sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 1 | // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 5 | #include "components/update_client/request_sender.h" |
| 6 | |
| 7 | #include <memory> |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame^] | 8 | #include <utility> |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 9 | |
sorin | 5cb1f549 | 2014-09-23 04:07:44 | [diff] [blame] | 10 | #include "base/macros.h" |
sorin | 519656c | 2017-04-28 22:39:34 | [diff] [blame] | 11 | #include "base/memory/ptr_util.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 12 | #include "base/memory/ref_counted.h" |
davidben | 74f6744 | 2016-10-01 01:45:22 | [diff] [blame] | 13 | #include "base/path_service.h" |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 14 | #include "base/run_loop.h" |
sorin | 1bc5eff | 2016-02-17 18:45:17 | [diff] [blame] | 15 | #include "base/strings/string_util.h" |
Francois Doray | ff8a645 | 2017-07-27 17:11:58 | [diff] [blame] | 16 | #include "base/test/scoped_task_environment.h" |
gab | 7966d31 | 2016-05-11 20:35:01 | [diff] [blame] | 17 | #include "base/threading/thread_task_runner_handle.h" |
sorin | b120440b | 2015-04-27 16:34:15 | [diff] [blame] | 18 | #include "components/update_client/test_configurator.h" |
| 19 | #include "components/update_client/url_request_post_interceptor.h" |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 20 | #include "net/url_request/url_fetcher.h" |
| 21 | #include "testing/gtest/include/gtest/gtest.h" |
| 22 | |
sorin | 52ac088 | 2015-01-24 01:15:00 | [diff] [blame] | 23 | namespace update_client { |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 24 | |
| 25 | namespace { |
| 26 | |
| 27 | const char kUrl1[] = "https://localhost2/path1"; |
| 28 | const char kUrl2[] = "https://localhost2/path2"; |
| 29 | const char kUrlPath1[] = "path1"; |
| 30 | const char kUrlPath2[] = "path2"; |
| 31 | |
sorin | 1bc5eff | 2016-02-17 18:45:17 | [diff] [blame] | 32 | // TODO(sorin): refactor as a utility function for unit tests. |
| 33 | base::FilePath test_file(const char* file) { |
| 34 | base::FilePath path; |
| 35 | PathService::Get(base::DIR_SOURCE_ROOT, &path); |
| 36 | return path.AppendASCII("components") |
| 37 | .AppendASCII("test") |
| 38 | .AppendASCII("data") |
| 39 | .AppendASCII("update_client") |
| 40 | .AppendASCII(file); |
| 41 | } |
| 42 | |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 43 | } // namespace |
| 44 | |
| 45 | class RequestSenderTest : public testing::Test { |
| 46 | public: |
| 47 | RequestSenderTest(); |
dcheng | 30a1b154 | 2014-10-29 21:27:50 | [diff] [blame] | 48 | ~RequestSenderTest() override; |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 49 | |
| 50 | // Overrides from testing::Test. |
dcheng | 30a1b154 | 2014-10-29 21:27:50 | [diff] [blame] | 51 | void SetUp() override; |
| 52 | void TearDown() override; |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 53 | |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 54 | void RequestSenderComplete(int error, |
| 55 | const std::string& response, |
| 56 | int retry_after_sec); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 57 | |
| 58 | protected: |
| 59 | void Quit(); |
| 60 | void RunThreads(); |
Francois Doray | ff8a645 | 2017-07-27 17:11:58 | [diff] [blame] | 61 | |
| 62 | base::test::ScopedTaskEnvironment scoped_task_environment_; |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 63 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 64 | scoped_refptr<TestConfigurator> config_; |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 65 | std::unique_ptr<RequestSender> request_sender_; |
| 66 | std::unique_ptr<InterceptorFactory> interceptor_factory_; |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 67 | |
sorin | 519656c | 2017-04-28 22:39:34 | [diff] [blame] | 68 | // Owned by the factory. |
| 69 | URLRequestPostInterceptor* post_interceptor_1_ = nullptr; |
| 70 | URLRequestPostInterceptor* post_interceptor_2_ = nullptr; |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 71 | |
sorin | 519656c | 2017-04-28 22:39:34 | [diff] [blame] | 72 | int error_ = 0; |
sorin | 1bc5eff | 2016-02-17 18:45:17 | [diff] [blame] | 73 | std::string response_; |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 74 | |
| 75 | private: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame^] | 76 | base::OnceClosure quit_closure_; |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 77 | |
| 78 | DISALLOW_COPY_AND_ASSIGN(RequestSenderTest); |
| 79 | }; |
| 80 | |
Francois Doray | ff8a645 | 2017-07-27 17:11:58 | [diff] [blame] | 81 | RequestSenderTest::RequestSenderTest() |
| 82 | : scoped_task_environment_( |
| 83 | base::test::ScopedTaskEnvironment::MainThreadType::IO) {} |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 84 | |
sorin | 1bc5eff | 2016-02-17 18:45:17 | [diff] [blame] | 85 | RequestSenderTest::~RequestSenderTest() {} |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 86 | |
| 87 | void RequestSenderTest::SetUp() { |
Sorin Jianu | cc048f89 | 2017-07-26 02:05:54 | [diff] [blame] | 88 | config_ = base::MakeRefCounted<TestConfigurator>(); |
sorin | 519656c | 2017-04-28 22:39:34 | [diff] [blame] | 89 | interceptor_factory_ = |
| 90 | base::MakeUnique<InterceptorFactory>(base::ThreadTaskRunnerHandle::Get()); |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 91 | post_interceptor_1_ = |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 92 | interceptor_factory_->CreateInterceptorForPath(kUrlPath1); |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 93 | post_interceptor_2_ = |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 94 | interceptor_factory_->CreateInterceptorForPath(kUrlPath2); |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 95 | EXPECT_TRUE(post_interceptor_1_); |
| 96 | EXPECT_TRUE(post_interceptor_2_); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 97 | |
sorin | 519656c | 2017-04-28 22:39:34 | [diff] [blame] | 98 | request_sender_ = nullptr; |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 99 | } |
| 100 | |
| 101 | void RequestSenderTest::TearDown() { |
sorin | 519656c | 2017-04-28 22:39:34 | [diff] [blame] | 102 | request_sender_ = nullptr; |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 103 | |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 104 | post_interceptor_1_ = nullptr; |
| 105 | post_interceptor_2_ = nullptr; |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 106 | |
sorin | 519656c | 2017-04-28 22:39:34 | [diff] [blame] | 107 | interceptor_factory_ = nullptr; |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 108 | |
Sorin Jianu | f805c22 | 2017-09-20 22:36:21 | [diff] [blame] | 109 | // Run the threads until they are idle to allow the clean up |
| 110 | // of the network interceptors on the IO thread. |
| 111 | scoped_task_environment_.RunUntilIdle(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 112 | config_ = nullptr; |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 113 | } |
| 114 | |
| 115 | void RequestSenderTest::RunThreads() { |
| 116 | base::RunLoop runloop; |
| 117 | quit_closure_ = runloop.QuitClosure(); |
| 118 | runloop.Run(); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 119 | } |
| 120 | |
| 121 | void RequestSenderTest::Quit() { |
| 122 | if (!quit_closure_.is_null()) |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame^] | 123 | std::move(quit_closure_).Run(); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 124 | } |
| 125 | |
sorin | 1bc5eff | 2016-02-17 18:45:17 | [diff] [blame] | 126 | void RequestSenderTest::RequestSenderComplete(int error, |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 127 | const std::string& response, |
| 128 | int retry_after_sec) { |
sorin | 1bc5eff | 2016-02-17 18:45:17 | [diff] [blame] | 129 | error_ = error; |
| 130 | response_ = response; |
| 131 | |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 132 | Quit(); |
| 133 | } |
| 134 | |
| 135 | // Tests that when a request to the first url succeeds, the subsequent urls are |
| 136 | // not tried. |
| 137 | TEST_F(RequestSenderTest, RequestSendSuccess) { |
sorin | 1bc5eff | 2016-02-17 18:45:17 | [diff] [blame] | 138 | EXPECT_TRUE(post_interceptor_1_->ExpectRequest( |
| 139 | new PartialMatch("test"), test_file("updatecheck_reply_1.xml"))); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 140 | |
sorin | 519656c | 2017-04-28 22:39:34 | [diff] [blame] | 141 | const std::vector<GURL> urls = {GURL(kUrl1), GURL(kUrl2)}; |
| 142 | request_sender_ = base::MakeUnique<RequestSender>(config_); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame^] | 143 | request_sender_->Send( |
| 144 | false, "test", urls, |
| 145 | base::BindOnce(&RequestSenderTest::RequestSenderComplete, |
| 146 | base::Unretained(this))); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 147 | RunThreads(); |
| 148 | |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 149 | EXPECT_EQ(1, post_interceptor_1_->GetHitCount()) |
| 150 | << post_interceptor_1_->GetRequestsAsString(); |
| 151 | EXPECT_EQ(1, post_interceptor_1_->GetCount()) |
| 152 | << post_interceptor_1_->GetRequestsAsString(); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 153 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 154 | EXPECT_EQ(0, post_interceptor_2_->GetHitCount()) |
| 155 | << post_interceptor_2_->GetRequestsAsString(); |
| 156 | EXPECT_EQ(0, post_interceptor_2_->GetCount()) |
| 157 | << post_interceptor_2_->GetRequestsAsString(); |
| 158 | |
sorin | 1bc5eff | 2016-02-17 18:45:17 | [diff] [blame] | 159 | // Sanity check the request. |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 160 | EXPECT_STREQ("test", post_interceptor_1_->GetRequests()[0].c_str()); |
sorin | 1bc5eff | 2016-02-17 18:45:17 | [diff] [blame] | 161 | |
| 162 | // Check the response post conditions. |
| 163 | EXPECT_EQ(0, error_); |
| 164 | EXPECT_TRUE(base::StartsWith(response_, |
| 165 | "<?xml version='1.0' encoding='UTF-8'?>", |
| 166 | base::CompareCase::SENSITIVE)); |
sorin | 519656c | 2017-04-28 22:39:34 | [diff] [blame] | 167 | EXPECT_EQ(505ul, response_.size()); |
Sorin Jianu | f805c22 | 2017-09-20 22:36:21 | [diff] [blame] | 168 | |
| 169 | interceptor_factory_ = nullptr; |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 170 | } |
| 171 | |
| 172 | // Tests that the request succeeds using the second url after the first url |
| 173 | // has failed. |
| 174 | TEST_F(RequestSenderTest, RequestSendSuccessWithFallback) { |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 175 | EXPECT_TRUE( |
| 176 | post_interceptor_1_->ExpectRequest(new PartialMatch("test"), 403)); |
| 177 | EXPECT_TRUE(post_interceptor_2_->ExpectRequest(new PartialMatch("test"))); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 178 | |
sorin | 519656c | 2017-04-28 22:39:34 | [diff] [blame] | 179 | const std::vector<GURL> urls = {GURL(kUrl1), GURL(kUrl2)}; |
| 180 | request_sender_ = base::MakeUnique<RequestSender>(config_); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame^] | 181 | request_sender_->Send( |
| 182 | false, "test", urls, |
| 183 | base::BindOnce(&RequestSenderTest::RequestSenderComplete, |
| 184 | base::Unretained(this))); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 185 | RunThreads(); |
| 186 | |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 187 | EXPECT_EQ(1, post_interceptor_1_->GetHitCount()) |
| 188 | << post_interceptor_1_->GetRequestsAsString(); |
| 189 | EXPECT_EQ(1, post_interceptor_1_->GetCount()) |
| 190 | << post_interceptor_1_->GetRequestsAsString(); |
| 191 | EXPECT_EQ(1, post_interceptor_2_->GetHitCount()) |
| 192 | << post_interceptor_2_->GetRequestsAsString(); |
| 193 | EXPECT_EQ(1, post_interceptor_2_->GetCount()) |
| 194 | << post_interceptor_2_->GetRequestsAsString(); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 195 | |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 196 | EXPECT_STREQ("test", post_interceptor_1_->GetRequests()[0].c_str()); |
| 197 | EXPECT_STREQ("test", post_interceptor_2_->GetRequests()[0].c_str()); |
sorin | 1bc5eff | 2016-02-17 18:45:17 | [diff] [blame] | 198 | EXPECT_EQ(0, error_); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 199 | } |
| 200 | |
| 201 | // Tests that the request fails when both urls have failed. |
| 202 | TEST_F(RequestSenderTest, RequestSendFailed) { |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 203 | EXPECT_TRUE( |
| 204 | post_interceptor_1_->ExpectRequest(new PartialMatch("test"), 403)); |
| 205 | EXPECT_TRUE( |
| 206 | post_interceptor_2_->ExpectRequest(new PartialMatch("test"), 403)); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 207 | |
sorin | 519656c | 2017-04-28 22:39:34 | [diff] [blame] | 208 | const std::vector<GURL> urls = {GURL(kUrl1), GURL(kUrl2)}; |
| 209 | request_sender_ = base::MakeUnique<RequestSender>(config_); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame^] | 210 | request_sender_->Send( |
| 211 | false, "test", urls, |
| 212 | base::BindOnce(&RequestSenderTest::RequestSenderComplete, |
| 213 | base::Unretained(this))); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 214 | RunThreads(); |
| 215 | |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 216 | EXPECT_EQ(1, post_interceptor_1_->GetHitCount()) |
| 217 | << post_interceptor_1_->GetRequestsAsString(); |
| 218 | EXPECT_EQ(1, post_interceptor_1_->GetCount()) |
| 219 | << post_interceptor_1_->GetRequestsAsString(); |
| 220 | EXPECT_EQ(1, post_interceptor_2_->GetHitCount()) |
| 221 | << post_interceptor_2_->GetRequestsAsString(); |
| 222 | EXPECT_EQ(1, post_interceptor_2_->GetCount()) |
| 223 | << post_interceptor_2_->GetRequestsAsString(); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 224 | |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 225 | EXPECT_STREQ("test", post_interceptor_1_->GetRequests()[0].c_str()); |
| 226 | EXPECT_STREQ("test", post_interceptor_2_->GetRequests()[0].c_str()); |
sorin | 1bc5eff | 2016-02-17 18:45:17 | [diff] [blame] | 227 | EXPECT_EQ(403, error_); |
sorin | 395c2ac | 2014-09-16 21:31:07 | [diff] [blame] | 228 | } |
| 229 | |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 230 | // Tests that the request fails when no urls are provided. |
| 231 | TEST_F(RequestSenderTest, RequestSendFailedNoUrls) { |
| 232 | std::vector<GURL> urls; |
sorin | 519656c | 2017-04-28 22:39:34 | [diff] [blame] | 233 | request_sender_ = base::MakeUnique<RequestSender>(config_); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame^] | 234 | request_sender_->Send( |
| 235 | false, "test", urls, |
| 236 | base::BindOnce(&RequestSenderTest::RequestSenderComplete, |
| 237 | base::Unretained(this))); |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 238 | RunThreads(); |
| 239 | |
sorin | 1bc5eff | 2016-02-17 18:45:17 | [diff] [blame] | 240 | EXPECT_EQ(-1, error_); |
| 241 | } |
| 242 | |
| 243 | // Tests that a CUP request fails if the response is not signed. |
| 244 | TEST_F(RequestSenderTest, RequestSendCupError) { |
| 245 | EXPECT_TRUE(post_interceptor_1_->ExpectRequest( |
| 246 | new PartialMatch("test"), test_file("updatecheck_reply_1.xml"))); |
| 247 | |
sorin | 519656c | 2017-04-28 22:39:34 | [diff] [blame] | 248 | const std::vector<GURL> urls = {GURL(kUrl1)}; |
| 249 | request_sender_ = base::MakeUnique<RequestSender>(config_); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame^] | 250 | request_sender_->Send( |
| 251 | true, "test", urls, |
| 252 | base::BindOnce(&RequestSenderTest::RequestSenderComplete, |
| 253 | base::Unretained(this))); |
sorin | 1bc5eff | 2016-02-17 18:45:17 | [diff] [blame] | 254 | RunThreads(); |
| 255 | |
| 256 | EXPECT_EQ(1, post_interceptor_1_->GetHitCount()) |
| 257 | << post_interceptor_1_->GetRequestsAsString(); |
| 258 | EXPECT_EQ(1, post_interceptor_1_->GetCount()) |
| 259 | << post_interceptor_1_->GetRequestsAsString(); |
| 260 | |
| 261 | EXPECT_STREQ("test", post_interceptor_1_->GetRequests()[0].c_str()); |
| 262 | EXPECT_EQ(RequestSender::kErrorResponseNotTrusted, error_); |
| 263 | EXPECT_TRUE(response_.empty()); |
sorin | 5cabcf0b | 2015-06-09 00:54:44 | [diff] [blame] | 264 | } |
| 265 | |
sorin | 52ac088 | 2015-01-24 01:15:00 | [diff] [blame] | 266 | } // namespace update_client |