blob: 4ed3d25cf6718ff3d2c8e6de8963b21b215f221b [file] [log] [blame]
sorin395c2ac2014-09-16 21:31:071// Copyright 2014 The Chromium Authors. All rights reserved.
2// Use of this source code is governed by a BSD-style license that can be
3// found in the LICENSE file.
4
dchengd0fc6aa92016-04-22 18:03:125#include "components/update_client/request_sender.h"
6
7#include <memory>
Sorin Jianua8ef73d2017-11-02 16:55:178#include <utility>
dchengd0fc6aa92016-04-22 18:03:129
sorin5cb1f5492014-09-23 04:07:4410#include "base/macros.h"
sorin519656c2017-04-28 22:39:3411#include "base/memory/ptr_util.h"
sorin9797aba2015-04-17 17:15:0312#include "base/memory/ref_counted.h"
davidben74f67442016-10-01 01:45:2213#include "base/path_service.h"
sorin395c2ac2014-09-16 21:31:0714#include "base/run_loop.h"
sorin1bc5eff2016-02-17 18:45:1715#include "base/strings/string_util.h"
Francois Dorayff8a6452017-07-27 17:11:5816#include "base/test/scoped_task_environment.h"
gab7966d312016-05-11 20:35:0117#include "base/threading/thread_task_runner_handle.h"
sorinb120440b2015-04-27 16:34:1518#include "components/update_client/test_configurator.h"
19#include "components/update_client/url_request_post_interceptor.h"
sorin395c2ac2014-09-16 21:31:0720#include "net/url_request/url_fetcher.h"
21#include "testing/gtest/include/gtest/gtest.h"
22
sorin52ac0882015-01-24 01:15:0023namespace update_client {
sorin395c2ac2014-09-16 21:31:0724
25namespace {
26
27const char kUrl1[] = "https://localhost2/path1";
28const char kUrl2[] = "https://localhost2/path2";
29const char kUrlPath1[] = "path1";
30const char kUrlPath2[] = "path2";
31
sorin1bc5eff2016-02-17 18:45:1732// TODO(sorin): refactor as a utility function for unit tests.
33base::FilePath test_file(const char* file) {
34 base::FilePath path;
35 PathService::Get(base::DIR_SOURCE_ROOT, &path);
36 return path.AppendASCII("components")
37 .AppendASCII("test")
38 .AppendASCII("data")
39 .AppendASCII("update_client")
40 .AppendASCII(file);
41}
42
sorin395c2ac2014-09-16 21:31:0743} // namespace
44
45class RequestSenderTest : public testing::Test {
46 public:
47 RequestSenderTest();
dcheng30a1b1542014-10-29 21:27:5048 ~RequestSenderTest() override;
sorin395c2ac2014-09-16 21:31:0749
50 // Overrides from testing::Test.
dcheng30a1b1542014-10-29 21:27:5051 void SetUp() override;
52 void TearDown() override;
sorin395c2ac2014-09-16 21:31:0753
sorinfccbf2d2016-04-04 20:34:3454 void RequestSenderComplete(int error,
55 const std::string& response,
56 int retry_after_sec);
sorin395c2ac2014-09-16 21:31:0757
58 protected:
59 void Quit();
60 void RunThreads();
Francois Dorayff8a6452017-07-27 17:11:5861
62 base::test::ScopedTaskEnvironment scoped_task_environment_;
sorin395c2ac2014-09-16 21:31:0763
sorin9797aba2015-04-17 17:15:0364 scoped_refptr<TestConfigurator> config_;
dchengd0fc6aa92016-04-22 18:03:1265 std::unique_ptr<RequestSender> request_sender_;
66 std::unique_ptr<InterceptorFactory> interceptor_factory_;
sorin395c2ac2014-09-16 21:31:0767
sorin519656c2017-04-28 22:39:3468 // Owned by the factory.
69 URLRequestPostInterceptor* post_interceptor_1_ = nullptr;
70 URLRequestPostInterceptor* post_interceptor_2_ = nullptr;
sorin395c2ac2014-09-16 21:31:0771
sorin519656c2017-04-28 22:39:3472 int error_ = 0;
sorin1bc5eff2016-02-17 18:45:1773 std::string response_;
sorin395c2ac2014-09-16 21:31:0774
75 private:
Sorin Jianua8ef73d2017-11-02 16:55:1776 base::OnceClosure quit_closure_;
sorin395c2ac2014-09-16 21:31:0777
78 DISALLOW_COPY_AND_ASSIGN(RequestSenderTest);
79};
80
Francois Dorayff8a6452017-07-27 17:11:5881RequestSenderTest::RequestSenderTest()
82 : scoped_task_environment_(
83 base::test::ScopedTaskEnvironment::MainThreadType::IO) {}
sorin395c2ac2014-09-16 21:31:0784
sorin1bc5eff2016-02-17 18:45:1785RequestSenderTest::~RequestSenderTest() {}
sorin395c2ac2014-09-16 21:31:0786
87void RequestSenderTest::SetUp() {
Sorin Jianucc048f892017-07-26 02:05:5488 config_ = base::MakeRefCounted<TestConfigurator>();
sorin519656c2017-04-28 22:39:3489 interceptor_factory_ =
90 base::MakeUnique<InterceptorFactory>(base::ThreadTaskRunnerHandle::Get());
sorin5cabcf0b2015-06-09 00:54:4491 post_interceptor_1_ =
sorin395c2ac2014-09-16 21:31:0792 interceptor_factory_->CreateInterceptorForPath(kUrlPath1);
sorin5cabcf0b2015-06-09 00:54:4493 post_interceptor_2_ =
sorin395c2ac2014-09-16 21:31:0794 interceptor_factory_->CreateInterceptorForPath(kUrlPath2);
sorin5cabcf0b2015-06-09 00:54:4495 EXPECT_TRUE(post_interceptor_1_);
96 EXPECT_TRUE(post_interceptor_2_);
sorin395c2ac2014-09-16 21:31:0797
sorin519656c2017-04-28 22:39:3498 request_sender_ = nullptr;
sorin395c2ac2014-09-16 21:31:0799}
100
101void RequestSenderTest::TearDown() {
sorin519656c2017-04-28 22:39:34102 request_sender_ = nullptr;
sorin395c2ac2014-09-16 21:31:07103
sorin5cabcf0b2015-06-09 00:54:44104 post_interceptor_1_ = nullptr;
105 post_interceptor_2_ = nullptr;
sorin395c2ac2014-09-16 21:31:07106
sorin519656c2017-04-28 22:39:34107 interceptor_factory_ = nullptr;
sorin395c2ac2014-09-16 21:31:07108
Sorin Jianuf805c222017-09-20 22:36:21109 // Run the threads until they are idle to allow the clean up
110 // of the network interceptors on the IO thread.
111 scoped_task_environment_.RunUntilIdle();
sorin9797aba2015-04-17 17:15:03112 config_ = nullptr;
sorin395c2ac2014-09-16 21:31:07113}
114
115void RequestSenderTest::RunThreads() {
116 base::RunLoop runloop;
117 quit_closure_ = runloop.QuitClosure();
118 runloop.Run();
sorin395c2ac2014-09-16 21:31:07119}
120
121void RequestSenderTest::Quit() {
122 if (!quit_closure_.is_null())
Sorin Jianua8ef73d2017-11-02 16:55:17123 std::move(quit_closure_).Run();
sorin395c2ac2014-09-16 21:31:07124}
125
sorin1bc5eff2016-02-17 18:45:17126void RequestSenderTest::RequestSenderComplete(int error,
sorinfccbf2d2016-04-04 20:34:34127 const std::string& response,
128 int retry_after_sec) {
sorin1bc5eff2016-02-17 18:45:17129 error_ = error;
130 response_ = response;
131
sorin395c2ac2014-09-16 21:31:07132 Quit();
133}
134
135// Tests that when a request to the first url succeeds, the subsequent urls are
136// not tried.
137TEST_F(RequestSenderTest, RequestSendSuccess) {
sorin1bc5eff2016-02-17 18:45:17138 EXPECT_TRUE(post_interceptor_1_->ExpectRequest(
139 new PartialMatch("test"), test_file("updatecheck_reply_1.xml")));
sorin395c2ac2014-09-16 21:31:07140
sorin519656c2017-04-28 22:39:34141 const std::vector<GURL> urls = {GURL(kUrl1), GURL(kUrl2)};
142 request_sender_ = base::MakeUnique<RequestSender>(config_);
Sorin Jianua8ef73d2017-11-02 16:55:17143 request_sender_->Send(
144 false, "test", urls,
145 base::BindOnce(&RequestSenderTest::RequestSenderComplete,
146 base::Unretained(this)));
sorin395c2ac2014-09-16 21:31:07147 RunThreads();
148
sorin5cabcf0b2015-06-09 00:54:44149 EXPECT_EQ(1, post_interceptor_1_->GetHitCount())
150 << post_interceptor_1_->GetRequestsAsString();
151 EXPECT_EQ(1, post_interceptor_1_->GetCount())
152 << post_interceptor_1_->GetRequestsAsString();
sorin395c2ac2014-09-16 21:31:07153
sorin30474f02017-04-27 00:45:48154 EXPECT_EQ(0, post_interceptor_2_->GetHitCount())
155 << post_interceptor_2_->GetRequestsAsString();
156 EXPECT_EQ(0, post_interceptor_2_->GetCount())
157 << post_interceptor_2_->GetRequestsAsString();
158
sorin1bc5eff2016-02-17 18:45:17159 // Sanity check the request.
sorin5cabcf0b2015-06-09 00:54:44160 EXPECT_STREQ("test", post_interceptor_1_->GetRequests()[0].c_str());
sorin1bc5eff2016-02-17 18:45:17161
162 // Check the response post conditions.
163 EXPECT_EQ(0, error_);
164 EXPECT_TRUE(base::StartsWith(response_,
165 "<?xml version='1.0' encoding='UTF-8'?>",
166 base::CompareCase::SENSITIVE));
sorin519656c2017-04-28 22:39:34167 EXPECT_EQ(505ul, response_.size());
Sorin Jianuf805c222017-09-20 22:36:21168
169 interceptor_factory_ = nullptr;
sorin395c2ac2014-09-16 21:31:07170}
171
172// Tests that the request succeeds using the second url after the first url
173// has failed.
174TEST_F(RequestSenderTest, RequestSendSuccessWithFallback) {
sorin5cabcf0b2015-06-09 00:54:44175 EXPECT_TRUE(
176 post_interceptor_1_->ExpectRequest(new PartialMatch("test"), 403));
177 EXPECT_TRUE(post_interceptor_2_->ExpectRequest(new PartialMatch("test")));
sorin395c2ac2014-09-16 21:31:07178
sorin519656c2017-04-28 22:39:34179 const std::vector<GURL> urls = {GURL(kUrl1), GURL(kUrl2)};
180 request_sender_ = base::MakeUnique<RequestSender>(config_);
Sorin Jianua8ef73d2017-11-02 16:55:17181 request_sender_->Send(
182 false, "test", urls,
183 base::BindOnce(&RequestSenderTest::RequestSenderComplete,
184 base::Unretained(this)));
sorin395c2ac2014-09-16 21:31:07185 RunThreads();
186
sorin5cabcf0b2015-06-09 00:54:44187 EXPECT_EQ(1, post_interceptor_1_->GetHitCount())
188 << post_interceptor_1_->GetRequestsAsString();
189 EXPECT_EQ(1, post_interceptor_1_->GetCount())
190 << post_interceptor_1_->GetRequestsAsString();
191 EXPECT_EQ(1, post_interceptor_2_->GetHitCount())
192 << post_interceptor_2_->GetRequestsAsString();
193 EXPECT_EQ(1, post_interceptor_2_->GetCount())
194 << post_interceptor_2_->GetRequestsAsString();
sorin395c2ac2014-09-16 21:31:07195
sorin5cabcf0b2015-06-09 00:54:44196 EXPECT_STREQ("test", post_interceptor_1_->GetRequests()[0].c_str());
197 EXPECT_STREQ("test", post_interceptor_2_->GetRequests()[0].c_str());
sorin1bc5eff2016-02-17 18:45:17198 EXPECT_EQ(0, error_);
sorin395c2ac2014-09-16 21:31:07199}
200
201// Tests that the request fails when both urls have failed.
202TEST_F(RequestSenderTest, RequestSendFailed) {
sorin5cabcf0b2015-06-09 00:54:44203 EXPECT_TRUE(
204 post_interceptor_1_->ExpectRequest(new PartialMatch("test"), 403));
205 EXPECT_TRUE(
206 post_interceptor_2_->ExpectRequest(new PartialMatch("test"), 403));
sorin395c2ac2014-09-16 21:31:07207
sorin519656c2017-04-28 22:39:34208 const std::vector<GURL> urls = {GURL(kUrl1), GURL(kUrl2)};
209 request_sender_ = base::MakeUnique<RequestSender>(config_);
Sorin Jianua8ef73d2017-11-02 16:55:17210 request_sender_->Send(
211 false, "test", urls,
212 base::BindOnce(&RequestSenderTest::RequestSenderComplete,
213 base::Unretained(this)));
sorin395c2ac2014-09-16 21:31:07214 RunThreads();
215
sorin5cabcf0b2015-06-09 00:54:44216 EXPECT_EQ(1, post_interceptor_1_->GetHitCount())
217 << post_interceptor_1_->GetRequestsAsString();
218 EXPECT_EQ(1, post_interceptor_1_->GetCount())
219 << post_interceptor_1_->GetRequestsAsString();
220 EXPECT_EQ(1, post_interceptor_2_->GetHitCount())
221 << post_interceptor_2_->GetRequestsAsString();
222 EXPECT_EQ(1, post_interceptor_2_->GetCount())
223 << post_interceptor_2_->GetRequestsAsString();
sorin395c2ac2014-09-16 21:31:07224
sorin5cabcf0b2015-06-09 00:54:44225 EXPECT_STREQ("test", post_interceptor_1_->GetRequests()[0].c_str());
226 EXPECT_STREQ("test", post_interceptor_2_->GetRequests()[0].c_str());
sorin1bc5eff2016-02-17 18:45:17227 EXPECT_EQ(403, error_);
sorin395c2ac2014-09-16 21:31:07228}
229
sorin5cabcf0b2015-06-09 00:54:44230// Tests that the request fails when no urls are provided.
231TEST_F(RequestSenderTest, RequestSendFailedNoUrls) {
232 std::vector<GURL> urls;
sorin519656c2017-04-28 22:39:34233 request_sender_ = base::MakeUnique<RequestSender>(config_);
Sorin Jianua8ef73d2017-11-02 16:55:17234 request_sender_->Send(
235 false, "test", urls,
236 base::BindOnce(&RequestSenderTest::RequestSenderComplete,
237 base::Unretained(this)));
sorin5cabcf0b2015-06-09 00:54:44238 RunThreads();
239
sorin1bc5eff2016-02-17 18:45:17240 EXPECT_EQ(-1, error_);
241}
242
243// Tests that a CUP request fails if the response is not signed.
244TEST_F(RequestSenderTest, RequestSendCupError) {
245 EXPECT_TRUE(post_interceptor_1_->ExpectRequest(
246 new PartialMatch("test"), test_file("updatecheck_reply_1.xml")));
247
sorin519656c2017-04-28 22:39:34248 const std::vector<GURL> urls = {GURL(kUrl1)};
249 request_sender_ = base::MakeUnique<RequestSender>(config_);
Sorin Jianua8ef73d2017-11-02 16:55:17250 request_sender_->Send(
251 true, "test", urls,
252 base::BindOnce(&RequestSenderTest::RequestSenderComplete,
253 base::Unretained(this)));
sorin1bc5eff2016-02-17 18:45:17254 RunThreads();
255
256 EXPECT_EQ(1, post_interceptor_1_->GetHitCount())
257 << post_interceptor_1_->GetRequestsAsString();
258 EXPECT_EQ(1, post_interceptor_1_->GetCount())
259 << post_interceptor_1_->GetRequestsAsString();
260
261 EXPECT_STREQ("test", post_interceptor_1_->GetRequests()[0].c_str());
262 EXPECT_EQ(RequestSender::kErrorResponseNotTrusted, error_);
263 EXPECT_TRUE(response_.empty());
sorin5cabcf0b2015-06-09 00:54:44264}
265
sorin52ac0882015-01-24 01:15:00266} // namespace update_client