blob: b46664a6d7e21f28cc6cf95bf96465720f0aae9d [file] [log] [blame] [view]
Elly Fong-Jonesbbc92062019-05-29 15:38:031# Chromium Sheriffing
2
Elly Fong-Jonesbbc92062019-05-29 15:38:033Sheriffs have one overarching role: to ensure that the Chromium build
4infrastructure is doing its job of helping developers deliver good software.
5Every other sheriff responsibility flows from that one. In priority order,
6sheriffs need to ensure that:
7
81. **The tree is open**, because when the tree is closed nobody can make
9 progress;
102. **New test failures are not introduced**, because they weaken our assurance
11 that we're shipping good code;
123. **Existing test failures are repaired**, for the same reason
13
14As the sheriff, you not only have those responsibilities, but you have any
15necessary authority to fulfill them. In particular, you have the authority to:
16
17* Revert changes that you know or suspect are causing breakages
18* Disable or otherwise mark misbehaving tests
Jason Clinton0daf7b02021-02-09 20:36:2219* Use Owners-Override label to override OWNERS checks freely as part of your
20 sheriffing duties
Elly Fong-Jonesbbc92062019-05-29 15:38:0321* Pull in any other engineer or team you need to help you do these duties
Jason Clinton0daf7b02021-02-09 20:36:2222* For clean reverts and cherry-picks, add the
23 [Rubber Stamper bot](code_reviews.md#automated-code_review). All other
24 changes require a +1 from another committer.
25
26TBRs were removed in Q1 2021.
Elly Fong-Jonesbbc92062019-05-29 15:38:0327
Eric Fooda089b52021-08-03 16:25:5228For more information on Chromium Trunk Sheriffs, including How Tos, Swapping
29Shifts and rotation updates, please see [Chromium Trunk Sheriffing](http://goto.google.com/chrome-trunk-sheriffing)
30
Joey Scarr9ded41f2020-07-01 04:23:2931## How to be a Sheriff
Elly Fong-Jonesbbc92062019-05-29 15:38:0332
Joey Scarr9ded41f2020-07-01 04:23:2933To be a sheriff, you must be both a Chromium committer and a Google employee.
34For more detailed sheriffing instructions, please see the internal documentation
35at
36[go/chrome-sheriffing-how-to](https://goto.google.com/chrome-sheriffing-how-to).
Joey Scarr223c9dc2020-07-09 16:39:2437
38## Contacting the Sheriffs
39
40The currently oncall sheriffs can be viewed in the top-left corner of the
41[Chromium Main Console](https://ci.chromium.org/p/chromium/g/main/console). You
42can also get in touch with sheriffs using the
43[#sheriffing Slack channel](https://chromium.slack.com/messages/CGJ5WKRUH/).
Devlin Cronincaddfe0f2021-09-15 17:01:3844
45## Please don't pass bugs back to the sheriff that assigned them to you
46As part of their role, sheriffs will triage open test failures and flakes. If
47possible, they will identify a culprit CL and revert it; however, sometimes this
48is not feasible. In that case, sheriffs will assign these bugs to appropriate
49owners. They typically do this by looking for:
50
511. The test author, or last person to make significant changes, or
522. A proximal OWNER of the test
53
54_Pro-tip: Sheriffs, identify yourself in your comments, e.g., "[Sheriff]
55assigning to the test author for further triage."_
56
57If you are assigned a bug by a sheriff, please don't pass the bug back to that
58person. Sheriffs have likely never seen the code before (or since), and are
59unlikely to be much help. Additionally, if >8 hours have passed, that person is
60no longer sheriff, and thus no longer responsible for triaging these bugs.
61
62Instead, if you aren't the best owner for the bug, please help to triage it
63more appropriately, since you're probably the test author, familiar with the
64test, or an OWNER. If have no idea who a good owner for the test is (or were
65assigned the bug in error\*), you can reapply the `Sheriff-Chromium` label and
66flip the status to `Untriaged`; this will put it back in the sheriff queue for
67the next sheriff to take a look at. Please only do this as a last resort, since
68the next sheriff is unlikely to have any more information about the issue.
69
70\*If you believe you were assigned the bug in error, it might be worth finding
71out why the sheriff passed it to you, and remedying it if possible - e.g. by
72updating OWNERS files.