[email protected] | a33347c | 2012-01-09 18:27:01 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
[email protected] | 212d149 | 2008-09-05 19:38:54 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5 | #include "net/dns/host_resolver_manager.h" |
[email protected] | 212d149 | 2008-09-05 19:38:54 | [diff] [blame] | 6 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 7 | #include <algorithm> |
Eric Roman | 21b3923 | 2019-06-28 21:28:21 | [diff] [blame] | 8 | #include <limits> |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 9 | #include <string> |
jsbell | cea42a5 | 2015-11-30 23:50:25 | [diff] [blame] | 10 | #include <tuple> |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 11 | #include <utility> |
olli.raula | 9cdf9d7 | 2015-12-10 14:24:29 | [diff] [blame] | 12 | #include <vector> |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 13 | |
Wez | a03bae0 | 2018-07-13 17:17:33 | [diff] [blame] | 14 | #include "base/auto_reset.h" |
[email protected] | aa22b24 | 2011-11-16 18:58:29 | [diff] [blame] | 15 | #include "base/bind.h" |
| 16 | #include "base/bind_helpers.h" |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 17 | #include "base/location.h" |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 18 | #include "base/macros.h" |
[email protected] | 3b63f8f4 | 2011-03-28 01:54:15 | [diff] [blame] | 19 | #include "base/memory/ref_counted.h" |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 20 | #include "base/run_loop.h" |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 21 | #include "base/single_thread_task_runner.h" |
tripta.g | dda7202 | 2017-06-19 05:16:23 | [diff] [blame] | 22 | #include "base/stl_util.h" |
[email protected] | be528af | 2013-06-11 07:39:48 | [diff] [blame] | 23 | #include "base/strings/string_util.h" |
| 24 | #include "base/strings/stringprintf.h" |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 25 | #include "base/synchronization/condition_variable.h" |
| 26 | #include "base/synchronization/lock.h" |
Eric Roman | 21b3923 | 2019-06-28 21:28:21 | [diff] [blame] | 27 | #include "base/task/thread_pool/thread_pool.h" |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 28 | #include "base/test/bind_test_util.h" |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 29 | #include "base/test/simple_test_clock.h" |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 30 | #include "base/test/test_mock_time_task_runner.h" |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 31 | #include "base/test/test_timeouts.h" |
Francois Doray | a2d01ba | 2017-09-25 19:17:40 | [diff] [blame] | 32 | #include "base/threading/thread_restrictions.h" |
gab | f767595f | 2016-05-11 18:50:35 | [diff] [blame] | 33 | #include "base/threading/thread_task_runner_handle.h" |
[email protected] | 66e96c4 | 2013-06-28 15:20:31 | [diff] [blame] | 34 | #include "base/time/time.h" |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 35 | #include "base/timer/mock_timer.h" |
Miriam Gershenson | 48857a35 | 2018-03-22 21:14:03 | [diff] [blame] | 36 | #include "base/values.h" |
jdoerrie | dfede5ad | 2019-02-11 13:06:57 | [diff] [blame] | 37 | #include "build/build_config.h" |
[email protected] | ecfa71c | 2008-09-09 13:28:36 | [diff] [blame] | 38 | #include "net/base/address_list.h" |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 39 | #include "net/base/host_port_pair.h" |
martijn | a23c896 | 2016-03-04 18:18:51 | [diff] [blame] | 40 | #include "net/base/ip_address.h" |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 41 | #include "net/base/ip_endpoint.h" |
mgersh | af9a923 | 2017-04-13 20:19:03 | [diff] [blame] | 42 | #include "net/base/mock_network_change_notifier.h" |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 43 | #include "net/base/net_errors.h" |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 44 | #include "net/dns/dns_client.h" |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 45 | #include "net/dns/dns_config.h" |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 46 | #include "net/dns/dns_test_util.h" |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 47 | #include "net/dns/dns_util.h" |
[email protected] | f2cb3cf | 2013-03-21 01:40:53 | [diff] [blame] | 48 | #include "net/dns/mock_host_resolver.h" |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 49 | #include "net/dns/mock_mdns_client.h" |
| 50 | #include "net/dns/mock_mdns_socket_factory.h" |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 51 | #include "net/log/net_log_event_type.h" |
| 52 | #include "net/log/net_log_source_type.h" |
mikecirone | f22f981 | 2016-10-04 03:40:19 | [diff] [blame] | 53 | #include "net/log/net_log_with_source.h" |
sergeyu | b8cdc21 | 2015-05-14 18:50:37 | [diff] [blame] | 54 | #include "net/log/test_net_log.h" |
Eric Roman | 79cc755 | 2019-07-19 02:17:54 | [diff] [blame] | 55 | #include "net/log/test_net_log_util.h" |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 56 | #include "net/test/gtest_util.h" |
Bence Béky | 98447b1 | 2018-05-08 03:14:01 | [diff] [blame] | 57 | #include "net/test/test_with_scoped_task_environment.h" |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 58 | #include "net/url_request/url_request_context.h" |
| 59 | #include "net/url_request/url_request_test_util.h" |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 60 | #include "testing/gmock/include/gmock/gmock.h" |
[email protected] | ecfa71c | 2008-09-09 13:28:36 | [diff] [blame] | 61 | #include "testing/gtest/include/gtest/gtest.h" |
[email protected] | 212d149 | 2008-09-05 19:38:54 | [diff] [blame] | 62 | |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 63 | #if BUILDFLAG(ENABLE_MDNS) |
| 64 | #include "net/dns/mdns_client_impl.h" |
| 65 | #endif // BUILDFLAG(ENABLE_MDNS) |
| 66 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 67 | using net::test::IsError; |
| 68 | using net::test::IsOk; |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 69 | using ::testing::_; |
| 70 | using ::testing::Between; |
| 71 | using ::testing::ByMove; |
Rob Percival | 94f21ad | 2017-11-14 10:20:24 | [diff] [blame] | 72 | using ::testing::NotNull; |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 73 | using ::testing::Return; |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 74 | |
[email protected] | 259aefa | 2009-08-20 22:45:00 | [diff] [blame] | 75 | namespace net { |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 76 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 77 | namespace { |
[email protected] | 112bd46 | 2009-12-10 07:23:40 | [diff] [blame] | 78 | |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 79 | const size_t kMaxJobs = 10u; |
| 80 | const size_t kMaxRetryAttempts = 4u; |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 81 | |
Eric Orth | 5906622 | 2019-03-07 23:52:27 | [diff] [blame] | 82 | ProcTaskParams DefaultParams(HostResolverProc* resolver_proc) { |
| 83 | return ProcTaskParams(resolver_proc, kMaxRetryAttempts); |
[email protected] | 0f292de0 | 2012-02-01 22:28:20 | [diff] [blame] | 84 | } |
| 85 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 86 | // A HostResolverProc that pushes each host mapped into a list and allows |
| 87 | // waiting for a specific number of requests. Unlike RuleBasedHostResolverProc |
[email protected] | 1ee9afa1 | 2013-04-16 14:18:06 | [diff] [blame] | 88 | // it never calls SystemHostResolverCall. By default resolves all hostnames to |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 89 | // "127.0.0.1". After AddRule(), it resolves only names explicitly specified. |
| 90 | class MockHostResolverProc : public HostResolverProc { |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 91 | public: |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 92 | struct ResolveKey { |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 93 | ResolveKey(const std::string& hostname, |
| 94 | AddressFamily address_family, |
| 95 | HostResolverFlags flags) |
| 96 | : hostname(hostname), address_family(address_family), flags(flags) {} |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 97 | bool operator<(const ResolveKey& other) const { |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 98 | return std::tie(address_family, hostname, flags) < |
| 99 | std::tie(other.address_family, other.hostname, other.flags); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 100 | } |
[email protected] | 137af62 | 2010-02-05 02:14:35 | [diff] [blame] | 101 | std::string hostname; |
| 102 | AddressFamily address_family; |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 103 | HostResolverFlags flags; |
[email protected] | 137af62 | 2010-02-05 02:14:35 | [diff] [blame] | 104 | }; |
| 105 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 106 | typedef std::vector<ResolveKey> CaptureList; |
[email protected] | 137af62 | 2010-02-05 02:14:35 | [diff] [blame] | 107 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 108 | MockHostResolverProc() |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 109 | : HostResolverProc(nullptr), |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 110 | num_requests_waiting_(0), |
| 111 | num_slots_available_(0), |
| 112 | requests_waiting_(&lock_), |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 113 | slots_available_(&lock_) {} |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 114 | |
| 115 | // Waits until |count| calls to |Resolve| are blocked. Returns false when |
| 116 | // timed out. |
| 117 | bool WaitFor(unsigned count) { |
| 118 | base::AutoLock lock(lock_); |
| 119 | base::Time start_time = base::Time::Now(); |
| 120 | while (num_requests_waiting_ < count) { |
| 121 | requests_waiting_.TimedWait(TestTimeouts::action_timeout()); |
| 122 | if (base::Time::Now() > start_time + TestTimeouts::action_timeout()) |
| 123 | return false; |
| 124 | } |
| 125 | return true; |
| 126 | } |
| 127 | |
| 128 | // Signals |count| waiting calls to |Resolve|. First come first served. |
| 129 | void SignalMultiple(unsigned count) { |
| 130 | base::AutoLock lock(lock_); |
| 131 | num_slots_available_ += count; |
| 132 | slots_available_.Broadcast(); |
| 133 | } |
| 134 | |
| 135 | // Signals all waiting calls to |Resolve|. Beware of races. |
| 136 | void SignalAll() { |
| 137 | base::AutoLock lock(lock_); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 138 | num_slots_available_ = num_requests_waiting_; |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 139 | slots_available_.Broadcast(); |
| 140 | } |
| 141 | |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 142 | void AddRule(const std::string& hostname, |
| 143 | AddressFamily family, |
| 144 | const AddressList& result, |
| 145 | HostResolverFlags flags = 0) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 146 | base::AutoLock lock(lock_); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 147 | rules_[ResolveKey(hostname, family, flags)] = result; |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 148 | } |
| 149 | |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 150 | void AddRule(const std::string& hostname, |
| 151 | AddressFamily family, |
| 152 | const std::string& ip_list, |
| 153 | HostResolverFlags flags = 0, |
| 154 | const std::string& canonical_name = "") { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 155 | AddressList result; |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 156 | int rv = ParseAddressList(ip_list, canonical_name, &result); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 157 | DCHECK_EQ(OK, rv); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 158 | AddRule(hostname, family, result, flags); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 159 | } |
[email protected] | 57a48d3 | 2012-03-03 00:04:55 | [diff] [blame] | 160 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 161 | void AddRuleForAllFamilies(const std::string& hostname, |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 162 | const std::string& ip_list, |
| 163 | HostResolverFlags flags = 0, |
| 164 | const std::string& canonical_name = "") { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 165 | AddressList result; |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 166 | int rv = ParseAddressList(ip_list, canonical_name, &result); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 167 | DCHECK_EQ(OK, rv); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 168 | AddRule(hostname, ADDRESS_FAMILY_UNSPECIFIED, result, flags); |
| 169 | AddRule(hostname, ADDRESS_FAMILY_IPV4, result, flags); |
| 170 | AddRule(hostname, ADDRESS_FAMILY_IPV6, result, flags); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 171 | } |
[email protected] | 137af62 | 2010-02-05 02:14:35 | [diff] [blame] | 172 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 173 | int Resolve(const std::string& hostname, |
| 174 | AddressFamily address_family, |
| 175 | HostResolverFlags host_resolver_flags, |
| 176 | AddressList* addrlist, |
| 177 | int* os_error) override { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 178 | base::AutoLock lock(lock_); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 179 | capture_list_.push_back( |
| 180 | ResolveKey(hostname, address_family, host_resolver_flags)); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 181 | ++num_requests_waiting_; |
| 182 | requests_waiting_.Broadcast(); |
Francois Doray | a2d01ba | 2017-09-25 19:17:40 | [diff] [blame] | 183 | { |
| 184 | base::ScopedAllowBaseSyncPrimitivesForTesting |
| 185 | scoped_allow_base_sync_primitives; |
| 186 | while (!num_slots_available_) |
| 187 | slots_available_.Wait(); |
| 188 | } |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 189 | DCHECK_GT(num_requests_waiting_, 0u); |
| 190 | --num_slots_available_; |
| 191 | --num_requests_waiting_; |
| 192 | if (rules_.empty()) { |
[email protected] | 007b3f8 | 2013-04-09 08:46:45 | [diff] [blame] | 193 | int rv = ParseAddressList("127.0.0.1", std::string(), addrlist); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 194 | DCHECK_EQ(OK, rv); |
| 195 | return OK; |
| 196 | } |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 197 | // Ignore HOST_RESOLVER_SYSTEM_ONLY, since it should have no impact on |
| 198 | // whether a rule matches. It should only affect cache lookups. |
| 199 | ResolveKey key(hostname, address_family, |
| 200 | host_resolver_flags & ~HOST_RESOLVER_SYSTEM_ONLY); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 201 | if (rules_.count(key) == 0) |
| 202 | return ERR_NAME_NOT_RESOLVED; |
| 203 | *addrlist = rules_[key]; |
| 204 | return OK; |
[email protected] | 137af62 | 2010-02-05 02:14:35 | [diff] [blame] | 205 | } |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 206 | |
| 207 | CaptureList GetCaptureList() const { |
| 208 | CaptureList copy; |
| 209 | { |
| 210 | base::AutoLock lock(lock_); |
| 211 | copy = capture_list_; |
| 212 | } |
| 213 | return copy; |
| 214 | } |
| 215 | |
| 216 | bool HasBlockedRequests() const { |
| 217 | base::AutoLock lock(lock_); |
| 218 | return num_requests_waiting_ > num_slots_available_; |
| 219 | } |
| 220 | |
[email protected] | a981330 | 2012-04-28 09:29:28 | [diff] [blame] | 221 | protected: |
Chris Watkins | 68b1503 | 2017-12-01 03:07:13 | [diff] [blame] | 222 | ~MockHostResolverProc() override = default; |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 223 | |
[email protected] | a981330 | 2012-04-28 09:29:28 | [diff] [blame] | 224 | private: |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 225 | mutable base::Lock lock_; |
| 226 | std::map<ResolveKey, AddressList> rules_; |
| 227 | CaptureList capture_list_; |
| 228 | unsigned num_requests_waiting_; |
| 229 | unsigned num_slots_available_; |
| 230 | base::ConditionVariable requests_waiting_; |
| 231 | base::ConditionVariable slots_available_; |
| 232 | |
| 233 | DISALLOW_COPY_AND_ASSIGN(MockHostResolverProc); |
| 234 | }; |
| 235 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 236 | class ResolveHostResponseHelper { |
| 237 | public: |
| 238 | using Callback = |
| 239 | base::OnceCallback<void(CompletionOnceCallback completion_callback, |
| 240 | int error)>; |
| 241 | |
| 242 | ResolveHostResponseHelper() {} |
| 243 | explicit ResolveHostResponseHelper( |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 244 | std::unique_ptr<HostResolverManager::CancellableRequest> request) |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 245 | : request_(std::move(request)) { |
| 246 | result_error_ = request_->Start(base::BindOnce( |
| 247 | &ResolveHostResponseHelper::OnComplete, base::Unretained(this))); |
| 248 | } |
| 249 | ResolveHostResponseHelper( |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 250 | std::unique_ptr<HostResolverManager::CancellableRequest> request, |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 251 | Callback custom_callback) |
| 252 | : request_(std::move(request)) { |
| 253 | result_error_ = request_->Start( |
| 254 | base::BindOnce(std::move(custom_callback), |
| 255 | base::BindOnce(&ResolveHostResponseHelper::OnComplete, |
| 256 | base::Unretained(this)))); |
| 257 | } |
| 258 | |
| 259 | bool complete() const { return result_error_ != ERR_IO_PENDING; } |
| 260 | int result_error() { |
| 261 | WaitForCompletion(); |
| 262 | return result_error_; |
| 263 | } |
| 264 | |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 265 | HostResolverManager::CancellableRequest* request() { return request_.get(); } |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 266 | |
| 267 | void CancelRequest() { |
| 268 | DCHECK(request_); |
| 269 | DCHECK(!complete()); |
| 270 | |
| 271 | request_ = nullptr; |
| 272 | } |
| 273 | |
| 274 | void OnComplete(int error) { |
| 275 | DCHECK(!complete()); |
| 276 | result_error_ = error; |
| 277 | |
| 278 | run_loop_.Quit(); |
| 279 | } |
| 280 | |
| 281 | private: |
| 282 | void WaitForCompletion() { |
| 283 | DCHECK(request_); |
| 284 | if (complete()) { |
| 285 | return; |
| 286 | } |
| 287 | run_loop_.Run(); |
| 288 | DCHECK(complete()); |
| 289 | } |
| 290 | |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 291 | std::unique_ptr<HostResolverManager::CancellableRequest> request_; |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 292 | int result_error_ = ERR_IO_PENDING; |
| 293 | base::RunLoop run_loop_; |
| 294 | |
| 295 | DISALLOW_COPY_AND_ASSIGN(ResolveHostResponseHelper); |
| 296 | }; |
| 297 | |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 298 | // Using LookupAttemptHostResolverProc simulate very long lookups, and control |
| 299 | // which attempt resolves the host. |
| 300 | class LookupAttemptHostResolverProc : public HostResolverProc { |
| 301 | public: |
| 302 | LookupAttemptHostResolverProc(HostResolverProc* previous, |
| 303 | int attempt_number_to_resolve, |
| 304 | int total_attempts) |
| 305 | : HostResolverProc(previous), |
| 306 | attempt_number_to_resolve_(attempt_number_to_resolve), |
| 307 | current_attempt_number_(0), |
| 308 | total_attempts_(total_attempts), |
| 309 | total_attempts_resolved_(0), |
| 310 | resolved_attempt_number_(0), |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 311 | num_attempts_waiting_(0), |
| 312 | all_done_(&lock_), |
| 313 | blocked_attempt_signal_(&lock_) {} |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 314 | |
| 315 | // Test harness will wait for all attempts to finish before checking the |
| 316 | // results. |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 317 | void WaitForAllAttemptsToFinish() { |
| 318 | base::AutoLock auto_lock(lock_); |
| 319 | while (total_attempts_resolved_ != total_attempts_) { |
| 320 | all_done_.Wait(); |
| 321 | } |
| 322 | } |
| 323 | |
| 324 | void WaitForNAttemptsToBeBlocked(int n) { |
| 325 | base::AutoLock auto_lock(lock_); |
| 326 | while (num_attempts_waiting_ < n) { |
| 327 | blocked_attempt_signal_.Wait(); |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 328 | } |
| 329 | } |
| 330 | |
| 331 | // All attempts will wait for an attempt to resolve the host. |
| 332 | void WaitForAnAttemptToComplete() { |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 333 | { |
| 334 | base::AutoLock auto_lock(lock_); |
Francois Doray | a2d01ba | 2017-09-25 19:17:40 | [diff] [blame] | 335 | base::ScopedAllowBaseSyncPrimitivesForTesting |
| 336 | scoped_allow_base_sync_primitives; |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 337 | while (resolved_attempt_number_ == 0) |
| 338 | all_done_.Wait(); |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 339 | } |
| 340 | all_done_.Broadcast(); // Tell all waiting attempts to proceed. |
| 341 | } |
| 342 | |
| 343 | // Returns the number of attempts that have finished the Resolve() method. |
Eric Roman | 21b3923 | 2019-06-28 21:28:21 | [diff] [blame] | 344 | int GetTotalAttemptsResolved() { |
| 345 | base::AutoLock auto_lock(lock_); |
| 346 | return total_attempts_resolved_; |
| 347 | } |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 348 | |
Eric Roman | 21b3923 | 2019-06-28 21:28:21 | [diff] [blame] | 349 | // Sets the resolved attempt number and unblocks waiting |
| 350 | // attempts. |
| 351 | void SetResolvedAttemptNumber(int n) { |
| 352 | base::AutoLock auto_lock(lock_); |
| 353 | EXPECT_EQ(0, resolved_attempt_number_); |
| 354 | resolved_attempt_number_ = n; |
| 355 | all_done_.Broadcast(); |
| 356 | } |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 357 | |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 358 | // HostResolverProc methods. |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 359 | int Resolve(const std::string& host, |
| 360 | AddressFamily address_family, |
| 361 | HostResolverFlags host_resolver_flags, |
| 362 | AddressList* addrlist, |
| 363 | int* os_error) override { |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 364 | bool wait_for_right_attempt_to_complete = true; |
| 365 | { |
| 366 | base::AutoLock auto_lock(lock_); |
| 367 | ++current_attempt_number_; |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 368 | ++num_attempts_waiting_; |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 369 | if (current_attempt_number_ == attempt_number_to_resolve_) { |
| 370 | resolved_attempt_number_ = current_attempt_number_; |
| 371 | wait_for_right_attempt_to_complete = false; |
| 372 | } |
| 373 | } |
| 374 | |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 375 | blocked_attempt_signal_.Broadcast(); |
| 376 | |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 377 | if (wait_for_right_attempt_to_complete) |
| 378 | // Wait for the attempt_number_to_resolve_ attempt to resolve. |
| 379 | WaitForAnAttemptToComplete(); |
| 380 | |
| 381 | int result = ResolveUsingPrevious(host, address_family, host_resolver_flags, |
| 382 | addrlist, os_error); |
| 383 | |
| 384 | { |
| 385 | base::AutoLock auto_lock(lock_); |
| 386 | ++total_attempts_resolved_; |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 387 | --num_attempts_waiting_; |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 388 | } |
| 389 | |
| 390 | all_done_.Broadcast(); // Tell all attempts to proceed. |
| 391 | |
| 392 | // Since any negative number is considered a network error, with -1 having |
| 393 | // special meaning (ERR_IO_PENDING). We could return the attempt that has |
| 394 | // resolved the host as a negative number. For example, if attempt number 3 |
| 395 | // resolves the host, then this method returns -4. |
| 396 | if (result == OK) |
| 397 | return -1 - resolved_attempt_number_; |
| 398 | else |
| 399 | return result; |
| 400 | } |
| 401 | |
[email protected] | a981330 | 2012-04-28 09:29:28 | [diff] [blame] | 402 | protected: |
Chris Watkins | 68b1503 | 2017-12-01 03:07:13 | [diff] [blame] | 403 | ~LookupAttemptHostResolverProc() override = default; |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 404 | |
[email protected] | a981330 | 2012-04-28 09:29:28 | [diff] [blame] | 405 | private: |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 406 | int attempt_number_to_resolve_; |
| 407 | int current_attempt_number_; // Incremented whenever Resolve is called. |
| 408 | int total_attempts_; |
| 409 | int total_attempts_resolved_; |
| 410 | int resolved_attempt_number_; |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 411 | int num_attempts_waiting_; |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 412 | |
| 413 | // All attempts wait for right attempt to be resolve. |
| 414 | base::Lock lock_; |
| 415 | base::ConditionVariable all_done_; |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 416 | base::ConditionVariable blocked_attempt_signal_; |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 417 | }; |
| 418 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 419 | // TestHostResolverManager's sole purpose is to mock the IPv6 reachability test. |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 420 | // By default, this pretends that IPv6 is globally reachable. |
| 421 | // This class is necessary so unit tests run the same on dual-stack machines as |
| 422 | // well as IPv4 only machines. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 423 | class TestHostResolverManager : public HostResolverManager { |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 424 | public: |
Eric Orth | 4d635c1 | 2019-04-24 22:53:04 | [diff] [blame] | 425 | TestHostResolverManager(const HostResolver::ManagerOptions& options, |
| 426 | NetLog* net_log) |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 427 | : TestHostResolverManager(options, net_log, true) {} |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 428 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 429 | TestHostResolverManager(const HostResolver::ManagerOptions& options, |
| 430 | NetLog* net_log, |
| 431 | bool ipv6_reachable) |
| 432 | : HostResolverManager(options, net_log), |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 433 | ipv6_reachable_(ipv6_reachable) {} |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 434 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 435 | ~TestHostResolverManager() override = default; |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 436 | |
| 437 | private: |
| 438 | const bool ipv6_reachable_; |
| 439 | |
mgersh | af9a923 | 2017-04-13 20:19:03 | [diff] [blame] | 440 | bool IsGloballyReachable(const IPAddress& dest, |
| 441 | const NetLogWithSource& net_log) override { |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 442 | return ipv6_reachable_; |
| 443 | } |
| 444 | }; |
| 445 | |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 446 | bool HasAddress(const IPAddress& search_address, const AddressList& addresses) { |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 447 | for (const auto& address : addresses) { |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 448 | if (search_address == address.address()) |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 449 | return true; |
| 450 | } |
| 451 | return false; |
| 452 | } |
| 453 | |
| 454 | void TestBothLoopbackIPs(const std::string& host) { |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 455 | AddressList addresses; |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 456 | EXPECT_TRUE(ResolveLocalHostname(host, &addresses)); |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 457 | EXPECT_EQ(2u, addresses.size()); |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 458 | EXPECT_TRUE(HasAddress(IPAddress::IPv4Localhost(), addresses)); |
| 459 | EXPECT_TRUE(HasAddress(IPAddress::IPv6Localhost(), addresses)); |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 460 | } |
| 461 | |
| 462 | void TestIPv6LoopbackOnly(const std::string& host) { |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 463 | AddressList addresses; |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 464 | EXPECT_TRUE(ResolveLocalHostname(host, &addresses)); |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 465 | EXPECT_EQ(1u, addresses.size()); |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 466 | EXPECT_TRUE(HasAddress(IPAddress::IPv6Localhost(), addresses)); |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 467 | } |
| 468 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 469 | } // namespace |
[email protected] | 8a00f00a | 2009-06-12 00:49:38 | [diff] [blame] | 470 | |
Gabriel Charette | 694c3c33 | 2019-08-19 14:53:05 | [diff] [blame] | 471 | class HostResolverManagerTest : public TestWithTaskEnvironment { |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 472 | public: |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 473 | static const int kDefaultPort = 80; |
| 474 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 475 | HostResolverManagerTest() : proc_(new MockHostResolverProc()) {} |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 476 | |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 477 | void CreateResolver(bool check_ipv6_on_wifi = true) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 478 | CreateResolverWithLimitsAndParams(kMaxJobs, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 479 | true /* ipv6_reachable */, |
| 480 | check_ipv6_on_wifi); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 481 | } |
| 482 | |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 483 | void DestroyResolver() { |
| 484 | if (!resolver_) |
| 485 | return; |
| 486 | |
| 487 | if (host_cache_) |
| 488 | resolver_->RemoveHostCacheInvalidator(host_cache_->invalidator()); |
| 489 | resolver_ = nullptr; |
| 490 | } |
| 491 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 492 | // This HostResolverManager will only allow 1 outstanding resolve at a time |
| 493 | // and perform no retries. |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 494 | void CreateSerialResolver(bool check_ipv6_on_wifi = true) { |
Eric Orth | 5906622 | 2019-03-07 23:52:27 | [diff] [blame] | 495 | ProcTaskParams params = DefaultParams(proc_.get()); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 496 | params.max_retry_attempts = 0u; |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 497 | CreateResolverWithLimitsAndParams(1u, params, true /* ipv6_reachable */, |
| 498 | check_ipv6_on_wifi); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 499 | } |
| 500 | |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 501 | protected: |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 502 | // testing::Test implementation: |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 503 | void SetUp() override { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 504 | host_cache_ = HostCache::CreateDefaultCache(); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 505 | CreateResolver(); |
| 506 | request_context_ = std::make_unique<TestURLRequestContext>(); |
| 507 | } |
[email protected] | 70c04ab | 2013-08-22 16:05:12 | [diff] [blame] | 508 | |
dcheng | 67be2b1f | 2014-10-27 21:47:29 | [diff] [blame] | 509 | void TearDown() override { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 510 | if (resolver_) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 511 | EXPECT_EQ(0u, resolver_->num_running_dispatcher_jobs_for_tests()); |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 512 | if (host_cache_) |
| 513 | resolver_->RemoveHostCacheInvalidator(host_cache_->invalidator()); |
| 514 | } |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 515 | EXPECT_FALSE(proc_->HasBlockedRequests()); |
| 516 | } |
| 517 | |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 518 | void CreateResolverWithLimitsAndParams(size_t max_concurrent_resolves, |
| 519 | const ProcTaskParams& params, |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 520 | bool ipv6_reachable, |
| 521 | bool check_ipv6_on_wifi) { |
Eric Orth | 4d635c1 | 2019-04-24 22:53:04 | [diff] [blame] | 522 | HostResolver::ManagerOptions options = DefaultOptions(); |
[email protected] | 106ccd2c | 2014-06-17 09:21:00 | [diff] [blame] | 523 | options.max_concurrent_resolves = max_concurrent_resolves; |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 524 | options.check_ipv6_on_wifi = check_ipv6_on_wifi; |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 525 | |
| 526 | CreateResolverWithOptionsAndParams(std::move(options), params, |
| 527 | ipv6_reachable); |
| 528 | } |
| 529 | |
| 530 | virtual HostResolver::ManagerOptions DefaultOptions() { |
| 531 | HostResolver::ManagerOptions options; |
| 532 | options.max_concurrent_resolves = kMaxJobs; |
| 533 | options.max_system_retry_attempts = kMaxRetryAttempts; |
| 534 | return options; |
| 535 | } |
| 536 | |
| 537 | virtual void CreateResolverWithOptionsAndParams( |
| 538 | HostResolver::ManagerOptions options, |
| 539 | const ProcTaskParams& params, |
| 540 | bool ipv6_reachable) { |
| 541 | // Use HostResolverManagerDnsTest if enabling DNS client. |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 542 | DCHECK(!options.insecure_dns_client_enabled); |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 543 | |
| 544 | DestroyResolver(); |
| 545 | |
| 546 | resolver_ = std::make_unique<TestHostResolverManager>( |
| 547 | options, nullptr /* net_log */, ipv6_reachable); |
[email protected] | 106ccd2c | 2014-06-17 09:21:00 | [diff] [blame] | 548 | resolver_->set_proc_params_for_test(params); |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 549 | |
| 550 | if (host_cache_) |
| 551 | resolver_->AddHostCacheInvalidator(host_cache_->invalidator()); |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 552 | } |
[email protected] | aa22b24 | 2011-11-16 18:58:29 | [diff] [blame] | 553 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 554 | // Friendship is not inherited, so use proxies to access those. |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 555 | size_t num_running_dispatcher_jobs() const { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 556 | DCHECK(resolver_.get()); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 557 | return resolver_->num_running_dispatcher_jobs_for_tests(); |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 558 | } |
| 559 | |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 560 | void set_allow_fallback_to_proctask(bool allow_fallback_to_proctask) { |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 561 | DCHECK(resolver_.get()); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 562 | resolver_->allow_fallback_to_proctask_ = allow_fallback_to_proctask; |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 563 | } |
| 564 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 565 | static unsigned maximum_insecure_dns_task_failures() { |
| 566 | return HostResolverManager::kMaximumInsecureDnsTaskFailures; |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 567 | } |
| 568 | |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 569 | bool IsIPv6Reachable(const NetLogWithSource& net_log) { |
sergeyu | b8cdc21 | 2015-05-14 18:50:37 | [diff] [blame] | 570 | return resolver_->IsIPv6Reachable(net_log); |
| 571 | } |
| 572 | |
dalyk | e966a183 | 2019-06-05 20:53:13 | [diff] [blame] | 573 | void PopulateCache(HostCache::Key& key, IPEndPoint endpoint) { |
| 574 | resolver_->CacheResult(host_cache_.get(), key, |
| 575 | HostCache::Entry(OK, AddressList(endpoint), |
| 576 | HostCache::Entry::SOURCE_UNKNOWN), |
| 577 | base::TimeDelta::FromSeconds(1)); |
| 578 | } |
| 579 | |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 580 | const std::pair<const HostCache::Key, HostCache::Entry>* GetCacheHit( |
| 581 | const HostCache::Key& key) { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 582 | DCHECK(host_cache_); |
| 583 | return host_cache_->LookupStale(key, base::TimeTicks(), nullptr, |
| 584 | false /* ignore_secure */); |
Rob Percival | 94f21ad | 2017-11-14 10:20:24 | [diff] [blame] | 585 | } |
| 586 | |
juliatuttle | 9fb7aeb | 2016-06-06 20:16:33 | [diff] [blame] | 587 | void MakeCacheStale() { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 588 | DCHECK(host_cache_); |
| 589 | host_cache_->Invalidate(); |
juliatuttle | 9fb7aeb | 2016-06-06 20:16:33 | [diff] [blame] | 590 | } |
| 591 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 592 | IPEndPoint CreateExpected(const std::string& ip_literal, uint16_t port) { |
| 593 | IPAddress ip; |
| 594 | bool result = ip.AssignFromIPLiteral(ip_literal); |
| 595 | DCHECK(result); |
| 596 | return IPEndPoint(ip, port); |
| 597 | } |
| 598 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 599 | scoped_refptr<MockHostResolverProc> proc_; |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 600 | std::unique_ptr<HostResolverManager> resolver_; |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 601 | std::unique_ptr<URLRequestContext> request_context_; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 602 | std::unique_ptr<HostCache> host_cache_; |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 603 | }; |
| 604 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 605 | TEST_F(HostResolverManagerTest, AsynchronousLookup) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 606 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 607 | proc_->SignalMultiple(1u); |
[email protected] | 471822ca | 2009-01-29 11:32:26 | [diff] [blame] | 608 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 609 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 610 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 611 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 612 | |
| 613 | EXPECT_THAT(response.result_error(), IsOk()); |
| 614 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 615 | testing::ElementsAre(CreateExpected("192.168.1.42", 80))); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 616 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 617 | |
| 618 | EXPECT_EQ("just.testing", proc_->GetCaptureList()[0].hostname); |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 619 | |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 620 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result = |
| 621 | GetCacheHit(HostCache::Key("just.testing", DnsQueryType::UNSPECIFIED, |
| 622 | 0 /* host_resolver_flags */, |
| 623 | HostResolverSource::ANY)); |
| 624 | EXPECT_TRUE(cache_result); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 625 | } |
| 626 | |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 627 | TEST_F(HostResolverManagerTest, JobsClearedOnCompletion) { |
| 628 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 629 | proc_->SignalMultiple(1u); |
| 630 | |
| 631 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 632 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 633 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 634 | EXPECT_EQ(1u, resolver_->num_jobs_for_testing()); |
| 635 | |
| 636 | EXPECT_THAT(response.result_error(), IsOk()); |
| 637 | EXPECT_EQ(0u, resolver_->num_jobs_for_testing()); |
| 638 | } |
| 639 | |
| 640 | TEST_F(HostResolverManagerTest, JobsClearedOnCompletion_MultipleRequests) { |
| 641 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 642 | proc_->SignalMultiple(1u); |
| 643 | |
| 644 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
| 645 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 646 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 647 | ResolveHostResponseHelper response2(resolver_->CreateRequest( |
| 648 | HostPortPair("just.testing", 85), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 649 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 650 | EXPECT_EQ(1u, resolver_->num_jobs_for_testing()); |
| 651 | |
| 652 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 653 | EXPECT_THAT(response2.result_error(), IsOk()); |
| 654 | EXPECT_EQ(0u, resolver_->num_jobs_for_testing()); |
| 655 | } |
| 656 | |
| 657 | TEST_F(HostResolverManagerTest, JobsClearedOnCompletion_Failure) { |
| 658 | proc_->AddRuleForAllFamilies(std::string(), |
| 659 | "0.0.0.0"); // Default to failures. |
| 660 | proc_->SignalMultiple(1u); |
| 661 | |
| 662 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 663 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 664 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 665 | EXPECT_EQ(1u, resolver_->num_jobs_for_testing()); |
| 666 | |
| 667 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 668 | EXPECT_EQ(0u, resolver_->num_jobs_for_testing()); |
| 669 | } |
| 670 | |
| 671 | TEST_F(HostResolverManagerTest, JobsClearedOnCompletion_Abort) { |
| 672 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 673 | |
| 674 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 675 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 676 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 677 | EXPECT_EQ(1u, resolver_->num_jobs_for_testing()); |
| 678 | |
| 679 | NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); |
| 680 | proc_->SignalMultiple(1u); |
| 681 | |
| 682 | EXPECT_THAT(response.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 683 | EXPECT_EQ(0u, resolver_->num_jobs_for_testing()); |
| 684 | } |
| 685 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 686 | TEST_F(HostResolverManagerTest, DnsQueryType) { |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 687 | proc_->AddRule("host", ADDRESS_FAMILY_IPV4, "192.168.1.20"); |
| 688 | proc_->AddRule("host", ADDRESS_FAMILY_IPV6, "::5"); |
| 689 | |
| 690 | HostResolver::ResolveHostParameters parameters; |
| 691 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 692 | parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 693 | ResolveHostResponseHelper v4_response(resolver_->CreateRequest( |
| 694 | HostPortPair("host", 80), NetLogWithSource(), parameters, |
| 695 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 696 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 697 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 698 | ResolveHostResponseHelper v6_response(resolver_->CreateRequest( |
| 699 | HostPortPair("host", 80), NetLogWithSource(), parameters, |
| 700 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 701 | |
| 702 | proc_->SignalMultiple(2u); |
| 703 | |
| 704 | EXPECT_THAT(v4_response.result_error(), IsOk()); |
| 705 | EXPECT_THAT(v4_response.request()->GetAddressResults().value().endpoints(), |
| 706 | testing::ElementsAre(CreateExpected("192.168.1.20", 80))); |
| 707 | |
| 708 | EXPECT_THAT(v6_response.result_error(), IsOk()); |
| 709 | EXPECT_THAT(v6_response.request()->GetAddressResults().value().endpoints(), |
| 710 | testing::ElementsAre(CreateExpected("::5", 80))); |
| 711 | } |
| 712 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 713 | TEST_F(HostResolverManagerTest, LocalhostIPV4IPV6Lookup) { |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 714 | HostResolver::ResolveHostParameters parameters; |
| 715 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 716 | parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 717 | ResolveHostResponseHelper v6_v4_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 718 | HostPortPair("localhost6", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 719 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 720 | EXPECT_THAT(v6_v4_response.result_error(), IsOk()); |
| 721 | EXPECT_THAT(v6_v4_response.request()->GetAddressResults().value().endpoints(), |
| 722 | testing::IsEmpty()); |
| 723 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 724 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 725 | ResolveHostResponseHelper v6_v6_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 726 | HostPortPair("localhost6", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 727 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 728 | EXPECT_THAT(v6_v6_response.result_error(), IsOk()); |
| 729 | EXPECT_THAT(v6_v6_response.request()->GetAddressResults().value().endpoints(), |
| 730 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 731 | |
| 732 | ResolveHostResponseHelper v6_unsp_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 733 | HostPortPair("localhost6", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 734 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 735 | EXPECT_THAT(v6_unsp_response.result_error(), IsOk()); |
| 736 | EXPECT_THAT( |
| 737 | v6_unsp_response.request()->GetAddressResults().value().endpoints(), |
| 738 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 739 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 740 | parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 741 | ResolveHostResponseHelper v4_v4_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 742 | HostPortPair("localhost", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 743 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 744 | EXPECT_THAT(v4_v4_response.result_error(), IsOk()); |
| 745 | EXPECT_THAT(v4_v4_response.request()->GetAddressResults().value().endpoints(), |
| 746 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 747 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 748 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 749 | ResolveHostResponseHelper v4_v6_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 750 | HostPortPair("localhost", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 751 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 752 | EXPECT_THAT(v4_v6_response.result_error(), IsOk()); |
| 753 | EXPECT_THAT(v4_v6_response.request()->GetAddressResults().value().endpoints(), |
| 754 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 755 | |
| 756 | ResolveHostResponseHelper v4_unsp_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 757 | HostPortPair("localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 758 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 759 | EXPECT_THAT(v4_unsp_response.result_error(), IsOk()); |
| 760 | EXPECT_THAT( |
| 761 | v4_unsp_response.request()->GetAddressResults().value().endpoints(), |
| 762 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 763 | CreateExpected("::1", 80))); |
| 764 | } |
| 765 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 766 | TEST_F(HostResolverManagerTest, ResolveIPLiteralWithHostResolverSystemOnly) { |
eroman | 368a100 | 2016-03-04 21:52:55 | [diff] [blame] | 767 | const char kIpLiteral[] = "178.78.32.1"; |
| 768 | // Add a mapping to tell if the resolver proc was called (if it was called, |
| 769 | // then the result will be the remapped value. Otherwise it will be the IP |
| 770 | // literal). |
| 771 | proc_->AddRuleForAllFamilies(kIpLiteral, "183.45.32.1"); |
| 772 | |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 773 | HostResolver::ResolveHostParameters parameters; |
| 774 | parameters.source = HostResolverSource::SYSTEM; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 775 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 776 | HostPortPair(kIpLiteral, 80), NetLogWithSource(), parameters, |
| 777 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 778 | |
| 779 | // IP literal resolution is expected to take precedence over source, so the |
| 780 | // result is expected to be the input IP, not the result IP from the proc rule |
| 781 | EXPECT_THAT(response.result_error(), IsOk()); |
| 782 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 783 | testing::ElementsAre(CreateExpected(kIpLiteral, 80))); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 784 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 785 | } |
| 786 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 787 | TEST_F(HostResolverManagerTest, EmptyListMeansNameNotResolved) { |
[email protected] | 49b70b22 | 2013-05-07 21:24:23 | [diff] [blame] | 788 | proc_->AddRuleForAllFamilies("just.testing", ""); |
| 789 | proc_->SignalMultiple(1u); |
| 790 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 791 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 792 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 793 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 794 | |
| 795 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 796 | EXPECT_FALSE(response.request()->GetAddressResults()); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 797 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 798 | |
| 799 | EXPECT_EQ("just.testing", proc_->GetCaptureList()[0].hostname); |
| 800 | } |
| 801 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 802 | TEST_F(HostResolverManagerTest, FailedAsynchronousLookup) { |
[email protected] | 007b3f8 | 2013-04-09 08:46:45 | [diff] [blame] | 803 | proc_->AddRuleForAllFamilies(std::string(), |
| 804 | "0.0.0.0"); // Default to failures. |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 805 | proc_->SignalMultiple(1u); |
[email protected] | a33347c | 2012-01-09 18:27:01 | [diff] [blame] | 806 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 807 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 808 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 809 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 810 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 811 | EXPECT_FALSE(response.request()->GetAddressResults()); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 812 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 813 | |
| 814 | EXPECT_EQ("just.testing", proc_->GetCaptureList()[0].hostname); |
| 815 | |
| 816 | // Also test that the error is not cached. |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 817 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result = |
| 818 | GetCacheHit(HostCache::Key("just.testing", DnsQueryType::UNSPECIFIED, |
| 819 | 0 /* host_resolver_flags */, |
| 820 | HostResolverSource::ANY)); |
| 821 | EXPECT_FALSE(cache_result); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 822 | } |
| 823 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 824 | TEST_F(HostResolverManagerTest, AbortedAsynchronousLookup) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 825 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 826 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 827 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 828 | ASSERT_FALSE(response0.complete()); |
| 829 | ASSERT_TRUE(proc_->WaitFor(1u)); |
| 830 | |
| 831 | // Resolver is destroyed while job is running on WorkerPool. |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 832 | DestroyResolver(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 833 | |
| 834 | proc_->SignalAll(); |
| 835 | |
| 836 | // To ensure there was no spurious callback, complete with a new resolver. |
| 837 | CreateResolver(); |
| 838 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 839 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 840 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 841 | |
| 842 | proc_->SignalMultiple(2u); |
| 843 | |
| 844 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 845 | |
| 846 | // This request was canceled. |
| 847 | EXPECT_FALSE(response0.complete()); |
| 848 | } |
| 849 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 850 | TEST_F(HostResolverManagerTest, NumericIPv4Address) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 851 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 852 | HostPortPair("127.1.2.3", 5555), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 853 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 854 | |
| 855 | EXPECT_THAT(response.result_error(), IsOk()); |
| 856 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 857 | testing::ElementsAre(CreateExpected("127.1.2.3", 5555))); |
| 858 | } |
| 859 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 860 | TEST_F(HostResolverManagerTest, NumericIPv6Address) { |
[email protected] | dbcff9627 | 2009-05-07 00:23:44 | [diff] [blame] | 861 | // Resolve a plain IPv6 address. Don't worry about [brackets], because |
| 862 | // the caller should have removed them. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 863 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 864 | HostPortPair("2001:db8::1", 5555), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 865 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 866 | |
| 867 | EXPECT_THAT(response.result_error(), IsOk()); |
| 868 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 869 | testing::ElementsAre(CreateExpected("2001:db8::1", 5555))); |
| 870 | } |
| 871 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 872 | TEST_F(HostResolverManagerTest, EmptyHost) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 873 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 874 | HostPortPair(std::string(), 5555), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 875 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 876 | |
| 877 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 878 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 879 | } |
| 880 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 881 | TEST_F(HostResolverManagerTest, EmptyDotsHost) { |
[email protected] | e806cd7 | 2013-05-17 02:08:43 | [diff] [blame] | 882 | for (int i = 0; i < 16; ++i) { |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 883 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 884 | HostPortPair(std::string(i, '.'), 5555), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 885 | base::nullopt, request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 886 | |
| 887 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 888 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 889 | } |
| 890 | } |
| 891 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 892 | TEST_F(HostResolverManagerTest, LongHost) { |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 893 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 894 | HostPortPair(std::string(4097, 'a'), 5555), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 895 | base::nullopt, request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 896 | |
| 897 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 898 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 899 | } |
| 900 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 901 | TEST_F(HostResolverManagerTest, DeDupeRequests) { |
[email protected] | b59ff37 | 2009-07-15 22:04:32 | [diff] [blame] | 902 | // Start 5 requests, duplicating hosts "a" and "b". Since the resolver_proc is |
[email protected] | 8a00f00a | 2009-06-12 00:49:38 | [diff] [blame] | 903 | // blocked, these should all pile up until we signal it. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 904 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 905 | responses.emplace_back( |
| 906 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 907 | HostPortPair("a", 80), NetLogWithSource(), base::nullopt, |
| 908 | request_context_.get(), host_cache_.get()))); |
| 909 | responses.emplace_back( |
| 910 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 911 | HostPortPair("b", 80), NetLogWithSource(), base::nullopt, |
| 912 | request_context_.get(), host_cache_.get()))); |
| 913 | responses.emplace_back( |
| 914 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 915 | HostPortPair("b", 81), NetLogWithSource(), base::nullopt, |
| 916 | request_context_.get(), host_cache_.get()))); |
| 917 | responses.emplace_back( |
| 918 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 919 | HostPortPair("a", 82), NetLogWithSource(), base::nullopt, |
| 920 | request_context_.get(), host_cache_.get()))); |
| 921 | responses.emplace_back( |
| 922 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 923 | HostPortPair("b", 83), NetLogWithSource(), base::nullopt, |
| 924 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 925 | |
| 926 | for (auto& response : responses) { |
| 927 | ASSERT_FALSE(response->complete()); |
| 928 | } |
| 929 | |
| 930 | proc_->SignalMultiple(2u); // One for "a", one for "b". |
| 931 | |
| 932 | for (auto& response : responses) { |
| 933 | EXPECT_THAT(response->result_error(), IsOk()); |
| 934 | } |
| 935 | } |
| 936 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 937 | TEST_F(HostResolverManagerTest, CancelMultipleRequests) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 938 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 939 | responses.emplace_back( |
| 940 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 941 | HostPortPair("a", 80), NetLogWithSource(), base::nullopt, |
| 942 | request_context_.get(), host_cache_.get()))); |
| 943 | responses.emplace_back( |
| 944 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 945 | HostPortPair("b", 80), NetLogWithSource(), base::nullopt, |
| 946 | request_context_.get(), host_cache_.get()))); |
| 947 | responses.emplace_back( |
| 948 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 949 | HostPortPair("b", 81), NetLogWithSource(), base::nullopt, |
| 950 | request_context_.get(), host_cache_.get()))); |
| 951 | responses.emplace_back( |
| 952 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 953 | HostPortPair("a", 82), NetLogWithSource(), base::nullopt, |
| 954 | request_context_.get(), host_cache_.get()))); |
| 955 | responses.emplace_back( |
| 956 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 957 | HostPortPair("b", 83), NetLogWithSource(), base::nullopt, |
| 958 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 959 | |
| 960 | for (auto& response : responses) { |
| 961 | ASSERT_FALSE(response->complete()); |
| 962 | } |
| 963 | |
| 964 | // Cancel everything except request for requests[3] ("a", 82). |
| 965 | responses[0]->CancelRequest(); |
| 966 | responses[1]->CancelRequest(); |
| 967 | responses[2]->CancelRequest(); |
| 968 | responses[4]->CancelRequest(); |
| 969 | |
| 970 | proc_->SignalMultiple(2u); // One for "a", one for "b". |
| 971 | |
| 972 | EXPECT_THAT(responses[3]->result_error(), IsOk()); |
| 973 | |
| 974 | EXPECT_FALSE(responses[0]->complete()); |
| 975 | EXPECT_FALSE(responses[1]->complete()); |
| 976 | EXPECT_FALSE(responses[2]->complete()); |
| 977 | EXPECT_FALSE(responses[4]->complete()); |
| 978 | } |
| 979 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 980 | TEST_F(HostResolverManagerTest, CanceledRequestsReleaseJobSlots) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 981 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 982 | |
| 983 | // Fill up the dispatcher and queue. |
| 984 | for (unsigned i = 0; i < kMaxJobs + 1; ++i) { |
| 985 | std::string hostname = "a_"; |
| 986 | hostname[1] = 'a' + i; |
| 987 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 988 | responses.emplace_back( |
| 989 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 990 | HostPortPair(hostname, 80), NetLogWithSource(), base::nullopt, |
| 991 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 992 | ASSERT_FALSE(responses.back()->complete()); |
| 993 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 994 | responses.emplace_back( |
| 995 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 996 | HostPortPair(hostname, 81), NetLogWithSource(), base::nullopt, |
| 997 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 998 | ASSERT_FALSE(responses.back()->complete()); |
| 999 | } |
| 1000 | |
| 1001 | ASSERT_TRUE(proc_->WaitFor(kMaxJobs)); |
| 1002 | |
| 1003 | // Cancel all but last two. |
| 1004 | for (unsigned i = 0; i < responses.size() - 2; ++i) { |
| 1005 | responses[i]->CancelRequest(); |
| 1006 | } |
| 1007 | |
| 1008 | ASSERT_TRUE(proc_->WaitFor(kMaxJobs + 1)); |
| 1009 | |
| 1010 | proc_->SignalAll(); |
| 1011 | |
| 1012 | size_t num_requests = responses.size(); |
| 1013 | EXPECT_THAT(responses[num_requests - 1]->result_error(), IsOk()); |
| 1014 | EXPECT_THAT(responses[num_requests - 2]->result_error(), IsOk()); |
| 1015 | for (unsigned i = 0; i < num_requests - 2; ++i) { |
| 1016 | EXPECT_FALSE(responses[i]->complete()); |
| 1017 | } |
| 1018 | } |
| 1019 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1020 | TEST_F(HostResolverManagerTest, CancelWithinCallback) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1021 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 1022 | auto custom_callback = base::BindLambdaForTesting( |
| 1023 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1024 | for (auto& response : responses) { |
| 1025 | // Cancelling request is required to complete first, so that it can |
| 1026 | // attempt to cancel the others. This test assumes all jobs are |
| 1027 | // completed in order. |
| 1028 | DCHECK(!response->complete()); |
| 1029 | |
| 1030 | response->CancelRequest(); |
| 1031 | } |
| 1032 | std::move(completion_callback).Run(error); |
| 1033 | }); |
| 1034 | |
| 1035 | ResolveHostResponseHelper cancelling_response( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1036 | resolver_->CreateRequest(HostPortPair("a", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1037 | base::nullopt, request_context_.get(), |
| 1038 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1039 | std::move(custom_callback)); |
| 1040 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1041 | responses.emplace_back( |
| 1042 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1043 | HostPortPair("a", 81), NetLogWithSource(), base::nullopt, |
| 1044 | request_context_.get(), host_cache_.get()))); |
| 1045 | responses.emplace_back( |
| 1046 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1047 | HostPortPair("a", 82), NetLogWithSource(), base::nullopt, |
| 1048 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1049 | |
| 1050 | proc_->SignalMultiple(2u); // One for "a". One for "finalrequest". |
| 1051 | |
| 1052 | EXPECT_THAT(cancelling_response.result_error(), IsOk()); |
| 1053 | |
| 1054 | ResolveHostResponseHelper final_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1055 | HostPortPair("finalrequest", 70), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1056 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1057 | EXPECT_THAT(final_response.result_error(), IsOk()); |
| 1058 | |
| 1059 | for (auto& response : responses) { |
| 1060 | EXPECT_FALSE(response->complete()); |
| 1061 | } |
| 1062 | } |
| 1063 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1064 | TEST_F(HostResolverManagerTest, DeleteWithinCallback) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1065 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 1066 | auto custom_callback = base::BindLambdaForTesting( |
| 1067 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1068 | for (auto& response : responses) { |
| 1069 | // Deleting request is required to be first, so the other requests |
| 1070 | // will still be running to be deleted. This test assumes that the |
| 1071 | // Jobs will be Aborted in order and the requests in order within the |
| 1072 | // jobs. |
| 1073 | DCHECK(!response->complete()); |
| 1074 | } |
| 1075 | |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 1076 | DestroyResolver(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1077 | std::move(completion_callback).Run(error); |
| 1078 | }); |
| 1079 | |
| 1080 | ResolveHostResponseHelper deleting_response( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1081 | resolver_->CreateRequest(HostPortPair("a", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1082 | base::nullopt, request_context_.get(), |
| 1083 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1084 | std::move(custom_callback)); |
| 1085 | |
| 1086 | // Start additional requests to be cancelled as part of the first's deletion. |
| 1087 | // Assumes all requests for a job are handled in order so that the deleting |
| 1088 | // request will run first and cancel the rest. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1089 | responses.emplace_back( |
| 1090 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1091 | HostPortPair("a", 81), NetLogWithSource(), base::nullopt, |
| 1092 | request_context_.get(), host_cache_.get()))); |
| 1093 | responses.emplace_back( |
| 1094 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1095 | HostPortPair("a", 82), NetLogWithSource(), base::nullopt, |
| 1096 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1097 | |
| 1098 | proc_->SignalMultiple(3u); |
| 1099 | |
| 1100 | EXPECT_THAT(deleting_response.result_error(), IsOk()); |
| 1101 | |
| 1102 | base::RunLoop().RunUntilIdle(); |
| 1103 | for (auto& response : responses) { |
| 1104 | EXPECT_FALSE(response->complete()); |
| 1105 | } |
| 1106 | } |
| 1107 | |
Francois Doray | 4a0a6f1 | 2019-08-19 15:25:22 | [diff] [blame] | 1108 | TEST_F(HostResolverManagerTest, DeleteWithinAbortedCallback) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1109 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 1110 | ResolveHostResponseHelper::Callback custom_callback = |
| 1111 | base::BindLambdaForTesting( |
| 1112 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1113 | for (auto& response : responses) { |
| 1114 | // Deleting request is required to be first, so the other requests |
| 1115 | // will still be running to be deleted. This test assumes that the |
| 1116 | // Jobs will be Aborted in order and the requests in order within |
| 1117 | // the jobs. |
| 1118 | DCHECK(!response->complete()); |
| 1119 | } |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 1120 | DestroyResolver(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1121 | std::move(completion_callback).Run(error); |
| 1122 | }); |
| 1123 | |
| 1124 | ResolveHostResponseHelper deleting_response( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1125 | resolver_->CreateRequest(HostPortPair("a", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1126 | base::nullopt, request_context_.get(), |
| 1127 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1128 | std::move(custom_callback)); |
| 1129 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1130 | responses.emplace_back( |
| 1131 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1132 | HostPortPair("a", 81), NetLogWithSource(), base::nullopt, |
| 1133 | request_context_.get(), host_cache_.get()))); |
| 1134 | responses.emplace_back( |
| 1135 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1136 | HostPortPair("b", 82), NetLogWithSource(), base::nullopt, |
| 1137 | request_context_.get(), host_cache_.get()))); |
| 1138 | responses.emplace_back( |
| 1139 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1140 | HostPortPair("b", 83), NetLogWithSource(), base::nullopt, |
| 1141 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1142 | |
| 1143 | // Wait for all calls to queue up, trigger abort via IP address change, then |
| 1144 | // signal all the queued requests to let them all try to finish. |
| 1145 | EXPECT_TRUE(proc_->WaitFor(2u)); |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1146 | NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1147 | proc_->SignalAll(); |
| 1148 | |
| 1149 | EXPECT_THAT(deleting_response.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 1150 | base::RunLoop().RunUntilIdle(); |
| 1151 | for (auto& response : responses) { |
| 1152 | EXPECT_FALSE(response->complete()); |
| 1153 | } |
| 1154 | } |
| 1155 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1156 | TEST_F(HostResolverManagerTest, StartWithinCallback) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1157 | std::unique_ptr<ResolveHostResponseHelper> new_response; |
| 1158 | auto custom_callback = base::BindLambdaForTesting( |
| 1159 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1160 | new_response = std::make_unique<ResolveHostResponseHelper>( |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1161 | resolver_->CreateRequest( |
| 1162 | HostPortPair("new", 70), NetLogWithSource(), base::nullopt, |
| 1163 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1164 | std::move(completion_callback).Run(error); |
| 1165 | }); |
| 1166 | |
| 1167 | ResolveHostResponseHelper starting_response( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1168 | resolver_->CreateRequest(HostPortPair("a", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1169 | base::nullopt, request_context_.get(), |
| 1170 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1171 | std::move(custom_callback)); |
| 1172 | |
| 1173 | proc_->SignalMultiple(2u); // One for "a". One for "new". |
| 1174 | |
| 1175 | EXPECT_THAT(starting_response.result_error(), IsOk()); |
| 1176 | EXPECT_THAT(new_response->result_error(), IsOk()); |
| 1177 | } |
| 1178 | |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1179 | TEST_F(HostResolverManagerTest, StartWithinEvictionCallback) { |
| 1180 | CreateSerialResolver(); |
| 1181 | resolver_->SetMaxQueuedJobsForTesting(2); |
| 1182 | |
| 1183 | std::unique_ptr<ResolveHostResponseHelper> new_response; |
| 1184 | auto custom_callback = base::BindLambdaForTesting( |
| 1185 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1186 | new_response = std::make_unique<ResolveHostResponseHelper>( |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1187 | resolver_->CreateRequest( |
| 1188 | HostPortPair("new", 70), NetLogWithSource(), base::nullopt, |
| 1189 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1190 | std::move(completion_callback).Run(error); |
| 1191 | }); |
| 1192 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1193 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 1194 | HostPortPair("initial", 80), NetLogWithSource(), base::nullopt, |
| 1195 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1196 | ResolveHostResponseHelper evictee1_response( |
| 1197 | resolver_->CreateRequest(HostPortPair("evictee1", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1198 | base::nullopt, request_context_.get(), |
| 1199 | host_cache_.get()), |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1200 | std::move(custom_callback)); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1201 | ResolveHostResponseHelper evictee2_response(resolver_->CreateRequest( |
| 1202 | HostPortPair("evictee2", 80), NetLogWithSource(), base::nullopt, |
| 1203 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1204 | |
| 1205 | // Now one running request ("initial") and two queued requests ("evictee1" and |
| 1206 | // "evictee2"). Any further requests will cause evictions. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1207 | ResolveHostResponseHelper evictor_response(resolver_->CreateRequest( |
| 1208 | HostPortPair("evictor", 80), NetLogWithSource(), base::nullopt, |
| 1209 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1210 | EXPECT_THAT(evictee1_response.result_error(), |
| 1211 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1212 | |
| 1213 | // "new" should evict "evictee2" |
| 1214 | EXPECT_THAT(evictee2_response.result_error(), |
| 1215 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1216 | |
| 1217 | proc_->SignalMultiple(3u); |
| 1218 | |
| 1219 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 1220 | EXPECT_THAT(evictor_response.result_error(), IsOk()); |
| 1221 | EXPECT_THAT(new_response->result_error(), IsOk()); |
| 1222 | } |
| 1223 | |
| 1224 | // Test where we start a new request within an eviction callback that itself |
| 1225 | // evicts the first evictor. |
| 1226 | TEST_F(HostResolverManagerTest, StartWithinEvictionCallback_DoubleEviction) { |
| 1227 | CreateSerialResolver(); |
| 1228 | resolver_->SetMaxQueuedJobsForTesting(1); |
| 1229 | |
| 1230 | std::unique_ptr<ResolveHostResponseHelper> new_response; |
| 1231 | auto custom_callback = base::BindLambdaForTesting( |
| 1232 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1233 | new_response = std::make_unique<ResolveHostResponseHelper>( |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1234 | resolver_->CreateRequest( |
| 1235 | HostPortPair("new", 70), NetLogWithSource(), base::nullopt, |
| 1236 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1237 | std::move(completion_callback).Run(error); |
| 1238 | }); |
| 1239 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1240 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 1241 | HostPortPair("initial", 80), NetLogWithSource(), base::nullopt, |
| 1242 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1243 | ResolveHostResponseHelper evictee_response( |
| 1244 | resolver_->CreateRequest(HostPortPair("evictee", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1245 | base::nullopt, request_context_.get(), |
| 1246 | host_cache_.get()), |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1247 | std::move(custom_callback)); |
| 1248 | |
| 1249 | // Now one running request ("initial") and one queued requests ("evictee"). |
| 1250 | // Any further requests will cause evictions. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1251 | ResolveHostResponseHelper evictor_response(resolver_->CreateRequest( |
| 1252 | HostPortPair("evictor", 80), NetLogWithSource(), base::nullopt, |
| 1253 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1254 | EXPECT_THAT(evictee_response.result_error(), |
| 1255 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1256 | |
| 1257 | // "new" should evict "evictor" |
| 1258 | EXPECT_THAT(evictor_response.result_error(), |
| 1259 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1260 | |
| 1261 | proc_->SignalMultiple(2u); |
| 1262 | |
| 1263 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 1264 | EXPECT_THAT(new_response->result_error(), IsOk()); |
| 1265 | } |
| 1266 | |
| 1267 | TEST_F(HostResolverManagerTest, StartWithinEvictionCallback_SameRequest) { |
| 1268 | CreateSerialResolver(); |
| 1269 | resolver_->SetMaxQueuedJobsForTesting(2); |
| 1270 | |
| 1271 | std::unique_ptr<ResolveHostResponseHelper> new_response; |
| 1272 | auto custom_callback = base::BindLambdaForTesting( |
| 1273 | [&](CompletionOnceCallback completion_callback, int error) { |
| 1274 | new_response = std::make_unique<ResolveHostResponseHelper>( |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1275 | resolver_->CreateRequest( |
| 1276 | HostPortPair("evictor", 70), NetLogWithSource(), base::nullopt, |
| 1277 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1278 | std::move(completion_callback).Run(error); |
| 1279 | }); |
| 1280 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1281 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 1282 | HostPortPair("initial", 80), NetLogWithSource(), base::nullopt, |
| 1283 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1284 | ResolveHostResponseHelper evictee_response( |
| 1285 | resolver_->CreateRequest(HostPortPair("evictee", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1286 | base::nullopt, request_context_.get(), |
| 1287 | host_cache_.get()), |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1288 | std::move(custom_callback)); |
| 1289 | ResolveHostResponseHelper additional_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1290 | HostPortPair("additional", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1291 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1292 | |
| 1293 | // Now one running request ("initial") and two queued requests ("evictee" and |
| 1294 | // "additional"). Any further requests will cause evictions. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1295 | ResolveHostResponseHelper evictor_response(resolver_->CreateRequest( |
| 1296 | HostPortPair("evictor", 80), NetLogWithSource(), base::nullopt, |
| 1297 | request_context_.get(), host_cache_.get())); |
Eric Orth | 3bd9e51 | 2019-03-29 15:33:35 | [diff] [blame] | 1298 | EXPECT_THAT(evictee_response.result_error(), |
| 1299 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1300 | |
| 1301 | // Second "evictor" should be joined with the first and not evict "additional" |
| 1302 | |
| 1303 | // Only 3 proc requests because both "evictor" requests are combined. |
| 1304 | proc_->SignalMultiple(3u); |
| 1305 | |
| 1306 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 1307 | EXPECT_THAT(additional_response.result_error(), IsOk()); |
| 1308 | EXPECT_THAT(evictor_response.result_error(), IsOk()); |
| 1309 | EXPECT_THAT(new_response->result_error(), IsOk()); |
| 1310 | } |
| 1311 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1312 | TEST_F(HostResolverManagerTest, BypassCache) { |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 1313 | proc_->SignalMultiple(2u); |
| 1314 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1315 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 1316 | HostPortPair("a", 80), NetLogWithSource(), base::nullopt, |
| 1317 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 1318 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 1319 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); |
| 1320 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1321 | ResolveHostResponseHelper cached_response(resolver_->CreateRequest( |
| 1322 | HostPortPair("a", 80), NetLogWithSource(), base::nullopt, |
| 1323 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 1324 | EXPECT_THAT(cached_response.result_error(), IsOk()); |
| 1325 | // Expect no increase to calls to |proc_| because result was cached. |
| 1326 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); |
| 1327 | |
| 1328 | HostResolver::ResolveHostParameters parameters; |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1329 | parameters.cache_usage = |
| 1330 | HostResolver::ResolveHostParameters::CacheUsage::DISALLOWED; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1331 | ResolveHostResponseHelper cache_bypassed_response(resolver_->CreateRequest( |
| 1332 | HostPortPair("a", 80), NetLogWithSource(), parameters, |
| 1333 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 1334 | EXPECT_THAT(cache_bypassed_response.result_error(), IsOk()); |
| 1335 | // Expect call to |proc_| because cache was bypassed. |
| 1336 | EXPECT_EQ(2u, proc_->GetCaptureList().size()); |
| 1337 | } |
| 1338 | |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1339 | // Test that IP address changes flush the cache but initial DNS config reads |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1340 | // do not. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1341 | TEST_F(HostResolverManagerTest, FlushCacheOnIPAddressChange) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1342 | proc_->SignalMultiple(2u); // One before the flush, one after. |
| 1343 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1344 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 1345 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 1346 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1347 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 1348 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); |
| 1349 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1350 | ResolveHostResponseHelper cached_response(resolver_->CreateRequest( |
| 1351 | HostPortPair("host1", 75), NetLogWithSource(), base::nullopt, |
| 1352 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1353 | EXPECT_THAT(cached_response.result_error(), IsOk()); |
| 1354 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); // No expected increase. |
| 1355 | |
| 1356 | // Verify initial DNS config read does not flush cache. |
| 1357 | NetworkChangeNotifier::NotifyObserversOfInitialDNSConfigReadForTests(); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1358 | ResolveHostResponseHelper unflushed_response(resolver_->CreateRequest( |
| 1359 | HostPortPair("host1", 75), NetLogWithSource(), base::nullopt, |
| 1360 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1361 | EXPECT_THAT(unflushed_response.result_error(), IsOk()); |
| 1362 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); // No expected increase. |
| 1363 | |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1364 | // Flush cache by triggering an IP address change. |
| 1365 | NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1366 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 1367 | |
| 1368 | // Resolve "host1" again -- this time it won't be served from cache, so it |
| 1369 | // will complete asynchronously. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1370 | ResolveHostResponseHelper flushed_response(resolver_->CreateRequest( |
| 1371 | HostPortPair("host1", 80), NetLogWithSource(), base::nullopt, |
| 1372 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1373 | EXPECT_THAT(flushed_response.result_error(), IsOk()); |
| 1374 | EXPECT_EQ(2u, proc_->GetCaptureList().size()); // Expected increase. |
| 1375 | } |
| 1376 | |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 1377 | TEST_F(HostResolverManagerTest, FlushCacheOnDnsConfigChange) { |
| 1378 | proc_->SignalMultiple(2u); // One before the flush, one after. |
| 1379 | |
| 1380 | // Resolve to load cache. |
| 1381 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 1382 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 1383 | request_context_.get(), host_cache_.get())); |
| 1384 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 1385 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); |
| 1386 | |
| 1387 | // Result expected to come from the cache. |
| 1388 | ResolveHostResponseHelper cached_response(resolver_->CreateRequest( |
| 1389 | HostPortPair("host1", 75), NetLogWithSource(), base::nullopt, |
| 1390 | request_context_.get(), host_cache_.get())); |
| 1391 | EXPECT_THAT(cached_response.result_error(), IsOk()); |
| 1392 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); // No expected increase. |
| 1393 | |
| 1394 | // Flush cache by triggering a DNS config change. |
| 1395 | NetworkChangeNotifier::NotifyObserversOfDNSChangeForTests(); |
| 1396 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 1397 | |
| 1398 | // Expect flushed from cache and therefore served from |proc_|. |
| 1399 | ResolveHostResponseHelper flushed_response(resolver_->CreateRequest( |
| 1400 | HostPortPair("host1", 80), NetLogWithSource(), base::nullopt, |
| 1401 | request_context_.get(), host_cache_.get())); |
| 1402 | EXPECT_THAT(flushed_response.result_error(), IsOk()); |
| 1403 | EXPECT_EQ(2u, proc_->GetCaptureList().size()); // Expected increase. |
| 1404 | } |
| 1405 | |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1406 | // Test that IP address changes send ERR_NETWORK_CHANGED to pending requests. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1407 | TEST_F(HostResolverManagerTest, AbortOnIPAddressChanged) { |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1408 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 1409 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 1410 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1411 | |
| 1412 | ASSERT_FALSE(response.complete()); |
| 1413 | ASSERT_TRUE(proc_->WaitFor(1u)); |
| 1414 | |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1415 | // Triggering an IP address change. |
| 1416 | NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1417 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 1418 | proc_->SignalAll(); |
| 1419 | |
| 1420 | EXPECT_THAT(response.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 1421 | EXPECT_FALSE(response.request()->GetAddressResults()); |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 1422 | EXPECT_EQ(0u, host_cache_->size()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1423 | } |
| 1424 | |
pauljensen | 101ed37 | 2015-04-17 00:11:42 | [diff] [blame] | 1425 | // Test that initial DNS config read signals do not abort pending requests. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1426 | TEST_F(HostResolverManagerTest, DontAbortOnInitialDNSConfigRead) { |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1427 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 1428 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 1429 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1430 | |
| 1431 | ASSERT_FALSE(response.complete()); |
| 1432 | ASSERT_TRUE(proc_->WaitFor(1u)); |
| 1433 | |
| 1434 | // Triggering initial DNS config read signal. |
| 1435 | NetworkChangeNotifier::NotifyObserversOfInitialDNSConfigReadForTests(); |
| 1436 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 1437 | proc_->SignalAll(); |
| 1438 | |
| 1439 | EXPECT_THAT(response.result_error(), IsOk()); |
| 1440 | EXPECT_TRUE(response.request()->GetAddressResults()); |
| 1441 | } |
| 1442 | |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1443 | // Obey pool constraints after IP address has changed. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1444 | TEST_F(HostResolverManagerTest, ObeyPoolConstraintsAfterIPAddressChange) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 1445 | // Runs at most one job at a time. |
| 1446 | CreateSerialResolver(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1447 | |
| 1448 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1449 | responses.emplace_back( |
| 1450 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1451 | HostPortPair("a", 80), NetLogWithSource(), base::nullopt, |
| 1452 | request_context_.get(), host_cache_.get()))); |
| 1453 | responses.emplace_back( |
| 1454 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1455 | HostPortPair("b", 80), NetLogWithSource(), base::nullopt, |
| 1456 | request_context_.get(), host_cache_.get()))); |
| 1457 | responses.emplace_back( |
| 1458 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1459 | HostPortPair("c", 80), NetLogWithSource(), base::nullopt, |
| 1460 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1461 | |
| 1462 | for (auto& response : responses) { |
| 1463 | ASSERT_FALSE(response->complete()); |
| 1464 | } |
| 1465 | ASSERT_TRUE(proc_->WaitFor(1u)); |
| 1466 | |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1467 | // Triggering an IP address change. |
| 1468 | NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1469 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 1470 | proc_->SignalMultiple(3u); // Let the false-start go so that we can catch it. |
| 1471 | |
| 1472 | // Requests should complete one at a time, with the first failing. |
| 1473 | EXPECT_THAT(responses[0]->result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 1474 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 1475 | EXPECT_FALSE(responses[1]->complete()); |
| 1476 | EXPECT_FALSE(responses[2]->complete()); |
| 1477 | |
| 1478 | EXPECT_THAT(responses[1]->result_error(), IsOk()); |
| 1479 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 1480 | EXPECT_FALSE(responses[2]->complete()); |
| 1481 | |
| 1482 | EXPECT_THAT(responses[2]->result_error(), IsOk()); |
| 1483 | } |
| 1484 | |
[email protected] | b3601bc2 | 2012-02-21 21:23:20 | [diff] [blame] | 1485 | // Tests that a new Request made from the callback of a previously aborted one |
| 1486 | // will not be aborted. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1487 | TEST_F(HostResolverManagerTest, AbortOnlyExistingRequestsOnIPAddressChange) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1488 | auto custom_callback_template = base::BindLambdaForTesting( |
| 1489 | [&](const HostPortPair& next_host, |
| 1490 | std::unique_ptr<ResolveHostResponseHelper>* next_response, |
| 1491 | CompletionOnceCallback completion_callback, int error) { |
| 1492 | *next_response = std::make_unique<ResolveHostResponseHelper>( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1493 | resolver_->CreateRequest(next_host, NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1494 | base::nullopt, request_context_.get(), |
| 1495 | host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1496 | std::move(completion_callback).Run(error); |
| 1497 | }); |
| 1498 | |
| 1499 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> next_responses(3); |
| 1500 | |
| 1501 | ResolveHostResponseHelper response0( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1502 | resolver_->CreateRequest(HostPortPair("bbb", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1503 | base::nullopt, request_context_.get(), |
| 1504 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1505 | base::BindOnce(custom_callback_template, HostPortPair("zzz", 80), |
| 1506 | &next_responses[0])); |
| 1507 | |
| 1508 | ResolveHostResponseHelper response1( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1509 | resolver_->CreateRequest(HostPortPair("eee", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1510 | base::nullopt, request_context_.get(), |
| 1511 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1512 | base::BindOnce(custom_callback_template, HostPortPair("aaa", 80), |
| 1513 | &next_responses[1])); |
| 1514 | |
| 1515 | ResolveHostResponseHelper response2( |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1516 | resolver_->CreateRequest(HostPortPair("ccc", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1517 | base::nullopt, request_context_.get(), |
| 1518 | host_cache_.get()), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1519 | base::BindOnce(custom_callback_template, HostPortPair("eee", 80), |
| 1520 | &next_responses[2])); |
| 1521 | |
| 1522 | // Wait until all are blocked; |
| 1523 | ASSERT_TRUE(proc_->WaitFor(3u)); |
Paul Jensen | f47bbab | 2018-09-14 16:34:04 | [diff] [blame] | 1524 | // Trigger an IP address change. |
| 1525 | NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1526 | // This should abort all running jobs. |
| 1527 | base::RunLoop().RunUntilIdle(); |
| 1528 | |
| 1529 | EXPECT_THAT(response0.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 1530 | EXPECT_THAT(response1.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 1531 | EXPECT_THAT(response2.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 1532 | |
| 1533 | EXPECT_FALSE(next_responses[0]->complete()); |
| 1534 | EXPECT_FALSE(next_responses[1]->complete()); |
| 1535 | EXPECT_FALSE(next_responses[2]->complete()); |
| 1536 | |
| 1537 | // Unblock all calls to proc. |
| 1538 | proc_->SignalMultiple(6u); |
| 1539 | |
| 1540 | // Run until the re-started requests finish. |
| 1541 | EXPECT_THAT(next_responses[0]->result_error(), IsOk()); |
| 1542 | EXPECT_THAT(next_responses[1]->result_error(), IsOk()); |
| 1543 | EXPECT_THAT(next_responses[2]->result_error(), IsOk()); |
| 1544 | |
| 1545 | // Verify that results of aborted Jobs were not cached. |
| 1546 | EXPECT_EQ(6u, proc_->GetCaptureList().size()); |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 1547 | EXPECT_EQ(3u, host_cache_->size()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1548 | } |
| 1549 | |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 1550 | // Tests that when the maximum threads is set to 1, requests are dequeued |
| 1551 | // in order of priority. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1552 | TEST_F(HostResolverManagerTest, HigherPriorityRequestsStartedFirst) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 1553 | CreateSerialResolver(); |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 1554 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1555 | HostResolver::ResolveHostParameters low_priority; |
| 1556 | low_priority.initial_priority = LOW; |
| 1557 | HostResolver::ResolveHostParameters medium_priority; |
| 1558 | medium_priority.initial_priority = MEDIUM; |
| 1559 | HostResolver::ResolveHostParameters highest_priority; |
| 1560 | highest_priority.initial_priority = HIGHEST; |
| 1561 | |
| 1562 | // Note that at this point the MockHostResolverProc is blocked, so any |
| 1563 | // requests we make will not complete. |
| 1564 | |
| 1565 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1566 | responses.emplace_back( |
| 1567 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1568 | HostPortPair("req0", 80), NetLogWithSource(), low_priority, |
| 1569 | request_context_.get(), host_cache_.get()))); |
| 1570 | responses.emplace_back( |
| 1571 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1572 | HostPortPair("req1", 80), NetLogWithSource(), medium_priority, |
| 1573 | request_context_.get(), host_cache_.get()))); |
| 1574 | responses.emplace_back( |
| 1575 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1576 | HostPortPair("req2", 80), NetLogWithSource(), medium_priority, |
| 1577 | request_context_.get(), host_cache_.get()))); |
| 1578 | responses.emplace_back( |
| 1579 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1580 | HostPortPair("req3", 80), NetLogWithSource(), low_priority, |
| 1581 | request_context_.get(), host_cache_.get()))); |
| 1582 | responses.emplace_back( |
| 1583 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1584 | HostPortPair("req4", 80), NetLogWithSource(), highest_priority, |
| 1585 | request_context_.get(), host_cache_.get()))); |
| 1586 | responses.emplace_back( |
| 1587 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1588 | HostPortPair("req5", 80), NetLogWithSource(), low_priority, |
| 1589 | request_context_.get(), host_cache_.get()))); |
| 1590 | responses.emplace_back( |
| 1591 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1592 | HostPortPair("req6", 80), NetLogWithSource(), low_priority, |
| 1593 | request_context_.get(), host_cache_.get()))); |
| 1594 | responses.emplace_back( |
| 1595 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1596 | HostPortPair("req5", 80), NetLogWithSource(), highest_priority, |
| 1597 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1598 | |
| 1599 | for (const auto& response : responses) { |
| 1600 | ASSERT_FALSE(response->complete()); |
| 1601 | } |
| 1602 | |
| 1603 | // Unblock the resolver thread so the requests can run. |
| 1604 | proc_->SignalMultiple(responses.size()); // More than needed. |
| 1605 | |
| 1606 | // Wait for all the requests to complete successfully. |
| 1607 | for (auto& response : responses) { |
| 1608 | EXPECT_THAT(response->result_error(), IsOk()); |
| 1609 | } |
| 1610 | |
| 1611 | // Since we have restricted to a single concurrent thread in the jobpool, |
| 1612 | // the requests should complete in order of priority (with the exception |
| 1613 | // of the first request, which gets started right away, since there is |
| 1614 | // nothing outstanding). |
| 1615 | MockHostResolverProc::CaptureList capture_list = proc_->GetCaptureList(); |
| 1616 | ASSERT_EQ(7u, capture_list.size()); |
| 1617 | |
| 1618 | EXPECT_EQ("req0", capture_list[0].hostname); |
| 1619 | EXPECT_EQ("req4", capture_list[1].hostname); |
| 1620 | EXPECT_EQ("req5", capture_list[2].hostname); |
| 1621 | EXPECT_EQ("req1", capture_list[3].hostname); |
| 1622 | EXPECT_EQ("req2", capture_list[4].hostname); |
| 1623 | EXPECT_EQ("req3", capture_list[5].hostname); |
| 1624 | EXPECT_EQ("req6", capture_list[6].hostname); |
| 1625 | } |
| 1626 | |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1627 | // Test that changing a job's priority affects the dequeueing order. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1628 | TEST_F(HostResolverManagerTest, ChangePriority) { |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1629 | CreateSerialResolver(); |
| 1630 | |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1631 | HostResolver::ResolveHostParameters lowest_priority; |
| 1632 | lowest_priority.initial_priority = LOWEST; |
| 1633 | HostResolver::ResolveHostParameters low_priority; |
| 1634 | low_priority.initial_priority = LOW; |
| 1635 | HostResolver::ResolveHostParameters medium_priority; |
| 1636 | medium_priority.initial_priority = MEDIUM; |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1637 | |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1638 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1639 | responses.emplace_back( |
| 1640 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1641 | HostPortPair("req0", 80), NetLogWithSource(), medium_priority, |
| 1642 | request_context_.get(), host_cache_.get()))); |
| 1643 | responses.emplace_back( |
| 1644 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1645 | HostPortPair("req1", 80), NetLogWithSource(), low_priority, |
| 1646 | request_context_.get(), host_cache_.get()))); |
| 1647 | responses.emplace_back( |
| 1648 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1649 | HostPortPair("req2", 80), NetLogWithSource(), lowest_priority, |
| 1650 | request_context_.get(), host_cache_.get()))); |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1651 | |
| 1652 | // req0 starts immediately; without ChangePriority, req1 and then req2 should |
| 1653 | // run. |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1654 | for (const auto& response : responses) { |
| 1655 | ASSERT_FALSE(response->complete()); |
| 1656 | } |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1657 | |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1658 | // Changing req2 to HIGHEST should make it run before req1. |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1659 | // (It can't run before req0, since req0 started immediately.) |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1660 | responses[2]->request()->ChangeRequestPriority(HIGHEST); |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1661 | |
| 1662 | // Let all 3 requests finish. |
| 1663 | proc_->SignalMultiple(3u); |
| 1664 | |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 1665 | for (auto& response : responses) { |
| 1666 | EXPECT_THAT(response->result_error(), IsOk()); |
| 1667 | } |
juliatuttle | c53b19a7 | 2016-05-05 13:51:31 | [diff] [blame] | 1668 | |
| 1669 | MockHostResolverProc::CaptureList capture_list = proc_->GetCaptureList(); |
| 1670 | ASSERT_EQ(3u, capture_list.size()); |
| 1671 | |
| 1672 | EXPECT_EQ("req0", capture_list[0].hostname); |
| 1673 | EXPECT_EQ("req2", capture_list[1].hostname); |
| 1674 | EXPECT_EQ("req1", capture_list[2].hostname); |
| 1675 | } |
| 1676 | |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 1677 | // Try cancelling a job which has not started yet. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1678 | TEST_F(HostResolverManagerTest, CancelPendingRequest) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 1679 | CreateSerialResolver(); |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 1680 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1681 | HostResolver::ResolveHostParameters lowest_priority; |
| 1682 | lowest_priority.initial_priority = LOWEST; |
| 1683 | HostResolver::ResolveHostParameters low_priority; |
| 1684 | low_priority.initial_priority = LOW; |
| 1685 | HostResolver::ResolveHostParameters medium_priority; |
| 1686 | medium_priority.initial_priority = MEDIUM; |
| 1687 | HostResolver::ResolveHostParameters highest_priority; |
| 1688 | highest_priority.initial_priority = HIGHEST; |
| 1689 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1690 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1691 | responses.emplace_back( |
| 1692 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1693 | HostPortPair("req0", 80), NetLogWithSource(), lowest_priority, |
| 1694 | request_context_.get(), host_cache_.get()))); |
| 1695 | responses.emplace_back( |
| 1696 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1697 | HostPortPair("req1", 80), NetLogWithSource(), highest_priority, |
| 1698 | request_context_.get(), host_cache_.get()))); |
| 1699 | responses.emplace_back( |
| 1700 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1701 | HostPortPair("req2", 80), NetLogWithSource(), medium_priority, |
| 1702 | request_context_.get(), host_cache_.get()))); |
| 1703 | responses.emplace_back( |
| 1704 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1705 | HostPortPair("req3", 80), NetLogWithSource(), low_priority, |
| 1706 | request_context_.get(), host_cache_.get()))); |
| 1707 | responses.emplace_back( |
| 1708 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1709 | HostPortPair("req4", 80), NetLogWithSource(), highest_priority, |
| 1710 | request_context_.get(), host_cache_.get()))); |
| 1711 | responses.emplace_back( |
| 1712 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1713 | HostPortPair("req5", 80), NetLogWithSource(), lowest_priority, |
| 1714 | request_context_.get(), host_cache_.get()))); |
| 1715 | responses.emplace_back( |
| 1716 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1717 | HostPortPair("req6", 80), NetLogWithSource(), medium_priority, |
| 1718 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1719 | |
| 1720 | // Cancel some requests |
| 1721 | responses[1]->CancelRequest(); |
| 1722 | responses[4]->CancelRequest(); |
| 1723 | responses[5]->CancelRequest(); |
| 1724 | |
| 1725 | // Unblock the resolver thread so the requests can run. |
| 1726 | proc_->SignalMultiple(responses.size()); // More than needed. |
| 1727 | |
| 1728 | // Let everything try to finish. |
| 1729 | base::RunLoop().RunUntilIdle(); |
| 1730 | |
| 1731 | // Wait for all the requests to complete succesfully. |
| 1732 | EXPECT_THAT(responses[0]->result_error(), IsOk()); |
| 1733 | EXPECT_THAT(responses[2]->result_error(), IsOk()); |
| 1734 | EXPECT_THAT(responses[3]->result_error(), IsOk()); |
| 1735 | EXPECT_THAT(responses[6]->result_error(), IsOk()); |
| 1736 | |
| 1737 | // Cancelled requests shouldn't complete. |
| 1738 | EXPECT_FALSE(responses[1]->complete()); |
| 1739 | EXPECT_FALSE(responses[4]->complete()); |
| 1740 | EXPECT_FALSE(responses[5]->complete()); |
| 1741 | |
| 1742 | // Verify that they called out the the resolver proc (which runs on the |
| 1743 | // resolver thread) in the expected order. |
| 1744 | MockHostResolverProc::CaptureList capture_list = proc_->GetCaptureList(); |
| 1745 | ASSERT_EQ(4u, capture_list.size()); |
| 1746 | |
| 1747 | EXPECT_EQ("req0", capture_list[0].hostname); |
| 1748 | EXPECT_EQ("req2", capture_list[1].hostname); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1749 | EXPECT_EQ("req6", capture_list[2].hostname); |
| 1750 | EXPECT_EQ("req3", capture_list[3].hostname); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1751 | } |
| 1752 | |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 1753 | // Test that when too many requests are enqueued, old ones start to be aborted. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1754 | TEST_F(HostResolverManagerTest, QueueOverflow) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 1755 | CreateSerialResolver(); |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 1756 | |
[email protected] | 0f292de0 | 2012-02-01 22:28:20 | [diff] [blame] | 1757 | // Allow only 3 queued jobs. |
| 1758 | const size_t kMaxPendingJobs = 3u; |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1759 | resolver_->SetMaxQueuedJobsForTesting(kMaxPendingJobs); |
[email protected] | 68ad3ee | 2010-01-30 03:45:39 | [diff] [blame] | 1760 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1761 | HostResolver::ResolveHostParameters lowest_priority; |
| 1762 | lowest_priority.initial_priority = LOWEST; |
| 1763 | HostResolver::ResolveHostParameters low_priority; |
| 1764 | low_priority.initial_priority = LOW; |
| 1765 | HostResolver::ResolveHostParameters medium_priority; |
| 1766 | medium_priority.initial_priority = MEDIUM; |
| 1767 | HostResolver::ResolveHostParameters highest_priority; |
| 1768 | highest_priority.initial_priority = HIGHEST; |
| 1769 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1770 | // Note that at this point the MockHostResolverProc is blocked, so any |
| 1771 | // requests we make will not complete. |
| 1772 | |
| 1773 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1774 | responses.emplace_back( |
| 1775 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1776 | HostPortPair("req0", 80), NetLogWithSource(), lowest_priority, |
| 1777 | request_context_.get(), host_cache_.get()))); |
| 1778 | responses.emplace_back( |
| 1779 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1780 | HostPortPair("req1", 80), NetLogWithSource(), highest_priority, |
| 1781 | request_context_.get(), host_cache_.get()))); |
| 1782 | responses.emplace_back( |
| 1783 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1784 | HostPortPair("req2", 80), NetLogWithSource(), medium_priority, |
| 1785 | request_context_.get(), host_cache_.get()))); |
| 1786 | responses.emplace_back( |
| 1787 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1788 | HostPortPair("req3", 80), NetLogWithSource(), medium_priority, |
| 1789 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1790 | |
| 1791 | // At this point, there are 3 enqueued jobs (and one "running" job). |
| 1792 | // Insertion of subsequent requests will cause evictions. |
| 1793 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1794 | responses.emplace_back( |
| 1795 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1796 | HostPortPair("req4", 80), NetLogWithSource(), low_priority, |
| 1797 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1798 | EXPECT_THAT(responses[4]->result_error(), |
| 1799 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); // Evicts self. |
| 1800 | EXPECT_FALSE(responses[4]->request()->GetAddressResults()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1801 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1802 | responses.emplace_back( |
| 1803 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1804 | HostPortPair("req5", 80), NetLogWithSource(), medium_priority, |
| 1805 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1806 | EXPECT_THAT(responses[2]->result_error(), |
| 1807 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1808 | EXPECT_FALSE(responses[2]->request()->GetAddressResults()); |
| 1809 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1810 | responses.emplace_back( |
| 1811 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1812 | HostPortPair("req6", 80), NetLogWithSource(), highest_priority, |
| 1813 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1814 | EXPECT_THAT(responses[3]->result_error(), |
| 1815 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1816 | EXPECT_FALSE(responses[3]->request()->GetAddressResults()); |
| 1817 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1818 | responses.emplace_back( |
| 1819 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 1820 | HostPortPair("req7", 80), NetLogWithSource(), medium_priority, |
| 1821 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1822 | EXPECT_THAT(responses[5]->result_error(), |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1823 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1824 | EXPECT_FALSE(responses[5]->request()->GetAddressResults()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1825 | |
| 1826 | // Unblock the resolver thread so the requests can run. |
| 1827 | proc_->SignalMultiple(4u); |
| 1828 | |
| 1829 | // The rest should succeed. |
| 1830 | EXPECT_THAT(responses[0]->result_error(), IsOk()); |
| 1831 | EXPECT_TRUE(responses[0]->request()->GetAddressResults()); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1832 | EXPECT_THAT(responses[1]->result_error(), IsOk()); |
| 1833 | EXPECT_TRUE(responses[1]->request()->GetAddressResults()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1834 | EXPECT_THAT(responses[6]->result_error(), IsOk()); |
| 1835 | EXPECT_TRUE(responses[6]->request()->GetAddressResults()); |
| 1836 | EXPECT_THAT(responses[7]->result_error(), IsOk()); |
| 1837 | EXPECT_TRUE(responses[7]->request()->GetAddressResults()); |
| 1838 | |
| 1839 | // Verify that they called out the the resolver proc (which runs on the |
| 1840 | // resolver thread) in the expected order. |
| 1841 | MockHostResolverProc::CaptureList capture_list = proc_->GetCaptureList(); |
| 1842 | ASSERT_EQ(4u, capture_list.size()); |
| 1843 | |
| 1844 | EXPECT_EQ("req0", capture_list[0].hostname); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1845 | EXPECT_EQ("req1", capture_list[1].hostname); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1846 | EXPECT_EQ("req6", capture_list[2].hostname); |
| 1847 | EXPECT_EQ("req7", capture_list[3].hostname); |
| 1848 | |
| 1849 | // Verify that the evicted (incomplete) requests were not cached. |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 1850 | EXPECT_EQ(4u, host_cache_->size()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1851 | |
| 1852 | for (size_t i = 0; i < responses.size(); ++i) { |
| 1853 | EXPECT_TRUE(responses[i]->complete()) << i; |
| 1854 | } |
| 1855 | } |
| 1856 | |
| 1857 | // Tests that jobs can self-evict by setting the max queue to 0. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1858 | TEST_F(HostResolverManagerTest, QueueOverflow_SelfEvict) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1859 | CreateSerialResolver(); |
| 1860 | resolver_->SetMaxQueuedJobsForTesting(0); |
| 1861 | |
| 1862 | // Note that at this point the MockHostResolverProc is blocked, so any |
| 1863 | // requests we make will not complete. |
| 1864 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1865 | ResolveHostResponseHelper run_response(resolver_->CreateRequest( |
| 1866 | HostPortPair("run", 80), NetLogWithSource(), base::nullopt, |
| 1867 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1868 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1869 | ResolveHostResponseHelper evict_response(resolver_->CreateRequest( |
| 1870 | HostPortPair("req1", 80), NetLogWithSource(), base::nullopt, |
| 1871 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 1872 | EXPECT_THAT(evict_response.result_error(), |
| 1873 | IsError(ERR_HOST_RESOLVER_QUEUE_TOO_LARGE)); |
| 1874 | EXPECT_FALSE(evict_response.request()->GetAddressResults()); |
| 1875 | |
| 1876 | proc_->SignalMultiple(1u); |
| 1877 | |
| 1878 | EXPECT_THAT(run_response.result_error(), IsOk()); |
| 1879 | EXPECT_TRUE(run_response.request()->GetAddressResults()); |
| 1880 | } |
| 1881 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1882 | // Make sure that the dns query type parameter is respected when raw IPs are |
| 1883 | // passed in. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1884 | TEST_F(HostResolverManagerTest, AddressFamilyWithRawIPs) { |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1885 | HostResolver::ResolveHostParameters v4_parameters; |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 1886 | v4_parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1887 | |
| 1888 | HostResolver::ResolveHostParameters v6_parameters; |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 1889 | v6_parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1890 | |
| 1891 | ResolveHostResponseHelper v4_v4_request(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1892 | HostPortPair("127.0.0.1", 80), NetLogWithSource(), v4_parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1893 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1894 | EXPECT_THAT(v4_v4_request.result_error(), IsOk()); |
| 1895 | EXPECT_THAT(v4_v4_request.request()->GetAddressResults().value().endpoints(), |
| 1896 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 1897 | |
| 1898 | ResolveHostResponseHelper v4_v6_request(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1899 | HostPortPair("127.0.0.1", 80), NetLogWithSource(), v6_parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1900 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1901 | EXPECT_THAT(v4_v6_request.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 1902 | |
| 1903 | ResolveHostResponseHelper v4_unsp_request(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1904 | HostPortPair("127.0.0.1", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1905 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1906 | EXPECT_THAT(v4_unsp_request.result_error(), IsOk()); |
| 1907 | EXPECT_THAT( |
| 1908 | v4_unsp_request.request()->GetAddressResults().value().endpoints(), |
| 1909 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 1910 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1911 | ResolveHostResponseHelper v6_v4_request(resolver_->CreateRequest( |
| 1912 | HostPortPair("::1", 80), NetLogWithSource(), v4_parameters, |
| 1913 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1914 | EXPECT_THAT(v6_v4_request.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 1915 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1916 | ResolveHostResponseHelper v6_v6_request(resolver_->CreateRequest( |
| 1917 | HostPortPair("::1", 80), NetLogWithSource(), v6_parameters, |
| 1918 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1919 | EXPECT_THAT(v6_v6_request.result_error(), IsOk()); |
| 1920 | EXPECT_THAT(v6_v6_request.request()->GetAddressResults().value().endpoints(), |
| 1921 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 1922 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1923 | ResolveHostResponseHelper v6_unsp_request(resolver_->CreateRequest( |
| 1924 | HostPortPair("::1", 80), NetLogWithSource(), base::nullopt, |
| 1925 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 1926 | EXPECT_THAT(v6_unsp_request.result_error(), IsOk()); |
| 1927 | EXPECT_THAT( |
| 1928 | v6_unsp_request.request()->GetAddressResults().value().endpoints(), |
| 1929 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 1930 | } |
| 1931 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1932 | TEST_F(HostResolverManagerTest, LocalOnly_FromCache) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1933 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 1934 | proc_->SignalMultiple(1u); // Need only one. |
| 1935 | |
| 1936 | HostResolver::ResolveHostParameters source_none_parameters; |
| 1937 | source_none_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 1938 | |
| 1939 | // First NONE query expected to complete synchronously with a cache miss. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1940 | ResolveHostResponseHelper cache_miss_request(resolver_->CreateRequest( |
| 1941 | HostPortPair("just.testing", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1942 | source_none_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1943 | EXPECT_TRUE(cache_miss_request.complete()); |
| 1944 | EXPECT_THAT(cache_miss_request.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 1945 | EXPECT_FALSE(cache_miss_request.request()->GetAddressResults()); |
| 1946 | EXPECT_FALSE(cache_miss_request.request()->GetStaleInfo()); |
| 1947 | |
| 1948 | // Normal query to populate the cache. |
| 1949 | ResolveHostResponseHelper normal_request(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1950 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1951 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1952 | EXPECT_THAT(normal_request.result_error(), IsOk()); |
| 1953 | EXPECT_FALSE(normal_request.request()->GetStaleInfo()); |
| 1954 | |
| 1955 | // Second NONE query expected to complete synchronously with cache hit. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1956 | ResolveHostResponseHelper cache_hit_request(resolver_->CreateRequest( |
| 1957 | HostPortPair("just.testing", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1958 | source_none_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1959 | EXPECT_TRUE(cache_hit_request.complete()); |
| 1960 | EXPECT_THAT(cache_hit_request.result_error(), IsOk()); |
| 1961 | EXPECT_THAT( |
| 1962 | cache_hit_request.request()->GetAddressResults().value().endpoints(), |
| 1963 | testing::ElementsAre(CreateExpected("192.168.1.42", 80))); |
| 1964 | EXPECT_FALSE(cache_hit_request.request()->GetStaleInfo().value().is_stale()); |
| 1965 | } |
| 1966 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 1967 | TEST_F(HostResolverManagerTest, LocalOnly_StaleEntry) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1968 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 1969 | proc_->SignalMultiple(1u); // Need only one. |
| 1970 | |
| 1971 | HostResolver::ResolveHostParameters source_none_parameters; |
| 1972 | source_none_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 1973 | |
| 1974 | // First NONE query expected to complete synchronously with a cache miss. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1975 | ResolveHostResponseHelper cache_miss_request(resolver_->CreateRequest( |
| 1976 | HostPortPair("just.testing", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1977 | source_none_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1978 | EXPECT_TRUE(cache_miss_request.complete()); |
| 1979 | EXPECT_THAT(cache_miss_request.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 1980 | EXPECT_FALSE(cache_miss_request.request()->GetAddressResults()); |
| 1981 | EXPECT_FALSE(cache_miss_request.request()->GetStaleInfo()); |
| 1982 | |
| 1983 | // Normal query to populate the cache. |
| 1984 | ResolveHostResponseHelper normal_request(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1985 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1986 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1987 | EXPECT_THAT(normal_request.result_error(), IsOk()); |
| 1988 | EXPECT_FALSE(normal_request.request()->GetStaleInfo()); |
| 1989 | |
| 1990 | MakeCacheStale(); |
| 1991 | |
| 1992 | // Second NONE query still expected to complete synchronously with cache miss. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 1993 | ResolveHostResponseHelper stale_request(resolver_->CreateRequest( |
| 1994 | HostPortPair("just.testing", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 1995 | source_none_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 1996 | EXPECT_TRUE(stale_request.complete()); |
| 1997 | EXPECT_THAT(stale_request.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 1998 | EXPECT_FALSE(stale_request.request()->GetAddressResults()); |
| 1999 | EXPECT_FALSE(stale_request.request()->GetStaleInfo()); |
| 2000 | } |
| 2001 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2002 | TEST_F(HostResolverManagerTest, LocalOnly_FromIp) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2003 | HostResolver::ResolveHostParameters source_none_parameters; |
| 2004 | source_none_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 2005 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2006 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2007 | HostPortPair("1.2.3.4", 56), NetLogWithSource(), source_none_parameters, |
| 2008 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2009 | |
| 2010 | // Expected to resolve synchronously. |
| 2011 | EXPECT_TRUE(response.complete()); |
| 2012 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2013 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2014 | testing::ElementsAre(CreateExpected("1.2.3.4", 56))); |
| 2015 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
| 2016 | } |
| 2017 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2018 | TEST_F(HostResolverManagerTest, LocalOnly_InvalidName) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2019 | proc_->AddRuleForAllFamilies("foo,bar.com", "192.168.1.42"); |
| 2020 | |
| 2021 | HostResolver::ResolveHostParameters source_none_parameters; |
| 2022 | source_none_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 2023 | |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2024 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2025 | HostPortPair("foo,bar.com", 57), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2026 | source_none_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2027 | |
| 2028 | // Expected to fail synchronously. |
| 2029 | EXPECT_TRUE(response.complete()); |
| 2030 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2031 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2032 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
| 2033 | } |
| 2034 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2035 | TEST_F(HostResolverManagerTest, LocalOnly_InvalidLocalhost) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2036 | HostResolver::ResolveHostParameters source_none_parameters; |
| 2037 | source_none_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 2038 | |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2039 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2040 | HostPortPair("foo,bar.localhost", 58), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2041 | source_none_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2042 | |
| 2043 | // Expected to fail synchronously. |
| 2044 | EXPECT_TRUE(response.complete()); |
| 2045 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2046 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2047 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
| 2048 | } |
| 2049 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2050 | TEST_F(HostResolverManagerTest, StaleAllowed) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2051 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 2052 | proc_->SignalMultiple(1u); // Need only one. |
| 2053 | |
| 2054 | HostResolver::ResolveHostParameters stale_allowed_parameters; |
| 2055 | stale_allowed_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 2056 | stale_allowed_parameters.cache_usage = |
| 2057 | HostResolver::ResolveHostParameters::CacheUsage::STALE_ALLOWED; |
| 2058 | |
| 2059 | // First query expected to complete synchronously as a cache miss. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2060 | ResolveHostResponseHelper cache_miss_request(resolver_->CreateRequest( |
| 2061 | HostPortPair("just.testing", 80), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2062 | stale_allowed_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2063 | EXPECT_TRUE(cache_miss_request.complete()); |
| 2064 | EXPECT_THAT(cache_miss_request.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 2065 | EXPECT_FALSE(cache_miss_request.request()->GetAddressResults()); |
| 2066 | EXPECT_FALSE(cache_miss_request.request()->GetStaleInfo()); |
| 2067 | |
| 2068 | // Normal query to populate cache |
| 2069 | ResolveHostResponseHelper normal_request(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2070 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2071 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2072 | EXPECT_THAT(normal_request.result_error(), IsOk()); |
| 2073 | EXPECT_FALSE(normal_request.request()->GetStaleInfo()); |
| 2074 | |
| 2075 | MakeCacheStale(); |
| 2076 | |
| 2077 | // Second NONE query expected to get a stale cache hit. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2078 | ResolveHostResponseHelper stale_request(resolver_->CreateRequest( |
| 2079 | HostPortPair("just.testing", 84), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2080 | stale_allowed_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2081 | EXPECT_TRUE(stale_request.complete()); |
| 2082 | EXPECT_THAT(stale_request.result_error(), IsOk()); |
| 2083 | EXPECT_THAT(stale_request.request()->GetAddressResults().value().endpoints(), |
| 2084 | testing::ElementsAre(CreateExpected("192.168.1.42", 84))); |
| 2085 | EXPECT_TRUE(stale_request.request()->GetStaleInfo().value().is_stale()); |
| 2086 | } |
| 2087 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2088 | TEST_F(HostResolverManagerTest, StaleAllowed_NonLocal) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2089 | proc_->AddRuleForAllFamilies("just.testing", "192.168.2.42"); |
| 2090 | proc_->SignalMultiple(1u); // Need only one. |
| 2091 | |
| 2092 | HostResolver::ResolveHostParameters stale_allowed_parameters; |
| 2093 | stale_allowed_parameters.cache_usage = |
| 2094 | HostResolver::ResolveHostParameters::CacheUsage::STALE_ALLOWED; |
| 2095 | |
| 2096 | // Normal non-local resolves should still work normally with the STALE_ALLOWED |
| 2097 | // parameter, and there should be no stale info. |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2098 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2099 | HostPortPair("just.testing", 85), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2100 | stale_allowed_parameters, request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2101 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2102 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2103 | testing::ElementsAre(CreateExpected("192.168.2.42", 85))); |
| 2104 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
| 2105 | } |
| 2106 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2107 | TEST_F(HostResolverManagerTest, StaleAllowed_FromIp) { |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2108 | HostResolver::ResolveHostParameters stale_allowed_parameters; |
| 2109 | stale_allowed_parameters.cache_usage = |
| 2110 | HostResolver::ResolveHostParameters::CacheUsage::STALE_ALLOWED; |
| 2111 | |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2112 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2113 | HostPortPair("1.2.3.4", 57), NetLogWithSource(), stale_allowed_parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2114 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 2115 | |
| 2116 | // Expected to resolve synchronously without stale info. |
| 2117 | EXPECT_TRUE(response.complete()); |
| 2118 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2119 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2120 | testing::ElementsAre(CreateExpected("1.2.3.4", 57))); |
| 2121 | EXPECT_FALSE(response.request()->GetStaleInfo()); |
| 2122 | } |
| 2123 | |
Miriam Gershenson | e3bc6302 | 2017-10-09 19:57:05 | [diff] [blame] | 2124 | // TODO(mgersh): add a test case for errors with positive TTL after |
| 2125 | // https://crbug.com/115051 is fixed. |
| 2126 | |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 2127 | // Test the retry attempts simulating host resolver proc that takes too long. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2128 | TEST_F(HostResolverManagerTest, MultipleAttempts) { |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 2129 | // Total number of attempts would be 3 and we want the 3rd attempt to resolve |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 2130 | // the host. First and second attempt will be forced to wait until they get |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 2131 | // word that a resolution has completed. The 3rd resolution attempt will try |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 2132 | // to get done ASAP, and won't wait. |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 2133 | int kAttemptNumberToResolve = 3; |
| 2134 | int kTotalAttempts = 3; |
| 2135 | |
Eric Orth | 9a03756 | 2018-07-03 21:24:38 | [diff] [blame] | 2136 | // Add a little bit of extra fudge to the delay to allow reasonable |
| 2137 | // flexibility for time > vs >= etc. We don't need to fail the test if we |
| 2138 | // retry at t=6001 instead of t=6000. |
| 2139 | base::TimeDelta kSleepFudgeFactor = base::TimeDelta::FromMilliseconds(1); |
| 2140 | |
[email protected] | 189163e | 2011-05-11 01:48:54 | [diff] [blame] | 2141 | scoped_refptr<LookupAttemptHostResolverProc> resolver_proc( |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2142 | new LookupAttemptHostResolverProc(nullptr, kAttemptNumberToResolve, |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2143 | kTotalAttempts)); |
| 2144 | |
Eric Orth | 5906622 | 2019-03-07 23:52:27 | [diff] [blame] | 2145 | ProcTaskParams params = DefaultParams(resolver_proc.get()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2146 | base::TimeDelta unresponsive_delay = params.unresponsive_delay; |
| 2147 | int retry_factor = params.retry_factor; |
| 2148 | |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 2149 | CreateResolverWithLimitsAndParams(kMaxJobs, params, true /* ipv6_reachable */, |
| 2150 | true /* check_ipv6_on_wifi */); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2151 | |
| 2152 | // Override the current thread task runner, so we can simulate the passage of |
| 2153 | // time and avoid any actual sleeps. |
| 2154 | auto test_task_runner = base::MakeRefCounted<base::TestMockTimeTaskRunner>(); |
| 2155 | base::ScopedClosureRunner task_runner_override_scoped_cleanup = |
| 2156 | base::ThreadTaskRunnerHandle::OverrideForTesting(test_task_runner); |
| 2157 | |
| 2158 | // Resolve "host1". |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2159 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2160 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 2161 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2162 | EXPECT_FALSE(response.complete()); |
| 2163 | |
| 2164 | resolver_proc->WaitForNAttemptsToBeBlocked(1); |
| 2165 | EXPECT_FALSE(response.complete()); |
| 2166 | |
| 2167 | test_task_runner->FastForwardBy(unresponsive_delay + kSleepFudgeFactor); |
| 2168 | resolver_proc->WaitForNAttemptsToBeBlocked(2); |
| 2169 | EXPECT_FALSE(response.complete()); |
| 2170 | |
| 2171 | test_task_runner->FastForwardBy(unresponsive_delay * retry_factor + |
| 2172 | kSleepFudgeFactor); |
| 2173 | |
| 2174 | resolver_proc->WaitForAllAttemptsToFinish(); |
| 2175 | test_task_runner->RunUntilIdle(); |
| 2176 | |
| 2177 | // Resolve returns -4 to indicate that 3rd attempt has resolved the host. |
| 2178 | // Since we're using a TestMockTimeTaskRunner, the RunLoop stuff in |
| 2179 | // result_error() will fail if it actually has to wait, but unless there's an |
| 2180 | // error, the result should be immediately ready by this point. |
| 2181 | EXPECT_EQ(-4, response.result_error()); |
| 2182 | |
| 2183 | // We should be done with retries, but make sure none erroneously happen. |
| 2184 | test_task_runner->FastForwardUntilNoTasksRemain(); |
| 2185 | |
Eric Roman | 21b3923 | 2019-06-28 21:28:21 | [diff] [blame] | 2186 | EXPECT_EQ(resolver_proc->GetTotalAttemptsResolved(), kTotalAttempts); |
| 2187 | } |
| 2188 | |
| 2189 | // Regression test for https://crbug.com/976948. |
| 2190 | // |
| 2191 | // Tests that when the maximum number of retries is set to |
| 2192 | // |HostResolver::ManagerOptions::kDefaultRetryAttempts| the |
| 2193 | // number of retries used is 4 rather than something higher. |
| 2194 | TEST_F(HostResolverManagerTest, DefaultMaxRetryAttempts) { |
| 2195 | auto test_task_runner = base::MakeRefCounted<base::TestMockTimeTaskRunner>(); |
| 2196 | base::ScopedClosureRunner task_runner_override_scoped_cleanup = |
| 2197 | base::ThreadTaskRunnerHandle::OverrideForTesting(test_task_runner); |
| 2198 | |
| 2199 | // Instantiate a ResolverProc that will block all incoming requests. |
| 2200 | auto resolver_proc = base::MakeRefCounted<LookupAttemptHostResolverProc>( |
| 2201 | nullptr, std::numeric_limits<size_t>::max(), |
| 2202 | std::numeric_limits<size_t>::max()); |
| 2203 | |
| 2204 | // This corresponds to kDefaultMaxRetryAttempts in |
| 2205 | // ProcTaskParams::ProcTaskParams(). The correspondence is verified below, |
| 2206 | // since that symbol is not exported. |
| 2207 | const size_t expected_max_retries = 4; |
| 2208 | |
| 2209 | // Use the special value |ManagerOptions::kDefaultRetryAttempts|, which is |
| 2210 | // expected to translate into |expected_num_retries|. |
| 2211 | ASSERT_NE(HostResolver::ManagerOptions::kDefaultRetryAttempts, |
| 2212 | expected_max_retries); |
| 2213 | ProcTaskParams params(resolver_proc.get(), |
| 2214 | HostResolver::ManagerOptions::kDefaultRetryAttempts); |
| 2215 | ASSERT_EQ(params.max_retry_attempts, expected_max_retries); |
| 2216 | |
| 2217 | CreateResolverWithLimitsAndParams(kMaxJobs, params, |
| 2218 | false /* ipv6_reachable */, |
| 2219 | false /* check_ipv6_on_wifi */); |
| 2220 | |
| 2221 | // Resolve "host1". The resolver proc will hang all requests so this |
| 2222 | // resolution should remain stalled until calling SetResolvedAttemptNumber(). |
| 2223 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2224 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 2225 | request_context_.get(), host_cache_.get())); |
| 2226 | EXPECT_FALSE(response.complete()); |
| 2227 | |
| 2228 | // Simulate running the main thread (network task runner) for a long |
| 2229 | // time. Because none of the attempts posted to worker pool can complete, this |
| 2230 | // should cause all of the retry attempts to get posted, according to the |
| 2231 | // exponential backoff schedule. |
| 2232 | test_task_runner->FastForwardBy(base::TimeDelta::FromMinutes(20)); |
| 2233 | |
| 2234 | // Unblock the resolver proc, then wait for all the worker pool and main |
| 2235 | // thread tasks to complete. Note that the call to SetResolvedAttemptNumber(1) |
| 2236 | // will cause all the blocked resolver procs tasks fail with -2. |
| 2237 | resolver_proc->SetResolvedAttemptNumber(1); |
| 2238 | const int kExpectedError = -2; |
| 2239 | base::ThreadPoolInstance::Get()->FlushForTesting(); |
| 2240 | test_task_runner->RunUntilIdle(); |
| 2241 | |
| 2242 | ASSERT_TRUE(response.complete()); |
| 2243 | EXPECT_EQ(kExpectedError, response.result_error()); |
| 2244 | |
| 2245 | // Ensure that the original attempt was executed on the worker pool, as well |
| 2246 | // as the maximum number of allowed retries, and no more. |
| 2247 | EXPECT_EQ(static_cast<int>(expected_max_retries + 1), |
| 2248 | resolver_proc->GetTotalAttemptsResolved()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2249 | } |
| 2250 | |
eroman | 91dd360 | 2015-03-26 03:46:33 | [diff] [blame] | 2251 | // If a host resolves to a list that includes 127.0.53.53, this is treated as |
| 2252 | // an error. 127.0.53.53 is a localhost address, however it has been given a |
eroman | 1efc237c | 2016-12-14 00:00:45 | [diff] [blame] | 2253 | // special significance by ICANN to help surface name collision resulting from |
eroman | 91dd360 | 2015-03-26 03:46:33 | [diff] [blame] | 2254 | // the new gTLDs. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2255 | TEST_F(HostResolverManagerTest, NameCollisionIcann) { |
eroman | 91dd360 | 2015-03-26 03:46:33 | [diff] [blame] | 2256 | proc_->AddRuleForAllFamilies("single", "127.0.53.53"); |
| 2257 | proc_->AddRuleForAllFamilies("multiple", "127.0.0.1,127.0.53.53"); |
| 2258 | proc_->AddRuleForAllFamilies("ipv6", "::127.0.53.53"); |
| 2259 | proc_->AddRuleForAllFamilies("not_reserved1", "53.53.0.127"); |
| 2260 | proc_->AddRuleForAllFamilies("not_reserved2", "127.0.53.54"); |
| 2261 | proc_->AddRuleForAllFamilies("not_reserved3", "10.0.53.53"); |
| 2262 | proc_->SignalMultiple(6u); |
| 2263 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2264 | ResolveHostResponseHelper single_response(resolver_->CreateRequest( |
| 2265 | HostPortPair("single", 80), NetLogWithSource(), base::nullopt, |
| 2266 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2267 | EXPECT_THAT(single_response.result_error(), |
| 2268 | IsError(ERR_ICANN_NAME_COLLISION)); |
| 2269 | EXPECT_FALSE(single_response.request()->GetAddressResults()); |
| 2270 | |
| 2271 | // ERR_ICANN_NAME_COLLISION is cached like any other error, using a fixed TTL |
| 2272 | // for failed entries from proc-based resolver. That said, the fixed TTL is 0, |
| 2273 | // so it should never be cached. |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 2274 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result = |
| 2275 | GetCacheHit(HostCache::Key("single", DnsQueryType::UNSPECIFIED, |
| 2276 | 0 /* host_resolver_flags */, |
| 2277 | HostResolverSource::ANY)); |
| 2278 | EXPECT_FALSE(cache_result); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2279 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2280 | ResolveHostResponseHelper multiple_response(resolver_->CreateRequest( |
| 2281 | HostPortPair("multiple", 80), NetLogWithSource(), base::nullopt, |
| 2282 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2283 | EXPECT_THAT(multiple_response.result_error(), |
| 2284 | IsError(ERR_ICANN_NAME_COLLISION)); |
| 2285 | |
| 2286 | // Resolving an IP literal of 127.0.53.53 however is allowed. |
| 2287 | ResolveHostResponseHelper literal_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2288 | HostPortPair("127.0.53.53", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2289 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2290 | EXPECT_THAT(literal_response.result_error(), IsOk()); |
| 2291 | |
| 2292 | // Moreover the address should not be recognized when embedded in an IPv6 |
| 2293 | // address. |
| 2294 | ResolveHostResponseHelper ipv6_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2295 | HostPortPair("127.0.53.53", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2296 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2297 | EXPECT_THAT(ipv6_response.result_error(), IsOk()); |
| 2298 | |
| 2299 | // Try some other IPs which are similar, but NOT an exact match on |
| 2300 | // 127.0.53.53. |
| 2301 | ResolveHostResponseHelper similar_response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2302 | HostPortPair("not_reserved1", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2303 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2304 | EXPECT_THAT(similar_response1.result_error(), IsOk()); |
| 2305 | |
| 2306 | ResolveHostResponseHelper similar_response2(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2307 | HostPortPair("not_reserved2", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2308 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2309 | EXPECT_THAT(similar_response2.result_error(), IsOk()); |
| 2310 | |
| 2311 | ResolveHostResponseHelper similar_response3(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2312 | HostPortPair("not_reserved3", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2313 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 2314 | EXPECT_THAT(similar_response3.result_error(), IsOk()); |
| 2315 | } |
| 2316 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2317 | TEST_F(HostResolverManagerTest, IsIPv6Reachable) { |
| 2318 | // The real HostResolverManager is needed since TestHostResolverManager will |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 2319 | // bypass the IPv6 reachability tests. |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 2320 | DestroyResolver(); |
| 2321 | host_cache_ = nullptr; |
| 2322 | resolver_ = std::make_unique<HostResolverManager>(DefaultOptions(), nullptr); |
cbentzel | 1906f87 | 2015-06-05 16:25:25 | [diff] [blame] | 2323 | |
sergeyu | b8cdc21 | 2015-05-14 18:50:37 | [diff] [blame] | 2324 | // Verify that two consecutive calls return the same value. |
tfarina | 4283411 | 2016-09-22 13:38:20 | [diff] [blame] | 2325 | TestNetLog test_net_log; |
| 2326 | NetLogWithSource net_log = |
| 2327 | NetLogWithSource::Make(&test_net_log, NetLogSourceType::NONE); |
| 2328 | bool result1 = IsIPv6Reachable(net_log); |
| 2329 | bool result2 = IsIPv6Reachable(net_log); |
sergeyu | b8cdc21 | 2015-05-14 18:50:37 | [diff] [blame] | 2330 | EXPECT_EQ(result1, result2); |
| 2331 | |
| 2332 | // Filter reachability check events and verify that there are two of them. |
Eric Roman | 79cc755 | 2019-07-19 02:17:54 | [diff] [blame] | 2333 | auto probe_event_list = test_net_log.GetEntriesWithType( |
| 2334 | NetLogEventType::HOST_RESOLVER_IMPL_IPV6_REACHABILITY_CHECK); |
sergeyu | b8cdc21 | 2015-05-14 18:50:37 | [diff] [blame] | 2335 | ASSERT_EQ(2U, probe_event_list.size()); |
| 2336 | |
| 2337 | // Verify that the first request was not cached and the second one was. |
Eric Roman | 79cc755 | 2019-07-19 02:17:54 | [diff] [blame] | 2338 | EXPECT_FALSE(GetBooleanValueFromParams(probe_event_list[0], "cached")); |
| 2339 | EXPECT_TRUE(GetBooleanValueFromParams(probe_event_list[1], "cached")); |
sergeyu | b8cdc21 | 2015-05-14 18:50:37 | [diff] [blame] | 2340 | } |
| 2341 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2342 | TEST_F(HostResolverManagerTest, IncludeCanonicalName) { |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 2343 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42", |
| 2344 | HOST_RESOLVER_CANONNAME, "canon.name"); |
| 2345 | proc_->SignalMultiple(2u); |
| 2346 | |
| 2347 | HostResolver::ResolveHostParameters parameters; |
| 2348 | parameters.include_canonical_name = true; |
| 2349 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2350 | HostPortPair("just.testing", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2351 | request_context_.get(), host_cache_.get())); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 2352 | ResolveHostResponseHelper response_no_flag(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2353 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2354 | request_context_.get(), host_cache_.get())); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 2355 | |
| 2356 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2357 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2358 | testing::ElementsAre(CreateExpected("192.168.1.42", 80))); |
| 2359 | EXPECT_EQ("canon.name", |
| 2360 | response.request()->GetAddressResults().value().canonical_name()); |
| 2361 | |
| 2362 | EXPECT_THAT(response_no_flag.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2363 | } |
| 2364 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2365 | TEST_F(HostResolverManagerTest, LoopbackOnly) { |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 2366 | proc_->AddRuleForAllFamilies("otherlocal", "127.0.0.1", |
| 2367 | HOST_RESOLVER_LOOPBACK_ONLY); |
| 2368 | proc_->SignalMultiple(2u); |
| 2369 | |
| 2370 | HostResolver::ResolveHostParameters parameters; |
| 2371 | parameters.loopback_only = true; |
| 2372 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2373 | HostPortPair("otherlocal", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2374 | request_context_.get(), host_cache_.get())); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 2375 | ResolveHostResponseHelper response_no_flag(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2376 | HostPortPair("otherlocal", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2377 | request_context_.get(), host_cache_.get())); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 2378 | |
| 2379 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2380 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2381 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 2382 | |
| 2383 | EXPECT_THAT(response_no_flag.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2384 | } |
| 2385 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2386 | TEST_F(HostResolverManagerTest, IsSpeculative) { |
Eric Orth | b30bc17 | 2018-08-17 21:09:57 | [diff] [blame] | 2387 | proc_->AddRuleForAllFamilies("just.testing", "192.168.1.42"); |
| 2388 | proc_->SignalMultiple(1u); |
| 2389 | |
| 2390 | HostResolver::ResolveHostParameters parameters; |
| 2391 | parameters.is_speculative = true; |
| 2392 | |
| 2393 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2394 | HostPortPair("just.testing", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2395 | request_context_.get(), host_cache_.get())); |
Eric Orth | b30bc17 | 2018-08-17 21:09:57 | [diff] [blame] | 2396 | |
| 2397 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2398 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2399 | |
| 2400 | ASSERT_EQ(1u, proc_->GetCaptureList().size()); |
| 2401 | EXPECT_EQ("just.testing", proc_->GetCaptureList()[0].hostname); |
| 2402 | |
| 2403 | // Reresolve without the |is_speculative| flag should immediately return from |
| 2404 | // cache. |
| 2405 | ResolveHostResponseHelper response2(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2406 | HostPortPair("just.testing", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2407 | request_context_.get(), host_cache_.get())); |
Eric Orth | b30bc17 | 2018-08-17 21:09:57 | [diff] [blame] | 2408 | |
| 2409 | EXPECT_THAT(response2.result_error(), IsOk()); |
| 2410 | EXPECT_THAT(response2.request()->GetAddressResults().value().endpoints(), |
| 2411 | testing::ElementsAre(CreateExpected("192.168.1.42", 80))); |
| 2412 | |
| 2413 | EXPECT_EQ("just.testing", proc_->GetCaptureList()[0].hostname); |
| 2414 | EXPECT_EQ(1u, proc_->GetCaptureList().size()); // No increase. |
| 2415 | } |
| 2416 | |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2417 | #if BUILDFLAG(ENABLE_MDNS) |
| 2418 | const uint8_t kMdnsResponseA[] = { |
| 2419 | // Header |
| 2420 | 0x00, 0x00, // ID is zeroed out |
| 2421 | 0x81, 0x80, // Standard query response, RA, no error |
| 2422 | 0x00, 0x00, // No questions (for simplicity) |
| 2423 | 0x00, 0x01, // 1 RR (answers) |
| 2424 | 0x00, 0x00, // 0 authority RRs |
| 2425 | 0x00, 0x00, // 0 additional RRs |
| 2426 | |
| 2427 | // "myhello.local." |
| 2428 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2429 | 0x00, |
| 2430 | |
| 2431 | 0x00, 0x01, // TYPE is A. |
| 2432 | 0x00, 0x01, // CLASS is IN. |
| 2433 | 0x00, 0x00, 0x00, 0x10, // TTL is 16 (seconds) |
| 2434 | 0x00, 0x04, // RDLENGTH is 4 bytes. |
| 2435 | 0x01, 0x02, 0x03, 0x04, // 1.2.3.4 |
| 2436 | }; |
| 2437 | |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 2438 | const uint8_t kMdnsResponseA2[] = { |
| 2439 | // Header |
| 2440 | 0x00, 0x00, // ID is zeroed out |
| 2441 | 0x81, 0x80, // Standard query response, RA, no error |
| 2442 | 0x00, 0x00, // No questions (for simplicity) |
| 2443 | 0x00, 0x01, // 1 RR (answers) |
| 2444 | 0x00, 0x00, // 0 authority RRs |
| 2445 | 0x00, 0x00, // 0 additional RRs |
| 2446 | |
| 2447 | // "myhello.local." |
| 2448 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2449 | 0x00, |
| 2450 | |
| 2451 | 0x00, 0x01, // TYPE is A. |
| 2452 | 0x00, 0x01, // CLASS is IN. |
| 2453 | 0x00, 0x00, 0x00, 0x10, // TTL is 16 (seconds) |
| 2454 | 0x00, 0x04, // RDLENGTH is 4 bytes. |
| 2455 | 0x05, 0x06, 0x07, 0x08, // 5.6.7.8 |
| 2456 | }; |
| 2457 | |
| 2458 | const uint8_t kMdnsResponseA2Goodbye[] = { |
| 2459 | // Header |
| 2460 | 0x00, 0x00, // ID is zeroed out |
| 2461 | 0x81, 0x80, // Standard query response, RA, no error |
| 2462 | 0x00, 0x00, // No questions (for simplicity) |
| 2463 | 0x00, 0x01, // 1 RR (answers) |
| 2464 | 0x00, 0x00, // 0 authority RRs |
| 2465 | 0x00, 0x00, // 0 additional RRs |
| 2466 | |
| 2467 | // "myhello.local." |
| 2468 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2469 | 0x00, |
| 2470 | |
| 2471 | 0x00, 0x01, // TYPE is A. |
| 2472 | 0x00, 0x01, // CLASS is IN. |
| 2473 | 0x00, 0x00, 0x00, 0x00, // TTL is 0 (signaling "goodbye" removal of result) |
| 2474 | 0x00, 0x04, // RDLENGTH is 4 bytes. |
| 2475 | 0x05, 0x06, 0x07, 0x08, // 5.6.7.8 |
| 2476 | }; |
| 2477 | |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2478 | const uint8_t kMdnsResponseAAAA[] = { |
| 2479 | // Header |
| 2480 | 0x00, 0x00, // ID is zeroed out |
| 2481 | 0x81, 0x80, // Standard query response, RA, no error |
| 2482 | 0x00, 0x00, // No questions (for simplicity) |
| 2483 | 0x00, 0x01, // 1 RR (answers) |
| 2484 | 0x00, 0x00, // 0 authority RRs |
| 2485 | 0x00, 0x00, // 0 additional RRs |
| 2486 | |
| 2487 | // "myhello.local." |
| 2488 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2489 | 0x00, |
| 2490 | |
| 2491 | 0x00, 0x1C, // TYPE is AAAA. |
| 2492 | 0x00, 0x01, // CLASS is IN. |
| 2493 | 0x00, 0x00, 0x00, 0x10, // TTL is 16 (seconds) |
| 2494 | 0x00, 0x10, // RDLENGTH is 16 bytes. |
| 2495 | |
| 2496 | // 000a:0000:0000:0000:0001:0002:0003:0004 |
| 2497 | 0x00, 0x0A, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x02, |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2498 | 0x00, 0x03, 0x00, 0x04}; |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2499 | |
| 2500 | // An MDNS response indicating that the responder owns the hostname, but the |
| 2501 | // specific requested type (AAAA) does not exist because the responder only has |
| 2502 | // A addresses. |
| 2503 | const uint8_t kMdnsResponseNsec[] = { |
| 2504 | // Header |
| 2505 | 0x00, 0x00, // ID is zeroed out |
| 2506 | 0x81, 0x80, // Standard query response, RA, no error |
| 2507 | 0x00, 0x00, // No questions (for simplicity) |
| 2508 | 0x00, 0x01, // 1 RR (answers) |
| 2509 | 0x00, 0x00, // 0 authority RRs |
| 2510 | 0x00, 0x00, // 0 additional RRs |
| 2511 | |
| 2512 | // "myhello.local." |
| 2513 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2514 | 0x00, |
| 2515 | |
| 2516 | 0x00, 0x2f, // TYPE is NSEC. |
| 2517 | 0x00, 0x01, // CLASS is IN. |
| 2518 | 0x00, 0x00, 0x00, 0x10, // TTL is 16 (seconds) |
| 2519 | 0x00, 0x06, // RDLENGTH is 6 bytes. |
| 2520 | 0xc0, 0x0c, // Next Domain Name (always pointer back to name in MDNS) |
| 2521 | 0x00, // Bitmap block number (always 0 in MDNS) |
| 2522 | 0x02, // Bitmap length is 2 |
| 2523 | 0x00, 0x08 // A type only |
| 2524 | }; |
| 2525 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2526 | const uint8_t kMdnsResponseTxt[] = { |
| 2527 | // Header |
| 2528 | 0x00, 0x00, // ID is zeroed out |
| 2529 | 0x81, 0x80, // Standard query response, RA, no error |
| 2530 | 0x00, 0x00, // No questions (for simplicity) |
| 2531 | 0x00, 0x01, // 1 RR (answers) |
| 2532 | 0x00, 0x00, // 0 authority RRs |
| 2533 | 0x00, 0x00, // 0 additional RRs |
| 2534 | |
| 2535 | // "myhello.local." |
| 2536 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2537 | 0x00, |
| 2538 | |
| 2539 | 0x00, 0x10, // TYPE is TXT. |
| 2540 | 0x00, 0x01, // CLASS is IN. |
| 2541 | 0x00, 0x00, 0x00, 0x11, // TTL is 17 (seconds) |
| 2542 | 0x00, 0x08, // RDLENGTH is 8 bytes. |
| 2543 | |
| 2544 | // "foo" |
| 2545 | 0x03, 0x66, 0x6f, 0x6f, |
| 2546 | // "bar" |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2547 | 0x03, 0x62, 0x61, 0x72}; |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2548 | |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 2549 | const uint8_t kMdnsResponsePtr[] = { |
| 2550 | // Header |
| 2551 | 0x00, 0x00, // ID is zeroed out |
| 2552 | 0x81, 0x80, // Standard query response, RA, no error |
| 2553 | 0x00, 0x00, // No questions (for simplicity) |
| 2554 | 0x00, 0x01, // 1 RR (answers) |
| 2555 | 0x00, 0x00, // 0 authority RRs |
| 2556 | 0x00, 0x00, // 0 additional RRs |
| 2557 | |
| 2558 | // "myhello.local." |
| 2559 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2560 | 0x00, |
| 2561 | |
| 2562 | 0x00, 0x0c, // TYPE is PTR. |
| 2563 | 0x00, 0x01, // CLASS is IN. |
| 2564 | 0x00, 0x00, 0x00, 0x12, // TTL is 18 (seconds) |
| 2565 | 0x00, 0x09, // RDLENGTH is 9 bytes. |
| 2566 | |
| 2567 | // "foo.com." |
| 2568 | 0x03, 'f', 'o', 'o', 0x03, 'c', 'o', 'm', 0x00}; |
| 2569 | |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 2570 | const uint8_t kMdnsResponsePtrRoot[] = { |
| 2571 | // Header |
| 2572 | 0x00, 0x00, // ID is zeroed out |
| 2573 | 0x81, 0x80, // Standard query response, RA, no error |
| 2574 | 0x00, 0x00, // No questions (for simplicity) |
| 2575 | 0x00, 0x01, // 1 RR (answers) |
| 2576 | 0x00, 0x00, // 0 authority RRs |
| 2577 | 0x00, 0x00, // 0 additional RRs |
| 2578 | |
| 2579 | // "myhello.local." |
| 2580 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2581 | 0x00, |
| 2582 | |
| 2583 | 0x00, 0x0c, // TYPE is PTR. |
| 2584 | 0x00, 0x01, // CLASS is IN. |
| 2585 | 0x00, 0x00, 0x00, 0x13, // TTL is 19 (seconds) |
| 2586 | 0x00, 0x01, // RDLENGTH is 1 byte. |
| 2587 | |
| 2588 | // "." (the root domain) |
| 2589 | 0x00}; |
| 2590 | |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 2591 | const uint8_t kMdnsResponseSrv[] = { |
| 2592 | // Header |
| 2593 | 0x00, 0x00, // ID is zeroed out |
| 2594 | 0x81, 0x80, // Standard query response, RA, no error |
| 2595 | 0x00, 0x00, // No questions (for simplicity) |
| 2596 | 0x00, 0x01, // 1 RR (answers) |
| 2597 | 0x00, 0x00, // 0 authority RRs |
| 2598 | 0x00, 0x00, // 0 additional RRs |
| 2599 | |
| 2600 | // "myhello.local." |
| 2601 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2602 | 0x00, |
| 2603 | |
| 2604 | 0x00, 0x21, // TYPE is SRV. |
| 2605 | 0x00, 0x01, // CLASS is IN. |
| 2606 | 0x00, 0x00, 0x00, 0x13, // TTL is 19 (seconds) |
| 2607 | 0x00, 0x0f, // RDLENGTH is 15 bytes. |
| 2608 | |
| 2609 | 0x00, 0x05, // Priority 5 |
| 2610 | 0x00, 0x01, // Weight 1 |
| 2611 | 0x20, 0x49, // Port 8265 |
| 2612 | |
| 2613 | // "foo.com." |
| 2614 | 0x03, 'f', 'o', 'o', 0x03, 'c', 'o', 'm', 0x00}; |
| 2615 | |
Bailey Berro | e70f06c | 2019-03-11 22:22:46 | [diff] [blame] | 2616 | const uint8_t kMdnsResponseSrvUnrestricted[] = { |
| 2617 | // Header |
| 2618 | 0x00, 0x00, // ID is zeroed out |
| 2619 | 0x81, 0x80, // Standard query response, RA, no error |
| 2620 | 0x00, 0x00, // No questions (for simplicity) |
| 2621 | 0x00, 0x01, // 1 RR (answers) |
| 2622 | 0x00, 0x00, // 0 authority RRs |
| 2623 | 0x00, 0x00, // 0 additional RRs |
| 2624 | |
| 2625 | // "foo bar(A1B2)._ipps._tcp.local" |
| 2626 | 0x0d, 'f', 'o', 'o', ' ', 'b', 'a', 'r', '(', 'A', '1', 'B', '2', ')', 0x05, |
| 2627 | '_', 'i', 'p', 'p', 's', 0x04, '_', 't', 'c', 'p', 0x05, 'l', 'o', 'c', 'a', |
| 2628 | 'l', 0x00, |
| 2629 | |
| 2630 | 0x00, 0x21, // TYPE is SRV. |
| 2631 | 0x00, 0x01, // CLASS is IN. |
| 2632 | 0x00, 0x00, 0x00, 0x13, // TTL is 19 (seconds) |
| 2633 | 0x00, 0x0f, // RDLENGTH is 15 bytes. |
| 2634 | |
| 2635 | 0x00, 0x05, // Priority 5 |
| 2636 | 0x00, 0x01, // Weight 1 |
| 2637 | 0x20, 0x49, // Port 8265 |
| 2638 | |
| 2639 | // "foo.com." |
| 2640 | 0x03, 'f', 'o', 'o', 0x03, 'c', 'o', 'm', 0x00}; |
| 2641 | |
| 2642 | const uint8_t kMdnsResponseSrvUnrestrictedResult[] = { |
| 2643 | // Header |
| 2644 | 0x00, 0x00, // ID is zeroed out |
| 2645 | 0x81, 0x80, // Standard query response, RA, no error |
| 2646 | 0x00, 0x00, // No questions (for simplicity) |
| 2647 | 0x00, 0x01, // 1 RR (answers) |
| 2648 | 0x00, 0x00, // 0 authority RRs |
| 2649 | 0x00, 0x00, // 0 additional RRs |
| 2650 | |
| 2651 | // "myhello.local." |
| 2652 | 0x07, 'm', 'y', 'h', 'e', 'l', 'l', 'o', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2653 | 0x00, |
| 2654 | |
| 2655 | 0x00, 0x21, // TYPE is SRV. |
| 2656 | 0x00, 0x01, // CLASS is IN. |
| 2657 | 0x00, 0x00, 0x00, 0x13, // TTL is 19 (seconds) |
| 2658 | 0x00, 0x15, // RDLENGTH is 21 bytes. |
| 2659 | |
| 2660 | 0x00, 0x05, // Priority 5 |
| 2661 | 0x00, 0x01, // Weight 1 |
| 2662 | 0x20, 0x49, // Port 8265 |
| 2663 | |
| 2664 | // "foo bar.local" |
| 2665 | 0x07, 'f', 'o', 'o', ' ', 'b', 'a', 'r', 0x05, 'l', 'o', 'c', 'a', 'l', |
| 2666 | 0x00}; |
| 2667 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2668 | TEST_F(HostResolverManagerTest, Mdns) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2669 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2670 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2671 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2672 | // 2 socket creations for every transaction. |
| 2673 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(4); |
| 2674 | |
| 2675 | HostResolver::ResolveHostParameters parameters; |
| 2676 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2677 | |
| 2678 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2679 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2680 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2681 | |
| 2682 | socket_factory_ptr->SimulateReceive(kMdnsResponseA, sizeof(kMdnsResponseA)); |
| 2683 | socket_factory_ptr->SimulateReceive(kMdnsResponseAAAA, |
| 2684 | sizeof(kMdnsResponseAAAA)); |
| 2685 | |
| 2686 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2687 | EXPECT_THAT( |
| 2688 | response.request()->GetAddressResults().value().endpoints(), |
| 2689 | testing::UnorderedElementsAre( |
| 2690 | CreateExpected("1.2.3.4", 80), |
| 2691 | CreateExpected("000a:0000:0000:0000:0001:0002:0003:0004", 80))); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2692 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2693 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2694 | } |
| 2695 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2696 | TEST_F(HostResolverManagerTest, Mdns_AaaaOnly) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2697 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2698 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2699 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2700 | // 2 socket creations for every transaction. |
| 2701 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 2702 | |
| 2703 | HostResolver::ResolveHostParameters parameters; |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 2704 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2705 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2706 | |
| 2707 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2708 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2709 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2710 | |
| 2711 | socket_factory_ptr->SimulateReceive(kMdnsResponseAAAA, |
| 2712 | sizeof(kMdnsResponseAAAA)); |
| 2713 | |
| 2714 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2715 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2716 | testing::ElementsAre(CreateExpected( |
| 2717 | "000a:0000:0000:0000:0001:0002:0003:0004", 80))); |
| 2718 | } |
| 2719 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2720 | TEST_F(HostResolverManagerTest, Mdns_Txt) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2721 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2722 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2723 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2724 | // 2 socket creations for every transaction. |
| 2725 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 2726 | |
| 2727 | HostResolver::ResolveHostParameters parameters; |
| 2728 | parameters.dns_query_type = DnsQueryType::TXT; |
| 2729 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2730 | |
| 2731 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2732 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2733 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2734 | |
| 2735 | socket_factory_ptr->SimulateReceive(kMdnsResponseTxt, |
| 2736 | sizeof(kMdnsResponseTxt)); |
| 2737 | |
| 2738 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2739 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2740 | EXPECT_THAT(response.request()->GetTextResults(), |
| 2741 | testing::Optional(testing::ElementsAre("foo", "bar"))); |
| 2742 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 2743 | } |
| 2744 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2745 | TEST_F(HostResolverManagerTest, Mdns_Ptr) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 2746 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2747 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2748 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2749 | // 2 socket creations for every transaction. |
| 2750 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 2751 | |
| 2752 | HostResolver::ResolveHostParameters parameters; |
| 2753 | parameters.dns_query_type = DnsQueryType::PTR; |
| 2754 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2755 | |
| 2756 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2757 | HostPortPair("myhello.local", 83), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2758 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 2759 | |
| 2760 | socket_factory_ptr->SimulateReceive(kMdnsResponsePtr, |
| 2761 | sizeof(kMdnsResponsePtr)); |
| 2762 | |
| 2763 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2764 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2765 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2766 | EXPECT_THAT( |
| 2767 | response.request()->GetHostnameResults(), |
| 2768 | testing::Optional(testing::ElementsAre(HostPortPair("foo.com", 83)))); |
| 2769 | } |
| 2770 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2771 | TEST_F(HostResolverManagerTest, Mdns_Srv) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 2772 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2773 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2774 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2775 | // 2 socket creations for every transaction. |
| 2776 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 2777 | |
| 2778 | HostResolver::ResolveHostParameters parameters; |
| 2779 | parameters.dns_query_type = DnsQueryType::SRV; |
| 2780 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2781 | |
| 2782 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2783 | HostPortPair("myhello.local", 83), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2784 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 2785 | |
| 2786 | socket_factory_ptr->SimulateReceive(kMdnsResponseSrv, |
| 2787 | sizeof(kMdnsResponseSrv)); |
| 2788 | |
| 2789 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2790 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2791 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2792 | EXPECT_THAT( |
| 2793 | response.request()->GetHostnameResults(), |
| 2794 | testing::Optional(testing::ElementsAre(HostPortPair("foo.com", 8265)))); |
| 2795 | } |
| 2796 | |
Bailey Berro | e70f06c | 2019-03-11 22:22:46 | [diff] [blame] | 2797 | // Test that we are able to create multicast DNS requests that contain |
| 2798 | // characters not permitted in the DNS spec such as spaces and parenthesis. |
| 2799 | TEST_F(HostResolverManagerTest, Mdns_Srv_Unrestricted) { |
| 2800 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2801 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2802 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2803 | |
| 2804 | HostResolver::ResolveHostParameters parameters; |
| 2805 | parameters.dns_query_type = DnsQueryType::SRV; |
| 2806 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2807 | |
| 2808 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 2809 | HostPortPair("foo bar(A1B2)._ipps._tcp.local", 83), NetLogWithSource(), |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2810 | parameters, request_context_.get(), host_cache_.get())); |
Bailey Berro | e70f06c | 2019-03-11 22:22:46 | [diff] [blame] | 2811 | |
| 2812 | socket_factory_ptr->SimulateReceive(kMdnsResponseSrvUnrestricted, |
| 2813 | sizeof(kMdnsResponseSrvUnrestricted)); |
| 2814 | |
| 2815 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2816 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2817 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2818 | EXPECT_THAT( |
| 2819 | response.request()->GetHostnameResults(), |
| 2820 | testing::Optional(testing::ElementsAre(HostPortPair("foo.com", 8265)))); |
| 2821 | } |
| 2822 | |
| 2823 | // Test that we are able to create multicast DNS requests that contain |
| 2824 | // characters not permitted in the DNS spec such as spaces and parenthesis. |
| 2825 | TEST_F(HostResolverManagerTest, Mdns_Srv_Result_Unrestricted) { |
| 2826 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2827 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2828 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2829 | |
| 2830 | HostResolver::ResolveHostParameters parameters; |
| 2831 | parameters.dns_query_type = DnsQueryType::SRV; |
| 2832 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2833 | |
| 2834 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2835 | HostPortPair("myhello.local", 83), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2836 | request_context_.get(), host_cache_.get())); |
Bailey Berro | e70f06c | 2019-03-11 22:22:46 | [diff] [blame] | 2837 | |
| 2838 | socket_factory_ptr->SimulateReceive( |
| 2839 | kMdnsResponseSrvUnrestrictedResult, |
| 2840 | sizeof(kMdnsResponseSrvUnrestrictedResult)); |
| 2841 | |
| 2842 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2843 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2844 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2845 | EXPECT_THAT(response.request()->GetHostnameResults(), |
| 2846 | testing::Optional( |
| 2847 | testing::ElementsAre(HostPortPair("foo bar.local", 8265)))); |
| 2848 | } |
| 2849 | |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2850 | // Test multicast DNS handling of NSEC responses (used for explicit negative |
| 2851 | // response). |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2852 | TEST_F(HostResolverManagerTest, Mdns_Nsec) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2853 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2854 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2855 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2856 | // 2 socket creations for every transaction. |
| 2857 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 2858 | |
| 2859 | HostResolver::ResolveHostParameters parameters; |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 2860 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2861 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2862 | |
| 2863 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2864 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2865 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2866 | |
| 2867 | socket_factory_ptr->SimulateReceive(kMdnsResponseNsec, |
| 2868 | sizeof(kMdnsResponseNsec)); |
| 2869 | |
| 2870 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2871 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2872 | } |
| 2873 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2874 | TEST_F(HostResolverManagerTest, Mdns_NoResponse) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2875 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2876 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2877 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2878 | // 2 socket creations for every transaction. |
| 2879 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(4); |
| 2880 | |
| 2881 | // Add a little bit of extra fudge to the delay to allow reasonable |
| 2882 | // flexibility for time > vs >= etc. We don't need to fail the test if we |
| 2883 | // timeout at t=6001 instead of t=6000. |
| 2884 | base::TimeDelta kSleepFudgeFactor = base::TimeDelta::FromMilliseconds(1); |
| 2885 | |
| 2886 | // Override the current thread task runner, so we can simulate the passage of |
| 2887 | // time to trigger the timeout. |
| 2888 | auto test_task_runner = base::MakeRefCounted<base::TestMockTimeTaskRunner>(); |
| 2889 | base::ScopedClosureRunner task_runner_override_scoped_cleanup = |
| 2890 | base::ThreadTaskRunnerHandle::OverrideForTesting(test_task_runner); |
| 2891 | |
| 2892 | HostResolver::ResolveHostParameters parameters; |
| 2893 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2894 | |
| 2895 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2896 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2897 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2898 | |
| 2899 | ASSERT_TRUE(test_task_runner->HasPendingTask()); |
| 2900 | test_task_runner->FastForwardBy(MDnsTransaction::kTransactionTimeout + |
| 2901 | kSleepFudgeFactor); |
| 2902 | |
| 2903 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2904 | EXPECT_FALSE(response.request()->GetAddressResults()); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2905 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2906 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 2907 | |
| 2908 | test_task_runner->FastForwardUntilNoTasksRemain(); |
| 2909 | } |
| 2910 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2911 | TEST_F(HostResolverManagerTest, Mdns_WrongType) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2912 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2913 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2914 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2915 | // 2 socket creations for every transaction. |
| 2916 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 2917 | |
| 2918 | // Add a little bit of extra fudge to the delay to allow reasonable |
| 2919 | // flexibility for time > vs >= etc. We don't need to fail the test if we |
| 2920 | // timeout at t=6001 instead of t=6000. |
| 2921 | base::TimeDelta kSleepFudgeFactor = base::TimeDelta::FromMilliseconds(1); |
| 2922 | |
| 2923 | // Override the current thread task runner, so we can simulate the passage of |
| 2924 | // time to trigger the timeout. |
| 2925 | auto test_task_runner = base::MakeRefCounted<base::TestMockTimeTaskRunner>(); |
| 2926 | base::ScopedClosureRunner task_runner_override_scoped_cleanup = |
| 2927 | base::ThreadTaskRunnerHandle::OverrideForTesting(test_task_runner); |
| 2928 | |
| 2929 | HostResolver::ResolveHostParameters parameters; |
| 2930 | parameters.dns_query_type = DnsQueryType::A; |
| 2931 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2932 | |
| 2933 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2934 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2935 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 2936 | |
| 2937 | // Not the requested type. Should be ignored. |
| 2938 | socket_factory_ptr->SimulateReceive(kMdnsResponseTxt, |
| 2939 | sizeof(kMdnsResponseTxt)); |
| 2940 | |
| 2941 | ASSERT_TRUE(test_task_runner->HasPendingTask()); |
| 2942 | test_task_runner->FastForwardBy(MDnsTransaction::kTransactionTimeout + |
| 2943 | kSleepFudgeFactor); |
| 2944 | |
| 2945 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 2946 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 2947 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 2948 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2949 | |
| 2950 | test_task_runner->FastForwardUntilNoTasksRemain(); |
| 2951 | } |
| 2952 | |
| 2953 | // Test for a request for both A and AAAA results where results only exist for |
| 2954 | // one type. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2955 | TEST_F(HostResolverManagerTest, Mdns_PartialResults) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2956 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2957 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2958 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2959 | // 2 socket creations for every transaction. |
| 2960 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(4); |
| 2961 | |
| 2962 | // Add a little bit of extra fudge to the delay to allow reasonable |
| 2963 | // flexibility for time > vs >= etc. We don't need to fail the test if we |
| 2964 | // timeout at t=6001 instead of t=6000. |
| 2965 | base::TimeDelta kSleepFudgeFactor = base::TimeDelta::FromMilliseconds(1); |
| 2966 | |
| 2967 | // Override the current thread task runner, so we can simulate the passage of |
| 2968 | // time to trigger the timeout. |
| 2969 | auto test_task_runner = base::MakeRefCounted<base::TestMockTimeTaskRunner>(); |
| 2970 | base::ScopedClosureRunner task_runner_override_scoped_cleanup = |
| 2971 | base::ThreadTaskRunnerHandle::OverrideForTesting(test_task_runner); |
| 2972 | |
| 2973 | HostResolver::ResolveHostParameters parameters; |
| 2974 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 2975 | |
| 2976 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 2977 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 2978 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2979 | |
| 2980 | ASSERT_TRUE(test_task_runner->HasPendingTask()); |
| 2981 | |
| 2982 | socket_factory_ptr->SimulateReceive(kMdnsResponseA, sizeof(kMdnsResponseA)); |
| 2983 | test_task_runner->FastForwardBy(MDnsTransaction::kTransactionTimeout + |
| 2984 | kSleepFudgeFactor); |
| 2985 | |
| 2986 | EXPECT_THAT(response.result_error(), IsOk()); |
| 2987 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 2988 | testing::ElementsAre(CreateExpected("1.2.3.4", 80))); |
| 2989 | |
| 2990 | test_task_runner->FastForwardUntilNoTasksRemain(); |
| 2991 | } |
| 2992 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 2993 | TEST_F(HostResolverManagerTest, Mdns_Cancel) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 2994 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 2995 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 2996 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 2997 | // 2 socket creations for every transaction. |
| 2998 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(4); |
| 2999 | |
| 3000 | HostResolver::ResolveHostParameters parameters; |
| 3001 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 3002 | |
| 3003 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3004 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3005 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 3006 | |
| 3007 | response.CancelRequest(); |
| 3008 | |
| 3009 | socket_factory_ptr->SimulateReceive(kMdnsResponseA, sizeof(kMdnsResponseA)); |
| 3010 | socket_factory_ptr->SimulateReceive(kMdnsResponseAAAA, |
| 3011 | sizeof(kMdnsResponseAAAA)); |
| 3012 | |
| 3013 | base::RunLoop().RunUntilIdle(); |
| 3014 | EXPECT_FALSE(response.complete()); |
| 3015 | } |
| 3016 | |
| 3017 | // Test for a two-transaction query where the first fails to start. The second |
| 3018 | // should be cancelled. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3019 | TEST_F(HostResolverManagerTest, Mdns_PartialFailure) { |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 3020 | // Setup a mock MDnsClient where the first transaction will always return |
| 3021 | // |false| immediately on Start(). Second transaction may or may not be |
| 3022 | // created, but if it is, Start() not expected to be called because the |
| 3023 | // overall request should immediately fail. |
| 3024 | auto transaction1 = std::make_unique<MockMDnsTransaction>(); |
| 3025 | EXPECT_CALL(*transaction1, Start()).WillOnce(Return(false)); |
| 3026 | auto transaction2 = std::make_unique<MockMDnsTransaction>(); |
| 3027 | EXPECT_CALL(*transaction2, Start()).Times(0); |
| 3028 | |
| 3029 | auto client = std::make_unique<MockMDnsClient>(); |
| 3030 | EXPECT_CALL(*client, CreateTransaction(_, _, _, _)) |
| 3031 | .Times(Between(1, 2)) // Second transaction optionally created. |
| 3032 | .WillOnce(Return(ByMove(std::move(transaction1)))) |
| 3033 | .WillOnce(Return(ByMove(std::move(transaction2)))); |
| 3034 | EXPECT_CALL(*client, IsListening()).WillRepeatedly(Return(true)); |
| 3035 | resolver_->SetMdnsClientForTesting(std::move(client)); |
| 3036 | |
| 3037 | HostResolver::ResolveHostParameters parameters; |
| 3038 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 3039 | |
| 3040 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3041 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3042 | request_context_.get(), host_cache_.get())); |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 3043 | |
| 3044 | EXPECT_THAT(response.result_error(), IsError(ERR_FAILED)); |
| 3045 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 3046 | } |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3047 | |
Eric Orth | e857ebb | 2019-03-13 23:02:07 | [diff] [blame] | 3048 | TEST_F(HostResolverManagerTest, Mdns_ListenFailure) { |
| 3049 | // Inject an MdnsClient mock that will always fail to start listening. |
| 3050 | auto client = std::make_unique<MockMDnsClient>(); |
| 3051 | EXPECT_CALL(*client, StartListening(_)).WillOnce(Return(ERR_FAILED)); |
| 3052 | EXPECT_CALL(*client, IsListening()).WillRepeatedly(Return(false)); |
| 3053 | resolver_->SetMdnsClientForTesting(std::move(client)); |
| 3054 | |
| 3055 | HostResolver::ResolveHostParameters parameters; |
| 3056 | parameters.source = HostResolverSource::MULTICAST_DNS; |
| 3057 | |
| 3058 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3059 | HostPortPair("myhello.local", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3060 | request_context_.get(), host_cache_.get())); |
Eric Orth | e857ebb | 2019-03-13 23:02:07 | [diff] [blame] | 3061 | |
| 3062 | EXPECT_THAT(response.result_error(), IsError(ERR_FAILED)); |
| 3063 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 3064 | } |
| 3065 | |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3066 | // Implementation of HostResolver::MdnsListenerDelegate that records all |
| 3067 | // received results in maps. |
| 3068 | class TestMdnsListenerDelegate : public HostResolver::MdnsListener::Delegate { |
| 3069 | public: |
| 3070 | using UpdateKey = |
| 3071 | std::pair<HostResolver::MdnsListener::Delegate::UpdateType, DnsQueryType>; |
| 3072 | |
| 3073 | void OnAddressResult( |
| 3074 | HostResolver::MdnsListener::Delegate::UpdateType update_type, |
| 3075 | DnsQueryType result_type, |
| 3076 | IPEndPoint address) override { |
| 3077 | address_results_.insert({{update_type, result_type}, std::move(address)}); |
| 3078 | } |
| 3079 | |
| 3080 | void OnTextResult( |
| 3081 | HostResolver::MdnsListener::Delegate::UpdateType update_type, |
| 3082 | DnsQueryType result_type, |
| 3083 | std::vector<std::string> text_records) override { |
| 3084 | for (auto& text_record : text_records) { |
| 3085 | text_results_.insert( |
| 3086 | {{update_type, result_type}, std::move(text_record)}); |
| 3087 | } |
| 3088 | } |
| 3089 | |
| 3090 | void OnHostnameResult( |
| 3091 | HostResolver::MdnsListener::Delegate::UpdateType update_type, |
| 3092 | DnsQueryType result_type, |
| 3093 | HostPortPair host) override { |
| 3094 | hostname_results_.insert({{update_type, result_type}, std::move(host)}); |
| 3095 | } |
| 3096 | |
| 3097 | void OnUnhandledResult( |
| 3098 | HostResolver::MdnsListener::Delegate::UpdateType update_type, |
| 3099 | DnsQueryType result_type) override { |
| 3100 | unhandled_results_.insert({update_type, result_type}); |
| 3101 | } |
| 3102 | |
| 3103 | const std::multimap<UpdateKey, IPEndPoint>& address_results() { |
| 3104 | return address_results_; |
| 3105 | } |
| 3106 | |
| 3107 | const std::multimap<UpdateKey, std::string>& text_results() { |
| 3108 | return text_results_; |
| 3109 | } |
| 3110 | |
| 3111 | const std::multimap<UpdateKey, HostPortPair>& hostname_results() { |
| 3112 | return hostname_results_; |
| 3113 | } |
| 3114 | |
| 3115 | const std::multiset<UpdateKey>& unhandled_results() { |
| 3116 | return unhandled_results_; |
| 3117 | } |
| 3118 | |
| 3119 | template <typename T> |
| 3120 | static std::pair<UpdateKey, T> CreateExpectedResult( |
| 3121 | HostResolver::MdnsListener::Delegate::UpdateType update_type, |
| 3122 | DnsQueryType query_type, |
| 3123 | T result) { |
| 3124 | return std::make_pair(std::make_pair(update_type, query_type), result); |
| 3125 | } |
| 3126 | |
| 3127 | private: |
| 3128 | std::multimap<UpdateKey, IPEndPoint> address_results_; |
| 3129 | std::multimap<UpdateKey, std::string> text_results_; |
| 3130 | std::multimap<UpdateKey, HostPortPair> hostname_results_; |
| 3131 | std::multiset<UpdateKey> unhandled_results_; |
| 3132 | }; |
| 3133 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3134 | TEST_F(HostResolverManagerTest, MdnsListener) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3135 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3136 | base::SimpleTestClock clock; |
| 3137 | clock.SetNow(base::Time::Now()); |
| 3138 | auto cache_cleanup_timer = std::make_unique<base::MockOneShotTimer>(); |
| 3139 | auto* cache_cleanup_timer_ptr = cache_cleanup_timer.get(); |
| 3140 | auto mdns_client = |
| 3141 | std::make_unique<MDnsClientImpl>(&clock, std::move(cache_cleanup_timer)); |
Eric Orth | e857ebb | 2019-03-13 23:02:07 | [diff] [blame] | 3142 | ASSERT_THAT(mdns_client->StartListening(socket_factory.get()), IsOk()); |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3143 | resolver_->SetMdnsClientForTesting(std::move(mdns_client)); |
| 3144 | |
| 3145 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3146 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 80), |
| 3147 | DnsQueryType::A); |
| 3148 | |
| 3149 | TestMdnsListenerDelegate delegate; |
| 3150 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3151 | ASSERT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3152 | |
| 3153 | socket_factory->SimulateReceive(kMdnsResponseA, sizeof(kMdnsResponseA)); |
| 3154 | socket_factory->SimulateReceive(kMdnsResponseA2, sizeof(kMdnsResponseA2)); |
| 3155 | socket_factory->SimulateReceive(kMdnsResponseA2Goodbye, |
| 3156 | sizeof(kMdnsResponseA2Goodbye)); |
| 3157 | |
| 3158 | // Per RFC6762 section 10.1, removals take effect 1 second after receiving the |
| 3159 | // goodbye message. |
| 3160 | clock.Advance(base::TimeDelta::FromSeconds(1)); |
| 3161 | cache_cleanup_timer_ptr->Fire(); |
| 3162 | |
| 3163 | // Expect 1 record adding "1.2.3.4", another changing to "5.6.7.8", and a |
| 3164 | // final removing "5.6.7.8". |
| 3165 | EXPECT_THAT(delegate.address_results(), |
| 3166 | testing::ElementsAre( |
| 3167 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3168 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3169 | DnsQueryType::A, CreateExpected("1.2.3.4", 80)), |
| 3170 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3171 | HostResolver::MdnsListener::Delegate::UpdateType::CHANGED, |
| 3172 | DnsQueryType::A, CreateExpected("5.6.7.8", 80)), |
| 3173 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3174 | HostResolver::MdnsListener::Delegate::UpdateType::REMOVED, |
| 3175 | DnsQueryType::A, CreateExpected("5.6.7.8", 80)))); |
| 3176 | |
| 3177 | EXPECT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3178 | EXPECT_THAT(delegate.hostname_results(), testing::IsEmpty()); |
| 3179 | EXPECT_THAT(delegate.unhandled_results(), testing::IsEmpty()); |
| 3180 | } |
| 3181 | |
Eric Orth | e857ebb | 2019-03-13 23:02:07 | [diff] [blame] | 3182 | TEST_F(HostResolverManagerTest, MdnsListener_StartListenFailure) { |
| 3183 | // Inject an MdnsClient mock that will always fail to start listening. |
| 3184 | auto client = std::make_unique<MockMDnsClient>(); |
| 3185 | EXPECT_CALL(*client, StartListening(_)).WillOnce(Return(ERR_TIMED_OUT)); |
| 3186 | EXPECT_CALL(*client, IsListening()).WillRepeatedly(Return(false)); |
| 3187 | resolver_->SetMdnsClientForTesting(std::move(client)); |
| 3188 | |
| 3189 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3190 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 80), |
| 3191 | DnsQueryType::A); |
| 3192 | TestMdnsListenerDelegate delegate; |
| 3193 | EXPECT_THAT(listener->Start(&delegate), IsError(ERR_TIMED_OUT)); |
| 3194 | EXPECT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3195 | } |
| 3196 | |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3197 | // Test that removal notifications are sent on natural expiration of MDNS |
| 3198 | // records. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3199 | TEST_F(HostResolverManagerTest, MdnsListener_Expiration) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3200 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3201 | base::SimpleTestClock clock; |
| 3202 | clock.SetNow(base::Time::Now()); |
| 3203 | auto cache_cleanup_timer = std::make_unique<base::MockOneShotTimer>(); |
| 3204 | auto* cache_cleanup_timer_ptr = cache_cleanup_timer.get(); |
| 3205 | auto mdns_client = |
| 3206 | std::make_unique<MDnsClientImpl>(&clock, std::move(cache_cleanup_timer)); |
Eric Orth | e857ebb | 2019-03-13 23:02:07 | [diff] [blame] | 3207 | ASSERT_THAT(mdns_client->StartListening(socket_factory.get()), IsOk()); |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3208 | resolver_->SetMdnsClientForTesting(std::move(mdns_client)); |
| 3209 | |
| 3210 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3211 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 100), |
| 3212 | DnsQueryType::A); |
| 3213 | |
| 3214 | TestMdnsListenerDelegate delegate; |
| 3215 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3216 | ASSERT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3217 | |
| 3218 | socket_factory->SimulateReceive(kMdnsResponseA, sizeof(kMdnsResponseA)); |
| 3219 | |
| 3220 | EXPECT_THAT( |
| 3221 | delegate.address_results(), |
| 3222 | testing::ElementsAre(TestMdnsListenerDelegate::CreateExpectedResult( |
| 3223 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3224 | DnsQueryType::A, CreateExpected("1.2.3.4", 100)))); |
| 3225 | |
| 3226 | clock.Advance(base::TimeDelta::FromSeconds(16)); |
| 3227 | cache_cleanup_timer_ptr->Fire(); |
| 3228 | |
| 3229 | EXPECT_THAT(delegate.address_results(), |
| 3230 | testing::ElementsAre( |
| 3231 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3232 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3233 | DnsQueryType::A, CreateExpected("1.2.3.4", 100)), |
| 3234 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3235 | HostResolver::MdnsListener::Delegate::UpdateType::REMOVED, |
| 3236 | DnsQueryType::A, CreateExpected("1.2.3.4", 100)))); |
| 3237 | |
| 3238 | EXPECT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3239 | EXPECT_THAT(delegate.hostname_results(), testing::IsEmpty()); |
| 3240 | EXPECT_THAT(delegate.unhandled_results(), testing::IsEmpty()); |
| 3241 | } |
| 3242 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3243 | TEST_F(HostResolverManagerTest, MdnsListener_Txt) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3244 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3245 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 3246 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 3247 | |
| 3248 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3249 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 12), |
| 3250 | DnsQueryType::TXT); |
| 3251 | |
| 3252 | TestMdnsListenerDelegate delegate; |
| 3253 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3254 | ASSERT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3255 | |
| 3256 | socket_factory_ptr->SimulateReceive(kMdnsResponseTxt, |
| 3257 | sizeof(kMdnsResponseTxt)); |
| 3258 | |
| 3259 | EXPECT_THAT(delegate.text_results(), |
| 3260 | testing::ElementsAre( |
| 3261 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3262 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3263 | DnsQueryType::TXT, "foo"), |
| 3264 | TestMdnsListenerDelegate::CreateExpectedResult( |
| 3265 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3266 | DnsQueryType::TXT, "bar"))); |
| 3267 | |
| 3268 | EXPECT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3269 | EXPECT_THAT(delegate.hostname_results(), testing::IsEmpty()); |
| 3270 | EXPECT_THAT(delegate.unhandled_results(), testing::IsEmpty()); |
| 3271 | } |
| 3272 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3273 | TEST_F(HostResolverManagerTest, MdnsListener_Ptr) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3274 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3275 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 3276 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 3277 | |
| 3278 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3279 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 13), |
| 3280 | DnsQueryType::PTR); |
| 3281 | |
| 3282 | TestMdnsListenerDelegate delegate; |
| 3283 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3284 | ASSERT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3285 | |
| 3286 | socket_factory_ptr->SimulateReceive(kMdnsResponsePtr, |
| 3287 | sizeof(kMdnsResponsePtr)); |
| 3288 | |
| 3289 | EXPECT_THAT( |
| 3290 | delegate.hostname_results(), |
| 3291 | testing::ElementsAre(TestMdnsListenerDelegate::CreateExpectedResult( |
| 3292 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3293 | DnsQueryType::PTR, HostPortPair("foo.com", 13)))); |
| 3294 | |
| 3295 | EXPECT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3296 | EXPECT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3297 | EXPECT_THAT(delegate.unhandled_results(), testing::IsEmpty()); |
| 3298 | } |
| 3299 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3300 | TEST_F(HostResolverManagerTest, MdnsListener_Srv) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3301 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3302 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 3303 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 3304 | |
| 3305 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3306 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 14), |
| 3307 | DnsQueryType::SRV); |
| 3308 | |
| 3309 | TestMdnsListenerDelegate delegate; |
| 3310 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3311 | ASSERT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3312 | |
| 3313 | socket_factory_ptr->SimulateReceive(kMdnsResponseSrv, |
| 3314 | sizeof(kMdnsResponseSrv)); |
| 3315 | |
| 3316 | EXPECT_THAT( |
| 3317 | delegate.hostname_results(), |
| 3318 | testing::ElementsAre(TestMdnsListenerDelegate::CreateExpectedResult( |
| 3319 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3320 | DnsQueryType::SRV, HostPortPair("foo.com", 8265)))); |
| 3321 | |
| 3322 | EXPECT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3323 | EXPECT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3324 | EXPECT_THAT(delegate.unhandled_results(), testing::IsEmpty()); |
| 3325 | } |
| 3326 | |
| 3327 | // Ensure query types we are not listening for do not affect MdnsListener. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3328 | TEST_F(HostResolverManagerTest, MdnsListener_NonListeningTypes) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3329 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3330 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 3331 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 3332 | |
| 3333 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3334 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 41), |
| 3335 | DnsQueryType::A); |
| 3336 | |
| 3337 | TestMdnsListenerDelegate delegate; |
| 3338 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3339 | |
| 3340 | socket_factory_ptr->SimulateReceive(kMdnsResponseAAAA, |
| 3341 | sizeof(kMdnsResponseAAAA)); |
| 3342 | |
| 3343 | EXPECT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3344 | EXPECT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3345 | EXPECT_THAT(delegate.hostname_results(), testing::IsEmpty()); |
| 3346 | EXPECT_THAT(delegate.unhandled_results(), testing::IsEmpty()); |
| 3347 | } |
| 3348 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3349 | TEST_F(HostResolverManagerTest, MdnsListener_RootDomain) { |
Eric Orth | 026776a | 2019-01-18 00:13:28 | [diff] [blame] | 3350 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 3351 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 3352 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 3353 | |
| 3354 | std::unique_ptr<HostResolver::MdnsListener> listener = |
| 3355 | resolver_->CreateMdnsListener(HostPortPair("myhello.local", 5), |
| 3356 | DnsQueryType::PTR); |
| 3357 | |
| 3358 | TestMdnsListenerDelegate delegate; |
| 3359 | ASSERT_THAT(listener->Start(&delegate), IsOk()); |
| 3360 | |
| 3361 | socket_factory_ptr->SimulateReceive(kMdnsResponsePtrRoot, |
| 3362 | sizeof(kMdnsResponsePtrRoot)); |
| 3363 | |
| 3364 | EXPECT_THAT(delegate.unhandled_results(), |
| 3365 | testing::ElementsAre(std::make_pair( |
| 3366 | HostResolver::MdnsListener::Delegate::UpdateType::ADDED, |
| 3367 | DnsQueryType::PTR))); |
| 3368 | |
| 3369 | EXPECT_THAT(delegate.address_results(), testing::IsEmpty()); |
| 3370 | EXPECT_THAT(delegate.text_results(), testing::IsEmpty()); |
| 3371 | EXPECT_THAT(delegate.hostname_results(), testing::IsEmpty()); |
| 3372 | } |
Eric Orth | 9871aafa | 2018-10-02 19:59:18 | [diff] [blame] | 3373 | #endif // BUILDFLAG(ENABLE_MDNS) |
| 3374 | |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 3375 | DnsConfig CreateValidDnsConfig() { |
martijn | a23c896 | 2016-03-04 18:18:51 | [diff] [blame] | 3376 | IPAddress dns_ip(192, 168, 1, 0); |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 3377 | DnsConfig config; |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 3378 | config.nameservers.push_back(IPEndPoint(dns_ip, dns_protocol::kDefaultPort)); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 3379 | config.dns_over_https_servers.push_back({DnsConfig::DnsOverHttpsServerConfig( |
| 3380 | "https://dns.example.com/", true /* use_post */)}); |
| 3381 | config.secure_dns_mode = DnsConfig::SecureDnsMode::OFF; |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 3382 | EXPECT_TRUE(config.IsValid()); |
| 3383 | return config; |
| 3384 | } |
| 3385 | |
[email protected] | 1d93285 | 2012-06-19 19:40:33 | [diff] [blame] | 3386 | // Specialized fixture for tests of DnsTask. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3387 | class HostResolverManagerDnsTest : public HostResolverManagerTest { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 3388 | public: |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 3389 | HostResolverManagerDnsTest() : dns_client_(nullptr) {} |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 3390 | |
[email protected] | 1d93285 | 2012-06-19 19:40:33 | [diff] [blame] | 3391 | protected: |
Miriam Gershenson | 17acdf09 | 2017-08-23 19:43:08 | [diff] [blame] | 3392 | void TearDown() override { |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3393 | HostResolverManagerTest::TearDown(); |
Miriam Gershenson | 17acdf09 | 2017-08-23 19:43:08 | [diff] [blame] | 3394 | ChangeDnsConfig(DnsConfig()); |
| 3395 | } |
| 3396 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3397 | // HostResolverManagerTest implementation: |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3398 | HostResolver::ManagerOptions DefaultOptions() override { |
| 3399 | HostResolver::ManagerOptions options = |
| 3400 | HostResolverManagerTest::DefaultOptions(); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3401 | options.insecure_dns_client_enabled = true; |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3402 | return options; |
| 3403 | } |
| 3404 | |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3405 | void CreateResolverWithOptionsAndParams(HostResolver::ManagerOptions options, |
| 3406 | const ProcTaskParams& params, |
| 3407 | bool ipv6_reachable) override { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 3408 | DestroyResolver(); |
| 3409 | |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3410 | resolver_ = std::make_unique<TestHostResolverManager>( |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3411 | options, nullptr /* net_log */, ipv6_reachable); |
| 3412 | auto dns_client = |
| 3413 | std::make_unique<MockDnsClient>(DnsConfig(), CreateDefaultDnsRules()); |
| 3414 | dns_client_ = dns_client.get(); |
| 3415 | resolver_->SetDnsClientForTesting(std::move(dns_client)); |
[email protected] | 106ccd2c | 2014-06-17 09:21:00 | [diff] [blame] | 3416 | resolver_->set_proc_params_for_test(params); |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 3417 | |
| 3418 | if (host_cache_) |
| 3419 | resolver_->AddHostCacheInvalidator(host_cache_->invalidator()); |
[email protected] | 1d93285 | 2012-06-19 19:40:33 | [diff] [blame] | 3420 | } |
| 3421 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3422 | // Call after CreateResolver() to update the resolver with a new MockDnsClient |
| 3423 | // using |config| and |rules|. |
| 3424 | void UseMockDnsClient(const DnsConfig& config, MockDnsClientRuleList rules) { |
| 3425 | // HostResolver expects DnsConfig to get set after setting DnsClient, so |
| 3426 | // create first with an empty config and then update the config. |
| 3427 | auto dns_client = |
| 3428 | std::make_unique<MockDnsClient>(DnsConfig(), std::move(rules)); |
| 3429 | dns_client_ = dns_client.get(); |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3430 | resolver_->SetDnsClientForTesting(std::move(dns_client)); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3431 | resolver_->SetInsecureDnsClientEnabled(true); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3432 | if (!config.Equals(DnsConfig())) |
| 3433 | ChangeDnsConfig(config); |
eroman | 1efc237c | 2016-12-14 00:00:45 | [diff] [blame] | 3434 | } |
| 3435 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3436 | static MockDnsClientRuleList CreateDefaultDnsRules() { |
| 3437 | MockDnsClientRuleList rules; |
| 3438 | |
| 3439 | AddDnsRule(&rules, "nodomain", dns_protocol::kTypeA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3440 | MockDnsClientRule::NODOMAIN, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3441 | AddDnsRule(&rules, "nodomain", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3442 | MockDnsClientRule::NODOMAIN, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3443 | AddDnsRule(&rules, "nx", dns_protocol::kTypeA, MockDnsClientRule::FAIL, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3444 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3445 | AddDnsRule(&rules, "nx", dns_protocol::kTypeAAAA, MockDnsClientRule::FAIL, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3446 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3447 | AddDnsRule(&rules, "ok", dns_protocol::kTypeA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3448 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3449 | AddDnsRule(&rules, "ok", dns_protocol::kTypeAAAA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3450 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3451 | AddDnsRule(&rules, "4ok", dns_protocol::kTypeA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3452 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3453 | AddDnsRule(&rules, "4ok", dns_protocol::kTypeAAAA, MockDnsClientRule::EMPTY, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3454 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3455 | AddDnsRule(&rules, "6ok", dns_protocol::kTypeA, MockDnsClientRule::EMPTY, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3456 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3457 | AddDnsRule(&rules, "6ok", dns_protocol::kTypeAAAA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3458 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3459 | AddDnsRule(&rules, "4nx", dns_protocol::kTypeA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3460 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3461 | AddDnsRule(&rules, "4nx", dns_protocol::kTypeAAAA, MockDnsClientRule::FAIL, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3462 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3463 | AddDnsRule(&rules, "empty", dns_protocol::kTypeA, MockDnsClientRule::EMPTY, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3464 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3465 | AddDnsRule(&rules, "empty", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3466 | MockDnsClientRule::EMPTY, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3467 | |
| 3468 | AddDnsRule(&rules, "slow_nx", dns_protocol::kTypeA, MockDnsClientRule::FAIL, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3469 | true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3470 | AddDnsRule(&rules, "slow_nx", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3471 | MockDnsClientRule::FAIL, true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3472 | |
| 3473 | AddDnsRule(&rules, "4slow_ok", dns_protocol::kTypeA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3474 | true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3475 | AddDnsRule(&rules, "4slow_ok", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3476 | MockDnsClientRule::OK, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3477 | AddDnsRule(&rules, "6slow_ok", dns_protocol::kTypeA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3478 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3479 | AddDnsRule(&rules, "6slow_ok", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3480 | MockDnsClientRule::OK, true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3481 | AddDnsRule(&rules, "4slow_4ok", dns_protocol::kTypeA, MockDnsClientRule::OK, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3482 | true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3483 | AddDnsRule(&rules, "4slow_4ok", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3484 | MockDnsClientRule::EMPTY, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3485 | AddDnsRule(&rules, "4slow_4timeout", dns_protocol::kTypeA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3486 | MockDnsClientRule::TIMEOUT, true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3487 | AddDnsRule(&rules, "4slow_4timeout", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3488 | MockDnsClientRule::OK, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3489 | AddDnsRule(&rules, "4slow_6timeout", dns_protocol::kTypeA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3490 | MockDnsClientRule::OK, true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3491 | AddDnsRule(&rules, "4slow_6timeout", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3492 | MockDnsClientRule::TIMEOUT, false /* delay */); |
| 3493 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3494 | AddDnsRule(&rules, "4collision", dns_protocol::kTypeA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3495 | IPAddress(127, 0, 53, 53), false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3496 | AddDnsRule(&rules, "4collision", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3497 | MockDnsClientRule::EMPTY, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3498 | AddDnsRule(&rules, "6collision", dns_protocol::kTypeA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3499 | MockDnsClientRule::EMPTY, false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3500 | // This isn't the expected IP for collisions (but looks close to it). |
| 3501 | AddDnsRule(&rules, "6collision", dns_protocol::kTypeAAAA, |
| 3502 | IPAddress(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 127, 0, 53, 53), |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3503 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3504 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 3505 | AddSecureDnsRule(&rules, "automatic_nodomain", dns_protocol::kTypeA, |
| 3506 | MockDnsClientRule::NODOMAIN, false /* delay */); |
| 3507 | AddSecureDnsRule(&rules, "automatic_nodomain", dns_protocol::kTypeAAAA, |
| 3508 | MockDnsClientRule::NODOMAIN, false /* delay */); |
| 3509 | AddDnsRule(&rules, "automatic_nodomain", dns_protocol::kTypeA, |
| 3510 | MockDnsClientRule::NODOMAIN, false /* delay */); |
| 3511 | AddDnsRule(&rules, "automatic_nodomain", dns_protocol::kTypeAAAA, |
| 3512 | MockDnsClientRule::NODOMAIN, false /* delay */); |
| 3513 | AddSecureDnsRule(&rules, "automatic", dns_protocol::kTypeA, |
| 3514 | MockDnsClientRule::OK, false /* delay */); |
| 3515 | AddSecureDnsRule(&rules, "automatic", dns_protocol::kTypeAAAA, |
| 3516 | MockDnsClientRule::OK, false /* delay */); |
| 3517 | AddDnsRule(&rules, "automatic", dns_protocol::kTypeA, MockDnsClientRule::OK, |
| 3518 | false /* delay */); |
| 3519 | AddDnsRule(&rules, "automatic", dns_protocol::kTypeAAAA, |
| 3520 | MockDnsClientRule::OK, false /* delay */); |
| 3521 | AddDnsRule(&rules, "insecure_automatic", dns_protocol::kTypeA, |
| 3522 | MockDnsClientRule::OK, false /* delay */); |
| 3523 | AddDnsRule(&rules, "insecure_automatic", dns_protocol::kTypeAAAA, |
| 3524 | MockDnsClientRule::OK, false /* delay */); |
| 3525 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3526 | AddSecureDnsRule(&rules, "secure", dns_protocol::kTypeA, |
| 3527 | MockDnsClientRule::OK, false /* delay */); |
| 3528 | AddSecureDnsRule(&rules, "secure", dns_protocol::kTypeAAAA, |
| 3529 | MockDnsClientRule::OK, false /* delay */); |
| 3530 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3531 | return rules; |
eroman | 1efc237c | 2016-12-14 00:00:45 | [diff] [blame] | 3532 | } |
| 3533 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3534 | // Adds a rule to |rules|. |
| 3535 | static void AddDnsRule(MockDnsClientRuleList* rules, |
| 3536 | const std::string& prefix, |
| 3537 | uint16_t qtype, |
| 3538 | MockDnsClientRule::ResultType result_type, |
| 3539 | bool delay) { |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 3540 | rules->emplace_back(prefix, qtype, false /* secure */, |
dalyk | ad3f6c3 | 2019-03-06 13:38:33 | [diff] [blame] | 3541 | MockDnsClientRule::Result(result_type), delay); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3542 | } |
| 3543 | |
| 3544 | static void AddDnsRule(MockDnsClientRuleList* rules, |
| 3545 | const std::string& prefix, |
| 3546 | uint16_t qtype, |
| 3547 | const IPAddress& result_ip, |
| 3548 | bool delay) { |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 3549 | rules->emplace_back(prefix, qtype, false /* secure */, |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3550 | MockDnsClientRule::Result( |
| 3551 | BuildTestDnsResponse(prefix, std::move(result_ip))), |
| 3552 | delay); |
| 3553 | } |
| 3554 | |
| 3555 | static void AddDnsRule(MockDnsClientRuleList* rules, |
| 3556 | const std::string& prefix, |
| 3557 | uint16_t qtype, |
| 3558 | IPAddress result_ip, |
| 3559 | std::string cannonname, |
| 3560 | bool delay) { |
| 3561 | rules->emplace_back( |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 3562 | prefix, qtype, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 3563 | MockDnsClientRule::Result(BuildTestDnsResponseWithCname( |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 3564 | prefix, std::move(result_ip), std::move(cannonname))), |
| 3565 | delay); |
[email protected] | 0adcb2b | 2012-08-15 21:30:46 | [diff] [blame] | 3566 | } |
| 3567 | |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3568 | static void AddSecureDnsRule(MockDnsClientRuleList* rules, |
| 3569 | const std::string& prefix, |
| 3570 | uint16_t qtype, |
| 3571 | MockDnsClientRule::ResultType result_type, |
| 3572 | bool delay) { |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 3573 | rules->emplace_back(prefix, qtype, true /* secure */, |
| 3574 | MockDnsClientRule::Result(result_type), delay); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 3575 | } |
| 3576 | |
[email protected] | 1d93285 | 2012-06-19 19:40:33 | [diff] [blame] | 3577 | void ChangeDnsConfig(const DnsConfig& config) { |
Eric Orth | c398f1e | 2019-07-09 21:54:55 | [diff] [blame] | 3578 | NetworkChangeNotifier::SetDnsConfigForTesting(config); |
[email protected] | bb0e3454 | 2012-08-31 19:52:40 | [diff] [blame] | 3579 | // Notification is delivered asynchronously. |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 3580 | base::RunLoop().RunUntilIdle(); |
[email protected] | 1d93285 | 2012-06-19 19:40:33 | [diff] [blame] | 3581 | } |
| 3582 | |
Miriam Gershenson | 44aafc12 | 2017-10-18 19:29:25 | [diff] [blame] | 3583 | void SetInitialDnsConfig(const DnsConfig& config) { |
John Abd-El-Malek | 1842b8c | 2018-05-16 14:53:22 | [diff] [blame] | 3584 | NetworkChangeNotifier::ClearDnsConfigForTesting(); |
Eric Orth | c398f1e | 2019-07-09 21:54:55 | [diff] [blame] | 3585 | NetworkChangeNotifier::SetDnsConfigForTesting(config); |
Miriam Gershenson | 44aafc12 | 2017-10-18 19:29:25 | [diff] [blame] | 3586 | // Notification is delivered asynchronously. |
| 3587 | base::RunLoop().RunUntilIdle(); |
| 3588 | } |
| 3589 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 3590 | // Owned by |resolver_|. |
| 3591 | MockDnsClient* dns_client_; |
[email protected] | 1d93285 | 2012-06-19 19:40:33 | [diff] [blame] | 3592 | }; |
| 3593 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3594 | TEST_F(HostResolverManagerDnsTest, DisableAndEnableInsecureDnsClient) { |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3595 | // Disable fallback to allow testing how requests are initially handled. |
| 3596 | set_allow_fallback_to_proctask(false); |
| 3597 | |
| 3598 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3599 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.2.47"); |
| 3600 | proc_->SignalMultiple(1u); |
| 3601 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3602 | resolver_->SetInsecureDnsClientEnabled(false); |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3603 | ResolveHostResponseHelper response_proc(resolver_->CreateRequest( |
| 3604 | HostPortPair("nx_succeed", 1212), NetLogWithSource(), base::nullopt, |
| 3605 | request_context_.get(), host_cache_.get())); |
| 3606 | EXPECT_THAT(response_proc.result_error(), IsOk()); |
| 3607 | EXPECT_THAT(response_proc.request()->GetAddressResults().value().endpoints(), |
| 3608 | testing::ElementsAre(CreateExpected("192.168.2.47", 1212))); |
| 3609 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3610 | resolver_->SetInsecureDnsClientEnabled(true); |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 3611 | ResolveHostResponseHelper response_dns_client(resolver_->CreateRequest( |
| 3612 | HostPortPair("ok_fail", 1212), NetLogWithSource(), base::nullopt, |
| 3613 | request_context_.get(), host_cache_.get())); |
| 3614 | EXPECT_THAT(response_dns_client.result_error(), IsOk()); |
| 3615 | EXPECT_THAT( |
| 3616 | response_dns_client.request()->GetAddressResults().value().endpoints(), |
| 3617 | testing::UnorderedElementsAre(CreateExpected("::1", 1212), |
| 3618 | CreateExpected("127.0.0.1", 1212))); |
| 3619 | } |
| 3620 | |
dalyk | 6d7d8ead | 2019-08-15 03:30:08 | [diff] [blame] | 3621 | TEST_F(HostResolverManagerDnsTest, UseProcTaskWhenPrivateDnsActive) { |
| 3622 | // Disable fallback to allow testing how requests are initially handled. |
| 3623 | set_allow_fallback_to_proctask(false); |
| 3624 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.2.47"); |
| 3625 | proc_->SignalMultiple(1u); |
| 3626 | |
| 3627 | DnsConfig config = CreateValidDnsConfig(); |
| 3628 | config.dns_over_tls_active = true; |
| 3629 | ChangeDnsConfig(config); |
| 3630 | ResolveHostResponseHelper response_proc(resolver_->CreateRequest( |
| 3631 | HostPortPair("nx_succeed", 1212), NetLogWithSource(), base::nullopt, |
| 3632 | request_context_.get(), host_cache_.get())); |
| 3633 | EXPECT_THAT(response_proc.result_error(), IsOk()); |
| 3634 | EXPECT_THAT(response_proc.request()->GetAddressResults().value().endpoints(), |
| 3635 | testing::ElementsAre(CreateExpected("192.168.2.47", 1212))); |
| 3636 | } |
| 3637 | |
Mike West | da1c690e | 2017-08-12 05:57:16 | [diff] [blame] | 3638 | // RFC 6761 localhost names should always resolve to loopback. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3639 | TEST_F(HostResolverManagerDnsTest, LocalhostLookup) { |
Mike West | da1c690e | 2017-08-12 05:57:16 | [diff] [blame] | 3640 | // Add a rule resolving localhost names to a non-loopback IP and test |
| 3641 | // that they still resolves to loopback. |
| 3642 | proc_->AddRuleForAllFamilies("foo.localhost", "192.168.1.42"); |
| 3643 | proc_->AddRuleForAllFamilies("localhost", "192.168.1.42"); |
| 3644 | proc_->AddRuleForAllFamilies("localhost.", "192.168.1.42"); |
| 3645 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3646 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3647 | HostPortPair("foo.localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3648 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3649 | EXPECT_THAT(response0.result_error(), IsOk()); |
| 3650 | EXPECT_THAT(response0.request()->GetAddressResults().value().endpoints(), |
| 3651 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3652 | CreateExpected("::1", 80))); |
| 3653 | |
| 3654 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3655 | HostPortPair("localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3656 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3657 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 3658 | EXPECT_THAT(response1.request()->GetAddressResults().value().endpoints(), |
| 3659 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3660 | CreateExpected("::1", 80))); |
| 3661 | |
| 3662 | ResolveHostResponseHelper response2(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3663 | HostPortPair("localhost.", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3664 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3665 | EXPECT_THAT(response2.result_error(), IsOk()); |
| 3666 | EXPECT_THAT(response2.request()->GetAddressResults().value().endpoints(), |
| 3667 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3668 | CreateExpected("::1", 80))); |
| 3669 | } |
| 3670 | |
Mike West | da1c690e | 2017-08-12 05:57:16 | [diff] [blame] | 3671 | // RFC 6761 localhost names should always resolve to loopback, even if a HOSTS |
| 3672 | // file is active. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3673 | TEST_F(HostResolverManagerDnsTest, LocalhostLookupWithHosts) { |
Mike West | da1c690e | 2017-08-12 05:57:16 | [diff] [blame] | 3674 | DnsHosts hosts; |
| 3675 | hosts[DnsHostsKey("localhost", ADDRESS_FAMILY_IPV4)] = |
| 3676 | IPAddress({192, 168, 1, 1}); |
| 3677 | hosts[DnsHostsKey("foo.localhost", ADDRESS_FAMILY_IPV4)] = |
| 3678 | IPAddress({192, 168, 1, 2}); |
| 3679 | |
| 3680 | DnsConfig config = CreateValidDnsConfig(); |
| 3681 | config.hosts = hosts; |
| 3682 | ChangeDnsConfig(config); |
| 3683 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3684 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3685 | HostPortPair("localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3686 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3687 | EXPECT_THAT(response0.result_error(), IsOk()); |
| 3688 | EXPECT_THAT(response0.request()->GetAddressResults().value().endpoints(), |
| 3689 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3690 | CreateExpected("::1", 80))); |
| 3691 | |
| 3692 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3693 | HostPortPair("foo.localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3694 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3695 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 3696 | EXPECT_THAT(response1.request()->GetAddressResults().value().endpoints(), |
| 3697 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3698 | CreateExpected("::1", 80))); |
| 3699 | } |
| 3700 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3701 | // Test successful and fallback resolutions in HostResolverManager::DnsTask. |
| 3702 | TEST_F(HostResolverManagerDnsTest, DnsTask) { |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 3703 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102"); |
| 3704 | // All other hostnames will fail in proc_. |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 3705 | |
| 3706 | // Initially there is no config, so client should not be invoked. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3707 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 3708 | HostPortPair("ok_fail", 80), NetLogWithSource(), base::nullopt, |
| 3709 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3710 | EXPECT_FALSE(initial_response.complete()); |
| 3711 | |
| 3712 | proc_->SignalMultiple(1u); |
| 3713 | |
| 3714 | EXPECT_THAT(initial_response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3715 | |
| 3716 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3717 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3718 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 3719 | HostPortPair("ok_fail", 80), NetLogWithSource(), base::nullopt, |
| 3720 | request_context_.get(), host_cache_.get())); |
| 3721 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
| 3722 | HostPortPair("nx_fail", 80), NetLogWithSource(), base::nullopt, |
| 3723 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3724 | ResolveHostResponseHelper response2(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3725 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3726 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3727 | |
| 3728 | proc_->SignalMultiple(4u); |
| 3729 | |
| 3730 | // Resolved by MockDnsClient. |
| 3731 | EXPECT_THAT(response0.result_error(), IsOk()); |
| 3732 | EXPECT_THAT(response0.request()->GetAddressResults().value().endpoints(), |
| 3733 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3734 | CreateExpected("::1", 80))); |
| 3735 | |
| 3736 | // Fallback to ProcTask. |
| 3737 | EXPECT_THAT(response1.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3738 | EXPECT_THAT(response2.result_error(), IsOk()); |
| 3739 | EXPECT_THAT(response2.request()->GetAddressResults().value().endpoints(), |
| 3740 | testing::ElementsAre(CreateExpected("192.168.1.102", 80))); |
| 3741 | } |
| 3742 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3743 | // Test successful and failing resolutions in HostResolverManager::DnsTask when |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 3744 | // fallback to ProcTask is disabled. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3745 | TEST_F(HostResolverManagerDnsTest, NoFallbackToProcTask) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3746 | set_allow_fallback_to_proctask(false); |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 3747 | |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 3748 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102"); |
| 3749 | // All other hostnames will fail in proc_. |
| 3750 | |
| 3751 | // Set empty DnsConfig. |
| 3752 | ChangeDnsConfig(DnsConfig()); |
| 3753 | // Initially there is no config, so client should not be invoked. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3754 | ResolveHostResponseHelper initial_response0(resolver_->CreateRequest( |
| 3755 | HostPortPair("ok_fail", 80), NetLogWithSource(), base::nullopt, |
| 3756 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3757 | ResolveHostResponseHelper initial_response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3758 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3759 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3760 | proc_->SignalMultiple(2u); |
| 3761 | |
| 3762 | EXPECT_THAT(initial_response0.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3763 | EXPECT_THAT(initial_response1.result_error(), IsOk()); |
| 3764 | EXPECT_THAT( |
| 3765 | initial_response1.request()->GetAddressResults().value().endpoints(), |
| 3766 | testing::ElementsAre(CreateExpected("192.168.1.102", 80))); |
| 3767 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3768 | // Switch to a valid config. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3769 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3770 | // First request is resolved by MockDnsClient, others should fail due to |
| 3771 | // disabled fallback to ProcTask. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3772 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 3773 | HostPortPair("ok_fail", 80), NetLogWithSource(), base::nullopt, |
| 3774 | request_context_.get(), host_cache_.get())); |
| 3775 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3776 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3777 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3778 | proc_->SignalMultiple(6u); |
| 3779 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3780 | // Resolved by MockDnsClient. |
| 3781 | EXPECT_THAT(response0.result_error(), IsOk()); |
| 3782 | EXPECT_THAT(response0.request()->GetAddressResults().value().endpoints(), |
| 3783 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3784 | CreateExpected("::1", 80))); |
| 3785 | // Fallback to ProcTask is disabled. |
| 3786 | EXPECT_THAT(response1.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3787 | } |
| 3788 | |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 3789 | // Test behavior of OnDnsTaskFailure when Job is aborted. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3790 | TEST_F(HostResolverManagerDnsTest, OnDnsTaskFailureAbortedJob) { |
[email protected] | 16c2bd7 | 2013-06-28 01:19:22 | [diff] [blame] | 3791 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3792 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 3793 | HostPortPair("nx_abort", 80), NetLogWithSource(), base::nullopt, |
| 3794 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3795 | // Abort all jobs here. |
| 3796 | CreateResolver(); |
| 3797 | proc_->SignalMultiple(1u); |
| 3798 | // Run to completion. |
| 3799 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 3800 | // It shouldn't crash during OnDnsTaskFailure callbacks. |
| 3801 | EXPECT_FALSE(response.complete()); |
| 3802 | |
| 3803 | // Repeat test with Fallback to ProcTask disabled |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3804 | set_allow_fallback_to_proctask(false); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3805 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3806 | ResolveHostResponseHelper no_fallback_response(resolver_->CreateRequest( |
| 3807 | HostPortPair("nx_abort", 80), NetLogWithSource(), base::nullopt, |
| 3808 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3809 | // Abort all jobs here. |
| 3810 | CreateResolver(); |
| 3811 | proc_->SignalMultiple(2u); |
| 3812 | // Run to completion. |
| 3813 | base::RunLoop().RunUntilIdle(); // Notification happens async. |
| 3814 | // It shouldn't crash during OnDnsTaskFailure callbacks. |
| 3815 | EXPECT_FALSE(no_fallback_response.complete()); |
| 3816 | } |
| 3817 | |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3818 | // Fallback to proc allowed with ANY source. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3819 | TEST_F(HostResolverManagerDnsTest, FallbackBySource_Any) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3820 | // Ensure fallback is otherwise allowed by resolver settings. |
| 3821 | set_allow_fallback_to_proctask(true); |
| 3822 | |
| 3823 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102"); |
| 3824 | // All other hostnames will fail in proc_. |
| 3825 | |
| 3826 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3827 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3828 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 3829 | HostPortPair("nx_fail", 80), NetLogWithSource(), base::nullopt, |
| 3830 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3831 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3832 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3833 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3834 | proc_->SignalMultiple(2u); |
| 3835 | |
| 3836 | EXPECT_THAT(response0.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3837 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 3838 | EXPECT_THAT(response1.request()->GetAddressResults().value().endpoints(), |
| 3839 | testing::ElementsAre(CreateExpected("192.168.1.102", 80))); |
| 3840 | } |
| 3841 | |
| 3842 | // Fallback to proc not allowed with DNS source. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3843 | TEST_F(HostResolverManagerDnsTest, FallbackBySource_Dns) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3844 | // Ensure fallback is otherwise allowed by resolver settings. |
| 3845 | set_allow_fallback_to_proctask(true); |
| 3846 | |
| 3847 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102"); |
| 3848 | // All other hostnames will fail in proc_. |
| 3849 | |
| 3850 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3851 | |
| 3852 | HostResolver::ResolveHostParameters parameters; |
| 3853 | parameters.source = HostResolverSource::DNS; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3854 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 3855 | HostPortPair("nx_fail", 80), NetLogWithSource(), parameters, |
| 3856 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3857 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3858 | HostPortPair("nx_succeed", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3859 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3860 | // Nothing should reach |proc_| on success, but let failures through to fail |
| 3861 | // instead of hanging. |
| 3862 | proc_->SignalMultiple(2u); |
| 3863 | |
| 3864 | EXPECT_THAT(response0.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3865 | EXPECT_THAT(response1.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3866 | } |
| 3867 | |
| 3868 | // Fallback to proc on DnsClient change allowed with ANY source. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3869 | TEST_F(HostResolverManagerDnsTest, FallbackOnAbortBySource_Any) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3870 | // Ensure fallback is otherwise allowed by resolver settings. |
| 3871 | set_allow_fallback_to_proctask(true); |
| 3872 | |
| 3873 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102"); |
| 3874 | // All other hostnames will fail in proc_. |
| 3875 | |
| 3876 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3877 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3878 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 3879 | HostPortPair("ok_fail", 80), NetLogWithSource(), base::nullopt, |
| 3880 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3881 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3882 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3883 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3884 | proc_->SignalMultiple(2u); |
| 3885 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3886 | // Simulate the case when the preference or policy has disabled the insecure |
| 3887 | // DNS client causing AbortInsecureDnsTasks. |
| 3888 | resolver_->SetInsecureDnsClientEnabled(false); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3889 | |
| 3890 | // All requests should fallback to proc resolver. |
| 3891 | EXPECT_THAT(response0.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 3892 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 3893 | EXPECT_THAT(response1.request()->GetAddressResults().value().endpoints(), |
| 3894 | testing::ElementsAre(CreateExpected("192.168.1.102", 80))); |
| 3895 | } |
| 3896 | |
| 3897 | // Fallback to proc on DnsClient change not allowed with DNS source. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3898 | TEST_F(HostResolverManagerDnsTest, FallbackOnAbortBySource_Dns) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3899 | // Ensure fallback is otherwise allowed by resolver settings. |
| 3900 | set_allow_fallback_to_proctask(true); |
| 3901 | |
| 3902 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102"); |
| 3903 | // All other hostnames will fail in proc_. |
| 3904 | |
| 3905 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3906 | |
| 3907 | HostResolver::ResolveHostParameters parameters; |
| 3908 | parameters.source = HostResolverSource::DNS; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3909 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 3910 | HostPortPair("ok_fail", 80), NetLogWithSource(), parameters, |
| 3911 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3912 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 3913 | HostPortPair("nx_succeed", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3914 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3915 | // Nothing should reach |proc_| on success, but let failures through to fail |
| 3916 | // instead of hanging. |
| 3917 | proc_->SignalMultiple(2u); |
| 3918 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3919 | // Simulate the case when the preference or policy has disabled the insecure |
| 3920 | // DNS client causing AbortInsecureDnsTasks. |
| 3921 | resolver_->SetInsecureDnsClientEnabled(false); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 3922 | |
| 3923 | // No fallback expected. All requests should fail. |
| 3924 | EXPECT_THAT(response0.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 3925 | EXPECT_THAT(response1.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 3926 | } |
| 3927 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 3928 | // Insecure DnsClient change shouldn't affect secure DnsTasks. |
| 3929 | TEST_F(HostResolverManagerDnsTest, |
| 3930 | DisableInsecureDnsClient_SecureDnsTasksUnaffected) { |
| 3931 | // Ensure fallback is otherwise allowed by resolver settings. |
| 3932 | set_allow_fallback_to_proctask(true); |
| 3933 | |
| 3934 | proc_->AddRuleForAllFamilies("automatic", "192.168.1.102"); |
| 3935 | // All other hostnames will fail in proc_. |
| 3936 | |
| 3937 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3938 | |
| 3939 | HostResolver::ResolveHostParameters secure_parameters; |
| 3940 | secure_parameters.secure_dns_mode_override = |
| 3941 | DnsConfig::SecureDnsMode::AUTOMATIC; |
| 3942 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 3943 | HostPortPair("automatic", 80), NetLogWithSource(), secure_parameters, |
| 3944 | request_context_.get(), host_cache_.get())); |
| 3945 | EXPECT_FALSE(response_secure.complete()); |
| 3946 | |
| 3947 | // Simulate the case when the preference or policy has disabled the insecure |
| 3948 | // DNS client causing AbortInsecureDnsTasks. |
| 3949 | resolver_->SetInsecureDnsClientEnabled(false); |
| 3950 | |
| 3951 | EXPECT_THAT(response_secure.result_error(), IsOk()); |
| 3952 | EXPECT_THAT( |
| 3953 | response_secure.request()->GetAddressResults().value().endpoints(), |
| 3954 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3955 | CreateExpected("::1", 80))); |
| 3956 | } |
| 3957 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3958 | TEST_F(HostResolverManagerDnsTest, DnsTaskUnspec) { |
[email protected] | 0adcb2b | 2012-08-15 21:30:46 | [diff] [blame] | 3959 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 3960 | |
| 3961 | proc_->AddRuleForAllFamilies("4nx", "192.168.1.101"); |
| 3962 | // All other hostnames will fail in proc_. |
| 3963 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3964 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 3965 | responses.emplace_back( |
| 3966 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 3967 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 3968 | request_context_.get(), host_cache_.get()))); |
| 3969 | responses.emplace_back( |
| 3970 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 3971 | HostPortPair("4ok", 80), NetLogWithSource(), base::nullopt, |
| 3972 | request_context_.get(), host_cache_.get()))); |
| 3973 | responses.emplace_back( |
| 3974 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 3975 | HostPortPair("6ok", 80), NetLogWithSource(), base::nullopt, |
| 3976 | request_context_.get(), host_cache_.get()))); |
| 3977 | responses.emplace_back( |
| 3978 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 3979 | HostPortPair("4nx", 80), NetLogWithSource(), base::nullopt, |
| 3980 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 3981 | |
| 3982 | proc_->SignalMultiple(4u); |
| 3983 | |
| 3984 | for (auto& response : responses) { |
| 3985 | EXPECT_THAT(response->result_error(), IsOk()); |
| 3986 | } |
| 3987 | |
| 3988 | EXPECT_THAT(responses[0]->request()->GetAddressResults().value().endpoints(), |
| 3989 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 3990 | CreateExpected("::1", 80))); |
| 3991 | EXPECT_THAT(responses[1]->request()->GetAddressResults().value().endpoints(), |
| 3992 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 3993 | EXPECT_THAT(responses[2]->request()->GetAddressResults().value().endpoints(), |
| 3994 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 3995 | EXPECT_THAT(responses[3]->request()->GetAddressResults().value().endpoints(), |
| 3996 | testing::ElementsAre(CreateExpected("192.168.1.101", 80))); |
| 3997 | } |
| 3998 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 3999 | TEST_F(HostResolverManagerDnsTest, NameCollisionIcann) { |
eroman | 1efc237c | 2016-12-14 00:00:45 | [diff] [blame] | 4000 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4001 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4002 | // When the resolver returns an A record with 127.0.53.53 it should be |
| 4003 | // mapped to a special error. |
| 4004 | ResolveHostResponseHelper response_ipv4(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4005 | HostPortPair("4collision", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4006 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4007 | EXPECT_THAT(response_ipv4.result_error(), IsError(ERR_ICANN_NAME_COLLISION)); |
| 4008 | EXPECT_FALSE(response_ipv4.request()->GetAddressResults()); |
| 4009 | |
| 4010 | // When the resolver returns an AAAA record with ::127.0.53.53 it should |
| 4011 | // work just like any other IP. (Despite having the same suffix, it is not |
| 4012 | // considered special) |
| 4013 | ResolveHostResponseHelper response_ipv6(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4014 | HostPortPair("6collision", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4015 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4016 | EXPECT_THAT(response_ipv6.result_error(), IsOk()); |
| 4017 | EXPECT_THAT(response_ipv6.request()->GetAddressResults().value().endpoints(), |
| 4018 | testing::ElementsAre(CreateExpected("::127.0.53.53", 80))); |
| 4019 | } |
| 4020 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4021 | TEST_F(HostResolverManagerDnsTest, ServeFromHosts) { |
[email protected] | d7b9a2b | 2012-05-31 22:31:19 | [diff] [blame] | 4022 | // Initially, use empty HOSTS file. |
[email protected] | bb0e3454 | 2012-08-31 19:52:40 | [diff] [blame] | 4023 | DnsConfig config = CreateValidDnsConfig(); |
| 4024 | ChangeDnsConfig(config); |
[email protected] | d7b9a2b | 2012-05-31 22:31:19 | [diff] [blame] | 4025 | |
[email protected] | 007b3f8 | 2013-04-09 08:46:45 | [diff] [blame] | 4026 | proc_->AddRuleForAllFamilies(std::string(), |
| 4027 | std::string()); // Default to failures. |
[email protected] | 38b50d9 | 2012-04-19 21:07:52 | [diff] [blame] | 4028 | proc_->SignalMultiple(1u); // For the first request which misses. |
[email protected] | 78eac2a | 2012-03-14 19:09:27 | [diff] [blame] | 4029 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4030 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 4031 | HostPortPair("nx_ipv4", 80), NetLogWithSource(), base::nullopt, |
| 4032 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4033 | EXPECT_THAT(initial_response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 4034 | |
| 4035 | IPAddress local_ipv4 = IPAddress::IPv4Localhost(); |
| 4036 | IPAddress local_ipv6 = IPAddress::IPv6Localhost(); |
| 4037 | |
| 4038 | DnsHosts hosts; |
| 4039 | hosts[DnsHostsKey("nx_ipv4", ADDRESS_FAMILY_IPV4)] = local_ipv4; |
| 4040 | hosts[DnsHostsKey("nx_ipv6", ADDRESS_FAMILY_IPV6)] = local_ipv6; |
| 4041 | hosts[DnsHostsKey("nx_both", ADDRESS_FAMILY_IPV4)] = local_ipv4; |
| 4042 | hosts[DnsHostsKey("nx_both", ADDRESS_FAMILY_IPV6)] = local_ipv6; |
| 4043 | |
| 4044 | // Update HOSTS file. |
| 4045 | config.hosts = hosts; |
| 4046 | ChangeDnsConfig(config); |
| 4047 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4048 | ResolveHostResponseHelper response_ipv4(resolver_->CreateRequest( |
| 4049 | HostPortPair("nx_ipv4", 80), NetLogWithSource(), base::nullopt, |
| 4050 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4051 | EXPECT_THAT(response_ipv4.result_error(), IsOk()); |
| 4052 | EXPECT_THAT(response_ipv4.request()->GetAddressResults().value().endpoints(), |
| 4053 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 4054 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4055 | ResolveHostResponseHelper response_ipv6(resolver_->CreateRequest( |
| 4056 | HostPortPair("nx_ipv6", 80), NetLogWithSource(), base::nullopt, |
| 4057 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4058 | EXPECT_THAT(response_ipv6.result_error(), IsOk()); |
| 4059 | EXPECT_THAT(response_ipv6.request()->GetAddressResults().value().endpoints(), |
| 4060 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 4061 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4062 | ResolveHostResponseHelper response_both(resolver_->CreateRequest( |
| 4063 | HostPortPair("nx_both", 80), NetLogWithSource(), base::nullopt, |
| 4064 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4065 | EXPECT_THAT(response_both.result_error(), IsOk()); |
| 4066 | EXPECT_THAT(response_both.request()->GetAddressResults().value().endpoints(), |
| 4067 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4068 | CreateExpected("::1", 80))); |
| 4069 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 4070 | // Requests with specified DNS query type. |
| 4071 | HostResolver::ResolveHostParameters parameters; |
| 4072 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 4073 | parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4074 | ResolveHostResponseHelper response_specified_ipv4(resolver_->CreateRequest( |
| 4075 | HostPortPair("nx_ipv4", 80), NetLogWithSource(), parameters, |
| 4076 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 4077 | EXPECT_THAT(response_specified_ipv4.result_error(), IsOk()); |
| 4078 | EXPECT_THAT(response_specified_ipv4.request() |
| 4079 | ->GetAddressResults() |
| 4080 | .value() |
| 4081 | .endpoints(), |
| 4082 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 4083 | |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 4084 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4085 | ResolveHostResponseHelper response_specified_ipv6(resolver_->CreateRequest( |
| 4086 | HostPortPair("nx_ipv6", 80), NetLogWithSource(), parameters, |
| 4087 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 4088 | EXPECT_THAT(response_specified_ipv6.result_error(), IsOk()); |
| 4089 | EXPECT_THAT(response_specified_ipv6.request() |
| 4090 | ->GetAddressResults() |
| 4091 | .value() |
| 4092 | .endpoints(), |
| 4093 | testing::ElementsAre(CreateExpected("::1", 80))); |
| 4094 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4095 | // Request with upper case. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4096 | ResolveHostResponseHelper response_upper(resolver_->CreateRequest( |
| 4097 | HostPortPair("nx_IPV4", 80), NetLogWithSource(), base::nullopt, |
| 4098 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4099 | EXPECT_THAT(response_upper.result_error(), IsOk()); |
| 4100 | EXPECT_THAT(response_upper.request()->GetAddressResults().value().endpoints(), |
| 4101 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 4102 | } |
| 4103 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4104 | TEST_F(HostResolverManagerDnsTest, SkipHostsWithUpcomingProcTask) { |
| 4105 | // Disable the DnsClient. |
| 4106 | resolver_->SetInsecureDnsClientEnabled(false); |
| 4107 | |
| 4108 | proc_->AddRuleForAllFamilies(std::string(), |
| 4109 | std::string()); // Default to failures. |
| 4110 | proc_->SignalMultiple(1u); // For the first request which misses. |
| 4111 | |
| 4112 | DnsConfig config = CreateValidDnsConfig(); |
| 4113 | DnsHosts hosts; |
| 4114 | hosts[DnsHostsKey("hosts", ADDRESS_FAMILY_IPV4)] = IPAddress::IPv4Localhost(); |
| 4115 | |
| 4116 | // Update HOSTS file. |
| 4117 | config.hosts = hosts; |
| 4118 | ChangeDnsConfig(config); |
| 4119 | |
| 4120 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4121 | HostPortPair("hosts", 80), NetLogWithSource(), base::nullopt, |
| 4122 | request_context_.get(), host_cache_.get())); |
| 4123 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 4124 | } |
| 4125 | |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4126 | // Test that hosts ending in ".local" or ".local." are resolved using the system |
| 4127 | // resolver. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4128 | TEST_F(HostResolverManagerDnsTest, BypassDnsTask) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4129 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4130 | |
| 4131 | proc_->AddRuleForAllFamilies(std::string(), |
| 4132 | std::string()); // Default to failures. |
| 4133 | |
| 4134 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 4135 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4136 | responses.emplace_back( |
| 4137 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4138 | HostPortPair("ok.local", 80), NetLogWithSource(), base::nullopt, |
| 4139 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4140 | responses.emplace_back( |
| 4141 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4142 | HostPortPair("ok.local.", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4143 | request_context_.get(), host_cache_.get()))); |
| 4144 | responses.emplace_back( |
| 4145 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4146 | HostPortPair("oklocal", 80), NetLogWithSource(), base::nullopt, |
| 4147 | request_context_.get(), host_cache_.get()))); |
| 4148 | responses.emplace_back( |
| 4149 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4150 | HostPortPair("oklocal.", 80), NetLogWithSource(), base::nullopt, |
| 4151 | request_context_.get(), host_cache_.get()))); |
| 4152 | responses.emplace_back( |
| 4153 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4154 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4155 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4156 | |
| 4157 | proc_->SignalMultiple(5u); |
| 4158 | |
| 4159 | for (size_t i = 0; i < 2; ++i) |
| 4160 | EXPECT_THAT(responses[i]->result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 4161 | |
| 4162 | for (size_t i = 2; i < responses.size(); ++i) |
| 4163 | EXPECT_THAT(responses[i]->result_error(), IsOk()); |
| 4164 | } |
| 4165 | |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 4166 | #if BUILDFLAG(ENABLE_MDNS) |
| 4167 | // Test that non-address queries for hosts ending in ".local" are resolved using |
| 4168 | // the MDNS resolver. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4169 | TEST_F(HostResolverManagerDnsTest, BypassDnsToMdnsWithNonAddress) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 4170 | // Ensure DNS task and system (proc) requests will fail. |
| 4171 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4172 | rules.emplace_back( |
| 4173 | "myhello.local", dns_protocol::kTypeTXT, false /* secure */, |
| 4174 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 4175 | CreateResolver(); |
| 4176 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 4177 | proc_->AddRuleForAllFamilies(std::string(), std::string()); |
| 4178 | |
| 4179 | auto socket_factory = std::make_unique<MockMDnsSocketFactory>(); |
| 4180 | MockMDnsSocketFactory* socket_factory_ptr = socket_factory.get(); |
| 4181 | resolver_->SetMdnsSocketFactoryForTesting(std::move(socket_factory)); |
| 4182 | // 2 socket creations for every transaction. |
| 4183 | EXPECT_CALL(*socket_factory_ptr, OnSendTo(_)).Times(2); |
| 4184 | |
| 4185 | HostResolver::ResolveHostParameters dns_parameters; |
| 4186 | dns_parameters.dns_query_type = DnsQueryType::TXT; |
| 4187 | |
| 4188 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4189 | HostPortPair("myhello.local", 80), NetLogWithSource(), dns_parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4190 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 4191 | |
| 4192 | socket_factory_ptr->SimulateReceive(kMdnsResponseTxt, |
| 4193 | sizeof(kMdnsResponseTxt)); |
| 4194 | proc_->SignalMultiple(1u); |
| 4195 | |
| 4196 | EXPECT_THAT(response.result_error(), IsOk()); |
| 4197 | EXPECT_THAT(response.request()->GetTextResults(), |
| 4198 | testing::Optional(testing::ElementsAre("foo", "bar"))); |
| 4199 | } |
| 4200 | #endif // BUILDFLAG(ENABLE_MDNS) |
| 4201 | |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4202 | // Test that DNS task is always used when explicitly requested as the source, |
| 4203 | // even with a case that would normally bypass it eg hosts ending in ".local". |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4204 | TEST_F(HostResolverManagerDnsTest, DnsNotBypassedWhenDnsSource) { |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4205 | // Ensure DNS task requests will succeed and system (proc) requests will fail. |
| 4206 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4207 | proc_->AddRuleForAllFamilies(std::string(), std::string()); |
| 4208 | |
| 4209 | HostResolver::ResolveHostParameters dns_parameters; |
| 4210 | dns_parameters.source = HostResolverSource::DNS; |
| 4211 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4212 | ResolveHostResponseHelper dns_response(resolver_->CreateRequest( |
| 4213 | HostPortPair("ok", 80), NetLogWithSource(), dns_parameters, |
| 4214 | request_context_.get(), host_cache_.get())); |
| 4215 | ResolveHostResponseHelper dns_local_response(resolver_->CreateRequest( |
| 4216 | HostPortPair("ok.local", 80), NetLogWithSource(), dns_parameters, |
| 4217 | request_context_.get(), host_cache_.get())); |
| 4218 | ResolveHostResponseHelper normal_local_response(resolver_->CreateRequest( |
| 4219 | HostPortPair("ok.local", 80), NetLogWithSource(), base::nullopt, |
| 4220 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4221 | |
| 4222 | proc_->SignalMultiple(3u); |
| 4223 | |
| 4224 | EXPECT_THAT(dns_response.result_error(), IsOk()); |
| 4225 | EXPECT_THAT(dns_local_response.result_error(), IsOk()); |
| 4226 | EXPECT_THAT(normal_local_response.result_error(), |
| 4227 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 4228 | } |
| 4229 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4230 | TEST_F(HostResolverManagerDnsTest, SystemOnlyBypassesDnsTask) { |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4231 | // Ensure DNS task requests will succeed and system (proc) requests will fail. |
| 4232 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4233 | proc_->AddRuleForAllFamilies(std::string(), std::string()); |
| 4234 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4235 | ResolveHostResponseHelper dns_response(resolver_->CreateRequest( |
| 4236 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4237 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4238 | |
| 4239 | HostResolver::ResolveHostParameters parameters; |
| 4240 | parameters.source = HostResolverSource::SYSTEM; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4241 | ResolveHostResponseHelper system_response(resolver_->CreateRequest( |
| 4242 | HostPortPair("ok", 80), NetLogWithSource(), parameters, |
| 4243 | request_context_.get(), host_cache_.get())); |
Eric Orth | dc35748e | 2018-08-23 22:41:48 | [diff] [blame] | 4244 | |
| 4245 | proc_->SignalMultiple(2u); |
| 4246 | |
| 4247 | EXPECT_THAT(dns_response.result_error(), IsOk()); |
| 4248 | EXPECT_THAT(system_response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 4249 | } |
| 4250 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4251 | TEST_F(HostResolverManagerDnsTest, |
| 4252 | DisableInsecureDnsClientOnPersistentFailure) { |
[email protected] | f0f602bd | 2012-11-15 18:01:02 | [diff] [blame] | 4253 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4254 | |
[email protected] | 007b3f8 | 2013-04-09 08:46:45 | [diff] [blame] | 4255 | proc_->AddRuleForAllFamilies(std::string(), |
| 4256 | std::string()); // Default to failures. |
[email protected] | f0f602bd | 2012-11-15 18:01:02 | [diff] [blame] | 4257 | |
| 4258 | // Check that DnsTask works. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4259 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 4260 | HostPortPair("ok_1", 80), NetLogWithSource(), base::nullopt, |
| 4261 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4262 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 4263 | |
| 4264 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4265 | for (unsigned i = 0; i < maximum_insecure_dns_task_failures(); ++i) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4266 | // Use custom names to require separate Jobs. |
| 4267 | std::string hostname = base::StringPrintf("nx_%u", i); |
| 4268 | // Ensure fallback to ProcTask succeeds. |
| 4269 | proc_->AddRuleForAllFamilies(hostname, "192.168.1.101"); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4270 | responses.emplace_back( |
| 4271 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4272 | HostPortPair(hostname, 80), NetLogWithSource(), base::nullopt, |
| 4273 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4274 | } |
| 4275 | |
| 4276 | proc_->SignalMultiple(responses.size()); |
| 4277 | |
| 4278 | for (size_t i = 0; i < responses.size(); ++i) |
| 4279 | EXPECT_THAT(responses[i]->result_error(), IsOk()); |
| 4280 | |
| 4281 | ASSERT_FALSE(proc_->HasBlockedRequests()); |
| 4282 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4283 | // Insecure DnsTasks should be disabled by now unless explicitly requested via |
| 4284 | // |source|. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4285 | ResolveHostResponseHelper fail_response(resolver_->CreateRequest( |
| 4286 | HostPortPair("ok_2", 80), NetLogWithSource(), base::nullopt, |
| 4287 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 4288 | HostResolver::ResolveHostParameters parameters; |
| 4289 | parameters.source = HostResolverSource::DNS; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4290 | ResolveHostResponseHelper dns_response(resolver_->CreateRequest( |
| 4291 | HostPortPair("ok_2", 80), NetLogWithSource(), parameters, |
| 4292 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 4293 | proc_->SignalMultiple(2u); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4294 | EXPECT_THAT(fail_response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 4295 | EXPECT_THAT(dns_response.result_error(), IsOk()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4296 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4297 | // Secure DnsTasks should not be affected. |
| 4298 | HostResolver::ResolveHostParameters secure_parameters; |
| 4299 | secure_parameters.secure_dns_mode_override = |
| 4300 | DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4301 | ResolveHostResponseHelper secure_response(resolver_->CreateRequest( |
| 4302 | HostPortPair("automatic", 80), NetLogWithSource(), secure_parameters, |
| 4303 | request_context_.get(), host_cache_.get())); |
| 4304 | EXPECT_THAT(secure_response.result_error(), IsOk()); |
| 4305 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4306 | // Check that it is re-enabled after DNS change. |
| 4307 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4308 | ResolveHostResponseHelper reenabled_response(resolver_->CreateRequest( |
| 4309 | HostPortPair("ok_3", 80), NetLogWithSource(), base::nullopt, |
| 4310 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4311 | EXPECT_THAT(reenabled_response.result_error(), IsOk()); |
| 4312 | } |
| 4313 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4314 | TEST_F(HostResolverManagerDnsTest, DontDisableDnsClientOnSporadicFailure) { |
[email protected] | f0f602bd | 2012-11-15 18:01:02 | [diff] [blame] | 4315 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4316 | |
| 4317 | // |proc_| defaults to successes. |
| 4318 | |
| 4319 | // 20 failures interleaved with 20 successes. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4320 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 4321 | for (unsigned i = 0; i < 40; ++i) { |
| 4322 | // Use custom names to require separate Jobs. |
| 4323 | std::string hostname = (i % 2) == 0 ? base::StringPrintf("nx_%u", i) |
| 4324 | : base::StringPrintf("ok_%u", i); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4325 | responses.emplace_back( |
| 4326 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4327 | HostPortPair(hostname, 80), NetLogWithSource(), base::nullopt, |
| 4328 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4329 | } |
| 4330 | |
| 4331 | proc_->SignalMultiple(40u); |
| 4332 | |
Eric Orth | 26fa08e | 2019-02-22 01:28:37 | [diff] [blame] | 4333 | for (const auto& response : responses) |
| 4334 | EXPECT_THAT(response->result_error(), IsOk()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4335 | |
| 4336 | // Make |proc_| default to failures. |
| 4337 | proc_->AddRuleForAllFamilies(std::string(), std::string()); |
| 4338 | |
| 4339 | // DnsTask should still be enabled. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4340 | ResolveHostResponseHelper final_response(resolver_->CreateRequest( |
| 4341 | HostPortPair("ok_last", 80), NetLogWithSource(), base::nullopt, |
| 4342 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4343 | EXPECT_THAT(final_response.result_error(), IsOk()); |
| 4344 | } |
| 4345 | |
[email protected] | ec666ab2 | 2013-04-17 20:05:59 | [diff] [blame] | 4346 | // Confirm that resolving "localhost" is unrestricted even if there are no |
| 4347 | // global IPv6 address. See SystemHostResolverCall for rationale. |
| 4348 | // Test both the DnsClient and system host resolver paths. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4349 | TEST_F(HostResolverManagerDnsTest, DualFamilyLocalhost) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4350 | CreateResolverWithLimitsAndParams(kMaxJobs, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 4351 | false /* ipv6_reachable */, |
| 4352 | true /* check_ipv6_on_wifi */); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4353 | |
| 4354 | // Make request fail if we actually get to the system resolver. |
| 4355 | proc_->AddRuleForAllFamilies(std::string(), std::string()); |
| 4356 | |
| 4357 | // Try without DnsClient. |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4358 | resolver_->SetInsecureDnsClientEnabled(false); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4359 | ResolveHostResponseHelper system_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4360 | HostPortPair("localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4361 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4362 | EXPECT_THAT(system_response.result_error(), IsOk()); |
| 4363 | EXPECT_THAT( |
| 4364 | system_response.request()->GetAddressResults().value().endpoints(), |
| 4365 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4366 | CreateExpected("::1", 80))); |
| 4367 | |
| 4368 | // With DnsClient |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 4369 | UseMockDnsClient(CreateValidDnsConfig(), CreateDefaultDnsRules()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4370 | ResolveHostResponseHelper builtin_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4371 | HostPortPair("localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4372 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4373 | EXPECT_THAT(builtin_response.result_error(), IsOk()); |
| 4374 | EXPECT_THAT( |
| 4375 | builtin_response.request()->GetAddressResults().value().endpoints(), |
| 4376 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4377 | CreateExpected("::1", 80))); |
| 4378 | |
| 4379 | // DnsClient configured without ipv6 (but ipv6 should still work for |
| 4380 | // localhost). |
| 4381 | DnsConfig config = CreateValidDnsConfig(); |
| 4382 | config.use_local_ipv6 = false; |
| 4383 | ChangeDnsConfig(config); |
| 4384 | ResolveHostResponseHelper ipv6_disabled_response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4385 | HostPortPair("localhost", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4386 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4387 | EXPECT_THAT(ipv6_disabled_response.result_error(), IsOk()); |
| 4388 | EXPECT_THAT( |
| 4389 | ipv6_disabled_response.request()->GetAddressResults().value().endpoints(), |
| 4390 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4391 | CreateExpected("::1", 80))); |
| 4392 | } |
| 4393 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4394 | TEST_F(HostResolverManagerDnsTest, SeparateJobsBySecureDnsMode) { |
| 4395 | MockDnsClientRuleList rules; |
| 4396 | rules.emplace_back("a", dns_protocol::kTypeA, true /* secure */, |
| 4397 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 4398 | true /* delay */); |
| 4399 | rules.emplace_back("a", dns_protocol::kTypeAAAA, true /* secure */, |
| 4400 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 4401 | true /* delay */); |
| 4402 | rules.emplace_back("a", dns_protocol::kTypeA, false /* secure */, |
| 4403 | MockDnsClientRule::Result(MockDnsClientRule::OK), |
| 4404 | false /* delay */); |
| 4405 | rules.emplace_back("a", dns_protocol::kTypeAAAA, false /* secure */, |
| 4406 | MockDnsClientRule::Result(MockDnsClientRule::OK), |
| 4407 | false /* delay */); |
| 4408 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 4409 | DnsConfigOverrides overrides; |
| 4410 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4411 | resolver_->SetDnsConfigOverrides(overrides); |
| 4412 | |
| 4413 | // Create three requests. One with a SECURE mode override, one with no |
| 4414 | // mode override, and one with an AUTOMATIC mode override (which is a no-op |
| 4415 | // since the DnsConfig uses AUTOMATIC). |
| 4416 | HostResolver::ResolveHostParameters parameters_secure_override; |
| 4417 | parameters_secure_override.secure_dns_mode_override = |
| 4418 | DnsConfig::SecureDnsMode::SECURE; |
| 4419 | ResolveHostResponseHelper secure_response(resolver_->CreateRequest( |
| 4420 | HostPortPair("a", 80), NetLogWithSource(), parameters_secure_override, |
| 4421 | request_context_.get(), host_cache_.get())); |
| 4422 | EXPECT_EQ(1u, resolver_->num_jobs_for_testing()); |
| 4423 | |
| 4424 | ResolveHostResponseHelper automatic_response0(resolver_->CreateRequest( |
| 4425 | HostPortPair("a", 80), NetLogWithSource(), base::nullopt, |
| 4426 | request_context_.get(), host_cache_.get())); |
| 4427 | EXPECT_EQ(2u, resolver_->num_jobs_for_testing()); |
| 4428 | |
| 4429 | HostResolver::ResolveHostParameters parameters_automatic_override; |
| 4430 | parameters_automatic_override.secure_dns_mode_override = |
| 4431 | DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4432 | ResolveHostResponseHelper automatic_response1(resolver_->CreateRequest( |
| 4433 | HostPortPair("a", 80), NetLogWithSource(), parameters_automatic_override, |
| 4434 | request_context_.get(), host_cache_.get())); |
| 4435 | // The AUTOMATIC mode requests should be joined into the same job. |
| 4436 | EXPECT_EQ(2u, resolver_->num_jobs_for_testing()); |
| 4437 | |
| 4438 | // All requests should be blocked on the secure transactions. |
| 4439 | base::RunLoop().RunUntilIdle(); |
| 4440 | EXPECT_FALSE(secure_response.complete()); |
| 4441 | EXPECT_FALSE(automatic_response0.complete()); |
| 4442 | EXPECT_FALSE(automatic_response1.complete()); |
| 4443 | |
| 4444 | // Complete secure transactions. |
| 4445 | dns_client_->CompleteDelayedTransactions(); |
| 4446 | EXPECT_THAT(secure_response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 4447 | EXPECT_THAT(automatic_response0.result_error(), IsOk()); |
| 4448 | EXPECT_THAT(automatic_response1.result_error(), IsOk()); |
| 4449 | } |
| 4450 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4451 | // Cancel a request with a single DNS transaction active. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4452 | TEST_F(HostResolverManagerDnsTest, CancelWithOneTransactionActive) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4453 | // Disable ipv6 to ensure we'll only try a single transaction for the host. |
| 4454 | CreateResolverWithLimitsAndParams(kMaxJobs, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 4455 | false /* ipv6_reachable */, |
| 4456 | true /* check_ipv6_on_wifi */); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4457 | DnsConfig config = CreateValidDnsConfig(); |
| 4458 | config.use_local_ipv6 = false; |
| 4459 | ChangeDnsConfig(config); |
| 4460 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4461 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4462 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4463 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4464 | ASSERT_FALSE(response.complete()); |
| 4465 | ASSERT_EQ(1u, num_running_dispatcher_jobs()); |
| 4466 | |
| 4467 | response.CancelRequest(); |
| 4468 | base::RunLoop().RunUntilIdle(); |
| 4469 | EXPECT_FALSE(response.complete()); |
| 4470 | |
| 4471 | // Dispatcher state checked in TearDown. |
| 4472 | } |
| 4473 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4474 | // Cancel a request with a single DNS transaction active and another pending. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4475 | TEST_F(HostResolverManagerDnsTest, CancelWithOneTransactionActiveOnePending) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4476 | CreateSerialResolver(); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4477 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4478 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4479 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4480 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4481 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4482 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 4483 | |
| 4484 | response.CancelRequest(); |
| 4485 | base::RunLoop().RunUntilIdle(); |
| 4486 | EXPECT_FALSE(response.complete()); |
| 4487 | |
| 4488 | // Dispatcher state checked in TearDown. |
| 4489 | } |
| 4490 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4491 | // Cancel a request with two DNS transactions active. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4492 | TEST_F(HostResolverManagerDnsTest, CancelWithTwoTransactionsActive) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4493 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4494 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4495 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4496 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4497 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4498 | EXPECT_EQ(2u, num_running_dispatcher_jobs()); |
| 4499 | |
| 4500 | response.CancelRequest(); |
| 4501 | base::RunLoop().RunUntilIdle(); |
| 4502 | EXPECT_FALSE(response.complete()); |
| 4503 | |
| 4504 | // Dispatcher state checked in TearDown. |
| 4505 | } |
| 4506 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4507 | // Delete a resolver with some active requests and some queued requests. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4508 | TEST_F(HostResolverManagerDnsTest, DeleteWithActiveTransactions) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4509 | // At most 10 Jobs active at once. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4510 | CreateResolverWithLimitsAndParams(10u, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 4511 | true /* ipv6_reachable */, |
| 4512 | true /* check_ipv6_on_wifi */); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4513 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4514 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4515 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4516 | // Add 12 DNS lookups (creating well more than 10 transaction). |
| 4517 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 4518 | for (int i = 0; i < 12; ++i) { |
| 4519 | std::string hostname = base::StringPrintf("ok%i", i); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4520 | responses.emplace_back( |
| 4521 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4522 | HostPortPair(hostname, 80), NetLogWithSource(), base::nullopt, |
| 4523 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4524 | } |
| 4525 | EXPECT_EQ(10u, num_running_dispatcher_jobs()); |
| 4526 | |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 4527 | DestroyResolver(); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4528 | |
| 4529 | base::RunLoop().RunUntilIdle(); |
| 4530 | for (auto& response : responses) { |
| 4531 | EXPECT_FALSE(response->complete()); |
| 4532 | } |
| 4533 | } |
| 4534 | |
dalyk | c682ba3c | 2019-08-21 17:16:23 | [diff] [blame^] | 4535 | TEST_F(HostResolverManagerDnsTest, DeleteWithSecureTransactions) { |
| 4536 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4537 | DnsConfigOverrides overrides; |
| 4538 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::SECURE; |
| 4539 | resolver_->SetDnsConfigOverrides(overrides); |
| 4540 | |
| 4541 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4542 | HostPortPair("secure", 80), NetLogWithSource(), base::nullopt, |
| 4543 | request_context_.get(), host_cache_.get())); |
| 4544 | |
| 4545 | DestroyResolver(); |
| 4546 | |
| 4547 | base::RunLoop().RunUntilIdle(); |
| 4548 | EXPECT_FALSE(response.complete()); |
| 4549 | } |
| 4550 | |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 4551 | TEST_F(HostResolverManagerDnsTest, DeleteWithCompletedRequests) { |
| 4552 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4553 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4554 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4555 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4556 | request_context_.get(), host_cache_.get())); |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 4557 | |
| 4558 | EXPECT_THAT(response.result_error(), IsOk()); |
| 4559 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 4560 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4561 | CreateExpected("::1", 80))); |
| 4562 | |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 4563 | DestroyResolver(); |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 4564 | |
| 4565 | // Completed requests should be unaffected by manager destruction. |
| 4566 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 4567 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4568 | CreateExpected("::1", 80))); |
| 4569 | } |
| 4570 | |
| 4571 | TEST_F(HostResolverManagerDnsTest, ExplicitCancel) { |
| 4572 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4573 | |
| 4574 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4575 | HostPortPair("4slow_4ok", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4576 | request_context_.get(), host_cache_.get())); |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 4577 | |
| 4578 | response.request()->Cancel(); |
| 4579 | dns_client_->CompleteDelayedTransactions(); |
| 4580 | |
| 4581 | base::RunLoop().RunUntilIdle(); |
| 4582 | EXPECT_FALSE(response.complete()); |
| 4583 | } |
| 4584 | |
| 4585 | TEST_F(HostResolverManagerDnsTest, ExplicitCancel_Completed) { |
| 4586 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4587 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4588 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4589 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 4590 | request_context_.get(), host_cache_.get())); |
Eric Orth | 5233c3a | 2019-04-08 17:01:14 | [diff] [blame] | 4591 | |
| 4592 | EXPECT_THAT(response.result_error(), IsOk()); |
| 4593 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 4594 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4595 | CreateExpected("::1", 80))); |
| 4596 | |
| 4597 | response.request()->Cancel(); |
| 4598 | |
| 4599 | // Completed requests should be unaffected by cancellation. |
| 4600 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 4601 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4602 | CreateExpected("::1", 80))); |
| 4603 | } |
| 4604 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4605 | // Cancel a request with only the IPv6 transaction active. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4606 | TEST_F(HostResolverManagerDnsTest, CancelWithIPv6TransactionActive) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4607 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4608 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4609 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4610 | HostPortPair("6slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 4611 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4612 | EXPECT_EQ(2u, num_running_dispatcher_jobs()); |
| 4613 | |
| 4614 | // The IPv4 request should complete, the IPv6 request is still pending. |
| 4615 | base::RunLoop().RunUntilIdle(); |
| 4616 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 4617 | |
| 4618 | response.CancelRequest(); |
| 4619 | base::RunLoop().RunUntilIdle(); |
| 4620 | EXPECT_FALSE(response.complete()); |
| 4621 | |
| 4622 | // Dispatcher state checked in TearDown. |
| 4623 | } |
| 4624 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4625 | // Cancel a request with only the IPv4 transaction pending. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4626 | TEST_F(HostResolverManagerDnsTest, CancelWithIPv4TransactionPending) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 4627 | set_allow_fallback_to_proctask(false); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4628 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4629 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4630 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4631 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 4632 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4633 | EXPECT_EQ(2u, num_running_dispatcher_jobs()); |
| 4634 | |
| 4635 | // The IPv6 request should complete, the IPv4 request is still pending. |
| 4636 | base::RunLoop().RunUntilIdle(); |
| 4637 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 4638 | |
| 4639 | response.CancelRequest(); |
| 4640 | base::RunLoop().RunUntilIdle(); |
| 4641 | EXPECT_FALSE(response.complete()); |
| 4642 | } |
| 4643 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4644 | TEST_F(HostResolverManagerDnsTest, CancelWithAutomaticModeTransactionPending) { |
| 4645 | MockDnsClientRuleList rules; |
| 4646 | rules.emplace_back("secure_6slow_6nx_insecure_6slow_ok", dns_protocol::kTypeA, |
| 4647 | true /* secure */, |
| 4648 | MockDnsClientRule::Result(MockDnsClientRule::OK), |
| 4649 | false /* delay */); |
| 4650 | rules.emplace_back("secure_6slow_6nx_insecure_6slow_ok", |
| 4651 | dns_protocol::kTypeAAAA, true /* secure */, |
| 4652 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 4653 | true /* delay */); |
| 4654 | rules.emplace_back("secure_6slow_6nx_insecure_6slow_ok", dns_protocol::kTypeA, |
| 4655 | false /* secure */, |
| 4656 | MockDnsClientRule::Result(MockDnsClientRule::OK), |
| 4657 | false /* delay */); |
| 4658 | rules.emplace_back("secure_6slow_6nx_insecure_6slow_ok", |
| 4659 | dns_protocol::kTypeAAAA, false /* secure */, |
| 4660 | MockDnsClientRule::Result(MockDnsClientRule::OK), |
| 4661 | true /* delay */); |
| 4662 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 4663 | |
| 4664 | DnsConfigOverrides overrides; |
| 4665 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4666 | resolver_->SetDnsConfigOverrides(overrides); |
| 4667 | |
| 4668 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 4669 | HostPortPair("secure_6slow_6nx_insecure_6slow_ok", 80), |
| 4670 | NetLogWithSource(), base::nullopt, request_context_.get(), |
| 4671 | host_cache_.get())); |
dalyk | c682ba3c | 2019-08-21 17:16:23 | [diff] [blame^] | 4672 | EXPECT_EQ(0u, num_running_dispatcher_jobs()); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4673 | |
| 4674 | // The secure IPv4 request should complete, the secure IPv6 request is still |
| 4675 | // pending. |
| 4676 | base::RunLoop().RunUntilIdle(); |
dalyk | c682ba3c | 2019-08-21 17:16:23 | [diff] [blame^] | 4677 | EXPECT_EQ(0u, num_running_dispatcher_jobs()); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4678 | |
| 4679 | response0.CancelRequest(); |
| 4680 | base::RunLoop().RunUntilIdle(); |
| 4681 | EXPECT_FALSE(response0.complete()); |
| 4682 | EXPECT_EQ(0u, num_running_dispatcher_jobs()); |
| 4683 | |
| 4684 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
| 4685 | HostPortPair("secure_6slow_6nx_insecure_6slow_ok", 80), |
| 4686 | NetLogWithSource(), base::nullopt, request_context_.get(), |
| 4687 | host_cache_.get())); |
dalyk | c682ba3c | 2019-08-21 17:16:23 | [diff] [blame^] | 4688 | EXPECT_EQ(0u, num_running_dispatcher_jobs()); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4689 | |
| 4690 | // The secure IPv4 request should complete, the secure IPv6 request is still |
| 4691 | // pending. |
| 4692 | base::RunLoop().RunUntilIdle(); |
dalyk | c682ba3c | 2019-08-21 17:16:23 | [diff] [blame^] | 4693 | EXPECT_EQ(0u, num_running_dispatcher_jobs()); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4694 | |
| 4695 | // Let the secure IPv6 request complete and start the insecure requests. |
| 4696 | dns_client_->CompleteDelayedTransactions(); |
| 4697 | EXPECT_EQ(2u, num_running_dispatcher_jobs()); |
| 4698 | |
| 4699 | // The insecure IPv4 request should complete, the insecure IPv6 request is |
| 4700 | // still pending. |
| 4701 | base::RunLoop().RunUntilIdle(); |
| 4702 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 4703 | |
| 4704 | response1.CancelRequest(); |
| 4705 | base::RunLoop().RunUntilIdle(); |
| 4706 | EXPECT_FALSE(response1.complete()); |
| 4707 | |
| 4708 | // Dispatcher state checked in TearDown. |
| 4709 | } |
| 4710 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4711 | // Test cases where AAAA completes first. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 4712 | TEST_F(HostResolverManagerDnsTest, AAAACompletesFirst) { |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 4713 | set_allow_fallback_to_proctask(false); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 4714 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4715 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4716 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4717 | responses.emplace_back( |
| 4718 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4719 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 4720 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4721 | responses.emplace_back( |
| 4722 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4723 | HostPortPair("4slow_4ok", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4724 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4725 | responses.emplace_back( |
| 4726 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4727 | HostPortPair("4slow_4timeout", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4728 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 4729 | responses.emplace_back( |
| 4730 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 4731 | HostPortPair("4slow_6timeout", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 4732 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 4733 | |
| 4734 | base::RunLoop().RunUntilIdle(); |
| 4735 | EXPECT_FALSE(responses[0]->complete()); |
| 4736 | EXPECT_FALSE(responses[1]->complete()); |
| 4737 | EXPECT_FALSE(responses[2]->complete()); |
| 4738 | // The IPv6 of request 3 should have failed and resulted in cancelling the |
| 4739 | // IPv4 request. |
| 4740 | EXPECT_THAT(responses[3]->result_error(), IsError(ERR_DNS_TIMED_OUT)); |
| 4741 | EXPECT_EQ(3u, num_running_dispatcher_jobs()); |
| 4742 | |
| 4743 | dns_client_->CompleteDelayedTransactions(); |
| 4744 | EXPECT_THAT(responses[0]->result_error(), IsOk()); |
| 4745 | EXPECT_THAT(responses[0]->request()->GetAddressResults().value().endpoints(), |
| 4746 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4747 | CreateExpected("::1", 80))); |
| 4748 | |
| 4749 | EXPECT_THAT(responses[1]->result_error(), IsOk()); |
| 4750 | EXPECT_THAT(responses[1]->request()->GetAddressResults().value().endpoints(), |
| 4751 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 4752 | |
| 4753 | EXPECT_THAT(responses[2]->result_error(), IsError(ERR_DNS_TIMED_OUT)); |
| 4754 | } |
| 4755 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4756 | TEST_F(HostResolverManagerDnsTest, AAAACompletesFirst_AutomaticMode) { |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4757 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4758 | rules.emplace_back("secure_slow_nx_insecure_4slow_ok", dns_protocol::kTypeA, |
| 4759 | true /* secure */, |
| 4760 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 4761 | true /* delay */); |
| 4762 | rules.emplace_back("secure_slow_nx_insecure_4slow_ok", |
| 4763 | dns_protocol::kTypeAAAA, true /* secure */, |
| 4764 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 4765 | true /* delay */); |
| 4766 | rules.emplace_back("secure_slow_nx_insecure_4slow_ok", dns_protocol::kTypeA, |
| 4767 | false /* secure */, |
| 4768 | MockDnsClientRule::Result(MockDnsClientRule::OK), |
| 4769 | true /* delay */); |
| 4770 | rules.emplace_back("secure_slow_nx_insecure_4slow_ok", |
| 4771 | dns_protocol::kTypeAAAA, false /* secure */, |
| 4772 | MockDnsClientRule::Result(MockDnsClientRule::EMPTY), |
| 4773 | false /* delay */); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4774 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4775 | DnsConfigOverrides overrides; |
| 4776 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4777 | resolver_->SetDnsConfigOverrides(overrides); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4778 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4779 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4780 | HostPortPair("secure_slow_nx_insecure_4slow_ok", 80), NetLogWithSource(), |
| 4781 | base::nullopt, request_context_.get(), host_cache_.get())); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4782 | base::RunLoop().RunUntilIdle(); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4783 | EXPECT_FALSE(response.complete()); |
| 4784 | // Complete the secure transactions. |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4785 | dns_client_->CompleteDelayedTransactions(); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4786 | base::RunLoop().RunUntilIdle(); |
| 4787 | EXPECT_FALSE(response.complete()); |
| 4788 | // Complete the insecure transactions. |
| 4789 | dns_client_->CompleteDelayedTransactions(); |
| 4790 | ASSERT_THAT(response.result_error(), IsOk()); |
| 4791 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 4792 | testing::ElementsAre(CreateExpected("127.0.0.1", 80))); |
| 4793 | HostCache::Key insecure_key = HostCache::Key( |
| 4794 | "secure_slow_nx_insecure_4slow_ok", DnsQueryType::UNSPECIFIED, |
| 4795 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4796 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result = |
| 4797 | GetCacheHit(insecure_key); |
| 4798 | EXPECT_TRUE(!!cache_result); |
| 4799 | } |
| 4800 | |
| 4801 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Automatic) { |
| 4802 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.100"); |
| 4803 | set_allow_fallback_to_proctask(true); |
| 4804 | |
| 4805 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4806 | DnsConfigOverrides overrides; |
| 4807 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4808 | resolver_->SetDnsConfigOverrides(overrides); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4809 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 4810 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4811 | // A successful DoH request should result in a secure cache entry. |
| 4812 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 4813 | HostPortPair("automatic", 80), NetLogWithSource(), base::nullopt, |
| 4814 | request_context_.get(), host_cache_.get())); |
| 4815 | ASSERT_THAT(response_secure.result_error(), IsOk()); |
| 4816 | EXPECT_THAT( |
| 4817 | response_secure.request()->GetAddressResults().value().endpoints(), |
| 4818 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4819 | CreateExpected("::1", 80))); |
| 4820 | HostCache::Key secure_key = |
| 4821 | HostCache::Key("automatic", DnsQueryType::UNSPECIFIED, |
| 4822 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4823 | secure_key.secure = true; |
| 4824 | cache_result = GetCacheHit(secure_key); |
| 4825 | EXPECT_TRUE(!!cache_result); |
| 4826 | |
| 4827 | // A successful plaintext DNS request should result in an insecure cache |
| 4828 | // entry. |
| 4829 | ResolveHostResponseHelper response_insecure(resolver_->CreateRequest( |
| 4830 | HostPortPair("insecure_automatic", 80), NetLogWithSource(), base::nullopt, |
| 4831 | request_context_.get(), host_cache_.get())); |
| 4832 | ASSERT_THAT(response_insecure.result_error(), IsOk()); |
| 4833 | EXPECT_THAT( |
| 4834 | response_insecure.request()->GetAddressResults().value().endpoints(), |
| 4835 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4836 | CreateExpected("::1", 80))); |
| 4837 | HostCache::Key insecure_key = |
| 4838 | HostCache::Key("insecure_automatic", DnsQueryType::UNSPECIFIED, |
| 4839 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4840 | cache_result = GetCacheHit(insecure_key); |
| 4841 | EXPECT_TRUE(!!cache_result); |
| 4842 | |
| 4843 | // Fallback to ProcTask allowed in AUTOMATIC mode. |
| 4844 | ResolveHostResponseHelper response_proc(resolver_->CreateRequest( |
| 4845 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
| 4846 | request_context_.get(), host_cache_.get())); |
| 4847 | proc_->SignalMultiple(1u); |
| 4848 | EXPECT_THAT(response_proc.result_error(), IsOk()); |
| 4849 | EXPECT_THAT(response_proc.request()->GetAddressResults().value().endpoints(), |
| 4850 | testing::ElementsAre(CreateExpected("192.168.1.100", 80))); |
| 4851 | } |
| 4852 | |
dalyk | e966a183 | 2019-06-05 20:53:13 | [diff] [blame] | 4853 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Automatic_SecureCache) { |
| 4854 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4855 | DnsConfigOverrides overrides; |
| 4856 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4857 | resolver_->SetDnsConfigOverrides(overrides); |
| 4858 | |
| 4859 | // Populate cache with a secure entry. |
| 4860 | HostCache::Key cached_secure_key = |
| 4861 | HostCache::Key("automatic_cached", DnsQueryType::UNSPECIFIED, |
| 4862 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4863 | cached_secure_key.secure = true; |
| 4864 | IPEndPoint kExpectedSecureIP = CreateExpected("192.168.1.102", 80); |
| 4865 | PopulateCache(cached_secure_key, kExpectedSecureIP); |
| 4866 | |
| 4867 | // The secure cache should be checked prior to any DoH request being sent. |
| 4868 | ResolveHostResponseHelper response_secure_cached(resolver_->CreateRequest( |
| 4869 | HostPortPair("automatic_cached", 80), NetLogWithSource(), base::nullopt, |
| 4870 | request_context_.get(), host_cache_.get())); |
| 4871 | EXPECT_THAT(response_secure_cached.result_error(), IsOk()); |
| 4872 | EXPECT_THAT( |
| 4873 | response_secure_cached.request()->GetAddressResults().value().endpoints(), |
| 4874 | testing::ElementsAre(kExpectedSecureIP)); |
| 4875 | EXPECT_FALSE( |
| 4876 | response_secure_cached.request()->GetStaleInfo().value().is_stale()); |
| 4877 | } |
| 4878 | |
| 4879 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Automatic_InsecureCache) { |
| 4880 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4881 | DnsConfigOverrides overrides; |
| 4882 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4883 | resolver_->SetDnsConfigOverrides(overrides); |
| 4884 | |
| 4885 | // Populate cache with an insecure entry. |
| 4886 | HostCache::Key cached_insecure_key = |
| 4887 | HostCache::Key("insecure_automatic_cached", DnsQueryType::UNSPECIFIED, |
| 4888 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4889 | IPEndPoint kExpectedInsecureIP = CreateExpected("192.168.1.103", 80); |
| 4890 | PopulateCache(cached_insecure_key, kExpectedInsecureIP); |
| 4891 | |
| 4892 | // The insecure cache should be checked after DoH requests fail. |
| 4893 | ResolveHostResponseHelper response_insecure_cached(resolver_->CreateRequest( |
| 4894 | HostPortPair("insecure_automatic_cached", 80), NetLogWithSource(), |
| 4895 | base::nullopt, request_context_.get(), host_cache_.get())); |
| 4896 | EXPECT_THAT(response_insecure_cached.result_error(), IsOk()); |
| 4897 | EXPECT_THAT(response_insecure_cached.request() |
| 4898 | ->GetAddressResults() |
| 4899 | .value() |
| 4900 | .endpoints(), |
| 4901 | testing::ElementsAre(kExpectedInsecureIP)); |
| 4902 | EXPECT_FALSE( |
| 4903 | response_insecure_cached.request()->GetStaleInfo().value().is_stale()); |
| 4904 | } |
| 4905 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4906 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Automatic_Downgrade) { |
| 4907 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4908 | // Remove all DoH servers from the config so there is no DoH server available. |
| 4909 | DnsConfigOverrides overrides; |
| 4910 | std::vector<DnsConfig::DnsOverHttpsServerConfig> doh_servers; |
| 4911 | overrides.dns_over_https_servers = doh_servers; |
| 4912 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4913 | resolver_->SetDnsConfigOverrides(overrides); |
| 4914 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 4915 | |
dalyk | e966a183 | 2019-06-05 20:53:13 | [diff] [blame] | 4916 | // Populate cache with both secure and insecure entries. |
| 4917 | HostCache::Key cached_secure_key = |
| 4918 | HostCache::Key("automatic_cached", DnsQueryType::UNSPECIFIED, |
| 4919 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4920 | cached_secure_key.secure = true; |
| 4921 | IPEndPoint kExpectedSecureIP = CreateExpected("192.168.1.102", 80); |
| 4922 | PopulateCache(cached_secure_key, kExpectedSecureIP); |
| 4923 | HostCache::Key cached_insecure_key = |
| 4924 | HostCache::Key("insecure_automatic_cached", DnsQueryType::UNSPECIFIED, |
| 4925 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4926 | IPEndPoint kExpectedInsecureIP = CreateExpected("192.168.1.103", 80); |
| 4927 | PopulateCache(cached_insecure_key, kExpectedInsecureIP); |
| 4928 | |
| 4929 | // The secure cache should still be checked first. |
| 4930 | ResolveHostResponseHelper response_cached(resolver_->CreateRequest( |
| 4931 | HostPortPair("automatic_cached", 80), NetLogWithSource(), base::nullopt, |
| 4932 | request_context_.get(), host_cache_.get())); |
| 4933 | EXPECT_THAT(response_cached.result_error(), IsOk()); |
| 4934 | EXPECT_THAT( |
| 4935 | response_cached.request()->GetAddressResults().value().endpoints(), |
| 4936 | testing::ElementsAre(kExpectedSecureIP)); |
| 4937 | |
| 4938 | // The insecure cache should be checked before any insecure requests are sent. |
| 4939 | ResolveHostResponseHelper insecure_response_cached(resolver_->CreateRequest( |
| 4940 | HostPortPair("insecure_automatic_cached", 80), NetLogWithSource(), |
| 4941 | base::nullopt, request_context_.get(), host_cache_.get())); |
| 4942 | EXPECT_THAT(insecure_response_cached.result_error(), IsOk()); |
| 4943 | EXPECT_THAT(insecure_response_cached.request() |
| 4944 | ->GetAddressResults() |
| 4945 | .value() |
| 4946 | .endpoints(), |
| 4947 | testing::ElementsAre(kExpectedInsecureIP)); |
| 4948 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4949 | // The DnsConfig doesn't contain DoH servers so AUTOMATIC mode will be |
| 4950 | // downgraded to OFF. A successful plaintext DNS request should result in an |
| 4951 | // insecure cache entry. |
| 4952 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 4953 | HostPortPair("automatic", 80), NetLogWithSource(), base::nullopt, |
| 4954 | request_context_.get(), host_cache_.get())); |
| 4955 | ASSERT_THAT(response.result_error(), IsOk()); |
| 4956 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4957 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 4958 | CreateExpected("::1", 80))); |
| 4959 | HostCache::Key key = |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4960 | HostCache::Key("automatic", DnsQueryType::UNSPECIFIED, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4961 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4962 | cache_result = GetCacheHit(key); |
| 4963 | EXPECT_TRUE(!!cache_result); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 4964 | } |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 4965 | |
dalyk | e966a183 | 2019-06-05 20:53:13 | [diff] [blame] | 4966 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Automatic_Stale) { |
| 4967 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4968 | DnsConfigOverrides overrides; |
| 4969 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 4970 | resolver_->SetDnsConfigOverrides(overrides); |
| 4971 | |
| 4972 | // Populate cache with insecure entry. |
| 4973 | HostCache::Key cached_stale_key = |
| 4974 | HostCache::Key("automatic_stale", DnsQueryType::UNSPECIFIED, |
| 4975 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 4976 | IPEndPoint kExpectedStaleIP = CreateExpected("192.168.1.102", 80); |
| 4977 | PopulateCache(cached_stale_key, kExpectedStaleIP); |
| 4978 | MakeCacheStale(); |
| 4979 | |
| 4980 | HostResolver::ResolveHostParameters stale_allowed_parameters; |
| 4981 | stale_allowed_parameters.cache_usage = |
| 4982 | HostResolver::ResolveHostParameters::CacheUsage::STALE_ALLOWED; |
| 4983 | |
| 4984 | // The insecure cache should be checked before secure requests are made since |
| 4985 | // stale results are allowed. |
| 4986 | ResolveHostResponseHelper response_stale(resolver_->CreateRequest( |
| 4987 | HostPortPair("automatic_stale", 80), NetLogWithSource(), |
| 4988 | stale_allowed_parameters, request_context_.get(), host_cache_.get())); |
| 4989 | EXPECT_THAT(response_stale.result_error(), IsOk()); |
| 4990 | EXPECT_THAT(response_stale.request()->GetAddressResults().value().endpoints(), |
| 4991 | testing::ElementsAre(kExpectedStaleIP)); |
| 4992 | EXPECT_TRUE(response_stale.request()->GetStaleInfo()->is_stale()); |
| 4993 | } |
| 4994 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 4995 | TEST_F(HostResolverManagerDnsTest, |
| 4996 | SecureDnsMode_Automatic_InsecureAsyncDisabled) { |
| 4997 | proc_->AddRuleForAllFamilies("insecure_automatic", "192.168.1.100"); |
| 4998 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 4999 | resolver_->SetInsecureDnsClientEnabled(false); |
| 5000 | DnsConfigOverrides overrides; |
| 5001 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 5002 | resolver_->SetDnsConfigOverrides(overrides); |
| 5003 | |
| 5004 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 5005 | |
| 5006 | // The secure part of the dns client should be enabled. |
| 5007 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 5008 | HostPortPair("automatic", 80), NetLogWithSource(), base::nullopt, |
| 5009 | request_context_.get(), host_cache_.get())); |
| 5010 | ASSERT_THAT(response_secure.result_error(), IsOk()); |
| 5011 | EXPECT_THAT( |
| 5012 | response_secure.request()->GetAddressResults().value().endpoints(), |
| 5013 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 5014 | CreateExpected("::1", 80))); |
| 5015 | HostCache::Key secure_key = |
| 5016 | HostCache::Key("automatic", DnsQueryType::UNSPECIFIED, |
| 5017 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5018 | secure_key.secure = true; |
| 5019 | cache_result = GetCacheHit(secure_key); |
| 5020 | EXPECT_TRUE(!!cache_result); |
| 5021 | |
| 5022 | // The insecure part of the dns client is disabled so insecure requests |
| 5023 | // should be skipped. |
| 5024 | ResolveHostResponseHelper response_insecure(resolver_->CreateRequest( |
| 5025 | HostPortPair("insecure_automatic", 80), NetLogWithSource(), base::nullopt, |
| 5026 | request_context_.get(), host_cache_.get())); |
| 5027 | proc_->SignalMultiple(1u); |
| 5028 | ASSERT_THAT(response_insecure.result_error(), IsOk()); |
| 5029 | EXPECT_THAT( |
| 5030 | response_insecure.request()->GetAddressResults().value().endpoints(), |
| 5031 | testing::ElementsAre(CreateExpected("192.168.1.100", 80))); |
| 5032 | HostCache::Key insecure_key = |
| 5033 | HostCache::Key("insecure_automatic", DnsQueryType::UNSPECIFIED, |
| 5034 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5035 | cache_result = GetCacheHit(insecure_key); |
| 5036 | EXPECT_TRUE(!!cache_result); |
| 5037 | |
| 5038 | HostCache::Key cached_insecure_key = |
| 5039 | HostCache::Key("insecure_automatic_cached", DnsQueryType::UNSPECIFIED, |
| 5040 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5041 | IPEndPoint kExpectedInsecureIP = CreateExpected("192.168.1.101", 80); |
| 5042 | PopulateCache(cached_insecure_key, kExpectedInsecureIP); |
| 5043 | |
| 5044 | // The insecure cache should still be checked even if the insecure part of |
| 5045 | // the dns client is disabled. |
| 5046 | ResolveHostResponseHelper response_insecure_cached(resolver_->CreateRequest( |
| 5047 | HostPortPair("insecure_automatic_cached", 80), NetLogWithSource(), |
| 5048 | base::nullopt, request_context_.get(), host_cache_.get())); |
| 5049 | EXPECT_THAT(response_insecure_cached.result_error(), IsOk()); |
| 5050 | EXPECT_THAT(response_insecure_cached.request() |
| 5051 | ->GetAddressResults() |
| 5052 | .value() |
| 5053 | .endpoints(), |
| 5054 | testing::ElementsAre(kExpectedInsecureIP)); |
| 5055 | } |
| 5056 | |
dalyk | 6d7d8ead | 2019-08-15 03:30:08 | [diff] [blame] | 5057 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Automatic_DotActive) { |
| 5058 | proc_->AddRuleForAllFamilies("insecure_automatic", "192.168.1.100"); |
| 5059 | DnsConfig config = CreateValidDnsConfig(); |
| 5060 | config.dns_over_tls_active = true; |
| 5061 | ChangeDnsConfig(config); |
| 5062 | DnsConfigOverrides overrides; |
| 5063 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 5064 | resolver_->SetDnsConfigOverrides(overrides); |
| 5065 | |
| 5066 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 5067 | |
| 5068 | // The secure part of the dns client should be enabled. |
| 5069 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 5070 | HostPortPair("automatic", 80), NetLogWithSource(), base::nullopt, |
| 5071 | request_context_.get(), host_cache_.get())); |
| 5072 | ASSERT_THAT(response_secure.result_error(), IsOk()); |
| 5073 | EXPECT_THAT( |
| 5074 | response_secure.request()->GetAddressResults().value().endpoints(), |
| 5075 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 5076 | CreateExpected("::1", 80))); |
| 5077 | HostCache::Key secure_key = |
| 5078 | HostCache::Key("automatic", DnsQueryType::UNSPECIFIED, |
| 5079 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5080 | secure_key.secure = true; |
| 5081 | cache_result = GetCacheHit(secure_key); |
| 5082 | EXPECT_TRUE(!!cache_result); |
| 5083 | |
| 5084 | // Insecure async requests should be skipped since the system resolver |
| 5085 | // requests will be secure. |
| 5086 | ResolveHostResponseHelper response_insecure(resolver_->CreateRequest( |
| 5087 | HostPortPair("insecure_automatic", 80), NetLogWithSource(), base::nullopt, |
| 5088 | request_context_.get(), host_cache_.get())); |
| 5089 | proc_->SignalMultiple(1u); |
| 5090 | ASSERT_THAT(response_insecure.result_error(), IsOk()); |
| 5091 | EXPECT_THAT( |
| 5092 | response_insecure.request()->GetAddressResults().value().endpoints(), |
| 5093 | testing::ElementsAre(CreateExpected("192.168.1.100", 80))); |
| 5094 | HostCache::Key insecure_key = |
| 5095 | HostCache::Key("insecure_automatic", DnsQueryType::UNSPECIFIED, |
| 5096 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5097 | cache_result = GetCacheHit(insecure_key); |
| 5098 | EXPECT_TRUE(!!cache_result); |
| 5099 | |
| 5100 | HostCache::Key cached_insecure_key = |
| 5101 | HostCache::Key("insecure_automatic_cached", DnsQueryType::UNSPECIFIED, |
| 5102 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5103 | IPEndPoint kExpectedInsecureIP = CreateExpected("192.168.1.101", 80); |
| 5104 | PopulateCache(cached_insecure_key, kExpectedInsecureIP); |
| 5105 | |
| 5106 | // The insecure cache should still be checked. |
| 5107 | ResolveHostResponseHelper response_insecure_cached(resolver_->CreateRequest( |
| 5108 | HostPortPair("insecure_automatic_cached", 80), NetLogWithSource(), |
| 5109 | base::nullopt, request_context_.get(), host_cache_.get())); |
| 5110 | EXPECT_THAT(response_insecure_cached.result_error(), IsOk()); |
| 5111 | EXPECT_THAT(response_insecure_cached.request() |
| 5112 | ->GetAddressResults() |
| 5113 | .value() |
| 5114 | .endpoints(), |
| 5115 | testing::ElementsAre(kExpectedInsecureIP)); |
| 5116 | } |
| 5117 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5118 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Secure) { |
| 5119 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.100"); |
| 5120 | set_allow_fallback_to_proctask(true); |
| 5121 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5122 | ChangeDnsConfig(CreateValidDnsConfig()); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5123 | DnsConfigOverrides overrides; |
| 5124 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::SECURE; |
| 5125 | resolver_->SetDnsConfigOverrides(overrides); |
| 5126 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 5127 | |
| 5128 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 5129 | HostPortPair("secure", 80), NetLogWithSource(), base::nullopt, |
| 5130 | request_context_.get(), host_cache_.get())); |
| 5131 | ASSERT_THAT(response_secure.result_error(), IsOk()); |
| 5132 | HostCache::Key secure_key = |
| 5133 | HostCache::Key("secure", DnsQueryType::UNSPECIFIED, |
| 5134 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5135 | secure_key.secure = true; |
| 5136 | cache_result = GetCacheHit(secure_key); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5137 | EXPECT_TRUE(!!cache_result); |
| 5138 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5139 | ResolveHostResponseHelper response_insecure(resolver_->CreateRequest( |
| 5140 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 5141 | request_context_.get(), host_cache_.get())); |
| 5142 | ASSERT_THAT(response_insecure.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 5143 | HostCache::Key insecure_key = |
| 5144 | HostCache::Key("ok", DnsQueryType::UNSPECIFIED, |
| 5145 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5146 | cache_result = GetCacheHit(insecure_key); |
| 5147 | EXPECT_FALSE(!!cache_result); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5148 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5149 | // Fallback to ProcTask not allowed in SECURE mode. |
| 5150 | ResolveHostResponseHelper response_proc(resolver_->CreateRequest( |
| 5151 | HostPortPair("nx_succeed", 80), NetLogWithSource(), base::nullopt, |
| 5152 | request_context_.get(), host_cache_.get())); |
| 5153 | proc_->SignalMultiple(1u); |
| 5154 | EXPECT_THAT(response_proc.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5155 | } |
| 5156 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5157 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Secure_InsecureAsyncDisabled) { |
| 5158 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.100"); |
| 5159 | set_allow_fallback_to_proctask(true); |
| 5160 | resolver_->SetInsecureDnsClientEnabled(false); |
| 5161 | |
| 5162 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5163 | DnsConfigOverrides overrides; |
| 5164 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::SECURE; |
| 5165 | resolver_->SetDnsConfigOverrides(overrides); |
| 5166 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 5167 | |
| 5168 | // The secure part of the dns client should be enabled. |
| 5169 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 5170 | HostPortPair("secure", 80), NetLogWithSource(), base::nullopt, |
| 5171 | request_context_.get(), host_cache_.get())); |
| 5172 | ASSERT_THAT(response_secure.result_error(), IsOk()); |
| 5173 | HostCache::Key secure_key = |
| 5174 | HostCache::Key("secure", DnsQueryType::UNSPECIFIED, |
| 5175 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5176 | secure_key.secure = true; |
| 5177 | cache_result = GetCacheHit(secure_key); |
| 5178 | EXPECT_TRUE(!!cache_result); |
| 5179 | } |
| 5180 | |
dalyk | 6f7f7ce6 | 2019-08-15 23:18:23 | [diff] [blame] | 5181 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Secure_Local_CacheMiss) { |
| 5182 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5183 | DnsConfigOverrides overrides; |
| 5184 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::SECURE; |
| 5185 | resolver_->SetDnsConfigOverrides(overrides); |
| 5186 | |
| 5187 | HostResolver::ResolveHostParameters source_none_parameters; |
| 5188 | source_none_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 5189 | |
| 5190 | // Populate cache with an insecure entry. |
| 5191 | HostCache::Key cached_insecure_key = |
| 5192 | HostCache::Key("automatic", DnsQueryType::UNSPECIFIED, |
| 5193 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5194 | IPEndPoint kExpectedInsecureIP = CreateExpected("192.168.1.102", 80); |
| 5195 | PopulateCache(cached_insecure_key, kExpectedInsecureIP); |
| 5196 | |
| 5197 | // NONE query expected to complete synchronously with a cache miss since |
| 5198 | // the insecure cache should not be checked. |
| 5199 | ResolveHostResponseHelper cache_miss_request(resolver_->CreateRequest( |
| 5200 | HostPortPair("automatic", 80), NetLogWithSource(), source_none_parameters, |
| 5201 | request_context_.get(), host_cache_.get())); |
| 5202 | EXPECT_TRUE(cache_miss_request.complete()); |
| 5203 | EXPECT_THAT(cache_miss_request.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 5204 | EXPECT_FALSE(cache_miss_request.request()->GetAddressResults()); |
| 5205 | EXPECT_FALSE(cache_miss_request.request()->GetStaleInfo()); |
| 5206 | } |
| 5207 | |
| 5208 | TEST_F(HostResolverManagerDnsTest, SecureDnsMode_Secure_Local_CacheHit) { |
| 5209 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5210 | DnsConfigOverrides overrides; |
| 5211 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::SECURE; |
| 5212 | resolver_->SetDnsConfigOverrides(overrides); |
| 5213 | |
| 5214 | HostResolver::ResolveHostParameters source_none_parameters; |
| 5215 | source_none_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 5216 | |
| 5217 | // Populate cache with a secure entry. |
| 5218 | HostCache::Key cached_secure_key = |
| 5219 | HostCache::Key("secure", DnsQueryType::UNSPECIFIED, |
| 5220 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5221 | cached_secure_key.secure = true; |
| 5222 | IPEndPoint kExpectedSecureIP = CreateExpected("192.168.1.103", 80); |
| 5223 | PopulateCache(cached_secure_key, kExpectedSecureIP); |
| 5224 | |
| 5225 | // NONE query expected to complete synchronously with a cache hit from the |
| 5226 | // secure cache. |
| 5227 | ResolveHostResponseHelper response_cached(resolver_->CreateRequest( |
| 5228 | HostPortPair("secure", 80), NetLogWithSource(), base::nullopt, |
| 5229 | request_context_.get(), host_cache_.get())); |
| 5230 | EXPECT_TRUE(response_cached.complete()); |
| 5231 | EXPECT_THAT(response_cached.result_error(), IsOk()); |
| 5232 | EXPECT_THAT( |
| 5233 | response_cached.request()->GetAddressResults().value().endpoints(), |
| 5234 | testing::ElementsAre(kExpectedSecureIP)); |
| 5235 | } |
| 5236 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5237 | // Test the case where only a single transaction slot is available. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5238 | TEST_F(HostResolverManagerDnsTest, SerialResolver) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5239 | CreateSerialResolver(); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5240 | set_allow_fallback_to_proctask(false); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5241 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5242 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5243 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5244 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 5245 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5246 | EXPECT_FALSE(response.complete()); |
| 5247 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 5248 | |
| 5249 | base::RunLoop().RunUntilIdle(); |
| 5250 | EXPECT_TRUE(response.complete()); |
| 5251 | EXPECT_THAT(response.result_error(), IsOk()); |
| 5252 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 5253 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 5254 | CreateExpected("::1", 80))); |
| 5255 | } |
| 5256 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5257 | // Test the case where subsequent transactions are handled on transaction |
| 5258 | // completion when only part of a multi-transaction request could be initially |
| 5259 | // started. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5260 | TEST_F(HostResolverManagerDnsTest, AAAAStartsAfterOtherJobFinishes) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5261 | CreateResolverWithLimitsAndParams(3u, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5262 | true /* ipv6_reachable */, |
| 5263 | true /* check_ipv6_on_wifi */); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5264 | set_allow_fallback_to_proctask(false); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5265 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5266 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5267 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
| 5268 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 5269 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5270 | EXPECT_EQ(2u, num_running_dispatcher_jobs()); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5271 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
| 5272 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 5273 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5274 | EXPECT_EQ(3u, num_running_dispatcher_jobs()); |
| 5275 | |
| 5276 | // Request 0's transactions should complete, starting Request 1's second |
| 5277 | // transaction, which should also complete. |
| 5278 | base::RunLoop().RunUntilIdle(); |
| 5279 | EXPECT_EQ(1u, num_running_dispatcher_jobs()); |
| 5280 | EXPECT_TRUE(response0.complete()); |
| 5281 | EXPECT_FALSE(response1.complete()); |
| 5282 | |
| 5283 | dns_client_->CompleteDelayedTransactions(); |
| 5284 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 5285 | EXPECT_THAT(response1.request()->GetAddressResults().value().endpoints(), |
| 5286 | testing::UnorderedElementsAre(CreateExpected("127.0.0.1", 80), |
| 5287 | CreateExpected("::1", 80))); |
| 5288 | } |
| 5289 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5290 | // Tests the case that a Job with a single transaction receives an empty address |
| 5291 | // list, triggering fallback to ProcTask. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5292 | TEST_F(HostResolverManagerDnsTest, IPv4EmptyFallback) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5293 | // Disable ipv6 to ensure we'll only try a single transaction for the host. |
| 5294 | CreateResolverWithLimitsAndParams(kMaxJobs, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5295 | false /* ipv6_reachable */, |
| 5296 | true /* check_ipv6_on_wifi */); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5297 | DnsConfig config = CreateValidDnsConfig(); |
| 5298 | config.use_local_ipv6 = false; |
| 5299 | ChangeDnsConfig(config); |
| 5300 | |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 5301 | proc_->AddRuleForAllFamilies("empty_fallback", "192.168.0.1", |
| 5302 | HOST_RESOLVER_DEFAULT_FAMILY_SET_DUE_TO_NO_IPV6); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5303 | proc_->SignalMultiple(1u); |
| 5304 | |
| 5305 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5306 | HostPortPair("empty_fallback", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5307 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5308 | EXPECT_THAT(response.result_error(), IsOk()); |
| 5309 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 5310 | testing::ElementsAre(CreateExpected("192.168.0.1", 80))); |
| 5311 | } |
| 5312 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5313 | // Tests the case that a Job with two transactions receives two empty address |
| 5314 | // lists, triggering fallback to ProcTask. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5315 | TEST_F(HostResolverManagerDnsTest, UnspecEmptyFallback) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5316 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5317 | proc_->AddRuleForAllFamilies("empty_fallback", "192.168.0.1"); |
| 5318 | proc_->SignalMultiple(1u); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5319 | |
| 5320 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5321 | HostPortPair("empty_fallback", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5322 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5323 | |
| 5324 | EXPECT_THAT(response.result_error(), IsOk()); |
| 5325 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 5326 | testing::ElementsAre(CreateExpected("192.168.0.1", 80))); |
| 5327 | } |
| 5328 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5329 | // Tests getting a new invalid DnsConfig while there are active DnsTasks. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5330 | TEST_F(HostResolverManagerDnsTest, InvalidDnsConfigWithPendingRequests) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5331 | // At most 3 jobs active at once. This number is important, since we want |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5332 | // to make sure that aborting the first HostResolverManager::Job does not |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5333 | // trigger another DnsTransaction on the second Job when it releases its |
| 5334 | // second prioritized dispatcher slot. |
| 5335 | CreateResolverWithLimitsAndParams(3u, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5336 | true /* ipv6_reachable */, |
| 5337 | true /* check_ipv6_on_wifi */); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5338 | |
| 5339 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5340 | |
| 5341 | proc_->AddRuleForAllFamilies("slow_nx1", "192.168.0.1"); |
| 5342 | proc_->AddRuleForAllFamilies("slow_nx2", "192.168.0.2"); |
| 5343 | proc_->AddRuleForAllFamilies("ok", "192.168.0.3"); |
| 5344 | |
| 5345 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 5346 | // First active job gets two slots. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5347 | responses.emplace_back( |
| 5348 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 5349 | HostPortPair("slow_nx1", 80), NetLogWithSource(), base::nullopt, |
| 5350 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5351 | // Next job gets one slot, and waits on another. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5352 | responses.emplace_back( |
| 5353 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 5354 | HostPortPair("slow_nx2", 80), NetLogWithSource(), base::nullopt, |
| 5355 | request_context_.get(), host_cache_.get()))); |
| 5356 | responses.emplace_back( |
| 5357 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 5358 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 5359 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5360 | |
| 5361 | EXPECT_EQ(3u, num_running_dispatcher_jobs()); |
| 5362 | for (auto& response : responses) { |
| 5363 | EXPECT_FALSE(response->complete()); |
| 5364 | } |
| 5365 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5366 | // Clear DNS config. Fully in-progress, partially in-progress, and queued |
| 5367 | // requests should all be aborted. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5368 | ChangeDnsConfig(DnsConfig()); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5369 | for (auto& response : responses) { |
| 5370 | EXPECT_THAT(response->result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 5371 | } |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5372 | } |
| 5373 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5374 | // Test that initial DNS config read signals do not abort pending requests |
| 5375 | // when using DnsClient. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5376 | TEST_F(HostResolverManagerDnsTest, DontAbortOnInitialDNSConfigRead) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5377 | // DnsClient is enabled, but there's no DnsConfig, so the request should start |
| 5378 | // using ProcTask. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5379 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5380 | HostPortPair("host1", 70), NetLogWithSource(), base::nullopt, |
| 5381 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5382 | EXPECT_FALSE(response.complete()); |
| 5383 | |
| 5384 | EXPECT_TRUE(proc_->WaitFor(1u)); |
| 5385 | // Send the initial config read signal, with a valid config. |
| 5386 | SetInitialDnsConfig(CreateValidDnsConfig()); |
| 5387 | proc_->SignalAll(); |
| 5388 | |
| 5389 | EXPECT_THAT(response.result_error(), IsOk()); |
| 5390 | } |
| 5391 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5392 | // Tests the case that the insecure part of the DnsClient is automatically |
| 5393 | // disabled due to failures while there are active DnsTasks. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5394 | TEST_F(HostResolverManagerDnsTest, |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5395 | AutomaticallyDisableInsecureDnsClientWithPendingRequests) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5396 | // Trying different limits is important for this test: Different limits |
| 5397 | // result in different behavior when aborting in-progress DnsTasks. Having |
| 5398 | // a DnsTask that has one job active and one in the queue when another job |
| 5399 | // occupying two slots has its DnsTask aborted is the case most likely to run |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5400 | // into problems. Try limits between [1, 2 * # of non failure requests]. |
| 5401 | for (size_t limit = 1u; limit < 10u; ++limit) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5402 | CreateResolverWithLimitsAndParams(limit, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5403 | true /* ipv6_reachable */, |
| 5404 | true /* check_ipv6_on_wifi */); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5405 | |
| 5406 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5407 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5408 | // Queue up enough failures to disable insecure DnsTasks. These will all |
| 5409 | // fall back to ProcTasks, and succeed there. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5410 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> failure_responses; |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5411 | for (unsigned i = 0u; i < maximum_insecure_dns_task_failures(); ++i) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5412 | std::string host = base::StringPrintf("nx%u", i); |
| 5413 | proc_->AddRuleForAllFamilies(host, "192.168.0.1"); |
| 5414 | failure_responses.emplace_back( |
| 5415 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5416 | HostPortPair(host, 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5417 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5418 | EXPECT_FALSE(failure_responses[i]->complete()); |
| 5419 | } |
| 5420 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5421 | // These requests should all bypass insecure DnsTasks, due to the above |
| 5422 | // failures, so should end up using ProcTasks. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5423 | proc_->AddRuleForAllFamilies("slow_ok1", "192.168.0.2"); |
| 5424 | ResolveHostResponseHelper response0(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5425 | HostPortPair("slow_ok1", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5426 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5427 | EXPECT_FALSE(response0.complete()); |
| 5428 | proc_->AddRuleForAllFamilies("slow_ok2", "192.168.0.3"); |
| 5429 | ResolveHostResponseHelper response1(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5430 | HostPortPair("slow_ok2", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5431 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5432 | EXPECT_FALSE(response1.complete()); |
| 5433 | proc_->AddRuleForAllFamilies("slow_ok3", "192.168.0.4"); |
| 5434 | ResolveHostResponseHelper response2(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5435 | HostPortPair("slow_ok3", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5436 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5437 | EXPECT_FALSE(response2.complete()); |
| 5438 | |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5439 | // Requests specifying DNS source cannot fallback to ProcTask, so they |
| 5440 | // should be unaffected. |
| 5441 | HostResolver::ResolveHostParameters parameters; |
| 5442 | parameters.source = HostResolverSource::DNS; |
| 5443 | ResolveHostResponseHelper response_dns(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5444 | HostPortPair("4slow_ok", 80), NetLogWithSource(), parameters, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5445 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5446 | EXPECT_FALSE(response_dns.complete()); |
| 5447 | |
| 5448 | // Requests specifying SYSTEM source should be unaffected by disabling |
| 5449 | // DnsClient. |
| 5450 | proc_->AddRuleForAllFamilies("nx_ok", "192.168.0.5"); |
| 5451 | parameters.source = HostResolverSource::SYSTEM; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5452 | ResolveHostResponseHelper response_system(resolver_->CreateRequest( |
| 5453 | HostPortPair("nx_ok", 80), NetLogWithSource(), parameters, |
| 5454 | request_context_.get(), host_cache_.get())); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5455 | EXPECT_FALSE(response_system.complete()); |
| 5456 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5457 | // Secure DnsTasks should not be affected. |
| 5458 | HostResolver::ResolveHostParameters secure_parameters; |
| 5459 | secure_parameters.secure_dns_mode_override = |
| 5460 | DnsConfig::SecureDnsMode::AUTOMATIC; |
| 5461 | ResolveHostResponseHelper response_secure(resolver_->CreateRequest( |
| 5462 | HostPortPair("automatic", 80), NetLogWithSource(), secure_parameters, |
| 5463 | request_context_.get(), host_cache_.get())); |
| 5464 | EXPECT_FALSE(response_secure.complete()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5465 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5466 | proc_->SignalMultiple(maximum_insecure_dns_task_failures() + 6); |
| 5467 | |
| 5468 | for (size_t i = 0u; i < maximum_insecure_dns_task_failures(); ++i) { |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5469 | EXPECT_THAT(failure_responses[i]->result_error(), IsOk()); |
| 5470 | EXPECT_THAT(failure_responses[i] |
| 5471 | ->request() |
| 5472 | ->GetAddressResults() |
| 5473 | .value() |
| 5474 | .endpoints(), |
| 5475 | testing::ElementsAre(CreateExpected("192.168.0.1", 80))); |
| 5476 | } |
| 5477 | |
| 5478 | EXPECT_THAT(response0.result_error(), IsOk()); |
| 5479 | EXPECT_THAT(response0.request()->GetAddressResults().value().endpoints(), |
| 5480 | testing::ElementsAre(CreateExpected("192.168.0.2", 80))); |
| 5481 | EXPECT_THAT(response1.result_error(), IsOk()); |
| 5482 | EXPECT_THAT(response1.request()->GetAddressResults().value().endpoints(), |
| 5483 | testing::ElementsAre(CreateExpected("192.168.0.3", 80))); |
| 5484 | EXPECT_THAT(response2.result_error(), IsOk()); |
| 5485 | EXPECT_THAT(response2.request()->GetAddressResults().value().endpoints(), |
| 5486 | testing::ElementsAre(CreateExpected("192.168.0.4", 80))); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5487 | |
| 5488 | dns_client_->CompleteDelayedTransactions(); |
| 5489 | EXPECT_THAT(response_dns.result_error(), IsOk()); |
| 5490 | |
| 5491 | EXPECT_THAT(response_system.result_error(), IsOk()); |
| 5492 | EXPECT_THAT( |
| 5493 | response_system.request()->GetAddressResults().value().endpoints(), |
| 5494 | testing::ElementsAre(CreateExpected("192.168.0.5", 80))); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5495 | |
| 5496 | EXPECT_THAT(response_secure.result_error(), IsOk()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5497 | } |
| 5498 | } |
| 5499 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5500 | // Tests a call to SetDnsClient while there are active DnsTasks. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5501 | TEST_F(HostResolverManagerDnsTest, |
| 5502 | ManuallyDisableDnsClientWithPendingRequests) { |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5503 | // At most 3 jobs active at once. This number is important, since we want to |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5504 | // make sure that aborting the first HostResolverManager::Job does not trigger |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5505 | // another DnsTransaction on the second Job when it releases its second |
| 5506 | // prioritized dispatcher slot. |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5507 | CreateResolverWithLimitsAndParams(3u, DefaultParams(proc_.get()), |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5508 | true /* ipv6_reachable */, |
| 5509 | true /* check_ipv6_on_wifi */); |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5510 | |
[email protected] | daae132 | 2013-09-05 18:26:50 | [diff] [blame] | 5511 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5512 | |
| 5513 | proc_->AddRuleForAllFamilies("slow_ok1", "192.168.0.1"); |
| 5514 | proc_->AddRuleForAllFamilies("slow_ok2", "192.168.0.2"); |
| 5515 | proc_->AddRuleForAllFamilies("ok", "192.168.0.3"); |
| 5516 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5517 | std::vector<std::unique_ptr<ResolveHostResponseHelper>> responses; |
| 5518 | // First active job gets two slots. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5519 | responses.emplace_back( |
| 5520 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 5521 | HostPortPair("slow_ok1", 80), NetLogWithSource(), base::nullopt, |
| 5522 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5523 | EXPECT_FALSE(responses[0]->complete()); |
| 5524 | // Next job gets one slot, and waits on another. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5525 | responses.emplace_back( |
| 5526 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 5527 | HostPortPair("slow_ok2", 80), NetLogWithSource(), base::nullopt, |
| 5528 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5529 | EXPECT_FALSE(responses[1]->complete()); |
| 5530 | // Next one is queued. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5531 | responses.emplace_back( |
| 5532 | std::make_unique<ResolveHostResponseHelper>(resolver_->CreateRequest( |
| 5533 | HostPortPair("ok", 80), NetLogWithSource(), base::nullopt, |
| 5534 | request_context_.get(), host_cache_.get()))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5535 | EXPECT_FALSE(responses[2]->complete()); |
| 5536 | |
| 5537 | EXPECT_EQ(3u, num_running_dispatcher_jobs()); |
| 5538 | |
| 5539 | // Clear DnsClient. The two in-progress jobs should fall back to a ProcTask, |
| 5540 | // and the next one should be started with a ProcTask. |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5541 | resolver_->SetInsecureDnsClientEnabled(false); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5542 | |
| 5543 | // All three in-progress requests should now be running a ProcTask. |
| 5544 | EXPECT_EQ(3u, num_running_dispatcher_jobs()); |
| 5545 | proc_->SignalMultiple(3u); |
| 5546 | |
| 5547 | for (auto& response : responses) { |
| 5548 | EXPECT_THAT(response->result_error(), IsOk()); |
| 5549 | } |
| 5550 | EXPECT_THAT(responses[0]->request()->GetAddressResults().value().endpoints(), |
| 5551 | testing::ElementsAre(CreateExpected("192.168.0.1", 80))); |
| 5552 | EXPECT_THAT(responses[1]->request()->GetAddressResults().value().endpoints(), |
| 5553 | testing::ElementsAre(CreateExpected("192.168.0.2", 80))); |
| 5554 | EXPECT_THAT(responses[2]->request()->GetAddressResults().value().endpoints(), |
| 5555 | testing::ElementsAre(CreateExpected("192.168.0.3", 80))); |
| 5556 | } |
| 5557 | |
Eric Orth | 04aad98 | 2019-05-06 22:41:04 | [diff] [blame] | 5558 | // When explicitly requesting source=DNS, no fallback allowed, so doing so with |
| 5559 | // DnsClient disabled should result in an error. |
| 5560 | TEST_F(HostResolverManagerDnsTest, DnsCallsWithDisabledDnsClient) { |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 5561 | ChangeDnsConfig(CreateValidDnsConfig()); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5562 | resolver_->SetInsecureDnsClientEnabled(false); |
Eric Orth | 04aad98 | 2019-05-06 22:41:04 | [diff] [blame] | 5563 | |
| 5564 | HostResolver::ResolveHostParameters params; |
| 5565 | params.source = HostResolverSource::DNS; |
| 5566 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5567 | HostPortPair("host", 80), NetLogWithSource(), params, |
| 5568 | request_context_.get(), host_cache_.get())); |
| 5569 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5570 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
Eric Orth | 04aad98 | 2019-05-06 22:41:04 | [diff] [blame] | 5571 | } |
| 5572 | |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 5573 | TEST_F(HostResolverManagerDnsTest, |
| 5574 | DnsCallsWithDisabledDnsClient_DisabledAtConstruction) { |
| 5575 | HostResolver::ManagerOptions options = DefaultOptions(); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5576 | options.insecure_dns_client_enabled = false; |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 5577 | CreateResolverWithOptionsAndParams(std::move(options), |
| 5578 | DefaultParams(proc_.get()), |
| 5579 | true /* ipv6_reachable */); |
| 5580 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5581 | |
| 5582 | HostResolver::ResolveHostParameters params; |
| 5583 | params.source = HostResolverSource::DNS; |
| 5584 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5585 | HostPortPair("host", 80), NetLogWithSource(), params, |
| 5586 | request_context_.get(), host_cache_.get())); |
| 5587 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5588 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 5589 | } |
| 5590 | |
| 5591 | // Same as DnsClient disabled, requests with source=DNS and no usable DnsConfig |
| 5592 | // should result in an error. |
| 5593 | TEST_F(HostResolverManagerDnsTest, DnsCallsWithNoDnsConfig) { |
| 5594 | ChangeDnsConfig(DnsConfig()); |
| 5595 | |
| 5596 | HostResolver::ResolveHostParameters params; |
| 5597 | params.source = HostResolverSource::DNS; |
| 5598 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5599 | HostPortPair("host", 80), NetLogWithSource(), params, |
| 5600 | request_context_.get(), host_cache_.get())); |
| 5601 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 5602 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
Eric Orth | 4e55b36 | 2019-05-07 22:00:03 | [diff] [blame] | 5603 | } |
| 5604 | |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5605 | TEST_F(HostResolverManagerDnsTest, NoCheckIpv6OnWifi) { |
rch | ce64e673 | 2017-06-05 17:41:57 | [diff] [blame] | 5606 | // CreateSerialResolver will destroy the current resolver_ which will attempt |
| 5607 | // to remove itself from the NetworkChangeNotifier. If this happens after a |
| 5608 | // new NetworkChangeNotifier is active, then it will not remove itself from |
| 5609 | // the old NetworkChangeNotifier which is a potential use-after-free. |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 5610 | DestroyResolver(); |
mgersh | af9a923 | 2017-04-13 20:19:03 | [diff] [blame] | 5611 | test::ScopedMockNetworkChangeNotifier notifier; |
Eric Orth | 607b6d8 | 2019-05-08 16:43:32 | [diff] [blame] | 5612 | // Serial resolver to guarantee order of resolutions. |
| 5613 | CreateSerialResolver(false /* check_ipv6_on_wifi */); |
mgersh | af9a923 | 2017-04-13 20:19:03 | [diff] [blame] | 5614 | |
| 5615 | notifier.mock_network_change_notifier()->SetConnectionType( |
| 5616 | NetworkChangeNotifier::CONNECTION_WIFI); |
| 5617 | // Needed so IPv6 availability check isn't skipped. |
| 5618 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5619 | |
| 5620 | proc_->AddRule("h1", ADDRESS_FAMILY_UNSPECIFIED, "::3"); |
| 5621 | proc_->AddRule("h1", ADDRESS_FAMILY_IPV4, "1.0.0.1"); |
Eric Orth | 322af3e4 | 2018-08-20 18:12:59 | [diff] [blame] | 5622 | proc_->AddRule("h1", ADDRESS_FAMILY_IPV4, "1.0.0.1", |
| 5623 | HOST_RESOLVER_DEFAULT_FAMILY_SET_DUE_TO_NO_IPV6); |
mgersh | af9a923 | 2017-04-13 20:19:03 | [diff] [blame] | 5624 | proc_->AddRule("h1", ADDRESS_FAMILY_IPV6, "::2"); |
| 5625 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5626 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5627 | HostPortPair("h1", 80), NetLogWithSource(), base::nullopt, |
| 5628 | request_context_.get(), host_cache_.get())); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 5629 | HostResolver::ResolveHostParameters parameters; |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5630 | parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5631 | ResolveHostResponseHelper v4_response(resolver_->CreateRequest( |
| 5632 | HostPortPair("h1", 80), NetLogWithSource(), parameters, |
| 5633 | request_context_.get(), host_cache_.get())); |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5634 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5635 | ResolveHostResponseHelper v6_response(resolver_->CreateRequest( |
| 5636 | HostPortPair("h1", 80), NetLogWithSource(), parameters, |
| 5637 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5638 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 5639 | proc_->SignalMultiple(3u); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5640 | |
| 5641 | // Should revert to only IPV4 request. |
| 5642 | EXPECT_THAT(response.result_error(), IsOk()); |
| 5643 | EXPECT_THAT(response.request()->GetAddressResults().value().endpoints(), |
| 5644 | testing::ElementsAre(CreateExpected("1.0.0.1", 80))); |
| 5645 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 5646 | EXPECT_THAT(v4_response.result_error(), IsOk()); |
| 5647 | EXPECT_THAT(v4_response.request()->GetAddressResults().value().endpoints(), |
| 5648 | testing::ElementsAre(CreateExpected("1.0.0.1", 80))); |
| 5649 | EXPECT_THAT(v6_response.result_error(), IsOk()); |
| 5650 | EXPECT_THAT(v6_response.request()->GetAddressResults().value().endpoints(), |
| 5651 | testing::ElementsAre(CreateExpected("::2", 80))); |
| 5652 | |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5653 | // Now repeat the test on non-wifi to check that IPv6 is used as normal |
| 5654 | // after the network changes. |
| 5655 | notifier.mock_network_change_notifier()->SetConnectionType( |
| 5656 | NetworkChangeNotifier::CONNECTION_4G); |
| 5657 | base::RunLoop().RunUntilIdle(); // Wait for NetworkChangeNotifier. |
| 5658 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5659 | ResolveHostResponseHelper no_wifi_response(resolver_->CreateRequest( |
| 5660 | HostPortPair("h1", 80), NetLogWithSource(), base::nullopt, |
| 5661 | request_context_.get(), host_cache_.get())); |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5662 | parameters.dns_query_type = DnsQueryType::A; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5663 | ResolveHostResponseHelper no_wifi_v4_response(resolver_->CreateRequest( |
| 5664 | HostPortPair("h1", 80), NetLogWithSource(), parameters, |
| 5665 | request_context_.get(), host_cache_.get())); |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5666 | parameters.dns_query_type = DnsQueryType::AAAA; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5667 | ResolveHostResponseHelper no_wifi_v6_response(resolver_->CreateRequest( |
| 5668 | HostPortPair("h1", 80), NetLogWithSource(), parameters, |
| 5669 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5670 | |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 5671 | proc_->SignalMultiple(3u); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5672 | |
| 5673 | // IPV6 should be available. |
| 5674 | EXPECT_THAT(no_wifi_response.result_error(), IsOk()); |
| 5675 | EXPECT_THAT( |
| 5676 | no_wifi_response.request()->GetAddressResults().value().endpoints(), |
| 5677 | testing::ElementsAre(CreateExpected("::3", 80))); |
Eric Orth | 00fe5a6 | 2018-08-15 22:20:00 | [diff] [blame] | 5678 | |
| 5679 | EXPECT_THAT(no_wifi_v4_response.result_error(), IsOk()); |
| 5680 | EXPECT_THAT( |
| 5681 | no_wifi_v4_response.request()->GetAddressResults().value().endpoints(), |
| 5682 | testing::ElementsAre(CreateExpected("1.0.0.1", 80))); |
| 5683 | EXPECT_THAT(no_wifi_v6_response.result_error(), IsOk()); |
| 5684 | EXPECT_THAT( |
| 5685 | no_wifi_v6_response.request()->GetAddressResults().value().endpoints(), |
| 5686 | testing::ElementsAre(CreateExpected("::2", 80))); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5687 | } |
| 5688 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5689 | TEST_F(HostResolverManagerDnsTest, NotFoundTTL) { |
Brad Lassey | 2e8f185d | 2018-05-21 22:25:21 | [diff] [blame] | 5690 | CreateResolver(); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5691 | set_allow_fallback_to_proctask(false); |
Brad Lassey | 2e8f185d | 2018-05-21 22:25:21 | [diff] [blame] | 5692 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5693 | |
| 5694 | // NODATA |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5695 | ResolveHostResponseHelper no_data_response(resolver_->CreateRequest( |
| 5696 | HostPortPair("empty", 80), NetLogWithSource(), base::nullopt, |
| 5697 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5698 | EXPECT_THAT(no_data_response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 5699 | EXPECT_FALSE(no_data_response.request()->GetAddressResults()); |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5700 | HostCache::Key key("empty", DnsQueryType::UNSPECIFIED, 0, |
| 5701 | HostResolverSource::ANY); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5702 | HostCache::EntryStaleness staleness; |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5703 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result = |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 5704 | host_cache_->Lookup(key, base::TimeTicks::Now(), |
| 5705 | false /* ignore_secure */); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5706 | EXPECT_TRUE(!!cache_result); |
| 5707 | EXPECT_TRUE(cache_result->second.has_ttl()); |
| 5708 | EXPECT_THAT(cache_result->second.ttl(), base::TimeDelta::FromSeconds(86400)); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5709 | |
| 5710 | // NXDOMAIN |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5711 | ResolveHostResponseHelper no_domain_response(resolver_->CreateRequest( |
| 5712 | HostPortPair("nodomain", 80), NetLogWithSource(), base::nullopt, |
| 5713 | request_context_.get(), host_cache_.get())); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5714 | EXPECT_THAT(no_domain_response.result_error(), |
| 5715 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 5716 | EXPECT_FALSE(no_domain_response.request()->GetAddressResults()); |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5717 | HostCache::Key nxkey("nodomain", DnsQueryType::UNSPECIFIED, 0, |
| 5718 | HostResolverSource::ANY); |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 5719 | cache_result = host_cache_->Lookup(nxkey, base::TimeTicks::Now(), |
| 5720 | false /* ignore_secure */); |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5721 | EXPECT_TRUE(!!cache_result); |
| 5722 | EXPECT_TRUE(cache_result->second.has_ttl()); |
| 5723 | EXPECT_THAT(cache_result->second.ttl(), base::TimeDelta::FromSeconds(86400)); |
Eric Orth | 7099298 | 2018-07-24 00:25:00 | [diff] [blame] | 5724 | } |
| 5725 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5726 | TEST_F(HostResolverManagerDnsTest, CachedError) { |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5727 | proc_->AddRuleForAllFamilies(std::string(), |
| 5728 | "0.0.0.0"); // Default to failures. |
| 5729 | proc_->SignalMultiple(1u); |
| 5730 | |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 5731 | CreateResolver(); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5732 | set_allow_fallback_to_proctask(true); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 5733 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5734 | |
| 5735 | HostResolver::ResolveHostParameters cache_only_parameters; |
| 5736 | cache_only_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 5737 | |
| 5738 | // Expect cache initially empty. |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5739 | ResolveHostResponseHelper cache_miss_response0(resolver_->CreateRequest( |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5740 | HostPortPair("nodomain", 80), NetLogWithSource(), cache_only_parameters, |
| 5741 | request_context_.get(), host_cache_.get())); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5742 | EXPECT_THAT(cache_miss_response0.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 5743 | EXPECT_FALSE(cache_miss_response0.request()->GetStaleInfo()); |
| 5744 | |
| 5745 | // The cache should not be populate with an error because fallback to ProcTask |
| 5746 | // was available. |
| 5747 | ResolveHostResponseHelper no_domain_response_with_fallback( |
| 5748 | resolver_->CreateRequest(HostPortPair("nodomain", 80), NetLogWithSource(), |
| 5749 | base::nullopt, request_context_.get(), |
| 5750 | host_cache_.get())); |
| 5751 | EXPECT_THAT(no_domain_response_with_fallback.result_error(), |
| 5752 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 5753 | |
| 5754 | // Expect cache still empty. |
| 5755 | ResolveHostResponseHelper cache_miss_response1(resolver_->CreateRequest( |
| 5756 | HostPortPair("nodomain", 80), NetLogWithSource(), cache_only_parameters, |
| 5757 | request_context_.get(), host_cache_.get())); |
| 5758 | EXPECT_THAT(cache_miss_response1.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 5759 | EXPECT_FALSE(cache_miss_response1.request()->GetStaleInfo()); |
| 5760 | |
| 5761 | // Disable fallback to proctask |
| 5762 | set_allow_fallback_to_proctask(false); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 5763 | |
| 5764 | // Populate cache with an error. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5765 | ResolveHostResponseHelper no_domain_response(resolver_->CreateRequest( |
| 5766 | HostPortPair("nodomain", 80), NetLogWithSource(), base::nullopt, |
| 5767 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 5768 | EXPECT_THAT(no_domain_response.result_error(), |
| 5769 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 5770 | |
| 5771 | // Expect the error result can be resolved from the cache. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5772 | ResolveHostResponseHelper cache_hit_response(resolver_->CreateRequest( |
| 5773 | HostPortPair("nodomain", 80), NetLogWithSource(), cache_only_parameters, |
| 5774 | request_context_.get(), host_cache_.get())); |
Eric Orth | eb33286 | 2019-01-26 00:52:38 | [diff] [blame] | 5775 | EXPECT_THAT(cache_hit_response.result_error(), |
| 5776 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 5777 | EXPECT_FALSE(cache_hit_response.request()->GetStaleInfo().value().is_stale()); |
| 5778 | } |
| 5779 | |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 5780 | TEST_F(HostResolverManagerDnsTest, CachedError_AutomaticMode) { |
| 5781 | CreateResolver(); |
| 5782 | set_allow_fallback_to_proctask(false); |
| 5783 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5784 | |
| 5785 | // Switch to automatic mode. |
| 5786 | DnsConfigOverrides overrides; |
| 5787 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
| 5788 | resolver_->SetDnsConfigOverrides(overrides); |
| 5789 | |
| 5790 | HostCache::Key insecure_key = |
| 5791 | HostCache::Key("automatic_nodomain", DnsQueryType::UNSPECIFIED, |
| 5792 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5793 | HostCache::Key secure_key = |
| 5794 | HostCache::Key("automatic_nodomain", DnsQueryType::UNSPECIFIED, |
| 5795 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5796 | secure_key.secure = true; |
| 5797 | |
| 5798 | // Expect cache initially empty. |
| 5799 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 5800 | cache_result = GetCacheHit(secure_key); |
| 5801 | EXPECT_FALSE(!!cache_result); |
| 5802 | cache_result = GetCacheHit(insecure_key); |
| 5803 | EXPECT_FALSE(!!cache_result); |
| 5804 | |
| 5805 | // Populate both secure and insecure caches with an error. |
| 5806 | ResolveHostResponseHelper no_domain_response(resolver_->CreateRequest( |
| 5807 | HostPortPair("automatic_nodomain", 80), NetLogWithSource(), base::nullopt, |
| 5808 | request_context_.get(), host_cache_.get())); |
| 5809 | EXPECT_THAT(no_domain_response.result_error(), |
| 5810 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 5811 | |
| 5812 | // Expect both secure and insecure caches to have the error result. |
| 5813 | cache_result = GetCacheHit(secure_key); |
| 5814 | EXPECT_TRUE(!!cache_result); |
| 5815 | cache_result = GetCacheHit(insecure_key); |
| 5816 | EXPECT_TRUE(!!cache_result); |
| 5817 | } |
| 5818 | |
| 5819 | TEST_F(HostResolverManagerDnsTest, CachedError_SecureMode) { |
| 5820 | CreateResolver(); |
| 5821 | set_allow_fallback_to_proctask(false); |
| 5822 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5823 | |
| 5824 | // Switch to secure mode. |
| 5825 | DnsConfigOverrides overrides; |
| 5826 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::SECURE; |
| 5827 | resolver_->SetDnsConfigOverrides(overrides); |
| 5828 | |
| 5829 | HostCache::Key insecure_key = |
| 5830 | HostCache::Key("automatic_nodomain", DnsQueryType::UNSPECIFIED, |
| 5831 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5832 | HostCache::Key secure_key = |
| 5833 | HostCache::Key("automatic_nodomain", DnsQueryType::UNSPECIFIED, |
| 5834 | 0 /* host_resolver_flags */, HostResolverSource::ANY); |
| 5835 | secure_key.secure = true; |
| 5836 | |
| 5837 | // Expect cache initially empty. |
| 5838 | const std::pair<const HostCache::Key, HostCache::Entry>* cache_result; |
| 5839 | cache_result = GetCacheHit(secure_key); |
| 5840 | EXPECT_FALSE(!!cache_result); |
| 5841 | cache_result = GetCacheHit(insecure_key); |
| 5842 | EXPECT_FALSE(!!cache_result); |
| 5843 | |
| 5844 | // Populate secure cache with an error. |
| 5845 | ResolveHostResponseHelper no_domain_response(resolver_->CreateRequest( |
| 5846 | HostPortPair("automatic_nodomain", 80), NetLogWithSource(), base::nullopt, |
| 5847 | request_context_.get(), host_cache_.get())); |
| 5848 | EXPECT_THAT(no_domain_response.result_error(), |
| 5849 | IsError(ERR_NAME_NOT_RESOLVED)); |
| 5850 | |
| 5851 | // Expect only the secure cache to have the error result. |
| 5852 | cache_result = GetCacheHit(secure_key); |
| 5853 | EXPECT_TRUE(!!cache_result); |
| 5854 | cache_result = GetCacheHit(insecure_key); |
| 5855 | EXPECT_FALSE(!!cache_result); |
| 5856 | } |
| 5857 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5858 | TEST_F(HostResolverManagerDnsTest, NoCanonicalName) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5859 | MockDnsClientRuleList rules; |
| 5860 | AddDnsRule(&rules, "alias", dns_protocol::kTypeA, IPAddress::IPv4Localhost(), |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5861 | "canonical", false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5862 | AddDnsRule(&rules, "alias", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5863 | IPAddress::IPv6Localhost(), "canonical", false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5864 | |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5865 | CreateResolver(); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5866 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5867 | set_allow_fallback_to_proctask(false); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5868 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5869 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5870 | HostPortPair("alias", 80), NetLogWithSource(), base::nullopt, |
| 5871 | request_context_.get(), host_cache_.get())); |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5872 | ASSERT_THAT(response.result_error(), IsOk()); |
| 5873 | |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 5874 | // HostResolver may still give name, but if so, it must be correct. |
| 5875 | std::string result_name = |
| 5876 | response.request()->GetAddressResults().value().canonical_name(); |
| 5877 | EXPECT_TRUE(result_name.empty() || result_name == "canonical"); |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5878 | } |
| 5879 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5880 | TEST_F(HostResolverManagerDnsTest, CanonicalName) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5881 | MockDnsClientRuleList rules; |
| 5882 | AddDnsRule(&rules, "alias", dns_protocol::kTypeA, IPAddress::IPv4Localhost(), |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5883 | "canonical", false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5884 | AddDnsRule(&rules, "alias", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5885 | IPAddress::IPv6Localhost(), "canonical", false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5886 | |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5887 | CreateResolver(); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5888 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5889 | set_allow_fallback_to_proctask(false); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5890 | |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5891 | HostResolver::ResolveHostParameters params; |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5892 | params.include_canonical_name = true; |
Eric Orth | 541a90c | 2019-01-17 20:11:46 | [diff] [blame] | 5893 | params.source = HostResolverSource::DNS; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5894 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5895 | HostPortPair("alias", 80), NetLogWithSource(), params, |
| 5896 | request_context_.get(), host_cache_.get())); |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5897 | ASSERT_THAT(response.result_error(), IsOk()); |
| 5898 | |
| 5899 | EXPECT_EQ(response.request()->GetAddressResults().value().canonical_name(), |
| 5900 | "canonical"); |
| 5901 | } |
| 5902 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5903 | TEST_F(HostResolverManagerDnsTest, CanonicalName_PreferV6) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5904 | MockDnsClientRuleList rules; |
| 5905 | AddDnsRule(&rules, "alias", dns_protocol::kTypeA, IPAddress::IPv4Localhost(), |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5906 | "wrong", false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5907 | AddDnsRule(&rules, "alias", dns_protocol::kTypeAAAA, |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5908 | IPAddress::IPv6Localhost(), "correct", true /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5909 | |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5910 | CreateResolver(); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5911 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5912 | set_allow_fallback_to_proctask(false); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5913 | |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5914 | HostResolver::ResolveHostParameters params; |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5915 | params.include_canonical_name = true; |
Eric Orth | 541a90c | 2019-01-17 20:11:46 | [diff] [blame] | 5916 | params.source = HostResolverSource::DNS; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5917 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5918 | HostPortPair("alias", 80), NetLogWithSource(), params, |
| 5919 | request_context_.get(), host_cache_.get())); |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5920 | ASSERT_FALSE(response.complete()); |
| 5921 | base::RunLoop().RunUntilIdle(); |
| 5922 | dns_client_->CompleteDelayedTransactions(); |
| 5923 | ASSERT_THAT(response.result_error(), IsOk()); |
| 5924 | EXPECT_EQ(response.request()->GetAddressResults().value().canonical_name(), |
| 5925 | "correct"); |
| 5926 | } |
| 5927 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5928 | TEST_F(HostResolverManagerDnsTest, CanonicalName_V4Only) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5929 | MockDnsClientRuleList rules; |
| 5930 | AddDnsRule(&rules, "alias", dns_protocol::kTypeA, IPAddress::IPv4Localhost(), |
dalyk | 48b20a99 | 2019-02-25 16:10:26 | [diff] [blame] | 5931 | "correct", false /* delay */); |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5932 | CreateResolver(); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5933 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
Eric Orth | 6093174 | 2018-11-05 23:40:57 | [diff] [blame] | 5934 | set_allow_fallback_to_proctask(false); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 5935 | |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5936 | HostResolver::ResolveHostParameters params; |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 5937 | params.dns_query_type = DnsQueryType::A; |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5938 | params.include_canonical_name = true; |
Eric Orth | 541a90c | 2019-01-17 20:11:46 | [diff] [blame] | 5939 | params.source = HostResolverSource::DNS; |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5940 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 5941 | HostPortPair("alias", 80), NetLogWithSource(), params, |
| 5942 | request_context_.get(), host_cache_.get())); |
Asanka Herath | 2d0226c | 2018-10-24 14:35:55 | [diff] [blame] | 5943 | ASSERT_THAT(response.result_error(), IsOk()); |
| 5944 | EXPECT_EQ(response.request()->GetAddressResults().value().canonical_name(), |
| 5945 | "correct"); |
| 5946 | } |
| 5947 | |
Eric Orth | 541a90c | 2019-01-17 20:11:46 | [diff] [blame] | 5948 | // Test that without specifying source, a request that would otherwise be |
| 5949 | // handled by DNS is sent to the system resolver if cannonname is requested. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5950 | TEST_F(HostResolverManagerDnsTest, CanonicalNameForcesProc) { |
Eric Orth | 541a90c | 2019-01-17 20:11:46 | [diff] [blame] | 5951 | // Disable fallback to ensure system resolver is used directly, not via |
| 5952 | // fallback. |
| 5953 | set_allow_fallback_to_proctask(false); |
| 5954 | |
| 5955 | proc_->AddRuleForAllFamilies("nx_succeed", "192.168.1.102", |
| 5956 | HOST_RESOLVER_CANONNAME, "canonical"); |
| 5957 | proc_->SignalMultiple(1u); |
| 5958 | |
| 5959 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 5960 | |
| 5961 | HostResolver::ResolveHostParameters params; |
| 5962 | params.include_canonical_name = true; |
| 5963 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 5964 | HostPortPair("nx_succeed", 80), NetLogWithSource(), params, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 5965 | request_context_.get(), host_cache_.get())); |
Eric Orth | 541a90c | 2019-01-17 20:11:46 | [diff] [blame] | 5966 | ASSERT_THAT(response.result_error(), IsOk()); |
| 5967 | |
| 5968 | EXPECT_EQ(response.request()->GetAddressResults().value().canonical_name(), |
| 5969 | "canonical"); |
| 5970 | } |
| 5971 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 5972 | TEST_F(HostResolverManagerTest, ResolveLocalHostname) { |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 5973 | AddressList addresses; |
| 5974 | |
| 5975 | TestBothLoopbackIPs("localhost"); |
| 5976 | TestBothLoopbackIPs("localhoST"); |
| 5977 | TestBothLoopbackIPs("localhost."); |
| 5978 | TestBothLoopbackIPs("localhoST."); |
| 5979 | TestBothLoopbackIPs("localhost.localdomain"); |
| 5980 | TestBothLoopbackIPs("localhost.localdomAIn"); |
| 5981 | TestBothLoopbackIPs("localhost.localdomain."); |
| 5982 | TestBothLoopbackIPs("localhost.localdomAIn."); |
| 5983 | TestBothLoopbackIPs("foo.localhost"); |
| 5984 | TestBothLoopbackIPs("foo.localhOSt"); |
| 5985 | TestBothLoopbackIPs("foo.localhost."); |
| 5986 | TestBothLoopbackIPs("foo.localhOSt."); |
| 5987 | |
| 5988 | TestIPv6LoopbackOnly("localhost6"); |
| 5989 | TestIPv6LoopbackOnly("localhoST6"); |
| 5990 | TestIPv6LoopbackOnly("localhost6."); |
| 5991 | TestIPv6LoopbackOnly("localhost6.localdomain6"); |
| 5992 | TestIPv6LoopbackOnly("localhost6.localdomain6."); |
| 5993 | |
Matt Menke | c35d163 | 2018-11-29 12:43:49 | [diff] [blame] | 5994 | EXPECT_FALSE(ResolveLocalHostname("127.0.0.1", &addresses)); |
| 5995 | EXPECT_FALSE(ResolveLocalHostname("::1", &addresses)); |
| 5996 | EXPECT_FALSE(ResolveLocalHostname("0:0:0:0:0:0:0:1", &addresses)); |
| 5997 | EXPECT_FALSE(ResolveLocalHostname("localhostx", &addresses)); |
| 5998 | EXPECT_FALSE(ResolveLocalHostname("localhost.x", &addresses)); |
| 5999 | EXPECT_FALSE(ResolveLocalHostname("foo.localdomain", &addresses)); |
| 6000 | EXPECT_FALSE(ResolveLocalHostname("foo.localdomain.x", &addresses)); |
| 6001 | EXPECT_FALSE(ResolveLocalHostname("localhost6x", &addresses)); |
| 6002 | EXPECT_FALSE(ResolveLocalHostname("localhost.localdomain6", &addresses)); |
| 6003 | EXPECT_FALSE(ResolveLocalHostname("localhost6.localdomain", &addresses)); |
| 6004 | EXPECT_FALSE(ResolveLocalHostname("127.0.0.1.1", &addresses)); |
| 6005 | EXPECT_FALSE(ResolveLocalHostname(".127.0.0.255", &addresses)); |
| 6006 | EXPECT_FALSE(ResolveLocalHostname("::2", &addresses)); |
| 6007 | EXPECT_FALSE(ResolveLocalHostname("::1:1", &addresses)); |
| 6008 | EXPECT_FALSE(ResolveLocalHostname("0:0:0:0:1:0:0:1", &addresses)); |
| 6009 | EXPECT_FALSE(ResolveLocalHostname("::1:1", &addresses)); |
| 6010 | EXPECT_FALSE(ResolveLocalHostname("0:0:0:0:0:0:0:0:1", &addresses)); |
| 6011 | EXPECT_FALSE(ResolveLocalHostname("foo.localhost.com", &addresses)); |
| 6012 | EXPECT_FALSE(ResolveLocalHostname("foo.localhoste", &addresses)); |
tfarina | 9ed7f8c5 | 2016-02-19 17:50:18 | [diff] [blame] | 6013 | } |
| 6014 | |
dalyk | 40dcab15 | 2019-03-15 21:03:15 | [diff] [blame] | 6015 | TEST_F(HostResolverManagerDnsTest, ResolveDnsOverHttpsServerName) { |
| 6016 | MockDnsClientRuleList rules; |
| 6017 | rules.emplace_back( |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6018 | "dns.example2.com", dns_protocol::kTypeA, false /* secure */, |
dalyk | 40dcab15 | 2019-03-15 21:03:15 | [diff] [blame] | 6019 | MockDnsClientRule::Result(MockDnsClientRule::OK), false /* delay */); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6020 | rules.emplace_back( |
| 6021 | "dns.example2.com", dns_protocol::kTypeAAAA, false /* secure */, |
| 6022 | MockDnsClientRule::Result(MockDnsClientRule::OK), false /* delay */); |
dalyk | 40dcab15 | 2019-03-15 21:03:15 | [diff] [blame] | 6023 | CreateResolver(); |
| 6024 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6025 | |
| 6026 | DnsConfigOverrides overrides; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6027 | std::vector<DnsConfig::DnsOverHttpsServerConfig> doh_servers = { |
| 6028 | DnsConfig::DnsOverHttpsServerConfig("https://dns.example.com/", |
| 6029 | true /* use_post */), |
| 6030 | DnsConfig::DnsOverHttpsServerConfig( |
| 6031 | "https://dns.example2.com/dns-query{?dns}", false /* use_post */)}; |
| 6032 | overrides.dns_over_https_servers = doh_servers; |
| 6033 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::SECURE; |
dalyk | 40dcab15 | 2019-03-15 21:03:15 | [diff] [blame] | 6034 | resolver_->SetDnsConfigOverrides(overrides); |
| 6035 | |
| 6036 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
Eric Orth | 6f1c517 | 2019-04-16 17:08:27 | [diff] [blame] | 6037 | HostPortPair("dns.example2.com", 80), NetLogWithSource(), base::nullopt, |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6038 | request_context_.get(), host_cache_.get())); |
dalyk | 40dcab15 | 2019-03-15 21:03:15 | [diff] [blame] | 6039 | ASSERT_THAT(response.result_error(), IsOk()); |
| 6040 | } |
| 6041 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6042 | TEST_F(HostResolverManagerDnsTest, AddDnsOverHttpsServerAfterConfig) { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 6043 | DestroyResolver(); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6044 | test::ScopedMockNetworkChangeNotifier notifier; |
| 6045 | CreateSerialResolver(); // To guarantee order of resolutions. |
| 6046 | notifier.mock_network_change_notifier()->SetConnectionType( |
| 6047 | NetworkChangeNotifier::CONNECTION_WIFI); |
| 6048 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6049 | |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6050 | std::string server("https://dnsserver.example.net/dns-query{?dns}"); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6051 | DnsConfigOverrides overrides; |
| 6052 | overrides.dns_over_https_servers.emplace( |
| 6053 | {DnsConfig::DnsOverHttpsServerConfig(server, true)}); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6054 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6055 | resolver_->SetDnsConfigOverrides(overrides); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6056 | base::DictionaryValue* config; |
| 6057 | |
| 6058 | auto value = resolver_->GetDnsConfigAsValue(); |
| 6059 | EXPECT_TRUE(value); |
| 6060 | if (!value) |
| 6061 | return; |
| 6062 | value->GetAsDictionary(&config); |
| 6063 | base::ListValue* doh_servers; |
| 6064 | config->GetListWithoutPathExpansion("doh_servers", &doh_servers); |
| 6065 | EXPECT_TRUE(doh_servers); |
| 6066 | if (!doh_servers) |
| 6067 | return; |
| 6068 | EXPECT_EQ(doh_servers->GetSize(), 1u); |
| 6069 | base::DictionaryValue* server_method; |
| 6070 | EXPECT_TRUE(doh_servers->GetDictionary(0, &server_method)); |
| 6071 | bool use_post; |
| 6072 | EXPECT_TRUE(server_method->GetBoolean("use_post", &use_post)); |
| 6073 | EXPECT_TRUE(use_post); |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6074 | std::string server_template; |
| 6075 | EXPECT_TRUE(server_method->GetString("server_template", &server_template)); |
| 6076 | EXPECT_EQ(server_template, server); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6077 | EXPECT_EQ(config->FindKey("secure_dns_mode")->GetInt(), |
| 6078 | static_cast<int>(DnsConfig::SecureDnsMode::AUTOMATIC)); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6079 | } |
| 6080 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6081 | TEST_F(HostResolverManagerDnsTest, AddDnsOverHttpsServerBeforeConfig) { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 6082 | DestroyResolver(); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6083 | test::ScopedMockNetworkChangeNotifier notifier; |
| 6084 | CreateSerialResolver(); // To guarantee order of resolutions. |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6085 | std::string server("https://dnsserver.example.net/dns-query{?dns}"); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6086 | DnsConfigOverrides overrides; |
| 6087 | overrides.dns_over_https_servers.emplace( |
| 6088 | {DnsConfig::DnsOverHttpsServerConfig(server, true)}); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6089 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6090 | resolver_->SetDnsConfigOverrides(overrides); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6091 | |
| 6092 | notifier.mock_network_change_notifier()->SetConnectionType( |
| 6093 | NetworkChangeNotifier::CONNECTION_WIFI); |
| 6094 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6095 | |
| 6096 | base::DictionaryValue* config; |
| 6097 | auto value = resolver_->GetDnsConfigAsValue(); |
| 6098 | EXPECT_TRUE(value); |
| 6099 | if (!value) |
| 6100 | return; |
| 6101 | value->GetAsDictionary(&config); |
| 6102 | base::ListValue* doh_servers; |
| 6103 | config->GetListWithoutPathExpansion("doh_servers", &doh_servers); |
| 6104 | EXPECT_TRUE(doh_servers); |
| 6105 | if (!doh_servers) |
| 6106 | return; |
| 6107 | EXPECT_EQ(doh_servers->GetSize(), 1u); |
| 6108 | base::DictionaryValue* server_method; |
| 6109 | EXPECT_TRUE(doh_servers->GetDictionary(0, &server_method)); |
| 6110 | bool use_post; |
| 6111 | EXPECT_TRUE(server_method->GetBoolean("use_post", &use_post)); |
| 6112 | EXPECT_TRUE(use_post); |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6113 | std::string server_template; |
| 6114 | EXPECT_TRUE(server_method->GetString("server_template", &server_template)); |
| 6115 | EXPECT_EQ(server_template, server); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6116 | EXPECT_EQ(config->FindKey("secure_dns_mode")->GetInt(), |
| 6117 | static_cast<int>(DnsConfig::SecureDnsMode::AUTOMATIC)); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6118 | } |
| 6119 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6120 | TEST_F(HostResolverManagerDnsTest, AddDnsOverHttpsServerBeforeClient) { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 6121 | DestroyResolver(); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6122 | test::ScopedMockNetworkChangeNotifier notifier; |
| 6123 | CreateSerialResolver(); // To guarantee order of resolutions. |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6124 | std::string server("https://dnsserver.example.net/dns-query{?dns}"); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6125 | DnsConfigOverrides overrides; |
| 6126 | overrides.dns_over_https_servers.emplace( |
| 6127 | {DnsConfig::DnsOverHttpsServerConfig(server, true)}); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6128 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6129 | resolver_->SetDnsConfigOverrides(overrides); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6130 | |
| 6131 | notifier.mock_network_change_notifier()->SetConnectionType( |
| 6132 | NetworkChangeNotifier::CONNECTION_WIFI); |
| 6133 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6134 | |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6135 | base::DictionaryValue* config; |
| 6136 | auto value = resolver_->GetDnsConfigAsValue(); |
| 6137 | EXPECT_TRUE(value); |
| 6138 | if (!value) |
| 6139 | return; |
| 6140 | value->GetAsDictionary(&config); |
| 6141 | base::ListValue* doh_servers; |
| 6142 | config->GetListWithoutPathExpansion("doh_servers", &doh_servers); |
| 6143 | EXPECT_TRUE(doh_servers); |
| 6144 | if (!doh_servers) |
| 6145 | return; |
| 6146 | EXPECT_EQ(doh_servers->GetSize(), 1u); |
| 6147 | base::DictionaryValue* server_method; |
| 6148 | EXPECT_TRUE(doh_servers->GetDictionary(0, &server_method)); |
| 6149 | bool use_post; |
| 6150 | EXPECT_TRUE(server_method->GetBoolean("use_post", &use_post)); |
| 6151 | EXPECT_TRUE(use_post); |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6152 | std::string server_template; |
| 6153 | EXPECT_TRUE(server_method->GetString("server_template", &server_template)); |
| 6154 | EXPECT_EQ(server_template, server); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6155 | EXPECT_EQ(config->FindKey("secure_dns_mode")->GetInt(), |
| 6156 | static_cast<int>(DnsConfig::SecureDnsMode::AUTOMATIC)); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6157 | } |
| 6158 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6159 | TEST_F(HostResolverManagerDnsTest, AddDnsOverHttpsServerAndThenRemove) { |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 6160 | DestroyResolver(); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6161 | test::ScopedMockNetworkChangeNotifier notifier; |
| 6162 | CreateSerialResolver(); // To guarantee order of resolutions. |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6163 | std::string server("https://dns.example.com/"); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6164 | DnsConfigOverrides overrides; |
| 6165 | overrides.dns_over_https_servers.emplace( |
| 6166 | {DnsConfig::DnsOverHttpsServerConfig(server, true)}); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6167 | overrides.secure_dns_mode = DnsConfig::SecureDnsMode::AUTOMATIC; |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6168 | resolver_->SetDnsConfigOverrides(overrides); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6169 | |
| 6170 | notifier.mock_network_change_notifier()->SetConnectionType( |
| 6171 | NetworkChangeNotifier::CONNECTION_WIFI); |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6172 | DnsConfig network_dns_config = CreateValidDnsConfig(); |
| 6173 | network_dns_config.dns_over_https_servers.clear(); |
| 6174 | ChangeDnsConfig(network_dns_config); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6175 | |
| 6176 | base::DictionaryValue* config; |
| 6177 | auto value = resolver_->GetDnsConfigAsValue(); |
| 6178 | EXPECT_TRUE(value); |
| 6179 | if (!value) |
| 6180 | return; |
| 6181 | value->GetAsDictionary(&config); |
| 6182 | base::ListValue* doh_servers; |
| 6183 | config->GetListWithoutPathExpansion("doh_servers", &doh_servers); |
| 6184 | EXPECT_TRUE(doh_servers); |
| 6185 | if (!doh_servers) |
| 6186 | return; |
| 6187 | EXPECT_EQ(doh_servers->GetSize(), 1u); |
| 6188 | base::DictionaryValue* server_method; |
| 6189 | EXPECT_TRUE(doh_servers->GetDictionary(0, &server_method)); |
| 6190 | bool use_post; |
| 6191 | EXPECT_TRUE(server_method->GetBoolean("use_post", &use_post)); |
| 6192 | EXPECT_TRUE(use_post); |
dalyk | b34631f | 2018-08-24 19:59:48 | [diff] [blame] | 6193 | std::string server_template; |
| 6194 | EXPECT_TRUE(server_method->GetString("server_template", &server_template)); |
| 6195 | EXPECT_EQ(server_template, server); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6196 | EXPECT_EQ(config->FindKey("secure_dns_mode")->GetInt(), |
| 6197 | static_cast<int>(DnsConfig::SecureDnsMode::AUTOMATIC)); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6198 | |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6199 | resolver_->SetDnsConfigOverrides(DnsConfigOverrides()); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6200 | value = resolver_->GetDnsConfigAsValue(); |
| 6201 | EXPECT_TRUE(value); |
| 6202 | if (!value) |
| 6203 | return; |
| 6204 | value->GetAsDictionary(&config); |
| 6205 | config->GetListWithoutPathExpansion("doh_servers", &doh_servers); |
| 6206 | EXPECT_TRUE(doh_servers); |
| 6207 | if (!doh_servers) |
| 6208 | return; |
| 6209 | EXPECT_EQ(doh_servers->GetSize(), 0u); |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6210 | EXPECT_EQ(config->FindKey("secure_dns_mode")->GetInt(), |
| 6211 | static_cast<int>(DnsConfig::SecureDnsMode::OFF)); |
Brad Lassey | 786929ad | 2018-02-21 20:54:27 | [diff] [blame] | 6212 | } |
| 6213 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6214 | TEST_F(HostResolverManagerDnsTest, SetDnsConfigOverrides) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6215 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6216 | ChangeDnsConfig(original_config); |
| 6217 | |
| 6218 | // Confirm pre-override state. |
| 6219 | ASSERT_TRUE(original_config.Equals(*dns_client_->GetConfig())); |
| 6220 | |
| 6221 | DnsConfigOverrides overrides; |
| 6222 | const std::vector<IPEndPoint> nameservers = { |
| 6223 | CreateExpected("192.168.0.1", 92)}; |
| 6224 | overrides.nameservers = nameservers; |
| 6225 | const std::vector<std::string> search = {"str"}; |
| 6226 | overrides.search = search; |
| 6227 | const DnsHosts hosts = { |
| 6228 | {DnsHostsKey("host", ADDRESS_FAMILY_IPV4), IPAddress(192, 168, 1, 1)}}; |
| 6229 | overrides.hosts = hosts; |
| 6230 | overrides.append_to_multi_label_name = false; |
| 6231 | overrides.randomize_ports = true; |
| 6232 | const int ndots = 5; |
| 6233 | overrides.ndots = ndots; |
| 6234 | const base::TimeDelta timeout = base::TimeDelta::FromSeconds(10); |
| 6235 | overrides.timeout = timeout; |
| 6236 | const int attempts = 20; |
| 6237 | overrides.attempts = attempts; |
| 6238 | overrides.rotate = true; |
| 6239 | overrides.use_local_ipv6 = true; |
| 6240 | const std::vector<DnsConfig::DnsOverHttpsServerConfig> |
| 6241 | dns_over_https_servers = { |
| 6242 | DnsConfig::DnsOverHttpsServerConfig("dns.example.com", true)}; |
| 6243 | overrides.dns_over_https_servers = dns_over_https_servers; |
dalyk | bd726ee | 2019-05-30 01:44:06 | [diff] [blame] | 6244 | const DnsConfig::SecureDnsMode secure_dns_mode = |
| 6245 | DnsConfig::SecureDnsMode::SECURE; |
| 6246 | overrides.secure_dns_mode = secure_dns_mode; |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6247 | |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6248 | // This test is expected to test overriding all fields. |
| 6249 | EXPECT_TRUE(overrides.OverridesEverything()); |
| 6250 | |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6251 | resolver_->SetDnsConfigOverrides(overrides); |
| 6252 | |
| 6253 | const DnsConfig* overridden_config = dns_client_->GetConfig(); |
| 6254 | EXPECT_EQ(nameservers, overridden_config->nameservers); |
| 6255 | EXPECT_EQ(search, overridden_config->search); |
| 6256 | EXPECT_EQ(hosts, overridden_config->hosts); |
| 6257 | EXPECT_FALSE(overridden_config->append_to_multi_label_name); |
| 6258 | EXPECT_TRUE(overridden_config->randomize_ports); |
| 6259 | EXPECT_EQ(ndots, overridden_config->ndots); |
| 6260 | EXPECT_EQ(timeout, overridden_config->timeout); |
| 6261 | EXPECT_EQ(attempts, overridden_config->attempts); |
| 6262 | EXPECT_TRUE(overridden_config->rotate); |
| 6263 | EXPECT_TRUE(overridden_config->use_local_ipv6); |
| 6264 | EXPECT_EQ(dns_over_https_servers, overridden_config->dns_over_https_servers); |
dalyk | bd726ee | 2019-05-30 01:44:06 | [diff] [blame] | 6265 | EXPECT_EQ(secure_dns_mode, overridden_config->secure_dns_mode); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6266 | } |
| 6267 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6268 | TEST_F(HostResolverManagerDnsTest, |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6269 | SetDnsConfigOverrides_OverrideEverythingCreation) { |
| 6270 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6271 | ChangeDnsConfig(original_config); |
| 6272 | |
| 6273 | // Confirm pre-override state. |
| 6274 | ASSERT_TRUE(original_config.Equals(*dns_client_->GetConfig())); |
| 6275 | ASSERT_FALSE(original_config.Equals(DnsConfig())); |
| 6276 | |
| 6277 | DnsConfigOverrides overrides = |
| 6278 | DnsConfigOverrides::CreateOverridingEverythingWithDefaults(); |
| 6279 | EXPECT_TRUE(overrides.OverridesEverything()); |
| 6280 | |
| 6281 | // Ensure config is valid by setting a nameserver. |
| 6282 | std::vector<IPEndPoint> nameservers = {CreateExpected("1.2.3.4", 50)}; |
| 6283 | overrides.nameservers = nameservers; |
| 6284 | EXPECT_TRUE(overrides.OverridesEverything()); |
| 6285 | |
| 6286 | resolver_->SetDnsConfigOverrides(overrides); |
| 6287 | |
| 6288 | DnsConfig expected; |
| 6289 | expected.nameservers = nameservers; |
| 6290 | EXPECT_TRUE(dns_client_->GetConfig()->Equals(DnsConfig(expected))); |
| 6291 | } |
| 6292 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6293 | TEST_F(HostResolverManagerDnsTest, SetDnsConfigOverrides_PartialOverride) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6294 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6295 | ChangeDnsConfig(original_config); |
| 6296 | |
| 6297 | // Confirm pre-override state. |
| 6298 | ASSERT_TRUE(original_config.Equals(*dns_client_->GetConfig())); |
| 6299 | |
| 6300 | DnsConfigOverrides overrides; |
| 6301 | const std::vector<IPEndPoint> nameservers = { |
| 6302 | CreateExpected("192.168.0.2", 192)}; |
| 6303 | overrides.nameservers = nameservers; |
| 6304 | overrides.rotate = true; |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6305 | EXPECT_FALSE(overrides.OverridesEverything()); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6306 | |
| 6307 | resolver_->SetDnsConfigOverrides(overrides); |
| 6308 | |
| 6309 | const DnsConfig* overridden_config = dns_client_->GetConfig(); |
| 6310 | EXPECT_EQ(nameservers, overridden_config->nameservers); |
| 6311 | EXPECT_EQ(original_config.search, overridden_config->search); |
| 6312 | EXPECT_EQ(original_config.hosts, overridden_config->hosts); |
| 6313 | EXPECT_TRUE(overridden_config->append_to_multi_label_name); |
| 6314 | EXPECT_FALSE(overridden_config->randomize_ports); |
| 6315 | EXPECT_EQ(original_config.ndots, overridden_config->ndots); |
| 6316 | EXPECT_EQ(original_config.timeout, overridden_config->timeout); |
| 6317 | EXPECT_EQ(original_config.attempts, overridden_config->attempts); |
| 6318 | EXPECT_TRUE(overridden_config->rotate); |
| 6319 | EXPECT_FALSE(overridden_config->use_local_ipv6); |
| 6320 | EXPECT_EQ(original_config.dns_over_https_servers, |
| 6321 | overridden_config->dns_over_https_servers); |
dalyk | bd726ee | 2019-05-30 01:44:06 | [diff] [blame] | 6322 | EXPECT_EQ(original_config.secure_dns_mode, |
| 6323 | overridden_config->secure_dns_mode); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6324 | } |
| 6325 | |
| 6326 | // Test that overridden configs are reapplied over a changed underlying system |
| 6327 | // config. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6328 | TEST_F(HostResolverManagerDnsTest, SetDnsConfigOverrides_NewConfig) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6329 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6330 | ChangeDnsConfig(original_config); |
| 6331 | |
| 6332 | // Confirm pre-override state. |
| 6333 | ASSERT_TRUE(original_config.Equals(*dns_client_->GetConfig())); |
| 6334 | |
| 6335 | DnsConfigOverrides overrides; |
| 6336 | const std::vector<IPEndPoint> nameservers = { |
| 6337 | CreateExpected("192.168.0.2", 192)}; |
| 6338 | overrides.nameservers = nameservers; |
| 6339 | |
| 6340 | resolver_->SetDnsConfigOverrides(overrides); |
| 6341 | ASSERT_EQ(nameservers, dns_client_->GetConfig()->nameservers); |
| 6342 | |
| 6343 | DnsConfig new_config = original_config; |
| 6344 | new_config.attempts = 103; |
| 6345 | ASSERT_NE(nameservers, new_config.nameservers); |
| 6346 | ChangeDnsConfig(new_config); |
| 6347 | |
| 6348 | const DnsConfig* overridden_config = dns_client_->GetConfig(); |
| 6349 | EXPECT_EQ(nameservers, overridden_config->nameservers); |
| 6350 | EXPECT_EQ(new_config.attempts, overridden_config->attempts); |
| 6351 | } |
| 6352 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6353 | TEST_F(HostResolverManagerDnsTest, SetDnsConfigOverrides_ClearOverrides) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6354 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6355 | ChangeDnsConfig(original_config); |
| 6356 | |
| 6357 | DnsConfigOverrides overrides; |
| 6358 | overrides.attempts = 245; |
| 6359 | resolver_->SetDnsConfigOverrides(overrides); |
| 6360 | |
| 6361 | ASSERT_FALSE(original_config.Equals(*dns_client_->GetConfig())); |
| 6362 | |
| 6363 | resolver_->SetDnsConfigOverrides(DnsConfigOverrides()); |
| 6364 | EXPECT_TRUE(original_config.Equals(*dns_client_->GetConfig())); |
| 6365 | } |
| 6366 | |
Eric Orth | 37b1819 | 2019-04-22 19:09:28 | [diff] [blame] | 6367 | TEST_F(HostResolverManagerDnsTest, FlushCacheOnDnsConfigOverridesChange) { |
| 6368 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6369 | |
| 6370 | HostResolver::ResolveHostParameters local_source_parameters; |
| 6371 | local_source_parameters.source = HostResolverSource::LOCAL_ONLY; |
| 6372 | |
| 6373 | // Populate cache. |
| 6374 | ResolveHostResponseHelper initial_response(resolver_->CreateRequest( |
| 6375 | HostPortPair("ok", 70), NetLogWithSource(), base::nullopt, |
| 6376 | request_context_.get(), host_cache_.get())); |
| 6377 | EXPECT_THAT(initial_response.result_error(), IsOk()); |
| 6378 | |
| 6379 | // Confirm result now cached. |
| 6380 | ResolveHostResponseHelper cached_response(resolver_->CreateRequest( |
| 6381 | HostPortPair("ok", 75), NetLogWithSource(), local_source_parameters, |
| 6382 | request_context_.get(), host_cache_.get())); |
| 6383 | ASSERT_THAT(cached_response.result_error(), IsOk()); |
| 6384 | ASSERT_TRUE(cached_response.request()->GetStaleInfo()); |
| 6385 | |
| 6386 | // Flush cache by triggering a DnsConfigOverrides change. |
| 6387 | DnsConfigOverrides overrides; |
| 6388 | overrides.attempts = 4; |
| 6389 | resolver_->SetDnsConfigOverrides(overrides); |
| 6390 | |
| 6391 | // Expect no longer cached |
| 6392 | ResolveHostResponseHelper flushed_response(resolver_->CreateRequest( |
| 6393 | HostPortPair("ok", 80), NetLogWithSource(), local_source_parameters, |
| 6394 | request_context_.get(), host_cache_.get())); |
| 6395 | EXPECT_THAT(flushed_response.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 6396 | } |
| 6397 | |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6398 | // Test that even when using config overrides, a change to the base system |
| 6399 | // config cancels pending requests. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6400 | TEST_F(HostResolverManagerDnsTest, CancellationOnBaseConfigChange) { |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6401 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6402 | ChangeDnsConfig(original_config); |
| 6403 | |
| 6404 | DnsConfigOverrides overrides; |
| 6405 | overrides.nameservers.emplace({CreateExpected("123.123.123.123", 80)}); |
| 6406 | ASSERT_FALSE(overrides.OverridesEverything()); |
| 6407 | resolver_->SetDnsConfigOverrides(overrides); |
| 6408 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6409 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6410 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 6411 | request_context_.get(), host_cache_.get())); |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6412 | ASSERT_FALSE(response.complete()); |
| 6413 | |
| 6414 | DnsConfig new_config = original_config; |
| 6415 | new_config.attempts = 103; |
| 6416 | ChangeDnsConfig(new_config); |
| 6417 | |
| 6418 | EXPECT_THAT(response.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 6419 | } |
| 6420 | |
| 6421 | // Test that when all configuration is overridden, system configuration changes |
| 6422 | // do not cancel requests. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6423 | TEST_F(HostResolverManagerDnsTest, |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6424 | CancellationOnBaseConfigChange_OverridesEverything) { |
| 6425 | DnsConfig original_config = CreateValidDnsConfig(); |
| 6426 | ChangeDnsConfig(original_config); |
| 6427 | |
| 6428 | DnsConfigOverrides overrides = |
| 6429 | DnsConfigOverrides::CreateOverridingEverythingWithDefaults(); |
| 6430 | overrides.nameservers.emplace({CreateExpected("123.123.123.123", 80)}); |
| 6431 | ASSERT_TRUE(overrides.OverridesEverything()); |
| 6432 | resolver_->SetDnsConfigOverrides(overrides); |
| 6433 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6434 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6435 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 6436 | request_context_.get(), host_cache_.get())); |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6437 | ASSERT_FALSE(response.complete()); |
| 6438 | |
| 6439 | DnsConfig new_config = original_config; |
| 6440 | new_config.attempts = 103; |
| 6441 | ChangeDnsConfig(new_config); |
| 6442 | |
| 6443 | dns_client_->CompleteDelayedTransactions(); |
| 6444 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6445 | } |
| 6446 | |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6447 | // Test that in-progress queries are cancelled on applying new DNS config |
| 6448 | // overrides, same as receiving a new DnsConfig from the system. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6449 | TEST_F(HostResolverManagerDnsTest, CancelQueriesOnSettingOverrides) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6450 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6451 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6452 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 6453 | request_context_.get(), host_cache_.get())); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6454 | ASSERT_FALSE(response.complete()); |
| 6455 | |
| 6456 | DnsConfigOverrides overrides; |
| 6457 | overrides.attempts = 123; |
| 6458 | resolver_->SetDnsConfigOverrides(overrides); |
| 6459 | |
| 6460 | EXPECT_THAT(response.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 6461 | } |
| 6462 | |
| 6463 | // Queries should not be cancelled if equal overrides are set. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6464 | TEST_F(HostResolverManagerDnsTest, |
| 6465 | CancelQueriesOnSettingOverrides_SameOverrides) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6466 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6467 | DnsConfigOverrides overrides; |
| 6468 | overrides.attempts = 123; |
| 6469 | resolver_->SetDnsConfigOverrides(overrides); |
| 6470 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6471 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6472 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 6473 | request_context_.get(), host_cache_.get())); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6474 | ASSERT_FALSE(response.complete()); |
| 6475 | |
| 6476 | resolver_->SetDnsConfigOverrides(overrides); |
| 6477 | |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6478 | dns_client_->CompleteDelayedTransactions(); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6479 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6480 | } |
| 6481 | |
| 6482 | // Test that in-progress queries are cancelled on clearing DNS config overrides, |
| 6483 | // same as receiving a new DnsConfig from the system. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6484 | TEST_F(HostResolverManagerDnsTest, CancelQueriesOnClearingOverrides) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6485 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6486 | DnsConfigOverrides overrides; |
| 6487 | overrides.attempts = 123; |
| 6488 | resolver_->SetDnsConfigOverrides(overrides); |
| 6489 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6490 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6491 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 6492 | request_context_.get(), host_cache_.get())); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6493 | ASSERT_FALSE(response.complete()); |
| 6494 | |
| 6495 | resolver_->SetDnsConfigOverrides(DnsConfigOverrides()); |
| 6496 | |
| 6497 | EXPECT_THAT(response.result_error(), IsError(ERR_NETWORK_CHANGED)); |
| 6498 | } |
| 6499 | |
| 6500 | // Queries should not be cancelled on clearing overrides if there were not any |
| 6501 | // overrides. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6502 | TEST_F(HostResolverManagerDnsTest, |
| 6503 | CancelQueriesOnClearingOverrides_NoOverrides) { |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6504 | ChangeDnsConfig(CreateValidDnsConfig()); |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6505 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6506 | HostPortPair("4slow_ok", 80), NetLogWithSource(), base::nullopt, |
| 6507 | request_context_.get(), host_cache_.get())); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6508 | ASSERT_FALSE(response.complete()); |
| 6509 | |
| 6510 | resolver_->SetDnsConfigOverrides(DnsConfigOverrides()); |
| 6511 | |
Eric Orth | c823a23d | 2018-10-30 22:12:48 | [diff] [blame] | 6512 | dns_client_->CompleteDelayedTransactions(); |
Eric Orth | c1eb129 | 2018-10-09 22:07:07 | [diff] [blame] | 6513 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6514 | } |
| 6515 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6516 | // Test HostResolverManager::UpdateModeForHistogram. |
| 6517 | TEST_F(HostResolverManagerDnsTest, ModeForHistogram) { |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6518 | // Test Async resolver is detected. |
| 6519 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6520 | EXPECT_EQ(resolver_->mode_for_histogram_, |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6521 | HostResolverManager::MODE_FOR_HISTOGRAM_ASYNC_DNS); |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6522 | |
| 6523 | // Test upgradability is detected for async DNS. |
Eric Orth | 192e3bb | 2018-11-14 19:30:32 | [diff] [blame] | 6524 | static const std::vector<const char*> upgradable_servers( |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6525 | {// Google Public DNS |
| 6526 | "8.8.8.8", "8.8.4.4", "2001:4860:4860::8888", "2001:4860:4860::8844", |
| 6527 | // Cloudflare DNS |
| 6528 | "1.1.1.1", "1.0.0.1", "2606:4700:4700::1111", "2606:4700:4700::1001", |
| 6529 | // Quad9 DNS |
| 6530 | "9.9.9.9", "149.112.112.112", "2620:fe::fe", "2620:fe::9"}); |
| 6531 | for (const char* upgradable_server : upgradable_servers) { |
| 6532 | IPAddress ip_address; |
| 6533 | ASSERT_TRUE(ip_address.AssignFromIPLiteral(upgradable_server)); |
| 6534 | DnsConfig dns_config; |
| 6535 | dns_config.nameservers.push_back( |
| 6536 | IPEndPoint(ip_address, dns_protocol::kDefaultPort)); |
| 6537 | ChangeDnsConfig(dns_config); |
| 6538 | EXPECT_EQ( |
| 6539 | resolver_->mode_for_histogram_, |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6540 | HostResolverManager::MODE_FOR_HISTOGRAM_ASYNC_DNS_PRIVATE_SUPPORTS_DOH); |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6541 | } |
| 6542 | |
| 6543 | // Test system resolver is detected. |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6544 | resolver_->SetInsecureDnsClientEnabled(false); |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6545 | ChangeDnsConfig(CreateValidDnsConfig()); |
| 6546 | EXPECT_EQ(resolver_->mode_for_histogram_, |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6547 | HostResolverManager::MODE_FOR_HISTOGRAM_SYSTEM); |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6548 | |
| 6549 | // Test upgradability is detected for system resolver. |
| 6550 | for (const char* upgradable_server : upgradable_servers) { |
| 6551 | IPAddress ip_address; |
| 6552 | ASSERT_TRUE(ip_address.AssignFromIPLiteral(upgradable_server)); |
| 6553 | DnsConfig dns_config; |
| 6554 | dns_config.nameservers.push_back( |
| 6555 | IPEndPoint(ip_address, dns_protocol::kDefaultPort)); |
| 6556 | ChangeDnsConfig(dns_config); |
| 6557 | EXPECT_EQ(resolver_->mode_for_histogram_, |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6558 | HostResolverManager::MODE_FOR_HISTOGRAM_SYSTEM_SUPPORTS_DOH); |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6559 | } |
dalyk | 6d7d8ead | 2019-08-15 03:30:08 | [diff] [blame] | 6560 | |
| 6561 | // Test private DNS is detected. |
| 6562 | DnsConfig config = CreateValidDnsConfig(); |
| 6563 | config.dns_over_tls_active = true; |
| 6564 | ChangeDnsConfig(config); |
| 6565 | EXPECT_EQ(resolver_->mode_for_histogram_, |
| 6566 | HostResolverManager::MODE_FOR_HISTOGRAM_SYSTEM_PRIVATE_DNS); |
| 6567 | |
| 6568 | // Test upgradeability from IP addresses when private DNS is active. |
| 6569 | for (const char* upgradable_server : upgradable_servers) { |
| 6570 | IPAddress ip_address; |
| 6571 | ASSERT_TRUE(ip_address.AssignFromIPLiteral(upgradable_server)); |
| 6572 | DnsConfig dns_config; |
| 6573 | dns_config.dns_over_tls_active = true; |
| 6574 | dns_config.nameservers.push_back( |
| 6575 | IPEndPoint(ip_address, dns_protocol::kDefaultPort)); |
| 6576 | ChangeDnsConfig(dns_config); |
| 6577 | EXPECT_EQ(resolver_->mode_for_histogram_, |
| 6578 | HostResolverManager:: |
| 6579 | MODE_FOR_HISTOGRAM_SYSTEM_PRIVATE_DNS_SUPPORTS_DOH); |
| 6580 | } |
| 6581 | |
| 6582 | // Test upgradeability from private DNS hostname. |
| 6583 | static const std::vector<const char*> upgradeable_private_servers( |
| 6584 | {// Google Public DNS |
| 6585 | "dns.google", |
| 6586 | // Cloudflare DNS |
| 6587 | "1dot1dot1dot1.cloudflare-dns.com", "cloudflare-dns.com", |
| 6588 | // Quad9 DNS |
| 6589 | "dns.quad9.net"}); |
| 6590 | for (const char* upgradeable_private_server : upgradeable_private_servers) { |
| 6591 | DnsConfig dns_config; |
| 6592 | dns_config.dns_over_tls_active = true; |
| 6593 | dns_config.dns_over_tls_hostname = upgradeable_private_server; |
| 6594 | dns_config.nameservers.push_back( |
| 6595 | IPEndPoint(IPAddress(1, 2, 3, 4), dns_protocol::kDefaultPort)); |
| 6596 | ChangeDnsConfig(dns_config); |
| 6597 | EXPECT_EQ(resolver_->mode_for_histogram_, |
| 6598 | HostResolverManager:: |
| 6599 | MODE_FOR_HISTOGRAM_SYSTEM_PRIVATE_DNS_SUPPORTS_DOH); |
| 6600 | } |
Paul Jensen | 41dc3e9f | 2018-11-06 22:10:10 | [diff] [blame] | 6601 | } |
| 6602 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6603 | TEST_F(HostResolverManagerDnsTest, TxtQuery) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6604 | // Simulate two separate DNS records, each with multiple strings. |
| 6605 | std::vector<std::string> foo_records = {"foo1", "foo2", "foo3"}; |
| 6606 | std::vector<std::string> bar_records = {"bar1", "bar2"}; |
| 6607 | std::vector<std::vector<std::string>> text_records = {foo_records, |
| 6608 | bar_records}; |
| 6609 | |
| 6610 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6611 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 6612 | MockDnsClientRule::Result(BuildTestDnsTextResponse( |
| 6613 | "host", std::move(text_records))), |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6614 | false /* delay */); |
| 6615 | |
| 6616 | CreateResolver(); |
| 6617 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6618 | |
| 6619 | HostResolver::ResolveHostParameters parameters; |
| 6620 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6621 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6622 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6623 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6624 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6625 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6626 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6627 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6628 | |
| 6629 | // Order between separate DNS records is undefined, but each record should |
| 6630 | // stay in order as that order may be meaningful. |
| 6631 | ASSERT_THAT(response.request()->GetTextResults(), |
| 6632 | testing::Optional(testing::UnorderedElementsAre( |
| 6633 | "foo1", "foo2", "foo3", "bar1", "bar2"))); |
| 6634 | std::vector<std::string> results = |
| 6635 | response.request()->GetTextResults().value(); |
| 6636 | EXPECT_NE(results.end(), std::search(results.begin(), results.end(), |
| 6637 | foo_records.begin(), foo_records.end())); |
| 6638 | EXPECT_NE(results.end(), std::search(results.begin(), results.end(), |
| 6639 | bar_records.begin(), bar_records.end())); |
| 6640 | } |
| 6641 | |
dalyk | c27699a | 2019-07-29 20:53:29 | [diff] [blame] | 6642 | TEST_F(HostResolverManagerDnsTest, TxtQuery_InvalidConfig) { |
| 6643 | set_allow_fallback_to_proctask(false); |
| 6644 | // Set empty DnsConfig. |
| 6645 | ChangeDnsConfig(DnsConfig()); |
| 6646 | |
| 6647 | HostResolver::ResolveHostParameters parameters; |
| 6648 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6649 | |
| 6650 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6651 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6652 | request_context_.get(), host_cache_.get())); |
| 6653 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_CACHE_MISS)); |
| 6654 | } |
| 6655 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6656 | TEST_F(HostResolverManagerDnsTest, TxtQuery_NonexistentDomain) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6657 | // Setup fallback to confirm it is not used for non-address results. |
| 6658 | set_allow_fallback_to_proctask(true); |
| 6659 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6660 | proc_->SignalMultiple(1u); |
| 6661 | |
| 6662 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6663 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6664 | MockDnsClientRule::Result(MockDnsClientRule::NODOMAIN), |
| 6665 | false /* delay */); |
| 6666 | |
| 6667 | CreateResolver(); |
| 6668 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6669 | |
| 6670 | HostResolver::ResolveHostParameters parameters; |
| 6671 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6672 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6673 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6674 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6675 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6676 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 6677 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6678 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6679 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6680 | } |
| 6681 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6682 | TEST_F(HostResolverManagerDnsTest, TxtQuery_Failure) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6683 | // Setup fallback to confirm it is not used for non-address results. |
| 6684 | set_allow_fallback_to_proctask(true); |
| 6685 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6686 | proc_->SignalMultiple(1u); |
| 6687 | |
| 6688 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6689 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
| 6690 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 6691 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6692 | |
| 6693 | CreateResolver(); |
| 6694 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6695 | |
| 6696 | HostResolver::ResolveHostParameters parameters; |
| 6697 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6698 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6699 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6700 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6701 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6702 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 6703 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6704 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6705 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6706 | } |
| 6707 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6708 | TEST_F(HostResolverManagerDnsTest, TxtQuery_Timeout) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6709 | // Setup fallback to confirm it is not used for non-address results. |
| 6710 | set_allow_fallback_to_proctask(true); |
| 6711 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6712 | proc_->SignalMultiple(1u); |
| 6713 | |
| 6714 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6715 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
| 6716 | MockDnsClientRule::Result(MockDnsClientRule::TIMEOUT), |
| 6717 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6718 | |
| 6719 | CreateResolver(); |
| 6720 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6721 | |
| 6722 | HostResolver::ResolveHostParameters parameters; |
| 6723 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6724 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6725 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6726 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6727 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6728 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_TIMED_OUT)); |
| 6729 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6730 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6731 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6732 | } |
| 6733 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6734 | TEST_F(HostResolverManagerDnsTest, TxtQuery_Empty) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6735 | // Setup fallback to confirm it is not used for non-address results. |
| 6736 | set_allow_fallback_to_proctask(true); |
| 6737 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6738 | proc_->SignalMultiple(1u); |
| 6739 | |
| 6740 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6741 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
| 6742 | MockDnsClientRule::Result(MockDnsClientRule::EMPTY), |
| 6743 | false /* delay */); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6744 | |
| 6745 | CreateResolver(); |
| 6746 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6747 | |
| 6748 | HostResolver::ResolveHostParameters parameters; |
| 6749 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6750 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6751 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6752 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6753 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6754 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 6755 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6756 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6757 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6758 | } |
| 6759 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6760 | TEST_F(HostResolverManagerDnsTest, TxtQuery_Malformed) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6761 | // Setup fallback to confirm it is not used for non-address results. |
| 6762 | set_allow_fallback_to_proctask(true); |
| 6763 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6764 | proc_->SignalMultiple(1u); |
| 6765 | |
| 6766 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6767 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6768 | MockDnsClientRule::Result(MockDnsClientRule::MALFORMED), |
| 6769 | false /* delay */); |
| 6770 | |
| 6771 | CreateResolver(); |
| 6772 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6773 | |
| 6774 | HostResolver::ResolveHostParameters parameters; |
| 6775 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6776 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6777 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6778 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6779 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6780 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_MALFORMED_RESPONSE)); |
| 6781 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6782 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6783 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6784 | } |
| 6785 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6786 | TEST_F(HostResolverManagerDnsTest, TxtQuery_MismatchedName) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6787 | std::vector<std::vector<std::string>> text_records = {{"text"}}; |
| 6788 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6789 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 6790 | MockDnsClientRule::Result(BuildTestDnsTextResponse( |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6791 | "host", std::move(text_records), "not.host")), |
| 6792 | false /* delay */); |
| 6793 | |
| 6794 | CreateResolver(); |
| 6795 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6796 | |
| 6797 | HostResolver::ResolveHostParameters parameters; |
| 6798 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6799 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6800 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6801 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6802 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6803 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_MALFORMED_RESPONSE)); |
| 6804 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6805 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6806 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6807 | } |
| 6808 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6809 | TEST_F(HostResolverManagerDnsTest, TxtQuery_WrongType) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6810 | // Respond to a TXT query with an A response. |
| 6811 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6812 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6813 | MockDnsClientRule::Result( |
| 6814 | BuildTestDnsResponse("host", IPAddress(1, 2, 3, 4))), |
| 6815 | false /* delay */); |
| 6816 | |
| 6817 | CreateResolver(); |
| 6818 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6819 | |
| 6820 | HostResolver::ResolveHostParameters parameters; |
| 6821 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6822 | |
| 6823 | // Responses for the wrong type should be ignored. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6824 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6825 | HostPortPair("ok", 108), NetLogWithSource(), parameters, |
| 6826 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6827 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 6828 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6829 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6830 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6831 | } |
| 6832 | |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 6833 | // Same as TxtQuery except we specify DNS HostResolverSource instead of relying |
| 6834 | // on automatic determination. Expect same results since DNS should be what we |
| 6835 | // automatically determine, but some slightly different logic paths are |
| 6836 | // involved. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6837 | TEST_F(HostResolverManagerDnsTest, TxtDnsQuery) { |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6838 | // Simulate two separate DNS records, each with multiple strings. |
| 6839 | std::vector<std::string> foo_records = {"foo1", "foo2", "foo3"}; |
| 6840 | std::vector<std::string> bar_records = {"bar1", "bar2"}; |
| 6841 | std::vector<std::vector<std::string>> text_records = {foo_records, |
| 6842 | bar_records}; |
| 6843 | |
| 6844 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6845 | rules.emplace_back("host", dns_protocol::kTypeTXT, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 6846 | MockDnsClientRule::Result(BuildTestDnsTextResponse( |
| 6847 | "host", std::move(text_records))), |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6848 | false /* delay */); |
| 6849 | |
| 6850 | CreateResolver(); |
| 6851 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6852 | |
| 6853 | HostResolver::ResolveHostParameters parameters; |
| 6854 | parameters.source = HostResolverSource::DNS; |
| 6855 | parameters.dns_query_type = DnsQueryType::TXT; |
| 6856 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6857 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6858 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6859 | request_context_.get(), host_cache_.get())); |
Eric Orth | 828bd3ae | 2018-12-12 17:30:36 | [diff] [blame] | 6860 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6861 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6862 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6863 | |
| 6864 | // Order between separate DNS records is undefined, but each record should |
| 6865 | // stay in order as that order may be meaningful. |
| 6866 | ASSERT_THAT(response.request()->GetTextResults(), |
| 6867 | testing::Optional(testing::UnorderedElementsAre( |
| 6868 | "foo1", "foo2", "foo3", "bar1", "bar2"))); |
| 6869 | std::vector<std::string> results = |
| 6870 | response.request()->GetTextResults().value(); |
| 6871 | EXPECT_NE(results.end(), std::search(results.begin(), results.end(), |
| 6872 | foo_records.begin(), foo_records.end())); |
| 6873 | EXPECT_NE(results.end(), std::search(results.begin(), results.end(), |
| 6874 | bar_records.begin(), bar_records.end())); |
| 6875 | } |
| 6876 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6877 | TEST_F(HostResolverManagerDnsTest, PtrQuery) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6878 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6879 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6880 | MockDnsClientRule::Result(BuildTestDnsPointerResponse( |
| 6881 | "host", {"foo.com", "bar.com"})), |
| 6882 | false /* delay */); |
| 6883 | |
| 6884 | CreateResolver(); |
| 6885 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6886 | |
| 6887 | HostResolver::ResolveHostParameters parameters; |
| 6888 | parameters.dns_query_type = DnsQueryType::PTR; |
| 6889 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6890 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6891 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6892 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6893 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6894 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6895 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6896 | |
| 6897 | // Order between separate records is undefined. |
| 6898 | EXPECT_THAT(response.request()->GetHostnameResults(), |
| 6899 | testing::Optional(testing::UnorderedElementsAre( |
| 6900 | HostPortPair("foo.com", 108), HostPortPair("bar.com", 108)))); |
| 6901 | } |
| 6902 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6903 | TEST_F(HostResolverManagerDnsTest, PtrQuery_Ip) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6904 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6905 | rules.emplace_back("8.8.8.8", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6906 | MockDnsClientRule::Result(BuildTestDnsPointerResponse( |
| 6907 | "8.8.8.8", {"foo.com", "bar.com"})), |
| 6908 | false /* delay */); |
| 6909 | |
| 6910 | CreateResolver(); |
| 6911 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6912 | |
| 6913 | HostResolver::ResolveHostParameters parameters; |
| 6914 | parameters.dns_query_type = DnsQueryType::PTR; |
| 6915 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6916 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6917 | HostPortPair("8.8.8.8", 108), NetLogWithSource(), parameters, |
| 6918 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6919 | EXPECT_THAT(response.result_error(), IsOk()); |
| 6920 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6921 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6922 | |
| 6923 | // Order between separate records is undefined. |
| 6924 | EXPECT_THAT(response.request()->GetHostnameResults(), |
| 6925 | testing::Optional(testing::UnorderedElementsAre( |
| 6926 | HostPortPair("foo.com", 108), HostPortPair("bar.com", 108)))); |
| 6927 | } |
| 6928 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6929 | TEST_F(HostResolverManagerDnsTest, PtrQuery_NonexistentDomain) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6930 | // Setup fallback to confirm it is not used for non-address results. |
| 6931 | set_allow_fallback_to_proctask(true); |
| 6932 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6933 | proc_->SignalMultiple(1u); |
| 6934 | |
| 6935 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6936 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6937 | MockDnsClientRule::Result(MockDnsClientRule::NODOMAIN), |
| 6938 | false /* delay */); |
| 6939 | |
| 6940 | CreateResolver(); |
| 6941 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6942 | |
| 6943 | HostResolver::ResolveHostParameters parameters; |
| 6944 | parameters.dns_query_type = DnsQueryType::PTR; |
| 6945 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6946 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6947 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6948 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6949 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 6950 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6951 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6952 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6953 | } |
| 6954 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6955 | TEST_F(HostResolverManagerDnsTest, PtrQuery_Failure) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6956 | // Setup fallback to confirm it is not used for non-address results. |
| 6957 | set_allow_fallback_to_proctask(true); |
| 6958 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6959 | proc_->SignalMultiple(1u); |
| 6960 | |
| 6961 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6962 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
| 6963 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 6964 | false /* delay */); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6965 | |
| 6966 | CreateResolver(); |
| 6967 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6968 | |
| 6969 | HostResolver::ResolveHostParameters parameters; |
| 6970 | parameters.dns_query_type = DnsQueryType::PTR; |
| 6971 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6972 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6973 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 6974 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6975 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 6976 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 6977 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 6978 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 6979 | } |
| 6980 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 6981 | TEST_F(HostResolverManagerDnsTest, PtrQuery_Timeout) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6982 | // Setup fallback to confirm it is not used for non-address results. |
| 6983 | set_allow_fallback_to_proctask(true); |
| 6984 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 6985 | proc_->SignalMultiple(1u); |
| 6986 | |
| 6987 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 6988 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
| 6989 | MockDnsClientRule::Result(MockDnsClientRule::TIMEOUT), |
| 6990 | false /* delay */); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 6991 | |
| 6992 | CreateResolver(); |
| 6993 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 6994 | |
| 6995 | HostResolver::ResolveHostParameters parameters; |
| 6996 | parameters.dns_query_type = DnsQueryType::PTR; |
| 6997 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 6998 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 6999 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7000 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7001 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_TIMED_OUT)); |
| 7002 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7003 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7004 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7005 | } |
| 7006 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7007 | TEST_F(HostResolverManagerDnsTest, PtrQuery_Empty) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7008 | // Setup fallback to confirm it is not used for non-address results. |
| 7009 | set_allow_fallback_to_proctask(true); |
| 7010 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 7011 | proc_->SignalMultiple(1u); |
| 7012 | |
| 7013 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7014 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
| 7015 | MockDnsClientRule::Result(MockDnsClientRule::EMPTY), |
| 7016 | false /* delay */); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7017 | |
| 7018 | CreateResolver(); |
| 7019 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7020 | |
| 7021 | HostResolver::ResolveHostParameters parameters; |
| 7022 | parameters.dns_query_type = DnsQueryType::PTR; |
| 7023 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7024 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7025 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7026 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7027 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 7028 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7029 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7030 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7031 | } |
| 7032 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7033 | TEST_F(HostResolverManagerDnsTest, PtrQuery_Malformed) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7034 | // Setup fallback to confirm it is not used for non-address results. |
| 7035 | set_allow_fallback_to_proctask(true); |
| 7036 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 7037 | proc_->SignalMultiple(1u); |
| 7038 | |
| 7039 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7040 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7041 | MockDnsClientRule::Result(MockDnsClientRule::MALFORMED), |
| 7042 | false /* delay */); |
| 7043 | |
| 7044 | CreateResolver(); |
| 7045 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7046 | |
| 7047 | HostResolver::ResolveHostParameters parameters; |
| 7048 | parameters.dns_query_type = DnsQueryType::PTR; |
| 7049 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7050 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7051 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7052 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7053 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_MALFORMED_RESPONSE)); |
| 7054 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7055 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7056 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7057 | } |
| 7058 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7059 | TEST_F(HostResolverManagerDnsTest, PtrQuery_MismatchedName) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7060 | std::vector<std::string> ptr_records = {{"foo.com"}}; |
| 7061 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7062 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7063 | MockDnsClientRule::Result(BuildTestDnsPointerResponse( |
| 7064 | "host", std::move(ptr_records), "not.host")), |
| 7065 | false /* delay */); |
| 7066 | |
| 7067 | CreateResolver(); |
| 7068 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7069 | |
| 7070 | HostResolver::ResolveHostParameters parameters; |
| 7071 | parameters.dns_query_type = DnsQueryType::PTR; |
| 7072 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7073 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7074 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7075 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7076 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_MALFORMED_RESPONSE)); |
| 7077 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7078 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7079 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7080 | } |
| 7081 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7082 | TEST_F(HostResolverManagerDnsTest, PtrQuery_WrongType) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7083 | // Respond to a TXT query with an A response. |
| 7084 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7085 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7086 | MockDnsClientRule::Result( |
| 7087 | BuildTestDnsResponse("host", IPAddress(1, 2, 3, 4))), |
| 7088 | false /* delay */); |
| 7089 | |
| 7090 | CreateResolver(); |
| 7091 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7092 | |
| 7093 | HostResolver::ResolveHostParameters parameters; |
| 7094 | parameters.dns_query_type = DnsQueryType::PTR; |
| 7095 | |
| 7096 | // Responses for the wrong type should be ignored. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7097 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7098 | HostPortPair("ok", 108), NetLogWithSource(), parameters, |
| 7099 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7100 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 7101 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7102 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7103 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7104 | } |
| 7105 | |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7106 | // Same as PtrQuery except we specify DNS HostResolverSource instead of relying |
| 7107 | // on automatic determination. Expect same results since DNS should be what we |
| 7108 | // automatically determine, but some slightly different logic paths are |
| 7109 | // involved. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7110 | TEST_F(HostResolverManagerDnsTest, PtrDnsQuery) { |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7111 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7112 | rules.emplace_back("host", dns_protocol::kTypePTR, false /* secure */, |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7113 | MockDnsClientRule::Result(BuildTestDnsPointerResponse( |
| 7114 | "host", {"foo.com", "bar.com"})), |
| 7115 | false /* delay */); |
| 7116 | |
| 7117 | CreateResolver(); |
| 7118 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7119 | |
| 7120 | HostResolver::ResolveHostParameters parameters; |
| 7121 | parameters.source = HostResolverSource::DNS; |
| 7122 | parameters.dns_query_type = DnsQueryType::PTR; |
| 7123 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7124 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7125 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7126 | request_context_.get(), host_cache_.get())); |
Eric Orth | e9db8d23 | 2019-01-14 21:24:45 | [diff] [blame] | 7127 | EXPECT_THAT(response.result_error(), IsOk()); |
| 7128 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7129 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7130 | |
| 7131 | // Order between separate records is undefined. |
| 7132 | EXPECT_THAT(response.request()->GetHostnameResults(), |
| 7133 | testing::Optional(testing::UnorderedElementsAre( |
| 7134 | HostPortPair("foo.com", 108), HostPortPair("bar.com", 108)))); |
| 7135 | } |
| 7136 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7137 | TEST_F(HostResolverManagerDnsTest, SrvQuery) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7138 | const TestServiceRecord kRecord1 = {2, 3, 1223, "foo.com"}; |
| 7139 | const TestServiceRecord kRecord2 = {5, 10, 80, "bar.com"}; |
| 7140 | const TestServiceRecord kRecord3 = {5, 1, 5, "google.com"}; |
| 7141 | const TestServiceRecord kRecord4 = {2, 100, 12345, "chromium.org"}; |
| 7142 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7143 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 7144 | MockDnsClientRule::Result(BuildTestDnsServiceResponse( |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7145 | "host", {kRecord1, kRecord2, kRecord3, kRecord4})), |
| 7146 | false /* delay */); |
| 7147 | |
| 7148 | CreateResolver(); |
| 7149 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7150 | |
| 7151 | HostResolver::ResolveHostParameters parameters; |
| 7152 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7153 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7154 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7155 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7156 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7157 | EXPECT_THAT(response.result_error(), IsOk()); |
| 7158 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7159 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7160 | |
| 7161 | // Expect ordered by priority, and random within a priority. |
| 7162 | base::Optional<std::vector<HostPortPair>> results = |
| 7163 | response.request()->GetHostnameResults(); |
| 7164 | ASSERT_THAT( |
| 7165 | results, |
| 7166 | testing::Optional(testing::UnorderedElementsAre( |
| 7167 | HostPortPair("foo.com", 1223), HostPortPair("bar.com", 80), |
| 7168 | HostPortPair("google.com", 5), HostPortPair("chromium.org", 12345)))); |
| 7169 | auto priority2 = std::vector<HostPortPair>(results.value().begin(), |
| 7170 | results.value().begin() + 2); |
| 7171 | EXPECT_THAT(priority2, testing::UnorderedElementsAre( |
| 7172 | HostPortPair("foo.com", 1223), |
| 7173 | HostPortPair("chromium.org", 12345))); |
| 7174 | auto priority5 = std::vector<HostPortPair>(results.value().begin() + 2, |
| 7175 | results.value().end()); |
| 7176 | EXPECT_THAT(priority5, |
| 7177 | testing::UnorderedElementsAre(HostPortPair("bar.com", 80), |
| 7178 | HostPortPair("google.com", 5))); |
| 7179 | } |
| 7180 | |
| 7181 | // 0-weight services are allowed. Ensure that we can handle such records, |
| 7182 | // especially the case where all entries have weight 0. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7183 | TEST_F(HostResolverManagerDnsTest, SrvQuery_ZeroWeight) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7184 | const TestServiceRecord kRecord1 = {5, 0, 80, "bar.com"}; |
| 7185 | const TestServiceRecord kRecord2 = {5, 0, 5, "google.com"}; |
| 7186 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7187 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 7188 | MockDnsClientRule::Result(BuildTestDnsServiceResponse( |
| 7189 | "host", {kRecord1, kRecord2})), |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7190 | false /* delay */); |
| 7191 | |
| 7192 | CreateResolver(); |
| 7193 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7194 | |
| 7195 | HostResolver::ResolveHostParameters parameters; |
| 7196 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7197 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7198 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7199 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7200 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7201 | EXPECT_THAT(response.result_error(), IsOk()); |
| 7202 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7203 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7204 | |
| 7205 | // Expect ordered by priority, and random within a priority. |
| 7206 | EXPECT_THAT(response.request()->GetHostnameResults(), |
| 7207 | testing::Optional(testing::UnorderedElementsAre( |
| 7208 | HostPortPair("bar.com", 80), HostPortPair("google.com", 5)))); |
| 7209 | } |
| 7210 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7211 | TEST_F(HostResolverManagerDnsTest, SrvQuery_NonexistentDomain) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7212 | // Setup fallback to confirm it is not used for non-address results. |
| 7213 | set_allow_fallback_to_proctask(true); |
| 7214 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 7215 | proc_->SignalMultiple(1u); |
| 7216 | |
| 7217 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7218 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7219 | MockDnsClientRule::Result(MockDnsClientRule::NODOMAIN), |
| 7220 | false /* delay */); |
| 7221 | |
| 7222 | CreateResolver(); |
| 7223 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7224 | |
| 7225 | HostResolver::ResolveHostParameters parameters; |
| 7226 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7227 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7228 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7229 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7230 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7231 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 7232 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7233 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7234 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7235 | } |
| 7236 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7237 | TEST_F(HostResolverManagerDnsTest, SrvQuery_Failure) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7238 | // Setup fallback to confirm it is not used for non-address results. |
| 7239 | set_allow_fallback_to_proctask(true); |
| 7240 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 7241 | proc_->SignalMultiple(1u); |
| 7242 | |
| 7243 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7244 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
| 7245 | MockDnsClientRule::Result(MockDnsClientRule::FAIL), |
| 7246 | false /* delay */); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7247 | |
| 7248 | CreateResolver(); |
| 7249 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7250 | |
| 7251 | HostResolver::ResolveHostParameters parameters; |
| 7252 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7253 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7254 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7255 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7256 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7257 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 7258 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7259 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7260 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7261 | } |
| 7262 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7263 | TEST_F(HostResolverManagerDnsTest, SrvQuery_Timeout) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7264 | // Setup fallback to confirm it is not used for non-address results. |
| 7265 | set_allow_fallback_to_proctask(true); |
| 7266 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 7267 | proc_->SignalMultiple(1u); |
| 7268 | |
| 7269 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7270 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
| 7271 | MockDnsClientRule::Result(MockDnsClientRule::TIMEOUT), |
| 7272 | false /* delay */); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7273 | |
| 7274 | CreateResolver(); |
| 7275 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7276 | |
| 7277 | HostResolver::ResolveHostParameters parameters; |
| 7278 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7279 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7280 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7281 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7282 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7283 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_TIMED_OUT)); |
| 7284 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7285 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7286 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7287 | } |
| 7288 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7289 | TEST_F(HostResolverManagerDnsTest, SrvQuery_Empty) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7290 | // Setup fallback to confirm it is not used for non-address results. |
| 7291 | set_allow_fallback_to_proctask(true); |
| 7292 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 7293 | proc_->SignalMultiple(1u); |
| 7294 | |
| 7295 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7296 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
| 7297 | MockDnsClientRule::Result(MockDnsClientRule::EMPTY), |
| 7298 | false /* delay */); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7299 | |
| 7300 | CreateResolver(); |
| 7301 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7302 | |
| 7303 | HostResolver::ResolveHostParameters parameters; |
| 7304 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7305 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7306 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7307 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7308 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7309 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 7310 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7311 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7312 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7313 | } |
| 7314 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7315 | TEST_F(HostResolverManagerDnsTest, SrvQuery_Malformed) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7316 | // Setup fallback to confirm it is not used for non-address results. |
| 7317 | set_allow_fallback_to_proctask(true); |
| 7318 | proc_->AddRuleForAllFamilies("host", "192.168.1.102"); |
| 7319 | proc_->SignalMultiple(1u); |
| 7320 | |
| 7321 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7322 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7323 | MockDnsClientRule::Result(MockDnsClientRule::MALFORMED), |
| 7324 | false /* delay */); |
| 7325 | |
| 7326 | CreateResolver(); |
| 7327 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7328 | |
| 7329 | HostResolver::ResolveHostParameters parameters; |
| 7330 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7331 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7332 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7333 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7334 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7335 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_MALFORMED_RESPONSE)); |
| 7336 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7337 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7338 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7339 | } |
| 7340 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7341 | TEST_F(HostResolverManagerDnsTest, SrvQuery_MismatchedName) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7342 | std::vector<TestServiceRecord> srv_records = {{1, 2, 3, "foo.com"}}; |
| 7343 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7344 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 7345 | MockDnsClientRule::Result(BuildTestDnsServiceResponse( |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7346 | "host", std::move(srv_records), "not.host")), |
| 7347 | false /* delay */); |
| 7348 | |
| 7349 | CreateResolver(); |
| 7350 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7351 | |
| 7352 | HostResolver::ResolveHostParameters parameters; |
| 7353 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7354 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7355 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7356 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7357 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7358 | EXPECT_THAT(response.result_error(), IsError(ERR_DNS_MALFORMED_RESPONSE)); |
| 7359 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7360 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7361 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7362 | } |
| 7363 | |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7364 | TEST_F(HostResolverManagerDnsTest, SrvQuery_WrongType) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7365 | // Respond to a SRV query with an A response. |
| 7366 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7367 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7368 | MockDnsClientRule::Result( |
| 7369 | BuildTestDnsResponse("host", IPAddress(1, 2, 3, 4))), |
| 7370 | false /* delay */); |
| 7371 | |
| 7372 | CreateResolver(); |
| 7373 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7374 | |
| 7375 | HostResolver::ResolveHostParameters parameters; |
| 7376 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7377 | |
| 7378 | // Responses for the wrong type should be ignored. |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7379 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7380 | HostPortPair("ok", 108), NetLogWithSource(), parameters, |
| 7381 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7382 | EXPECT_THAT(response.result_error(), IsError(ERR_NAME_NOT_RESOLVED)); |
| 7383 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7384 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7385 | EXPECT_FALSE(response.request()->GetHostnameResults()); |
| 7386 | } |
| 7387 | |
| 7388 | // Same as SrvQuery except we specify DNS HostResolverSource instead of relying |
| 7389 | // on automatic determination. Expect same results since DNS should be what we |
| 7390 | // automatically determine, but some slightly different logic paths are |
| 7391 | // involved. |
Eric Orth | 960e706 | 2019-03-08 18:43:54 | [diff] [blame] | 7392 | TEST_F(HostResolverManagerDnsTest, SrvDnsQuery) { |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7393 | const TestServiceRecord kRecord1 = {2, 3, 1223, "foo.com"}; |
| 7394 | const TestServiceRecord kRecord2 = {5, 10, 80, "bar.com"}; |
| 7395 | const TestServiceRecord kRecord3 = {5, 1, 5, "google.com"}; |
| 7396 | const TestServiceRecord kRecord4 = {2, 100, 12345, "chromium.org"}; |
| 7397 | MockDnsClientRuleList rules; |
dalyk | 4f4ac71 | 2019-05-31 16:33:13 | [diff] [blame] | 7398 | rules.emplace_back("host", dns_protocol::kTypeSRV, false /* secure */, |
dalyk | c0ab072 | 2019-03-14 17:00:58 | [diff] [blame] | 7399 | MockDnsClientRule::Result(BuildTestDnsServiceResponse( |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7400 | "host", {kRecord1, kRecord2, kRecord3, kRecord4})), |
| 7401 | false /* delay */); |
| 7402 | |
| 7403 | CreateResolver(); |
| 7404 | UseMockDnsClient(CreateValidDnsConfig(), std::move(rules)); |
| 7405 | |
| 7406 | HostResolver::ResolveHostParameters parameters; |
| 7407 | parameters.source = HostResolverSource::DNS; |
| 7408 | parameters.dns_query_type = DnsQueryType::SRV; |
| 7409 | |
Eric Orth | 117e199 | 2019-04-17 00:24:15 | [diff] [blame] | 7410 | ResolveHostResponseHelper response(resolver_->CreateRequest( |
| 7411 | HostPortPair("host", 108), NetLogWithSource(), parameters, |
| 7412 | request_context_.get(), host_cache_.get())); |
Eric Orth | a625b04 | 2019-01-16 01:14:45 | [diff] [blame] | 7413 | EXPECT_THAT(response.result_error(), IsOk()); |
| 7414 | EXPECT_FALSE(response.request()->GetAddressResults()); |
| 7415 | EXPECT_FALSE(response.request()->GetTextResults()); |
| 7416 | |
| 7417 | // Expect ordered by priority, and random within a priority. |
| 7418 | base::Optional<std::vector<HostPortPair>> results = |
| 7419 | response.request()->GetHostnameResults(); |
| 7420 | ASSERT_THAT( |
| 7421 | results, |
| 7422 | testing::Optional(testing::UnorderedElementsAre( |
| 7423 | HostPortPair("foo.com", 1223), HostPortPair("bar.com", 80), |
| 7424 | HostPortPair("google.com", 5), HostPortPair("chromium.org", 12345)))); |
| 7425 | auto priority2 = std::vector<HostPortPair>(results.value().begin(), |
| 7426 | results.value().begin() + 2); |
| 7427 | EXPECT_THAT(priority2, testing::UnorderedElementsAre( |
| 7428 | HostPortPair("foo.com", 1223), |
| 7429 | HostPortPair("chromium.org", 12345))); |
| 7430 | auto priority5 = std::vector<HostPortPair>(results.value().begin() + 2, |
| 7431 | results.value().end()); |
| 7432 | EXPECT_THAT(priority5, |
| 7433 | testing::UnorderedElementsAre(HostPortPair("bar.com", 80), |
| 7434 | HostPortPair("google.com", 5))); |
| 7435 | } |
| 7436 | |
[email protected] | 259aefa | 2009-08-20 22:45:00 | [diff] [blame] | 7437 | } // namespace net |