[email protected] | a159531 | 2012-01-22 03:25:04 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
[email protected] | 5af3c57 | 2010-07-20 14:16:27 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 3 | // found in the LICENSE file. |
| 4 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 5 | #include <cmath> |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 6 | #include <utility> |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 7 | #include <vector> |
| 8 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 9 | #include "base/bind.h" |
danakj | db9ae794 | 2020-11-11 16:01:35 | [diff] [blame] | 10 | #include "base/callback_helpers.h" |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 11 | #include "base/compiler_specific.h" |
Lei Zhang | 305c015e1 | 2021-06-04 21:07:02 | [diff] [blame] | 12 | #include "base/cxx17_backports.h" |
thestig | d8df033 | 2014-09-04 06:33:29 | [diff] [blame] | 13 | #include "base/files/file_util.h" |
[email protected] | ea1a3f6 | 2012-11-16 20:34:23 | [diff] [blame] | 14 | #include "base/files/scoped_temp_dir.h" |
Keishi Hattori | 0e45c02 | 2021-11-27 09:25:52 | [diff] [blame] | 15 | #include "base/memory/raw_ptr.h" |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 16 | #include "base/run_loop.h" |
Bence Béky | d228fb2 | 2021-10-29 14:45:51 | [diff] [blame] | 17 | #include "base/strings/string_number_conversions.h" |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 18 | #include "base/strings/string_piece.h" |
Devlin Cronin | e4bcb40e | 2018-06-05 18:02:47 | [diff] [blame] | 19 | #include "base/test/metrics/histogram_tester.h" |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 20 | #include "base/test/scoped_feature_list.h" |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 21 | #include "base/test/test_file_util.h" |
gab | f767595f | 2016-05-11 18:50:35 | [diff] [blame] | 22 | #include "base/threading/thread_task_runner_handle.h" |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 23 | #include "build/build_config.h" |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 24 | #include "net/base/auth.h" |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 25 | #include "net/base/chunked_upload_data_stream.h" |
Bence Béky | 8ddc249 | 2018-06-13 01:02:04 | [diff] [blame] | 26 | #include "net/base/completion_once_callback.h" |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 27 | #include "net/base/elements_upload_data_stream.h" |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 28 | #include "net/base/features.h" |
Tsuyoshi Horo | 01faed6 | 2019-02-20 22:11:37 | [diff] [blame] | 29 | #include "net/base/ip_endpoint.h" |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 30 | #include "net/base/network_isolation_key.h" |
tbansal | 28e68f8 | 2016-02-04 02:56:15 | [diff] [blame] | 31 | #include "net/base/proxy_delegate.h" |
Lily Houghton | 582d462 | 2018-01-22 22:43:40 | [diff] [blame] | 32 | #include "net/base/proxy_server.h" |
Eric Orth | 5ccc3f0 | 2021-09-23 00:01:57 | [diff] [blame] | 33 | #include "net/base/proxy_string_util.h" |
[email protected] | 262eec8 | 2013-03-19 21:01:36 | [diff] [blame] | 34 | #include "net/base/request_priority.h" |
Matt Menke | 4807a9a | 2020-11-21 00:14:41 | [diff] [blame] | 35 | #include "net/base/schemeful_site.h" |
tbansal | 28e68f8 | 2016-02-04 02:56:15 | [diff] [blame] | 36 | #include "net/base/test_proxy_delegate.h" |
[email protected] | b2d26cfd | 2012-12-11 10:36:06 | [diff] [blame] | 37 | #include "net/base/upload_bytes_element_reader.h" |
[email protected] | b2d26cfd | 2012-12-11 10:36:06 | [diff] [blame] | 38 | #include "net/base/upload_file_element_reader.h" |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 39 | #include "net/dns/mock_host_resolver.h" |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 40 | #include "net/dns/public/secure_dns_policy.h" |
aberent | bba302d | 2015-12-03 10:20:19 | [diff] [blame] | 41 | #include "net/http/http_auth_scheme.h" |
bnc | 3171a243 | 2016-12-28 18:40:26 | [diff] [blame] | 42 | #include "net/http/http_network_session.h" |
[email protected] | 87bfa3f | 2010-09-30 14:54:56 | [diff] [blame] | 43 | #include "net/http/http_network_session_peer.h" |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 44 | #include "net/http/http_network_transaction.h" |
Matt Menke | 6e879bd | 2019-03-18 17:26:04 | [diff] [blame] | 45 | #include "net/http/http_proxy_connect_job.h" |
Bence Béky | 3a0c4853 | 2018-03-02 13:38:51 | [diff] [blame] | 46 | #include "net/http/http_response_info.h" |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 47 | #include "net/http/http_server_properties.h" |
[email protected] | c41737d | 2014-05-14 07:47:19 | [diff] [blame] | 48 | #include "net/http/http_transaction_test_util.h" |
Yoichi Osato | 4c75c0c | 2020-06-24 08:03:57 | [diff] [blame] | 49 | #include "net/http/test_upload_data_stream_not_allow_http1.h" |
Matt Menke | c74a926 | 2020-06-09 15:49:21 | [diff] [blame] | 50 | #include "net/http/transport_security_state.h" |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 51 | #include "net/log/net_log_event_type.h" |
mikecirone | f22f981 | 2016-10-04 03:40:19 | [diff] [blame] | 52 | #include "net/log/net_log_with_source.h" |
mmenke | 16a7cbdd | 2015-04-24 23:00:56 | [diff] [blame] | 53 | #include "net/log/test_net_log.h" |
mmenke | 43758e6 | 2015-05-04 21:09:46 | [diff] [blame] | 54 | #include "net/log/test_net_log_util.h" |
Nicolas Arciniega | 8ec5bfa | 2020-03-20 05:07:26 | [diff] [blame] | 55 | #include "net/proxy_resolution/configured_proxy_resolution_service.h" |
[email protected] | bb88e1d3 | 2013-05-03 23:11:07 | [diff] [blame] | 56 | #include "net/socket/next_proto.h" |
Paul Jensen | a457017a | 2018-01-19 23:52:04 | [diff] [blame] | 57 | #include "net/socket/socket_tag.h" |
Bence Béky | 78b542c | 2021-03-25 19:30:37 | [diff] [blame] | 58 | #include "net/spdy/alps_decoder.h" |
Bence Béky | 94658bf | 2018-05-11 19:22:58 | [diff] [blame] | 59 | #include "net/spdy/buffered_spdy_framer.h" |
| 60 | #include "net/spdy/spdy_http_stream.h" |
| 61 | #include "net/spdy/spdy_http_utils.h" |
| 62 | #include "net/spdy/spdy_session.h" |
| 63 | #include "net/spdy/spdy_session_pool.h" |
| 64 | #include "net/spdy/spdy_test_util_common.h" |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 65 | #include "net/ssl/ssl_connection_status_flags.h" |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 66 | #include "net/test/cert_test_util.h" |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 67 | #include "net/test/gtest_util.h" |
rsleevi | a69c79a | 2016-06-22 03:28:43 | [diff] [blame] | 68 | #include "net/test/test_data_directory.h" |
Gabriel Charette | c710874 | 2019-08-23 03:31:40 | [diff] [blame] | 69 | #include "net/test/test_with_task_environment.h" |
Victor Vasiliev | 27cc771 | 2019-01-24 11:50:14 | [diff] [blame] | 70 | #include "net/third_party/quiche/src/spdy/core/spdy_protocol.h" |
| 71 | #include "net/third_party/quiche/src/spdy/core/spdy_test_utils.h" |
rhalavati | 9ebaba7e | 2017-04-27 06:16:29 | [diff] [blame] | 72 | #include "net/traffic_annotation/network_traffic_annotation_test_helper.h" |
[email protected] | d2db029 | 2011-01-26 20:23:44 | [diff] [blame] | 73 | #include "net/url_request/url_request_test_util.h" |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 74 | #include "net/websockets/websocket_test_util.h" |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 75 | #include "testing/gmock/include/gmock/gmock.h" |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 76 | #include "testing/platform_test.h" |
Matt Menke | 4807a9a | 2020-11-21 00:14:41 | [diff] [blame] | 77 | #include "url/gurl.h" |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 78 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 79 | using net::test::IsError; |
| 80 | using net::test::IsOk; |
| 81 | |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 82 | //----------------------------------------------------------------------------- |
| 83 | |
[email protected] | d1eda93 | 2009-11-04 01:03:10 | [diff] [blame] | 84 | namespace net { |
[email protected] | dae22c5 | 2010-07-30 02:16:35 | [diff] [blame] | 85 | |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 86 | namespace { |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 87 | |
| 88 | using testing::Each; |
| 89 | using testing::Eq; |
| 90 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 91 | const int32_t kBufferSize = SpdyHttpStream::kRequestBodyBufferSize; |
| 92 | |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 93 | } // namespace |
| 94 | |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 95 | const char kPushedUrl[] = "https://www.example.org/foo.dat"; |
| 96 | |
Gabriel Charette | 694c3c33 | 2019-08-19 14:53:05 | [diff] [blame] | 97 | class SpdyNetworkTransactionTest : public TestWithTaskEnvironment { |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 98 | protected: |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 99 | SpdyNetworkTransactionTest() |
David Benjamin | bae08ba | 2019-10-18 21:06:15 | [diff] [blame] | 100 | : TestWithTaskEnvironment( |
| 101 | base::test::TaskEnvironment::TimeSource::MOCK_TIME), |
| 102 | default_url_(kDefaultUrl), |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 103 | host_port_pair_(HostPortPair::FromURL(default_url_)) {} |
[email protected] | 2d672869 | 2011-03-12 01:39:55 | [diff] [blame] | 104 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 105 | ~SpdyNetworkTransactionTest() override { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 106 | // UploadDataStream may post a deletion task back to the message loop on |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 107 | // destruction. |
| 108 | upload_data_stream_.reset(); |
| 109 | base::RunLoop().RunUntilIdle(); |
| 110 | } |
| 111 | |
dcheng | 67be2b1f | 2014-10-27 21:47:29 | [diff] [blame] | 112 | void SetUp() override { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 113 | request_.method = "GET"; |
| 114 | request_.url = GURL(kDefaultUrl); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 115 | request_.traffic_annotation = |
| 116 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 117 | ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 118 | } |
| 119 | |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 120 | struct TransactionHelperResult { |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 121 | int rv; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 122 | std::string status_line; |
| 123 | std::string response_data; |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 124 | HttpResponseInfo response_info; |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 125 | }; |
| 126 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 127 | // A helper class that handles all the initial npn/ssl setup. |
| 128 | class NormalSpdyTransactionHelper { |
| 129 | public: |
rdsmith | 82957ad | 2015-09-16 19:42:03 | [diff] [blame] | 130 | NormalSpdyTransactionHelper( |
| 131 | const HttpRequestInfo& request, |
| 132 | RequestPriority priority, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 133 | const NetLogWithSource& log, |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 134 | std::unique_ptr<SpdySessionDependencies> session_deps) |
[email protected] | 30c942b | 2010-07-21 16:59:59 | [diff] [blame] | 135 | : request_(request), |
[email protected] | 262eec8 | 2013-03-19 21:01:36 | [diff] [blame] | 136 | priority_(priority), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 137 | session_deps_(session_deps.get() == nullptr |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 138 | ? std::make_unique<SpdySessionDependencies>() |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 139 | : std::move(session_deps)), |
xunjieli | 92551953 | 2017-01-30 15:33:17 | [diff] [blame] | 140 | log_(log) { |
| 141 | session_deps_->net_log = log.net_log(); |
| 142 | session_ = |
| 143 | SpdySessionDependencies::SpdyCreateSession(session_deps_.get()); |
| 144 | } |
[email protected] | 61b4efc | 2012-04-27 18:12:50 | [diff] [blame] | 145 | |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 146 | ~NormalSpdyTransactionHelper() { |
| 147 | // Any test which doesn't close the socket by sending it an EOF will |
| 148 | // have a valid session left open, which leaks the entire session pool. |
| 149 | // This is just fine - in fact, some of our tests intentionally do this |
| 150 | // so that we can check consistency of the SpdySessionPool as the test |
| 151 | // finishes. If we had put an EOF on the socket, the SpdySession would |
| 152 | // have closed and we wouldn't be able to check the consistency. |
| 153 | |
| 154 | // Forcefully close existing sessions here. |
| 155 | session()->spdy_session_pool()->CloseAllSessions(); |
| 156 | } |
| 157 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 158 | void RunPreTestSetup() { |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 159 | // We're now ready to use SSL-npn SPDY. |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 160 | trans_ = |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 161 | std::make_unique<HttpNetworkTransaction>(priority_, session_.get()); |
[email protected] | cb54b3b2 | 2010-06-03 16:28:55 | [diff] [blame] | 162 | } |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 163 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 164 | // Start the transaction, read some data, finish. |
| 165 | void RunDefaultTest() { |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 166 | if (!StartDefaultTest()) |
| 167 | return; |
| 168 | FinishDefaultTest(); |
| 169 | } |
| 170 | |
| 171 | bool StartDefaultTest() { |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 172 | output_.rv = trans_->Start(&request_, callback_.callback(), log_); |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 173 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 174 | // We expect an IO Pending or some sort of error. |
| 175 | EXPECT_LT(output_.rv, 0); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 176 | return output_.rv == ERR_IO_PENDING; |
| 177 | } |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 178 | |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 179 | void FinishDefaultTest() { |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 180 | output_.rv = callback_.WaitForResult(); |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 181 | // Finish async network reads/writes. |
| 182 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 183 | if (output_.rv != OK) { |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 184 | session_->spdy_session_pool()->CloseCurrentSessions(ERR_ABORTED); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 185 | return; |
| 186 | } |
[email protected] | ff57bb8 | 2009-11-12 06:52:14 | [diff] [blame] | 187 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 188 | // Verify responses. |
| 189 | const HttpResponseInfo* response = trans_->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 190 | ASSERT_TRUE(response); |
| 191 | ASSERT_TRUE(response->headers); |
bnc | 80bb1d4 | 2016-10-26 18:11:34 | [diff] [blame] | 192 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
bnc | 927c496 | 2016-07-21 14:45:59 | [diff] [blame] | 193 | response->connection_info); |
| 194 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 195 | EXPECT_TRUE(response->was_fetched_via_spdy); |
bnc | 94c9284 | 2016-09-21 15:22:52 | [diff] [blame] | 196 | EXPECT_TRUE(response->was_alpn_negotiated); |
Tsuyoshi Horo | 01faed6 | 2019-02-20 22:11:37 | [diff] [blame] | 197 | EXPECT_EQ("127.0.0.1", response->remote_endpoint.ToStringWithoutPort()); |
| 198 | EXPECT_EQ(443, response->remote_endpoint.port()); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 199 | output_.status_line = response->headers->GetStatusLine(); |
| 200 | output_.response_info = *response; // Make a copy so we can verify. |
| 201 | output_.rv = ReadTransaction(trans_.get(), &output_.response_data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 202 | } |
| 203 | |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 204 | void FinishDefaultTestWithoutVerification() { |
| 205 | output_.rv = callback_.WaitForResult(); |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 206 | // Finish async network reads/writes. |
| 207 | base::RunLoop().RunUntilIdle(); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 208 | if (output_.rv != OK) |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 209 | session_->spdy_session_pool()->CloseCurrentSessions(ERR_ABORTED); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 210 | } |
| 211 | |
maksim.sisov | 8d2df66d | 2016-06-20 07:07:11 | [diff] [blame] | 212 | void WaitForCallbackToComplete() { output_.rv = callback_.WaitForResult(); } |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 213 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 214 | // Most tests will want to call this function. In particular, the MockReads |
| 215 | // should end with an empty read, and that read needs to be processed to |
| 216 | // ensure proper deletion of the spdy_session_pool. |
| 217 | void VerifyDataConsumed() { |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 218 | for (const SocketDataProvider* provider : data_vector_) { |
| 219 | EXPECT_TRUE(provider->AllReadDataConsumed()); |
| 220 | EXPECT_TRUE(provider->AllWriteDataConsumed()); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 221 | } |
| 222 | } |
| 223 | |
| 224 | // Occasionally a test will expect to error out before certain reads are |
| 225 | // processed. In that case we want to explicitly ensure that the reads were |
| 226 | // not processed. |
| 227 | void VerifyDataNotConsumed() { |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 228 | for (const SocketDataProvider* provider : data_vector_) { |
| 229 | EXPECT_FALSE(provider->AllReadDataConsumed()); |
| 230 | EXPECT_FALSE(provider->AllWriteDataConsumed()); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 231 | } |
| 232 | } |
| 233 | |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 234 | void RunToCompletion(SocketDataProvider* data) { |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 235 | RunPreTestSetup(); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 236 | AddData(data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 237 | RunDefaultTest(); |
| 238 | VerifyDataConsumed(); |
| 239 | } |
[email protected] | e6b0686 | 2010-07-20 16:32:58 | [diff] [blame] | 240 | |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 241 | void RunToCompletionWithSSLData( |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 242 | SocketDataProvider* data, |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 243 | std::unique_ptr<SSLSocketDataProvider> ssl_provider) { |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 244 | RunPreTestSetup(); |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 245 | AddDataWithSSLSocketDataProvider(data, std::move(ssl_provider)); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 246 | RunDefaultTest(); |
| 247 | VerifyDataConsumed(); |
| 248 | } |
| 249 | |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 250 | void AddData(SocketDataProvider* data) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 251 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 252 | ssl_provider->ssl_info.cert = |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 253 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 254 | AddDataWithSSLSocketDataProvider(data, std::move(ssl_provider)); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 255 | } |
| 256 | |
| 257 | void AddDataWithSSLSocketDataProvider( |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 258 | SocketDataProvider* data, |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 259 | std::unique_ptr<SSLSocketDataProvider> ssl_provider) { |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 260 | data_vector_.push_back(data); |
bnc | 3cf2a59 | 2016-08-11 14:48:36 | [diff] [blame] | 261 | if (ssl_provider->next_proto == kProtoUnknown) |
| 262 | ssl_provider->next_proto = kProtoHTTP2; |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 263 | |
| 264 | session_deps_->socket_factory->AddSSLSocketDataProvider( |
| 265 | ssl_provider.get()); |
olli.raula | ae011c42 | 2015-12-10 07:38:51 | [diff] [blame] | 266 | ssl_vector_.push_back(std::move(ssl_provider)); |
[email protected] | d4f0022 | 2012-07-10 06:24:51 | [diff] [blame] | 267 | |
[email protected] | 3b782843 | 2010-08-18 18:33:27 | [diff] [blame] | 268 | session_deps_->socket_factory->AddSocketDataProvider(data); |
| 269 | } |
| 270 | |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 271 | size_t GetSpdySessionCount() { |
| 272 | std::unique_ptr<base::Value> value( |
| 273 | session_->spdy_session_pool()->SpdySessionPoolInfoToValue()); |
| 274 | CHECK(value && value->is_list()); |
| 275 | return value->GetList().size(); |
| 276 | } |
| 277 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 278 | HttpNetworkTransaction* trans() { return trans_.get(); } |
| 279 | void ResetTrans() { trans_.reset(); } |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 280 | const TransactionHelperResult& output() { return output_; } |
mmenke | e65e7af | 2015-10-13 17:16:42 | [diff] [blame] | 281 | HttpNetworkSession* session() const { return session_.get(); } |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 282 | SpdySessionDependencies* session_deps() { return session_deps_.get(); } |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 283 | |
| 284 | private: |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 285 | typedef std::vector<SocketDataProvider*> DataVector; |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 286 | typedef std::vector<std::unique_ptr<SSLSocketDataProvider>> SSLVector; |
| 287 | typedef std::vector<std::unique_ptr<SocketDataProvider>> AlternateVector; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 288 | const HttpRequestInfo request_; |
| 289 | const RequestPriority priority_; |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 290 | std::unique_ptr<SpdySessionDependencies> session_deps_; |
| 291 | std::unique_ptr<HttpNetworkSession> session_; |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 292 | TransactionHelperResult output_; |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 293 | SSLVector ssl_vector_; |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 294 | TestCompletionCallback callback_; |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 295 | std::unique_ptr<HttpNetworkTransaction> trans_; |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 296 | DataVector data_vector_; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 297 | const NetLogWithSource log_; |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 298 | }; |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 299 | |
| 300 | void ConnectStatusHelperWithExpectedStatus(const MockRead& status, |
| 301 | int expected_status); |
| 302 | |
| 303 | void ConnectStatusHelper(const MockRead& status); |
[email protected] | d3cee19d | 2010-06-22 18:42:18 | [diff] [blame] | 304 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 305 | HttpRequestInfo CreateGetPushRequest() const WARN_UNUSED_RESULT { |
| 306 | HttpRequestInfo request; |
| 307 | request.method = "GET"; |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 308 | request.url = GURL(kPushedUrl); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 309 | request.traffic_annotation = |
| 310 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 311 | return request; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 312 | } |
| 313 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 314 | void UsePostRequest() { |
| 315 | ASSERT_FALSE(upload_data_stream_); |
| 316 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
| 317 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
| 318 | kUploadData, kUploadDataSize)); |
| 319 | upload_data_stream_ = std::make_unique<ElementsUploadDataStream>( |
| 320 | std::move(element_readers), 0); |
| 321 | |
| 322 | request_.method = "POST"; |
| 323 | request_.upload_data_stream = upload_data_stream_.get(); |
[email protected] | d3cee19d | 2010-06-22 18:42:18 | [diff] [blame] | 324 | } |
| 325 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 326 | void UseFilePostRequest() { |
| 327 | ASSERT_FALSE(upload_data_stream_); |
| 328 | base::FilePath file_path; |
| 329 | CHECK(base::CreateTemporaryFileInDir(temp_dir_.GetPath(), &file_path)); |
| 330 | CHECK_EQ(static_cast<int>(kUploadDataSize), |
| 331 | base::WriteFile(file_path, kUploadData, kUploadDataSize)); |
| 332 | |
| 333 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
| 334 | element_readers.push_back(std::make_unique<UploadFileElementReader>( |
| 335 | base::ThreadTaskRunnerHandle::Get().get(), file_path, 0, |
| 336 | kUploadDataSize, base::Time())); |
| 337 | upload_data_stream_ = std::make_unique<ElementsUploadDataStream>( |
| 338 | std::move(element_readers), 0); |
| 339 | |
| 340 | request_.method = "POST"; |
| 341 | request_.upload_data_stream = upload_data_stream_.get(); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 342 | request_.traffic_annotation = |
| 343 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
[email protected] | 3deb9a5 | 2010-11-11 00:24:40 | [diff] [blame] | 344 | } |
| 345 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 346 | void UseUnreadableFilePostRequest() { |
| 347 | ASSERT_FALSE(upload_data_stream_); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 348 | base::FilePath file_path; |
vabr | b858232 | 2016-09-09 08:05:37 | [diff] [blame] | 349 | CHECK(base::CreateTemporaryFileInDir(temp_dir_.GetPath(), &file_path)); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 350 | CHECK_EQ(static_cast<int>(kUploadDataSize), |
[email protected] | e5c2a22e | 2014-03-06 20:42:30 | [diff] [blame] | 351 | base::WriteFile(file_path, kUploadData, kUploadDataSize)); |
[email protected] | 92be8eb | 2014-08-07 22:57:11 | [diff] [blame] | 352 | CHECK(base::MakeFileUnreadable(file_path)); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 353 | |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 354 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 355 | element_readers.push_back(std::make_unique<UploadFileElementReader>( |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 356 | base::ThreadTaskRunnerHandle::Get().get(), file_path, 0, |
ricea | 2deef68 | 2016-09-09 08:04:07 | [diff] [blame] | 357 | kUploadDataSize, base::Time())); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 358 | upload_data_stream_ = std::make_unique<ElementsUploadDataStream>( |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 359 | std::move(element_readers), 0); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 360 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 361 | request_.method = "POST"; |
| 362 | request_.upload_data_stream = upload_data_stream_.get(); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 363 | } |
| 364 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 365 | void UseComplexPostRequest() { |
| 366 | ASSERT_FALSE(upload_data_stream_); |
| 367 | const int kFileRangeOffset = 1; |
| 368 | const int kFileRangeLength = 3; |
| 369 | CHECK_LT(kFileRangeOffset + kFileRangeLength, kUploadDataSize); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 370 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 371 | base::FilePath file_path; |
| 372 | CHECK(base::CreateTemporaryFileInDir(temp_dir_.GetPath(), &file_path)); |
| 373 | CHECK_EQ(static_cast<int>(kUploadDataSize), |
| 374 | base::WriteFile(file_path, kUploadData, kUploadDataSize)); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 375 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 376 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
| 377 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
| 378 | kUploadData, kFileRangeOffset)); |
| 379 | element_readers.push_back(std::make_unique<UploadFileElementReader>( |
| 380 | base::ThreadTaskRunnerHandle::Get().get(), file_path, kFileRangeOffset, |
| 381 | kFileRangeLength, base::Time())); |
| 382 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
| 383 | kUploadData + kFileRangeOffset + kFileRangeLength, |
| 384 | kUploadDataSize - (kFileRangeOffset + kFileRangeLength))); |
| 385 | upload_data_stream_ = std::make_unique<ElementsUploadDataStream>( |
| 386 | std::move(element_readers), 0); |
[email protected] | 329b68b | 2012-11-14 17:54:27 | [diff] [blame] | 387 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 388 | request_.method = "POST"; |
| 389 | request_.upload_data_stream = upload_data_stream_.get(); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 390 | } |
| 391 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 392 | void UseChunkedPostRequest() { |
| 393 | ASSERT_FALSE(upload_chunked_data_stream_); |
| 394 | upload_chunked_data_stream_ = std::make_unique<ChunkedUploadDataStream>(0); |
| 395 | request_.method = "POST"; |
| 396 | request_.upload_data_stream = upload_chunked_data_stream_.get(); |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 397 | } |
| 398 | |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 399 | // Read the result of a particular transaction, knowing that we've got |
| 400 | // multiple transactions in the read pipeline; so as we read, we may have |
| 401 | // to skip over data destined for other transactions while we consume |
| 402 | // the data for |trans|. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 403 | int ReadResult(HttpNetworkTransaction* trans, std::string* result) { |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 404 | const int kSize = 3000; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 405 | |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 406 | int bytes_read = 0; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 407 | scoped_refptr<IOBufferWithSize> buf = |
| 408 | base::MakeRefCounted<IOBufferWithSize>(kSize); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 409 | TestCompletionCallback callback; |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 410 | while (true) { |
[email protected] | 9049948 | 2013-06-01 00:39:50 | [diff] [blame] | 411 | int rv = trans->Read(buf.get(), kSize, callback.callback()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 412 | if (rv == ERR_IO_PENDING) { |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 413 | rv = callback.WaitForResult(); |
| 414 | } else if (rv <= 0) { |
| 415 | break; |
| 416 | } |
| 417 | result->append(buf->data(), rv); |
| 418 | bytes_read += rv; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 419 | } |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 420 | return bytes_read; |
| 421 | } |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 422 | |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 423 | void VerifyStreamsClosed(const NormalSpdyTransactionHelper& helper) { |
| 424 | // This lengthy block is reaching into the pool to dig out the active |
| 425 | // session. Once we have the session, we verify that the streams are |
| 426 | // all closed and not leaked at this point. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 427 | SpdySessionKey key(HostPortPair::FromURL(request_.url), |
Paul Jensen | a457017a | 2018-01-19 23:52:04 | [diff] [blame] | 428 | ProxyServer::Direct(), PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 429 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 430 | request_.network_isolation_key, SecureDnsPolicy::kAllow); |
mmenke | e65e7af | 2015-10-13 17:16:42 | [diff] [blame] | 431 | HttpNetworkSession* session = helper.session(); |
[email protected] | 795cbf8 | 2013-07-22 09:37:27 | [diff] [blame] | 432 | base::WeakPtr<SpdySession> spdy_session = |
bnc | 9ead3ae | 2017-03-16 00:48:15 | [diff] [blame] | 433 | session->spdy_session_pool()->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 434 | key, /* enable_ip_based_pooling = */ true, |
| 435 | /* is_websocket = */ false, log_); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 436 | ASSERT_TRUE(spdy_session); |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 437 | EXPECT_EQ(0u, num_active_streams(spdy_session)); |
| 438 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session)); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 439 | } |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 440 | |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 441 | void RunServerPushTest(SequencedSocketData* data, |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 442 | HttpResponseInfo* response, |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 443 | HttpResponseInfo* push_response, |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 444 | const std::string& expected) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 445 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 446 | nullptr); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 447 | helper.RunPreTestSetup(); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 448 | helper.AddData(data); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 449 | |
| 450 | HttpNetworkTransaction* trans = helper.trans(); |
| 451 | |
| 452 | // Start the transaction with basic parameters. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 453 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 454 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 455 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 456 | rv = callback.WaitForResult(); |
| 457 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 458 | // Finish async network reads/writes. |
| 459 | base::RunLoop().RunUntilIdle(); |
| 460 | |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 461 | // Request the pushed path. |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 462 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 463 | HttpRequestInfo request = CreateGetPushRequest(); |
| 464 | rv = trans2.Start(&request, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 465 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 466 | base::RunLoop().RunUntilIdle(); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 467 | |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 468 | // The data for the pushed path may be coming in more than 1 frame. Compile |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 469 | // the results into a single string. |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 470 | |
| 471 | // Read the server push body. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 472 | std::string result2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 473 | ReadResult(&trans2, &result2); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 474 | // Read the response body. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 475 | std::string result; |
rch | 0aecfd8 | 2015-05-19 17:22:32 | [diff] [blame] | 476 | ReadResult(trans, &result); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 477 | |
| 478 | // Verify that we consumed all test data. |
rch | 37de576c | 2015-05-17 20:28:17 | [diff] [blame] | 479 | EXPECT_TRUE(data->AllReadDataConsumed()); |
| 480 | EXPECT_TRUE(data->AllWriteDataConsumed()); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 481 | |
caseq | e8340bc9 | 2016-04-20 00:02:57 | [diff] [blame] | 482 | LoadTimingInfo load_timing_info; |
| 483 | EXPECT_TRUE(trans->GetLoadTimingInfo(&load_timing_info)); |
| 484 | EXPECT_TRUE(load_timing_info.push_start.is_null()); |
| 485 | EXPECT_TRUE(load_timing_info.push_end.is_null()); |
| 486 | |
| 487 | LoadTimingInfo load_timing_info2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 488 | EXPECT_TRUE(trans2.GetLoadTimingInfo(&load_timing_info2)); |
caseq | e8340bc9 | 2016-04-20 00:02:57 | [diff] [blame] | 489 | EXPECT_FALSE(load_timing_info2.push_start.is_null()); |
| 490 | EXPECT_FALSE(load_timing_info2.push_end.is_null()); |
| 491 | |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 492 | // Verify that the received push data is same as the expected push data. |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 493 | EXPECT_EQ(result2.compare(expected), 0) << "Received data: " |
| 494 | << result2 |
| 495 | << "||||| Expected data: " |
| 496 | << expected; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 497 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 498 | // Verify the response HEADERS. |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 499 | // Copy the response info, because trans goes away. |
| 500 | *response = *trans->GetResponseInfo(); |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 501 | *push_response = *trans2.GetResponseInfo(); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 502 | |
| 503 | VerifyStreamsClosed(helper); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 504 | } |
| 505 | |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 506 | void RunBrokenPushTest(SequencedSocketData* data, int expected_rv) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 507 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 508 | nullptr); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 509 | helper.RunPreTestSetup(); |
| 510 | helper.AddData(data); |
| 511 | |
| 512 | HttpNetworkTransaction* trans = helper.trans(); |
| 513 | |
| 514 | // Start the transaction with basic parameters. |
| 515 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 516 | int rv = trans->Start(&request_, callback.callback(), log_); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 517 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 518 | rv = callback.WaitForResult(); |
| 519 | EXPECT_EQ(expected_rv, rv); |
| 520 | |
| 521 | // Finish async network reads/writes. |
| 522 | base::RunLoop().RunUntilIdle(); |
| 523 | |
| 524 | // Verify that we consumed all test data. |
| 525 | EXPECT_TRUE(data->AllReadDataConsumed()); |
| 526 | EXPECT_TRUE(data->AllWriteDataConsumed()); |
| 527 | |
| 528 | if (expected_rv == OK) { |
| 529 | // Expected main request to succeed, even if push failed. |
| 530 | HttpResponseInfo response = *trans->GetResponseInfo(); |
| 531 | EXPECT_TRUE(response.headers); |
| 532 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
| 533 | } |
| 534 | } |
| 535 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 536 | static void DeleteSessionCallback(NormalSpdyTransactionHelper* helper, |
| 537 | int result) { |
| 538 | helper->ResetTrans(); |
| 539 | } |
| 540 | |
mmenke | e65e7af | 2015-10-13 17:16:42 | [diff] [blame] | 541 | static void StartTransactionCallback(HttpNetworkSession* session, |
| 542 | GURL url, |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 543 | NetLogWithSource log, |
mmenke | e65e7af | 2015-10-13 17:16:42 | [diff] [blame] | 544 | int result) { |
krasin | 0bfeb6b | 2017-01-13 21:48:04 | [diff] [blame] | 545 | HttpRequestInfo request; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 546 | HttpNetworkTransaction trans(DEFAULT_PRIORITY, session); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 547 | TestCompletionCallback callback; |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 548 | request.method = "GET"; |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 549 | request.url = url; |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 550 | request.traffic_annotation = |
| 551 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 552 | int rv = trans.Start(&request, callback.callback(), log); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 553 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 554 | callback.WaitForResult(); |
| 555 | } |
| 556 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 557 | ChunkedUploadDataStream* upload_chunked_data_stream() { |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 558 | return upload_chunked_data_stream_.get(); |
| 559 | } |
| 560 | |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 561 | size_t num_active_streams(base::WeakPtr<SpdySession> session) { |
| 562 | return session->active_streams_.size(); |
| 563 | } |
| 564 | |
Bence Béky | fd2c1fd | 2017-12-15 02:32:03 | [diff] [blame] | 565 | static size_t num_unclaimed_pushed_streams( |
| 566 | base::WeakPtr<SpdySession> session) { |
| 567 | return session->pool_->push_promise_index()->CountStreamsForSession( |
| 568 | session.get()); |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 569 | } |
| 570 | |
Bence Béky | fd2c1fd | 2017-12-15 02:32:03 | [diff] [blame] | 571 | static bool has_unclaimed_pushed_stream_for_url( |
| 572 | base::WeakPtr<SpdySession> session, |
| 573 | const GURL& url) { |
| 574 | return session->pool_->push_promise_index()->FindStream( |
| 575 | url, session.get()) != kNoPushedStreamFound; |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 576 | } |
| 577 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 578 | static spdy::SpdyStreamId spdy_stream_hi_water_mark( |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 579 | base::WeakPtr<SpdySession> session) { |
| 580 | return session->stream_hi_water_mark_; |
| 581 | } |
| 582 | |
David Benjamin | bae08ba | 2019-10-18 21:06:15 | [diff] [blame] | 583 | base::RepeatingClosure FastForwardByCallback(base::TimeDelta delta) { |
| 584 | return base::BindRepeating(&SpdyNetworkTransactionTest::FastForwardBy, |
| 585 | base::Unretained(this), delta); |
| 586 | } |
| 587 | |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 588 | const GURL default_url_; |
| 589 | const HostPortPair host_port_pair_; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 590 | HttpRequestInfo request_; |
[email protected] | 9ec54f8 | 2013-05-10 02:53:05 | [diff] [blame] | 591 | SpdyTestUtil spdy_util_; |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 592 | const NetLogWithSource log_; |
[email protected] | 9ec54f8 | 2013-05-10 02:53:05 | [diff] [blame] | 593 | |
[email protected] | d3cee19d | 2010-06-22 18:42:18 | [diff] [blame] | 594 | private: |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 595 | std::unique_ptr<ChunkedUploadDataStream> upload_chunked_data_stream_; |
| 596 | std::unique_ptr<UploadDataStream> upload_data_stream_; |
[email protected] | ea1a3f6 | 2012-11-16 20:34:23 | [diff] [blame] | 597 | base::ScopedTempDir temp_dir_; |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 598 | }; |
| 599 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 600 | // Verify HttpNetworkTransaction constructor. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 601 | TEST_F(SpdyNetworkTransactionTest, Constructor) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 602 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 603 | std::unique_ptr<HttpNetworkSession> session( |
[email protected] | bb88e1d3 | 2013-05-03 23:11:07 | [diff] [blame] | 604 | SpdySessionDependencies::SpdyCreateSession(session_deps.get())); |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 605 | auto trans = |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 606 | std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, session.get()); |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 607 | } |
| 608 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 609 | TEST_F(SpdyNetworkTransactionTest, Get) { |
[email protected] | 75f30cc2 | 2010-06-28 21:41:38 | [diff] [blame] | 610 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 611 | spdy::SpdySerializedFrame req( |
| 612 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 613 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 614 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 615 | spdy::SpdySerializedFrame resp( |
| 616 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 617 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 618 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 619 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 620 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 621 | }; |
| 622 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 623 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 624 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 625 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 626 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 627 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 628 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 629 | EXPECT_EQ("hello!", out.response_data); |
| 630 | } |
| 631 | |
Bence Béky | 2fcf4fa | 2018-04-06 20:06:01 | [diff] [blame] | 632 | TEST_F(SpdyNetworkTransactionTest, SetPriority) { |
| 633 | for (bool set_priority_before_starting_transaction : {true, false}) { |
| 634 | SpdyTestUtil spdy_test_util; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 635 | spdy::SpdySerializedFrame req( |
Bence Béky | 2fcf4fa | 2018-04-06 20:06:01 | [diff] [blame] | 636 | spdy_test_util.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 637 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 638 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 639 | spdy::SpdySerializedFrame resp( |
Bence Béky | 2fcf4fa | 2018-04-06 20:06:01 | [diff] [blame] | 640 | spdy_test_util.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 641 | spdy::SpdySerializedFrame body( |
| 642 | spdy_test_util.ConstructSpdyDataFrame(1, true)); |
Bence Béky | 2fcf4fa | 2018-04-06 20:06:01 | [diff] [blame] | 643 | MockRead reads[] = {CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 644 | MockRead(ASYNC, 0, 3)}; |
| 645 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 646 | SequencedSocketData data(reads, writes); |
Bence Béky | 2fcf4fa | 2018-04-06 20:06:01 | [diff] [blame] | 647 | NormalSpdyTransactionHelper helper(request_, HIGHEST, log_, nullptr); |
| 648 | helper.RunPreTestSetup(); |
| 649 | helper.AddData(&data); |
| 650 | |
| 651 | if (set_priority_before_starting_transaction) { |
| 652 | helper.trans()->SetPriority(LOWEST); |
| 653 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 654 | } else { |
| 655 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 656 | helper.trans()->SetPriority(LOWEST); |
| 657 | } |
| 658 | |
| 659 | helper.FinishDefaultTest(); |
| 660 | helper.VerifyDataConsumed(); |
| 661 | |
| 662 | TransactionHelperResult out = helper.output(); |
| 663 | EXPECT_THAT(out.rv, IsOk()); |
| 664 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 665 | EXPECT_EQ("hello!", out.response_data); |
| 666 | } |
| 667 | } |
| 668 | |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 669 | // Test that changing the request priority of an existing stream triggers |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 670 | // sending PRIORITY frames in case there are multiple open streams and their |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 671 | // relative priorities change. |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 672 | TEST_F(SpdyNetworkTransactionTest, SetPriorityOnExistingStream) { |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 673 | const char* kUrl2 = "https://www.example.org/bar"; |
| 674 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 675 | spdy::SpdySerializedFrame req1( |
| 676 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, HIGHEST)); |
| 677 | spdy::SpdySerializedFrame req2(spdy_util_.ConstructSpdyGet(kUrl2, 3, MEDIUM)); |
| 678 | spdy::SpdySerializedFrame priority1( |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 679 | spdy_util_.ConstructSpdyPriority(3, 0, MEDIUM, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 680 | spdy::SpdySerializedFrame priority2( |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 681 | spdy_util_.ConstructSpdyPriority(1, 3, LOWEST, true)); |
| 682 | MockWrite writes[] = {CreateMockWrite(req1, 0), CreateMockWrite(req2, 2), |
| 683 | CreateMockWrite(priority1, 4), |
| 684 | CreateMockWrite(priority2, 5)}; |
| 685 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 686 | spdy::SpdySerializedFrame resp1( |
| 687 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 688 | spdy::SpdySerializedFrame resp2( |
| 689 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 690 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 691 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 692 | MockRead reads[] = {CreateMockRead(resp1, 1), CreateMockRead(resp2, 3), |
| 693 | CreateMockRead(body1, 6), CreateMockRead(body2, 7), |
| 694 | MockRead(ASYNC, 0, 8)}; |
| 695 | |
| 696 | SequencedSocketData data(reads, writes); |
| 697 | NormalSpdyTransactionHelper helper(request_, HIGHEST, log_, nullptr); |
| 698 | helper.RunPreTestSetup(); |
| 699 | helper.AddData(&data); |
| 700 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 701 | |
| 702 | // Open HTTP/2 connection and create first stream. |
| 703 | base::RunLoop().RunUntilIdle(); |
| 704 | |
| 705 | HttpNetworkTransaction trans2(MEDIUM, helper.session()); |
| 706 | HttpRequestInfo request2; |
| 707 | request2.url = GURL(kUrl2); |
| 708 | request2.method = "GET"; |
| 709 | request2.traffic_annotation = |
| 710 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 711 | TestCompletionCallback callback2; |
| 712 | int rv = trans2.Start(&request2, callback2.callback(), log_); |
| 713 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 714 | |
| 715 | // Create second stream. |
| 716 | base::RunLoop().RunUntilIdle(); |
| 717 | |
| 718 | // First request has HIGHEST priority, second request has MEDIUM priority. |
| 719 | // Changing the priority of the first request to LOWEST changes their order, |
| 720 | // and therefore triggers sending PRIORITY frames. |
| 721 | helper.trans()->SetPriority(LOWEST); |
| 722 | |
| 723 | helper.FinishDefaultTest(); |
| 724 | helper.VerifyDataConsumed(); |
| 725 | |
| 726 | TransactionHelperResult out = helper.output(); |
| 727 | EXPECT_THAT(out.rv, IsOk()); |
| 728 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 729 | EXPECT_EQ("hello!", out.response_data); |
| 730 | |
| 731 | rv = callback2.WaitForResult(); |
| 732 | ASSERT_THAT(rv, IsOk()); |
| 733 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
| 734 | ASSERT_TRUE(response2); |
| 735 | ASSERT_TRUE(response2->headers); |
| 736 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 737 | response2->connection_info); |
| 738 | EXPECT_EQ("HTTP/1.1 200", response2->headers->GetStatusLine()); |
| 739 | } |
| 740 | |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 741 | // Create two requests: a lower priority one first, then a higher priority one. |
| 742 | // Test that the second request gets sent out first. |
| 743 | TEST_F(SpdyNetworkTransactionTest, RequestsOrderedByPriority) { |
| 744 | const char* kUrl2 = "https://www.example.org/foo"; |
| 745 | |
| 746 | // First send second request on stream 1, then first request on stream 3. |
| 747 | spdy::SpdySerializedFrame req2( |
| 748 | spdy_util_.ConstructSpdyGet(kUrl2, 1, HIGHEST)); |
| 749 | spdy::SpdySerializedFrame req1( |
| 750 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOW)); |
| 751 | MockWrite writes[] = {CreateMockWrite(req2, 0), CreateMockWrite(req1, 1)}; |
| 752 | |
| 753 | spdy::SpdySerializedFrame resp2( |
| 754 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 755 | spdy::SpdySerializedFrame resp1( |
| 756 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 757 | spdy::SpdySerializedFrame body2( |
| 758 | spdy_util_.ConstructSpdyDataFrame(1, "stream 1", true)); |
| 759 | spdy::SpdySerializedFrame body1( |
| 760 | spdy_util_.ConstructSpdyDataFrame(3, "stream 3", true)); |
| 761 | MockRead reads[] = {CreateMockRead(resp2, 2), CreateMockRead(body2, 3), |
| 762 | CreateMockRead(resp1, 4), CreateMockRead(body1, 5), |
| 763 | MockRead(ASYNC, 0, 6)}; |
| 764 | |
| 765 | SequencedSocketData data(reads, writes); |
| 766 | NormalSpdyTransactionHelper helper(request_, LOW, log_, nullptr); |
| 767 | helper.RunPreTestSetup(); |
| 768 | helper.AddData(&data); |
| 769 | |
| 770 | // Create HTTP/2 connection. This is necessary because starting the first |
| 771 | // transaction does not create the connection yet, so the second request |
| 772 | // could not use the same connection, whereas running the message loop after |
| 773 | // starting the first transaction would call Socket::Write() with the first |
| 774 | // HEADERS frame, so the second transaction could not get ahead of it. |
| 775 | SpdySessionKey key(HostPortPair("www.example.org", 443), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 776 | ProxyServer::Direct(), PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 777 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 778 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 779 | auto spdy_session = CreateSpdySession(helper.session(), key, log_); |
| 780 | EXPECT_TRUE(spdy_session); |
| 781 | |
| 782 | // Start first transaction. |
| 783 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 784 | |
| 785 | // Start second transaction. |
| 786 | HttpNetworkTransaction trans2(HIGHEST, helper.session()); |
| 787 | HttpRequestInfo request2; |
| 788 | request2.url = GURL(kUrl2); |
| 789 | request2.method = "GET"; |
| 790 | request2.traffic_annotation = |
| 791 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 792 | TestCompletionCallback callback2; |
| 793 | int rv = trans2.Start(&request2, callback2.callback(), log_); |
| 794 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 795 | |
| 796 | // Complete first transaction and verify results. |
| 797 | helper.FinishDefaultTest(); |
| 798 | helper.VerifyDataConsumed(); |
| 799 | |
| 800 | TransactionHelperResult out = helper.output(); |
| 801 | EXPECT_THAT(out.rv, IsOk()); |
| 802 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 803 | EXPECT_EQ("stream 3", out.response_data); |
| 804 | |
| 805 | // Complete second transaction and verify results. |
| 806 | rv = callback2.WaitForResult(); |
| 807 | ASSERT_THAT(rv, IsOk()); |
| 808 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
| 809 | ASSERT_TRUE(response2); |
| 810 | ASSERT_TRUE(response2->headers); |
| 811 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 812 | response2->connection_info); |
| 813 | EXPECT_EQ("HTTP/1.1 200", response2->headers->GetStatusLine()); |
| 814 | std::string response_data; |
| 815 | ReadTransaction(&trans2, &response_data); |
| 816 | EXPECT_EQ("stream 1", response_data); |
| 817 | } |
| 818 | |
| 819 | // Test that already enqueued HEADERS frames are reordered if their relative |
| 820 | // priority changes. |
| 821 | TEST_F(SpdyNetworkTransactionTest, QueuedFramesReorderedOnPriorityChange) { |
| 822 | const char* kUrl2 = "https://www.example.org/foo"; |
| 823 | const char* kUrl3 = "https://www.example.org/bar"; |
| 824 | |
| 825 | spdy::SpdySerializedFrame req1( |
| 826 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, DEFAULT_PRIORITY)); |
| 827 | spdy::SpdySerializedFrame req3(spdy_util_.ConstructSpdyGet(kUrl3, 3, MEDIUM)); |
| 828 | spdy::SpdySerializedFrame req2(spdy_util_.ConstructSpdyGet(kUrl2, 5, LOWEST)); |
| 829 | MockWrite writes[] = {MockWrite(ASYNC, ERR_IO_PENDING, 0), |
| 830 | CreateMockWrite(req1, 1), CreateMockWrite(req3, 2), |
| 831 | CreateMockWrite(req2, 3)}; |
| 832 | |
| 833 | spdy::SpdySerializedFrame resp1( |
| 834 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 835 | spdy::SpdySerializedFrame resp3( |
| 836 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 837 | spdy::SpdySerializedFrame resp2( |
| 838 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 5)); |
| 839 | spdy::SpdySerializedFrame body1( |
| 840 | spdy_util_.ConstructSpdyDataFrame(1, "stream 1", true)); |
| 841 | spdy::SpdySerializedFrame body3( |
| 842 | spdy_util_.ConstructSpdyDataFrame(3, "stream 3", true)); |
| 843 | spdy::SpdySerializedFrame body2( |
| 844 | spdy_util_.ConstructSpdyDataFrame(5, "stream 5", true)); |
| 845 | MockRead reads[] = {CreateMockRead(resp1, 4), CreateMockRead(body1, 5), |
| 846 | CreateMockRead(resp3, 6), CreateMockRead(body3, 7), |
| 847 | CreateMockRead(resp2, 8), CreateMockRead(body2, 9), |
| 848 | MockRead(ASYNC, 0, 10)}; |
| 849 | |
| 850 | SequencedSocketData data(reads, writes); |
| 851 | // Priority of first request does not matter, because Socket::Write() will be |
| 852 | // called with its HEADERS frame before the other requests start. |
| 853 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 854 | helper.RunPreTestSetup(); |
| 855 | helper.AddData(&data); |
| 856 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 857 | |
| 858 | // Open HTTP/2 connection, create HEADERS frame for first request, and call |
| 859 | // Socket::Write() with that frame. After this, no other request can get |
| 860 | // ahead of the first one. |
| 861 | base::RunLoop().RunUntilIdle(); |
| 862 | |
| 863 | HttpNetworkTransaction trans2(HIGHEST, helper.session()); |
| 864 | HttpRequestInfo request2; |
| 865 | request2.url = GURL(kUrl2); |
| 866 | request2.method = "GET"; |
| 867 | request2.traffic_annotation = |
| 868 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 869 | TestCompletionCallback callback2; |
| 870 | int rv = trans2.Start(&request2, callback2.callback(), log_); |
| 871 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 872 | |
| 873 | HttpNetworkTransaction trans3(MEDIUM, helper.session()); |
| 874 | HttpRequestInfo request3; |
| 875 | request3.url = GURL(kUrl3); |
| 876 | request3.method = "GET"; |
| 877 | request3.traffic_annotation = |
| 878 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 879 | TestCompletionCallback callback3; |
| 880 | rv = trans3.Start(&request3, callback3.callback(), log_); |
| 881 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 882 | |
| 883 | // Create HEADERS frames for second and third request and enqueue them in |
| 884 | // SpdyWriteQueue with their original priorities. Writing of the first |
| 885 | // HEADERS frame to the socked still has not completed. |
| 886 | base::RunLoop().RunUntilIdle(); |
| 887 | |
| 888 | // Second request is of HIGHEST, third of MEDIUM priority. Changing second |
| 889 | // request to LOWEST changes their relative order. This should result in |
| 890 | // already enqueued frames being reordered within SpdyWriteQueue. |
| 891 | trans2.SetPriority(LOWEST); |
| 892 | |
| 893 | // Complete async write of the first HEADERS frame. |
| 894 | data.Resume(); |
| 895 | |
| 896 | helper.FinishDefaultTest(); |
| 897 | TransactionHelperResult out = helper.output(); |
| 898 | EXPECT_THAT(out.rv, IsOk()); |
| 899 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 900 | EXPECT_EQ("stream 1", out.response_data); |
| 901 | |
| 902 | rv = callback2.WaitForResult(); |
| 903 | ASSERT_THAT(rv, IsOk()); |
| 904 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
| 905 | ASSERT_TRUE(response2); |
| 906 | ASSERT_TRUE(response2->headers); |
| 907 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 908 | response2->connection_info); |
| 909 | EXPECT_EQ("HTTP/1.1 200", response2->headers->GetStatusLine()); |
| 910 | std::string response_data; |
| 911 | ReadTransaction(&trans2, &response_data); |
| 912 | EXPECT_EQ("stream 5", response_data); |
| 913 | |
| 914 | rv = callback3.WaitForResult(); |
| 915 | ASSERT_THAT(rv, IsOk()); |
| 916 | const HttpResponseInfo* response3 = trans3.GetResponseInfo(); |
| 917 | ASSERT_TRUE(response3); |
| 918 | ASSERT_TRUE(response3->headers); |
| 919 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 920 | response3->connection_info); |
| 921 | EXPECT_EQ("HTTP/1.1 200", response3->headers->GetStatusLine()); |
| 922 | ReadTransaction(&trans3, &response_data); |
| 923 | EXPECT_EQ("stream 3", response_data); |
| 924 | |
| 925 | helper.VerifyDataConsumed(); |
| 926 | } |
| 927 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 928 | TEST_F(SpdyNetworkTransactionTest, GetAtEachPriority) { |
[email protected] | 3d08dd38 | 2013-10-19 00:13:11 | [diff] [blame] | 929 | for (RequestPriority p = MINIMUM_PRIORITY; p <= MAXIMUM_PRIORITY; |
[email protected] | 31ae7ab | 2012-04-24 21:09:05 | [diff] [blame] | 930 | p = RequestPriority(p + 1)) { |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 931 | SpdyTestUtil spdy_test_util; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 932 | |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 933 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 934 | spdy::SpdySerializedFrame req( |
| 935 | spdy_test_util.ConstructSpdyGet(nullptr, 0, 1, p)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 936 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 937 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 938 | spdy::SpdyPriority spdy_prio = 0; |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 939 | EXPECT_TRUE(GetSpdyPriority(req, &spdy_prio)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 940 | // this repeats the RequestPriority-->spdy::SpdyPriority mapping from |
| 941 | // spdy::SpdyFramer::ConvertRequestPriorityToSpdyPriority to make |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 942 | // sure it's being done right. |
bnc | 05808ff4 | 2016-01-08 23:48:25 | [diff] [blame] | 943 | switch (p) { |
| 944 | case HIGHEST: |
| 945 | EXPECT_EQ(0, spdy_prio); |
| 946 | break; |
| 947 | case MEDIUM: |
| 948 | EXPECT_EQ(1, spdy_prio); |
| 949 | break; |
| 950 | case LOW: |
| 951 | EXPECT_EQ(2, spdy_prio); |
| 952 | break; |
| 953 | case LOWEST: |
| 954 | EXPECT_EQ(3, spdy_prio); |
| 955 | break; |
| 956 | case IDLE: |
| 957 | EXPECT_EQ(4, spdy_prio); |
| 958 | break; |
rdsmith | 5eb6fbc | 2016-10-21 17:36:08 | [diff] [blame] | 959 | case THROTTLED: |
| 960 | EXPECT_EQ(5, spdy_prio); |
| 961 | break; |
bnc | 05808ff4 | 2016-01-08 23:48:25 | [diff] [blame] | 962 | default: |
| 963 | FAIL(); |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 964 | } |
| 965 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 966 | spdy::SpdySerializedFrame resp( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 967 | spdy_test_util.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 968 | spdy::SpdySerializedFrame body( |
| 969 | spdy_test_util.ConstructSpdyDataFrame(1, true)); |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 970 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 971 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 972 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 973 | }; |
| 974 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 975 | SequencedSocketData data(reads, writes); |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 976 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 977 | NormalSpdyTransactionHelper helper(request_, p, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 978 | helper.RunToCompletion(&data); |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 979 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 980 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 981 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 982 | EXPECT_EQ("hello!", out.response_data); |
| 983 | } |
| 984 | } |
| 985 | |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 986 | // Start three gets simultaniously; making sure that multiplexed |
| 987 | // streams work properly. |
| 988 | |
| 989 | // This can't use the TransactionHelper method, since it only |
| 990 | // handles a single transaction, and finishes them as soon |
| 991 | // as it launches them. |
| 992 | |
| 993 | // TODO(gavinp): create a working generalized TransactionHelper that |
| 994 | // can allow multiple streams in flight. |
| 995 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 996 | TEST_F(SpdyNetworkTransactionTest, ThreeGets) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 997 | spdy::SpdySerializedFrame req( |
| 998 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 999 | spdy::SpdySerializedFrame resp( |
| 1000 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1001 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1002 | spdy::SpdySerializedFrame fbody(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1003 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1004 | spdy::SpdySerializedFrame req2( |
| 1005 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 1006 | spdy::SpdySerializedFrame resp2( |
| 1007 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 1008 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, false)); |
| 1009 | spdy::SpdySerializedFrame fbody2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1010 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1011 | spdy::SpdySerializedFrame req3( |
| 1012 | spdy_util_.ConstructSpdyGet(nullptr, 0, 5, LOWEST)); |
| 1013 | spdy::SpdySerializedFrame resp3( |
| 1014 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 5)); |
| 1015 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame(5, false)); |
| 1016 | spdy::SpdySerializedFrame fbody3(spdy_util_.ConstructSpdyDataFrame(5, true)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1017 | |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1018 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1019 | CreateMockWrite(req, 0), CreateMockWrite(req2, 3), |
| 1020 | CreateMockWrite(req3, 6), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1021 | }; |
| 1022 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1023 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 1024 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 1025 | CreateMockRead(resp3, 7), CreateMockRead(body3, 8), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1026 | |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1027 | CreateMockRead(fbody, 9), CreateMockRead(fbody2, 10), |
| 1028 | CreateMockRead(fbody3, 11), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1029 | |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1030 | MockRead(ASYNC, 0, 12), // EOF |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1031 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1032 | SequencedSocketData data(reads, writes); |
| 1033 | SequencedSocketData data_placeholder1; |
| 1034 | SequencedSocketData data_placeholder2; |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1035 | |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1036 | TransactionHelperResult out; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1037 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1038 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1039 | helper.AddData(&data); |
rch | aeb3f05 | 2015-04-14 16:02:49 | [diff] [blame] | 1040 | // We require placeholder data because three get requests are sent out at |
| 1041 | // the same time which results in three sockets being connected. The first |
| 1042 | // on will negotiate SPDY and will be used for all requests. |
mmenke | cc2298e | 2015-12-07 18:20:18 | [diff] [blame] | 1043 | helper.AddData(&data_placeholder1); |
| 1044 | helper.AddData(&data_placeholder2); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1045 | TestCompletionCallback callback1; |
| 1046 | TestCompletionCallback callback2; |
| 1047 | TestCompletionCallback callback3; |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1048 | |
krasin | 0bfeb6b | 2017-01-13 21:48:04 | [diff] [blame] | 1049 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 1050 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 1051 | HttpNetworkTransaction trans3(DEFAULT_PRIORITY, helper.session()); |
| 1052 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1053 | out.rv = trans1.Start(&request_, callback1.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1054 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1055 | out.rv = trans2.Start(&request_, callback2.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1056 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1057 | out.rv = trans3.Start(&request_, callback3.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1058 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1059 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1060 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1061 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1062 | out.rv = callback3.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1063 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1064 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1065 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1066 | EXPECT_TRUE(response1->headers); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1067 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1068 | out.status_line = response1->headers->GetStatusLine(); |
| 1069 | out.response_info = *response1; |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1070 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1071 | trans2.GetResponseInfo(); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1072 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1073 | out.rv = ReadTransaction(&trans1, &out.response_data); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1074 | helper.VerifyDataConsumed(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1075 | EXPECT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1076 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1077 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1078 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1079 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1080 | } |
| 1081 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1082 | TEST_F(SpdyNetworkTransactionTest, TwoGetsLateBinding) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1083 | spdy::SpdySerializedFrame req( |
| 1084 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 1085 | spdy::SpdySerializedFrame resp( |
| 1086 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1087 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1088 | spdy::SpdySerializedFrame fbody(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1089 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1090 | spdy::SpdySerializedFrame req2( |
| 1091 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 1092 | spdy::SpdySerializedFrame resp2( |
| 1093 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 1094 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, false)); |
| 1095 | spdy::SpdySerializedFrame fbody2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1096 | |
| 1097 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1098 | CreateMockWrite(req, 0), CreateMockWrite(req2, 3), |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1099 | }; |
| 1100 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1101 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 1102 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 1103 | CreateMockRead(fbody, 6), CreateMockRead(fbody2, 7), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1104 | MockRead(ASYNC, 0, 8), // EOF |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1105 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1106 | SequencedSocketData data(reads, writes); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1107 | |
[email protected] | d973e99a | 2012-02-17 21:02:36 | [diff] [blame] | 1108 | MockConnect never_finishing_connect(SYNCHRONOUS, ERR_IO_PENDING); |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1109 | SequencedSocketData data_placeholder; |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1110 | data_placeholder.set_connect_data(never_finishing_connect); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1111 | |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1112 | TransactionHelperResult out; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1113 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1114 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1115 | helper.AddData(&data); |
rch | aeb3f05 | 2015-04-14 16:02:49 | [diff] [blame] | 1116 | // We require placeholder data because two requests are sent out at |
| 1117 | // the same time which results in two sockets being connected. The first |
| 1118 | // on will negotiate SPDY and will be used for all requests. |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1119 | helper.AddData(&data_placeholder); |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1120 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 1121 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1122 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1123 | TestCompletionCallback callback1; |
| 1124 | TestCompletionCallback callback2; |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1125 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1126 | out.rv = trans1.Start(&request_, callback1.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1127 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1128 | out.rv = trans2.Start(&request_, callback2.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1129 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1130 | |
| 1131 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1132 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1133 | out.rv = callback2.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1134 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1135 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1136 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1137 | EXPECT_TRUE(response1->headers); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1138 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1139 | out.status_line = response1->headers->GetStatusLine(); |
| 1140 | out.response_info = *response1; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1141 | out.rv = ReadTransaction(&trans1, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1142 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1143 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1144 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1145 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1146 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1147 | EXPECT_TRUE(response2->headers); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1148 | EXPECT_TRUE(response2->was_fetched_via_spdy); |
| 1149 | out.status_line = response2->headers->GetStatusLine(); |
| 1150 | out.response_info = *response2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1151 | out.rv = ReadTransaction(&trans2, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1152 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1153 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1154 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1155 | |
| 1156 | helper.VerifyDataConsumed(); |
| 1157 | } |
| 1158 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1159 | TEST_F(SpdyNetworkTransactionTest, TwoGetsLateBindingFromPreconnect) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1160 | spdy::SpdySerializedFrame req( |
| 1161 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 1162 | spdy::SpdySerializedFrame resp( |
| 1163 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1164 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1165 | spdy::SpdySerializedFrame fbody(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1166 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1167 | spdy::SpdySerializedFrame req2( |
| 1168 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 1169 | spdy::SpdySerializedFrame resp2( |
| 1170 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 1171 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, false)); |
| 1172 | spdy::SpdySerializedFrame fbody2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1173 | |
| 1174 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1175 | CreateMockWrite(req, 0), CreateMockWrite(req2, 3), |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1176 | }; |
| 1177 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1178 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 1179 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 1180 | CreateMockRead(fbody, 6), CreateMockRead(fbody2, 7), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1181 | MockRead(ASYNC, 0, 8), // EOF |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1182 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1183 | SequencedSocketData preconnect_data(reads, writes); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1184 | |
[email protected] | d973e99a | 2012-02-17 21:02:36 | [diff] [blame] | 1185 | MockConnect never_finishing_connect(ASYNC, ERR_IO_PENDING); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1186 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1187 | SequencedSocketData data_placeholder; |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1188 | data_placeholder.set_connect_data(never_finishing_connect); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1189 | |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1190 | TransactionHelperResult out; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1191 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1192 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1193 | helper.AddData(&preconnect_data); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1194 | // We require placeholder data because 3 connections are attempted (first is |
| 1195 | // the preconnect, 2nd and 3rd are the never finished connections. |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1196 | helper.AddData(&data_placeholder); |
| 1197 | helper.AddData(&data_placeholder); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1198 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1199 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 1200 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1201 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1202 | TestCompletionCallback callback1; |
| 1203 | TestCompletionCallback callback2; |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1204 | |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1205 | // Preconnect the first. |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1206 | HttpStreamFactory* http_stream_factory = |
| 1207 | helper.session()->http_stream_factory(); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1208 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1209 | http_stream_factory->PreconnectStreams(1, request_); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1210 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1211 | out.rv = trans1.Start(&request_, callback1.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1212 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1213 | out.rv = trans2.Start(&request_, callback2.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1214 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1215 | |
| 1216 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1217 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1218 | out.rv = callback2.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1219 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1220 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1221 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1222 | EXPECT_TRUE(response1->headers); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1223 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1224 | out.status_line = response1->headers->GetStatusLine(); |
| 1225 | out.response_info = *response1; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1226 | out.rv = ReadTransaction(&trans1, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1227 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1228 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1229 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1230 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1231 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1232 | EXPECT_TRUE(response2->headers); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1233 | EXPECT_TRUE(response2->was_fetched_via_spdy); |
| 1234 | out.status_line = response2->headers->GetStatusLine(); |
| 1235 | out.response_info = *response2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1236 | out.rv = ReadTransaction(&trans2, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1237 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1238 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 1b32317 | 2011-03-01 17:50:17 | [diff] [blame] | 1239 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1240 | |
| 1241 | helper.VerifyDataConsumed(); |
| 1242 | } |
| 1243 | |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1244 | // Similar to ThreeGets above, however this test adds a SETTINGS |
| 1245 | // frame. The SETTINGS frame is read during the IO loop waiting on |
| 1246 | // the first transaction completion, and sets a maximum concurrent |
| 1247 | // stream limit of 1. This means that our IO loop exists after the |
| 1248 | // second transaction completes, so we can assert on read_index(). |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1249 | TEST_F(SpdyNetworkTransactionTest, ThreeGetsWithMaxConcurrent) { |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1250 | // Construct the request. |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1251 | // Each request fully completes before the next starts. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1252 | spdy::SpdySerializedFrame req( |
| 1253 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 1254 | spdy::SpdySerializedFrame resp( |
| 1255 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1256 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1257 | spdy::SpdySerializedFrame fbody(spdy_util_.ConstructSpdyDataFrame(1, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1258 | spdy_util_.UpdateWithStreamDestruction(1); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1259 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1260 | spdy::SpdySerializedFrame req2( |
| 1261 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 1262 | spdy::SpdySerializedFrame resp2( |
| 1263 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 1264 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, false)); |
| 1265 | spdy::SpdySerializedFrame fbody2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1266 | spdy_util_.UpdateWithStreamDestruction(3); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1267 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1268 | spdy::SpdySerializedFrame req3( |
| 1269 | spdy_util_.ConstructSpdyGet(nullptr, 0, 5, LOWEST)); |
| 1270 | spdy::SpdySerializedFrame resp3( |
| 1271 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 5)); |
| 1272 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame(5, false)); |
| 1273 | spdy::SpdySerializedFrame fbody3(spdy_util_.ConstructSpdyDataFrame(5, true)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1274 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1275 | spdy::SettingsMap settings; |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 1276 | const uint32_t max_concurrent_streams = 1; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1277 | settings[spdy::SETTINGS_MAX_CONCURRENT_STREAMS] = max_concurrent_streams; |
| 1278 | spdy::SpdySerializedFrame settings_frame( |
[email protected] | c10b2085 | 2013-05-15 21:29:20 | [diff] [blame] | 1279 | spdy_util_.ConstructSpdySettings(settings)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1280 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1281 | |
[email protected] | 2d672869 | 2011-03-12 01:39:55 | [diff] [blame] | 1282 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1283 | CreateMockWrite(req, 0), CreateMockWrite(settings_ack, 5), |
| 1284 | CreateMockWrite(req2, 6), CreateMockWrite(req3, 10), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1285 | }; |
[email protected] | 2d672869 | 2011-03-12 01:39:55 | [diff] [blame] | 1286 | |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1287 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1288 | CreateMockRead(settings_frame, 1), |
| 1289 | CreateMockRead(resp, 2), |
| 1290 | CreateMockRead(body, 3), |
| 1291 | CreateMockRead(fbody, 4), |
| 1292 | CreateMockRead(resp2, 7), |
| 1293 | CreateMockRead(body2, 8), |
| 1294 | CreateMockRead(fbody2, 9), |
| 1295 | CreateMockRead(resp3, 11), |
| 1296 | CreateMockRead(body3, 12), |
| 1297 | CreateMockRead(fbody3, 13), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1298 | |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1299 | MockRead(ASYNC, 0, 14), // EOF |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1300 | }; |
| 1301 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1302 | SequencedSocketData data(reads, writes); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1303 | |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1304 | TransactionHelperResult out; |
| 1305 | { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1306 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 1307 | nullptr); |
[email protected] | 2d672869 | 2011-03-12 01:39:55 | [diff] [blame] | 1308 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1309 | helper.AddData(&data); |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1310 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 1311 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 1312 | HttpNetworkTransaction trans3(DEFAULT_PRIORITY, helper.session()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1313 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1314 | TestCompletionCallback callback1; |
| 1315 | TestCompletionCallback callback2; |
| 1316 | TestCompletionCallback callback3; |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1317 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1318 | out.rv = trans1.Start(&request_, callback1.callback(), log_); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1319 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 1320 | // Run transaction 1 through quickly to force a read of our SETTINGS |
| 1321 | // frame. |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1322 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1323 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1324 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1325 | out.rv = trans2.Start(&request_, callback2.callback(), log_); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1326 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1327 | out.rv = trans3.Start(&request_, callback3.callback(), log_); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1328 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
| 1329 | out.rv = callback2.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1330 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1331 | |
| 1332 | out.rv = callback3.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1333 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1334 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1335 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1336 | ASSERT_TRUE(response1); |
| 1337 | EXPECT_TRUE(response1->headers); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1338 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1339 | out.status_line = response1->headers->GetStatusLine(); |
| 1340 | out.response_info = *response1; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1341 | out.rv = ReadTransaction(&trans1, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1342 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1343 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1344 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1345 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1346 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1347 | out.status_line = response2->headers->GetStatusLine(); |
| 1348 | out.response_info = *response2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1349 | out.rv = ReadTransaction(&trans2, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1350 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1351 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1352 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1353 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1354 | const HttpResponseInfo* response3 = trans3.GetResponseInfo(); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1355 | out.status_line = response3->headers->GetStatusLine(); |
| 1356 | out.response_info = *response3; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1357 | out.rv = ReadTransaction(&trans3, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1358 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1359 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1360 | EXPECT_EQ("hello!hello!", out.response_data); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1361 | |
| 1362 | helper.VerifyDataConsumed(); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1363 | } |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1364 | EXPECT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1365 | } |
| 1366 | |
| 1367 | // Similar to ThreeGetsWithMaxConcurrent above, however this test adds |
| 1368 | // a fourth transaction. The third and fourth transactions have |
| 1369 | // different data ("hello!" vs "hello!hello!") and because of the |
| 1370 | // user specified priority, we expect to see them inverted in |
| 1371 | // the response from the server. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1372 | TEST_F(SpdyNetworkTransactionTest, FourGetsWithMaxConcurrentPriority) { |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1373 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1374 | spdy::SpdySerializedFrame req( |
| 1375 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 1376 | spdy::SpdySerializedFrame resp( |
| 1377 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1378 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1379 | spdy::SpdySerializedFrame fbody(spdy_util_.ConstructSpdyDataFrame(1, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1380 | spdy_util_.UpdateWithStreamDestruction(1); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1381 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1382 | spdy::SpdySerializedFrame req2( |
| 1383 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 1384 | spdy::SpdySerializedFrame resp2( |
| 1385 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 1386 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, false)); |
| 1387 | spdy::SpdySerializedFrame fbody2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1388 | spdy_util_.UpdateWithStreamDestruction(3); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1389 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1390 | spdy::SpdySerializedFrame req4( |
| 1391 | spdy_util_.ConstructSpdyGet(nullptr, 0, 5, HIGHEST)); |
| 1392 | spdy::SpdySerializedFrame resp4( |
| 1393 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 5)); |
| 1394 | spdy::SpdySerializedFrame fbody4(spdy_util_.ConstructSpdyDataFrame(5, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1395 | spdy_util_.UpdateWithStreamDestruction(5); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1396 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1397 | spdy::SpdySerializedFrame req3( |
| 1398 | spdy_util_.ConstructSpdyGet(nullptr, 0, 7, LOWEST)); |
| 1399 | spdy::SpdySerializedFrame resp3( |
| 1400 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 7)); |
| 1401 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame(7, false)); |
| 1402 | spdy::SpdySerializedFrame fbody3(spdy_util_.ConstructSpdyDataFrame(7, true)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1403 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1404 | spdy::SettingsMap settings; |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 1405 | const uint32_t max_concurrent_streams = 1; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1406 | settings[spdy::SETTINGS_MAX_CONCURRENT_STREAMS] = max_concurrent_streams; |
| 1407 | spdy::SpdySerializedFrame settings_frame( |
[email protected] | c10b2085 | 2013-05-15 21:29:20 | [diff] [blame] | 1408 | spdy_util_.ConstructSpdySettings(settings)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1409 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1410 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1411 | CreateMockWrite(req, 0), CreateMockWrite(settings_ack, 5), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1412 | // By making these synchronous, it guarantees that they are not *started* |
| 1413 | // before their sequence number, which in turn verifies that only a single |
| 1414 | // request is in-flight at a time. |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1415 | CreateMockWrite(req2, 6, SYNCHRONOUS), |
| 1416 | CreateMockWrite(req4, 10, SYNCHRONOUS), |
| 1417 | CreateMockWrite(req3, 13, SYNCHRONOUS), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1418 | }; |
| 1419 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1420 | CreateMockRead(settings_frame, 1), |
| 1421 | CreateMockRead(resp, 2), |
| 1422 | CreateMockRead(body, 3), |
| 1423 | CreateMockRead(fbody, 4), |
| 1424 | CreateMockRead(resp2, 7), |
| 1425 | CreateMockRead(body2, 8), |
| 1426 | CreateMockRead(fbody2, 9), |
| 1427 | CreateMockRead(resp4, 11), |
| 1428 | CreateMockRead(fbody4, 12), |
| 1429 | CreateMockRead(resp3, 14), |
| 1430 | CreateMockRead(body3, 15), |
| 1431 | CreateMockRead(fbody3, 16), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1432 | |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1433 | MockRead(ASYNC, 0, 17), // EOF |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1434 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1435 | SequencedSocketData data(reads, writes); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1436 | TransactionHelperResult out; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1437 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1438 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1439 | helper.AddData(&data); |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1440 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1441 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 1442 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 1443 | HttpNetworkTransaction trans3(DEFAULT_PRIORITY, helper.session()); |
| 1444 | HttpNetworkTransaction trans4(HIGHEST, helper.session()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1445 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1446 | TestCompletionCallback callback1; |
| 1447 | TestCompletionCallback callback2; |
| 1448 | TestCompletionCallback callback3; |
| 1449 | TestCompletionCallback callback4; |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1450 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1451 | out.rv = trans1.Start(&request_, callback1.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1452 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
[email protected] | e0935cc | 2012-03-24 14:12:48 | [diff] [blame] | 1453 | // Run transaction 1 through quickly to force a read of our SETTINGS frame. |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1454 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1455 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1456 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 1457 | // Finish async network reads and writes associated with |trans1|. |
| 1458 | base::RunLoop().RunUntilIdle(); |
| 1459 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1460 | out.rv = trans2.Start(&request_, callback2.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1461 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1462 | out.rv = trans3.Start(&request_, callback3.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1463 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1464 | out.rv = trans4.Start(&request_, callback4.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1465 | ASSERT_THAT(out.rv, IsError(ERR_IO_PENDING)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1466 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1467 | out.rv = callback2.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1468 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1469 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1470 | out.rv = callback3.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1471 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1472 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1473 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1474 | EXPECT_TRUE(response1->headers); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1475 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1476 | out.status_line = response1->headers->GetStatusLine(); |
| 1477 | out.response_info = *response1; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1478 | out.rv = ReadTransaction(&trans1, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1479 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1480 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1481 | EXPECT_EQ("hello!hello!", out.response_data); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1482 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1483 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1484 | out.status_line = response2->headers->GetStatusLine(); |
| 1485 | out.response_info = *response2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1486 | out.rv = ReadTransaction(&trans2, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1487 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1488 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1489 | EXPECT_EQ("hello!hello!", out.response_data); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1490 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1491 | // notice: response3 gets two hellos, response4 gets one |
| 1492 | // hello, so we know dequeuing priority was respected. |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1493 | const HttpResponseInfo* response3 = trans3.GetResponseInfo(); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1494 | out.status_line = response3->headers->GetStatusLine(); |
| 1495 | out.response_info = *response3; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1496 | out.rv = ReadTransaction(&trans3, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1497 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1498 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1499 | EXPECT_EQ("hello!hello!", out.response_data); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1500 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1501 | out.rv = callback4.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1502 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1503 | const HttpResponseInfo* response4 = trans4.GetResponseInfo(); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1504 | out.status_line = response4->headers->GetStatusLine(); |
| 1505 | out.response_info = *response4; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 1506 | out.rv = ReadTransaction(&trans4, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1507 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1508 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1509 | EXPECT_EQ("hello!", out.response_data); |
| 1510 | helper.VerifyDataConsumed(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1511 | EXPECT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1512 | } |
| 1513 | |
| 1514 | // Similar to ThreeGetsMaxConcurrrent above, however, this test |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1515 | // deletes a session in the middle of the transaction to ensure |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1516 | // that we properly remove pendingcreatestream objects from |
| 1517 | // the spdy_session |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1518 | TEST_F(SpdyNetworkTransactionTest, ThreeGetsWithMaxConcurrentDelete) { |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1519 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1520 | spdy::SpdySerializedFrame req( |
| 1521 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 1522 | spdy::SpdySerializedFrame resp( |
| 1523 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1524 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1525 | spdy::SpdySerializedFrame fbody(spdy_util_.ConstructSpdyDataFrame(1, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1526 | spdy_util_.UpdateWithStreamDestruction(1); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1527 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1528 | spdy::SpdySerializedFrame req2( |
| 1529 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 1530 | spdy::SpdySerializedFrame resp2( |
| 1531 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 1532 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, false)); |
| 1533 | spdy::SpdySerializedFrame fbody2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1534 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1535 | spdy::SettingsMap settings; |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 1536 | const uint32_t max_concurrent_streams = 1; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1537 | settings[spdy::SETTINGS_MAX_CONCURRENT_STREAMS] = max_concurrent_streams; |
| 1538 | spdy::SpdySerializedFrame settings_frame( |
[email protected] | c10b2085 | 2013-05-15 21:29:20 | [diff] [blame] | 1539 | spdy_util_.ConstructSpdySettings(settings)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1540 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1541 | |
[email protected] | d4a77c1 | 2014-05-15 20:45:21 | [diff] [blame] | 1542 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1543 | CreateMockWrite(req, 0), CreateMockWrite(settings_ack, 5), |
| 1544 | CreateMockWrite(req2, 6), |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1545 | }; |
| 1546 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1547 | CreateMockRead(settings_frame, 1), CreateMockRead(resp, 2), |
| 1548 | CreateMockRead(body, 3), CreateMockRead(fbody, 4), |
| 1549 | CreateMockRead(resp2, 7), CreateMockRead(body2, 8), |
| 1550 | CreateMockRead(fbody2, 9), MockRead(ASYNC, 0, 10), // EOF |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1551 | }; |
| 1552 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1553 | SequencedSocketData data(reads, writes); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1554 | |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1555 | TransactionHelperResult out; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1556 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1557 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1558 | helper.AddData(&data); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 1559 | auto trans1 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 1560 | helper.session()); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 1561 | auto trans2 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 1562 | helper.session()); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 1563 | auto trans3 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 1564 | helper.session()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1565 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1566 | TestCompletionCallback callback1; |
| 1567 | TestCompletionCallback callback2; |
| 1568 | TestCompletionCallback callback3; |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1569 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1570 | out.rv = trans1->Start(&request_, callback1.callback(), log_); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1571 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
[email protected] | e0935cc | 2012-03-24 14:12:48 | [diff] [blame] | 1572 | // Run transaction 1 through quickly to force a read of our SETTINGS frame. |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1573 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1574 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1575 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1576 | out.rv = trans2->Start(&request_, callback2.callback(), log_); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1577 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1578 | out.rv = trans3->Start(&request_, callback3.callback(), log_); |
olli.raula | 7ca9cd1d | 2016-01-04 06:50:37 | [diff] [blame] | 1579 | trans3.reset(); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1580 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
| 1581 | out.rv = callback2.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1582 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1583 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1584 | const HttpResponseInfo* response1 = trans1->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1585 | ASSERT_TRUE(response1); |
| 1586 | EXPECT_TRUE(response1->headers); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1587 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1588 | out.status_line = response1->headers->GetStatusLine(); |
| 1589 | out.response_info = *response1; |
| 1590 | out.rv = ReadTransaction(trans1.get(), &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1591 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1592 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1593 | EXPECT_EQ("hello!hello!", out.response_data); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1594 | |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1595 | const HttpResponseInfo* response2 = trans2->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1596 | ASSERT_TRUE(response2); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1597 | out.status_line = response2->headers->GetStatusLine(); |
| 1598 | out.response_info = *response2; |
| 1599 | out.rv = ReadTransaction(trans2.get(), &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1600 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1601 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bdebd1b | 2010-08-09 20:18:08 | [diff] [blame] | 1602 | EXPECT_EQ("hello!hello!", out.response_data); |
| 1603 | helper.VerifyDataConsumed(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1604 | EXPECT_THAT(out.rv, IsOk()); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1605 | } |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1606 | |
[email protected] | 448d4ca5 | 2012-03-04 04:12:23 | [diff] [blame] | 1607 | namespace { |
| 1608 | |
Bence Béky | 8ddc249 | 2018-06-13 01:02:04 | [diff] [blame] | 1609 | // A helper class that will delete |transaction| on error when the callback is |
| 1610 | // invoked. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1611 | class KillerCallback : public TestCompletionCallbackBase { |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1612 | public: |
| 1613 | explicit KillerCallback(HttpNetworkTransaction* transaction) |
Bence Béky | 8ddc249 | 2018-06-13 01:02:04 | [diff] [blame] | 1614 | : transaction_(transaction) {} |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1615 | |
Chris Watkins | 61914cb | 2017-12-01 19:59:00 | [diff] [blame] | 1616 | ~KillerCallback() override = default; |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1617 | |
Bence Béky | 8ddc249 | 2018-06-13 01:02:04 | [diff] [blame] | 1618 | CompletionOnceCallback callback() { |
| 1619 | return base::BindOnce(&KillerCallback::OnComplete, base::Unretained(this)); |
| 1620 | } |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1621 | |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1622 | private: |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1623 | void OnComplete(int result) { |
| 1624 | if (result < 0) |
| 1625 | delete transaction_; |
| 1626 | |
| 1627 | SetResult(result); |
| 1628 | } |
| 1629 | |
Keishi Hattori | 0e45c02 | 2021-11-27 09:25:52 | [diff] [blame] | 1630 | raw_ptr<HttpNetworkTransaction> transaction_; |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1631 | }; |
| 1632 | |
[email protected] | 448d4ca5 | 2012-03-04 04:12:23 | [diff] [blame] | 1633 | } // namespace |
| 1634 | |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1635 | // Similar to ThreeGetsMaxConcurrrentDelete above, however, this test |
| 1636 | // closes the socket while we have a pending transaction waiting for |
| 1637 | // a pending stream creation. http://crbug.com/52901 |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1638 | TEST_F(SpdyNetworkTransactionTest, ThreeGetsWithMaxConcurrentSocketClose) { |
Matt Menke | 66e502a7 | 2019-04-15 13:34:38 | [diff] [blame] | 1639 | // Construct the request. Each stream uses a different priority to provide |
| 1640 | // more useful failure information if the requests are made in an unexpected |
| 1641 | // order. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1642 | spdy::SpdySerializedFrame req( |
Matt Menke | 66e502a7 | 2019-04-15 13:34:38 | [diff] [blame] | 1643 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, HIGHEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1644 | spdy::SpdySerializedFrame resp( |
| 1645 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1646 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1647 | spdy::SpdySerializedFrame fin_body( |
| 1648 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 1649 | spdy_util_.UpdateWithStreamDestruction(1); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1650 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1651 | spdy::SpdySerializedFrame req2( |
Matt Menke | 66e502a7 | 2019-04-15 13:34:38 | [diff] [blame] | 1652 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, MEDIUM)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1653 | spdy::SpdySerializedFrame resp2( |
| 1654 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1655 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1656 | spdy::SettingsMap settings; |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 1657 | const uint32_t max_concurrent_streams = 1; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1658 | settings[spdy::SETTINGS_MAX_CONCURRENT_STREAMS] = max_concurrent_streams; |
| 1659 | spdy::SpdySerializedFrame settings_frame( |
[email protected] | c10b2085 | 2013-05-15 21:29:20 | [diff] [blame] | 1660 | spdy_util_.ConstructSpdySettings(settings)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1661 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1662 | |
Matt Menke | 66e502a7 | 2019-04-15 13:34:38 | [diff] [blame] | 1663 | MockWrite writes[] = {CreateMockWrite(req, 0), |
| 1664 | CreateMockWrite(settings_ack, 6), |
| 1665 | CreateMockWrite(req2, 7)}; |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1666 | MockRead reads[] = { |
Matt Menke | 66e502a7 | 2019-04-15 13:34:38 | [diff] [blame] | 1667 | CreateMockRead(settings_frame, 1), CreateMockRead(resp, 2), |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1668 | CreateMockRead(body, 3), |
Matt Menke | 66e502a7 | 2019-04-15 13:34:38 | [diff] [blame] | 1669 | // Delay the request here. For this test to pass, the three HTTP streams |
| 1670 | // have to be created in order, but SpdySession doesn't actually guarantee |
| 1671 | // that (See note in SpdySession::ProcessPendingStreamRequests). As a |
| 1672 | // workaround, delay finishing up the first stream until the second and |
| 1673 | // third streams are waiting in the SPDY stream request queue. |
| 1674 | MockRead(ASYNC, ERR_IO_PENDING, 4), CreateMockRead(fin_body, 5), |
| 1675 | CreateMockRead(resp2, 8), |
David Benjamin | 73dc524 | 2019-05-15 21:59:28 | [diff] [blame] | 1676 | // The exact error does not matter, but some errors, such as |
| 1677 | // ERR_CONNECTION_RESET, may trigger a retry, which this test does not |
| 1678 | // account for. |
| 1679 | MockRead(ASYNC, ERR_SSL_BAD_RECORD_MAC_ALERT, 9), // Abort! |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1680 | }; |
| 1681 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1682 | SequencedSocketData data(reads, writes); |
| 1683 | SequencedSocketData data_placeholder; |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1684 | |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1685 | TransactionHelperResult out; |
Matt Menke | 66e502a7 | 2019-04-15 13:34:38 | [diff] [blame] | 1686 | NormalSpdyTransactionHelper helper(request_, HIGHEST, log_, nullptr); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1687 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1688 | helper.AddData(&data); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1689 | // We require placeholder data because three get requests are sent out, so |
| 1690 | // there needs to be three sets of SSL connection data. |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1691 | helper.AddData(&data_placeholder); |
| 1692 | helper.AddData(&data_placeholder); |
Matt Menke | 66e502a7 | 2019-04-15 13:34:38 | [diff] [blame] | 1693 | HttpNetworkTransaction trans1(HIGHEST, helper.session()); |
| 1694 | HttpNetworkTransaction trans2(MEDIUM, helper.session()); |
[email protected] | 262eec8 | 2013-03-19 21:01:36 | [diff] [blame] | 1695 | HttpNetworkTransaction* trans3( |
mmenke | e65e7af | 2015-10-13 17:16:42 | [diff] [blame] | 1696 | new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session())); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1697 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 1698 | TestCompletionCallback callback1; |
| 1699 | TestCompletionCallback callback2; |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1700 | KillerCallback callback3(trans3); |
| 1701 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1702 | out.rv = trans1.Start(&request_, callback1.callback(), log_); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1703 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
[email protected] | e0935cc | 2012-03-24 14:12:48 | [diff] [blame] | 1704 | // Run transaction 1 through quickly to force a read of our SETTINGS frame. |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1705 | out.rv = callback1.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1706 | ASSERT_THAT(out.rv, IsOk()); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1707 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1708 | out.rv = trans2.Start(&request_, callback2.callback(), log_); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1709 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1710 | out.rv = trans3->Start(&request_, callback3.callback(), log_); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1711 | ASSERT_EQ(out.rv, ERR_IO_PENDING); |
Matt Menke | 66e502a7 | 2019-04-15 13:34:38 | [diff] [blame] | 1712 | |
| 1713 | // Run until both transactions are in the SpdySession's queue, waiting for the |
| 1714 | // final request to complete. |
| 1715 | base::RunLoop().RunUntilIdle(); |
| 1716 | data.Resume(); |
| 1717 | |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1718 | out.rv = callback3.WaitForResult(); |
David Benjamin | 73dc524 | 2019-05-15 21:59:28 | [diff] [blame] | 1719 | EXPECT_THAT(out.rv, IsError(ERR_SSL_BAD_RECORD_MAC_ALERT)); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1720 | |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1721 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1722 | ASSERT_TRUE(response1); |
| 1723 | EXPECT_TRUE(response1->headers); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1724 | EXPECT_TRUE(response1->was_fetched_via_spdy); |
| 1725 | out.status_line = response1->headers->GetStatusLine(); |
| 1726 | out.response_info = *response1; |
| 1727 | out.rv = ReadTransaction(&trans1, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1728 | EXPECT_THAT(out.rv, IsOk()); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1729 | |
| 1730 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 1731 | ASSERT_TRUE(response2); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1732 | out.status_line = response2->headers->GetStatusLine(); |
| 1733 | out.response_info = *response2; |
| 1734 | out.rv = ReadTransaction(&trans2, &out.response_data); |
David Benjamin | 73dc524 | 2019-05-15 21:59:28 | [diff] [blame] | 1735 | EXPECT_THAT(out.rv, IsError(ERR_SSL_BAD_RECORD_MAC_ALERT)); |
[email protected] | 044dcc5 | 2010-09-17 15:44:26 | [diff] [blame] | 1736 | |
| 1737 | helper.VerifyDataConsumed(); |
[email protected] | 2bd9302 | 2010-07-17 00:58:44 | [diff] [blame] | 1738 | } |
| 1739 | |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1740 | // Test that a simple PUT request works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1741 | TEST_F(SpdyNetworkTransactionTest, Put) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1742 | // Setup the request. |
| 1743 | request_.method = "PUT"; |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1744 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1745 | spdy::Http2HeaderBlock put_headers( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 1746 | spdy_util_.ConstructPutHeaderBlock(kDefaultUrl, 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1747 | spdy::SpdySerializedFrame req( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 1748 | spdy_util_.ConstructSpdyHeaders(1, std::move(put_headers), LOWEST, true)); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1749 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1750 | CreateMockWrite(req, 0), |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1751 | }; |
| 1752 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1753 | spdy::SpdySerializedFrame resp( |
| 1754 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1755 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1756 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1757 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1758 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1759 | }; |
| 1760 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1761 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1762 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1763 | helper.RunToCompletion(&data); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1764 | TransactionHelperResult out = helper.output(); |
| 1765 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1766 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1767 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1768 | } |
| 1769 | |
| 1770 | // Test that a simple HEAD request works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1771 | TEST_F(SpdyNetworkTransactionTest, Head) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1772 | // Setup the request. |
| 1773 | request_.method = "HEAD"; |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1774 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1775 | spdy::Http2HeaderBlock head_headers( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 1776 | spdy_util_.ConstructHeadHeaderBlock(kDefaultUrl, 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1777 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyHeaders( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 1778 | 1, std::move(head_headers), LOWEST, true)); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1779 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1780 | CreateMockWrite(req, 0), |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1781 | }; |
| 1782 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1783 | spdy::SpdySerializedFrame resp( |
| 1784 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 1785 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1786 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1787 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1788 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1789 | }; |
| 1790 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1791 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1792 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1793 | helper.RunToCompletion(&data); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1794 | TransactionHelperResult out = helper.output(); |
| 1795 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1796 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1797 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | d8ef27b | 2010-08-06 17:34:39 | [diff] [blame] | 1798 | } |
| 1799 | |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 1800 | // Test that a simple POST works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1801 | TEST_F(SpdyNetworkTransactionTest, Post) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1802 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 1803 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1804 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | ff57bb8 | 2009-11-12 06:52:14 | [diff] [blame] | 1805 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1806 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), // POST upload frame |
[email protected] | ff57bb8 | 2009-11-12 06:52:14 | [diff] [blame] | 1807 | }; |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 1808 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1809 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | ff57bb8 | 2009-11-12 06:52:14 | [diff] [blame] | 1810 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1811 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1812 | MockRead(ASYNC, 0, 4) // EOF |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 1813 | }; |
| 1814 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1815 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1816 | UsePostRequest(); |
| 1817 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1818 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 1819 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1820 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1821 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 1822 | EXPECT_EQ("hello!", out.response_data); |
| 1823 | } |
| 1824 | |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1825 | // Test that a POST with a file works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1826 | TEST_F(SpdyNetworkTransactionTest, FilePost) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1827 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 1828 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1829 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1830 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1831 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), // POST upload frame |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1832 | }; |
| 1833 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1834 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1835 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1836 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1837 | MockRead(ASYNC, 0, 4) // EOF |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1838 | }; |
| 1839 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1840 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1841 | UseFilePostRequest(); |
| 1842 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1843 | helper.RunToCompletion(&data); |
| 1844 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1845 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1846 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1847 | EXPECT_EQ("hello!", out.response_data); |
| 1848 | } |
| 1849 | |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 1850 | // Test that a POST with a unreadable file fails. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1851 | TEST_F(SpdyNetworkTransactionTest, UnreadableFilePost) { |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 1852 | MockWrite writes[] = { |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1853 | MockWrite(ASYNC, 0, 0) // EOF |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 1854 | }; |
| 1855 | MockRead reads[] = { |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1856 | MockRead(ASYNC, 0, 1) // EOF |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 1857 | }; |
| 1858 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1859 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1860 | UseUnreadableFilePostRequest(); |
| 1861 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 1862 | helper.RunPreTestSetup(); |
| 1863 | helper.AddData(&data); |
| 1864 | helper.RunDefaultTest(); |
| 1865 | |
| 1866 | base::RunLoop().RunUntilIdle(); |
| 1867 | helper.VerifyDataNotConsumed(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1868 | EXPECT_THAT(helper.output().rv, IsError(ERR_ACCESS_DENIED)); |
[email protected] | 999dd8c | 2013-11-12 06:45:54 | [diff] [blame] | 1869 | } |
| 1870 | |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1871 | // Test that a complex POST works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1872 | TEST_F(SpdyNetworkTransactionTest, ComplexPost) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1873 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 1874 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1875 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1876 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1877 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), // POST upload frame |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1878 | }; |
| 1879 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1880 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1881 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1882 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1883 | MockRead(ASYNC, 0, 4) // EOF |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1884 | }; |
| 1885 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1886 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1887 | UseComplexPostRequest(); |
| 1888 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1889 | helper.RunToCompletion(&data); |
| 1890 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1891 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1892 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 69e6b4a | 2012-10-18 08:03:01 | [diff] [blame] | 1893 | EXPECT_EQ("hello!", out.response_data); |
| 1894 | } |
| 1895 | |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1896 | // Test that a chunked POST works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1897 | TEST_F(SpdyNetworkTransactionTest, ChunkedPost) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1898 | spdy::SpdySerializedFrame req( |
| 1899 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
| 1900 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1901 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1902 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1903 | }; |
| 1904 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1905 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1906 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1907 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1908 | MockRead(ASYNC, 0, 4) // EOF |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1909 | }; |
| 1910 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1911 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1912 | UseChunkedPostRequest(); |
| 1913 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1914 | |
| 1915 | // These chunks get merged into a single frame when being sent. |
| 1916 | const int kFirstChunkSize = kUploadDataSize/2; |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 1917 | upload_chunked_data_stream()->AppendData(kUploadData, kFirstChunkSize, false); |
| 1918 | upload_chunked_data_stream()->AppendData( |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1919 | kUploadData + kFirstChunkSize, kUploadDataSize - kFirstChunkSize, true); |
| 1920 | |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 1921 | helper.RunToCompletion(&data); |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1922 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1923 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1924 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1925 | EXPECT_EQ(kUploadData, out.response_data); |
| 1926 | } |
| 1927 | |
| 1928 | // Test that a chunked POST works with chunks appended after transaction starts. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1929 | TEST_F(SpdyNetworkTransactionTest, DelayedChunkedPost) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1930 | spdy::SpdySerializedFrame req( |
| 1931 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
| 1932 | spdy::SpdySerializedFrame chunk1(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1933 | spdy::SpdySerializedFrame chunk2(spdy_util_.ConstructSpdyDataFrame(1, false)); |
| 1934 | spdy::SpdySerializedFrame chunk3(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1935 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1936 | CreateMockWrite(req, 0), CreateMockWrite(chunk1, 1), |
| 1937 | CreateMockWrite(chunk2, 2), CreateMockWrite(chunk3, 3), |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1938 | }; |
| 1939 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1940 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1941 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1942 | CreateMockRead(resp, 4), CreateMockRead(chunk1, 5), |
| 1943 | CreateMockRead(chunk2, 6), CreateMockRead(chunk3, 7), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1944 | MockRead(ASYNC, 0, 8) // EOF |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1945 | }; |
| 1946 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 1947 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1948 | UseChunkedPostRequest(); |
| 1949 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1950 | |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 1951 | upload_chunked_data_stream()->AppendData(kUploadData, kUploadDataSize, false); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1952 | |
| 1953 | helper.RunPreTestSetup(); |
| 1954 | helper.AddData(&data); |
| 1955 | ASSERT_TRUE(helper.StartDefaultTest()); |
| 1956 | |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 1957 | base::RunLoop().RunUntilIdle(); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 1958 | upload_chunked_data_stream()->AppendData(kUploadData, kUploadDataSize, false); |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 1959 | base::RunLoop().RunUntilIdle(); |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 1960 | upload_chunked_data_stream()->AppendData(kUploadData, kUploadDataSize, true); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1961 | |
| 1962 | helper.FinishDefaultTest(); |
| 1963 | helper.VerifyDataConsumed(); |
| 1964 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 1965 | std::string expected_response; |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1966 | expected_response += kUploadData; |
| 1967 | expected_response += kUploadData; |
| 1968 | expected_response += kUploadData; |
| 1969 | |
| 1970 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1971 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 1972 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 34b345f9 | 2013-02-22 03:27:26 | [diff] [blame] | 1973 | EXPECT_EQ(expected_response, out.response_data); |
[email protected] | 0c9bf87 | 2011-03-04 17:53:22 | [diff] [blame] | 1974 | } |
| 1975 | |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1976 | // Test that a POST without any post data works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 1977 | TEST_F(SpdyNetworkTransactionTest, NullPost) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1978 | // Setup the request. |
| 1979 | request_.method = "POST"; |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1980 | // Create an empty UploadData. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 1981 | request_.upload_data_stream = nullptr; |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1982 | |
[email protected] | 329b68b | 2012-11-14 17:54:27 | [diff] [blame] | 1983 | // When request.upload_data_stream is NULL for post, content-length is |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1984 | // expected to be 0. |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 1985 | spdy::Http2HeaderBlock req_block( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 1986 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1987 | spdy::SpdySerializedFrame req( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 1988 | spdy_util_.ConstructSpdyHeaders(1, std::move(req_block), LOWEST, true)); |
[email protected] | d2c1a97b | 2014-03-03 19:25:09 | [diff] [blame] | 1989 | |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1990 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1991 | CreateMockWrite(req, 0), |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1992 | }; |
| 1993 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 1994 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 1995 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1996 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 1997 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 1998 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 1999 | }; |
| 2000 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2001 | SequencedSocketData data(reads, writes); |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 2002 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2003 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2004 | helper.RunToCompletion(&data); |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 2005 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2006 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 2007 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | a33cad2b6 | 2010-07-30 22:24:39 | [diff] [blame] | 2008 | EXPECT_EQ("hello!", out.response_data); |
| 2009 | } |
| 2010 | |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 2011 | // Test that a simple POST works. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2012 | TEST_F(SpdyNetworkTransactionTest, EmptyPost) { |
[email protected] | 329b68b | 2012-11-14 17:54:27 | [diff] [blame] | 2013 | // Create an empty UploadDataStream. |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 2014 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
olli.raula | 6df48b2a | 2015-11-26 07:40:22 | [diff] [blame] | 2015 | ElementsUploadDataStream stream(std::move(element_readers), 0); |
[email protected] | 329b68b | 2012-11-14 17:54:27 | [diff] [blame] | 2016 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2017 | // Setup the request. |
| 2018 | request_.method = "POST"; |
| 2019 | request_.upload_data_stream = &stream; |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 2020 | |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 2021 | const uint64_t kContentLength = 0; |
[email protected] | d2c1a97b | 2014-03-03 19:25:09 | [diff] [blame] | 2022 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 2023 | spdy::Http2HeaderBlock req_block( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 2024 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, kContentLength)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2025 | spdy::SpdySerializedFrame req( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 2026 | spdy_util_.ConstructSpdyHeaders(1, std::move(req_block), LOWEST, true)); |
[email protected] | d2c1a97b | 2014-03-03 19:25:09 | [diff] [blame] | 2027 | |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 2028 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2029 | CreateMockWrite(req, 0), |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 2030 | }; |
| 2031 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2032 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 2033 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 2034 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2035 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 2036 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 2037 | }; |
| 2038 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2039 | SequencedSocketData data(reads, writes); |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 2040 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2041 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2042 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2043 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2044 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 2045 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | edd3b0a5 | 2009-11-24 18:56:36 | [diff] [blame] | 2046 | EXPECT_EQ("hello!", out.response_data); |
| 2047 | } |
| 2048 | |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2049 | // While we're doing a post, the server sends the reply before upload completes. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2050 | TEST_F(SpdyNetworkTransactionTest, ResponseBeforePostCompletes) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2051 | spdy::SpdySerializedFrame req( |
| 2052 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
| 2053 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2054 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2055 | CreateMockWrite(req, 0), CreateMockWrite(body, 3), |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2056 | }; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2057 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | a5566f970 | 2010-05-05 22:25:43 | [diff] [blame] | 2058 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2059 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 2060 | MockRead(ASYNC, 0, 4) // EOF |
[email protected] | a5566f970 | 2010-05-05 22:25:43 | [diff] [blame] | 2061 | }; |
| 2062 | |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2063 | // Write the request headers, and read the complete response |
| 2064 | // while still waiting for chunked request data. |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2065 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2066 | UseChunkedPostRequest(); |
| 2067 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | c92f4b454 | 2012-07-26 23:53:21 | [diff] [blame] | 2068 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 2069 | helper.AddData(&data); |
[email protected] | c92f4b454 | 2012-07-26 23:53:21 | [diff] [blame] | 2070 | |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2071 | ASSERT_TRUE(helper.StartDefaultTest()); |
[email protected] | c92f4b454 | 2012-07-26 23:53:21 | [diff] [blame] | 2072 | |
maksim.sisov | 8d2df66d | 2016-06-20 07:07:11 | [diff] [blame] | 2073 | base::RunLoop().RunUntilIdle(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 2074 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 2075 | // Process the request headers, response headers, and response body. |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2076 | // The request body is still in flight. |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2077 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 2078 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2079 | |
| 2080 | // Finish sending the request body. |
mmenke | cbc2b71 | 2014-10-09 20:29:07 | [diff] [blame] | 2081 | upload_chunked_data_stream()->AppendData(kUploadData, kUploadDataSize, true); |
maksim.sisov | 8d2df66d | 2016-06-20 07:07:11 | [diff] [blame] | 2082 | helper.WaitForCallbackToComplete(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2083 | EXPECT_THAT(helper.output().rv, IsOk()); |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2084 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 2085 | std::string response_body; |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2086 | EXPECT_THAT(ReadTransaction(helper.trans(), &response_body), IsOk()); |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2087 | EXPECT_EQ(kUploadData, response_body); |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 2088 | |
| 2089 | // Finish async network reads/writes. |
| 2090 | base::RunLoop().RunUntilIdle(); |
[email protected] | 35c3fc73 | 2014-02-15 00:16:07 | [diff] [blame] | 2091 | helper.VerifyDataConsumed(); |
[email protected] | a5566f970 | 2010-05-05 22:25:43 | [diff] [blame] | 2092 | } |
| 2093 | |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2094 | // The client upon cancellation tries to send a RST_STREAM frame. The mock |
| 2095 | // socket causes the TCP write to return zero. This test checks that the client |
| 2096 | // tries to queue up the RST_STREAM frame again. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2097 | TEST_F(SpdyNetworkTransactionTest, SocketWriteReturnsZero) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2098 | spdy::SpdySerializedFrame req( |
| 2099 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2100 | spdy::SpdySerializedFrame rst( |
| 2101 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_CANCEL)); |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2102 | MockWrite writes[] = { |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2103 | CreateMockWrite(req, 0, SYNCHRONOUS), |
| 2104 | MockWrite(SYNCHRONOUS, nullptr, 0, 2), |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2105 | CreateMockWrite(rst, 3, SYNCHRONOUS), |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2106 | }; |
| 2107 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2108 | spdy::SpdySerializedFrame resp( |
| 2109 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2110 | MockRead reads[] = { |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2111 | CreateMockRead(resp, 1, ASYNC), MockRead(ASYNC, nullptr, 0, 4) // EOF |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2112 | }; |
| 2113 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2114 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2115 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2116 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 2117 | helper.AddData(&data); |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 2118 | helper.StartDefaultTest(); |
| 2119 | EXPECT_THAT(helper.output().rv, IsError(ERR_IO_PENDING)); |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2120 | |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 2121 | helper.WaitForCallbackToComplete(); |
| 2122 | EXPECT_THAT(helper.output().rv, IsOk()); |
[email protected] | 3b782843 | 2010-08-18 18:33:27 | [diff] [blame] | 2123 | |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2124 | helper.ResetTrans(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 2125 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3b782843 | 2010-08-18 18:33:27 | [diff] [blame] | 2126 | |
[email protected] | f9a26d7 | 2010-08-03 18:07:13 | [diff] [blame] | 2127 | helper.VerifyDataConsumed(); |
| 2128 | } |
| 2129 | |
[email protected] | 9330067 | 2009-10-24 13:22:51 | [diff] [blame] | 2130 | // Test that the transaction doesn't crash when we don't have a reply. |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 2131 | TEST_F(SpdyNetworkTransactionTest, ResponseWithoutHeaders) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2132 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | ff57bb8 | 2009-11-12 06:52:14 | [diff] [blame] | 2133 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2134 | CreateMockRead(body, 1), MockRead(ASYNC, 0, 3) // EOF |
[email protected] | 9330067 | 2009-10-24 13:22:51 | [diff] [blame] | 2135 | }; |
| 2136 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2137 | spdy::SpdySerializedFrame req( |
| 2138 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2139 | spdy::SpdySerializedFrame rst( |
| 2140 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 2141 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2142 | CreateMockWrite(req, 0), CreateMockWrite(rst, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 2143 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2144 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2145 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2146 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2147 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 2148 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
[email protected] | 9330067 | 2009-10-24 13:22:51 | [diff] [blame] | 2149 | } |
| 2150 | |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2151 | // Test that the transaction doesn't crash when we get two replies on the same |
| 2152 | // stream ID. See http://crbug.com/45639. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2153 | TEST_F(SpdyNetworkTransactionTest, ResponseWithTwoSynReplies) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2154 | spdy::SpdySerializedFrame req( |
| 2155 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2156 | spdy::SpdySerializedFrame rst( |
| 2157 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
[email protected] | 2aeef78 | 2013-06-21 18:30:56 | [diff] [blame] | 2158 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2159 | CreateMockWrite(req, 0), CreateMockWrite(rst, 4), |
[email protected] | 2aeef78 | 2013-06-21 18:30:56 | [diff] [blame] | 2160 | }; |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2161 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2162 | spdy::SpdySerializedFrame resp0( |
| 2163 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2164 | spdy::SpdySerializedFrame resp1( |
| 2165 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2166 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2167 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2168 | CreateMockRead(resp0, 1), CreateMockRead(resp1, 2), |
| 2169 | CreateMockRead(body, 3), MockRead(ASYNC, 0, 5) // EOF |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2170 | }; |
| 2171 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2172 | SequencedSocketData data(reads, writes); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2173 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2174 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2175 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2176 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2177 | |
| 2178 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2179 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2180 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2181 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2182 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2183 | rv = callback.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2184 | EXPECT_THAT(rv, IsOk()); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2185 | |
| 2186 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 2187 | ASSERT_TRUE(response); |
| 2188 | EXPECT_TRUE(response->headers); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2189 | EXPECT_TRUE(response->was_fetched_via_spdy); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 2190 | std::string response_data; |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2191 | rv = ReadTransaction(trans, &response_data); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 2192 | EXPECT_THAT(rv, IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2193 | |
| 2194 | helper.VerifyDataConsumed(); |
[email protected] | d3002235 | 2010-06-24 19:17:58 | [diff] [blame] | 2195 | } |
| 2196 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2197 | TEST_F(SpdyNetworkTransactionTest, ResetReplyWithTransferEncoding) { |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2198 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2199 | spdy::SpdySerializedFrame req( |
| 2200 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2201 | spdy::SpdySerializedFrame rst( |
| 2202 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2203 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2204 | CreateMockWrite(req, 0), CreateMockWrite(rst, 2), |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2205 | }; |
| 2206 | |
| 2207 | const char* const headers[] = { |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 2208 | "transfer-encoding", "chunked" |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2209 | }; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2210 | spdy::SpdySerializedFrame resp( |
| 2211 | spdy_util_.ConstructSpdyGetReply(headers, 1, 1)); |
| 2212 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2213 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2214 | CreateMockRead(resp, 1), CreateMockRead(body, 3), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 2215 | MockRead(ASYNC, 0, 4) // EOF |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2216 | }; |
| 2217 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2218 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2219 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2220 | helper.RunToCompletion(&data); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2221 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 2222 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2223 | |
| 2224 | helper.session()->spdy_session_pool()->CloseAllSessions(); |
| 2225 | helper.VerifyDataConsumed(); |
| 2226 | } |
| 2227 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2228 | TEST_F(SpdyNetworkTransactionTest, ResetPushWithTransferEncoding) { |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2229 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2230 | spdy::SpdySerializedFrame req( |
| 2231 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2232 | spdy::SpdySerializedFrame priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2233 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2234 | spdy::SpdySerializedFrame rst( |
| 2235 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2236 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2237 | CreateMockWrite(req, 0), CreateMockWrite(priority, 3), |
| 2238 | CreateMockWrite(rst, 5), |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2239 | }; |
| 2240 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2241 | spdy::SpdySerializedFrame resp( |
| 2242 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 2243 | const char* const headers[] = { |
| 2244 | "transfer-encoding", "chunked" |
| 2245 | }; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2246 | spdy::SpdySerializedFrame push(spdy_util_.ConstructSpdyPush( |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 2247 | headers, base::size(headers) / 2, 2, 1, "https://www.example.org/1")); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2248 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2249 | MockRead reads[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2250 | CreateMockRead(resp, 1), CreateMockRead(push, 2), CreateMockRead(body, 4), |
| 2251 | MockRead(ASYNC, 0, 6) // EOF |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2252 | }; |
| 2253 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2254 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2255 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2256 | helper.RunToCompletion(&data); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2257 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2258 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 2259 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | b350300 | 2012-03-27 04:57:25 | [diff] [blame] | 2260 | EXPECT_EQ("hello!", out.response_data); |
| 2261 | |
| 2262 | helper.session()->spdy_session_pool()->CloseAllSessions(); |
| 2263 | helper.VerifyDataConsumed(); |
| 2264 | } |
| 2265 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2266 | TEST_F(SpdyNetworkTransactionTest, CancelledTransaction) { |
[email protected] | 75f30cc2 | 2010-06-28 21:41:38 | [diff] [blame] | 2267 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2268 | spdy::SpdySerializedFrame req( |
| 2269 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2270 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2271 | CreateMockWrite(req), |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2272 | }; |
| 2273 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2274 | spdy::SpdySerializedFrame resp( |
| 2275 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2276 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2277 | CreateMockRead(resp), |
| 2278 | // This following read isn't used by the test, except during the |
| 2279 | // RunUntilIdle() call at the end since the SpdySession survives the |
| 2280 | // HttpNetworkTransaction and still tries to continue Read()'ing. Any |
| 2281 | // MockRead will do here. |
| 2282 | MockRead(ASYNC, 0, 0) // EOF |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2283 | }; |
| 2284 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2285 | StaticSocketDataProvider data(reads, writes); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2286 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2287 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2288 | helper.RunPreTestSetup(); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2289 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2290 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2291 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2292 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2293 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2294 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2295 | helper.ResetTrans(); // Cancel the transaction. |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2296 | |
[email protected] | 30c942b | 2010-07-21 16:59:59 | [diff] [blame] | 2297 | // Flush the MessageLoop while the SpdySessionDependencies (in particular, the |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2298 | // MockClientSocketFactory) are still alive. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 2299 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2300 | helper.VerifyDataNotConsumed(); |
[email protected] | 34437af8 | 2009-11-06 02:28:49 | [diff] [blame] | 2301 | } |
[email protected] | 72552f0 | 2009-10-28 15:25:01 | [diff] [blame] | 2302 | |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2303 | // Verify that the client sends a Rst Frame upon cancelling the stream. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2304 | TEST_F(SpdyNetworkTransactionTest, CancelledTransactionSendRst) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2305 | spdy::SpdySerializedFrame req( |
| 2306 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2307 | spdy::SpdySerializedFrame rst( |
| 2308 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_CANCEL)); |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2309 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2310 | CreateMockWrite(req, 0, SYNCHRONOUS), |
| 2311 | CreateMockWrite(rst, 2, SYNCHRONOUS), |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2312 | }; |
| 2313 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2314 | spdy::SpdySerializedFrame resp( |
| 2315 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2316 | MockRead reads[] = { |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2317 | CreateMockRead(resp, 1, ASYNC), MockRead(ASYNC, nullptr, 0, 3) // EOF |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2318 | }; |
| 2319 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2320 | SequencedSocketData data(reads, writes); |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2321 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2322 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2323 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 2324 | helper.AddData(&data); |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2325 | HttpNetworkTransaction* trans = helper.trans(); |
| 2326 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2327 | TestCompletionCallback callback; |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2328 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2329 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2330 | EXPECT_THAT(callback.GetResult(rv), IsOk()); |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2331 | |
[email protected] | 3b782843 | 2010-08-18 18:33:27 | [diff] [blame] | 2332 | helper.ResetTrans(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 2333 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3b782843 | 2010-08-18 18:33:27 | [diff] [blame] | 2334 | |
[email protected] | 6c6ea17 | 2010-07-27 20:04:03 | [diff] [blame] | 2335 | helper.VerifyDataConsumed(); |
| 2336 | } |
| 2337 | |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2338 | // Verify that the client can correctly deal with the user callback attempting |
| 2339 | // to start another transaction on a session that is closing down. See |
| 2340 | // http://crbug.com/47455 |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2341 | TEST_F(SpdyNetworkTransactionTest, StartTransactionOnReadCallback) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2342 | spdy::SpdySerializedFrame req( |
| 2343 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2344 | MockWrite writes[] = {CreateMockWrite(req)}; |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 2345 | MockWrite writes2[] = {CreateMockWrite(req, 0), |
| 2346 | MockWrite(SYNCHRONOUS, ERR_IO_PENDING, 3)}; |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2347 | |
[email protected] | cbdd7316 | 2013-03-18 23:27:33 | [diff] [blame] | 2348 | // The indicated length of this frame is longer than its actual length. When |
| 2349 | // the session receives an empty frame after this one, it shuts down the |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2350 | // session, and calls the read callback with the incomplete data. |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 2351 | const uint8_t kGetBodyFrame2[] = { |
| 2352 | 0x00, 0x00, 0x00, 0x01, 0x01, 0x00, 0x00, |
| 2353 | 0x07, 'h', 'e', 'l', 'l', 'o', '!', |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2354 | }; |
| 2355 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2356 | spdy::SpdySerializedFrame resp( |
| 2357 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2358 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2359 | CreateMockRead(resp, 1), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 2360 | MockRead(ASYNC, ERR_IO_PENDING, 2), // Force a pause |
| 2361 | MockRead(ASYNC, reinterpret_cast<const char*>(kGetBodyFrame2), |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 2362 | base::size(kGetBodyFrame2), 3), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 2363 | MockRead(ASYNC, ERR_IO_PENDING, 4), // Force a pause |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2364 | MockRead(ASYNC, nullptr, 0, 5), // EOF |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2365 | }; |
| 2366 | MockRead reads2[] = { |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2367 | CreateMockRead(resp, 1), MockRead(ASYNC, nullptr, 0, 2), // EOF |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2368 | }; |
| 2369 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2370 | SequencedSocketData data(reads, writes); |
| 2371 | SequencedSocketData data2(reads2, writes2); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2372 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2373 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2374 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2375 | helper.AddData(&data); |
| 2376 | helper.AddData(&data2); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2377 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2378 | |
| 2379 | // Start the transaction with basic parameters. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2380 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2381 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2382 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2383 | rv = callback.WaitForResult(); |
| 2384 | |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2385 | const int kSize = 3000; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 2386 | scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(kSize); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2387 | rv = trans->Read( |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 2388 | buf.get(), kSize, |
Yannic Bonenberger | 00e0984 | 2019-08-31 20:46:19 | [diff] [blame] | 2389 | base::BindOnce(&SpdyNetworkTransactionTest::StartTransactionCallback, |
| 2390 | helper.session(), default_url_, log_)); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2391 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2392 | // This forces an err_IO_pending, which sets the callback. |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 2393 | data.Resume(); |
| 2394 | data.RunUntilPaused(); |
| 2395 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2396 | // This finishes the read. |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 2397 | data.Resume(); |
| 2398 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2399 | helper.VerifyDataConsumed(); |
[email protected] | b278eb7 | 2010-07-09 20:17:00 | [diff] [blame] | 2400 | } |
| 2401 | |
Mostyn Bramley-Moore | 699c531 | 2018-05-01 10:48:09 | [diff] [blame] | 2402 | // Verify that the client can correctly deal with the user callback deleting |
| 2403 | // the transaction. Failures will usually be flagged by thread and/or memory |
| 2404 | // checking tools. See http://crbug.com/46925 |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2405 | TEST_F(SpdyNetworkTransactionTest, DeleteSessionOnReadCallback) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2406 | spdy::SpdySerializedFrame req( |
| 2407 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2408 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2409 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2410 | spdy::SpdySerializedFrame resp( |
| 2411 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2412 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2413 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2414 | CreateMockRead(resp, 1), |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 2415 | MockRead(ASYNC, ERR_IO_PENDING, 2), // Force a pause |
| 2416 | CreateMockRead(body, 3), MockRead(ASYNC, nullptr, 0, 4), // EOF |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2417 | }; |
| 2418 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2419 | SequencedSocketData data(reads, writes); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2420 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2421 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2422 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2423 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2424 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2425 | |
| 2426 | // Start the transaction with basic parameters. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2427 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2428 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2429 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2430 | rv = callback.WaitForResult(); |
| 2431 | |
| 2432 | // Setup a user callback which will delete the session, and clear out the |
| 2433 | // memory holding the stream object. Note that the callback deletes trans. |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2434 | const int kSize = 3000; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 2435 | scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(kSize); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 2436 | rv = trans->Read( |
Yannic Bonenberger | 00e0984 | 2019-08-31 20:46:19 | [diff] [blame] | 2437 | buf.get(), kSize, |
| 2438 | base::BindOnce(&SpdyNetworkTransactionTest::DeleteSessionCallback, |
| 2439 | base::Unretained(&helper))); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2440 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 2441 | data.Resume(); |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2442 | |
| 2443 | // Finish running rest of tasks. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 2444 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 2445 | helper.VerifyDataConsumed(); |
[email protected] | 9be804c8 | 2010-06-24 17:59:46 | [diff] [blame] | 2446 | } |
| 2447 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2448 | TEST_F(SpdyNetworkTransactionTest, RedirectGetRequest) { |
| 2449 | SpdyURLRequestContext spdy_url_request_context; |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 2450 | // Use a different port to avoid trying to reuse the initial H2 session. |
| 2451 | const char kRedirectUrl[] = "https://www.foo.com:8080/index.php"; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2452 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2453 | SSLSocketDataProvider ssl_provider0(ASYNC, OK); |
| 2454 | ssl_provider0.next_proto = kProtoHTTP2; |
| 2455 | spdy_url_request_context.socket_factory().AddSSLSocketDataProvider( |
| 2456 | &ssl_provider0); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2457 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 2458 | spdy::Http2HeaderBlock headers0( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2459 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2460 | headers0["user-agent"] = ""; |
| 2461 | headers0["accept-encoding"] = "gzip, deflate"; |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 2462 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2463 | spdy::SpdySerializedFrame req0( |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2464 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers0), LOWEST, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2465 | spdy::SpdySerializedFrame rst( |
| 2466 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_CANCEL)); |
Shivani Sharma | c18f976 | 2017-10-23 16:43:23 | [diff] [blame] | 2467 | MockWrite writes0[] = {CreateMockWrite(req0, 0), CreateMockWrite(rst, 2)}; |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 2468 | |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 2469 | const char* const kExtraHeaders[] = {"location", kRedirectUrl}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2470 | spdy::SpdySerializedFrame resp0(spdy_util_.ConstructSpdyReplyError( |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 2471 | "301", kExtraHeaders, base::size(kExtraHeaders) / 2, 1)); |
Shivani Sharma | c18f976 | 2017-10-23 16:43:23 | [diff] [blame] | 2472 | MockRead reads0[] = {CreateMockRead(resp0, 1), MockRead(ASYNC, 0, 3)}; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2473 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2474 | SequencedSocketData data0(reads0, writes0); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2475 | spdy_url_request_context.socket_factory().AddSocketDataProvider(&data0); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2476 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2477 | SSLSocketDataProvider ssl_provider1(ASYNC, OK); |
| 2478 | ssl_provider1.next_proto = kProtoHTTP2; |
| 2479 | spdy_url_request_context.socket_factory().AddSSLSocketDataProvider( |
| 2480 | &ssl_provider1); |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 2481 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2482 | SpdyTestUtil spdy_util1; |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 2483 | spdy::Http2HeaderBlock headers1( |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 2484 | spdy_util1.ConstructGetHeaderBlock(kRedirectUrl)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2485 | headers1["user-agent"] = ""; |
| 2486 | headers1["accept-encoding"] = "gzip, deflate"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2487 | spdy::SpdySerializedFrame req1( |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2488 | spdy_util1.ConstructSpdyHeaders(1, std::move(headers1), LOWEST, true)); |
| 2489 | MockWrite writes1[] = {CreateMockWrite(req1, 0)}; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2490 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2491 | spdy::SpdySerializedFrame resp1( |
| 2492 | spdy_util1.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2493 | spdy::SpdySerializedFrame body1(spdy_util1.ConstructSpdyDataFrame(1, true)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2494 | MockRead reads1[] = {CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 2495 | MockRead(ASYNC, 0, 3)}; |
| 2496 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2497 | SequencedSocketData data1(reads1, writes1); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2498 | spdy_url_request_context.socket_factory().AddSocketDataProvider(&data1); |
| 2499 | |
| 2500 | TestDelegate delegate; |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2501 | |
| 2502 | std::unique_ptr<URLRequest> request = spdy_url_request_context.CreateRequest( |
| 2503 | default_url_, DEFAULT_PRIORITY, &delegate, TRAFFIC_ANNOTATION_FOR_TESTS); |
| 2504 | request->Start(); |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2505 | delegate.RunUntilRedirect(); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2506 | |
| 2507 | EXPECT_EQ(1, delegate.received_redirect_count()); |
| 2508 | |
Anton Bikineev | 068d291 | 2021-05-15 20:43:52 | [diff] [blame] | 2509 | request->FollowDeferredRedirect(absl::nullopt /* removed_headers */, |
| 2510 | absl::nullopt /* modified_headers */); |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2511 | delegate.RunUntilComplete(); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2512 | |
| 2513 | EXPECT_EQ(1, delegate.response_started_count()); |
| 2514 | EXPECT_FALSE(delegate.received_data_before_response()); |
| 2515 | EXPECT_THAT(delegate.request_status(), IsOk()); |
| 2516 | EXPECT_EQ("hello!", delegate.data_received()); |
| 2517 | |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2518 | // Pump the message loop to allow read data to be consumed. |
| 2519 | base::RunLoop().RunUntilIdle(); |
| 2520 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2521 | EXPECT_TRUE(data0.AllReadDataConsumed()); |
| 2522 | EXPECT_TRUE(data0.AllWriteDataConsumed()); |
| 2523 | EXPECT_TRUE(data1.AllReadDataConsumed()); |
| 2524 | EXPECT_TRUE(data1.AllWriteDataConsumed()); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2525 | } |
| 2526 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2527 | TEST_F(SpdyNetworkTransactionTest, RedirectServerPush) { |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2528 | const char redirected_url[] = "https://www.foo.com/index.php"; |
| 2529 | SpdyURLRequestContext spdy_url_request_context; |
[email protected] | 3a8d685 | 2011-03-11 23:43:44 | [diff] [blame] | 2530 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2531 | SSLSocketDataProvider ssl_provider0(ASYNC, OK); |
| 2532 | ssl_provider0.next_proto = kProtoHTTP2; |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 2533 | ssl_provider0.ssl_info.cert = |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2534 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 2535 | ASSERT_TRUE(ssl_provider0.ssl_info.cert); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2536 | spdy_url_request_context.socket_factory().AddSSLSocketDataProvider( |
| 2537 | &ssl_provider0); |
| 2538 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 2539 | spdy::Http2HeaderBlock headers0( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2540 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2541 | headers0["user-agent"] = ""; |
| 2542 | headers0["accept-encoding"] = "gzip, deflate"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2543 | spdy::SpdySerializedFrame req0( |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2544 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers0), LOWEST, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2545 | spdy::SpdySerializedFrame priority( |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2546 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2547 | spdy::SpdySerializedFrame rst( |
| 2548 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_CANCEL)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2549 | MockWrite writes[] = {CreateMockWrite(req0, 0), CreateMockWrite(priority, 3), |
| 2550 | CreateMockWrite(rst, 5)}; |
[email protected] | 3a8d685 | 2011-03-11 23:43:44 | [diff] [blame] | 2551 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2552 | spdy::SpdySerializedFrame resp0( |
| 2553 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2554 | spdy::SpdySerializedFrame push(spdy_util_.ConstructSpdyPush( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 2555 | nullptr, 0, 2, 1, kPushedUrl, "301", redirected_url)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2556 | spdy::SpdySerializedFrame body0(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2557 | MockRead reads[] = {CreateMockRead(resp0, 1), CreateMockRead(push, 2), |
| 2558 | CreateMockRead(body0, 4), MockRead(ASYNC, 0, 6)}; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2559 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2560 | SequencedSocketData data0(reads, writes); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2561 | spdy_url_request_context.socket_factory().AddSocketDataProvider(&data0); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2562 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2563 | SSLSocketDataProvider ssl_provider1(ASYNC, OK); |
| 2564 | ssl_provider1.next_proto = kProtoHTTP2; |
| 2565 | spdy_url_request_context.socket_factory().AddSSLSocketDataProvider( |
| 2566 | &ssl_provider1); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2567 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2568 | SpdyTestUtil spdy_util1; |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 2569 | spdy::Http2HeaderBlock headers1( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2570 | spdy_util1.ConstructGetHeaderBlock(redirected_url)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2571 | headers1["user-agent"] = ""; |
| 2572 | headers1["accept-encoding"] = "gzip, deflate"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2573 | spdy::SpdySerializedFrame req1( |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2574 | spdy_util1.ConstructSpdyHeaders(1, std::move(headers1), LOWEST, true)); |
| 2575 | MockWrite writes1[] = {CreateMockWrite(req1, 0)}; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2576 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2577 | spdy::SpdySerializedFrame resp1( |
| 2578 | spdy_util1.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2579 | spdy::SpdySerializedFrame body1(spdy_util1.ConstructSpdyDataFrame(1, true)); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2580 | MockRead reads1[] = {CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 2581 | MockRead(ASYNC, 0, 3)}; |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2582 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2583 | SequencedSocketData data1(reads1, writes1); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2584 | spdy_url_request_context.socket_factory().AddSocketDataProvider(&data1); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2585 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2586 | TestDelegate delegate0; |
| 2587 | std::unique_ptr<URLRequest> request = spdy_url_request_context.CreateRequest( |
| 2588 | default_url_, DEFAULT_PRIORITY, &delegate0, TRAFFIC_ANNOTATION_FOR_TESTS); |
| 2589 | |
| 2590 | request->Start(); |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2591 | delegate0.RunUntilComplete(); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2592 | |
| 2593 | EXPECT_EQ(0, delegate0.received_redirect_count()); |
| 2594 | EXPECT_EQ("hello!", delegate0.data_received()); |
| 2595 | |
| 2596 | TestDelegate delegate1; |
| 2597 | std::unique_ptr<URLRequest> request1 = spdy_url_request_context.CreateRequest( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 2598 | GURL(kPushedUrl), DEFAULT_PRIORITY, &delegate1, |
| 2599 | TRAFFIC_ANNOTATION_FOR_TESTS); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2600 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2601 | request1->Start(); |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2602 | delegate1.RunUntilRedirect(); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2603 | EXPECT_EQ(1, delegate1.received_redirect_count()); |
| 2604 | |
Anton Bikineev | 068d291 | 2021-05-15 20:43:52 | [diff] [blame] | 2605 | request1->FollowDeferredRedirect(absl::nullopt /* removed_headers */, |
| 2606 | absl::nullopt /* modified_headers */); |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2607 | delegate1.RunUntilComplete(); |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2608 | EXPECT_EQ(1, delegate1.response_started_count()); |
| 2609 | EXPECT_FALSE(delegate1.received_data_before_response()); |
| 2610 | EXPECT_EQ(OK, delegate1.request_status()); |
| 2611 | EXPECT_EQ("hello!", delegate1.data_received()); |
| 2612 | |
Wez | 0e71711 | 2018-06-18 23:09:22 | [diff] [blame] | 2613 | // Pump the message loop to allow read data to be consumed. |
| 2614 | base::RunLoop().RunUntilIdle(); |
| 2615 | |
bnc | f2ba5883 | 2017-06-07 00:22:28 | [diff] [blame] | 2616 | EXPECT_TRUE(data0.AllReadDataConsumed()); |
| 2617 | EXPECT_TRUE(data0.AllWriteDataConsumed()); |
| 2618 | EXPECT_TRUE(data1.AllReadDataConsumed()); |
| 2619 | EXPECT_TRUE(data1.AllWriteDataConsumed()); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2620 | } |
| 2621 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2622 | TEST_F(SpdyNetworkTransactionTest, ServerPushSingleDataFrame) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2623 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 2624 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2625 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2626 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2627 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2628 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2629 | }; |
| 2630 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2631 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2632 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2633 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 2634 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2635 | spdy::SpdySerializedFrame stream1_body( |
| 2636 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 2637 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2638 | spdy::SpdySerializedFrame stream2_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 2639 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2640 | MockRead reads[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2641 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream2_syn, 2), |
| 2642 | CreateMockRead(stream1_body, 4), CreateMockRead(stream2_body, 5), |
| 2643 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6), // Force a pause |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2644 | }; |
| 2645 | |
| 2646 | HttpResponseInfo response; |
| 2647 | HttpResponseInfo response2; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 2648 | std::string expected_push_result("pushed"); |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2649 | SequencedSocketData data(reads, writes); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2650 | RunServerPushTest(&data, |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 2651 | &response, |
| 2652 | &response2, |
| 2653 | expected_push_result); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2654 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 2655 | // Verify the response headers. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 2656 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 2657 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2658 | |
| 2659 | // Verify the pushed stream. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 2660 | EXPECT_TRUE(response2.headers); |
bnc | cdc749f | 2016-01-27 16:39:04 | [diff] [blame] | 2661 | EXPECT_EQ("HTTP/1.1 200", response2.headers->GetStatusLine()); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2662 | } |
| 2663 | |
Bence Béky | 02b906a | 2018-07-18 21:03:39 | [diff] [blame] | 2664 | // When server push is disabled by |
| 2665 | // HttpNetworkSession::initial_settings[SETTINGS_ENABLE_PUSH] = 0, verify that |
| 2666 | // such a setting is sent out in the initial SETTINGS frame, and if the server |
| 2667 | // creates a pushed stream despite of this, it is immediately reset. |
| 2668 | TEST_F(SpdyNetworkTransactionTest, ServerPushDisabled) { |
Bence Béky | da83e05 | 2018-07-20 01:03:32 | [diff] [blame] | 2669 | base::HistogramTester histogram_tester; |
| 2670 | |
Bence Béky | 02b906a | 2018-07-18 21:03:39 | [diff] [blame] | 2671 | spdy::SpdySerializedFrame preface( |
| 2672 | const_cast<char*>(spdy::kHttp2ConnectionHeaderPrefix), |
| 2673 | spdy::kHttp2ConnectionHeaderPrefixSize, |
| 2674 | /* owns_buffer = */ false); |
| 2675 | |
| 2676 | spdy::SettingsMap initial_settings; |
| 2677 | initial_settings[spdy::SETTINGS_HEADER_TABLE_SIZE] = kSpdyMaxHeaderTableSize; |
| 2678 | initial_settings[spdy::SETTINGS_ENABLE_PUSH] = 0; |
| 2679 | initial_settings[spdy::SETTINGS_MAX_CONCURRENT_STREAMS] = |
| 2680 | kSpdyMaxConcurrentPushedStreams; |
Bence Béky | 6cee52f | 2019-10-24 16:52:33 | [diff] [blame] | 2681 | initial_settings[spdy::SETTINGS_MAX_HEADER_LIST_SIZE] = |
| 2682 | kSpdyMaxHeaderListSize; |
Bence Béky | 02b906a | 2018-07-18 21:03:39 | [diff] [blame] | 2683 | spdy::SpdySerializedFrame initial_settings_frame( |
| 2684 | spdy_util_.ConstructSpdySettings(initial_settings)); |
| 2685 | |
| 2686 | spdy::SpdySerializedFrame req( |
| 2687 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2688 | spdy::SpdySerializedFrame rst( |
| 2689 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_REFUSED_STREAM)); |
| 2690 | |
| 2691 | MockWrite writes[] = {CreateMockWrite(preface, 0), |
| 2692 | CreateMockWrite(initial_settings_frame, 1), |
| 2693 | CreateMockWrite(req, 2), CreateMockWrite(rst, 5)}; |
| 2694 | |
| 2695 | spdy::SpdySerializedFrame reply( |
| 2696 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2697 | spdy::SpdySerializedFrame push( |
| 2698 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
| 2699 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 2700 | MockRead reads[] = {CreateMockRead(reply, 3), CreateMockRead(push, 4), |
| 2701 | CreateMockRead(body, 6), MockRead(ASYNC, OK, 7)}; |
| 2702 | |
| 2703 | SequencedSocketData data(reads, writes); |
| 2704 | |
| 2705 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 2706 | session_deps->http2_settings[spdy::SETTINGS_ENABLE_PUSH] = 0; |
| 2707 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 2708 | std::move(session_deps)); |
| 2709 | |
| 2710 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 2711 | SpdySessionPoolPeer pool_peer(spdy_session_pool); |
| 2712 | pool_peer.SetEnableSendingInitialData(true); |
| 2713 | |
| 2714 | helper.RunToCompletion(&data); |
Bence Béky | da83e05 | 2018-07-20 01:03:32 | [diff] [blame] | 2715 | |
| 2716 | histogram_tester.ExpectBucketCount( |
| 2717 | "Net.SpdyPushedStreamFate", |
| 2718 | static_cast<int>(SpdyPushedStreamFate::kPushDisabled), 1); |
| 2719 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
Bence Béky | 02b906a | 2018-07-18 21:03:39 | [diff] [blame] | 2720 | } |
| 2721 | |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2722 | TEST_F(SpdyNetworkTransactionTest, ServerPushHeadMethod) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2723 | spdy::SpdySerializedFrame req( |
| 2724 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2725 | spdy::SpdySerializedFrame priority( |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2726 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 2727 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(priority, 2)}; |
| 2728 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 2729 | spdy::Http2HeaderBlock push_promise_header_block; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2730 | push_promise_header_block[spdy::kHttp2MethodHeader] = "HEAD"; |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 2731 | spdy_util_.AddUrlToHeaderBlock(kPushedUrl, &push_promise_header_block); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2732 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2733 | 1, 2, std::move(push_promise_header_block))); |
| 2734 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 2735 | spdy::Http2HeaderBlock push_response_headers; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2736 | push_response_headers[spdy::kHttp2StatusHeader] = "200"; |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2737 | push_response_headers["foo"] = "bar"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2738 | spdy::SpdyHeadersIR headers_ir(2, std::move(push_response_headers)); |
| 2739 | spdy::SpdySerializedFrame push_headers(spdy_util_.SerializeFrame(headers_ir)); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2740 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2741 | spdy::SpdySerializedFrame resp( |
| 2742 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2743 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2744 | MockRead reads[] = { |
| 2745 | CreateMockRead(push_promise, 1), CreateMockRead(push_headers, 3), |
| 2746 | CreateMockRead(resp, 4), CreateMockRead(body, 5), |
| 2747 | // Do not close the connection after first request is done. |
| 2748 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6)}; |
| 2749 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2750 | SequencedSocketData data(reads, writes); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2751 | |
| 2752 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 2753 | helper.RunPreTestSetup(); |
| 2754 | helper.AddData(&data); |
| 2755 | |
| 2756 | // Run first request. This reads PUSH_PROMISE. |
| 2757 | helper.RunDefaultTest(); |
| 2758 | |
| 2759 | // Request the pushed resource. |
| 2760 | HttpNetworkTransaction trans(DEFAULT_PRIORITY, helper.session()); |
| 2761 | HttpRequestInfo request = CreateGetPushRequest(); |
| 2762 | request.method = "HEAD"; |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 2763 | request.traffic_annotation = |
| 2764 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2765 | TestCompletionCallback callback; |
| 2766 | int rv = trans.Start(&request, callback.callback(), log_); |
| 2767 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 2768 | rv = callback.WaitForResult(); |
| 2769 | EXPECT_THAT(rv, IsOk()); |
| 2770 | |
| 2771 | const HttpResponseInfo* response = trans.GetResponseInfo(); |
| 2772 | ASSERT_TRUE(response); |
| 2773 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 2774 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 2775 | ASSERT_TRUE(response->headers); |
| 2776 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 2777 | std::string value; |
| 2778 | EXPECT_TRUE(response->headers->GetNormalizedHeader("foo", &value)); |
| 2779 | EXPECT_EQ("bar", value); |
| 2780 | |
| 2781 | helper.VerifyDataConsumed(); |
| 2782 | } |
| 2783 | |
| 2784 | TEST_F(SpdyNetworkTransactionTest, ServerPushHeadDoesNotMatchGetRequest) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2785 | spdy::SpdySerializedFrame req1( |
| 2786 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 2787 | spdy::SpdySerializedFrame priority( |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2788 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 2789 | spdy_util_.UpdateWithStreamDestruction(1); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2790 | spdy::SpdySerializedFrame req2( |
| 2791 | spdy_util_.ConstructSpdyGet(kPushedUrl, 3, LOWEST)); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2792 | MockWrite writes[] = {CreateMockWrite(req1, 0), CreateMockWrite(priority, 2), |
| 2793 | CreateMockWrite(req2, 6)}; |
| 2794 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 2795 | spdy::Http2HeaderBlock push_promise_header_block; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2796 | push_promise_header_block[spdy::kHttp2MethodHeader] = "HEAD"; |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 2797 | spdy_util_.AddUrlToHeaderBlock(kPushedUrl, &push_promise_header_block); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2798 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2799 | 1, 2, std::move(push_promise_header_block))); |
| 2800 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 2801 | spdy::Http2HeaderBlock push_response_headers; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2802 | push_response_headers[spdy::kHttp2StatusHeader] = "200"; |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2803 | push_response_headers["foo"] = "bar"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2804 | spdy::SpdyHeadersIR headers_ir(2, std::move(push_response_headers)); |
| 2805 | spdy::SpdySerializedFrame push_headers(spdy_util_.SerializeFrame(headers_ir)); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2806 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2807 | spdy::SpdySerializedFrame resp1( |
| 2808 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 2809 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 2810 | spdy::SpdySerializedFrame resp2( |
| 2811 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 2812 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2813 | MockRead reads[] = {CreateMockRead(push_promise, 1), |
| 2814 | CreateMockRead(push_headers, 3), |
| 2815 | CreateMockRead(resp1, 4), |
| 2816 | CreateMockRead(body1, 5), |
| 2817 | CreateMockRead(resp2, 7), |
| 2818 | CreateMockRead(body2, 8), |
| 2819 | MockRead(ASYNC, 0, 9)}; |
| 2820 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2821 | SequencedSocketData data(reads, writes); |
Bence Béky | 5b1e4ce7 | 2018-01-11 14:55:15 | [diff] [blame] | 2822 | |
| 2823 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 2824 | helper.RunPreTestSetup(); |
| 2825 | helper.AddData(&data); |
| 2826 | |
| 2827 | // Run first request. This reads PUSH_PROMISE. |
| 2828 | helper.RunDefaultTest(); |
| 2829 | |
| 2830 | // Request the pushed resource. |
| 2831 | HttpNetworkTransaction trans(DEFAULT_PRIORITY, helper.session()); |
| 2832 | HttpRequestInfo request = CreateGetPushRequest(); |
| 2833 | TestCompletionCallback callback; |
| 2834 | int rv = trans.Start(&request, callback.callback(), log_); |
| 2835 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 2836 | rv = callback.WaitForResult(); |
| 2837 | EXPECT_THAT(rv, IsOk()); |
| 2838 | |
| 2839 | const HttpResponseInfo* response = trans.GetResponseInfo(); |
| 2840 | ASSERT_TRUE(response); |
| 2841 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 2842 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 2843 | ASSERT_TRUE(response->headers); |
| 2844 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 2845 | std::string value; |
| 2846 | EXPECT_FALSE(response->headers->GetNormalizedHeader("foo", &value)); |
| 2847 | std::string result; |
| 2848 | ReadResult(&trans, &result); |
| 2849 | EXPECT_EQ("hello!", result); |
| 2850 | |
| 2851 | // Read EOF. |
| 2852 | base::RunLoop().RunUntilIdle(); |
| 2853 | |
| 2854 | helper.VerifyDataConsumed(); |
| 2855 | } |
| 2856 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 2857 | TEST_F(SpdyNetworkTransactionTest, ServerPushSingleDataFrame2) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2858 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 2859 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2860 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2861 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 2862 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2863 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 2864 | }; |
[email protected] | 82918cc | 2010-08-25 17:24:50 | [diff] [blame] | 2865 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2866 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2867 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2868 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 2869 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 2870 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2871 | spdy::SpdySerializedFrame stream2_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 2872 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2873 | spdy::SpdySerializedFrame stream1_body( |
| 2874 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 82918cc | 2010-08-25 17:24:50 | [diff] [blame] | 2875 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 2876 | CreateMockRead(stream1_reply, 1), |
| 2877 | CreateMockRead(stream2_syn, 2), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2878 | CreateMockRead(stream2_body, 4), |
| 2879 | CreateMockRead(stream1_body, 5, SYNCHRONOUS), |
| 2880 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6), // Force a pause |
[email protected] | 82918cc | 2010-08-25 17:24:50 | [diff] [blame] | 2881 | }; |
| 2882 | |
| 2883 | HttpResponseInfo response; |
| 2884 | HttpResponseInfo response2; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 2885 | std::string expected_push_result("pushed"); |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2886 | SequencedSocketData data(reads, writes); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 2887 | RunServerPushTest(&data, |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 2888 | &response, |
| 2889 | &response2, |
| 2890 | expected_push_result); |
[email protected] | 82918cc | 2010-08-25 17:24:50 | [diff] [blame] | 2891 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 2892 | // Verify the response headers. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 2893 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 2894 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | 82918cc | 2010-08-25 17:24:50 | [diff] [blame] | 2895 | |
| 2896 | // Verify the pushed stream. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 2897 | EXPECT_TRUE(response2.headers); |
bnc | cdc749f | 2016-01-27 16:39:04 | [diff] [blame] | 2898 | EXPECT_EQ("HTTP/1.1 200", response2.headers->GetStatusLine()); |
[email protected] | 82918cc | 2010-08-25 17:24:50 | [diff] [blame] | 2899 | } |
| 2900 | |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2901 | TEST_F(SpdyNetworkTransactionTest, ServerPushUpdatesPriority) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2902 | spdy::SpdySerializedFrame stream1_headers( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 2903 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, HIGHEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2904 | spdy::SpdySerializedFrame stream3_headers( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 2905 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, MEDIUM)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2906 | spdy::SpdySerializedFrame stream5_headers( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 2907 | spdy_util_.ConstructSpdyGet(nullptr, 0, 5, MEDIUM)); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2908 | |
| 2909 | // Stream 1 pushes two streams that are initially prioritized below stream 5. |
| 2910 | // Stream 2 is later prioritized below stream 1 after it matches a request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2911 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2912 | spdy_util_.ConstructSpdyPriority(2, 5, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2913 | spdy::SpdySerializedFrame stream4_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2914 | spdy_util_.ConstructSpdyPriority(4, 2, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2915 | spdy::SpdySerializedFrame stream4_priority_update( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2916 | spdy_util_.ConstructSpdyPriority(4, 5, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2917 | spdy::SpdySerializedFrame stream2_priority_update( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2918 | spdy_util_.ConstructSpdyPriority(2, 1, HIGHEST, true)); |
| 2919 | |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2920 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2921 | CreateMockWrite(stream1_headers, 0), |
| 2922 | CreateMockWrite(stream3_headers, 1), |
| 2923 | CreateMockWrite(stream5_headers, 2), |
| 2924 | CreateMockWrite(stream2_priority, 7), |
| 2925 | CreateMockWrite(stream4_priority, 9), |
| 2926 | CreateMockWrite(stream4_priority_update, 11), |
| 2927 | CreateMockWrite(stream2_priority_update, 12), |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 2928 | }; |
| 2929 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2930 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2931 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2932 | spdy::SpdySerializedFrame stream3_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2933 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2934 | spdy::SpdySerializedFrame stream5_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2935 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 5)); |
| 2936 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2937 | spdy::SpdySerializedFrame stream2_push( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 2938 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2939 | spdy::SpdySerializedFrame stream4_push(spdy_util_.ConstructSpdyPush( |
Bence Béky | 3e01b53 | 2018-02-06 23:04:51 | [diff] [blame] | 2940 | nullptr, 0, 4, 1, "https://www.example.org/bar.dat")); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2941 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 2942 | spdy::SpdySerializedFrame stream1_body( |
| 2943 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 2944 | spdy::SpdySerializedFrame stream2_body( |
| 2945 | spdy_util_.ConstructSpdyDataFrame(2, true)); |
| 2946 | spdy::SpdySerializedFrame stream3_body( |
| 2947 | spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 2948 | spdy::SpdySerializedFrame stream5_body( |
| 2949 | spdy_util_.ConstructSpdyDataFrame(5, true)); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2950 | |
| 2951 | MockRead reads[] = { |
| 2952 | CreateMockRead(stream1_reply, 3), |
| 2953 | CreateMockRead(stream3_reply, 4), |
| 2954 | CreateMockRead(stream5_reply, 5), |
| 2955 | CreateMockRead(stream2_push, 6), |
| 2956 | CreateMockRead(stream4_push, 8), |
| 2957 | MockRead(ASYNC, ERR_IO_PENDING, 10), |
| 2958 | CreateMockRead(stream1_body, 13), |
| 2959 | CreateMockRead(stream2_body, 14), |
| 2960 | CreateMockRead(stream3_body, 15), |
| 2961 | CreateMockRead(stream5_body, 16), |
| 2962 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 17), // Force a pause |
| 2963 | }; |
| 2964 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 2965 | SequencedSocketData data(reads, writes); |
| 2966 | SequencedSocketData data_placeholder1; |
| 2967 | SequencedSocketData data_placeholder2; |
| 2968 | SequencedSocketData data_placeholder3; |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2969 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2970 | NormalSpdyTransactionHelper helper(request_, LOWEST, log_, nullptr); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2971 | helper.RunPreTestSetup(); |
| 2972 | helper.AddData(&data); |
| 2973 | helper.AddData(&data_placeholder1); // other requests reuse the same socket |
| 2974 | helper.AddData(&data_placeholder2); |
| 2975 | helper.AddData(&data_placeholder3); |
| 2976 | HttpNetworkTransaction trans1(HIGHEST, helper.session()); |
| 2977 | HttpNetworkTransaction trans3(MEDIUM, helper.session()); |
| 2978 | HttpNetworkTransaction trans5(MEDIUM, helper.session()); |
| 2979 | |
| 2980 | TestCompletionCallback callback1; |
| 2981 | TestCompletionCallback callback3; |
| 2982 | TestCompletionCallback callback5; |
| 2983 | |
| 2984 | // Start the ordinary requests. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2985 | ASSERT_THAT(trans1.Start(&request_, callback1.callback(), log_), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2986 | IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2987 | ASSERT_THAT(trans3.Start(&request_, callback3.callback(), log_), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2988 | IsError(ERR_IO_PENDING)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2989 | ASSERT_THAT(trans5.Start(&request_, callback5.callback(), log_), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2990 | IsError(ERR_IO_PENDING)); |
| 2991 | data.RunUntilPaused(); |
| 2992 | |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2993 | // Start a request that matches the push. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 2994 | HttpRequestInfo push_req = CreateGetPushRequest(); |
krasin | 0bfeb6b | 2017-01-13 21:48:04 | [diff] [blame] | 2995 | |
| 2996 | HttpNetworkTransaction trans2(HIGHEST, helper.session()); |
| 2997 | TestCompletionCallback callback2; |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 2998 | ASSERT_THAT(trans2.Start(&push_req, callback2.callback(), log_), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 2999 | IsError(ERR_IO_PENDING)); |
| 3000 | data.Resume(); |
| 3001 | |
| 3002 | base::RunLoop().RunUntilIdle(); |
| 3003 | ASSERT_THAT(callback1.WaitForResult(), IsOk()); |
| 3004 | ASSERT_THAT(callback2.WaitForResult(), IsOk()); |
| 3005 | ASSERT_THAT(callback3.WaitForResult(), IsOk()); |
| 3006 | ASSERT_THAT(callback5.WaitForResult(), IsOk()); |
| 3007 | helper.VerifyDataConsumed(); |
| 3008 | } |
| 3009 | |
| 3010 | TEST_F(SpdyNetworkTransactionTest, ServerPushServerAborted) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3011 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3012 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3013 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3014 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 3015 | MockWrite writes[] = { |
| 3016 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
| 3017 | }; |
| 3018 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3019 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3020 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3021 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3022 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3023 | spdy::SpdySerializedFrame stream2_rst( |
| 3024 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
| 3025 | spdy::SpdySerializedFrame stream1_body( |
| 3026 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3027 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3028 | CreateMockRead(stream1_reply, 1), |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 3029 | CreateMockRead(stream2_syn, 2, SYNCHRONOUS), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3030 | CreateMockRead(stream2_rst, 4), |
| 3031 | CreateMockRead(stream1_body, 5, SYNCHRONOUS), |
| 3032 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6), // Force a pause |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3033 | }; |
| 3034 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3035 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3036 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3037 | |
| 3038 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 3039 | helper.AddData(&data); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3040 | |
| 3041 | HttpNetworkTransaction* trans = helper.trans(); |
| 3042 | |
| 3043 | // Start the transaction with basic parameters. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 3044 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3045 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3046 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3047 | rv = callback.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3048 | EXPECT_THAT(rv, IsOk()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3049 | |
| 3050 | // Verify that we consumed all test data. |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3051 | base::RunLoop().RunUntilIdle(); |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 3052 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 3053 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3054 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 3055 | // Verify the response headers. |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3056 | HttpResponseInfo response = *trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3057 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 3058 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3059 | } |
| 3060 | |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 3061 | // Verify that we don't leak streams and that we properly send a reset |
| 3062 | // if the server pushes the same stream twice. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3063 | TEST_F(SpdyNetworkTransactionTest, ServerPushDuplicate) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3064 | base::HistogramTester histogram_tester; |
| 3065 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3066 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3067 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3068 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3069 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3070 | spdy::SpdySerializedFrame stream3_rst( |
| 3071 | spdy_util_.ConstructSpdyRstStream(4, spdy::ERROR_CODE_REFUSED_STREAM)); |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3072 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3073 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
| 3074 | CreateMockWrite(stream3_rst, 5), |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3075 | }; |
| 3076 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3077 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3078 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3079 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3080 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3081 | spdy::SpdySerializedFrame stream3_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3082 | spdy_util_.ConstructSpdyPush(nullptr, 0, 4, 1, kPushedUrl)); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3083 | |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 3084 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3085 | spdy::SpdySerializedFrame stream1_body( |
| 3086 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3087 | spdy::SpdySerializedFrame stream2_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3088 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3089 | |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3090 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3091 | CreateMockRead(stream1_reply, 1), |
| 3092 | CreateMockRead(stream2_syn, 2), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3093 | CreateMockRead(stream3_syn, 4), |
| 3094 | CreateMockRead(stream1_body, 6), |
| 3095 | CreateMockRead(stream2_body, 7), |
| 3096 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 8), // Force a pause |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3097 | }; |
| 3098 | |
| 3099 | HttpResponseInfo response; |
| 3100 | HttpResponseInfo response2; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 3101 | std::string expected_push_result("pushed"); |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3102 | SequencedSocketData data(reads, writes); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 3103 | RunServerPushTest(&data, |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 3104 | &response, |
| 3105 | &response2, |
| 3106 | expected_push_result); |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3107 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 3108 | // Verify the response headers. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3109 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 3110 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3111 | |
| 3112 | // Verify the pushed stream. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3113 | EXPECT_TRUE(response2.headers); |
bnc | cdc749f | 2016-01-27 16:39:04 | [diff] [blame] | 3114 | EXPECT_EQ("HTTP/1.1 200", response2.headers->GetStatusLine()); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3115 | |
| 3116 | histogram_tester.ExpectBucketCount( |
| 3117 | "Net.SpdyPushedStreamFate", |
| 3118 | static_cast<int>(SpdyPushedStreamFate::kAcceptedNoVary), 1); |
| 3119 | histogram_tester.ExpectBucketCount( |
| 3120 | "Net.SpdyPushedStreamFate", |
| 3121 | static_cast<int>(SpdyPushedStreamFate::kDuplicateUrl), 1); |
| 3122 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 2); |
[email protected] | fdc165a | 2010-09-03 03:51:29 | [diff] [blame] | 3123 | } |
| 3124 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3125 | TEST_F(SpdyNetworkTransactionTest, ServerPushMultipleDataFrame) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3126 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3127 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3128 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3129 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3130 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3131 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3132 | }; |
| 3133 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3134 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3135 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3136 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3137 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3138 | static const char kPushedData[] = "pushed payload for chunked test"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3139 | spdy::SpdySerializedFrame stream2_body_base( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3140 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 3141 | const size_t kChunkSize = strlen(kPushedData) / 4; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3142 | spdy::SpdySerializedFrame stream2_body1(stream2_body_base.data(), kChunkSize, |
| 3143 | false); |
| 3144 | spdy::SpdySerializedFrame stream2_body2(stream2_body_base.data() + kChunkSize, |
| 3145 | kChunkSize, false); |
| 3146 | spdy::SpdySerializedFrame stream2_body3( |
| 3147 | stream2_body_base.data() + 2 * kChunkSize, kChunkSize, false); |
| 3148 | spdy::SpdySerializedFrame stream2_body4( |
| 3149 | stream2_body_base.data() + 3 * kChunkSize, |
| 3150 | stream2_body_base.size() - 3 * kChunkSize, false); |
| 3151 | spdy::SpdySerializedFrame stream1_body( |
| 3152 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3153 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3154 | CreateMockRead(stream1_reply, 1), |
| 3155 | CreateMockRead(stream2_syn, 2), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3156 | CreateMockRead(stream2_body1, 4), |
| 3157 | CreateMockRead(stream2_body2, 5), |
| 3158 | CreateMockRead(stream2_body3, 6), |
| 3159 | CreateMockRead(stream2_body4, 7), |
| 3160 | CreateMockRead(stream1_body, 8, SYNCHRONOUS), |
| 3161 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 9), // Force a pause |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3162 | }; |
| 3163 | |
| 3164 | HttpResponseInfo response; |
| 3165 | HttpResponseInfo response2; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 3166 | std::string expected_push_result(kPushedData); |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3167 | SequencedSocketData data(reads, writes); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 3168 | RunServerPushTest(&data, &response, &response2, kPushedData); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3169 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 3170 | // Verify the response headers. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3171 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 3172 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3173 | |
| 3174 | // Verify the pushed stream. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3175 | EXPECT_TRUE(response2.headers); |
bnc | cdc749f | 2016-01-27 16:39:04 | [diff] [blame] | 3176 | EXPECT_EQ("HTTP/1.1 200", response2.headers->GetStatusLine()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3177 | } |
| 3178 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3179 | TEST_F(SpdyNetworkTransactionTest, ServerPushMultipleDataFrameInterrupted) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3180 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3181 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3182 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3183 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3184 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3185 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3186 | }; |
| 3187 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3188 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3189 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3190 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3191 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3192 | static const char kPushedData[] = "pushed payload for chunked test"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3193 | spdy::SpdySerializedFrame stream2_body_base( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3194 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 3195 | const size_t kChunkSize = strlen(kPushedData) / 4; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3196 | spdy::SpdySerializedFrame stream2_body1(stream2_body_base.data(), kChunkSize, |
| 3197 | false); |
| 3198 | spdy::SpdySerializedFrame stream2_body2(stream2_body_base.data() + kChunkSize, |
| 3199 | kChunkSize, false); |
| 3200 | spdy::SpdySerializedFrame stream2_body3( |
| 3201 | stream2_body_base.data() + 2 * kChunkSize, kChunkSize, false); |
| 3202 | spdy::SpdySerializedFrame stream2_body4( |
| 3203 | stream2_body_base.data() + 3 * kChunkSize, |
| 3204 | stream2_body_base.size() - 3 * kChunkSize, false); |
| 3205 | spdy::SpdySerializedFrame stream1_body( |
| 3206 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3207 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3208 | CreateMockRead(stream1_reply, 1), |
| 3209 | CreateMockRead(stream2_syn, 2), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3210 | CreateMockRead(stream2_body1, 4), |
| 3211 | CreateMockRead(stream2_body2, 5), |
| 3212 | CreateMockRead(stream2_body3, 6), |
| 3213 | CreateMockRead(stream2_body4, 7), |
| 3214 | CreateMockRead(stream1_body, 8, SYNCHRONOUS), |
| 3215 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 9) // Force a pause. |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3216 | }; |
| 3217 | |
| 3218 | HttpResponseInfo response; |
| 3219 | HttpResponseInfo response2; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3220 | SequencedSocketData data(reads, writes); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 3221 | RunServerPushTest(&data, &response, &response2, kPushedData); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3222 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 3223 | // Verify the response headers. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3224 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 3225 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3226 | |
| 3227 | // Verify the pushed stream. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3228 | EXPECT_TRUE(response2.headers); |
bnc | cdc749f | 2016-01-27 16:39:04 | [diff] [blame] | 3229 | EXPECT_EQ("HTTP/1.1 200", response2.headers->GetStatusLine()); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3230 | } |
| 3231 | |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3232 | TEST_F(SpdyNetworkTransactionTest, ServerPushInvalidUrl) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3233 | base::HistogramTester histogram_tester; |
| 3234 | |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3235 | // Coverage on how a non-empty invalid GURL in a PUSH_PROMISE is handled. |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 3236 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3237 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 3238 | spdy::SpdySerializedFrame req( |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3239 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers), LOWEST, true)); |
| 3240 | |
| 3241 | // Can't use ConstructSpdyPush here since it wants to parse a URL and |
| 3242 | // split it into the appropriate :header pieces. So we have to hand-fill |
| 3243 | // those pieces in. |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 3244 | spdy::Http2HeaderBlock push_promise_header_block; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3245 | push_promise_header_block[spdy::kHttp2AuthorityHeader] = ""; |
| 3246 | push_promise_header_block[spdy::kHttp2SchemeHeader] = ""; |
| 3247 | push_promise_header_block[spdy::kHttp2PathHeader] = "/index.html"; |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3248 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3249 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 3250 | 1, 2, std::move(push_promise_header_block))); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3251 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3252 | spdy::SpdySerializedFrame stream2_rst( |
| 3253 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_REFUSED_STREAM)); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3254 | |
| 3255 | MockWrite writes[] = {CreateMockWrite(req, 0), |
| 3256 | CreateMockWrite(stream2_rst, 2)}; |
| 3257 | MockRead reads[] = { |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 3258 | CreateMockRead(push_promise, 1), MockRead(ASYNC, 0, 3) /* EOF */ |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3259 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3260 | SequencedSocketData data(reads, writes); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3261 | RunBrokenPushTest(&data, ERR_CONNECTION_CLOSED); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3262 | |
| 3263 | histogram_tester.ExpectBucketCount( |
| 3264 | "Net.SpdyPushedStreamFate", |
| 3265 | static_cast<int>(SpdyPushedStreamFate::kInvalidUrl), 1); |
| 3266 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3267 | } |
| 3268 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3269 | TEST_F(SpdyNetworkTransactionTest, ServerPushInvalidAssociatedStreamID0) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3270 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3271 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3272 | spdy::SpdySerializedFrame goaway( |
| 3273 | spdy_util_.ConstructSpdyGoAway(0, spdy::ERROR_CODE_PROTOCOL_ERROR, |
| 3274 | "Framer error: 1 (INVALID_STREAM_ID).")); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3275 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3276 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(goaway, 3), |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3277 | }; |
| 3278 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3279 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3280 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3281 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3282 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 0, kPushedUrl)); |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3283 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3284 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream2_syn, 2), |
[email protected] | 19ec8a7 | 2010-08-23 03:38:23 | [diff] [blame] | 3285 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3286 | SequencedSocketData data(reads, writes); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3287 | RunBrokenPushTest(&data, OK); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3288 | } |
| 3289 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3290 | TEST_F(SpdyNetworkTransactionTest, ServerPushInvalidAssociatedStreamID9) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3291 | base::HistogramTester histogram_tester; |
| 3292 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3293 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3294 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3295 | spdy::SpdySerializedFrame stream1_body( |
| 3296 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3297 | spdy::SpdySerializedFrame stream2_rst( |
| 3298 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_STREAM_CLOSED)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3299 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3300 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_rst, 3), |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3301 | }; |
| 3302 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3303 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3304 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3305 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3306 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 9, kPushedUrl)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3307 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3308 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream2_syn, 2), |
| 3309 | CreateMockRead(stream1_body, 4), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 3310 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 5), // Force a pause |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3311 | }; |
| 3312 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3313 | SequencedSocketData data(reads, writes); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3314 | RunBrokenPushTest(&data, OK); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3315 | |
| 3316 | histogram_tester.ExpectBucketCount( |
| 3317 | "Net.SpdyPushedStreamFate", |
| 3318 | static_cast<int>(SpdyPushedStreamFate::kInactiveAssociatedStream), 1); |
| 3319 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3320 | } |
| 3321 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3322 | TEST_F(SpdyNetworkTransactionTest, ServerPushNoURL) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3323 | base::HistogramTester histogram_tester; |
| 3324 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3325 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3326 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3327 | spdy::SpdySerializedFrame stream1_body( |
| 3328 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3329 | spdy::SpdySerializedFrame stream2_rst( |
| 3330 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_REFUSED_STREAM)); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3331 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3332 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_rst, 3), |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3333 | }; |
| 3334 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3335 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3336 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 3337 | spdy::Http2HeaderBlock incomplete_headers; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3338 | incomplete_headers[spdy::kHttp2StatusHeader] = "200 OK"; |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 3339 | incomplete_headers["hello"] = "bye"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3340 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 3341 | spdy_util_.ConstructSpdyPushPromise(1, 2, std::move(incomplete_headers))); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3342 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3343 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream2_syn, 2), |
| 3344 | CreateMockRead(stream1_body, 4), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 3345 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 5) // Force a pause |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3346 | }; |
| 3347 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3348 | SequencedSocketData data(reads, writes); |
morlovich | ab1d1c1e | 2017-02-07 19:59:28 | [diff] [blame] | 3349 | RunBrokenPushTest(&data, OK); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3350 | |
| 3351 | histogram_tester.ExpectBucketCount( |
| 3352 | "Net.SpdyPushedStreamFate", |
| 3353 | static_cast<int>(SpdyPushedStreamFate::kInvalidUrl), 1); |
| 3354 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
[email protected] | e3ebba0f | 2010-08-05 17:59:58 | [diff] [blame] | 3355 | } |
| 3356 | |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3357 | // PUSH_PROMISE on a server-initiated stream should trigger GOAWAY. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3358 | TEST_F(SpdyNetworkTransactionTest, ServerPushOnPushedStream) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3359 | base::HistogramTester histogram_tester; |
| 3360 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3361 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3362 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3363 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3364 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3365 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 3366 | 2, spdy::ERROR_CODE_PROTOCOL_ERROR, |
Bence Béky | 602c40c | 2017-07-26 05:22:56 | [diff] [blame] | 3367 | "Received pushed stream id 4 on invalid stream id 2 (must be odd).")); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3368 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3369 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(stream2_priority, 3), |
| 3370 | CreateMockWrite(goaway, 5), |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3371 | }; |
| 3372 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3373 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3374 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3375 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3376 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3377 | spdy::SpdySerializedFrame stream3_syn(spdy_util_.ConstructSpdyPush( |
Bence Béky | 3e01b53 | 2018-02-06 23:04:51 | [diff] [blame] | 3378 | nullptr, 0, 4, 2, "https://www.example.org/bar.dat")); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3379 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3380 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream2_syn, 2), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3381 | CreateMockRead(stream3_syn, 4), |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3382 | }; |
| 3383 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3384 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3385 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3386 | helper.RunToCompletion(&data); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3387 | |
| 3388 | histogram_tester.ExpectBucketCount( |
| 3389 | "Net.SpdyPushedStreamFate", |
| 3390 | static_cast<int>(SpdyPushedStreamFate::kAssociatedStreamIdParityError), |
| 3391 | 1); |
| 3392 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3393 | } |
| 3394 | |
| 3395 | // PUSH_PROMISE on a closed client-initiated stream should trigger RST_STREAM. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3396 | TEST_F(SpdyNetworkTransactionTest, ServerPushOnClosedStream) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3397 | base::HistogramTester histogram_tester; |
| 3398 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3399 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3400 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3401 | spdy::SpdySerializedFrame rst( |
| 3402 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_STREAM_CLOSED)); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3403 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3404 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(rst, 5), |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3405 | }; |
| 3406 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3407 | spdy::SpdySerializedFrame stream1_reply( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 3408 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3409 | spdy::SpdySerializedFrame stream1_body( |
| 3410 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3411 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3412 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3413 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 3414 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream1_body, 2), |
| 3415 | CreateMockRead(stream2_syn, 3), MockRead(SYNCHRONOUS, ERR_IO_PENDING, 4), |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3416 | }; |
| 3417 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3418 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3419 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3420 | helper.RunPreTestSetup(); |
| 3421 | helper.AddData(&data); |
| 3422 | |
| 3423 | HttpNetworkTransaction* trans = helper.trans(); |
| 3424 | |
| 3425 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3426 | int rv = trans->Start(&request_, callback.callback(), log_); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3427 | rv = callback.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3428 | EXPECT_THAT(rv, IsOk()); |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 3429 | |
| 3430 | // Finish async network reads/writes. |
| 3431 | base::RunLoop().RunUntilIdle(); |
| 3432 | |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3433 | HttpResponseInfo response = *trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3434 | EXPECT_TRUE(response.headers); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3435 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
| 3436 | |
| 3437 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 3438 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 3439 | VerifyStreamsClosed(helper); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3440 | |
| 3441 | histogram_tester.ExpectBucketCount( |
| 3442 | "Net.SpdyPushedStreamFate", |
| 3443 | static_cast<int>(SpdyPushedStreamFate::kInactiveAssociatedStream), 1); |
| 3444 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3445 | } |
| 3446 | |
| 3447 | // PUSH_PROMISE on a server-initiated stream should trigger GOAWAY even if |
| 3448 | // stream is closed. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 3449 | TEST_F(SpdyNetworkTransactionTest, ServerPushOnClosedPushedStream) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3450 | base::HistogramTester histogram_tester; |
| 3451 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3452 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 3453 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3454 | spdy::SpdySerializedFrame stream2_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3455 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3456 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 3457 | 2, spdy::ERROR_CODE_PROTOCOL_ERROR, |
Bence Béky | 602c40c | 2017-07-26 05:22:56 | [diff] [blame] | 3458 | "Received pushed stream id 4 on invalid stream id 2 (must be odd).")); |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 3459 | MockWrite writes[] = {CreateMockWrite(stream1_syn, 0), |
| 3460 | CreateMockWrite(stream2_priority, 3), |
| 3461 | CreateMockWrite(goaway, 8)}; |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3462 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3463 | spdy::SpdySerializedFrame stream2_syn( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3464 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3465 | spdy::SpdySerializedFrame stream1_reply( |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 3466 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3467 | spdy::SpdySerializedFrame stream1_body( |
| 3468 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3469 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3470 | spdy::SpdySerializedFrame stream2_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3471 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3472 | spdy::SpdySerializedFrame stream3_syn(spdy_util_.ConstructSpdyPush( |
Bence Béky | 3e01b53 | 2018-02-06 23:04:51 | [diff] [blame] | 3473 | nullptr, 0, 4, 2, "https://www.example.org/bar.dat")); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3474 | |
| 3475 | MockRead reads[] = { |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 3476 | CreateMockRead(stream2_syn, 1), CreateMockRead(stream1_reply, 2), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 3477 | CreateMockRead(stream1_body, 4), CreateMockRead(stream2_body, 5), |
Bence Béky | 7bf9436 | 2018-01-10 13:19:36 | [diff] [blame] | 3478 | MockRead(ASYNC, ERR_IO_PENDING, 6), CreateMockRead(stream3_syn, 7)}; |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3479 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3480 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3481 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3482 | helper.RunPreTestSetup(); |
| 3483 | helper.AddData(&data); |
| 3484 | |
| 3485 | HttpNetworkTransaction* trans1 = helper.trans(); |
| 3486 | TestCompletionCallback callback1; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3487 | int rv = trans1->Start(&request_, callback1.callback(), log_); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3488 | rv = callback1.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3489 | EXPECT_THAT(rv, IsOk()); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3490 | HttpResponseInfo response = *trans1->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3491 | EXPECT_TRUE(response.headers); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3492 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
| 3493 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 3494 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3495 | TestCompletionCallback callback2; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 3496 | HttpRequestInfo request = CreateGetPushRequest(); |
| 3497 | rv = trans2.Start(&request, callback2.callback(), log_); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3498 | rv = callback2.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3499 | EXPECT_THAT(rv, IsOk()); |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 3500 | response = *trans2.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 3501 | EXPECT_TRUE(response.headers); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3502 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 3503 | std::string result; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 3504 | ReadResult(&trans2, &result); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3505 | EXPECT_EQ(kPushedData, result); |
| 3506 | |
| 3507 | data.Resume(); |
| 3508 | base::RunLoop().RunUntilIdle(); |
| 3509 | |
| 3510 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 3511 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 3512 | |
| 3513 | histogram_tester.ExpectBucketCount( |
| 3514 | "Net.SpdyPushedStreamFate", |
| 3515 | static_cast<int>(SpdyPushedStreamFate::kAssociatedStreamIdParityError), |
| 3516 | 1); |
| 3517 | histogram_tester.ExpectBucketCount( |
| 3518 | "Net.SpdyPushedStreamFate", |
| 3519 | static_cast<int>(SpdyPushedStreamFate::kAcceptedNoVary), 1); |
| 3520 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 2); |
bnc | 0cb98b2 | 2016-03-04 17:10:52 | [diff] [blame] | 3521 | } |
| 3522 | |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3523 | TEST_F(SpdyNetworkTransactionTest, ServerCancelsPush) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3524 | spdy::SpdySerializedFrame req1( |
| 3525 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 3526 | spdy::SpdySerializedFrame priority( |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3527 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3528 | spdy_util_.UpdateWithStreamDestruction(1); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3529 | spdy::SpdySerializedFrame req2( |
| 3530 | spdy_util_.ConstructSpdyGet(kPushedUrl, 3, LOWEST)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3531 | MockWrite writes1[] = {CreateMockWrite(req1, 0), CreateMockWrite(priority, 3), |
| 3532 | CreateMockWrite(req2, 6)}; |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3533 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3534 | spdy::SpdySerializedFrame reply1( |
| 3535 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 3536 | spdy::SpdySerializedFrame push( |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 3537 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3538 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3539 | spdy::SpdySerializedFrame rst( |
| 3540 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_INTERNAL_ERROR)); |
| 3541 | spdy::SpdySerializedFrame reply2( |
| 3542 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 3543 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3544 | MockRead reads1[] = {CreateMockRead(reply1, 1), CreateMockRead(push, 2), |
| 3545 | CreateMockRead(body1, 4), CreateMockRead(rst, 5), |
| 3546 | CreateMockRead(reply2, 7), CreateMockRead(body2, 8), |
| 3547 | MockRead(ASYNC, 0, 9)}; |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3548 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3549 | SequencedSocketData data(reads1, writes1); |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3550 | |
| 3551 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 3552 | helper.RunPreTestSetup(); |
| 3553 | helper.AddData(&data); |
| 3554 | |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3555 | // First request opens up connection. |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3556 | HttpNetworkTransaction* trans1 = helper.trans(); |
| 3557 | TestCompletionCallback callback1; |
| 3558 | int rv = trans1->Start(&request_, callback1.callback(), log_); |
| 3559 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 3560 | |
| 3561 | // Read until response body arrives. PUSH_PROMISE comes earlier. |
| 3562 | rv = callback1.WaitForResult(); |
| 3563 | EXPECT_THAT(rv, IsOk()); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3564 | const HttpResponseInfo* response = trans1->GetResponseInfo(); |
| 3565 | EXPECT_TRUE(response->headers); |
| 3566 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 3567 | std::string result1; |
| 3568 | ReadResult(trans1, &result1); |
| 3569 | EXPECT_EQ("hello!", result1); |
| 3570 | |
| 3571 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 3572 | SpdySessionKey key(host_port_pair_, ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 3573 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 3574 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 3575 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3576 | base::WeakPtr<SpdySession> spdy_session = |
| 3577 | spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 3578 | key, /* enable_ip_based_pooling = */ true, |
| 3579 | /* is_websocket = */ false, log_); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3580 | EXPECT_EQ(1u, num_unclaimed_pushed_streams(spdy_session)); |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3581 | |
| 3582 | // Create request matching pushed stream. |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3583 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3584 | HttpRequestInfo request2 = CreateGetPushRequest(); |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3585 | TestCompletionCallback callback2; |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3586 | rv = trans2.Start(&request2, callback2.callback(), log_); |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3587 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 3588 | |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3589 | // Pushed stream is now claimed by second request. |
| 3590 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session)); |
| 3591 | |
| 3592 | // Second request receives RST_STREAM and is retried on the same connection. |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3593 | rv = callback2.WaitForResult(); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3594 | EXPECT_THAT(rv, IsOk()); |
| 3595 | response = trans2.GetResponseInfo(); |
| 3596 | EXPECT_TRUE(response->headers); |
| 3597 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 3598 | std::string result2; |
| 3599 | ReadResult(&trans2, &result2); |
| 3600 | EXPECT_EQ("hello!", result2); |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3601 | |
| 3602 | // Read EOF. |
| 3603 | base::RunLoop().RunUntilIdle(); |
| 3604 | |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3605 | helper.VerifyDataConsumed(); |
| 3606 | } |
| 3607 | |
| 3608 | // Regression test for https://crbug.com/776415. |
| 3609 | // A client-initiated request can only pool to an existing HTTP/2 connection if |
| 3610 | // the IP address matches. However, a resource can be pushed by the server on a |
| 3611 | // connection even if the IP address does not match. This test verifies that if |
| 3612 | // the request binds to such a pushed stream, and after that the server resets |
| 3613 | // the stream before SpdySession::GetPushedStream() is called, then the retry |
| 3614 | // (using a client-initiated stream) does not pool to this connection. |
| 3615 | TEST_F(SpdyNetworkTransactionTest, ServerCancelsCrossOriginPush) { |
| 3616 | const char* kUrl1 = "https://www.example.org"; |
| 3617 | const char* kUrl2 = "https://mail.example.org"; |
| 3618 | |
| 3619 | auto resolver = std::make_unique<MockHostResolver>(); |
| 3620 | resolver->rules()->ClearRules(); |
| 3621 | resolver->rules()->AddRule("www.example.org", "127.0.0.1"); |
| 3622 | resolver->rules()->AddRule("mail.example.org", "127.0.0.2"); |
| 3623 | |
| 3624 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 3625 | session_deps->host_resolver = std::move(resolver); |
| 3626 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 3627 | std::move(session_deps)); |
| 3628 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3629 | spdy::SpdySerializedFrame req1(spdy_util_.ConstructSpdyGet(kUrl1, 1, LOWEST)); |
| 3630 | spdy::SpdySerializedFrame priority( |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3631 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 3632 | MockWrite writes1[] = {CreateMockWrite(req1, 0), |
| 3633 | CreateMockWrite(priority, 3)}; |
| 3634 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3635 | spdy::SpdySerializedFrame reply1( |
| 3636 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 3637 | spdy::SpdySerializedFrame push( |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3638 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kUrl2)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3639 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3640 | spdy::SpdySerializedFrame rst( |
| 3641 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_INTERNAL_ERROR)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3642 | MockRead reads1[] = { |
| 3643 | CreateMockRead(reply1, 1), CreateMockRead(push, 2), |
| 3644 | CreateMockRead(body1, 4), CreateMockRead(rst, 5), |
| 3645 | MockRead(ASYNC, ERR_IO_PENDING, 6), MockRead(ASYNC, 0, 7)}; |
| 3646 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3647 | SequencedSocketData data1(reads1, writes1); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3648 | |
| 3649 | SpdyTestUtil spdy_util2; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3650 | spdy::SpdySerializedFrame req2(spdy_util2.ConstructSpdyGet(kUrl2, 1, LOWEST)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3651 | MockWrite writes2[] = {CreateMockWrite(req2, 0)}; |
| 3652 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 3653 | spdy::SpdySerializedFrame reply2( |
| 3654 | spdy_util2.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 3655 | spdy::SpdySerializedFrame body2(spdy_util2.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 3656 | 1, "Response on the second connection.", true)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3657 | MockRead reads2[] = {CreateMockRead(reply2, 1), CreateMockRead(body2, 2), |
| 3658 | MockRead(ASYNC, 0, 3)}; |
| 3659 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 3660 | SequencedSocketData data2(reads2, writes2); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3661 | |
| 3662 | helper.RunPreTestSetup(); |
| 3663 | helper.AddData(&data1); |
| 3664 | helper.AddData(&data2); |
| 3665 | |
| 3666 | // First request opens up connection to www.example.org. |
| 3667 | HttpNetworkTransaction* trans1 = helper.trans(); |
| 3668 | HttpRequestInfo request1; |
| 3669 | request1.method = "GET"; |
| 3670 | request1.url = GURL(kUrl1); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 3671 | request1.traffic_annotation = |
| 3672 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3673 | TestCompletionCallback callback1; |
| 3674 | int rv = trans1->Start(&request1, callback1.callback(), log_); |
| 3675 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 3676 | |
| 3677 | // Read until response body arrives. PUSH_PROMISE comes earlier. |
| 3678 | rv = callback1.WaitForResult(); |
| 3679 | EXPECT_THAT(rv, IsOk()); |
| 3680 | const HttpResponseInfo* response = trans1->GetResponseInfo(); |
| 3681 | EXPECT_TRUE(response->headers); |
| 3682 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 3683 | std::string result1; |
| 3684 | ReadResult(trans1, &result1); |
| 3685 | EXPECT_EQ("hello!", result1); |
| 3686 | |
| 3687 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 3688 | SpdySessionKey key1(HostPortPair::FromURL(GURL(kUrl1)), ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 3689 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 3690 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 3691 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3692 | base::WeakPtr<SpdySession> spdy_session1 = |
| 3693 | spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 3694 | key1, /* enable_ip_based_pooling = */ true, |
| 3695 | /* is_websocket = */ false, log_); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3696 | EXPECT_EQ(1u, num_unclaimed_pushed_streams(spdy_session1)); |
| 3697 | |
| 3698 | // While cross-origin push for kUrl2 is allowed on spdy_session1, |
| 3699 | // a client-initiated request would not pool to this connection, |
| 3700 | // because the IP address does not match. |
| 3701 | SpdySessionKey key2(HostPortPair::FromURL(GURL(kUrl2)), ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 3702 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 3703 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 3704 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3705 | EXPECT_FALSE(spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 3706 | key2, /* enable_ip_based_pooling = */ true, |
| 3707 | /* is_websocket = */ false, log_)); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3708 | |
| 3709 | // Create request matching pushed stream. |
| 3710 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 3711 | HttpRequestInfo request2; |
| 3712 | request2.method = "GET"; |
| 3713 | request2.url = GURL(kUrl2); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 3714 | request2.traffic_annotation = |
| 3715 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | 1a5d856 | 2018-01-05 17:29:28 | [diff] [blame] | 3716 | TestCompletionCallback callback2; |
| 3717 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 3718 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 3719 | |
| 3720 | // Pushed stream is now claimed by second request. |
| 3721 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session1)); |
| 3722 | |
| 3723 | // Second request receives RST_STREAM and is retried on a new connection. |
| 3724 | rv = callback2.WaitForResult(); |
| 3725 | EXPECT_THAT(rv, IsOk()); |
| 3726 | response = trans2.GetResponseInfo(); |
| 3727 | EXPECT_TRUE(response->headers); |
| 3728 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 3729 | std::string result2; |
| 3730 | ReadResult(&trans2, &result2); |
| 3731 | EXPECT_EQ("Response on the second connection.", result2); |
| 3732 | |
| 3733 | // Make sure that the first connection is still open. This is important in |
| 3734 | // order to test that the retry created its own connection (because the IP |
| 3735 | // address does not match), instead of using the connection of the cancelled |
| 3736 | // pushed stream. |
| 3737 | EXPECT_TRUE(spdy_session1); |
| 3738 | |
| 3739 | // Read EOF. |
| 3740 | data1.Resume(); |
| 3741 | base::RunLoop().RunUntilIdle(); |
| 3742 | |
| 3743 | helper.VerifyDataConsumed(); |
Bence Béky | e8955cf2 | 2018-01-02 17:31:29 | [diff] [blame] | 3744 | } |
| 3745 | |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 3746 | TEST_F(SpdyNetworkTransactionTest, NoConnectionPoolingOverTunnel) { |
| 3747 | // Use port 443 for two reasons: This makes the endpoint is port 443 check in |
| 3748 | // NormalSpdyTransactionHelper pass, and this means that the tunnel uses the |
| 3749 | // same port as the servers, to further confuse things. |
| 3750 | const char kPacString[] = "PROXY myproxy:443"; |
| 3751 | |
| 3752 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Nicolas Arciniega | d2013f9 | 2020-02-07 23:00:56 | [diff] [blame] | 3753 | ConfiguredProxyResolutionService::CreateFixedFromPacResult( |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 3754 | kPacString, TRAFFIC_ANNOTATION_FOR_TESTS)); |
| 3755 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 3756 | std::move(session_deps)); |
| 3757 | |
| 3758 | // Only one request uses the first connection. |
| 3759 | spdy::SpdySerializedFrame req1( |
| 3760 | spdy_util_.ConstructSpdyGet("https://www.example.org", 1, LOWEST)); |
| 3761 | MockWrite writes1[] = { |
| 3762 | MockWrite(ASYNC, 0, |
| 3763 | "CONNECT www.example.org:443 HTTP/1.1\r\n" |
| 3764 | "Host: www.example.org:443\r\n" |
| 3765 | "Proxy-Connection: keep-alive\r\n\r\n"), |
| 3766 | CreateMockWrite(req1, 2), |
| 3767 | }; |
| 3768 | |
| 3769 | spdy::SpdySerializedFrame resp1( |
| 3770 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 3771 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3772 | MockRead reads1[] = {MockRead(ASYNC, 1, "HTTP/1.1 200 OK\r\n\r\n"), |
| 3773 | CreateMockRead(resp1, 3), CreateMockRead(body1, 4), |
| 3774 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 5)}; |
| 3775 | |
| 3776 | MockConnect connect1(ASYNC, OK); |
| 3777 | SequencedSocketData data1(connect1, reads1, writes1); |
| 3778 | |
| 3779 | // Run a transaction to completion to set up a SPDY session. |
| 3780 | helper.RunToCompletion(&data1); |
| 3781 | TransactionHelperResult out = helper.output(); |
| 3782 | EXPECT_THAT(out.rv, IsOk()); |
| 3783 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 3784 | EXPECT_EQ("hello!", out.response_data); |
| 3785 | |
| 3786 | // A new SPDY session should have been created. |
| 3787 | SpdySessionKey key1(HostPortPair("www.example.org", 443), |
Eric Orth | 5ccc3f0 | 2021-09-23 00:01:57 | [diff] [blame] | 3788 | PacResultElementToProxyServer(kPacString), |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 3789 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 3790 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 3791 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 3792 | base::WeakPtr<SpdySession> session1 = |
| 3793 | helper.session()->spdy_session_pool()->FindAvailableSession( |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 3794 | key1, true /* enable_ip_based_pooling */, false /* is_websocket */, |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 3795 | NetLogWithSource()); |
| 3796 | ASSERT_TRUE(session1); |
| 3797 | |
| 3798 | // The second request uses a second connection. |
| 3799 | SpdyTestUtil spdy_util2; |
| 3800 | spdy::SpdySerializedFrame req2( |
| 3801 | spdy_util2.ConstructSpdyGet("https://example.test", 1, LOWEST)); |
| 3802 | MockWrite writes2[] = { |
| 3803 | MockWrite(ASYNC, 0, |
| 3804 | "CONNECT example.test:443 HTTP/1.1\r\n" |
| 3805 | "Host: example.test:443\r\n" |
| 3806 | "Proxy-Connection: keep-alive\r\n\r\n"), |
| 3807 | CreateMockWrite(req2, 2), |
| 3808 | }; |
| 3809 | |
| 3810 | spdy::SpdySerializedFrame resp2( |
| 3811 | spdy_util2.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 3812 | spdy::SpdySerializedFrame body2(spdy_util2.ConstructSpdyDataFrame(1, true)); |
| 3813 | MockRead reads2[] = {MockRead(ASYNC, 1, "HTTP/1.1 200 OK\r\n\r\n"), |
| 3814 | CreateMockRead(resp2, 3), CreateMockRead(body2, 4), |
| 3815 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 5)}; |
| 3816 | |
| 3817 | MockConnect connect2(ASYNC, OK); |
| 3818 | SequencedSocketData data2(connect2, reads2, writes2); |
| 3819 | helper.AddData(&data2); |
| 3820 | |
| 3821 | HttpRequestInfo request2; |
| 3822 | request2.method = "GET"; |
| 3823 | request2.url = GURL("https://example.test/"); |
| 3824 | request2.load_flags = 0; |
| 3825 | request2.traffic_annotation = |
| 3826 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 3827 | auto trans2 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
| 3828 | helper.session()); |
| 3829 | |
| 3830 | TestCompletionCallback callback; |
| 3831 | EXPECT_THAT(trans2->Start(&request2, callback.callback(), NetLogWithSource()), |
| 3832 | IsError(ERR_IO_PENDING)); |
| 3833 | |
| 3834 | // Wait for the second request to get headers. It should create a new H2 |
| 3835 | // session to do so. |
| 3836 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
| 3837 | |
| 3838 | const HttpResponseInfo* response = trans2->GetResponseInfo(); |
| 3839 | ASSERT_TRUE(response); |
| 3840 | ASSERT_TRUE(response->headers); |
| 3841 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 3842 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 3843 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 3844 | std::string response_data; |
| 3845 | ASSERT_THAT(ReadTransaction(trans2.get(), &response_data), IsOk()); |
| 3846 | EXPECT_EQ("hello!", response_data); |
| 3847 | |
| 3848 | // Inspect the new session. |
Eric Orth | 5ccc3f0 | 2021-09-23 00:01:57 | [diff] [blame] | 3849 | SpdySessionKey key2(HostPortPair("example.test", 443), |
| 3850 | PacResultElementToProxyServer(kPacString), |
| 3851 | PRIVACY_MODE_DISABLED, |
| 3852 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
| 3853 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 3854 | base::WeakPtr<SpdySession> session2 = |
| 3855 | helper.session()->spdy_session_pool()->FindAvailableSession( |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 3856 | key2, true /* enable_ip_based_pooling */, false /* is_websocket */, |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 3857 | NetLogWithSource()); |
| 3858 | ASSERT_TRUE(session2); |
| 3859 | ASSERT_TRUE(session1); |
| 3860 | EXPECT_NE(session1.get(), session2.get()); |
| 3861 | } |
| 3862 | |
| 3863 | // Check that if a session is found after host resolution, but is closed before |
| 3864 | // the task to try to use it executes, the request will continue to create a new |
| 3865 | // socket and use it. |
| 3866 | TEST_F(SpdyNetworkTransactionTest, ConnectionPoolingSessionClosedBeforeUse) { |
| 3867 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 3868 | |
| 3869 | // Only one request uses the first connection. |
| 3870 | spdy::SpdySerializedFrame req1( |
| 3871 | spdy_util_.ConstructSpdyGet("https://www.example.org", 1, LOWEST)); |
| 3872 | MockWrite writes1[] = { |
| 3873 | CreateMockWrite(req1, 0), |
| 3874 | }; |
| 3875 | |
| 3876 | spdy::SpdySerializedFrame resp1( |
| 3877 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 3878 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 3879 | MockRead reads1[] = {CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 3880 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 3)}; |
| 3881 | |
| 3882 | MockConnect connect1(ASYNC, OK); |
| 3883 | SequencedSocketData data1(connect1, reads1, writes1); |
| 3884 | |
| 3885 | // Run a transaction to completion to set up a SPDY session. |
| 3886 | helper.RunToCompletion(&data1); |
| 3887 | TransactionHelperResult out = helper.output(); |
| 3888 | EXPECT_THAT(out.rv, IsOk()); |
| 3889 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 3890 | EXPECT_EQ("hello!", out.response_data); |
| 3891 | |
| 3892 | // A new SPDY session should have been created. |
| 3893 | SpdySessionKey key1(HostPortPair("www.example.org", 443), |
| 3894 | ProxyServer::Direct(), PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 3895 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 3896 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 3897 | EXPECT_TRUE(helper.session()->spdy_session_pool()->FindAvailableSession( |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 3898 | key1, true /* enable_ip_based_pooling */, false /* is_websocket */, |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 3899 | NetLogWithSource())); |
| 3900 | |
| 3901 | // The second request uses a second connection. |
| 3902 | SpdyTestUtil spdy_util2; |
| 3903 | spdy::SpdySerializedFrame req2( |
| 3904 | spdy_util2.ConstructSpdyGet("https://example.test", 1, LOWEST)); |
| 3905 | MockWrite writes2[] = { |
| 3906 | CreateMockWrite(req2, 0), |
| 3907 | }; |
| 3908 | |
| 3909 | spdy::SpdySerializedFrame resp2( |
| 3910 | spdy_util2.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 3911 | spdy::SpdySerializedFrame body2(spdy_util2.ConstructSpdyDataFrame(1, true)); |
| 3912 | MockRead reads2[] = {CreateMockRead(resp2, 1), CreateMockRead(body2, 2), |
| 3913 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 3)}; |
| 3914 | |
| 3915 | MockConnect connect2(ASYNC, OK); |
| 3916 | SequencedSocketData data2(connect2, reads2, writes2); |
| 3917 | helper.AddData(&data2); |
| 3918 | |
| 3919 | HttpRequestInfo request2; |
| 3920 | request2.method = "GET"; |
| 3921 | request2.url = GURL("https://example.test/"); |
| 3922 | request2.load_flags = 0; |
| 3923 | request2.traffic_annotation = |
| 3924 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 3925 | auto trans2 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
| 3926 | helper.session()); |
| 3927 | |
| 3928 | // Set on-demand mode and run the second request to the DNS lookup. |
| 3929 | helper.session_deps()->host_resolver->set_ondemand_mode(true); |
| 3930 | TestCompletionCallback callback; |
| 3931 | EXPECT_THAT(trans2->Start(&request2, callback.callback(), NetLogWithSource()), |
| 3932 | IsError(ERR_IO_PENDING)); |
| 3933 | base::RunLoop().RunUntilIdle(); |
| 3934 | ASSERT_TRUE(helper.session_deps()->host_resolver->has_pending_requests()); |
| 3935 | |
| 3936 | // Resolve the request now, which should create an alias for the SpdySession |
| 3937 | // immediately, but the task to use the session for the second request should |
| 3938 | // run asynchronously, so it hasn't run yet. |
| 3939 | helper.session_deps()->host_resolver->ResolveOnlyRequestNow(); |
| 3940 | SpdySessionKey key2(HostPortPair("example.test", 443), ProxyServer::Direct(), |
| 3941 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 3942 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 3943 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 3944 | base::WeakPtr<SpdySession> session1 = |
| 3945 | helper.session()->spdy_session_pool()->FindAvailableSession( |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 3946 | key2, true /* enable_ip_based_pooling */, false /* is_websocket */, |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 3947 | NetLogWithSource()); |
| 3948 | ASSERT_TRUE(session1); |
| 3949 | EXPECT_EQ(key1, session1->spdy_session_key()); |
| 3950 | // Remove the session before the second request can try to use it. |
| 3951 | helper.session()->spdy_session_pool()->CloseAllSessions(); |
| 3952 | |
| 3953 | // Wait for the second request to get headers. It should create a new H2 |
| 3954 | // session to do so. |
| 3955 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
| 3956 | |
| 3957 | const HttpResponseInfo* response = trans2->GetResponseInfo(); |
| 3958 | ASSERT_TRUE(response); |
| 3959 | ASSERT_TRUE(response->headers); |
| 3960 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 3961 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 3962 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 3963 | std::string response_data; |
| 3964 | ASSERT_THAT(ReadTransaction(trans2.get(), &response_data), IsOk()); |
| 3965 | EXPECT_EQ("hello!", response_data); |
| 3966 | |
| 3967 | // Inspect the new session. |
| 3968 | base::WeakPtr<SpdySession> session2 = |
| 3969 | helper.session()->spdy_session_pool()->FindAvailableSession( |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 3970 | key2, true /* enable_ip_based_pooling */, false /* is_websocket */, |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 3971 | NetLogWithSource()); |
| 3972 | ASSERT_TRUE(session2); |
| 3973 | EXPECT_EQ(key2, session2->spdy_session_key()); |
| 3974 | helper.VerifyDataConsumed(); |
| 3975 | } |
| 3976 | |
Xiaohan Wang | 2a6845b | 2022-01-08 04:40:57 | [diff] [blame] | 3977 | #if BUILDFLAG(IS_ANDROID) |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 3978 | |
| 3979 | // Test this if two HttpNetworkTransactions try to repurpose the same |
| 3980 | // SpdySession with two different SocketTags, only one request gets the session, |
| 3981 | // while the other makes a new SPDY session. |
| 3982 | TEST_F(SpdyNetworkTransactionTest, ConnectionPoolingMultipleSocketTags) { |
| 3983 | const SocketTag kSocketTag1(SocketTag::UNSET_UID, 1); |
| 3984 | const SocketTag kSocketTag2(SocketTag::UNSET_UID, 2); |
| 3985 | const SocketTag kSocketTag3(SocketTag::UNSET_UID, 3); |
| 3986 | |
| 3987 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 3988 | |
| 3989 | // The first and third requests use the first connection. |
| 3990 | spdy::SpdySerializedFrame req1( |
| 3991 | spdy_util_.ConstructSpdyGet("https://www.example.org", 1, LOWEST)); |
| 3992 | spdy_util_.UpdateWithStreamDestruction(1); |
| 3993 | spdy::SpdySerializedFrame req3( |
| 3994 | spdy_util_.ConstructSpdyGet("https://example.test/request3", 3, LOWEST)); |
| 3995 | MockWrite writes1[] = { |
| 3996 | CreateMockWrite(req1, 0), |
| 3997 | CreateMockWrite(req3, 3), |
| 3998 | }; |
| 3999 | |
| 4000 | spdy::SpdySerializedFrame resp1( |
| 4001 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 4002 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 4003 | spdy::SpdySerializedFrame resp3( |
| 4004 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 4005 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 4006 | MockRead reads1[] = {CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 4007 | CreateMockRead(resp3, 4), CreateMockRead(body3, 5), |
| 4008 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6)}; |
| 4009 | |
| 4010 | SequencedSocketData data1(MockConnect(ASYNC, OK), reads1, writes1); |
| 4011 | helper.AddData(&data1); |
| 4012 | |
| 4013 | // Due to the vagaries of how the socket pools work, in this particular case, |
| 4014 | // the second ConnectJob will be cancelled, but only after it tries to start |
| 4015 | // connecting. This does not happen in the general case of a bunch of requests |
| 4016 | // using the same socket tag. |
| 4017 | SequencedSocketData data2(MockConnect(SYNCHRONOUS, ERR_IO_PENDING), |
| 4018 | base::span<const MockRead>(), |
| 4019 | base::span<const MockWrite>()); |
| 4020 | helper.AddData(&data2); |
| 4021 | |
| 4022 | // The second request uses a second connection. |
| 4023 | SpdyTestUtil spdy_util2; |
| 4024 | spdy::SpdySerializedFrame req2( |
| 4025 | spdy_util2.ConstructSpdyGet("https://example.test/request2", 1, LOWEST)); |
| 4026 | MockWrite writes2[] = { |
| 4027 | CreateMockWrite(req2, 0), |
| 4028 | }; |
| 4029 | |
| 4030 | spdy::SpdySerializedFrame resp2( |
| 4031 | spdy_util2.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 4032 | spdy::SpdySerializedFrame body2(spdy_util2.ConstructSpdyDataFrame(1, true)); |
| 4033 | MockRead reads2[] = {CreateMockRead(resp2, 1), CreateMockRead(body2, 2), |
| 4034 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 3)}; |
| 4035 | |
| 4036 | SequencedSocketData data3(MockConnect(ASYNC, OK), reads2, writes2); |
| 4037 | helper.AddData(&data3); |
| 4038 | |
| 4039 | // Run a transaction to completion to set up a SPDY session. This can't use |
| 4040 | // RunToCompletion(), since it can't call VerifyDataConsumed() yet. |
| 4041 | helper.RunPreTestSetup(); |
| 4042 | helper.RunDefaultTest(); |
| 4043 | TransactionHelperResult out = helper.output(); |
| 4044 | EXPECT_THAT(out.rv, IsOk()); |
| 4045 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 4046 | EXPECT_EQ("hello!", out.response_data); |
| 4047 | |
| 4048 | // A new SPDY session should have been created. |
| 4049 | SpdySessionKey key1(HostPortPair("www.example.org", 443), |
| 4050 | ProxyServer::Direct(), PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 4051 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 4052 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 4053 | EXPECT_TRUE(helper.session()->spdy_session_pool()->FindAvailableSession( |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4054 | key1, true /* enable_ip_based_pooling */, false /* is_websocket */, |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 4055 | NetLogWithSource())); |
| 4056 | |
| 4057 | // Set on-demand mode for the next two requests. |
| 4058 | helper.session_deps()->host_resolver->set_ondemand_mode(true); |
| 4059 | |
| 4060 | HttpRequestInfo request2; |
| 4061 | request2.socket_tag = kSocketTag2; |
| 4062 | request2.method = "GET"; |
| 4063 | request2.url = GURL("https://example.test/request2"); |
| 4064 | request2.load_flags = 0; |
| 4065 | request2.traffic_annotation = |
| 4066 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 4067 | auto trans2 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
| 4068 | helper.session()); |
| 4069 | TestCompletionCallback callback2; |
| 4070 | EXPECT_THAT( |
| 4071 | trans2->Start(&request2, callback2.callback(), NetLogWithSource()), |
| 4072 | IsError(ERR_IO_PENDING)); |
| 4073 | |
| 4074 | HttpRequestInfo request3; |
| 4075 | request3.socket_tag = kSocketTag3; |
| 4076 | request3.method = "GET"; |
| 4077 | request3.url = GURL("https://example.test/request3"); |
| 4078 | request3.load_flags = 0; |
| 4079 | request3.traffic_annotation = |
| 4080 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 4081 | auto trans3 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
| 4082 | helper.session()); |
| 4083 | TestCompletionCallback callback3; |
| 4084 | EXPECT_THAT( |
| 4085 | trans3->Start(&request3, callback3.callback(), NetLogWithSource()), |
| 4086 | IsError(ERR_IO_PENDING)); |
| 4087 | |
| 4088 | // Run the message loop until both requests are waiting on the host resolver. |
| 4089 | base::RunLoop().RunUntilIdle(); |
| 4090 | ASSERT_TRUE(helper.session_deps()->host_resolver->has_pending_requests()); |
| 4091 | |
| 4092 | // Complete the second requests's DNS lookup now, which should create an alias |
| 4093 | // for the SpdySession immediately, but the task to use the session for the |
| 4094 | // second request should run asynchronously, so it hasn't run yet. |
| 4095 | helper.session_deps()->host_resolver->ResolveNow(2); |
| 4096 | SpdySessionKey key2(HostPortPair("example.test", 443), ProxyServer::Direct(), |
| 4097 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 4098 | SpdySessionKey::IsProxySession::kFalse, kSocketTag2, |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 4099 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 4100 | |
| 4101 | // Complete the third requests's DNS lookup now, which should hijack the |
| 4102 | // SpdySession from the second request. |
| 4103 | helper.session_deps()->host_resolver->ResolveNow(3); |
| 4104 | SpdySessionKey key3(HostPortPair("example.test", 443), ProxyServer::Direct(), |
| 4105 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 4106 | SpdySessionKey::IsProxySession::kFalse, kSocketTag3, |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 4107 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 4108 | |
| 4109 | // Wait for the second request to get headers. It should create a new H2 |
| 4110 | // session to do so. |
| 4111 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
| 4112 | |
| 4113 | const HttpResponseInfo* response = trans2->GetResponseInfo(); |
| 4114 | ASSERT_TRUE(response); |
| 4115 | ASSERT_TRUE(response->headers); |
| 4116 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 4117 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4118 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 4119 | std::string response_data; |
| 4120 | ASSERT_THAT(ReadTransaction(trans2.get(), &response_data), IsOk()); |
| 4121 | EXPECT_EQ("hello!", response_data); |
| 4122 | |
| 4123 | // Wait for the third request to get headers. It should have reused the first |
| 4124 | // session. |
| 4125 | EXPECT_THAT(callback3.WaitForResult(), IsOk()); |
| 4126 | |
| 4127 | response = trans3->GetResponseInfo(); |
| 4128 | ASSERT_TRUE(response); |
| 4129 | ASSERT_TRUE(response->headers); |
| 4130 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 4131 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4132 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 4133 | ASSERT_THAT(ReadTransaction(trans3.get(), &response_data), IsOk()); |
| 4134 | EXPECT_EQ("hello!", response_data); |
| 4135 | |
| 4136 | helper.VerifyDataConsumed(); |
| 4137 | } |
| 4138 | |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4139 | TEST_F(SpdyNetworkTransactionTest, SocketTagChangeSessionTagWithDnsAliases) { |
| 4140 | SocketTag socket_tag_1(SocketTag::UNSET_UID, 1); |
| 4141 | SocketTag socket_tag_2(SocketTag::UNSET_UID, 2); |
| 4142 | request_.socket_tag = socket_tag_1; |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4143 | |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4144 | std::unique_ptr<SpdySessionDependencies> session_deps = |
| 4145 | std::make_unique<SpdySessionDependencies>(); |
| 4146 | std::unique_ptr<MockCachingHostResolver> host_resolver = |
| 4147 | std::make_unique<MockCachingHostResolver>(2 /* cache_invalidation_num */); |
| 4148 | session_deps->host_resolver = std::move(host_resolver); |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4149 | |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4150 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 4151 | std::move(session_deps)); |
| 4152 | |
| 4153 | GURL url = request_.url; |
Eric Orth | ac66191 | 2022-01-10 21:44:17 | [diff] [blame^] | 4154 | std::set<std::string> dns_aliases({"alias1", "alias2", "alias3"}); |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4155 | helper.session_deps()->host_resolver->rules()->AddIPLiteralRuleWithDnsAliases( |
| 4156 | url.host(), "127.0.0.1", dns_aliases); |
| 4157 | |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4158 | spdy::SpdySerializedFrame req1( |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4159 | spdy_util_.ConstructSpdyGet(url.spec().c_str(), 1, DEFAULT_PRIORITY)); |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4160 | spdy_util_.UpdateWithStreamDestruction(1); |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4161 | spdy::SpdySerializedFrame req2( |
| 4162 | spdy_util_.ConstructSpdyGet(url.spec().c_str(), 3, DEFAULT_PRIORITY)); |
| 4163 | MockWrite writes[] = { |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4164 | CreateMockWrite(req1, 0), |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4165 | CreateMockWrite(req2, 3), |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4166 | }; |
| 4167 | |
| 4168 | spdy::SpdySerializedFrame resp1( |
| 4169 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 4170 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4171 | spdy::SpdySerializedFrame resp2( |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4172 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 4173 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 4174 | MockRead reads[] = {CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 4175 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 4176 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6)}; |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4177 | |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4178 | SequencedSocketData data(MockConnect(ASYNC, OK), reads, writes); |
| 4179 | helper.AddData(&data); |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4180 | |
| 4181 | // Run a transaction to completion to set up a SPDY session. This can't use |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4182 | // RunToCompletion(), since it can't call VerifyDataConsumed() yet because |
| 4183 | // there are still further requests expected. |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4184 | helper.RunPreTestSetup(); |
| 4185 | helper.RunDefaultTest(); |
| 4186 | TransactionHelperResult out = helper.output(); |
| 4187 | EXPECT_THAT(out.rv, IsOk()); |
| 4188 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 4189 | EXPECT_EQ("hello!", out.response_data); |
| 4190 | |
| 4191 | // A new SPDY session should have been created. |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4192 | EXPECT_EQ(1u, helper.GetSpdySessionCount()); |
| 4193 | SpdySessionKey key1(HostPortPair(url.host(), 443), ProxyServer::Direct(), |
| 4194 | PRIVACY_MODE_DISABLED, |
| 4195 | SpdySessionKey::IsProxySession::kFalse, socket_tag_1, |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 4196 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4197 | EXPECT_TRUE(helper.session()->spdy_session_pool()->FindAvailableSession( |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4198 | key1, true /* enable_ip_based_pooling */, false /* is_websocket */, |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4199 | NetLogWithSource())); |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4200 | EXPECT_EQ( |
| 4201 | dns_aliases, |
| 4202 | helper.session()->spdy_session_pool()->GetDnsAliasesForSessionKey(key1)); |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4203 | |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4204 | // Clear host resolver rules to ensure that cached values for DNS aliases |
| 4205 | // are used. |
| 4206 | helper.session_deps()->host_resolver->rules()->ClearRules(); |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4207 | |
| 4208 | HttpRequestInfo request2; |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4209 | request2.socket_tag = socket_tag_2; |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4210 | request2.method = "GET"; |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4211 | request2.url = url; |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4212 | request2.load_flags = 0; |
| 4213 | request2.traffic_annotation = |
| 4214 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4215 | SpdySessionKey key2(HostPortPair(url.host(), 443), ProxyServer::Direct(), |
| 4216 | PRIVACY_MODE_DISABLED, |
| 4217 | SpdySessionKey::IsProxySession::kFalse, socket_tag_2, |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 4218 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4219 | auto trans2 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
| 4220 | helper.session()); |
| 4221 | TestCompletionCallback callback2; |
| 4222 | EXPECT_THAT( |
| 4223 | trans2->Start(&request2, callback2.callback(), NetLogWithSource()), |
| 4224 | IsError(ERR_IO_PENDING)); |
| 4225 | |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4226 | // Wait for the second request to get headers. It should have reused the |
| 4227 | // first session but changed the tag. |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4228 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
| 4229 | |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4230 | EXPECT_EQ(1u, helper.GetSpdySessionCount()); |
| 4231 | EXPECT_FALSE(helper.session()->spdy_session_pool()->FindAvailableSession( |
| 4232 | key1, true /* enable_ip_based_pooling */, false /* is_websocket */, |
| 4233 | NetLogWithSource())); |
| 4234 | EXPECT_TRUE(helper.session() |
| 4235 | ->spdy_session_pool() |
| 4236 | ->GetDnsAliasesForSessionKey(key1) |
| 4237 | .empty()); |
| 4238 | EXPECT_TRUE(helper.session()->spdy_session_pool()->FindAvailableSession( |
| 4239 | key2, true /* enable_ip_based_pooling */, false /* is_websocket */, |
| 4240 | NetLogWithSource())); |
| 4241 | EXPECT_EQ( |
| 4242 | dns_aliases, |
| 4243 | helper.session()->spdy_session_pool()->GetDnsAliasesForSessionKey(key2)); |
| 4244 | |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4245 | const HttpResponseInfo* response = trans2->GetResponseInfo(); |
| 4246 | ASSERT_TRUE(response); |
| 4247 | ASSERT_TRUE(response->headers); |
| 4248 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 4249 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4250 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 4251 | std::string response_data; |
| 4252 | ASSERT_THAT(ReadTransaction(trans2.get(), &response_data), IsOk()); |
| 4253 | EXPECT_EQ("hello!", response_data); |
| 4254 | |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4255 | helper.VerifyDataConsumed(); |
| 4256 | } |
| 4257 | |
| 4258 | TEST_F(SpdyNetworkTransactionTest, |
| 4259 | SocketTagChangeFromIPAliasedSessionWithDnsAliases) { |
| 4260 | SocketTag socket_tag_1(SocketTag::UNSET_UID, 1); |
| 4261 | SocketTag socket_tag_2(SocketTag::UNSET_UID, 2); |
| 4262 | request_.socket_tag = socket_tag_1; |
| 4263 | |
| 4264 | std::unique_ptr<SpdySessionDependencies> session_deps = |
| 4265 | std::make_unique<SpdySessionDependencies>(); |
| 4266 | std::unique_ptr<MockCachingHostResolver> host_resolver = |
| 4267 | std::make_unique<MockCachingHostResolver>(2 /* cache_invalidation_num */); |
| 4268 | session_deps->host_resolver = std::move(host_resolver); |
| 4269 | |
| 4270 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 4271 | std::move(session_deps)); |
| 4272 | GURL url1 = request_.url; |
Eric Orth | ac66191 | 2022-01-10 21:44:17 | [diff] [blame^] | 4273 | std::set<std::string> dns_aliases1({"alias1", "alias2", "alias3"}); |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4274 | GURL url2("https://example.test/"); |
Eric Orth | ac66191 | 2022-01-10 21:44:17 | [diff] [blame^] | 4275 | std::set<std::string> dns_aliases2({"example.net", "example.com"}); |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4276 | |
| 4277 | helper.session_deps()->host_resolver->rules()->AddIPLiteralRuleWithDnsAliases( |
| 4278 | url1.host(), "127.0.0.1", dns_aliases1); |
| 4279 | helper.session_deps()->host_resolver->rules()->AddIPLiteralRuleWithDnsAliases( |
| 4280 | url2.host(), "127.0.0.1", dns_aliases2); |
| 4281 | |
| 4282 | spdy::SpdySerializedFrame req1( |
| 4283 | spdy_util_.ConstructSpdyGet(url1.spec().c_str(), 1, DEFAULT_PRIORITY)); |
| 4284 | spdy_util_.UpdateWithStreamDestruction(1); |
| 4285 | spdy::SpdySerializedFrame req2( |
| 4286 | spdy_util_.ConstructSpdyGet(url2.spec().c_str(), 3, DEFAULT_PRIORITY)); |
| 4287 | spdy_util_.UpdateWithStreamDestruction(3); |
| 4288 | spdy::SpdySerializedFrame req3( |
| 4289 | spdy_util_.ConstructSpdyGet(url2.spec().c_str(), 5, DEFAULT_PRIORITY)); |
| 4290 | spdy_util_.UpdateWithStreamDestruction(5); |
| 4291 | spdy::SpdySerializedFrame req4( |
| 4292 | spdy_util_.ConstructSpdyGet(url1.spec().c_str(), 7, DEFAULT_PRIORITY)); |
| 4293 | MockWrite writes[] = { |
| 4294 | CreateMockWrite(req1, 0), |
| 4295 | CreateMockWrite(req2, 3), |
| 4296 | CreateMockWrite(req3, 6), |
| 4297 | CreateMockWrite(req4, 9), |
| 4298 | }; |
| 4299 | |
| 4300 | spdy::SpdySerializedFrame resp1( |
| 4301 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 4302 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 4303 | spdy::SpdySerializedFrame resp2( |
| 4304 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 4305 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 4306 | spdy::SpdySerializedFrame resp3( |
| 4307 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 5)); |
| 4308 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame(5, true)); |
| 4309 | spdy::SpdySerializedFrame resp4( |
| 4310 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 7)); |
| 4311 | spdy::SpdySerializedFrame body4(spdy_util_.ConstructSpdyDataFrame(7, true)); |
| 4312 | MockRead reads[] = {CreateMockRead(resp1, 1), |
| 4313 | CreateMockRead(body1, 2), |
| 4314 | CreateMockRead(resp2, 4), |
| 4315 | CreateMockRead(body2, 5), |
| 4316 | CreateMockRead(resp3, 7), |
| 4317 | CreateMockRead(body3, 8), |
| 4318 | CreateMockRead(resp4, 10), |
| 4319 | CreateMockRead(body4, 11), |
| 4320 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 12)}; |
| 4321 | |
| 4322 | SequencedSocketData data(MockConnect(ASYNC, OK), reads, writes); |
| 4323 | helper.AddData(&data); |
| 4324 | |
| 4325 | // Run a transaction to completion to set up a SPDY session. This can't use |
| 4326 | // RunToCompletion(), since it can't call VerifyDataConsumed() yet. |
| 4327 | helper.RunPreTestSetup(); |
| 4328 | helper.RunDefaultTest(); |
| 4329 | TransactionHelperResult out = helper.output(); |
| 4330 | EXPECT_THAT(out.rv, IsOk()); |
| 4331 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 4332 | EXPECT_EQ("hello!", out.response_data); |
| 4333 | |
| 4334 | // A new SPDY session should have been created. |
| 4335 | EXPECT_EQ(1u, helper.GetSpdySessionCount()); |
| 4336 | SpdySessionKey key1(HostPortPair(url1.host(), 443), ProxyServer::Direct(), |
| 4337 | PRIVACY_MODE_DISABLED, |
| 4338 | SpdySessionKey::IsProxySession::kFalse, socket_tag_1, |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 4339 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4340 | EXPECT_TRUE(helper.session()->spdy_session_pool()->FindAvailableSession( |
| 4341 | key1, true /* enable_ip_based_pooling */, false /* is_websocket */, |
| 4342 | NetLogWithSource())); |
| 4343 | EXPECT_EQ( |
| 4344 | dns_aliases1, |
| 4345 | helper.session()->spdy_session_pool()->GetDnsAliasesForSessionKey(key1)); |
| 4346 | |
| 4347 | HttpRequestInfo request2; |
| 4348 | request2.socket_tag = socket_tag_1; |
| 4349 | request2.method = "GET"; |
| 4350 | request2.url = url2; |
| 4351 | request2.load_flags = 0; |
| 4352 | request2.traffic_annotation = |
| 4353 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 4354 | SpdySessionKey key2(HostPortPair(url2.host(), 443), ProxyServer::Direct(), |
| 4355 | PRIVACY_MODE_DISABLED, |
| 4356 | SpdySessionKey::IsProxySession::kFalse, socket_tag_1, |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 4357 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4358 | auto trans2 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
| 4359 | helper.session()); |
| 4360 | TestCompletionCallback callback2; |
| 4361 | EXPECT_THAT( |
| 4362 | trans2->Start(&request2, callback2.callback(), NetLogWithSource()), |
| 4363 | IsError(ERR_IO_PENDING)); |
| 4364 | |
| 4365 | // Wait for the second request to get headers. It should have reused the |
| 4366 | // first session. |
| 4367 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
| 4368 | |
| 4369 | EXPECT_EQ(1u, helper.GetSpdySessionCount()); |
| 4370 | EXPECT_TRUE(helper.session()->spdy_session_pool()->FindAvailableSession( |
| 4371 | key2, true /* enable_ip_based_pooling */, false /* is_websocket */, |
| 4372 | NetLogWithSource())); |
| 4373 | EXPECT_EQ( |
| 4374 | dns_aliases2, |
| 4375 | helper.session()->spdy_session_pool()->GetDnsAliasesForSessionKey(key2)); |
| 4376 | |
| 4377 | const HttpResponseInfo* response = trans2->GetResponseInfo(); |
| 4378 | ASSERT_TRUE(response); |
| 4379 | ASSERT_TRUE(response->headers); |
| 4380 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 4381 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4382 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 4383 | std::string response_data; |
| 4384 | ASSERT_THAT(ReadTransaction(trans2.get(), &response_data), IsOk()); |
| 4385 | EXPECT_EQ("hello!", response_data); |
| 4386 | |
| 4387 | // Clear host resolver rules to ensure that cached values for DNS aliases |
| 4388 | // are used. |
| 4389 | helper.session_deps()->host_resolver->rules()->ClearRules(); |
| 4390 | trans2.reset(); |
| 4391 | |
| 4392 | HttpRequestInfo request3; |
| 4393 | request3.socket_tag = socket_tag_2; |
| 4394 | request3.method = "GET"; |
| 4395 | request3.url = url2; |
| 4396 | request3.load_flags = 0; |
| 4397 | request3.traffic_annotation = |
| 4398 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 4399 | SpdySessionKey key3(HostPortPair(url2.host(), 443), ProxyServer::Direct(), |
| 4400 | PRIVACY_MODE_DISABLED, |
| 4401 | SpdySessionKey::IsProxySession::kFalse, socket_tag_2, |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 4402 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4403 | auto trans3 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
| 4404 | helper.session()); |
| 4405 | TestCompletionCallback callback3; |
| 4406 | EXPECT_THAT( |
| 4407 | trans3->Start(&request3, callback3.callback(), NetLogWithSource()), |
| 4408 | IsError(ERR_IO_PENDING)); |
| 4409 | |
| 4410 | // Wait for the third request to get headers. It should have reused the |
| 4411 | // first session but changed the socket tag. |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4412 | EXPECT_THAT(callback3.WaitForResult(), IsOk()); |
| 4413 | |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4414 | EXPECT_EQ(1u, helper.GetSpdySessionCount()); |
| 4415 | EXPECT_FALSE(helper.session()->spdy_session_pool()->FindAvailableSession( |
| 4416 | key2, true /* enable_ip_based_pooling */, false /* is_websocket */, |
| 4417 | NetLogWithSource())); |
| 4418 | EXPECT_TRUE(helper.session() |
| 4419 | ->spdy_session_pool() |
| 4420 | ->GetDnsAliasesForSessionKey(key2) |
| 4421 | .empty()); |
| 4422 | EXPECT_TRUE(helper.session()->spdy_session_pool()->FindAvailableSession( |
| 4423 | key3, true /* enable_ip_based_pooling */, false /* is_websocket */, |
| 4424 | NetLogWithSource())); |
| 4425 | EXPECT_EQ( |
| 4426 | dns_aliases2, |
| 4427 | helper.session()->spdy_session_pool()->GetDnsAliasesForSessionKey(key3)); |
| 4428 | |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4429 | response = trans3->GetResponseInfo(); |
| 4430 | ASSERT_TRUE(response); |
| 4431 | ASSERT_TRUE(response->headers); |
| 4432 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 4433 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4434 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 4435 | ASSERT_THAT(ReadTransaction(trans3.get(), &response_data), IsOk()); |
| 4436 | EXPECT_EQ("hello!", response_data); |
| 4437 | |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4438 | trans3.reset(); |
| 4439 | |
| 4440 | HttpRequestInfo request4; |
| 4441 | request4.socket_tag = socket_tag_2; |
| 4442 | request4.method = "GET"; |
| 4443 | request4.url = url1; |
| 4444 | request4.load_flags = 0; |
| 4445 | request4.traffic_annotation = |
| 4446 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 4447 | SpdySessionKey key4(HostPortPair(url1.host(), 443), ProxyServer::Direct(), |
| 4448 | PRIVACY_MODE_DISABLED, |
| 4449 | SpdySessionKey::IsProxySession::kFalse, socket_tag_2, |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 4450 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Cammie Smith Barnes | 5191037b7 | 2021-03-01 22:06:53 | [diff] [blame] | 4451 | auto trans4 = std::make_unique<HttpNetworkTransaction>(DEFAULT_PRIORITY, |
| 4452 | helper.session()); |
| 4453 | TestCompletionCallback callback4; |
| 4454 | EXPECT_THAT( |
| 4455 | trans4->Start(&request4, callback4.callback(), NetLogWithSource()), |
| 4456 | IsError(ERR_IO_PENDING)); |
| 4457 | |
| 4458 | // Wait for the third request to get headers. It should have reused the |
| 4459 | // first session but changed the socket tag. |
| 4460 | EXPECT_THAT(callback4.WaitForResult(), IsOk()); |
| 4461 | |
| 4462 | EXPECT_EQ(1u, helper.GetSpdySessionCount()); |
| 4463 | EXPECT_FALSE(helper.session()->spdy_session_pool()->FindAvailableSession( |
| 4464 | key1, true /* enable_ip_based_pooling */, false /* is_websocket */, |
| 4465 | NetLogWithSource())); |
| 4466 | EXPECT_TRUE(helper.session() |
| 4467 | ->spdy_session_pool() |
| 4468 | ->GetDnsAliasesForSessionKey(key1) |
| 4469 | .empty()); |
| 4470 | EXPECT_TRUE(helper.session()->spdy_session_pool()->FindAvailableSession( |
| 4471 | key4, true /* enable_ip_based_pooling */, false /* is_websocket */, |
| 4472 | NetLogWithSource())); |
| 4473 | EXPECT_EQ( |
| 4474 | dns_aliases1, |
| 4475 | helper.session()->spdy_session_pool()->GetDnsAliasesForSessionKey(key4)); |
| 4476 | |
| 4477 | response = trans4->GetResponseInfo(); |
| 4478 | ASSERT_TRUE(response); |
| 4479 | ASSERT_TRUE(response->headers); |
| 4480 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 4481 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4482 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 4483 | ASSERT_THAT(ReadTransaction(trans4.get(), &response_data), IsOk()); |
| 4484 | EXPECT_EQ("hello!", response_data); |
| 4485 | |
Cammie Smith Barnes | 6b93b99 | 2021-02-03 21:25:40 | [diff] [blame] | 4486 | helper.VerifyDataConsumed(); |
| 4487 | } |
| 4488 | |
Xiaohan Wang | 2a6845b | 2022-01-08 04:40:57 | [diff] [blame] | 4489 | #endif // BUILDFLAG(IS_ANDROID) |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 4490 | |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4491 | // Regression test for https://crbug.com/727653. |
| 4492 | TEST_F(SpdyNetworkTransactionTest, RejectServerPushWithNoMethod) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 4493 | base::HistogramTester histogram_tester; |
| 4494 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4495 | spdy::SpdySerializedFrame req( |
| 4496 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 4497 | spdy::SpdySerializedFrame rst( |
| 4498 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_REFUSED_STREAM)); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4499 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(rst, 3)}; |
| 4500 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4501 | spdy::SpdySerializedFrame reply( |
| 4502 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4503 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 4504 | spdy::Http2HeaderBlock push_promise_header_block; |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 4505 | spdy_util_.AddUrlToHeaderBlock(kPushedUrl, &push_promise_header_block); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4506 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 4507 | 1, 2, std::move(push_promise_header_block))); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4508 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4509 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 4510 | MockRead reads[] = {CreateMockRead(reply, 1), CreateMockRead(push_promise, 2), |
| 4511 | CreateMockRead(body, 4), |
| 4512 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 5)}; |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4513 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4514 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4515 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4516 | helper.RunToCompletion(&data); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 4517 | |
| 4518 | histogram_tester.ExpectBucketCount( |
| 4519 | "Net.SpdyPushedStreamFate", |
| 4520 | static_cast<int>(SpdyPushedStreamFate::kInvalidUrl), 1); |
| 4521 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4522 | } |
| 4523 | |
| 4524 | // Regression test for https://crbug.com/727653. |
| 4525 | TEST_F(SpdyNetworkTransactionTest, RejectServerPushWithInvalidMethod) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 4526 | base::HistogramTester histogram_tester; |
| 4527 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4528 | spdy::SpdySerializedFrame req( |
| 4529 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 4530 | spdy::SpdySerializedFrame rst( |
| 4531 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_REFUSED_STREAM)); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4532 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(rst, 3)}; |
| 4533 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4534 | spdy::SpdySerializedFrame reply( |
| 4535 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4536 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 4537 | spdy::Http2HeaderBlock push_promise_header_block; |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4538 | push_promise_header_block[":method"] = "POST"; |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 4539 | spdy_util_.AddUrlToHeaderBlock(kPushedUrl, &push_promise_header_block); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4540 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 4541 | 1, 2, std::move(push_promise_header_block))); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4542 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4543 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 4544 | MockRead reads[] = {CreateMockRead(reply, 1), CreateMockRead(push_promise, 2), |
| 4545 | CreateMockRead(body, 4), |
| 4546 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 5)}; |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4547 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4548 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4549 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4550 | helper.RunToCompletion(&data); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 4551 | |
| 4552 | histogram_tester.ExpectBucketCount( |
| 4553 | "Net.SpdyPushedStreamFate", |
| 4554 | static_cast<int>(SpdyPushedStreamFate::kInvalidUrl), 1); |
| 4555 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
bnc | c055fa3 | 2017-06-19 13:44:42 | [diff] [blame] | 4556 | } |
| 4557 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 4558 | // Verify that various response headers parse correctly through the HTTP layer. |
| 4559 | TEST_F(SpdyNetworkTransactionTest, ResponseHeaders) { |
| 4560 | struct ResponseHeadersTests { |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 4561 | int extra_header_count; |
| 4562 | const char* extra_headers[4]; |
| 4563 | size_t expected_header_count; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 4564 | base::StringPiece expected_headers[8]; |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 4565 | } test_cases[] = { |
| 4566 | // No extra headers. |
Yoichi Osato | 85350eb7 | 2020-09-11 02:14:30 | [diff] [blame] | 4567 | {0, {}, 1, {"hello", "bye"}}, |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 4568 | // Comma-separated header value. |
| 4569 | {1, |
| 4570 | {"cookie", "val1, val2"}, |
Yoichi Osato | 85350eb7 | 2020-09-11 02:14:30 | [diff] [blame] | 4571 | 2, |
| 4572 | {"hello", "bye", "cookie", "val1, val2"}}, |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 4573 | // Multiple headers are preserved: they are joined with \0 separator in |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 4574 | // spdy::Http2HeaderBlock.AppendValueOrAddHeader(), then split up in |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 4575 | // HpackEncoder, then joined with \0 separator when |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4576 | // spdy::HpackDecoderAdapter::ListenerAdapter::OnHeader() calls |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 4577 | // spdy::Http2HeaderBlock.AppendValueOrAddHeader(), then split up again in |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 4578 | // HttpResponseHeaders. |
| 4579 | {2, |
| 4580 | {"content-encoding", "val1", "content-encoding", "val2"}, |
Yoichi Osato | 85350eb7 | 2020-09-11 02:14:30 | [diff] [blame] | 4581 | 3, |
| 4582 | {"hello", "bye", "content-encoding", "val1", "content-encoding", |
| 4583 | "val2"}}, |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 4584 | // Cookie header is not split up by HttpResponseHeaders. |
| 4585 | {2, |
| 4586 | {"cookie", "val1", "cookie", "val2"}, |
Yoichi Osato | 85350eb7 | 2020-09-11 02:14:30 | [diff] [blame] | 4587 | 2, |
| 4588 | {"hello", "bye", "cookie", "val1; val2"}}}; |
bnc | 7ecc112 | 2015-09-28 13:22:49 | [diff] [blame] | 4589 | |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 4590 | for (size_t i = 0; i < base::size(test_cases); ++i) { |
Bence Béky | ad9eb162 | 2020-09-17 16:29:17 | [diff] [blame] | 4591 | SCOPED_TRACE(i); |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4592 | SpdyTestUtil spdy_test_util; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4593 | spdy::SpdySerializedFrame req( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 4594 | spdy_test_util.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4595 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 4596 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4597 | spdy::SpdySerializedFrame resp(spdy_test_util.ConstructSpdyGetReply( |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 4598 | test_cases[i].extra_headers, test_cases[i].extra_header_count, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4599 | spdy::SpdySerializedFrame body( |
| 4600 | spdy_test_util.ConstructSpdyDataFrame(1, true)); |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 4601 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4602 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 4603 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 4604 | }; |
| 4605 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4606 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4607 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 4608 | nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4609 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4610 | TransactionHelperResult out = helper.output(); |
| 4611 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4612 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 4613 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 4614 | EXPECT_EQ("hello!", out.response_data); |
| 4615 | |
| 4616 | scoped_refptr<HttpResponseHeaders> headers = out.response_info.headers; |
Bence Béky | ad9eb162 | 2020-09-17 16:29:17 | [diff] [blame] | 4617 | ASSERT_TRUE(headers); |
| 4618 | EXPECT_EQ("HTTP/1.1 200", headers->GetStatusLine()); |
olli.raula | 33c282f | 2016-01-21 12:12:49 | [diff] [blame] | 4619 | size_t iter = 0; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 4620 | std::string name, value; |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 4621 | size_t expected_header_index = 0; |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 4622 | while (headers->EnumerateHeaderLines(&iter, &name, &value)) { |
Bence Béky | ad9eb162 | 2020-09-17 16:29:17 | [diff] [blame] | 4623 | ASSERT_LT(expected_header_index, test_cases[i].expected_header_count); |
| 4624 | EXPECT_EQ(name, |
| 4625 | test_cases[i].expected_headers[2 * expected_header_index]); |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 4626 | EXPECT_EQ(value, |
Bence Béky | ad9eb162 | 2020-09-17 16:29:17 | [diff] [blame] | 4627 | test_cases[i].expected_headers[2 * expected_header_index + 1]); |
Bence Béky | e543851 | 2017-11-22 23:07:42 | [diff] [blame] | 4628 | ++expected_header_index; |
[email protected] | 8b07037 | 2009-11-16 22:01:25 | [diff] [blame] | 4629 | } |
Bence Béky | ad9eb162 | 2020-09-17 16:29:17 | [diff] [blame] | 4630 | EXPECT_EQ(expected_header_index, test_cases[i].expected_header_count); |
[email protected] | 3f662f1 | 2010-03-25 19:56:12 | [diff] [blame] | 4631 | } |
| 4632 | } |
| 4633 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 4634 | // Verify that we don't crash on invalid response headers. |
| 4635 | TEST_F(SpdyNetworkTransactionTest, InvalidResponseHeaders) { |
| 4636 | struct InvalidResponseHeadersTests { |
[email protected] | e7f7509 | 2010-07-01 22:39:13 | [diff] [blame] | 4637 | int num_headers; |
| 4638 | const char* headers[10]; |
Bence Béky | ad9eb162 | 2020-09-17 16:29:17 | [diff] [blame] | 4639 | } test_cases[] = {// Response headers missing status header |
| 4640 | {2, {"cookie", "val1", "cookie", "val2", nullptr}}, |
| 4641 | // Response headers with no headers |
| 4642 | {0, {nullptr}}}; |
[email protected] | dd11b93 | 2009-11-30 19:39:48 | [diff] [blame] | 4643 | |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 4644 | for (size_t i = 0; i < base::size(test_cases); ++i) { |
Bence Béky | ad9eb162 | 2020-09-17 16:29:17 | [diff] [blame] | 4645 | SCOPED_TRACE(i); |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4646 | SpdyTestUtil spdy_test_util; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 4647 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4648 | spdy::SpdySerializedFrame req( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 4649 | spdy_test_util.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4650 | spdy::SpdySerializedFrame rst(spdy_test_util.ConstructSpdyRstStream( |
| 4651 | 1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
[email protected] | dd11b93 | 2009-11-30 19:39:48 | [diff] [blame] | 4652 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4653 | CreateMockWrite(req, 0), CreateMockWrite(rst, 2), |
[email protected] | dd11b93 | 2009-11-30 19:39:48 | [diff] [blame] | 4654 | }; |
| 4655 | |
[email protected] | 745aa9c | 2014-06-27 02:21:29 | [diff] [blame] | 4656 | // Construct the reply. |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 4657 | spdy::Http2HeaderBlock reply_headers; |
[email protected] | 745aa9c | 2014-06-27 02:21:29 | [diff] [blame] | 4658 | AppendToHeaderBlock( |
| 4659 | test_cases[i].headers, test_cases[i].num_headers, &reply_headers); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4660 | spdy::SpdySerializedFrame resp( |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 4661 | spdy_test_util.ConstructSpdyReply(1, std::move(reply_headers))); |
[email protected] | dd11b93 | 2009-11-30 19:39:48 | [diff] [blame] | 4662 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4663 | CreateMockRead(resp, 1), MockRead(ASYNC, 0, 3) // EOF |
[email protected] | dd11b93 | 2009-11-30 19:39:48 | [diff] [blame] | 4664 | }; |
| 4665 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4666 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4667 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 4668 | nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4669 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4670 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 4671 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
[email protected] | dd11b93 | 2009-11-30 19:39:48 | [diff] [blame] | 4672 | } |
| 4673 | } |
| 4674 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4675 | TEST_F(SpdyNetworkTransactionTest, CorruptFrameSessionError) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4676 | spdy::SpdySerializedFrame req( |
| 4677 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Zhongyi Shi | 495af807 | 2020-02-28 04:43:48 | [diff] [blame] | 4678 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 4679 | 0, spdy::ERROR_CODE_COMPRESSION_ERROR, |
Bence Béky | a18ae76 | 2021-10-26 01:09:13 | [diff] [blame] | 4680 | "Framer error: 24 (HPACK_TRUNCATED_BLOCK).")); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4681 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(goaway, 2)}; |
[email protected] | e3352df | 2014-03-19 05:55:42 | [diff] [blame] | 4682 | |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 4683 | // This is the length field that's too short. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4684 | spdy::SpdySerializedFrame reply_wrong_length( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 4685 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4686 | size_t right_size = reply_wrong_length.size() - spdy::kFrameHeaderSize; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 4687 | size_t wrong_size = right_size - 4; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4688 | spdy::test::SetFrameLength(&reply_wrong_length, wrong_size); |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 4689 | |
[email protected] | e3352df | 2014-03-19 05:55:42 | [diff] [blame] | 4690 | MockRead reads[] = { |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 4691 | MockRead(ASYNC, reply_wrong_length.data(), reply_wrong_length.size() - 4, |
| 4692 | 1), |
[email protected] | e3352df | 2014-03-19 05:55:42 | [diff] [blame] | 4693 | }; |
| 4694 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4695 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4696 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | e3352df | 2014-03-19 05:55:42 | [diff] [blame] | 4697 | helper.RunToCompletion(&data); |
| 4698 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 4699 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_COMPRESSION_ERROR)); |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4700 | } |
| 4701 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4702 | TEST_F(SpdyNetworkTransactionTest, GoAwayOnDecompressionFailure) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4703 | spdy::SpdySerializedFrame req( |
| 4704 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Zhongyi Shi | 495af807 | 2020-02-28 04:43:48 | [diff] [blame] | 4705 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 4706 | 0, spdy::ERROR_CODE_COMPRESSION_ERROR, |
Bence Béky | a18ae76 | 2021-10-26 01:09:13 | [diff] [blame] | 4707 | "Framer error: 24 (HPACK_TRUNCATED_BLOCK).")); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4708 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(goaway, 2)}; |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4709 | |
| 4710 | // Read HEADERS with corrupted payload. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4711 | spdy::SpdySerializedFrame resp( |
| 4712 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4713 | memset(resp.data() + 12, 0xcf, resp.size() - 12); |
| 4714 | MockRead reads[] = {CreateMockRead(resp, 1)}; |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4715 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4716 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4717 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4718 | helper.RunToCompletion(&data); |
| 4719 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 4720 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_COMPRESSION_ERROR)); |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4721 | } |
| 4722 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4723 | TEST_F(SpdyNetworkTransactionTest, GoAwayOnFrameSizeError) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4724 | spdy::SpdySerializedFrame req( |
| 4725 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 4726 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 4727 | 0, spdy::ERROR_CODE_FRAME_SIZE_ERROR, |
Bence Béky | a18ae76 | 2021-10-26 01:09:13 | [diff] [blame] | 4728 | "Framer error: 9 (INVALID_CONTROL_FRAME_SIZE).")); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4729 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(goaway, 2)}; |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4730 | |
| 4731 | // Read WINDOW_UPDATE with incorrectly-sized payload. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4732 | spdy::SpdySerializedFrame bad_window_update( |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4733 | spdy_util_.ConstructSpdyWindowUpdate(1, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4734 | spdy::test::SetFrameLength(&bad_window_update, bad_window_update.size() - 1); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4735 | MockRead reads[] = {CreateMockRead(bad_window_update, 1)}; |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4736 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4737 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4738 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4739 | helper.RunToCompletion(&data); |
| 4740 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 4741 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_FRAME_SIZE_ERROR)); |
[email protected] | e3352df | 2014-03-19 05:55:42 | [diff] [blame] | 4742 | } |
| 4743 | |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4744 | // Test that we shutdown correctly on write errors. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4745 | TEST_F(SpdyNetworkTransactionTest, WriteError) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4746 | spdy::SpdySerializedFrame req( |
| 4747 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4748 | MockWrite writes[] = { |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4749 | // We'll write 10 bytes successfully |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4750 | MockWrite(ASYNC, req.data(), 10, 1), |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4751 | // Followed by ERROR! |
[email protected] | bdd1b22 | 2014-06-10 11:08:39 | [diff] [blame] | 4752 | MockWrite(ASYNC, ERR_FAILED, 2), |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 4753 | // Session drains and attempts to write a GOAWAY: Another ERROR! |
| 4754 | MockWrite(ASYNC, ERR_FAILED, 3), |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4755 | }; |
| 4756 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 4757 | MockRead reads[] = {MockRead(SYNCHRONOUS, ERR_IO_PENDING, 0)}; |
[email protected] | 238002d | 2013-10-17 02:01:40 | [diff] [blame] | 4758 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4759 | SequencedSocketData data(reads, writes); |
[email protected] | 238002d | 2013-10-17 02:01:40 | [diff] [blame] | 4760 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4761 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 238002d | 2013-10-17 02:01:40 | [diff] [blame] | 4762 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 4763 | helper.AddData(&data); |
[email protected] | 238002d | 2013-10-17 02:01:40 | [diff] [blame] | 4764 | EXPECT_TRUE(helper.StartDefaultTest()); |
[email protected] | 238002d | 2013-10-17 02:01:40 | [diff] [blame] | 4765 | helper.FinishDefaultTest(); |
rch | 37de576c | 2015-05-17 20:28:17 | [diff] [blame] | 4766 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 4767 | EXPECT_TRUE(data.AllReadDataConsumed()); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4768 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4769 | EXPECT_THAT(out.rv, IsError(ERR_FAILED)); |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4770 | } |
| 4771 | |
| 4772 | // Test that partial writes work. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4773 | TEST_F(SpdyNetworkTransactionTest, PartialWrite) { |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 4774 | // Chop the HEADERS frame into 5 chunks. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4775 | spdy::SpdySerializedFrame req( |
| 4776 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4777 | const int kChunks = 5; |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 4778 | std::unique_ptr<MockWrite[]> writes = ChopWriteFrame(req, kChunks); |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 4779 | for (int i = 0; i < kChunks; ++i) { |
| 4780 | writes[i].sequence_number = i; |
| 4781 | } |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4782 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4783 | spdy::SpdySerializedFrame resp( |
| 4784 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 4785 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4786 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4787 | CreateMockRead(resp, kChunks), CreateMockRead(body, kChunks + 1), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 4788 | MockRead(ASYNC, 0, kChunks + 2) // EOF |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4789 | }; |
| 4790 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4791 | SequencedSocketData data(reads, base::make_span(writes.get(), kChunks)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4792 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4793 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4794 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4795 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 4796 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | bf2491a9 | 2009-11-29 16:39:48 | [diff] [blame] | 4797 | EXPECT_EQ("hello!", out.response_data); |
| 4798 | } |
| 4799 | |
[email protected] | 9e743cd | 2010-03-16 07:03:53 | [diff] [blame] | 4800 | // Test that the NetLog contains good data for a simple GET request. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4801 | TEST_F(SpdyNetworkTransactionTest, NetLog) { |
[email protected] | 3deb9a5 | 2010-11-11 00:24:40 | [diff] [blame] | 4802 | static const char* const kExtraHeaders[] = { |
| 4803 | "user-agent", "Chrome", |
| 4804 | }; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4805 | spdy::SpdySerializedFrame req( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 4806 | spdy_util_.ConstructSpdyGet(kExtraHeaders, 1, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4807 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4808 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4809 | spdy::SpdySerializedFrame resp( |
| 4810 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 4811 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4812 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4813 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 4814 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4815 | }; |
| 4816 | |
Matt Reichhoff | 0049a0b7 | 2021-10-20 20:44:26 | [diff] [blame] | 4817 | RecordingNetLogObserver net_log_observer; |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4818 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4819 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4820 | request_.extra_headers.SetHeader("User-Agent", "Chrome"); |
Matt Reichhoff | 0049a0b7 | 2021-10-20 20:44:26 | [diff] [blame] | 4821 | NormalSpdyTransactionHelper helper( |
| 4822 | request_, DEFAULT_PRIORITY, |
| 4823 | NetLogWithSource::Make(NetLogSourceType::NONE), nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4824 | helper.RunToCompletion(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4825 | TransactionHelperResult out = helper.output(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4826 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 4827 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4828 | EXPECT_EQ("hello!", out.response_data); |
| 4829 | |
[email protected] | 9e743cd | 2010-03-16 07:03:53 | [diff] [blame] | 4830 | // Check that the NetLog was filled reasonably. |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4831 | // This test is intentionally non-specific about the exact ordering of the |
| 4832 | // log; instead we just check to make sure that certain events exist, and that |
| 4833 | // they are in the right order. |
Matt Reichhoff | 0049a0b7 | 2021-10-20 20:44:26 | [diff] [blame] | 4834 | auto entries = net_log_observer.GetEntries(); |
[email protected] | b2fcd0e | 2010-12-01 15:19:40 | [diff] [blame] | 4835 | |
| 4836 | EXPECT_LT(0u, entries.size()); |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4837 | int pos = 0; |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 4838 | pos = ExpectLogContainsSomewhere( |
| 4839 | entries, 0, NetLogEventType::HTTP_TRANSACTION_SEND_REQUEST, |
| 4840 | NetLogEventPhase::BEGIN); |
| 4841 | pos = ExpectLogContainsSomewhere( |
| 4842 | entries, pos + 1, NetLogEventType::HTTP_TRANSACTION_SEND_REQUEST, |
| 4843 | NetLogEventPhase::END); |
| 4844 | pos = ExpectLogContainsSomewhere( |
| 4845 | entries, pos + 1, NetLogEventType::HTTP_TRANSACTION_READ_HEADERS, |
| 4846 | NetLogEventPhase::BEGIN); |
| 4847 | pos = ExpectLogContainsSomewhere( |
| 4848 | entries, pos + 1, NetLogEventType::HTTP_TRANSACTION_READ_HEADERS, |
| 4849 | NetLogEventPhase::END); |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 4850 | pos = ExpectLogContainsSomewhere(entries, pos + 1, |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 4851 | NetLogEventType::HTTP_TRANSACTION_READ_BODY, |
| 4852 | NetLogEventPhase::BEGIN); |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 4853 | pos = ExpectLogContainsSomewhere(entries, pos + 1, |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 4854 | NetLogEventType::HTTP_TRANSACTION_READ_BODY, |
| 4855 | NetLogEventPhase::END); |
[email protected] | 3deb9a5 | 2010-11-11 00:24:40 | [diff] [blame] | 4856 | |
| 4857 | // Check that we logged all the headers correctly |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 4858 | pos = ExpectLogContainsSomewhere(entries, 0, |
| 4859 | NetLogEventType::HTTP2_SESSION_SEND_HEADERS, |
| 4860 | NetLogEventPhase::NONE); |
[email protected] | 3deb9a5 | 2010-11-11 00:24:40 | [diff] [blame] | 4861 | |
Eric Roman | 79cc755 | 2019-07-19 02:17:54 | [diff] [blame] | 4862 | ASSERT_TRUE(entries[pos].HasParams()); |
| 4863 | auto* header_list = entries[pos].params.FindKey("headers"); |
Bence Béky | 66871e3 | 2018-12-06 21:11:24 | [diff] [blame] | 4864 | ASSERT_TRUE(header_list); |
| 4865 | ASSERT_TRUE(header_list->is_list()); |
| 4866 | ASSERT_EQ(5u, header_list->GetList().size()); |
[email protected] | f3da152d | 2012-06-02 01:00:57 | [diff] [blame] | 4867 | |
Bence Béky | 66871e3 | 2018-12-06 21:11:24 | [diff] [blame] | 4868 | ASSERT_TRUE(header_list->GetList()[0].is_string()); |
| 4869 | EXPECT_EQ(":method: GET", header_list->GetList()[0].GetString()); |
| 4870 | |
| 4871 | ASSERT_TRUE(header_list->GetList()[1].is_string()); |
| 4872 | EXPECT_EQ(":authority: www.example.org", |
| 4873 | header_list->GetList()[1].GetString()); |
| 4874 | |
| 4875 | ASSERT_TRUE(header_list->GetList()[2].is_string()); |
| 4876 | EXPECT_EQ(":scheme: https", header_list->GetList()[2].GetString()); |
| 4877 | |
| 4878 | ASSERT_TRUE(header_list->GetList()[3].is_string()); |
| 4879 | EXPECT_EQ(":path: /", header_list->GetList()[3].GetString()); |
| 4880 | |
| 4881 | ASSERT_TRUE(header_list->GetList()[4].is_string()); |
| 4882 | EXPECT_EQ("user-agent: Chrome", header_list->GetList()[4].GetString()); |
[email protected] | dac35804 | 2009-12-18 02:07:48 | [diff] [blame] | 4883 | } |
| 4884 | |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4885 | // Since we buffer the IO from the stream to the renderer, this test verifies |
| 4886 | // that when we read out the maximum amount of data (e.g. we received 50 bytes |
| 4887 | // on the network, but issued a Read for only 5 of those bytes) that the data |
| 4888 | // flow still works correctly. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4889 | TEST_F(SpdyNetworkTransactionTest, BufferFull) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4890 | spdy::SpdySerializedFrame req( |
| 4891 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4892 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4893 | |
[email protected] | 20d005f | 2010-07-02 19:55:43 | [diff] [blame] | 4894 | // 2 data frames in a single read. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4895 | spdy::SpdySerializedFrame data_frame_1( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4896 | spdy_util_.ConstructSpdyDataFrame(1, "goodby", /*fin=*/false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4897 | spdy::SpdySerializedFrame data_frame_2( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4898 | spdy_util_.ConstructSpdyDataFrame(1, "e worl", /*fin=*/false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4899 | spdy::SpdySerializedFrame combined_data_frames = |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 4900 | CombineFrames({&data_frame_1, &data_frame_2}); |
| 4901 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4902 | spdy::SpdySerializedFrame last_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4903 | spdy_util_.ConstructSpdyDataFrame(1, "d", /*fin=*/true)); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4904 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4905 | spdy::SpdySerializedFrame resp( |
| 4906 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4907 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4908 | CreateMockRead(resp, 1), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 4909 | MockRead(ASYNC, ERR_IO_PENDING, 2), // Force a pause |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 4910 | CreateMockRead(combined_data_frames, 3), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 4911 | MockRead(ASYNC, ERR_IO_PENDING, 4), // Force a pause |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4912 | CreateMockRead(last_frame, 5), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 4913 | MockRead(ASYNC, 0, 6) // EOF |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4914 | }; |
| 4915 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4916 | SequencedSocketData data(reads, writes); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4917 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 4918 | TestCompletionCallback callback; |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4919 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4920 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4921 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 4922 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4923 | HttpNetworkTransaction* trans = helper.trans(); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4924 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4925 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4926 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4927 | TransactionHelperResult out = helper.output(); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4928 | out.rv = callback.WaitForResult(); |
| 4929 | EXPECT_EQ(out.rv, OK); |
| 4930 | |
| 4931 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 4932 | EXPECT_TRUE(response->headers); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4933 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 4934 | out.status_line = response->headers->GetStatusLine(); |
| 4935 | out.response_info = *response; // Make a copy so we can verify. |
| 4936 | |
| 4937 | // Read Data |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 4938 | TestCompletionCallback read_callback; |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4939 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 4940 | std::string content; |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4941 | do { |
| 4942 | // Read small chunks at a time. |
| 4943 | const int kSmallReadSize = 3; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 4944 | scoped_refptr<IOBuffer> buf = |
| 4945 | base::MakeRefCounted<IOBuffer>(kSmallReadSize); |
[email protected] | 9049948 | 2013-06-01 00:39:50 | [diff] [blame] | 4946 | rv = trans->Read(buf.get(), kSmallReadSize, read_callback.callback()); |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 4947 | if (rv == ERR_IO_PENDING) { |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 4948 | data.Resume(); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4949 | rv = read_callback.WaitForResult(); |
| 4950 | } |
| 4951 | if (rv > 0) { |
| 4952 | content.append(buf->data(), rv); |
| 4953 | } else if (rv < 0) { |
| 4954 | NOTREACHED(); |
| 4955 | } |
| 4956 | } while (rv > 0); |
| 4957 | |
| 4958 | out.response_data.swap(content); |
| 4959 | |
[email protected] | 30c942b | 2010-07-21 16:59:59 | [diff] [blame] | 4960 | // Flush the MessageLoop while the SpdySessionDependencies (in particular, the |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4961 | // MockClientSocketFactory) are still alive. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 4962 | base::RunLoop().RunUntilIdle(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4963 | |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4964 | // Verify that we consumed all test data. |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4965 | helper.VerifyDataConsumed(); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4966 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4967 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 4968 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 79d8422 | 2010-02-26 00:01:44 | [diff] [blame] | 4969 | EXPECT_EQ("goodbye world", out.response_data); |
| 4970 | } |
| 4971 | |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4972 | // Verify that basic buffering works; when multiple data frames arrive |
| 4973 | // at the same time, ensure that we don't notify a read completion for |
| 4974 | // each data frame individually. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 4975 | TEST_F(SpdyNetworkTransactionTest, Buffering) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4976 | spdy::SpdySerializedFrame req( |
| 4977 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4978 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4979 | |
| 4980 | // 4 data frames in a single read. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4981 | spdy::SpdySerializedFrame data_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4982 | spdy_util_.ConstructSpdyDataFrame(1, "message", /*fin=*/false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4983 | spdy::SpdySerializedFrame data_frame_fin( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 4984 | spdy_util_.ConstructSpdyDataFrame(1, "message", /*fin=*/true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4985 | spdy::SpdySerializedFrame combined_data_frames = |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 4986 | CombineFrames({&data_frame, &data_frame, &data_frame, &data_frame_fin}); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4987 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 4988 | spdy::SpdySerializedFrame resp( |
| 4989 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4990 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 4991 | CreateMockRead(resp, 1), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 4992 | MockRead(ASYNC, ERR_IO_PENDING, 2), // Force a pause |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 4993 | CreateMockRead(combined_data_frames, 3), MockRead(ASYNC, 0, 4) // EOF |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4994 | }; |
| 4995 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 4996 | SequencedSocketData data(reads, writes); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 4997 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 4998 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 4999 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 5000 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5001 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5002 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5003 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5004 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5005 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5006 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5007 | TransactionHelperResult out = helper.output(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5008 | out.rv = callback.WaitForResult(); |
| 5009 | EXPECT_EQ(out.rv, OK); |
| 5010 | |
| 5011 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5012 | EXPECT_TRUE(response->headers); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5013 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 5014 | out.status_line = response->headers->GetStatusLine(); |
| 5015 | out.response_info = *response; // Make a copy so we can verify. |
| 5016 | |
| 5017 | // Read Data |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5018 | TestCompletionCallback read_callback; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5019 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5020 | std::string content; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5021 | int reads_completed = 0; |
| 5022 | do { |
| 5023 | // Read small chunks at a time. |
| 5024 | const int kSmallReadSize = 14; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 5025 | scoped_refptr<IOBuffer> buf = |
| 5026 | base::MakeRefCounted<IOBuffer>(kSmallReadSize); |
[email protected] | 9049948 | 2013-06-01 00:39:50 | [diff] [blame] | 5027 | rv = trans->Read(buf.get(), kSmallReadSize, read_callback.callback()); |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 5028 | if (rv == ERR_IO_PENDING) { |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 5029 | data.Resume(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5030 | rv = read_callback.WaitForResult(); |
| 5031 | } |
| 5032 | if (rv > 0) { |
| 5033 | EXPECT_EQ(kSmallReadSize, rv); |
| 5034 | content.append(buf->data(), rv); |
| 5035 | } else if (rv < 0) { |
| 5036 | FAIL() << "Unexpected read error: " << rv; |
| 5037 | } |
| 5038 | reads_completed++; |
| 5039 | } while (rv > 0); |
| 5040 | |
| 5041 | EXPECT_EQ(3, reads_completed); // Reads are: 14 bytes, 14 bytes, 0 bytes. |
| 5042 | |
| 5043 | out.response_data.swap(content); |
| 5044 | |
[email protected] | 30c942b | 2010-07-21 16:59:59 | [diff] [blame] | 5045 | // Flush the MessageLoop while the SpdySessionDependencies (in particular, the |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5046 | // MockClientSocketFactory) are still alive. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 5047 | base::RunLoop().RunUntilIdle(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5048 | |
| 5049 | // Verify that we consumed all test data. |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5050 | helper.VerifyDataConsumed(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5051 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5052 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 5053 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5054 | EXPECT_EQ("messagemessagemessagemessage", out.response_data); |
| 5055 | } |
| 5056 | |
| 5057 | // Verify the case where we buffer data but read it after it has been buffered. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5058 | TEST_F(SpdyNetworkTransactionTest, BufferedAll) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5059 | spdy::SpdySerializedFrame req( |
| 5060 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5061 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5062 | |
[email protected] | 20d005f | 2010-07-02 19:55:43 | [diff] [blame] | 5063 | // 5 data frames in a single read. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5064 | spdy::SpdySerializedFrame reply( |
| 5065 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 5066 | spdy::SpdySerializedFrame data_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 5067 | spdy_util_.ConstructSpdyDataFrame(1, "message", /*fin=*/false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5068 | spdy::SpdySerializedFrame data_frame_fin( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 5069 | spdy_util_.ConstructSpdyDataFrame(1, "message", /*fin=*/true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5070 | spdy::SpdySerializedFrame combined_frames = CombineFrames( |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 5071 | {&reply, &data_frame, &data_frame, &data_frame, &data_frame_fin}); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5072 | |
| 5073 | MockRead reads[] = { |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 5074 | CreateMockRead(combined_frames, 1), MockRead(ASYNC, 0, 2) // EOF |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5075 | }; |
| 5076 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5077 | SequencedSocketData data(reads, writes); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5078 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5079 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5080 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 5081 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5082 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5083 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5084 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5085 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5086 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5087 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5088 | TransactionHelperResult out = helper.output(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5089 | out.rv = callback.WaitForResult(); |
| 5090 | EXPECT_EQ(out.rv, OK); |
| 5091 | |
| 5092 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5093 | EXPECT_TRUE(response->headers); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5094 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 5095 | out.status_line = response->headers->GetStatusLine(); |
| 5096 | out.response_info = *response; // Make a copy so we can verify. |
| 5097 | |
| 5098 | // Read Data |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5099 | TestCompletionCallback read_callback; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5100 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5101 | std::string content; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5102 | int reads_completed = 0; |
| 5103 | do { |
| 5104 | // Read small chunks at a time. |
| 5105 | const int kSmallReadSize = 14; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 5106 | scoped_refptr<IOBuffer> buf = |
| 5107 | base::MakeRefCounted<IOBuffer>(kSmallReadSize); |
[email protected] | 9049948 | 2013-06-01 00:39:50 | [diff] [blame] | 5108 | rv = trans->Read(buf.get(), kSmallReadSize, read_callback.callback()); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5109 | if (rv > 0) { |
| 5110 | EXPECT_EQ(kSmallReadSize, rv); |
| 5111 | content.append(buf->data(), rv); |
| 5112 | } else if (rv < 0) { |
| 5113 | FAIL() << "Unexpected read error: " << rv; |
| 5114 | } |
| 5115 | reads_completed++; |
| 5116 | } while (rv > 0); |
| 5117 | |
| 5118 | EXPECT_EQ(3, reads_completed); |
| 5119 | |
| 5120 | out.response_data.swap(content); |
| 5121 | |
[email protected] | 30c942b | 2010-07-21 16:59:59 | [diff] [blame] | 5122 | // Flush the MessageLoop while the SpdySessionDependencies (in particular, the |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5123 | // MockClientSocketFactory) are still alive. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 5124 | base::RunLoop().RunUntilIdle(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5125 | |
| 5126 | // Verify that we consumed all test data. |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5127 | helper.VerifyDataConsumed(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5128 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5129 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 5130 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5131 | EXPECT_EQ("messagemessagemessagemessage", out.response_data); |
| 5132 | } |
| 5133 | |
| 5134 | // Verify the case where we buffer data and close the connection. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5135 | TEST_F(SpdyNetworkTransactionTest, BufferedClosed) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5136 | spdy::SpdySerializedFrame req( |
| 5137 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5138 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5139 | |
| 5140 | // All data frames in a single read. |
[email protected] | 20d005f | 2010-07-02 19:55:43 | [diff] [blame] | 5141 | // NOTE: We don't FIN the stream. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5142 | spdy::SpdySerializedFrame data_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 5143 | spdy_util_.ConstructSpdyDataFrame(1, "message", /*fin=*/false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5144 | spdy::SpdySerializedFrame combined_data_frames = |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 5145 | CombineFrames({&data_frame, &data_frame, &data_frame, &data_frame}); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5146 | spdy::SpdySerializedFrame resp( |
| 5147 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5148 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5149 | CreateMockRead(resp, 1), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 5150 | MockRead(ASYNC, ERR_IO_PENDING, 2), // Force a wait |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 5151 | CreateMockRead(combined_data_frames, 3), MockRead(ASYNC, 0, 4) // EOF |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5152 | }; |
| 5153 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5154 | SequencedSocketData data(reads, writes); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5155 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5156 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5157 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 5158 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5159 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5160 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5161 | TestCompletionCallback callback; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5162 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5163 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5164 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5165 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5166 | TransactionHelperResult out = helper.output(); |
Francois Doray | 6bbf45e | 2021-06-30 19:06:51 | [diff] [blame] | 5167 | rv = callback.WaitForResult(); |
| 5168 | EXPECT_EQ(rv, OK); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5169 | |
| 5170 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5171 | EXPECT_TRUE(response->headers); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5172 | EXPECT_TRUE(response->was_fetched_via_spdy); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5173 | |
| 5174 | // Read Data |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5175 | TestCompletionCallback read_callback; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5176 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5177 | std::string content; |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5178 | int reads_completed = 0; |
| 5179 | do { |
Francois Doray | 6bbf45e | 2021-06-30 19:06:51 | [diff] [blame] | 5180 | // Allocate a large buffer to allow buffering. If a single read fills the |
| 5181 | // buffer, no buffering happens. |
| 5182 | const int kLargeReadSize = 1000; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 5183 | scoped_refptr<IOBuffer> buf = |
Francois Doray | 6bbf45e | 2021-06-30 19:06:51 | [diff] [blame] | 5184 | base::MakeRefCounted<IOBuffer>(kLargeReadSize); |
| 5185 | rv = trans->Read(buf.get(), kLargeReadSize, read_callback.callback()); |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 5186 | if (rv == ERR_IO_PENDING) { |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 5187 | data.Resume(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5188 | rv = read_callback.WaitForResult(); |
| 5189 | } |
Francois Doray | 6bbf45e | 2021-06-30 19:06:51 | [diff] [blame] | 5190 | |
| 5191 | if (rv < 0) { |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5192 | // This test intentionally closes the connection, and will get an error. |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5193 | EXPECT_THAT(rv, IsError(ERR_CONNECTION_CLOSED)); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5194 | break; |
| 5195 | } |
| 5196 | reads_completed++; |
| 5197 | } while (rv > 0); |
| 5198 | |
| 5199 | EXPECT_EQ(0, reads_completed); |
| 5200 | |
[email protected] | 30c942b | 2010-07-21 16:59:59 | [diff] [blame] | 5201 | // Flush the MessageLoop while the SpdySessionDependencies (in particular, the |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5202 | // MockClientSocketFactory) are still alive. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 5203 | base::RunLoop().RunUntilIdle(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5204 | |
| 5205 | // Verify that we consumed all test data. |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5206 | helper.VerifyDataConsumed(); |
[email protected] | 8918d28 | 2010-03-02 00:57:55 | [diff] [blame] | 5207 | } |
| 5208 | |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 5209 | // Verify the case where we buffer data and cancel the transaction. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5210 | TEST_F(SpdyNetworkTransactionTest, BufferedCancelled) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5211 | spdy::SpdySerializedFrame req( |
| 5212 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 5213 | spdy::SpdySerializedFrame rst( |
| 5214 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_CANCEL)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5215 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(rst, 4)}; |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 5216 | |
[email protected] | 20d005f | 2010-07-02 19:55:43 | [diff] [blame] | 5217 | // NOTE: We don't FIN the stream. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5218 | spdy::SpdySerializedFrame data_frame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 5219 | spdy_util_.ConstructSpdyDataFrame(1, "message", /*fin=*/false)); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 5220 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5221 | spdy::SpdySerializedFrame resp( |
| 5222 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 5223 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5224 | CreateMockRead(resp, 1), |
| 5225 | MockRead(ASYNC, ERR_IO_PENDING, 2), // Force a wait |
| 5226 | CreateMockRead(data_frame, 3), MockRead(ASYNC, 0, 5) // EOF |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 5227 | }; |
| 5228 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5229 | SequencedSocketData data(reads, writes); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 5230 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5231 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5232 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 5233 | helper.AddData(&data); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5234 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5235 | TestCompletionCallback callback; |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 5236 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5237 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5238 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 5239 | |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5240 | TransactionHelperResult out = helper.output(); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 5241 | out.rv = callback.WaitForResult(); |
| 5242 | EXPECT_EQ(out.rv, OK); |
| 5243 | |
| 5244 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5245 | EXPECT_TRUE(response->headers); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 5246 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 5247 | out.status_line = response->headers->GetStatusLine(); |
| 5248 | out.response_info = *response; // Make a copy so we can verify. |
| 5249 | |
| 5250 | // Read Data |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5251 | TestCompletionCallback read_callback; |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 5252 | |
[email protected] | 88c7b4be | 2014-03-19 23:04:01 | [diff] [blame] | 5253 | const int kReadSize = 256; |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 5254 | scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(kReadSize); |
[email protected] | 88c7b4be | 2014-03-19 23:04:01 | [diff] [blame] | 5255 | rv = trans->Read(buf.get(), kReadSize, read_callback.callback()); |
bnc | 301745a | 2015-03-10 03:22:16 | [diff] [blame] | 5256 | ASSERT_EQ(ERR_IO_PENDING, rv) << "Unexpected read: " << rv; |
[email protected] | 88c7b4be | 2014-03-19 23:04:01 | [diff] [blame] | 5257 | |
| 5258 | // Complete the read now, which causes buffering to start. |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 5259 | data.Resume(); |
| 5260 | base::RunLoop().RunUntilIdle(); |
[email protected] | 88c7b4be | 2014-03-19 23:04:01 | [diff] [blame] | 5261 | // Destroy the transaction, causing the stream to get cancelled |
| 5262 | // and orphaning the buffered IO task. |
| 5263 | helper.ResetTrans(); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 5264 | |
| 5265 | // Flush the MessageLoop; this will cause the buffered IO task |
| 5266 | // to run for the final time. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 5267 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5268 | |
| 5269 | // Verify that we consumed all test data. |
| 5270 | helper.VerifyDataConsumed(); |
[email protected] | 1ed7b3dc | 2010-03-04 05:41:45 | [diff] [blame] | 5271 | } |
| 5272 | |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 5273 | // Request should fail upon receiving a GOAWAY frame |
| 5274 | // with Last-Stream-ID lower than the stream id corresponding to the request |
| 5275 | // and with error code other than NO_ERROR. |
| 5276 | TEST_F(SpdyNetworkTransactionTest, FailOnGoAway) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5277 | spdy::SpdySerializedFrame req( |
| 5278 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5279 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | 69d717bd | 2010-04-21 18:43:21 | [diff] [blame] | 5280 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5281 | spdy::SpdySerializedFrame go_away( |
| 5282 | spdy_util_.ConstructSpdyGoAway(0, spdy::ERROR_CODE_INTERNAL_ERROR, "")); |
[email protected] | 69d717bd | 2010-04-21 18:43:21 | [diff] [blame] | 5283 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5284 | CreateMockRead(go_away, 1), |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5285 | }; |
| 5286 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5287 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5288 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 5289 | helper.RunToCompletion(&data); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5290 | TransactionHelperResult out = helper.output(); |
Matt Menke | 3b52f9f | 2020-06-08 20:04:03 | [diff] [blame] | 5291 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
[email protected] | 69d717bd | 2010-04-21 18:43:21 | [diff] [blame] | 5292 | } |
| 5293 | |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 5294 | // Request should be retried on a new connection upon receiving a GOAWAY frame |
| 5295 | // with Last-Stream-ID lower than the stream id corresponding to the request |
| 5296 | // and with error code NO_ERROR. |
| 5297 | TEST_F(SpdyNetworkTransactionTest, RetryOnGoAway) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5298 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 5299 | |
| 5300 | // First connection. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5301 | spdy::SpdySerializedFrame req( |
| 5302 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 5303 | MockWrite writes1[] = {CreateMockWrite(req, 0)}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5304 | spdy::SpdySerializedFrame go_away( |
| 5305 | spdy_util_.ConstructSpdyGoAway(0, spdy::ERROR_CODE_NO_ERROR, "")); |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 5306 | MockRead reads1[] = {CreateMockRead(go_away, 1)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5307 | SequencedSocketData data1(reads1, writes1); |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 5308 | helper.AddData(&data1); |
| 5309 | |
| 5310 | // Second connection. |
| 5311 | MockWrite writes2[] = {CreateMockWrite(req, 0)}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5312 | spdy::SpdySerializedFrame resp( |
| 5313 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 5314 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 5315 | MockRead reads2[] = {CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 5316 | MockRead(ASYNC, 0, 3)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5317 | SequencedSocketData data2(reads2, writes2); |
bnc | c4769d41 | 2017-04-19 19:57:54 | [diff] [blame] | 5318 | helper.AddData(&data2); |
| 5319 | |
| 5320 | helper.RunPreTestSetup(); |
| 5321 | helper.RunDefaultTest(); |
| 5322 | |
| 5323 | TransactionHelperResult out = helper.output(); |
| 5324 | EXPECT_THAT(out.rv, IsOk()); |
| 5325 | |
| 5326 | helper.VerifyDataConsumed(); |
| 5327 | } |
| 5328 | |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 5329 | // A server can gracefully shut down by sending a GOAWAY frame |
| 5330 | // with maximum last-stream-id value. |
| 5331 | // Transactions started before receiving such a GOAWAY frame should succeed, |
| 5332 | // but SpdySession should be unavailable for new streams. |
| 5333 | TEST_F(SpdyNetworkTransactionTest, GracefulGoaway) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5334 | spdy::SpdySerializedFrame req1( |
| 5335 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 5336 | spdy_util_.UpdateWithStreamDestruction(1); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5337 | spdy::SpdySerializedFrame req2( |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 5338 | spdy_util_.ConstructSpdyGet("https://www.example.org/foo", 3, LOWEST)); |
| 5339 | MockWrite writes[] = {CreateMockWrite(req1, 0), CreateMockWrite(req2, 3)}; |
| 5340 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5341 | spdy::SpdySerializedFrame resp1( |
| 5342 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 5343 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 5344 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 5345 | 0x7fffffff, spdy::ERROR_CODE_NO_ERROR, "Graceful shutdown.")); |
| 5346 | spdy::SpdySerializedFrame resp2( |
| 5347 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 5348 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 5349 | MockRead reads[] = {CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 5350 | CreateMockRead(goaway, 4), CreateMockRead(resp2, 5), |
| 5351 | CreateMockRead(body2, 6), MockRead(ASYNC, 0, 7)}; |
| 5352 | |
| 5353 | // Run first transaction. |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5354 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5355 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 5356 | helper.RunPreTestSetup(); |
| 5357 | helper.AddData(&data); |
| 5358 | helper.RunDefaultTest(); |
| 5359 | |
| 5360 | // Verify first response. |
| 5361 | TransactionHelperResult out = helper.output(); |
| 5362 | EXPECT_THAT(out.rv, IsOk()); |
| 5363 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 5364 | EXPECT_EQ("hello!", out.response_data); |
| 5365 | |
| 5366 | // GOAWAY frame has not yet been received, SpdySession should be available. |
| 5367 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 5368 | SpdySessionKey key(host_port_pair_, ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 5369 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 5370 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 5371 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 5372 | base::WeakPtr<SpdySession> spdy_session = |
bnc | 9ead3ae | 2017-03-16 00:48:15 | [diff] [blame] | 5373 | spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 5374 | key, /* enable_ip_based_pooling = */ true, |
| 5375 | /* is_websocket = */ false, log_); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 5376 | EXPECT_TRUE(spdy_session); |
| 5377 | |
| 5378 | // Start second transaction. |
| 5379 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 5380 | TestCompletionCallback callback; |
| 5381 | HttpRequestInfo request2; |
| 5382 | request2.method = "GET"; |
| 5383 | request2.url = GURL("https://www.example.org/foo"); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 5384 | request2.traffic_annotation = |
| 5385 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 5386 | int rv = trans2.Start(&request2, callback.callback(), log_); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 5387 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 5388 | rv = callback.WaitForResult(); |
| 5389 | EXPECT_THAT(rv, IsOk()); |
| 5390 | |
| 5391 | // Verify second response. |
| 5392 | const HttpResponseInfo* response = trans2.GetResponseInfo(); |
| 5393 | ASSERT_TRUE(response); |
| 5394 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, response->connection_info); |
| 5395 | ASSERT_TRUE(response->headers); |
| 5396 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 5397 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 5398 | EXPECT_TRUE(response->was_alpn_negotiated); |
Tsuyoshi Horo | 01faed6 | 2019-02-20 22:11:37 | [diff] [blame] | 5399 | EXPECT_EQ("127.0.0.1", response->remote_endpoint.ToStringWithoutPort()); |
| 5400 | EXPECT_EQ(443, response->remote_endpoint.port()); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5401 | std::string response_data; |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 5402 | rv = ReadTransaction(&trans2, &response_data); |
| 5403 | EXPECT_THAT(rv, IsOk()); |
| 5404 | EXPECT_EQ("hello!", response_data); |
| 5405 | |
| 5406 | // Graceful GOAWAY was received, SpdySession should be unavailable. |
bnc | 9ead3ae | 2017-03-16 00:48:15 | [diff] [blame] | 5407 | spdy_session = spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 5408 | key, /* enable_ip_based_pooling = */ true, |
| 5409 | /* is_websocket = */ false, log_); |
bnc | 1fc7b35 | 2017-01-12 17:51:02 | [diff] [blame] | 5410 | EXPECT_FALSE(spdy_session); |
| 5411 | |
| 5412 | helper.VerifyDataConsumed(); |
| 5413 | } |
| 5414 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5415 | TEST_F(SpdyNetworkTransactionTest, CloseWithActiveStream) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5416 | spdy::SpdySerializedFrame req( |
| 5417 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5418 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 5419 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5420 | spdy::SpdySerializedFrame resp( |
| 5421 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 5422 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5423 | CreateMockRead(resp, 1), MockRead(SYNCHRONOUS, 0, 2) // EOF |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 5424 | }; |
| 5425 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5426 | SequencedSocketData data(reads, writes); |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 5427 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5428 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5429 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 5430 | helper.AddData(&data); |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 5431 | helper.StartDefaultTest(); |
| 5432 | EXPECT_THAT(helper.output().rv, IsError(ERR_IO_PENDING)); |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 5433 | |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 5434 | helper.WaitForCallbackToComplete(); |
| 5435 | EXPECT_THAT(helper.output().rv, IsError(ERR_CONNECTION_CLOSED)); |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5436 | |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 5437 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5438 | EXPECT_TRUE(response->headers); |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 5439 | EXPECT_TRUE(response->was_fetched_via_spdy); |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 5440 | |
| 5441 | // Verify that we consumed all test data. |
[email protected] | 3caf554 | 2010-07-16 15:19:47 | [diff] [blame] | 5442 | helper.VerifyDataConsumed(); |
[email protected] | f5ed2155 | 2010-05-04 18:39:54 | [diff] [blame] | 5443 | } |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 5444 | |
Bence Béky | c2d3795 | 2017-11-20 16:58:16 | [diff] [blame] | 5445 | TEST_F(SpdyNetworkTransactionTest, GoAwayImmediately) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5446 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway(1)); |
Bence Béky | c2d3795 | 2017-11-20 16:58:16 | [diff] [blame] | 5447 | MockRead reads[] = {CreateMockRead(goaway, 0, SYNCHRONOUS)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5448 | SequencedSocketData data(reads, base::span<MockWrite>()); |
Bence Béky | c2d3795 | 2017-11-20 16:58:16 | [diff] [blame] | 5449 | |
| 5450 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 5451 | helper.RunPreTestSetup(); |
| 5452 | helper.AddData(&data); |
| 5453 | helper.StartDefaultTest(); |
| 5454 | EXPECT_THAT(helper.output().rv, IsError(ERR_IO_PENDING)); |
| 5455 | |
| 5456 | helper.WaitForCallbackToComplete(); |
| 5457 | EXPECT_THAT(helper.output().rv, IsError(ERR_CONNECTION_CLOSED)); |
| 5458 | |
| 5459 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
| 5460 | EXPECT_FALSE(response->headers); |
| 5461 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 5462 | |
| 5463 | // Verify that we consumed all test data. |
| 5464 | helper.VerifyDataConsumed(); |
| 5465 | } |
| 5466 | |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5467 | // Retry with HTTP/1.1 when receiving HTTP_1_1_REQUIRED. Note that no actual |
| 5468 | // protocol negotiation happens, instead this test forces protocols for both |
| 5469 | // sockets. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5470 | TEST_F(SpdyNetworkTransactionTest, HTTP11RequiredRetry) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5471 | request_.method = "GET"; |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5472 | // Do not force SPDY so that second socket can negotiate HTTP/1.1. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5473 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5474 | |
| 5475 | // First socket: HTTP/2 request rejected with HTTP_1_1_REQUIRED. |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 5476 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5477 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 5478 | spdy::SpdySerializedFrame req( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 5479 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers), LOWEST, true)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5480 | MockWrite writes0[] = {CreateMockWrite(req, 0)}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5481 | spdy::SpdySerializedFrame rst( |
| 5482 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_HTTP_1_1_REQUIRED)); |
Bence Béky | cb361312 | 2017-09-19 17:06:57 | [diff] [blame] | 5483 | MockRead reads0[] = {CreateMockRead(rst, 1)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5484 | SequencedSocketData data0(reads0, writes0); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5485 | |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5486 | auto ssl_provider0 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5487 | // Expect HTTP/2 protocols too in SSLConfig. |
Bence Béky | 27a19b8 | 2018-01-30 14:58:36 | [diff] [blame] | 5488 | ssl_provider0->next_protos_expected_in_ssl_config = |
| 5489 | NextProtoVector{kProtoHTTP2, kProtoHTTP11}; |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5490 | // Force SPDY. |
bnc | 3cf2a59 | 2016-08-11 14:48:36 | [diff] [blame] | 5491 | ssl_provider0->next_proto = kProtoHTTP2; |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 5492 | helper.AddDataWithSSLSocketDataProvider(&data0, std::move(ssl_provider0)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5493 | |
| 5494 | // Second socket: falling back to HTTP/1.1. |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 5495 | MockWrite writes1[] = {MockWrite(ASYNC, 0, |
| 5496 | "GET / HTTP/1.1\r\n" |
| 5497 | "Host: www.example.org\r\n" |
| 5498 | "Connection: keep-alive\r\n\r\n")}; |
| 5499 | MockRead reads1[] = {MockRead(ASYNC, 1, |
| 5500 | "HTTP/1.1 200 OK\r\n" |
| 5501 | "Content-Length: 5\r\n\r\n" |
| 5502 | "hello")}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5503 | SequencedSocketData data1(reads1, writes1); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5504 | |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5505 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5506 | // Expect only HTTP/1.1 protocol in SSLConfig. |
Bence Béky | 27a19b8 | 2018-01-30 14:58:36 | [diff] [blame] | 5507 | ssl_provider1->next_protos_expected_in_ssl_config = |
| 5508 | NextProtoVector{kProtoHTTP11}; |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5509 | // Force HTTP/1.1. |
bnc | 3cf2a59 | 2016-08-11 14:48:36 | [diff] [blame] | 5510 | ssl_provider1->next_proto = kProtoHTTP11; |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 5511 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5512 | |
bnc | 525e175a | 2016-06-20 12:36:40 | [diff] [blame] | 5513 | HttpServerProperties* http_server_properties = |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5514 | helper.session()->spdy_session_pool()->http_server_properties(); |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 5515 | EXPECT_FALSE(http_server_properties->RequiresHTTP11( |
| 5516 | url::SchemeHostPort(request_.url), NetworkIsolationKey())); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5517 | |
| 5518 | helper.RunPreTestSetup(); |
| 5519 | helper.StartDefaultTest(); |
| 5520 | helper.FinishDefaultTestWithoutVerification(); |
| 5521 | helper.VerifyDataConsumed(); |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 5522 | EXPECT_TRUE(http_server_properties->RequiresHTTP11( |
| 5523 | url::SchemeHostPort(request_.url), NetworkIsolationKey())); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5524 | |
| 5525 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5526 | ASSERT_TRUE(response); |
| 5527 | ASSERT_TRUE(response->headers); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5528 | EXPECT_EQ("HTTP/1.1 200 OK", response->headers->GetStatusLine()); |
| 5529 | EXPECT_FALSE(response->was_fetched_via_spdy); |
mmenke | 8210acc | 2016-07-11 16:34:52 | [diff] [blame] | 5530 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP1_1, |
| 5531 | response->connection_info); |
bnc | 94c9284 | 2016-09-21 15:22:52 | [diff] [blame] | 5532 | EXPECT_TRUE(response->was_alpn_negotiated); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5533 | EXPECT_TRUE(request_.url.SchemeIs("https")); |
Tsuyoshi Horo | 01faed6 | 2019-02-20 22:11:37 | [diff] [blame] | 5534 | EXPECT_EQ("127.0.0.1", response->remote_endpoint.ToStringWithoutPort()); |
| 5535 | EXPECT_EQ(443, response->remote_endpoint.port()); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5536 | std::string response_data; |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5537 | ASSERT_THAT(ReadTransaction(helper.trans(), &response_data), IsOk()); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5538 | EXPECT_EQ("hello", response_data); |
| 5539 | } |
| 5540 | |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 5541 | // Same as above test, but checks that NetworkIsolationKeys are respected. |
| 5542 | TEST_F(SpdyNetworkTransactionTest, HTTP11RequiredRetryWithNetworkIsolationKey) { |
Matt Menke | 4807a9a | 2020-11-21 00:14:41 | [diff] [blame] | 5543 | const SchemefulSite kSite1(GURL("https://foo.test/")); |
| 5544 | const SchemefulSite kSite2(GURL("https://bar.test/")); |
| 5545 | const NetworkIsolationKey kNetworkIsolationKey1(kSite1, kSite1); |
| 5546 | const NetworkIsolationKey kNetworkIsolationKey2(kSite2, kSite2); |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 5547 | |
| 5548 | const NetworkIsolationKey kNetworkIsolationKeys[] = { |
| 5549 | kNetworkIsolationKey1, kNetworkIsolationKey2, NetworkIsolationKey()}; |
| 5550 | |
| 5551 | base::test::ScopedFeatureList feature_list; |
| 5552 | feature_list.InitWithFeatures( |
| 5553 | // enabled_features |
| 5554 | {features::kPartitionHttpServerPropertiesByNetworkIsolationKey, |
| 5555 | // Need to partition connections by NetworkIsolationKey for |
| 5556 | // SpdySessionKeys to include NetworkIsolationKeys. |
| 5557 | features::kPartitionConnectionsByNetworkIsolationKey}, |
| 5558 | // disabled_features |
| 5559 | {}); |
| 5560 | |
| 5561 | // Do not force SPDY so that sockets can negotiate HTTP/1.1. |
| 5562 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 5563 | |
| 5564 | // For each server, set up and tear down a QUIC session cleanly, and check |
| 5565 | // that stats have been added to HttpServerProperties using the correct |
| 5566 | // NetworkIsolationKey. |
| 5567 | for (size_t i = 0; i < base::size(kNetworkIsolationKeys); ++i) { |
| 5568 | SCOPED_TRACE(i); |
| 5569 | |
| 5570 | request_.method = "GET"; |
| 5571 | request_.network_isolation_key = kNetworkIsolationKeys[i]; |
| 5572 | |
| 5573 | // First socket: HTTP/2 request rejected with HTTP_1_1_REQUIRED. |
| 5574 | SpdyTestUtil spdy_util; |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 5575 | spdy::Http2HeaderBlock headers( |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 5576 | spdy_util.ConstructGetHeaderBlock(kDefaultUrl)); |
| 5577 | spdy::SpdySerializedFrame req( |
| 5578 | spdy_util.ConstructSpdyHeaders(1, std::move(headers), LOWEST, true)); |
| 5579 | MockWrite writes0[] = {CreateMockWrite(req, 0)}; |
| 5580 | spdy::SpdySerializedFrame rst(spdy_util.ConstructSpdyRstStream( |
| 5581 | 1, spdy::ERROR_CODE_HTTP_1_1_REQUIRED)); |
| 5582 | MockRead reads0[] = {CreateMockRead(rst, 1)}; |
| 5583 | SequencedSocketData data0(reads0, writes0); |
| 5584 | |
| 5585 | auto ssl_provider0 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 5586 | // Expect HTTP/2 protocols too in SSLConfig. |
| 5587 | ssl_provider0->next_protos_expected_in_ssl_config = |
| 5588 | NextProtoVector{kProtoHTTP2, kProtoHTTP11}; |
| 5589 | // Force SPDY. |
| 5590 | ssl_provider0->next_proto = kProtoHTTP2; |
| 5591 | helper.AddDataWithSSLSocketDataProvider(&data0, std::move(ssl_provider0)); |
| 5592 | |
| 5593 | // Second socket: falling back to HTTP/1.1. |
| 5594 | MockWrite writes1[] = {MockWrite(ASYNC, 0, |
| 5595 | "GET / HTTP/1.1\r\n" |
| 5596 | "Host: www.example.org\r\n" |
| 5597 | "Connection: keep-alive\r\n\r\n")}; |
| 5598 | MockRead reads1[] = {MockRead(ASYNC, 1, |
| 5599 | "HTTP/1.1 200 OK\r\n" |
| 5600 | "Content-Length: 5\r\n\r\n" |
| 5601 | "hello")}; |
| 5602 | SequencedSocketData data1(reads1, writes1); |
| 5603 | |
| 5604 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 5605 | // Expect only HTTP/1.1 protocol in SSLConfig. |
| 5606 | ssl_provider1->next_protos_expected_in_ssl_config = |
| 5607 | NextProtoVector{kProtoHTTP11}; |
| 5608 | // Force HTTP/1.1. |
| 5609 | ssl_provider1->next_proto = kProtoHTTP11; |
| 5610 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
| 5611 | |
| 5612 | HttpServerProperties* http_server_properties = |
| 5613 | helper.session()->spdy_session_pool()->http_server_properties(); |
| 5614 | EXPECT_FALSE(http_server_properties->RequiresHTTP11( |
| 5615 | url::SchemeHostPort(request_.url), kNetworkIsolationKeys[i])); |
| 5616 | |
| 5617 | HttpNetworkTransaction trans(DEFAULT_PRIORITY, helper.session()); |
| 5618 | |
| 5619 | TestCompletionCallback callback; |
| 5620 | int rv = trans.Start(&request_, callback.callback(), log_); |
| 5621 | EXPECT_THAT(callback.GetResult(rv), IsOk()); |
| 5622 | |
| 5623 | const HttpResponseInfo* response = trans.GetResponseInfo(); |
| 5624 | ASSERT_TRUE(response); |
| 5625 | ASSERT_TRUE(response->headers); |
| 5626 | EXPECT_EQ("HTTP/1.1 200 OK", response->headers->GetStatusLine()); |
| 5627 | EXPECT_FALSE(response->was_fetched_via_spdy); |
| 5628 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP1_1, |
| 5629 | response->connection_info); |
| 5630 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 5631 | EXPECT_TRUE(request_.url.SchemeIs("https")); |
| 5632 | EXPECT_EQ("127.0.0.1", response->remote_endpoint.ToStringWithoutPort()); |
| 5633 | EXPECT_EQ(443, response->remote_endpoint.port()); |
| 5634 | std::string response_data; |
| 5635 | ASSERT_THAT(ReadTransaction(&trans, &response_data), IsOk()); |
| 5636 | EXPECT_EQ("hello", response_data); |
| 5637 | |
| 5638 | for (size_t j = 0; j < base::size(kNetworkIsolationKeys); ++j) { |
| 5639 | // NetworkIsolationKeys up to kNetworkIsolationKeys[j] are known to |
| 5640 | // require HTTP/1.1, others are not. |
| 5641 | if (j <= i) { |
| 5642 | EXPECT_TRUE(http_server_properties->RequiresHTTP11( |
| 5643 | url::SchemeHostPort(request_.url), kNetworkIsolationKeys[j])); |
| 5644 | } else { |
| 5645 | EXPECT_FALSE(http_server_properties->RequiresHTTP11( |
| 5646 | url::SchemeHostPort(request_.url), kNetworkIsolationKeys[j])); |
| 5647 | } |
| 5648 | } |
| 5649 | } |
| 5650 | } |
| 5651 | |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5652 | // Retry with HTTP/1.1 to the proxy when receiving HTTP_1_1_REQUIRED from the |
| 5653 | // proxy. Note that no actual protocol negotiation happens, instead this test |
| 5654 | // forces protocols for both sockets. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5655 | TEST_F(SpdyNetworkTransactionTest, HTTP11RequiredProxyRetry) { |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5656 | request_.method = "GET"; |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5657 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Nicolas Arciniega | d2013f9 | 2020-02-07 23:00:56 | [diff] [blame] | 5658 | ConfiguredProxyResolutionService::CreateFixedFromPacResult( |
Ramin Halavati | ca8d525 | 2018-03-12 05:33:49 | [diff] [blame] | 5659 | "HTTPS myproxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5660 | // Do not force SPDY so that second socket can negotiate HTTP/1.1. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5661 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 5662 | std::move(session_deps)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5663 | |
| 5664 | // First socket: HTTP/2 CONNECT rejected with HTTP_1_1_REQUIRED. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5665 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyConnect( |
Matt Menke | 6e879bd | 2019-03-18 17:26:04 | [diff] [blame] | 5666 | nullptr, 0, 1, HttpProxyConnectJob::kH2QuicTunnelPriority, |
| 5667 | HostPortPair("www.example.org", 443))); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5668 | MockWrite writes0[] = {CreateMockWrite(req, 0)}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5669 | spdy::SpdySerializedFrame rst( |
| 5670 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_HTTP_1_1_REQUIRED)); |
Bence Béky | cb361312 | 2017-09-19 17:06:57 | [diff] [blame] | 5671 | MockRead reads0[] = {CreateMockRead(rst, 1)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5672 | SequencedSocketData data0(reads0, writes0); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5673 | |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5674 | auto ssl_provider0 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5675 | // Expect HTTP/2 protocols too in SSLConfig. |
Bence Béky | 27a19b8 | 2018-01-30 14:58:36 | [diff] [blame] | 5676 | ssl_provider0->next_protos_expected_in_ssl_config = |
| 5677 | NextProtoVector{kProtoHTTP2, kProtoHTTP11}; |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5678 | // Force SPDY. |
bnc | 3cf2a59 | 2016-08-11 14:48:36 | [diff] [blame] | 5679 | ssl_provider0->next_proto = kProtoHTTP2; |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 5680 | helper.AddDataWithSSLSocketDataProvider(&data0, std::move(ssl_provider0)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5681 | |
| 5682 | // Second socket: retry using HTTP/1.1. |
| 5683 | MockWrite writes1[] = { |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 5684 | MockWrite(ASYNC, 0, |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 5685 | "CONNECT www.example.org:443 HTTP/1.1\r\n" |
rsleevi | db16bb0 | 2015-11-12 23:47:17 | [diff] [blame] | 5686 | "Host: www.example.org:443\r\n" |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5687 | "Proxy-Connection: keep-alive\r\n\r\n"), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 5688 | MockWrite(ASYNC, 2, |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5689 | "GET / HTTP/1.1\r\n" |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 5690 | "Host: www.example.org\r\n" |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5691 | "Connection: keep-alive\r\n\r\n"), |
| 5692 | }; |
| 5693 | |
| 5694 | MockRead reads1[] = { |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 5695 | MockRead(ASYNC, 1, "HTTP/1.1 200 OK\r\n\r\n"), |
| 5696 | MockRead(ASYNC, 3, |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5697 | "HTTP/1.1 200 OK\r\n" |
| 5698 | "Content-Length: 5\r\n\r\n" |
| 5699 | "hello"), |
| 5700 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5701 | SequencedSocketData data1(reads1, writes1); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5702 | |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5703 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5704 | // Expect only HTTP/1.1 protocol in SSLConfig. |
Bence Béky | 27a19b8 | 2018-01-30 14:58:36 | [diff] [blame] | 5705 | ssl_provider1->next_protos_expected_in_ssl_config = |
| 5706 | NextProtoVector{kProtoHTTP11}; |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5707 | // Force HTTP/1.1. |
bnc | 3cf2a59 | 2016-08-11 14:48:36 | [diff] [blame] | 5708 | ssl_provider1->next_proto = kProtoHTTP11; |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 5709 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5710 | |
| 5711 | // A third socket is needed for the tunnelled connection. |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5712 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5713 | helper.session_deps()->socket_factory->AddSSLSocketDataProvider( |
| 5714 | ssl_provider2.get()); |
| 5715 | |
bnc | 525e175a | 2016-06-20 12:36:40 | [diff] [blame] | 5716 | HttpServerProperties* http_server_properties = |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5717 | helper.session()->spdy_session_pool()->http_server_properties(); |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 5718 | url::SchemeHostPort proxy_scheme_host_port(url::kHttpsScheme, "myproxy", 70); |
| 5719 | EXPECT_FALSE(http_server_properties->RequiresHTTP11(proxy_scheme_host_port, |
| 5720 | NetworkIsolationKey())); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5721 | |
| 5722 | helper.RunPreTestSetup(); |
| 5723 | helper.StartDefaultTest(); |
| 5724 | helper.FinishDefaultTestWithoutVerification(); |
| 5725 | helper.VerifyDataConsumed(); |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 5726 | EXPECT_TRUE(http_server_properties->RequiresHTTP11(proxy_scheme_host_port, |
| 5727 | NetworkIsolationKey())); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5728 | |
| 5729 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5730 | ASSERT_TRUE(response); |
| 5731 | ASSERT_TRUE(response->headers); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5732 | EXPECT_EQ("HTTP/1.1 200 OK", response->headers->GetStatusLine()); |
| 5733 | EXPECT_FALSE(response->was_fetched_via_spdy); |
mmenke | 8210acc | 2016-07-11 16:34:52 | [diff] [blame] | 5734 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP1_1, |
| 5735 | response->connection_info); |
bnc | 94c9284 | 2016-09-21 15:22:52 | [diff] [blame] | 5736 | EXPECT_FALSE(response->was_alpn_negotiated); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5737 | EXPECT_TRUE(request_.url.SchemeIs("https")); |
Tsuyoshi Horo | 01faed6 | 2019-02-20 22:11:37 | [diff] [blame] | 5738 | EXPECT_EQ("127.0.0.1", response->remote_endpoint.ToStringWithoutPort()); |
| 5739 | EXPECT_EQ(70, response->remote_endpoint.port()); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5740 | std::string response_data; |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5741 | ASSERT_THAT(ReadTransaction(helper.trans(), &response_data), IsOk()); |
bnc | facdd85 | 2015-01-09 19:22:54 | [diff] [blame] | 5742 | EXPECT_EQ("hello", response_data); |
| 5743 | } |
| 5744 | |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 5745 | // Same as above, but also test that NetworkIsolationKeys are respected. |
| 5746 | TEST_F(SpdyNetworkTransactionTest, |
| 5747 | HTTP11RequiredProxyRetryWithNetworkIsolationKey) { |
Matt Menke | 4807a9a | 2020-11-21 00:14:41 | [diff] [blame] | 5748 | const SchemefulSite kSite1(GURL("https://foo.test/")); |
| 5749 | const SchemefulSite kSite2(GURL("https://bar.test/")); |
| 5750 | const NetworkIsolationKey kNetworkIsolationKey1(kSite1, kSite1); |
| 5751 | const NetworkIsolationKey kNetworkIsolationKey2(kSite2, kSite2); |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 5752 | |
| 5753 | const NetworkIsolationKey kNetworkIsolationKeys[] = { |
| 5754 | kNetworkIsolationKey1, kNetworkIsolationKey2, NetworkIsolationKey()}; |
| 5755 | |
| 5756 | base::test::ScopedFeatureList feature_list; |
| 5757 | feature_list.InitWithFeatures( |
| 5758 | // enabled_features |
| 5759 | {features::kPartitionHttpServerPropertiesByNetworkIsolationKey, |
| 5760 | // Need to partition connections by NetworkIsolationKey for |
| 5761 | // SpdySessionKeys to include NetworkIsolationKeys. |
| 5762 | features::kPartitionConnectionsByNetworkIsolationKey}, |
| 5763 | // disabled_features |
| 5764 | {}); |
| 5765 | |
| 5766 | request_.method = "GET"; |
| 5767 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Nicolas Arciniega | d2013f9 | 2020-02-07 23:00:56 | [diff] [blame] | 5768 | ConfiguredProxyResolutionService::CreateFixedFromPacResult( |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 5769 | "HTTPS myproxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
| 5770 | // Do not force SPDY so that second socket can negotiate HTTP/1.1. |
| 5771 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 5772 | std::move(session_deps)); |
| 5773 | helper.RunPreTestSetup(); |
| 5774 | |
| 5775 | for (size_t i = 0; i < base::size(kNetworkIsolationKeys); ++i) { |
| 5776 | // First socket: HTTP/2 CONNECT rejected with HTTP_1_1_REQUIRED. |
| 5777 | |
| 5778 | SpdyTestUtil spdy_util; |
| 5779 | spdy::SpdySerializedFrame req(spdy_util.ConstructSpdyConnect( |
| 5780 | nullptr, 0, 1, HttpProxyConnectJob::kH2QuicTunnelPriority, |
| 5781 | HostPortPair("www.example.org", 443))); |
| 5782 | MockWrite writes0[] = {CreateMockWrite(req, 0)}; |
| 5783 | spdy::SpdySerializedFrame rst(spdy_util.ConstructSpdyRstStream( |
| 5784 | 1, spdy::ERROR_CODE_HTTP_1_1_REQUIRED)); |
| 5785 | MockRead reads0[] = {CreateMockRead(rst, 1)}; |
| 5786 | SequencedSocketData data0(reads0, writes0); |
| 5787 | |
| 5788 | auto ssl_provider0 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 5789 | // Expect HTTP/2 protocols too in SSLConfig. |
| 5790 | ssl_provider0->next_protos_expected_in_ssl_config = |
| 5791 | NextProtoVector{kProtoHTTP2, kProtoHTTP11}; |
| 5792 | // Force SPDY. |
| 5793 | ssl_provider0->next_proto = kProtoHTTP2; |
| 5794 | helper.AddDataWithSSLSocketDataProvider(&data0, std::move(ssl_provider0)); |
| 5795 | |
| 5796 | // Second socket: retry using HTTP/1.1. |
| 5797 | MockWrite writes1[] = { |
| 5798 | MockWrite(ASYNC, 0, |
| 5799 | "CONNECT www.example.org:443 HTTP/1.1\r\n" |
| 5800 | "Host: www.example.org:443\r\n" |
| 5801 | "Proxy-Connection: keep-alive\r\n\r\n"), |
| 5802 | MockWrite(ASYNC, 2, |
| 5803 | "GET / HTTP/1.1\r\n" |
| 5804 | "Host: www.example.org\r\n" |
| 5805 | "Connection: keep-alive\r\n\r\n"), |
| 5806 | }; |
| 5807 | |
| 5808 | MockRead reads1[] = { |
| 5809 | MockRead(ASYNC, 1, "HTTP/1.1 200 OK\r\n\r\n"), |
| 5810 | MockRead(ASYNC, 3, |
| 5811 | "HTTP/1.1 200 OK\r\n" |
| 5812 | "Content-Length: 5\r\n\r\n" |
| 5813 | "hello"), |
| 5814 | }; |
| 5815 | SequencedSocketData data1(reads1, writes1); |
| 5816 | |
| 5817 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 5818 | // Expect only HTTP/1.1 protocol in SSLConfig. |
| 5819 | ssl_provider1->next_protos_expected_in_ssl_config = |
| 5820 | NextProtoVector{kProtoHTTP11}; |
| 5821 | // Force HTTP/1.1. |
| 5822 | ssl_provider1->next_proto = kProtoHTTP11; |
| 5823 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
| 5824 | |
| 5825 | // A third socket is needed for the tunnelled connection. |
| 5826 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 5827 | helper.session_deps()->socket_factory->AddSSLSocketDataProvider( |
| 5828 | ssl_provider2.get()); |
| 5829 | |
| 5830 | HttpServerProperties* http_server_properties = |
| 5831 | helper.session()->spdy_session_pool()->http_server_properties(); |
| 5832 | url::SchemeHostPort proxy_scheme_host_port(url::kHttpsScheme, "myproxy", |
| 5833 | 70); |
| 5834 | EXPECT_FALSE(http_server_properties->RequiresHTTP11( |
| 5835 | proxy_scheme_host_port, kNetworkIsolationKeys[i])); |
| 5836 | |
| 5837 | request_.network_isolation_key = kNetworkIsolationKeys[i]; |
| 5838 | HttpNetworkTransaction trans(DEFAULT_PRIORITY, helper.session()); |
| 5839 | TestCompletionCallback callback; |
| 5840 | int rv = trans.Start(&request_, callback.callback(), log_); |
| 5841 | EXPECT_THAT(callback.GetResult(rv), IsOk()); |
| 5842 | helper.VerifyDataConsumed(); |
| 5843 | |
| 5844 | const HttpResponseInfo* response = trans.GetResponseInfo(); |
| 5845 | ASSERT_TRUE(response); |
| 5846 | ASSERT_TRUE(response->headers); |
| 5847 | EXPECT_EQ("HTTP/1.1 200 OK", response->headers->GetStatusLine()); |
| 5848 | EXPECT_FALSE(response->was_fetched_via_spdy); |
| 5849 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP1_1, |
| 5850 | response->connection_info); |
| 5851 | EXPECT_FALSE(response->was_alpn_negotiated); |
| 5852 | EXPECT_TRUE(request_.url.SchemeIs("https")); |
| 5853 | EXPECT_EQ("127.0.0.1", response->remote_endpoint.ToStringWithoutPort()); |
| 5854 | EXPECT_EQ(70, response->remote_endpoint.port()); |
| 5855 | std::string response_data; |
| 5856 | ASSERT_THAT(ReadTransaction(&trans, &response_data), IsOk()); |
| 5857 | EXPECT_EQ("hello", response_data); |
| 5858 | |
| 5859 | for (size_t j = 0; j < base::size(kNetworkIsolationKeys); ++j) { |
| 5860 | // The proxy SchemeHostPort URL should not be marked as requiring HTTP/1.1 |
| 5861 | // using the current NetworkIsolationKey, and the state of others should |
| 5862 | // be unchanged since the last loop iteration.. |
| 5863 | if (j <= i) { |
| 5864 | EXPECT_TRUE(http_server_properties->RequiresHTTP11( |
| 5865 | proxy_scheme_host_port, kNetworkIsolationKeys[j])); |
| 5866 | } else { |
| 5867 | EXPECT_FALSE(http_server_properties->RequiresHTTP11( |
| 5868 | proxy_scheme_host_port, kNetworkIsolationKeys[j])); |
| 5869 | } |
| 5870 | } |
| 5871 | |
| 5872 | // The destination SchemeHostPort should not be marked as requiring |
| 5873 | // HTTP/1.1. |
| 5874 | EXPECT_FALSE(http_server_properties->RequiresHTTP11( |
| 5875 | url::SchemeHostPort(request_.url), kNetworkIsolationKeys[i])); |
| 5876 | } |
| 5877 | } |
| 5878 | |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5879 | // Test to make sure we can correctly connect through a proxy. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5880 | TEST_F(SpdyNetworkTransactionTest, ProxyConnect) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5881 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Nicolas Arciniega | d2013f9 | 2020-02-07 23:00:56 | [diff] [blame] | 5882 | ConfiguredProxyResolutionService::CreateFixedFromPacResult( |
Ramin Halavati | ca8d525 | 2018-03-12 05:33:49 | [diff] [blame] | 5883 | "PROXY myproxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5884 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 5885 | std::move(session_deps)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5886 | helper.RunPreTestSetup(); |
| 5887 | HttpNetworkTransaction* trans = helper.trans(); |
| 5888 | |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 5889 | const char kConnect443[] = { |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 5890 | "CONNECT www.example.org:443 HTTP/1.1\r\n" |
rsleevi | db16bb0 | 2015-11-12 23:47:17 | [diff] [blame] | 5891 | "Host: www.example.org:443\r\n" |
rch | cb934f56 | 2015-04-07 16:25:12 | [diff] [blame] | 5892 | "Proxy-Connection: keep-alive\r\n\r\n"}; |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5893 | const char kHTTP200[] = {"HTTP/1.1 200 OK\r\n\r\n"}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5894 | spdy::SpdySerializedFrame req( |
| 5895 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 5896 | spdy::SpdySerializedFrame resp( |
| 5897 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 5898 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5899 | |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 5900 | MockWrite writes[] = { |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 5901 | MockWrite(SYNCHRONOUS, kConnect443, base::size(kConnect443) - 1, 0), |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5902 | CreateMockWrite(req, 2), |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5903 | }; |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 5904 | MockRead reads[] = { |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 5905 | MockRead(SYNCHRONOUS, kHTTP200, base::size(kHTTP200) - 1, 1), |
| 5906 | CreateMockRead(resp, 3), |
| 5907 | CreateMockRead(body, 4), |
Raul Tambre | 94493c65 | 2019-03-11 17:18:35 | [diff] [blame] | 5908 | MockRead(ASYNC, nullptr, 0, 5), |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5909 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5910 | SequencedSocketData data(reads, writes); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5911 | |
Bence Béky | 53a5aef | 2018-03-29 21:54:12 | [diff] [blame] | 5912 | helper.AddData(&data); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5913 | TestCompletionCallback callback; |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5914 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5915 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5916 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5917 | |
| 5918 | rv = callback.WaitForResult(); |
| 5919 | EXPECT_EQ(0, rv); |
| 5920 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 5921 | // Verify the response headers. |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5922 | HttpResponseInfo response = *trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5923 | ASSERT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 5924 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5925 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 5926 | std::string response_data; |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5927 | ASSERT_THAT(ReadTransaction(trans, &response_data), IsOk()); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5928 | EXPECT_EQ("hello!", response_data); |
| 5929 | helper.VerifyDataConsumed(); |
| 5930 | } |
| 5931 | |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 5932 | // Test to make sure we can correctly connect through a proxy to |
| 5933 | // www.example.org, if there already exists a direct spdy connection to |
| 5934 | // www.example.org. See https://crbug.com/49874. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5935 | TEST_F(SpdyNetworkTransactionTest, DirectConnectProxyReconnect) { |
[email protected] | 733b7a6d | 2010-08-25 01:38:43 | [diff] [blame] | 5936 | // Use a proxy service which returns a proxy fallback list from DIRECT to |
| 5937 | // myproxy:70. For this test there will be no fallback, so it is equivalent |
| 5938 | // to simply DIRECT. The reason for appending the second proxy is to verify |
| 5939 | // that the session pool key used does is just "DIRECT". |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 5940 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Nicolas Arciniega | d2013f9 | 2020-02-07 23:00:56 | [diff] [blame] | 5941 | ConfiguredProxyResolutionService::CreateFixedFromPacResult( |
Ramin Halavati | ca8d525 | 2018-03-12 05:33:49 | [diff] [blame] | 5942 | "DIRECT; PROXY myproxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 5943 | // When setting up the first transaction, we store the SpdySessionPool so that |
| 5944 | // we can use the same pool in the second transaction. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5945 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 5946 | std::move(session_deps)); |
[email protected] | 733b7a6d | 2010-08-25 01:38:43 | [diff] [blame] | 5947 | |
[email protected] | 87bfa3f | 2010-09-30 14:54:56 | [diff] [blame] | 5948 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5949 | helper.RunPreTestSetup(); |
| 5950 | |
| 5951 | // Construct and send a simple GET request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5952 | spdy::SpdySerializedFrame req( |
| 5953 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5954 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5955 | CreateMockWrite(req, 0), |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5956 | }; |
| 5957 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 5958 | spdy::SpdySerializedFrame resp( |
| 5959 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 5960 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5961 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 5962 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 5963 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 3), // Force a pause |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5964 | }; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 5965 | SequencedSocketData data(reads, writes); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 5966 | helper.AddData(&data); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5967 | HttpNetworkTransaction* trans = helper.trans(); |
| 5968 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 5969 | TestCompletionCallback callback; |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5970 | TransactionHelperResult out; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 5971 | out.rv = trans->Start(&request_, callback.callback(), log_); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5972 | |
| 5973 | EXPECT_EQ(out.rv, ERR_IO_PENDING); |
| 5974 | out.rv = callback.WaitForResult(); |
| 5975 | EXPECT_EQ(out.rv, OK); |
| 5976 | |
| 5977 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 5978 | EXPECT_TRUE(response->headers); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5979 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 5980 | out.rv = ReadTransaction(trans, &out.response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 5981 | EXPECT_THAT(out.rv, IsOk()); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5982 | out.status_line = response->headers->GetStatusLine(); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 5983 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5984 | EXPECT_EQ("hello!", out.response_data); |
| 5985 | |
| 5986 | // Check that the SpdySession is still in the SpdySessionPool. |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 5987 | SpdySessionKey session_pool_key_direct( |
| 5988 | host_port_pair_, ProxyServer::Direct(), PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 5989 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 5990 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
[email protected] | 41d64e8 | 2013-07-03 22:44:26 | [diff] [blame] | 5991 | EXPECT_TRUE(HasSpdySession(spdy_session_pool, session_pool_key_direct)); |
[email protected] | e6d01765 | 2013-05-17 18:01:40 | [diff] [blame] | 5992 | SpdySessionKey session_pool_key_proxy( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 5993 | host_port_pair_, |
Eric Orth | 5ccc3f0 | 2021-09-23 00:01:57 | [diff] [blame] | 5994 | ProxyUriToProxyServer("www.foo.com", ProxyServer::SCHEME_HTTP), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 5995 | PRIVACY_MODE_DISABLED, SpdySessionKey::IsProxySession::kFalse, |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 5996 | SocketTag(), NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
[email protected] | 41d64e8 | 2013-07-03 22:44:26 | [diff] [blame] | 5997 | EXPECT_FALSE(HasSpdySession(spdy_session_pool, session_pool_key_proxy)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 5998 | |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 5999 | // New SpdyTestUtil instance for the session that will be used for the |
| 6000 | // proxy connection. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6001 | SpdyTestUtil spdy_util_2; |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 6002 | |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 6003 | // Set up data for the proxy connection. |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 6004 | const char kConnect443[] = { |
| 6005 | "CONNECT www.example.org:443 HTTP/1.1\r\n" |
rsleevi | db16bb0 | 2015-11-12 23:47:17 | [diff] [blame] | 6006 | "Host: www.example.org:443\r\n" |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 6007 | "Proxy-Connection: keep-alive\r\n\r\n"}; |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 6008 | const char kHTTP200[] = {"HTTP/1.1 200 OK\r\n\r\n"}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6009 | spdy::SpdySerializedFrame req2( |
| 6010 | spdy_util_2.ConstructSpdyGet(kPushedUrl, 1, LOWEST)); |
| 6011 | spdy::SpdySerializedFrame resp2( |
| 6012 | spdy_util_2.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 6013 | spdy::SpdySerializedFrame body2(spdy_util_2.ConstructSpdyDataFrame(1, true)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 6014 | |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 6015 | MockWrite writes2[] = { |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 6016 | MockWrite(SYNCHRONOUS, kConnect443, base::size(kConnect443) - 1, 0), |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6017 | CreateMockWrite(req2, 2), |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 6018 | }; |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 6019 | MockRead reads2[] = { |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 6020 | MockRead(SYNCHRONOUS, kHTTP200, base::size(kHTTP200) - 1, 1), |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6021 | CreateMockRead(resp2, 3), CreateMockRead(body2, 4), |
rch | ebf1298 | 2015-04-10 01:15:00 | [diff] [blame] | 6022 | MockRead(ASYNC, 0, 5) // EOF |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 6023 | }; |
| 6024 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6025 | SequencedSocketData data_proxy(reads2, writes2); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 6026 | |
bnc | ce36dca2 | 2015-04-21 22:11:23 | [diff] [blame] | 6027 | // Create another request to www.example.org, but this time through a proxy. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6028 | request_.method = "GET"; |
Bence Béky | d2df6c1c8 | 2018-04-20 22:52:01 | [diff] [blame] | 6029 | request_.url = GURL(kPushedUrl); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 6030 | auto session_deps_proxy = std::make_unique<SpdySessionDependencies>( |
Nicolas Arciniega | d2013f9 | 2020-02-07 23:00:56 | [diff] [blame] | 6031 | ConfiguredProxyResolutionService::CreateFixedFromPacResult( |
Ramin Halavati | ca8d525 | 2018-03-12 05:33:49 | [diff] [blame] | 6032 | "PROXY myproxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6033 | NormalSpdyTransactionHelper helper_proxy(request_, DEFAULT_PRIORITY, log_, |
| 6034 | std::move(session_deps_proxy)); |
| 6035 | |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 6036 | helper_proxy.RunPreTestSetup(); |
Bence Béky | 53a5aef | 2018-03-29 21:54:12 | [diff] [blame] | 6037 | helper_proxy.AddData(&data_proxy); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 6038 | |
| 6039 | HttpNetworkTransaction* trans_proxy = helper_proxy.trans(); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 6040 | TestCompletionCallback callback_proxy; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6041 | int rv = trans_proxy->Start(&request_, callback_proxy.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6042 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 6043 | rv = callback_proxy.WaitForResult(); |
| 6044 | EXPECT_EQ(0, rv); |
| 6045 | |
| 6046 | HttpResponseInfo response_proxy = *trans_proxy->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6047 | ASSERT_TRUE(response_proxy.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 6048 | EXPECT_EQ("HTTP/1.1 200", response_proxy.headers->GetStatusLine()); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 6049 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6050 | std::string response_data; |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6051 | ASSERT_THAT(ReadTransaction(trans_proxy, &response_data), IsOk()); |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 6052 | EXPECT_EQ("hello!", response_data); |
| 6053 | |
[email protected] | b261d0e | 2010-08-02 19:13:24 | [diff] [blame] | 6054 | helper_proxy.VerifyDataConsumed(); |
| 6055 | } |
| 6056 | |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6057 | // When we get a TCP-level RST, we need to retry a HttpNetworkTransaction |
| 6058 | // on a new connection, if the connection was previously known to be good. |
| 6059 | // This can happen when a server reboots without saying goodbye, or when |
| 6060 | // we're behind a NAT that masked the RST. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6061 | TEST_F(SpdyNetworkTransactionTest, VerifyRetryOnConnectionReset) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6062 | spdy::SpdySerializedFrame resp( |
| 6063 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 6064 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6065 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6066 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 6067 | MockRead(ASYNC, ERR_IO_PENDING, 3), |
| 6068 | MockRead(ASYNC, ERR_CONNECTION_RESET, 4), |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6069 | }; |
| 6070 | |
| 6071 | MockRead reads2[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6072 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
rch | 3232084 | 2015-05-16 15:57:09 | [diff] [blame] | 6073 | MockRead(ASYNC, 0, 3) // EOF |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6074 | }; |
| 6075 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6076 | spdy::SpdySerializedFrame req( |
| 6077 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 6078 | // In all cases the connection will be reset before req3 can be |
| 6079 | // dispatched, destroying both streams. |
| 6080 | spdy_util_.UpdateWithStreamDestruction(1); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6081 | spdy::SpdySerializedFrame req3( |
| 6082 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6083 | MockWrite writes1[] = {CreateMockWrite(req, 0), CreateMockWrite(req3, 5)}; |
| 6084 | MockWrite writes2[] = {CreateMockWrite(req, 0)}; |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 6085 | |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6086 | // This test has a couple of variants. |
| 6087 | enum { |
| 6088 | // Induce the RST while waiting for our transaction to send. |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 6089 | VARIANT_RST_DURING_SEND_COMPLETION = 0, |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6090 | // Induce the RST while waiting for our transaction to read. |
| 6091 | // In this case, the send completed - everything copied into the SNDBUF. |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 6092 | VARIANT_RST_DURING_READ_COMPLETION = 1 |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6093 | }; |
| 6094 | |
| 6095 | for (int variant = VARIANT_RST_DURING_SEND_COMPLETION; |
| 6096 | variant <= VARIANT_RST_DURING_READ_COMPLETION; |
| 6097 | ++variant) { |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6098 | SequencedSocketData data1(reads, |
| 6099 | base::make_span(writes1).first(1 + variant)); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6100 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6101 | SequencedSocketData data2(reads2, writes2); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6102 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6103 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 6104 | nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 6105 | helper.AddData(&data1); |
| 6106 | helper.AddData(&data2); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6107 | helper.RunPreTestSetup(); |
| 6108 | |
| 6109 | for (int i = 0; i < 2; ++i) { |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6110 | HttpNetworkTransaction trans(DEFAULT_PRIORITY, helper.session()); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6111 | |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 6112 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6113 | int rv = trans.Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6114 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6115 | // On the second transaction, we trigger the RST. |
| 6116 | if (i == 1) { |
| 6117 | if (variant == VARIANT_RST_DURING_READ_COMPLETION) { |
| 6118 | // Writes to the socket complete asynchronously on SPDY by running |
| 6119 | // through the message loop. Complete the write here. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 6120 | base::RunLoop().RunUntilIdle(); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6121 | } |
| 6122 | |
| 6123 | // Now schedule the ERR_CONNECTION_RESET. |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 6124 | data1.Resume(); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6125 | } |
| 6126 | rv = callback.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6127 | EXPECT_THAT(rv, IsOk()); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6128 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6129 | const HttpResponseInfo* response = trans.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6130 | ASSERT_TRUE(response); |
| 6131 | EXPECT_TRUE(response->headers); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6132 | EXPECT_TRUE(response->was_fetched_via_spdy); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6133 | std::string response_data; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6134 | rv = ReadTransaction(&trans, &response_data); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6135 | EXPECT_THAT(rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 6136 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6137 | EXPECT_EQ("hello!", response_data); |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 6138 | base::RunLoop().RunUntilIdle(); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6139 | } |
| 6140 | |
| 6141 | helper.VerifyDataConsumed(); |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 6142 | base::RunLoop().RunUntilIdle(); |
[email protected] | 58cebf8f | 2010-07-31 19:20:16 | [diff] [blame] | 6143 | } |
| 6144 | } |
[email protected] | 1f418ee | 2010-10-16 19:46:56 | [diff] [blame] | 6145 | |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6146 | // Tests that Basic authentication works over SPDY |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6147 | TEST_F(SpdyNetworkTransactionTest, SpdyBasicAuth) { |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6148 | // The first request will be a bare GET, the second request will be a |
| 6149 | // GET with an Authorization header. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6150 | spdy::SpdySerializedFrame req_get( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 6151 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 6152 | // Will be refused for lack of auth. |
| 6153 | spdy_util_.UpdateWithStreamDestruction(1); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6154 | const char* const kExtraAuthorizationHeaders[] = { |
[email protected] | cdf8f7e7 | 2013-05-23 10:56:46 | [diff] [blame] | 6155 | "authorization", "Basic Zm9vOmJhcg==" |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6156 | }; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6157 | spdy::SpdySerializedFrame req_get_authorization(spdy_util_.ConstructSpdyGet( |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 6158 | kExtraAuthorizationHeaders, base::size(kExtraAuthorizationHeaders) / 2, 3, |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 6159 | LOWEST)); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6160 | MockWrite spdy_writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6161 | CreateMockWrite(req_get, 0), CreateMockWrite(req_get_authorization, 3), |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6162 | }; |
| 6163 | |
| 6164 | // The first response is a 401 authentication challenge, and the second |
| 6165 | // response will be a 200 response since the second request includes a valid |
| 6166 | // Authorization header. |
| 6167 | const char* const kExtraAuthenticationHeaders[] = { |
[email protected] | fb9e431 | 2012-02-17 06:27:26 | [diff] [blame] | 6168 | "www-authenticate", |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6169 | "Basic realm=\"MyRealm\"" |
| 6170 | }; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6171 | spdy::SpdySerializedFrame resp_authentication( |
| 6172 | spdy_util_.ConstructSpdyReplyError( |
| 6173 | "401", kExtraAuthenticationHeaders, |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 6174 | base::size(kExtraAuthenticationHeaders) / 2, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6175 | spdy::SpdySerializedFrame body_authentication( |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6176 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6177 | spdy::SpdySerializedFrame resp_data( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6178 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6179 | spdy::SpdySerializedFrame body_data( |
| 6180 | spdy_util_.ConstructSpdyDataFrame(3, true)); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6181 | |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6182 | MockRead spdy_reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6183 | CreateMockRead(resp_authentication, 1), |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 6184 | CreateMockRead(body_authentication, 2, SYNCHRONOUS), |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6185 | CreateMockRead(resp_data, 4), |
| 6186 | CreateMockRead(body_data, 5), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 6187 | MockRead(ASYNC, 0, 6), |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6188 | }; |
| 6189 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6190 | SequencedSocketData data(spdy_reads, spdy_writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6191 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6192 | |
| 6193 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 6194 | helper.AddData(&data); |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 6195 | helper.StartDefaultTest(); |
| 6196 | EXPECT_THAT(helper.output().rv, IsError(ERR_IO_PENDING)); |
| 6197 | |
| 6198 | helper.WaitForCallbackToComplete(); |
| 6199 | EXPECT_THAT(helper.output().rv, IsOk()); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6200 | |
| 6201 | // Make sure the response has an auth challenge. |
bnc | 4d782f49 | 2016-08-18 13:50:00 | [diff] [blame] | 6202 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6203 | const HttpResponseInfo* const response_start = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6204 | ASSERT_TRUE(response_start); |
| 6205 | ASSERT_TRUE(response_start->headers); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6206 | EXPECT_EQ(401, response_start->headers->response_code()); |
| 6207 | EXPECT_TRUE(response_start->was_fetched_via_spdy); |
Anton Bikineev | 068d291 | 2021-05-15 20:43:52 | [diff] [blame] | 6208 | const absl::optional<AuthChallengeInfo>& auth_challenge = |
Emily Stark | f2c9bbd | 2019-04-09 17:08:58 | [diff] [blame] | 6209 | response_start->auth_challenge; |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6210 | ASSERT_TRUE(auth_challenge); |
[email protected] | 79cb5c1 | 2011-09-12 13:12:04 | [diff] [blame] | 6211 | EXPECT_FALSE(auth_challenge->is_proxy); |
aberent | bba302d | 2015-12-03 10:20:19 | [diff] [blame] | 6212 | EXPECT_EQ(kBasicAuthScheme, auth_challenge->scheme); |
[email protected] | 79cb5c1 | 2011-09-12 13:12:04 | [diff] [blame] | 6213 | EXPECT_EQ("MyRealm", auth_challenge->realm); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6214 | |
| 6215 | // Restart with a username/password. |
Jan Wilken Dörrie | c92a6d724 | 2021-03-23 17:43:48 | [diff] [blame] | 6216 | AuthCredentials credentials(u"foo", u"bar"); |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 6217 | TestCompletionCallback callback_restart; |
| 6218 | const int rv_restart = trans->RestartWithAuth( |
| 6219 | credentials, callback_restart.callback()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6220 | EXPECT_THAT(rv_restart, IsError(ERR_IO_PENDING)); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6221 | const int rv_restart_complete = callback_restart.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6222 | EXPECT_THAT(rv_restart_complete, IsOk()); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6223 | // TODO(cbentzel): This is actually the same response object as before, but |
| 6224 | // data has changed. |
| 6225 | const HttpResponseInfo* const response_restart = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6226 | ASSERT_TRUE(response_restart); |
| 6227 | ASSERT_TRUE(response_restart->headers); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6228 | EXPECT_EQ(200, response_restart->headers->response_code()); |
Emily Stark | f2c9bbd | 2019-04-09 17:08:58 | [diff] [blame] | 6229 | EXPECT_FALSE(response_restart->auth_challenge); |
[email protected] | 018aabc | 2010-10-29 16:16:59 | [diff] [blame] | 6230 | } |
| 6231 | |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6232 | struct PushHeaderTestParams { |
Victor Vasiliev | 502ba58 | 2020-09-15 23:16:15 | [diff] [blame] | 6233 | std::vector<std::pair<std::string, std::string>> extra_request_headers; |
| 6234 | std::vector<std::pair<std::string, std::string>> extra_pushed_request_headers; |
| 6235 | std::vector<std::pair<std::string, std::string>> |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6236 | extra_pushed_response_headers; |
Victor Vasiliev | 502ba58 | 2020-09-15 23:16:15 | [diff] [blame] | 6237 | std::string pushed_status_code; |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6238 | bool push_accepted; |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6239 | SpdyPushedStreamFate expected_fate; |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6240 | } push_header_test_cases[] = { |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6241 | // Base case: no extra headers. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6242 | {{}, {}, {}, "200", true, SpdyPushedStreamFate::kAcceptedNoVary}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6243 | // Cookie headers match. |
| 6244 | {{{"cookie", "value=foo"}}, |
| 6245 | {{"cookie", "value=foo"}}, |
| 6246 | {{"vary", "Cookie"}}, |
| 6247 | "200", |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6248 | true, |
| 6249 | SpdyPushedStreamFate::kAcceptedMatchingVary}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6250 | // Cookie headers mismatch. |
| 6251 | {{{"cookie", "value=foo"}}, |
| 6252 | {{"cookie", "value=bar"}}, |
| 6253 | {{"vary", "Cookie"}}, |
| 6254 | "200", |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6255 | false, |
| 6256 | SpdyPushedStreamFate::kVaryMismatch}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6257 | // Partial Content response, no Range headers. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6258 | {{}, {}, {}, "206", false, SpdyPushedStreamFate::kClientRequestNotRange}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6259 | // Partial Content response, no Range headers in pushed request. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6260 | {{{"range", "0-42"}}, |
| 6261 | {}, |
| 6262 | {}, |
| 6263 | "206", |
| 6264 | false, |
| 6265 | SpdyPushedStreamFate::kPushedRequestNotRange}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6266 | // Partial Content response, no Range headers in client request. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6267 | {{}, |
| 6268 | {{"range", "0-42"}}, |
| 6269 | {}, |
| 6270 | "206", |
| 6271 | false, |
| 6272 | SpdyPushedStreamFate::kClientRequestNotRange}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6273 | // Partial Content response, mismatching Range headers. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6274 | {{{"range", "0-42"}}, |
| 6275 | {{"range", "10-42"}}, |
| 6276 | {}, |
| 6277 | "206", |
| 6278 | false, |
| 6279 | SpdyPushedStreamFate::kRangeMismatch}, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6280 | // Partial Content response, matching Range headers. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6281 | {{{"range", "0-42"}}, |
| 6282 | {{"range", "0-42"}}, |
| 6283 | {}, |
| 6284 | "206", |
| 6285 | true, |
| 6286 | SpdyPushedStreamFate::kAcceptedNoVary}, |
| 6287 | }; |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6288 | |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6289 | class SpdyNetworkTransactionPushHeaderTest |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6290 | : public SpdyNetworkTransactionTest, |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6291 | public ::testing::WithParamInterface<PushHeaderTestParams> { |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6292 | protected: |
| 6293 | void RunTest(bool pushed_response_headers_received_before_request) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6294 | base::HistogramTester histogram_tester; |
| 6295 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6296 | int seq = 0; |
| 6297 | std::vector<MockWrite> writes; |
| 6298 | std::vector<MockRead> reads; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 6299 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6300 | spdy::SpdySerializedFrame req1( |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6301 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6302 | writes.push_back(CreateMockWrite(req1, seq++)); |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 6303 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 6304 | spdy::Http2HeaderBlock pushed_request_headers; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6305 | pushed_request_headers[spdy::kHttp2MethodHeader] = "GET"; |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6306 | for (const auto& header : GetParam().extra_pushed_request_headers) { |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6307 | pushed_request_headers.insert(header); |
| 6308 | } |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6309 | spdy_util_.AddUrlToHeaderBlock(kPushedUrl, &pushed_request_headers); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6310 | spdy::SpdySerializedFrame pushed_request( |
| 6311 | spdy_util_.ConstructSpdyPushPromise(1, 2, |
| 6312 | std::move(pushed_request_headers))); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6313 | reads.push_back(CreateMockRead(pushed_request, seq++)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6314 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6315 | spdy::SpdySerializedFrame priority( |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6316 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6317 | writes.push_back(CreateMockWrite(priority, seq++)); |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 6318 | |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6319 | reads.push_back(MockRead(ASYNC, ERR_IO_PENDING, seq++)); |
| 6320 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 6321 | spdy::Http2HeaderBlock pushed_response_headers; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6322 | pushed_response_headers[spdy::kHttp2StatusHeader] = |
| 6323 | GetParam().pushed_status_code; |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6324 | for (const auto& header : GetParam().extra_pushed_response_headers) { |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6325 | pushed_response_headers.insert(header); |
| 6326 | } |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6327 | spdy::SpdySerializedFrame pushed_response( |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6328 | spdy_util_.ConstructSpdyReply(2, std::move(pushed_response_headers))); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6329 | reads.push_back(CreateMockRead(pushed_response, seq++)); |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 6330 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6331 | spdy::SpdySerializedFrame resp1( |
| 6332 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6333 | reads.push_back(CreateMockRead(resp1, seq++)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6334 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6335 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6336 | reads.push_back(CreateMockRead(body1, seq++)); |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6337 | spdy_util_.UpdateWithStreamDestruction(1); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6338 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6339 | spdy::SpdySerializedFrame pushed_body( |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6340 | spdy_util_.ConstructSpdyDataFrame(2, "This is pushed.", true)); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6341 | reads.push_back(CreateMockRead(pushed_body, seq++)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6342 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6343 | // If push is not accepted, a new request is sent on the wire. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6344 | spdy::SpdySerializedFrame rst; |
| 6345 | spdy::SpdySerializedFrame req2; |
| 6346 | spdy::SpdySerializedFrame resp2; |
| 6347 | spdy::SpdySerializedFrame body2; |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6348 | if (!GetParam().push_accepted) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6349 | rst = spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_CANCEL); |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6350 | writes.push_back(CreateMockWrite(rst, seq++)); |
| 6351 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 6352 | spdy::Http2HeaderBlock request_headers2( |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6353 | spdy_util_.ConstructGetHeaderBlock(kPushedUrl)); |
| 6354 | for (const auto& header : GetParam().extra_request_headers) { |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6355 | request_headers2.insert(header); |
| 6356 | } |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6357 | req2 = spdy_util_.ConstructSpdyHeaders(3, std::move(request_headers2), |
| 6358 | LOWEST, true); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6359 | writes.push_back(CreateMockWrite(req2, seq++)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6360 | |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6361 | resp2 = spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6362 | reads.push_back(CreateMockRead(resp2, seq++)); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 6363 | |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6364 | body2 = spdy_util_.ConstructSpdyDataFrame(3, "This is not pushed.", true); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6365 | reads.push_back(CreateMockRead(body2, seq++)); |
| 6366 | } |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 6367 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6368 | reads.push_back(MockRead(ASYNC, ERR_IO_PENDING, seq++)); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 6369 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6370 | reads.push_back(MockRead(ASYNC, 0, seq++)); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 6371 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6372 | SequencedSocketData data(reads, writes); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 6373 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6374 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 6375 | nullptr); |
| 6376 | helper.RunPreTestSetup(); |
| 6377 | helper.AddData(&data); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 6378 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6379 | HttpNetworkTransaction* trans = helper.trans(); |
| 6380 | TestCompletionCallback callback1; |
| 6381 | int rv = trans->Start(&request_, callback1.callback(), log_); |
| 6382 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6383 | |
| 6384 | // Open connection. |
| 6385 | base::RunLoop().RunUntilIdle(); |
| 6386 | |
| 6387 | if (pushed_response_headers_received_before_request) { |
| 6388 | // Read pushed response headers. |
| 6389 | data.Resume(); |
| 6390 | base::RunLoop().RunUntilIdle(); |
| 6391 | } |
| 6392 | |
| 6393 | HttpRequestInfo request2 = CreateGetPushRequest(); |
| 6394 | for (const auto& header : GetParam().extra_request_headers) { |
| 6395 | request2.extra_headers.SetHeader(header.first, header.second); |
| 6396 | } |
| 6397 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 6398 | TestCompletionCallback callback2; |
| 6399 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 6400 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 6401 | base::RunLoop().RunUntilIdle(); |
| 6402 | |
| 6403 | if (!pushed_response_headers_received_before_request) { |
| 6404 | // Read pushed response headers. |
| 6405 | data.Resume(); |
| 6406 | base::RunLoop().RunUntilIdle(); |
| 6407 | } |
| 6408 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6409 | rv = callback1.WaitForResult(); |
| 6410 | EXPECT_THAT(rv, IsOk()); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 6411 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6412 | const HttpResponseInfo* const response1 = trans->GetResponseInfo(); |
| 6413 | EXPECT_TRUE(response1->headers); |
| 6414 | EXPECT_EQ("HTTP/1.1 200", response1->headers->GetStatusLine()); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 6415 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6416 | std::string result1; |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6417 | ReadResult(trans, &result1); |
| 6418 | EXPECT_EQ(result1, "hello!"); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 6419 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6420 | rv = callback2.WaitForResult(); |
| 6421 | EXPECT_THAT(rv, IsOk()); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 6422 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6423 | std::string result2; |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6424 | ReadResult(&trans2, &result2); |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6425 | EXPECT_EQ(result2, GetParam().push_accepted ? "This is pushed." |
| 6426 | : "This is not pushed."); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 6427 | |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6428 | data.Resume(); |
| 6429 | base::RunLoop().RunUntilIdle(); |
| 6430 | helper.VerifyDataConsumed(); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6431 | |
| 6432 | histogram_tester.ExpectBucketCount( |
| 6433 | "Net.SpdyPushedStreamFate", static_cast<int>(GetParam().expected_fate), |
| 6434 | 1); |
| 6435 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
Bence Béky | c4caf07 | 2018-04-20 22:27:30 | [diff] [blame] | 6436 | } |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6437 | }; |
| 6438 | |
Ilia Samsonov | 958c9fef | 2019-11-20 21:37:31 | [diff] [blame] | 6439 | INSTANTIATE_TEST_SUITE_P(All, |
Victor Costan | 2309ea0 | 2019-02-13 21:35:47 | [diff] [blame] | 6440 | SpdyNetworkTransactionPushHeaderTest, |
| 6441 | ::testing::ValuesIn(push_header_test_cases)); |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6442 | |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6443 | TEST_P(SpdyNetworkTransactionPushHeaderTest, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6444 | PushedResponseHeadersReceivedBeforeRequest) { |
| 6445 | RunTest(/* pushed_response_headers_received_before_request = */ true); |
Bence Béky | 04268b02 | 2018-04-19 01:17:41 | [diff] [blame] | 6446 | } |
| 6447 | |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6448 | TEST_P(SpdyNetworkTransactionPushHeaderTest, |
Bence Béky | 49db0e2 | 2018-05-11 00:54:05 | [diff] [blame] | 6449 | PushedResponseHeadersReceivedAfterRequest) { |
| 6450 | RunTest(/* pushed_response_headers_received_before_request = */ false); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6451 | } |
| 6452 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 6453 | TEST_F(SpdyNetworkTransactionTest, ResponseHeadersTwice) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6454 | spdy::SpdySerializedFrame req( |
| 6455 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 6456 | spdy::SpdySerializedFrame rst( |
| 6457 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
[email protected] | b771bb7 | 2013-06-24 09:55:41 | [diff] [blame] | 6458 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6459 | CreateMockWrite(req, 0), CreateMockWrite(rst, 4), |
[email protected] | 745aa9c | 2014-06-27 02:21:29 | [diff] [blame] | 6460 | }; |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6461 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6462 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6463 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 6464 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 6465 | spdy::Http2HeaderBlock late_headers; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 6466 | late_headers["hello"] = "bye"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6467 | spdy::SpdySerializedFrame stream1_headers( |
| 6468 | spdy_util_.ConstructSpdyResponseHeaders(1, std::move(late_headers), |
| 6469 | false)); |
| 6470 | spdy::SpdySerializedFrame stream1_body( |
| 6471 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6472 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6473 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream1_headers, 2), |
| 6474 | CreateMockRead(stream1_body, 3), MockRead(ASYNC, 0, 5) // EOF |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6475 | }; |
| 6476 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6477 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6478 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 6479 | helper.RunToCompletion(&data); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6480 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 6481 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6482 | } |
| 6483 | |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 6484 | // Tests that receiving HEADERS, DATA, HEADERS, and DATA in that sequence will |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 6485 | // trigger a ERR_HTTP2_PROTOCOL_ERROR because trailing HEADERS must not be |
xunjieli | 294da72 | 2015-08-11 19:15:02 | [diff] [blame] | 6486 | // followed by any DATA frames. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6487 | TEST_F(SpdyNetworkTransactionTest, SyncReplyDataAfterTrailers) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6488 | spdy::SpdySerializedFrame req( |
| 6489 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 6490 | spdy::SpdySerializedFrame rst( |
| 6491 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
[email protected] | b771bb7 | 2013-06-24 09:55:41 | [diff] [blame] | 6492 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6493 | CreateMockWrite(req, 0), CreateMockWrite(rst, 5), |
[email protected] | b771bb7 | 2013-06-24 09:55:41 | [diff] [blame] | 6494 | }; |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6495 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6496 | spdy::SpdySerializedFrame stream1_reply( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6497 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6498 | spdy::SpdySerializedFrame stream1_body( |
| 6499 | spdy_util_.ConstructSpdyDataFrame(1, false)); |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 6500 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 6501 | spdy::Http2HeaderBlock late_headers; |
bnc | 38dcd39 | 2016-02-09 23:19:49 | [diff] [blame] | 6502 | late_headers["hello"] = "bye"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6503 | spdy::SpdySerializedFrame stream1_headers( |
| 6504 | spdy_util_.ConstructSpdyResponseHeaders(1, std::move(late_headers), |
| 6505 | false)); |
| 6506 | spdy::SpdySerializedFrame stream1_body2( |
| 6507 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6508 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6509 | CreateMockRead(stream1_reply, 1), CreateMockRead(stream1_body, 2), |
| 6510 | CreateMockRead(stream1_headers, 3), CreateMockRead(stream1_body2, 4), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 6511 | MockRead(ASYNC, 0, 6) // EOF |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6512 | }; |
| 6513 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6514 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6515 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 6516 | helper.RunToCompletion(&data); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6517 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 6518 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
[email protected] | d0835850 | 2010-12-03 22:04:03 | [diff] [blame] | 6519 | } |
| 6520 | |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6521 | struct PushUrlTestParams { |
| 6522 | const char* url_to_fetch; |
| 6523 | const char* url_to_push; |
Bence Béky | b2f7667 | 2018-06-11 21:10:13 | [diff] [blame] | 6524 | bool client_cert_sent; |
Matt Menke | c74a926 | 2020-06-09 15:49:21 | [diff] [blame] | 6525 | bool expect_ct_error; |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6526 | SpdyPushedStreamFate expected_fate; |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6527 | } push_url_test_cases[] = { |
| 6528 | // http scheme cannot be pushed (except by trusted proxy). |
Matt Menke | c74a926 | 2020-06-09 15:49:21 | [diff] [blame] | 6529 | {"https://www.example.org/foo.html", "http://www.example.org/foo.js", |
| 6530 | false /* client_cert_sent */, false /* expect_ct_error */, |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6531 | SpdyPushedStreamFate::kNonHttpsPushedScheme}, |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6532 | // ftp scheme cannot be pushed. |
Matt Menke | c74a926 | 2020-06-09 15:49:21 | [diff] [blame] | 6533 | {"https://www.example.org/foo.html", "ftp://www.example.org/foo.js", |
| 6534 | false /* client_cert_sent */, false /* expect_ct_error */, |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6535 | SpdyPushedStreamFate::kInvalidUrl}, |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6536 | // Cross subdomain, certificate not valid. |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6537 | {"https://www.example.org/foo.html", "https://blat.www.example.org/foo.js", |
Matt Menke | c74a926 | 2020-06-09 15:49:21 | [diff] [blame] | 6538 | false /* client_cert_sent */, false /* expect_ct_error */, |
| 6539 | SpdyPushedStreamFate::kCertificateMismatch}, |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6540 | // Cross domain, certificate not valid. |
Matt Menke | c74a926 | 2020-06-09 15:49:21 | [diff] [blame] | 6541 | {"https://www.example.org/foo.html", "https://www.foo.com/foo.js", |
| 6542 | false /* client_cert_sent */, false /* expect_ct_error */, |
Bence Béky | b2f7667 | 2018-06-11 21:10:13 | [diff] [blame] | 6543 | SpdyPushedStreamFate::kCertificateMismatch}, |
| 6544 | // Cross domain, certificate valid, but cross-origin push is rejected on a |
| 6545 | // connection with client certificate. |
| 6546 | {"https://www.example.org/foo.html", "https://mail.example.org/foo.js", |
Matt Menke | c74a926 | 2020-06-09 15:49:21 | [diff] [blame] | 6547 | true /* client_cert_sent */, false /* expect_ct_error */, |
| 6548 | SpdyPushedStreamFate::kCertificateMismatch}, |
| 6549 | // Cross domain, certificate valid, but cross-origin push is rejected on a |
| 6550 | // connection with an Expect-CT error. |
| 6551 | {"https://www.example.org/foo.html", "https://mail.example.org/foo.js", |
| 6552 | false /* client_cert_sent */, true /* expect_ct_error */, |
| 6553 | SpdyPushedStreamFate::kCertificateMismatch}}; |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6554 | |
| 6555 | class SpdyNetworkTransactionPushUrlTest |
| 6556 | : public SpdyNetworkTransactionTest, |
| 6557 | public ::testing::WithParamInterface<PushUrlTestParams> { |
Matt Menke | c74a926 | 2020-06-09 15:49:21 | [diff] [blame] | 6558 | public: |
| 6559 | SpdyNetworkTransactionPushUrlTest() { |
| 6560 | // Set features needed for the |expect_ct_error| case, where it's important |
| 6561 | // to check that NetworkIsolationKeys are respected. |
| 6562 | feature_list_.InitWithFeatures( |
| 6563 | /* enabled_features */ |
| 6564 | {TransportSecurityState::kDynamicExpectCTFeature, |
| 6565 | features::kPartitionExpectCTStateByNetworkIsolationKey, |
| 6566 | features::kPartitionConnectionsByNetworkIsolationKey, |
| 6567 | features::kPartitionSSLSessionsByNetworkIsolationKey}, |
| 6568 | /* disabled_features */ |
| 6569 | {}); |
| 6570 | } |
| 6571 | |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6572 | protected: |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6573 | // In this test we want to verify that we can't accidentally push content |
| 6574 | // which can't be pushed by this content server. |
| 6575 | // This test assumes that: |
| 6576 | // - if we're requesting http://www.foo.com/barbaz |
| 6577 | // - the browser has made a connection to "www.foo.com". |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6578 | void RunTest() { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6579 | base::HistogramTester histogram_tester; |
| 6580 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6581 | SpdyTestUtil spdy_test_util; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6582 | spdy::SpdySerializedFrame stream1_syn( |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6583 | spdy_test_util.ConstructSpdyGet(GetParam().url_to_fetch, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6584 | spdy::SpdySerializedFrame stream1_body( |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6585 | spdy_test_util.ConstructSpdyDataFrame(1, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6586 | spdy::SpdySerializedFrame push_rst(spdy_test_util.ConstructSpdyRstStream( |
| 6587 | 2, spdy::ERROR_CODE_REFUSED_STREAM)); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6588 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6589 | CreateMockWrite(stream1_syn, 0), CreateMockWrite(push_rst, 3), |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6590 | }; |
| 6591 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6592 | spdy::SpdySerializedFrame stream1_reply( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 6593 | spdy_test_util.ConstructSpdyGetReply(nullptr, 0, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6594 | spdy::SpdySerializedFrame stream2_syn(spdy_test_util.ConstructSpdyPush( |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6595 | nullptr, 0, 2, 1, GetParam().url_to_push)); |
[email protected] | 8a0fc82 | 2013-06-27 20:52:43 | [diff] [blame] | 6596 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6597 | spdy::SpdySerializedFrame stream2_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6598 | spdy_test_util.ConstructSpdyDataFrame(2, kPushedData, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6599 | spdy::SpdySerializedFrame rst( |
| 6600 | spdy_test_util.ConstructSpdyRstStream(2, spdy::ERROR_CODE_CANCEL)); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6601 | |
| 6602 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6603 | CreateMockRead(stream1_reply, 1), |
| 6604 | CreateMockRead(stream2_syn, 2), |
| 6605 | CreateMockRead(stream1_body, 4), |
| 6606 | CreateMockRead(stream2_body, 5), |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 6607 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6), // Force a pause |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6608 | }; |
| 6609 | |
| 6610 | HttpResponseInfo response; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6611 | SequencedSocketData data(reads, writes); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6612 | |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6613 | request_.url = GURL(GetParam().url_to_fetch); |
Matt Menke | c74a926 | 2020-06-09 15:49:21 | [diff] [blame] | 6614 | // Set a NetworkIsolationKey for the |expect_ct_error| case, to make sure |
| 6615 | // NetworkIsolationKeys are respected. |
| 6616 | request_.network_isolation_key = NetworkIsolationKey::CreateTransient(); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6617 | |
Bence Béky | b2f7667 | 2018-06-11 21:10:13 | [diff] [blame] | 6618 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 6619 | ssl_provider->ssl_info.client_cert_sent = GetParam().client_cert_sent; |
| 6620 | ssl_provider->ssl_info.cert = |
| 6621 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
Eric Orth | fc0583b | 2021-05-18 19:13:59 | [diff] [blame] | 6622 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
Matt Menke | c74a926 | 2020-06-09 15:49:21 | [diff] [blame] | 6623 | if (GetParam().expect_ct_error) { |
| 6624 | ssl_provider->ssl_info.ct_policy_compliance = |
| 6625 | ct::CTPolicyCompliance::CT_POLICY_NOT_ENOUGH_SCTS; |
| 6626 | ssl_provider->ssl_info.is_issued_by_known_root = true; |
| 6627 | |
| 6628 | session_deps->transport_security_state->AddExpectCT( |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 6629 | "mail.example.org", base::Time::Now() + base::Days(1) /* expiry */, |
| 6630 | true, GURL(), request_.network_isolation_key); |
Matt Menke | c74a926 | 2020-06-09 15:49:21 | [diff] [blame] | 6631 | } |
| 6632 | |
| 6633 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 6634 | std::move(session_deps)); |
| 6635 | |
| 6636 | helper.RunPreTestSetup(); |
| 6637 | |
| 6638 | if (GetParam().expect_ct_error) { |
| 6639 | ssl_provider->ssl_info.ct_policy_compliance = |
| 6640 | ct::CTPolicyCompliance::CT_POLICY_NOT_ENOUGH_SCTS; |
| 6641 | ssl_provider->ssl_info.is_issued_by_known_root = true; |
| 6642 | } |
| 6643 | |
Bence Béky | b2f7667 | 2018-06-11 21:10:13 | [diff] [blame] | 6644 | helper.AddDataWithSSLSocketDataProvider(&data, std::move(ssl_provider)); |
[email protected] | 7c6f7ba | 2012-04-03 04:09:29 | [diff] [blame] | 6645 | |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6646 | HttpNetworkTransaction* trans = helper.trans(); |
| 6647 | |
| 6648 | // Start the transaction with basic parameters. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 6649 | TestCompletionCallback callback; |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6650 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6651 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6652 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6653 | rv = callback.WaitForResult(); |
| 6654 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 6655 | // Finish async network reads/writes. |
| 6656 | base::RunLoop().RunUntilIdle(); |
| 6657 | |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6658 | // Read the response body. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6659 | std::string result; |
rch | 0aecfd8 | 2015-05-19 17:22:32 | [diff] [blame] | 6660 | ReadResult(trans, &result); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6661 | |
| 6662 | // Verify that we consumed all test data. |
rch | 37de576c | 2015-05-17 20:28:17 | [diff] [blame] | 6663 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 6664 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6665 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 6666 | // Verify the response headers. |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6667 | // Copy the response info, because trans goes away. |
| 6668 | response = *trans->GetResponseInfo(); |
| 6669 | |
| 6670 | VerifyStreamsClosed(helper); |
| 6671 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 6672 | // Verify the response headers. |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6673 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 6674 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 6675 | |
| 6676 | histogram_tester.ExpectBucketCount( |
| 6677 | "Net.SpdyPushedStreamFate", static_cast<int>(GetParam().expected_fate), |
| 6678 | 1); |
| 6679 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6680 | } |
Matt Menke | c74a926 | 2020-06-09 15:49:21 | [diff] [blame] | 6681 | |
| 6682 | base::test::ScopedFeatureList feature_list_; |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6683 | }; |
| 6684 | |
Ilia Samsonov | 958c9fef | 2019-11-20 21:37:31 | [diff] [blame] | 6685 | INSTANTIATE_TEST_SUITE_P(All, |
Victor Costan | 2309ea0 | 2019-02-13 21:35:47 | [diff] [blame] | 6686 | SpdyNetworkTransactionPushUrlTest, |
| 6687 | ::testing::ValuesIn(push_url_test_cases)); |
Bence Béky | e7023f8 | 2018-05-14 01:53:03 | [diff] [blame] | 6688 | |
| 6689 | TEST_P(SpdyNetworkTransactionPushUrlTest, PushUrlTest) { |
| 6690 | RunTest(); |
[email protected] | a7a265ef | 2010-12-08 18:05:57 | [diff] [blame] | 6691 | } |
| 6692 | |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6693 | // Verify that push works cross origin as long as the certificate is valid for |
| 6694 | // the pushed authority. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6695 | TEST_F(SpdyNetworkTransactionTest, ServerPushValidCrossOrigin) { |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6696 | // "spdy_pooling.pem" is valid for both www.example.org and mail.example.org. |
| 6697 | const char* url_to_fetch = "https://www.example.org"; |
| 6698 | const char* url_to_push = "https://mail.example.org"; |
| 6699 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6700 | spdy::SpdySerializedFrame headers( |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6701 | spdy_util_.ConstructSpdyGet(url_to_fetch, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6702 | spdy::SpdySerializedFrame push_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6703 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6704 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6705 | CreateMockWrite(headers, 0), CreateMockWrite(push_priority, 3), |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6706 | }; |
| 6707 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6708 | spdy::SpdySerializedFrame reply( |
| 6709 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 6710 | spdy::SpdySerializedFrame push( |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6711 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, url_to_push)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6712 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6713 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6714 | spdy::SpdySerializedFrame pushed_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6715 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6716 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6717 | CreateMockRead(reply, 1), |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 6718 | CreateMockRead(push, 2, SYNCHRONOUS), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6719 | CreateMockRead(body, 4), |
| 6720 | CreateMockRead(pushed_body, 5, SYNCHRONOUS), |
| 6721 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6), |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6722 | }; |
| 6723 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6724 | SequencedSocketData data(reads, writes); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6725 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6726 | request_.url = GURL(url_to_fetch); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6727 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6728 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6729 | helper.RunPreTestSetup(); |
| 6730 | helper.AddData(&data); |
| 6731 | |
| 6732 | HttpNetworkTransaction* trans0 = helper.trans(); |
| 6733 | TestCompletionCallback callback0; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 6734 | int rv = trans0->Start(&request_, callback0.callback(), log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6735 | rv = callback0.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6736 | EXPECT_THAT(rv, IsOk()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6737 | |
| 6738 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 6739 | SpdySessionKey key(host_port_pair_, ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 6740 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 6741 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 6742 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6743 | base::WeakPtr<SpdySession> spdy_session = |
bnc | 9ead3ae | 2017-03-16 00:48:15 | [diff] [blame] | 6744 | spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 6745 | key, /* enable_ip_based_pooling = */ true, |
| 6746 | /* is_websocket = */ false, log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6747 | |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 6748 | EXPECT_EQ(1u, num_unclaimed_pushed_streams(spdy_session)); |
Bence Béky | 3b60901 | 2017-12-04 15:19:35 | [diff] [blame] | 6749 | EXPECT_TRUE( |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 6750 | has_unclaimed_pushed_stream_for_url(spdy_session, GURL(url_to_push))); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6751 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6752 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6753 | HttpRequestInfo push_request; |
| 6754 | push_request.method = "GET"; |
| 6755 | push_request.url = GURL(url_to_push); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 6756 | push_request.traffic_annotation = |
| 6757 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6758 | TestCompletionCallback callback1; |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 6759 | rv = trans1.Start(&push_request, callback1.callback(), log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6760 | rv = callback1.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 6761 | EXPECT_THAT(rv, IsOk()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6762 | |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 6763 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6764 | |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6765 | HttpResponseInfo response = *trans0->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6766 | EXPECT_TRUE(response.headers); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6767 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
| 6768 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6769 | std::string result0; |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6770 | ReadResult(trans0, &result0); |
| 6771 | EXPECT_EQ("hello!", result0); |
| 6772 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6773 | HttpResponseInfo push_response = *trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 6774 | EXPECT_TRUE(push_response.headers); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6775 | EXPECT_EQ("HTTP/1.1 200", push_response.headers->GetStatusLine()); |
| 6776 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 6777 | std::string result1; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 6778 | ReadResult(&trans1, &result1); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6779 | EXPECT_EQ(kPushedData, result1); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6780 | |
| 6781 | base::RunLoop().RunUntilIdle(); |
| 6782 | helper.VerifyDataConsumed(); |
| 6783 | VerifyStreamsClosed(helper); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6784 | } |
| 6785 | |
Matt Menke | df93ff7 | 2020-07-16 02:23:03 | [diff] [blame] | 6786 | // Verify that push does not work cross origin when NetworkIsolationKeys don't |
| 6787 | // match. |
| 6788 | TEST_F(SpdyNetworkTransactionTest, |
| 6789 | ServerPushCrossOriginNetworkIsolationKeyMistmatch) { |
| 6790 | base::test::ScopedFeatureList feature_list; |
| 6791 | feature_list.InitWithFeatures( |
| 6792 | // enabled_features |
| 6793 | {features::kPartitionHttpServerPropertiesByNetworkIsolationKey, |
| 6794 | // Need to partition connections by NetworkIsolationKey for |
| 6795 | // SpdySessionKeys to include NetworkIsolationKeys. |
| 6796 | features::kPartitionConnectionsByNetworkIsolationKey}, |
| 6797 | // disabled_features |
| 6798 | {}); |
| 6799 | |
| 6800 | // "spdy_pooling.pem" is valid for both www.example.org and mail.example.org. |
| 6801 | const char* url_to_fetch = "https://www.example.org"; |
| 6802 | const char* url_to_push = "https://mail.example.org"; |
| 6803 | |
| 6804 | spdy::SpdySerializedFrame headers( |
| 6805 | spdy_util_.ConstructSpdyGet(url_to_fetch, 1, LOWEST)); |
| 6806 | spdy::SpdySerializedFrame push_priority( |
| 6807 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 6808 | MockWrite writes[] = { |
| 6809 | CreateMockWrite(headers, 0), |
| 6810 | CreateMockWrite(push_priority, 3), |
| 6811 | }; |
| 6812 | |
| 6813 | spdy::SpdySerializedFrame reply( |
| 6814 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 6815 | spdy::SpdySerializedFrame push( |
| 6816 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, url_to_push)); |
| 6817 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 6818 | const char kPushedData[] = "pushed"; |
| 6819 | spdy::SpdySerializedFrame pushed_body( |
| 6820 | spdy_util_.ConstructSpdyDataFrame(2, kPushedData, true)); |
| 6821 | MockRead reads[] = { |
| 6822 | CreateMockRead(reply, 1), |
| 6823 | CreateMockRead(push, 2, SYNCHRONOUS), |
| 6824 | CreateMockRead(body, 4), |
| 6825 | CreateMockRead(pushed_body, 5, SYNCHRONOUS), |
| 6826 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6), |
| 6827 | }; |
| 6828 | |
| 6829 | SequencedSocketData data(reads, writes); |
| 6830 | |
| 6831 | request_.url = GURL(url_to_fetch); |
| 6832 | |
| 6833 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 6834 | helper.RunPreTestSetup(); |
| 6835 | helper.AddData(&data); |
| 6836 | |
| 6837 | SequencedSocketData data2(net::MockConnect(ASYNC, net::ERR_FAILED), |
| 6838 | base::span<MockRead>(), base::span<MockWrite>()); |
| 6839 | helper.AddData(&data2); |
| 6840 | |
| 6841 | HttpNetworkTransaction* trans0 = helper.trans(); |
| 6842 | TestCompletionCallback callback0; |
| 6843 | int rv = trans0->Start(&request_, callback0.callback(), log_); |
| 6844 | rv = callback0.GetResult(rv); |
| 6845 | EXPECT_THAT(rv, IsOk()); |
| 6846 | |
| 6847 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 6848 | SpdySessionKey key(host_port_pair_, ProxyServer::Direct(), |
| 6849 | PRIVACY_MODE_DISABLED, |
| 6850 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 6851 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | df93ff7 | 2020-07-16 02:23:03 | [diff] [blame] | 6852 | base::WeakPtr<SpdySession> spdy_session = |
| 6853 | spdy_session_pool->FindAvailableSession( |
| 6854 | key, /* enable_ip_based_pooling = */ true, |
| 6855 | /* is_websocket = */ false, log_); |
| 6856 | |
| 6857 | EXPECT_EQ(1u, num_unclaimed_pushed_streams(spdy_session)); |
| 6858 | EXPECT_TRUE( |
| 6859 | has_unclaimed_pushed_stream_for_url(spdy_session, GURL(url_to_push))); |
| 6860 | |
| 6861 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 6862 | HttpRequestInfo push_request; |
| 6863 | // Use a different NetworkIsolationKey than |spdy_session| (which uses an |
| 6864 | // empty one). |
| 6865 | push_request.network_isolation_key = NetworkIsolationKey::CreateTransient(); |
| 6866 | push_request.method = "GET"; |
| 6867 | push_request.url = GURL(url_to_push); |
| 6868 | push_request.traffic_annotation = |
| 6869 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 6870 | TestCompletionCallback callback1; |
| 6871 | rv = trans1.Start(&push_request, callback1.callback(), log_); |
| 6872 | // This transaction should try and use a new socket, which fails. |
| 6873 | EXPECT_THAT(callback1.GetResult(rv), IsError(net::ERR_FAILED)); |
| 6874 | |
| 6875 | // The pushed stream should still be pending. |
| 6876 | EXPECT_EQ(1u, num_unclaimed_pushed_streams(spdy_session)); |
| 6877 | |
| 6878 | // Try again, this time with an empty NetworkIsolationKey, matching the |
| 6879 | // SpdySession's. This request should successfully get the pushed stream. |
| 6880 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 6881 | push_request.network_isolation_key = NetworkIsolationKey(); |
| 6882 | TestCompletionCallback callback2; |
| 6883 | rv = trans1.Start(&push_request, callback2.callback(), log_); |
| 6884 | EXPECT_THAT(callback2.GetResult(rv), IsOk()); |
| 6885 | |
| 6886 | HttpResponseInfo response = *trans0->GetResponseInfo(); |
| 6887 | EXPECT_TRUE(response.headers); |
| 6888 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
| 6889 | |
| 6890 | std::string result0; |
| 6891 | ReadResult(trans0, &result0); |
| 6892 | EXPECT_EQ("hello!", result0); |
| 6893 | |
| 6894 | HttpResponseInfo push_response = *trans1.GetResponseInfo(); |
| 6895 | EXPECT_TRUE(push_response.headers); |
| 6896 | EXPECT_EQ("HTTP/1.1 200", push_response.headers->GetStatusLine()); |
| 6897 | |
| 6898 | std::string result1; |
| 6899 | ReadResult(&trans1, &result1); |
| 6900 | EXPECT_EQ(kPushedData, result1); |
| 6901 | |
| 6902 | base::RunLoop().RunUntilIdle(); |
| 6903 | helper.VerifyDataConsumed(); |
| 6904 | VerifyStreamsClosed(helper); |
| 6905 | } |
| 6906 | |
Bence Béky | b2f7667 | 2018-06-11 21:10:13 | [diff] [blame] | 6907 | // Regression test for https://crbug.com/832859: Server push is accepted on a |
| 6908 | // connection with client certificate, as long as SpdySessionKey matches. |
| 6909 | TEST_F(SpdyNetworkTransactionTest, ServerPushWithClientCert) { |
| 6910 | spdy::SpdySerializedFrame req( |
| 6911 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, DEFAULT_PRIORITY)); |
| 6912 | spdy::SpdySerializedFrame priority( |
| 6913 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 6914 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(priority, 3)}; |
| 6915 | |
| 6916 | spdy::SpdySerializedFrame resp( |
| 6917 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 6918 | spdy::SpdySerializedFrame push( |
| 6919 | spdy_util_.ConstructSpdyPush(nullptr, 0, 2, 1, kPushedUrl)); |
| 6920 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 6921 | spdy::SpdySerializedFrame body2( |
| 6922 | spdy_util_.ConstructSpdyDataFrame(2, "pushed", true)); |
| 6923 | MockRead reads[] = {CreateMockRead(resp, 1), CreateMockRead(push, 2), |
| 6924 | CreateMockRead(body1, 4), CreateMockRead(body2, 5), |
| 6925 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6)}; |
| 6926 | |
| 6927 | SequencedSocketData data(reads, writes); |
| 6928 | |
| 6929 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 6930 | ssl_provider->ssl_info.client_cert_sent = true; |
| 6931 | ssl_provider->ssl_info.cert = |
| 6932 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
| 6933 | |
| 6934 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 6935 | helper.RunPreTestSetup(); |
| 6936 | helper.AddDataWithSSLSocketDataProvider(&data, std::move(ssl_provider)); |
| 6937 | |
| 6938 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 6939 | helper.FinishDefaultTest(); |
| 6940 | |
| 6941 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 6942 | HttpRequestInfo request = CreateGetPushRequest(); |
| 6943 | TestCompletionCallback callback; |
| 6944 | int rv = trans2.Start(&request, callback.callback(), log_); |
| 6945 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 6946 | |
| 6947 | rv = callback.WaitForResult(); |
| 6948 | EXPECT_THAT(rv, IsOk()); |
| 6949 | |
| 6950 | const HttpResponseInfo* const response = trans2.GetResponseInfo(); |
| 6951 | EXPECT_TRUE(response->headers); |
| 6952 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 6953 | |
| 6954 | std::string result; |
| 6955 | ReadResult(&trans2, &result); |
| 6956 | EXPECT_EQ("pushed", result); |
| 6957 | |
| 6958 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 6959 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
| 6960 | |
| 6961 | VerifyStreamsClosed(helper); |
| 6962 | } |
| 6963 | |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6964 | // Verify that push works cross origin, even if there is already a connection |
| 6965 | // open to origin of pushed resource. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6966 | TEST_F(SpdyNetworkTransactionTest, ServerPushValidCrossOriginWithOpenSession) { |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6967 | const char* url_to_fetch0 = "https://mail.example.org/foo"; |
| 6968 | const char* url_to_fetch1 = "https://docs.example.org"; |
| 6969 | const char* url_to_push = "https://mail.example.org/bar"; |
| 6970 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6971 | SpdyTestUtil spdy_util_0; |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6972 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6973 | spdy::SpdySerializedFrame headers0( |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6974 | spdy_util_0.ConstructSpdyGet(url_to_fetch0, 1, LOWEST)); |
| 6975 | MockWrite writes0[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6976 | CreateMockWrite(headers0, 0), |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6977 | }; |
| 6978 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6979 | spdy::SpdySerializedFrame reply0( |
| 6980 | spdy_util_0.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6981 | const char kData0[] = "first"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6982 | spdy::SpdySerializedFrame body0( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 6983 | spdy_util_0.ConstructSpdyDataFrame(1, kData0, true)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6984 | MockRead reads0[] = {CreateMockRead(reply0, 1), CreateMockRead(body0, 2), |
| 6985 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 3)}; |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6986 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 6987 | SequencedSocketData data0(reads0, writes0); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6988 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 6989 | SpdyTestUtil spdy_util_1; |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6990 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6991 | spdy::SpdySerializedFrame headers1( |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6992 | spdy_util_1.ConstructSpdyGet(url_to_fetch1, 1, LOWEST)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 6993 | spdy::SpdySerializedFrame push_priority( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6994 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6995 | MockWrite writes1[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 6996 | CreateMockWrite(headers1, 0), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 6997 | CreateMockWrite(push_priority, 3, SYNCHRONOUS), |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 6998 | }; |
| 6999 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7000 | spdy::SpdySerializedFrame reply1( |
| 7001 | spdy_util_1.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 7002 | spdy::SpdySerializedFrame push( |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7003 | spdy_util_1.ConstructSpdyPush(nullptr, 0, 2, 1, url_to_push)); |
| 7004 | const char kData1[] = "second"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7005 | spdy::SpdySerializedFrame body1( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7006 | spdy_util_1.ConstructSpdyDataFrame(1, kData1, true)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7007 | const char kPushedData[] = "pushed"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7008 | spdy::SpdySerializedFrame pushed_body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7009 | spdy_util_1.ConstructSpdyDataFrame(2, kPushedData, true)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7010 | |
| 7011 | MockRead reads1[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7012 | CreateMockRead(reply1, 1), |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 7013 | CreateMockRead(push, 2, SYNCHRONOUS), |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 7014 | CreateMockRead(body1, 4), |
| 7015 | CreateMockRead(pushed_body, 5, SYNCHRONOUS), |
| 7016 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 6), |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7017 | }; |
| 7018 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7019 | SequencedSocketData data1(reads1, writes1); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7020 | |
| 7021 | // Request |url_to_fetch0| to open connection to mail.example.org. |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7022 | request_.url = GURL(url_to_fetch0); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7023 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7024 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7025 | helper.RunPreTestSetup(); |
| 7026 | |
| 7027 | // "spdy_pooling.pem" is valid for www.example.org, but not for |
| 7028 | // docs.example.org. |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 7029 | auto ssl_provider0 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 7030 | ssl_provider0->ssl_info.cert = |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7031 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 7032 | ASSERT_TRUE(ssl_provider0->ssl_info.cert); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7033 | helper.AddDataWithSSLSocketDataProvider(&data0, std::move(ssl_provider0)); |
| 7034 | |
| 7035 | // "wildcard.pem" is valid for both www.example.org and docs.example.org. |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 7036 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 7037 | ssl_provider1->ssl_info.cert = |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7038 | ImportCertFromFile(GetTestCertsDirectory(), "wildcard.pem"); |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 7039 | ASSERT_TRUE(ssl_provider1->ssl_info.cert); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7040 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
| 7041 | |
| 7042 | HttpNetworkTransaction* trans0 = helper.trans(); |
| 7043 | TestCompletionCallback callback0; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7044 | int rv = trans0->Start(&request_, callback0.callback(), log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7045 | rv = callback0.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7046 | EXPECT_THAT(rv, IsOk()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7047 | |
| 7048 | // Request |url_to_fetch1|, during which docs.example.org pushes |
| 7049 | // |url_to_push|, which happens to be for www.example.org, to which there is |
| 7050 | // already an open connection. |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 7051 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7052 | HttpRequestInfo request1; |
| 7053 | request1.method = "GET"; |
| 7054 | request1.url = GURL(url_to_fetch1); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 7055 | request1.traffic_annotation = |
| 7056 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7057 | TestCompletionCallback callback1; |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 7058 | rv = trans1.Start(&request1, callback1.callback(), log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7059 | rv = callback1.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7060 | EXPECT_THAT(rv, IsOk()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7061 | |
| 7062 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 7063 | HostPortPair host_port_pair0("mail.example.org", 443); |
| 7064 | SpdySessionKey key0(host_port_pair0, ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 7065 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 7066 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 7067 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7068 | base::WeakPtr<SpdySession> spdy_session0 = |
bnc | 9ead3ae | 2017-03-16 00:48:15 | [diff] [blame] | 7069 | spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 7070 | key0, /* enable_ip_based_pooling = */ true, |
| 7071 | /* is_websocket = */ false, log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7072 | |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 7073 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session0)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7074 | |
| 7075 | HostPortPair host_port_pair1("docs.example.org", 443); |
| 7076 | SpdySessionKey key1(host_port_pair1, ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 7077 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 7078 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 7079 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7080 | base::WeakPtr<SpdySession> spdy_session1 = |
bnc | 9ead3ae | 2017-03-16 00:48:15 | [diff] [blame] | 7081 | spdy_session_pool->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 7082 | key1, /* enable_ip_based_pooling = */ true, |
| 7083 | /* is_websocket = */ false, log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7084 | |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 7085 | EXPECT_EQ(1u, num_unclaimed_pushed_streams(spdy_session1)); |
Bence Béky | 3b60901 | 2017-12-04 15:19:35 | [diff] [blame] | 7086 | EXPECT_TRUE( |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 7087 | has_unclaimed_pushed_stream_for_url(spdy_session1, GURL(url_to_push))); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7088 | |
| 7089 | // Request |url_to_push|, which should be served from the pushed resource. |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 7090 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7091 | HttpRequestInfo push_request; |
| 7092 | push_request.method = "GET"; |
| 7093 | push_request.url = GURL(url_to_push); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 7094 | push_request.traffic_annotation = |
| 7095 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7096 | TestCompletionCallback callback2; |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 7097 | rv = trans2.Start(&push_request, callback2.callback(), log_); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7098 | rv = callback2.GetResult(rv); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7099 | EXPECT_THAT(rv, IsOk()); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7100 | |
Bence Béky | 285e7d4 | 2017-12-04 20:22:11 | [diff] [blame] | 7101 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session0)); |
| 7102 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session1)); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7103 | |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7104 | HttpResponseInfo response0 = *trans0->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 7105 | EXPECT_TRUE(response0.headers); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7106 | EXPECT_EQ("HTTP/1.1 200", response0.headers->GetStatusLine()); |
| 7107 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7108 | std::string result0; |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7109 | ReadResult(trans0, &result0); |
| 7110 | EXPECT_EQ(kData0, result0); |
| 7111 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 7112 | HttpResponseInfo response1 = *trans1.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 7113 | EXPECT_TRUE(response1.headers); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7114 | EXPECT_EQ("HTTP/1.1 200", response1.headers->GetStatusLine()); |
| 7115 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7116 | std::string result1; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 7117 | ReadResult(&trans1, &result1); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7118 | EXPECT_EQ(kData1, result1); |
| 7119 | |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 7120 | HttpResponseInfo push_response = *trans2.GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 7121 | EXPECT_TRUE(push_response.headers); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7122 | EXPECT_EQ("HTTP/1.1 200", push_response.headers->GetStatusLine()); |
| 7123 | |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7124 | std::string result2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 7125 | ReadResult(&trans2, &result2); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7126 | EXPECT_EQ(kPushedData, result2); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 7127 | |
| 7128 | base::RunLoop().RunUntilIdle(); |
| 7129 | helper.VerifyDataConsumed(); |
| 7130 | VerifyStreamsClosed(helper); |
bnc | 3e79387f | 2016-03-15 14:49:20 | [diff] [blame] | 7131 | } |
| 7132 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7133 | TEST_F(SpdyNetworkTransactionTest, RetryAfterRefused) { |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 7134 | // Construct the request. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7135 | spdy::SpdySerializedFrame req( |
| 7136 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 7137 | // Will be destroyed by the RST before stream 3 starts. |
| 7138 | spdy_util_.UpdateWithStreamDestruction(1); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7139 | spdy::SpdySerializedFrame req2( |
| 7140 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 7141 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7142 | CreateMockWrite(req, 0), CreateMockWrite(req2, 2), |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 7143 | }; |
| 7144 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7145 | spdy::SpdySerializedFrame refused( |
| 7146 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_REFUSED_STREAM)); |
| 7147 | spdy::SpdySerializedFrame resp( |
| 7148 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 7149 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(3, true)); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 7150 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7151 | CreateMockRead(refused, 1), CreateMockRead(resp, 3), |
| 7152 | CreateMockRead(body, 4), MockRead(ASYNC, 0, 5) // EOF |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 7153 | }; |
| 7154 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7155 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7156 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 7157 | |
| 7158 | helper.RunPreTestSetup(); |
[email protected] | dd54bd8 | 2012-07-19 23:44:57 | [diff] [blame] | 7159 | helper.AddData(&data); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 7160 | |
| 7161 | HttpNetworkTransaction* trans = helper.trans(); |
| 7162 | |
| 7163 | // Start the transaction with basic parameters. |
[email protected] | 49639fa | 2011-12-20 23:22:41 | [diff] [blame] | 7164 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7165 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7166 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 7167 | rv = callback.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7168 | EXPECT_THAT(rv, IsOk()); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 7169 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 7170 | // Finish async network reads. |
| 7171 | base::RunLoop().RunUntilIdle(); |
| 7172 | |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 7173 | // Verify that we consumed all test data. |
rch | 08e3aa3e | 2015-05-16 14:27:52 | [diff] [blame] | 7174 | EXPECT_TRUE(data.AllReadDataConsumed()); |
| 7175 | EXPECT_TRUE(data.AllWriteDataConsumed()); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 7176 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 7177 | // Verify the response headers. |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 7178 | HttpResponseInfo response = *trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 7179 | EXPECT_TRUE(response.headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 7180 | EXPECT_EQ("HTTP/1.1 200", response.headers->GetStatusLine()); |
[email protected] | 721c0ce | 2011-10-13 02:41:00 | [diff] [blame] | 7181 | } |
| 7182 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 7183 | TEST_F(SpdyNetworkTransactionTest, OutOfOrderHeaders) { |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7184 | // This first request will start to establish the SpdySession. |
| 7185 | // Then we will start the second (MEDIUM priority) and then third |
| 7186 | // (HIGHEST priority) request in such a way that the third will actually |
[email protected] | c92f4b454 | 2012-07-26 23:53:21 | [diff] [blame] | 7187 | // start before the second, causing the second to be numbered differently |
[email protected] | 513963e | 2013-06-15 01:53:04 | [diff] [blame] | 7188 | // than the order they were created. |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 7189 | // |
| 7190 | // Note that the requests and responses created below are expectations |
| 7191 | // of what the above will produce on the wire, and hence are in the |
| 7192 | // initial->HIGHEST->LOWEST priority. |
| 7193 | // |
| 7194 | // Frames are created by SpdySession just before the write associated |
| 7195 | // with the frame is attempted, so stream dependencies will be based |
| 7196 | // on the streams alive at the point of the request write attempt. Thus |
| 7197 | // req1 is alive when req2 is attempted (during but not after the |
| 7198 | // |data.RunFor(2);| statement below) but not when req3 is attempted. |
| 7199 | // The call to spdy_util_.UpdateWithStreamDestruction() reflects this. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7200 | spdy::SpdySerializedFrame req1( |
| 7201 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 7202 | spdy::SpdySerializedFrame req2( |
| 7203 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, HIGHEST)); |
rdsmith | ebb50aa | 2015-11-12 03:44:38 | [diff] [blame] | 7204 | spdy_util_.UpdateWithStreamDestruction(1); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7205 | spdy::SpdySerializedFrame req3( |
| 7206 | spdy_util_.ConstructSpdyGet(nullptr, 0, 5, MEDIUM)); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7207 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7208 | MockWrite(ASYNC, ERR_IO_PENDING, 0), CreateMockWrite(req1, 1), |
| 7209 | CreateMockWrite(req2, 5), CreateMockWrite(req3, 6), |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7210 | }; |
| 7211 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7212 | spdy::SpdySerializedFrame resp1( |
| 7213 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 7214 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 7215 | spdy::SpdySerializedFrame resp2( |
| 7216 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 7217 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 7218 | spdy::SpdySerializedFrame resp3( |
| 7219 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 5)); |
| 7220 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame(5, true)); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7221 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7222 | CreateMockRead(resp1, 2), MockRead(ASYNC, ERR_IO_PENDING, 3), |
| 7223 | CreateMockRead(body1, 4), CreateMockRead(resp2, 7), |
| 7224 | CreateMockRead(body2, 8), CreateMockRead(resp3, 9), |
| 7225 | CreateMockRead(body3, 10), MockRead(ASYNC, 0, 11) // EOF |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7226 | }; |
| 7227 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7228 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7229 | NormalSpdyTransactionHelper helper(request_, LOWEST, log_, nullptr); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7230 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7231 | helper.AddData(&data); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7232 | |
| 7233 | // Start the first transaction to set up the SpdySession |
| 7234 | HttpNetworkTransaction* trans = helper.trans(); |
| 7235 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7236 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7237 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7238 | |
| 7239 | // Run the message loop, but do not allow the write to complete. |
| 7240 | // This leaves the SpdySession with a write pending, which prevents |
| 7241 | // SpdySession from attempting subsequent writes until this write completes. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 7242 | base::RunLoop().RunUntilIdle(); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7243 | |
| 7244 | // Now, start both new transactions |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7245 | TestCompletionCallback callback2; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 7246 | HttpNetworkTransaction trans2(MEDIUM, helper.session()); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7247 | rv = trans2.Start(&request_, callback2.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7248 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 7249 | base::RunLoop().RunUntilIdle(); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7250 | |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7251 | TestCompletionCallback callback3; |
bnc | 691fda6 | 2016-08-12 00:43:16 | [diff] [blame] | 7252 | HttpNetworkTransaction trans3(HIGHEST, helper.session()); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7253 | rv = trans3.Start(&request_, callback3.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7254 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 7255 | base::RunLoop().RunUntilIdle(); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7256 | |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 7257 | // We now have two HEADERS frames queued up which will be |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7258 | // dequeued only once the first write completes, which we |
| 7259 | // now allow to happen. |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7260 | ASSERT_TRUE(data.IsPaused()); |
| 7261 | data.Resume(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7262 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7263 | |
| 7264 | // And now we can allow everything else to run to completion. |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7265 | data.Resume(); |
| 7266 | base::RunLoop().RunUntilIdle(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7267 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
| 7268 | EXPECT_THAT(callback3.WaitForResult(), IsOk()); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7269 | |
| 7270 | helper.VerifyDataConsumed(); |
krasin | 0bfeb6b | 2017-01-13 21:48:04 | [diff] [blame] | 7271 | |
| 7272 | // At this point the test is completed and we need to safely destroy |
| 7273 | // all allocated structures. Helper stores a transaction that has a |
| 7274 | // reference to a stack allocated request, which has a short lifetime, |
| 7275 | // and is accessed during the transaction destruction. We need to delete |
| 7276 | // the transaction while the request is still a valid object. |
| 7277 | helper.ResetTrans(); |
[email protected] | e1f58efa | 2012-05-15 18:23:40 | [diff] [blame] | 7278 | } |
| 7279 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7280 | // Test that sent data frames and received WINDOW_UPDATE frames change |
| 7281 | // the send_window_size_ correctly. |
| 7282 | |
| 7283 | // WINDOW_UPDATE is different than most other frames in that it can arrive |
| 7284 | // while the client is still sending the request body. In order to enforce |
| 7285 | // this scenario, we feed a couple of dummy frames and give a delay of 0 to |
| 7286 | // socket data provider, so that initial read that is done as soon as the |
| 7287 | // stream is created, succeeds and schedules another read. This way reads |
| 7288 | // and writes are interleaved; after doing a full frame write, SpdyStream |
| 7289 | // will break out of DoLoop and will read and process a WINDOW_UPDATE. |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 7290 | // Once our WINDOW_UPDATE is read, we cannot send HEADERS right away |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7291 | // since request has not been completely written, therefore we feed |
| 7292 | // enough number of WINDOW_UPDATEs to finish the first read and cause a |
| 7293 | // write, leading to a complete write of request body; after that we send |
| 7294 | // a reply with a body, to cause a graceful shutdown. |
| 7295 | |
| 7296 | // TODO(agayev): develop a socket data provider where both, reads and |
| 7297 | // writes are ordered so that writing tests like these are easy and rewrite |
| 7298 | // all these tests using it. Right now we are working around the |
| 7299 | // limitations as described above and it's not deterministic, tests may |
| 7300 | // fail under specific circumstances. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7301 | TEST_F(SpdyNetworkTransactionTest, WindowUpdateReceived) { |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7302 | static int kFrameCount = 2; |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7303 | std::string content(kMaxSpdyFrameChunkSize, 'a'); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7304 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 7305 | kDefaultUrl, 1, kMaxSpdyFrameChunkSize * kFrameCount, LOWEST, nullptr, |
| 7306 | 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7307 | spdy::SpdySerializedFrame body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7308 | spdy_util_.ConstructSpdyDataFrame(1, content, false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7309 | spdy::SpdySerializedFrame body_end( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7310 | spdy_util_.ConstructSpdyDataFrame(1, content, true)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7311 | |
| 7312 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7313 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), |
| 7314 | CreateMockWrite(body_end, 2), |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7315 | }; |
| 7316 | |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 7317 | static const int32_t kDeltaWindowSize = 0xff; |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7318 | static const int kDeltaCount = 4; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7319 | spdy::SpdySerializedFrame window_update( |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7320 | spdy_util_.ConstructSpdyWindowUpdate(1, kDeltaWindowSize)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7321 | spdy::SpdySerializedFrame window_update_dummy( |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7322 | spdy_util_.ConstructSpdyWindowUpdate(2, kDeltaWindowSize)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7323 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7324 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7325 | CreateMockRead(window_update_dummy, 3), |
| 7326 | CreateMockRead(window_update_dummy, 4), |
| 7327 | CreateMockRead(window_update_dummy, 5), |
| 7328 | CreateMockRead(window_update, 6), // Four updates, therefore window |
| 7329 | CreateMockRead(window_update, 7), // size should increase by |
| 7330 | CreateMockRead(window_update, 8), // kDeltaWindowSize * 4 |
| 7331 | CreateMockRead(window_update, 9), |
| 7332 | CreateMockRead(resp, 10), |
| 7333 | MockRead(ASYNC, ERR_IO_PENDING, 11), |
| 7334 | CreateMockRead(body_end, 12), |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7335 | MockRead(ASYNC, 0, 13) // EOF |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7336 | }; |
| 7337 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7338 | SequencedSocketData data(reads, writes); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7339 | |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 7340 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7341 | for (int i = 0; i < kFrameCount; ++i) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 7342 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7343 | content.data(), content.size())); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7344 | } |
olli.raula | 6df48b2a | 2015-11-26 07:40:22 | [diff] [blame] | 7345 | ElementsUploadDataStream upload_data_stream(std::move(element_readers), 0); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7346 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7347 | // Setup the request. |
| 7348 | request_.method = "POST"; |
| 7349 | request_.upload_data_stream = &upload_data_stream; |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7350 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7351 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7352 | helper.AddData(&data); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7353 | helper.RunPreTestSetup(); |
| 7354 | |
| 7355 | HttpNetworkTransaction* trans = helper.trans(); |
| 7356 | |
| 7357 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7358 | int rv = trans->Start(&request_, callback.callback(), log_); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7359 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7360 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7361 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7362 | data.RunUntilPaused(); |
| 7363 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7364 | |
| 7365 | SpdyHttpStream* stream = static_cast<SpdyHttpStream*>(trans->stream_.get()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 7366 | ASSERT_TRUE(stream); |
| 7367 | ASSERT_TRUE(stream->stream()); |
bnc | bca843ba | 2016-07-14 13:05:48 | [diff] [blame] | 7368 | EXPECT_EQ(static_cast<int>(kDefaultInitialWindowSize) + |
| 7369 | kDeltaWindowSize * kDeltaCount - |
| 7370 | kMaxSpdyFrameChunkSize * kFrameCount, |
| 7371 | stream->stream()->send_window_size()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7372 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7373 | data.Resume(); |
| 7374 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7375 | |
| 7376 | rv = callback.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7377 | EXPECT_THAT(rv, IsOk()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7378 | |
| 7379 | helper.VerifyDataConsumed(); |
| 7380 | } |
| 7381 | |
| 7382 | // Test that received data frames and sent WINDOW_UPDATE frames change |
| 7383 | // the recv_window_size_ correctly. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7384 | TEST_F(SpdyNetworkTransactionTest, WindowUpdateSent) { |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 7385 | // Session level maximum window size that is more than twice the default |
| 7386 | // initial window size so that an initial window update is sent. |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 7387 | const int32_t session_max_recv_window_size = 5 * 64 * 1024; |
bnc | bca843ba | 2016-07-14 13:05:48 | [diff] [blame] | 7388 | ASSERT_LT(2 * kDefaultInitialWindowSize, session_max_recv_window_size); |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 7389 | // Stream level maximum window size that is less than the session level |
| 7390 | // maximum window size so that we test for confusion between the two. |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 7391 | const int32_t stream_max_recv_window_size = 4 * 64 * 1024; |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 7392 | ASSERT_GT(session_max_recv_window_size, stream_max_recv_window_size); |
| 7393 | // Size of body to be sent. Has to be less than or equal to both window sizes |
| 7394 | // so that we do not run out of receiving window. Also has to be greater than |
| 7395 | // half of them so that it triggers both a session level and a stream level |
| 7396 | // window update frame. |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 7397 | const int32_t kTargetSize = 3 * 64 * 1024; |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 7398 | ASSERT_GE(session_max_recv_window_size, kTargetSize); |
| 7399 | ASSERT_GE(stream_max_recv_window_size, kTargetSize); |
| 7400 | ASSERT_LT(session_max_recv_window_size / 2, kTargetSize); |
| 7401 | ASSERT_LT(stream_max_recv_window_size / 2, kTargetSize); |
| 7402 | // Size of each DATA frame. |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 7403 | const int32_t kChunkSize = 4096; |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 7404 | // Size of window updates. |
| 7405 | ASSERT_EQ(0, session_max_recv_window_size / 2 % kChunkSize); |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 7406 | const int32_t session_window_update_delta = |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 7407 | session_max_recv_window_size / 2 + kChunkSize; |
| 7408 | ASSERT_EQ(0, stream_max_recv_window_size / 2 % kChunkSize); |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 7409 | const int32_t stream_window_update_delta = |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 7410 | stream_max_recv_window_size / 2 + kChunkSize; |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7411 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7412 | spdy::SpdySerializedFrame preface( |
| 7413 | const_cast<char*>(spdy::kHttp2ConnectionHeaderPrefix), |
| 7414 | spdy::kHttp2ConnectionHeaderPrefixSize, |
| 7415 | /* owns_buffer = */ false); |
bnc | 8abf64af | 2017-06-07 20:18:54 | [diff] [blame] | 7416 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7417 | spdy::SettingsMap initial_settings; |
| 7418 | initial_settings[spdy::SETTINGS_HEADER_TABLE_SIZE] = kSpdyMaxHeaderTableSize; |
| 7419 | initial_settings[spdy::SETTINGS_MAX_CONCURRENT_STREAMS] = |
bnc | 3171a243 | 2016-12-28 18:40:26 | [diff] [blame] | 7420 | kSpdyMaxConcurrentPushedStreams; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7421 | initial_settings[spdy::SETTINGS_INITIAL_WINDOW_SIZE] = |
| 7422 | stream_max_recv_window_size; |
Bence Béky | 6cee52f | 2019-10-24 16:52:33 | [diff] [blame] | 7423 | initial_settings[spdy::SETTINGS_MAX_HEADER_LIST_SIZE] = |
| 7424 | kSpdyMaxHeaderListSize; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7425 | spdy::SpdySerializedFrame initial_settings_frame( |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 7426 | spdy_util_.ConstructSpdySettings(initial_settings)); |
bnc | 8abf64af | 2017-06-07 20:18:54 | [diff] [blame] | 7427 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7428 | spdy::SpdySerializedFrame initial_window_update( |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 7429 | spdy_util_.ConstructSpdyWindowUpdate( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7430 | spdy::kSessionFlowControlStreamId, |
bnc | bca843ba | 2016-07-14 13:05:48 | [diff] [blame] | 7431 | session_max_recv_window_size - kDefaultInitialWindowSize)); |
bnc | 8abf64af | 2017-06-07 20:18:54 | [diff] [blame] | 7432 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7433 | spdy::SpdySerializedFrame combined_frames = CombineFrames( |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 7434 | {&preface, &initial_settings_frame, &initial_window_update}); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7435 | |
| 7436 | std::vector<MockWrite> writes; |
bnc | ef26b60 | 2017-06-12 22:08:19 | [diff] [blame] | 7437 | writes.push_back(CreateMockWrite(combined_frames)); |
bnc | 8abf64af | 2017-06-07 20:18:54 | [diff] [blame] | 7438 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7439 | spdy::SpdySerializedFrame req( |
| 7440 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7441 | writes.push_back(CreateMockWrite(req, writes.size())); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7442 | |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 7443 | std::vector<MockRead> reads; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7444 | spdy::SpdySerializedFrame resp( |
| 7445 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7446 | reads.push_back(CreateMockRead(resp, writes.size() + reads.size())); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7447 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7448 | std::vector<spdy::SpdySerializedFrame> body_frames; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7449 | const std::string body_data(kChunkSize, 'x'); |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 7450 | for (size_t remaining = kTargetSize; remaining != 0;) { |
| 7451 | size_t frame_size = std::min(remaining, body_data.size()); |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7452 | body_frames.push_back(spdy_util_.ConstructSpdyDataFrame( |
| 7453 | 1, base::StringPiece(body_data.data(), frame_size), false)); |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 7454 | reads.push_back( |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7455 | CreateMockRead(body_frames.back(), writes.size() + reads.size())); |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 7456 | remaining -= frame_size; |
| 7457 | } |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 7458 | // Yield. |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 7459 | reads.push_back( |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 7460 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, writes.size() + reads.size())); |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 7461 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7462 | spdy::SpdySerializedFrame session_window_update( |
bnc | 8abf64af | 2017-06-07 20:18:54 | [diff] [blame] | 7463 | spdy_util_.ConstructSpdyWindowUpdate(0, session_window_update_delta)); |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 7464 | writes.push_back( |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7465 | CreateMockWrite(session_window_update, writes.size() + reads.size())); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7466 | spdy::SpdySerializedFrame stream_window_update( |
bnc | 8abf64af | 2017-06-07 20:18:54 | [diff] [blame] | 7467 | spdy_util_.ConstructSpdyWindowUpdate(1, stream_window_update_delta)); |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 7468 | writes.push_back( |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7469 | CreateMockWrite(stream_window_update, writes.size() + reads.size())); |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 7470 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7471 | SequencedSocketData data(reads, writes); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7472 | |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 7473 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
bnc | 903e8c1 | 2016-12-09 20:50:05 | [diff] [blame] | 7474 | session_deps->session_max_recv_window_size = session_max_recv_window_size; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7475 | session_deps->http2_settings[spdy::SETTINGS_INITIAL_WINDOW_SIZE] = |
bnc | 3171a243 | 2016-12-28 18:40:26 | [diff] [blame] | 7476 | stream_max_recv_window_size; |
bnc | 903e8c1 | 2016-12-09 20:50:05 | [diff] [blame] | 7477 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7478 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
bnc | 903e8c1 | 2016-12-09 20:50:05 | [diff] [blame] | 7479 | std::move(session_deps)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7480 | helper.AddData(&data); |
| 7481 | helper.RunPreTestSetup(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7482 | |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 7483 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 7484 | SpdySessionPoolPeer pool_peer(spdy_session_pool); |
| 7485 | pool_peer.SetEnableSendingInitialData(true); |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 7486 | |
| 7487 | HttpNetworkTransaction* trans = helper.trans(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7488 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7489 | int rv = trans->Start(&request_, callback.callback(), log_); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7490 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7491 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7492 | rv = callback.WaitForResult(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7493 | EXPECT_THAT(rv, IsOk()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7494 | |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 7495 | // Finish async network reads. |
| 7496 | base::RunLoop().RunUntilIdle(); |
| 7497 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7498 | SpdyHttpStream* stream = |
| 7499 | static_cast<SpdyHttpStream*>(trans->stream_.get()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 7500 | ASSERT_TRUE(stream); |
| 7501 | ASSERT_TRUE(stream->stream()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7502 | |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 7503 | // All data has been read, but not consumed. The window reflects this. |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 7504 | EXPECT_EQ(static_cast<int>(stream_max_recv_window_size - kTargetSize), |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 7505 | stream->stream()->recv_window_size()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7506 | |
| 7507 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 7508 | ASSERT_TRUE(response); |
| 7509 | ASSERT_TRUE(response->headers); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 7510 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7511 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 7512 | |
| 7513 | // Issue a read which will cause a WINDOW_UPDATE to be sent and window |
| 7514 | // size increased to default. |
Victor Costan | 9c7302b | 2018-08-27 16:39:44 | [diff] [blame] | 7515 | scoped_refptr<IOBuffer> buf = base::MakeRefCounted<IOBuffer>(kTargetSize); |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 7516 | EXPECT_EQ(static_cast<int>(kTargetSize), |
Bence Béky | bdbb0e7 | 2018-08-07 21:42:59 | [diff] [blame] | 7517 | trans->Read(buf.get(), kTargetSize, CompletionOnceCallback())); |
bnc | 8f0f3b6 | 2015-04-08 04:37:23 | [diff] [blame] | 7518 | EXPECT_EQ(static_cast<int>(stream_max_recv_window_size), |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 7519 | stream->stream()->recv_window_size()); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7520 | EXPECT_THAT(base::StringPiece(buf->data(), kTargetSize), Each(Eq('x'))); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7521 | |
[email protected] | 251029e | 2014-03-19 06:04:40 | [diff] [blame] | 7522 | // Allow scheduled WINDOW_UPDATE frames to write. |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 7523 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7524 | helper.VerifyDataConsumed(); |
| 7525 | } |
| 7526 | |
| 7527 | // Test that WINDOW_UPDATE frame causing overflow is handled correctly. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7528 | TEST_F(SpdyNetworkTransactionTest, WindowUpdateOverflow) { |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7529 | // Number of full frames we hope to write (but will not, used to |
| 7530 | // set content-length header correctly) |
| 7531 | static int kFrameCount = 3; |
| 7532 | |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7533 | std::string content(kMaxSpdyFrameChunkSize, 'a'); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7534 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 7535 | kDefaultUrl, 1, kMaxSpdyFrameChunkSize * kFrameCount, LOWEST, nullptr, |
| 7536 | 0)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7537 | spdy::SpdySerializedFrame body( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7538 | spdy_util_.ConstructSpdyDataFrame(1, content, false)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7539 | spdy::SpdySerializedFrame rst(spdy_util_.ConstructSpdyRstStream( |
| 7540 | 1, spdy::ERROR_CODE_FLOW_CONTROL_ERROR)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7541 | |
| 7542 | // We're not going to write a data frame with FIN, we'll receive a bad |
| 7543 | // WINDOW_UPDATE while sending a request and will send a RST_STREAM frame. |
| 7544 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7545 | CreateMockWrite(req, 0), CreateMockWrite(body, 2), |
| 7546 | CreateMockWrite(rst, 3), |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7547 | }; |
| 7548 | |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 7549 | static const int32_t kDeltaWindowSize = 0x7fffffff; // cause an overflow |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7550 | spdy::SpdySerializedFrame window_update( |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7551 | spdy_util_.ConstructSpdyWindowUpdate(1, kDeltaWindowSize)); |
| 7552 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7553 | CreateMockRead(window_update, 1), MockRead(ASYNC, 0, 4) // EOF |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7554 | }; |
| 7555 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7556 | SequencedSocketData data(reads, writes); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7557 | |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 7558 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7559 | for (int i = 0; i < kFrameCount; ++i) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 7560 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7561 | content.data(), content.size())); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7562 | } |
olli.raula | 6df48b2a | 2015-11-26 07:40:22 | [diff] [blame] | 7563 | ElementsUploadDataStream upload_data_stream(std::move(element_readers), 0); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7564 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7565 | // Setup the request. |
| 7566 | request_.method = "POST"; |
| 7567 | request_.upload_data_stream = &upload_data_stream; |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7568 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7569 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7570 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7571 | helper.AddData(&data); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7572 | HttpNetworkTransaction* trans = helper.trans(); |
| 7573 | |
| 7574 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7575 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7576 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7577 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7578 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7579 | ASSERT_TRUE(callback.have_result()); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 7580 | EXPECT_THAT(callback.WaitForResult(), IsError(ERR_HTTP2_FLOW_CONTROL_ERROR)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7581 | helper.VerifyDataConsumed(); |
| 7582 | } |
| 7583 | |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 7584 | // Regression test for https://crbug.com/732019. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7585 | // RFC7540 Section 6.9.2: A spdy::SETTINGS_INITIAL_WINDOW_SIZE change that |
| 7586 | // causes any stream flow control window to overflow MUST be treated as a |
| 7587 | // connection error. |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 7588 | TEST_F(SpdyNetworkTransactionTest, InitialWindowSizeOverflow) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7589 | spdy::SpdySerializedFrame window_update( |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 7590 | spdy_util_.ConstructSpdyWindowUpdate(1, 0x60000000)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7591 | spdy::SettingsMap settings; |
| 7592 | settings[spdy::SETTINGS_INITIAL_WINDOW_SIZE] = 0x60000000; |
| 7593 | spdy::SpdySerializedFrame settings_frame( |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 7594 | spdy_util_.ConstructSpdySettings(settings)); |
| 7595 | MockRead reads[] = {CreateMockRead(window_update, 1), |
| 7596 | CreateMockRead(settings_frame, 2)}; |
| 7597 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7598 | spdy::SpdySerializedFrame req( |
| 7599 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 7600 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
| 7601 | spdy::SpdySerializedFrame goaway( |
| 7602 | spdy_util_.ConstructSpdyGoAway(0, spdy::ERROR_CODE_FLOW_CONTROL_ERROR, |
| 7603 | "New spdy::SETTINGS_INITIAL_WINDOW_SIZE " |
| 7604 | "value overflows flow control window of " |
| 7605 | "stream 1.")); |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 7606 | MockWrite writes[] = {CreateMockWrite(req, 0), |
| 7607 | CreateMockWrite(settings_ack, 3), |
| 7608 | CreateMockWrite(goaway, 4)}; |
| 7609 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7610 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7611 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 7612 | helper.RunToCompletion(&data); |
| 7613 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 7614 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_FLOW_CONTROL_ERROR)); |
Bence Béky | 05dcb038 | 2017-09-15 20:07:58 | [diff] [blame] | 7615 | } |
| 7616 | |
David Schinazi | 410676a | 2019-08-13 22:31:05 | [diff] [blame] | 7617 | // Tests that we close the connection if we try to enqueue more frames than |
| 7618 | // the cap allows. |
| 7619 | TEST_F(SpdyNetworkTransactionTest, SessionMaxQueuedCappedFramesExceeded) { |
| 7620 | const int kTestSessionMaxQueuedCappedFrames = 5; |
| 7621 | const int kTestNumPings = kTestSessionMaxQueuedCappedFrames + 1; |
| 7622 | spdy::SettingsMap settings; |
| 7623 | settings[spdy::SETTINGS_INITIAL_WINDOW_SIZE] = 0xffff; |
| 7624 | spdy::SpdySerializedFrame settings_frame( |
| 7625 | spdy_util_.ConstructSpdySettings(settings)); |
| 7626 | std::vector<spdy::SpdySerializedFrame> ping_frames; |
| 7627 | |
| 7628 | spdy::SpdySerializedFrame req( |
| 7629 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 7630 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
| 7631 | |
| 7632 | std::vector<MockWrite> writes; |
| 7633 | std::vector<MockRead> reads; |
| 7634 | // Send request, receive SETTINGS and send a SETTINGS ACK. |
| 7635 | writes.push_back(CreateMockWrite(req, writes.size() + reads.size())); |
| 7636 | reads.push_back(CreateMockRead(settings_frame, writes.size() + reads.size())); |
| 7637 | writes.push_back(CreateMockWrite(settings_ack, writes.size() + reads.size())); |
| 7638 | // Receive more pings than our limit allows. |
| 7639 | for (int i = 1; i <= kTestNumPings; ++i) { |
| 7640 | ping_frames.push_back( |
| 7641 | spdy_util_.ConstructSpdyPing(/*ping_id=*/i, /*is_ack=*/false)); |
| 7642 | reads.push_back( |
| 7643 | CreateMockRead(ping_frames.back(), writes.size() + reads.size())); |
| 7644 | } |
| 7645 | // Only write PING ACKs after receiving all of them to ensure they are all in |
| 7646 | // the write queue. |
| 7647 | for (int i = 1; i <= kTestNumPings; ++i) { |
| 7648 | ping_frames.push_back( |
| 7649 | spdy_util_.ConstructSpdyPing(/*ping_id=*/i, /*is_ack=*/true)); |
| 7650 | writes.push_back( |
| 7651 | CreateMockWrite(ping_frames.back(), writes.size() + reads.size())); |
| 7652 | } |
| 7653 | // Stop reading. |
| 7654 | reads.push_back(MockRead(ASYNC, 0, writes.size() + reads.size())); |
| 7655 | |
| 7656 | SequencedSocketData data(reads, writes); |
| 7657 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 7658 | session_deps->session_max_queued_capped_frames = |
| 7659 | kTestSessionMaxQueuedCappedFrames; |
| 7660 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 7661 | std::move(session_deps)); |
| 7662 | helper.RunToCompletion(&data); |
| 7663 | TransactionHelperResult out = helper.output(); |
| 7664 | EXPECT_THAT(out.rv, IsError(ERR_CONNECTION_CLOSED)); |
| 7665 | } |
| 7666 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7667 | // Test that after hitting a send window size of 0, the write process |
| 7668 | // stalls and upon receiving WINDOW_UPDATE frame write resumes. |
| 7669 | |
| 7670 | // This test constructs a POST request followed by enough data frames |
| 7671 | // containing 'a' that would make the window size 0, followed by another |
| 7672 | // data frame containing default content (which is "hello!") and this frame |
rch | acdcbdc | 2015-05-16 17:16:00 | [diff] [blame] | 7673 | // also contains a FIN flag. SequencedSocketData is used to enforce all |
| 7674 | // writes, save the last, go through before a read could happen. The last frame |
| 7675 | // ("hello!") is not permitted to go through since by the time its turn |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7676 | // arrives, window size is 0. At this point MessageLoop::Run() called via |
| 7677 | // callback would block. Therefore we call MessageLoop::RunUntilIdle() |
| 7678 | // which returns after performing all possible writes. We use DCHECKS to |
| 7679 | // ensure that last data frame is still there and stream has stalled. |
| 7680 | // After that, next read is artifically enforced, which causes a |
| 7681 | // WINDOW_UPDATE to be read and I/O process resumes. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7682 | TEST_F(SpdyNetworkTransactionTest, FlowControlStallResume) { |
bnc | bca843ba | 2016-07-14 13:05:48 | [diff] [blame] | 7683 | const int32_t initial_window_size = kDefaultInitialWindowSize; |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7684 | // Number of upload data buffers we need to send to zero out the window size |
| 7685 | // is the minimal number of upload buffers takes to be bigger than |
| 7686 | // |initial_window_size|. |
| 7687 | size_t num_upload_buffers = |
| 7688 | ceil(static_cast<double>(initial_window_size) / kBufferSize); |
| 7689 | // Each upload data buffer consists of |num_frames_in_one_upload_buffer| |
| 7690 | // frames, each with |kMaxSpdyFrameChunkSize| bytes except the last frame, |
| 7691 | // which has kBufferSize % kMaxSpdyChunkSize bytes. |
| 7692 | size_t num_frames_in_one_upload_buffer = |
| 7693 | ceil(static_cast<double>(kBufferSize) / kMaxSpdyFrameChunkSize); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7694 | |
| 7695 | // Construct content for a data frame of maximum size. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7696 | std::string content(kMaxSpdyFrameChunkSize, 'a'); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7697 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7698 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 7699 | kDefaultUrl, 1, |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7700 | /*content_length=*/kBufferSize * num_upload_buffers + kUploadDataSize, |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 7701 | LOWEST, nullptr, 0)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7702 | |
| 7703 | // Full frames. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7704 | spdy::SpdySerializedFrame body1( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7705 | spdy_util_.ConstructSpdyDataFrame(1, content, false)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7706 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7707 | // Last frame in each upload data buffer. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7708 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7709 | 1, |
| 7710 | base::StringPiece(content.data(), kBufferSize % kMaxSpdyFrameChunkSize), |
| 7711 | false)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7712 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7713 | // The very last frame before the stalled frames. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7714 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7715 | 1, |
| 7716 | base::StringPiece(content.data(), initial_window_size % kBufferSize % |
| 7717 | kMaxSpdyFrameChunkSize), |
| 7718 | false)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7719 | |
| 7720 | // Data frames to be sent once WINDOW_UPDATE frame is received. |
| 7721 | |
| 7722 | // If kBufferSize * num_upload_buffers > initial_window_size, |
| 7723 | // we need one additional frame to send the rest of 'a'. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7724 | std::string last_body(kBufferSize * num_upload_buffers - initial_window_size, |
| 7725 | 'a'); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7726 | spdy::SpdySerializedFrame body4( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7727 | spdy_util_.ConstructSpdyDataFrame(1, last_body, false)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7728 | |
| 7729 | // Also send a "hello!" after WINDOW_UPDATE. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7730 | spdy::SpdySerializedFrame body5(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7731 | |
| 7732 | // Fill in mock writes. |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7733 | size_t i = 0; |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7734 | std::vector<MockWrite> writes; |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7735 | writes.push_back(CreateMockWrite(req, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7736 | for (size_t j = 0; j < num_upload_buffers; j++) { |
| 7737 | for (size_t k = 0; k < num_frames_in_one_upload_buffer; k++) { |
Brandon Maslen | 6d59d91 | 2020-11-24 23:43:31 | [diff] [blame] | 7738 | if (j == num_upload_buffers - 1 && |
| 7739 | (initial_window_size % kBufferSize != 0)) { |
| 7740 | writes.push_back(CreateMockWrite(body3, i++)); |
| 7741 | } else if (k == num_frames_in_one_upload_buffer - 1 && |
| 7742 | kBufferSize % kMaxSpdyFrameChunkSize != 0) { |
| 7743 | writes.push_back(CreateMockWrite(body2, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7744 | } else { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7745 | writes.push_back(CreateMockWrite(body1, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7746 | } |
| 7747 | } |
| 7748 | } |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7749 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7750 | // Fill in mock reads. |
| 7751 | std::vector<MockRead> reads; |
| 7752 | // Force a pause. |
| 7753 | reads.push_back(MockRead(ASYNC, ERR_IO_PENDING, i++)); |
| 7754 | // Construct read frame for window updates that gives enough space to upload |
| 7755 | // the rest of the data. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7756 | spdy::SpdySerializedFrame session_window_update( |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7757 | spdy_util_.ConstructSpdyWindowUpdate(0, |
| 7758 | kUploadDataSize + last_body.size())); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7759 | spdy::SpdySerializedFrame window_update(spdy_util_.ConstructSpdyWindowUpdate( |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7760 | 1, kUploadDataSize + last_body.size())); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7761 | |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7762 | reads.push_back(CreateMockRead(session_window_update, i++)); |
| 7763 | reads.push_back(CreateMockRead(window_update, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7764 | |
| 7765 | // Stalled frames which can be sent after receiving window updates. |
| 7766 | if (last_body.size() > 0) |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7767 | writes.push_back(CreateMockWrite(body4, i++)); |
| 7768 | writes.push_back(CreateMockWrite(body5, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7769 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7770 | spdy::SpdySerializedFrame reply( |
| 7771 | spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7772 | reads.push_back(CreateMockRead(reply, i++)); |
| 7773 | reads.push_back(CreateMockRead(body2, i++)); |
| 7774 | reads.push_back(CreateMockRead(body5, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7775 | reads.push_back(MockRead(ASYNC, 0, i++)); // EOF |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7776 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7777 | SequencedSocketData data(reads, writes); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7778 | |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 7779 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7780 | std::string upload_data_string(kBufferSize * num_upload_buffers, 'a'); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7781 | upload_data_string.append(kUploadData, kUploadDataSize); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 7782 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 7783 | upload_data_string.c_str(), upload_data_string.size())); |
olli.raula | 6df48b2a | 2015-11-26 07:40:22 | [diff] [blame] | 7784 | ElementsUploadDataStream upload_data_stream(std::move(element_readers), 0); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7785 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7786 | request_.method = "POST"; |
| 7787 | request_.upload_data_stream = &upload_data_stream; |
| 7788 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 7789 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7790 | helper.AddData(&data); |
| 7791 | helper.RunPreTestSetup(); |
| 7792 | |
| 7793 | HttpNetworkTransaction* trans = helper.trans(); |
| 7794 | |
| 7795 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7796 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7797 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7798 | |
[email protected] | fc9d8847 | 2013-08-14 02:31:17 | [diff] [blame] | 7799 | base::RunLoop().RunUntilIdle(); // Write as much as we can. |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7800 | |
| 7801 | SpdyHttpStream* stream = static_cast<SpdyHttpStream*>(trans->stream_.get()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 7802 | ASSERT_TRUE(stream); |
| 7803 | ASSERT_TRUE(stream->stream()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7804 | EXPECT_EQ(0, stream->stream()->send_window_size()); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7805 | if (initial_window_size % kBufferSize != 0) { |
| 7806 | // If it does not take whole number of full upload buffer to zero out |
| 7807 | // initial window size, then the upload data is not at EOF, because the |
| 7808 | // last read must be stalled. |
| 7809 | EXPECT_FALSE(upload_data_stream.IsEOF()); |
| 7810 | } else { |
| 7811 | // All the body data should have been read. |
| 7812 | // TODO(satorux): This is because of the weirdness in reading the request |
| 7813 | // body in OnSendBodyComplete(). See crbug.com/113107. |
| 7814 | EXPECT_TRUE(upload_data_stream.IsEOF()); |
| 7815 | } |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7816 | // But the body is not yet fully sent (kUploadData is not yet sent) |
| 7817 | // since we're send-stalled. |
| 7818 | EXPECT_TRUE(stream->stream()->send_stalled_by_flow_control()); |
| 7819 | |
mmenke | e2401192 | 2015-12-17 22:12:59 | [diff] [blame] | 7820 | data.Resume(); // Read in WINDOW_UPDATE frame. |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7821 | rv = callback.WaitForResult(); |
bnc | eb9aa711 | 2017-01-05 01:03:46 | [diff] [blame] | 7822 | EXPECT_THAT(rv, IsOk()); |
| 7823 | |
| 7824 | // Finish async network reads. |
| 7825 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7826 | helper.VerifyDataConsumed(); |
| 7827 | } |
| 7828 | |
| 7829 | // Test we correctly handle the case where the SETTINGS frame results in |
| 7830 | // unstalling the send window. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7831 | TEST_F(SpdyNetworkTransactionTest, FlowControlStallResumeAfterSettings) { |
bnc | bca843ba | 2016-07-14 13:05:48 | [diff] [blame] | 7832 | const int32_t initial_window_size = kDefaultInitialWindowSize; |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7833 | // Number of upload data buffers we need to send to zero out the window size |
| 7834 | // is the minimal number of upload buffers takes to be bigger than |
| 7835 | // |initial_window_size|. |
| 7836 | size_t num_upload_buffers = |
| 7837 | ceil(static_cast<double>(initial_window_size) / kBufferSize); |
| 7838 | // Each upload data buffer consists of |num_frames_in_one_upload_buffer| |
| 7839 | // frames, each with |kMaxSpdyFrameChunkSize| bytes except the last frame, |
| 7840 | // which has kBufferSize % kMaxSpdyChunkSize bytes. |
| 7841 | size_t num_frames_in_one_upload_buffer = |
| 7842 | ceil(static_cast<double>(kBufferSize) / kMaxSpdyFrameChunkSize); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7843 | |
| 7844 | // Construct content for a data frame of maximum size. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7845 | std::string content(kMaxSpdyFrameChunkSize, 'a'); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7846 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7847 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 7848 | kDefaultUrl, 1, |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7849 | /*content_length=*/kBufferSize * num_upload_buffers + kUploadDataSize, |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 7850 | LOWEST, nullptr, 0)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7851 | |
| 7852 | // Full frames. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7853 | spdy::SpdySerializedFrame body1( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7854 | spdy_util_.ConstructSpdyDataFrame(1, content, false)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7855 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7856 | // Last frame in each upload data buffer. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7857 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7858 | 1, |
| 7859 | base::StringPiece(content.data(), kBufferSize % kMaxSpdyFrameChunkSize), |
| 7860 | false)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7861 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7862 | // The very last frame before the stalled frames. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7863 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7864 | 1, |
| 7865 | base::StringPiece(content.data(), initial_window_size % kBufferSize % |
| 7866 | kMaxSpdyFrameChunkSize), |
| 7867 | false)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7868 | |
| 7869 | // Data frames to be sent once WINDOW_UPDATE frame is received. |
| 7870 | |
| 7871 | // If kBufferSize * num_upload_buffers > initial_window_size, |
| 7872 | // we need one additional frame to send the rest of 'a'. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7873 | std::string last_body(kBufferSize * num_upload_buffers - initial_window_size, |
| 7874 | 'a'); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7875 | spdy::SpdySerializedFrame body4( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 7876 | spdy_util_.ConstructSpdyDataFrame(1, last_body, false)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7877 | |
| 7878 | // Also send a "hello!" after WINDOW_UPDATE. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7879 | spdy::SpdySerializedFrame body5(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7880 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7881 | // Fill in mock writes. |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7882 | size_t i = 0; |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7883 | std::vector<MockWrite> writes; |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7884 | writes.push_back(CreateMockWrite(req, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7885 | for (size_t j = 0; j < num_upload_buffers; j++) { |
| 7886 | for (size_t k = 0; k < num_frames_in_one_upload_buffer; k++) { |
Brandon Maslen | 6d59d91 | 2020-11-24 23:43:31 | [diff] [blame] | 7887 | if (j == num_upload_buffers - 1 && |
| 7888 | (initial_window_size % kBufferSize != 0)) { |
| 7889 | writes.push_back(CreateMockWrite(body3, i++)); |
| 7890 | } else if (k == num_frames_in_one_upload_buffer - 1 && |
| 7891 | kBufferSize % kMaxSpdyFrameChunkSize != 0) { |
| 7892 | writes.push_back(CreateMockWrite(body2, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7893 | } else { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7894 | writes.push_back(CreateMockWrite(body1, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7895 | } |
| 7896 | } |
| 7897 | } |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7898 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7899 | // Fill in mock reads. |
| 7900 | std::vector<MockRead> reads; |
| 7901 | // Force a pause. |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7902 | reads.push_back(MockRead(ASYNC, ERR_IO_PENDING, i++)); |
| 7903 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7904 | // Construct read frame for SETTINGS that gives enough space to upload the |
| 7905 | // rest of the data. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7906 | spdy::SettingsMap settings; |
| 7907 | settings[spdy::SETTINGS_INITIAL_WINDOW_SIZE] = initial_window_size * 2; |
| 7908 | spdy::SpdySerializedFrame settings_frame_large( |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7909 | spdy_util_.ConstructSpdySettings(settings)); |
| 7910 | |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7911 | reads.push_back(CreateMockRead(settings_frame_large, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7912 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7913 | spdy::SpdySerializedFrame session_window_update( |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7914 | spdy_util_.ConstructSpdyWindowUpdate(0, |
| 7915 | last_body.size() + kUploadDataSize)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7916 | reads.push_back(CreateMockRead(session_window_update, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7917 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7918 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7919 | writes.push_back(CreateMockWrite(settings_ack, i++)); |
[email protected] | d4a77c1 | 2014-05-15 20:45:21 | [diff] [blame] | 7920 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7921 | // Stalled frames which can be sent after |settings_ack|. |
| 7922 | if (last_body.size() > 0) |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7923 | writes.push_back(CreateMockWrite(body4, i++)); |
| 7924 | writes.push_back(CreateMockWrite(body5, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7925 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 7926 | spdy::SpdySerializedFrame reply( |
| 7927 | spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 7928 | reads.push_back(CreateMockRead(reply, i++)); |
| 7929 | reads.push_back(CreateMockRead(body2, i++)); |
| 7930 | reads.push_back(CreateMockRead(body5, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7931 | reads.push_back(MockRead(ASYNC, 0, i++)); // EOF |
| 7932 | |
| 7933 | // Force all writes to happen before any read, last write will not |
| 7934 | // actually queue a frame, due to window size being 0. |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 7935 | SequencedSocketData data(reads, writes); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7936 | |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 7937 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 7938 | std::string upload_data_string(kBufferSize * num_upload_buffers, 'a'); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7939 | upload_data_string.append(kUploadData, kUploadDataSize); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 7940 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 7941 | upload_data_string.c_str(), upload_data_string.size())); |
olli.raula | 6df48b2a | 2015-11-26 07:40:22 | [diff] [blame] | 7942 | ElementsUploadDataStream upload_data_stream(std::move(element_readers), 0); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7943 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7944 | request_.method = "POST"; |
| 7945 | request_.upload_data_stream = &upload_data_stream; |
| 7946 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 7947 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7948 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7949 | helper.AddData(&data); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7950 | |
| 7951 | HttpNetworkTransaction* trans = helper.trans(); |
| 7952 | |
| 7953 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 7954 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 7955 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7956 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7957 | data.RunUntilPaused(); // Write as much as we can. |
| 7958 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7959 | |
| 7960 | SpdyHttpStream* stream = static_cast<SpdyHttpStream*>(trans->stream_.get()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 7961 | ASSERT_TRUE(stream); |
| 7962 | ASSERT_TRUE(stream->stream()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7963 | EXPECT_EQ(0, stream->stream()->send_window_size()); |
| 7964 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7965 | if (initial_window_size % kBufferSize != 0) { |
| 7966 | // If it does not take whole number of full upload buffer to zero out |
| 7967 | // initial window size, then the upload data is not at EOF, because the |
| 7968 | // last read must be stalled. |
| 7969 | EXPECT_FALSE(upload_data_stream.IsEOF()); |
| 7970 | } else { |
| 7971 | // All the body data should have been read. |
| 7972 | // TODO(satorux): This is because of the weirdness in reading the request |
| 7973 | // body in OnSendBodyComplete(). See crbug.com/113107. |
| 7974 | EXPECT_TRUE(upload_data_stream.IsEOF()); |
| 7975 | } |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7976 | // But the body is not yet fully sent (kUploadData is not yet sent) |
| 7977 | // since we're send-stalled. |
| 7978 | EXPECT_TRUE(stream->stream()->send_stalled_by_flow_control()); |
| 7979 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 7980 | // Read in SETTINGS frame to unstall. |
| 7981 | data.Resume(); |
| 7982 | base::RunLoop().RunUntilIdle(); |
| 7983 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7984 | rv = callback.WaitForResult(); |
| 7985 | helper.VerifyDataConsumed(); |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 7986 | // If stream is nullptr, that means it was unstalled and closed. |
| 7987 | EXPECT_TRUE(stream->stream() == nullptr); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 7988 | } |
| 7989 | |
| 7990 | // Test we correctly handle the case where the SETTINGS frame results in a |
| 7991 | // negative send window size. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 7992 | TEST_F(SpdyNetworkTransactionTest, FlowControlNegativeSendWindowSize) { |
bnc | bca843ba | 2016-07-14 13:05:48 | [diff] [blame] | 7993 | const int32_t initial_window_size = kDefaultInitialWindowSize; |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 7994 | // Number of upload data buffers we need to send to zero out the window size |
| 7995 | // is the minimal number of upload buffers takes to be bigger than |
| 7996 | // |initial_window_size|. |
| 7997 | size_t num_upload_buffers = |
| 7998 | ceil(static_cast<double>(initial_window_size) / kBufferSize); |
| 7999 | // Each upload data buffer consists of |num_frames_in_one_upload_buffer| |
| 8000 | // frames, each with |kMaxSpdyFrameChunkSize| bytes except the last frame, |
| 8001 | // which has kBufferSize % kMaxSpdyChunkSize bytes. |
| 8002 | size_t num_frames_in_one_upload_buffer = |
| 8003 | ceil(static_cast<double>(kBufferSize) / kMaxSpdyFrameChunkSize); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8004 | |
| 8005 | // Construct content for a data frame of maximum size. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 8006 | std::string content(kMaxSpdyFrameChunkSize, 'a'); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8007 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8008 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
bnc | b2602438 | 2016-06-29 02:39:45 | [diff] [blame] | 8009 | kDefaultUrl, 1, |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 8010 | /*content_length=*/kBufferSize * num_upload_buffers + kUploadDataSize, |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 8011 | LOWEST, nullptr, 0)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8012 | |
| 8013 | // Full frames. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8014 | spdy::SpdySerializedFrame body1( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 8015 | spdy_util_.ConstructSpdyDataFrame(1, content, false)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8016 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 8017 | // Last frame in each upload data buffer. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8018 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 8019 | 1, |
| 8020 | base::StringPiece(content.data(), kBufferSize % kMaxSpdyFrameChunkSize), |
| 8021 | false)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8022 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 8023 | // The very last frame before the stalled frames. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8024 | spdy::SpdySerializedFrame body3(spdy_util_.ConstructSpdyDataFrame( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 8025 | 1, |
| 8026 | base::StringPiece(content.data(), initial_window_size % kBufferSize % |
| 8027 | kMaxSpdyFrameChunkSize), |
| 8028 | false)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 8029 | |
| 8030 | // Data frames to be sent once WINDOW_UPDATE frame is received. |
| 8031 | |
| 8032 | // If kBufferSize * num_upload_buffers > initial_window_size, |
| 8033 | // we need one additional frame to send the rest of 'a'. |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 8034 | std::string last_body(kBufferSize * num_upload_buffers - initial_window_size, |
| 8035 | 'a'); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8036 | spdy::SpdySerializedFrame body4( |
Bence Béky | d74f438 | 2018-02-20 18:26:19 | [diff] [blame] | 8037 | spdy_util_.ConstructSpdyDataFrame(1, last_body, false)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 8038 | |
| 8039 | // Also send a "hello!" after WINDOW_UPDATE. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8040 | spdy::SpdySerializedFrame body5(spdy_util_.ConstructSpdyDataFrame(1, true)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8041 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 8042 | // Fill in mock writes. |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8043 | size_t i = 0; |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 8044 | std::vector<MockWrite> writes; |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 8045 | writes.push_back(CreateMockWrite(req, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 8046 | for (size_t j = 0; j < num_upload_buffers; j++) { |
| 8047 | for (size_t k = 0; k < num_frames_in_one_upload_buffer; k++) { |
Brandon Maslen | 6d59d91 | 2020-11-24 23:43:31 | [diff] [blame] | 8048 | if (j == num_upload_buffers - 1 && |
| 8049 | (initial_window_size % kBufferSize != 0)) { |
| 8050 | writes.push_back(CreateMockWrite(body3, i++)); |
| 8051 | } else if (k == num_frames_in_one_upload_buffer - 1 && |
| 8052 | kBufferSize % kMaxSpdyFrameChunkSize != 0) { |
| 8053 | writes.push_back(CreateMockWrite(body2, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 8054 | } else { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 8055 | writes.push_back(CreateMockWrite(body1, i++)); |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 8056 | } |
| 8057 | } |
| 8058 | } |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8059 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 8060 | // Fill in mock reads. |
| 8061 | std::vector<MockRead> reads; |
| 8062 | // Force a pause. |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 8063 | reads.push_back(MockRead(ASYNC, ERR_IO_PENDING, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8064 | // Construct read frame for SETTINGS that makes the send_window_size |
| 8065 | // negative. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8066 | spdy::SettingsMap new_settings; |
| 8067 | new_settings[spdy::SETTINGS_INITIAL_WINDOW_SIZE] = initial_window_size / 2; |
| 8068 | spdy::SpdySerializedFrame settings_frame_small( |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8069 | spdy_util_.ConstructSpdySettings(new_settings)); |
| 8070 | // Construct read frames for WINDOW_UPDATE that makes the send_window_size |
| 8071 | // positive. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8072 | spdy::SpdySerializedFrame session_window_update_init_size( |
bnc | 2f54c83 | 2014-12-01 13:31:19 | [diff] [blame] | 8073 | spdy_util_.ConstructSpdyWindowUpdate(0, initial_window_size)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8074 | spdy::SpdySerializedFrame window_update_init_size( |
bnc | 2f54c83 | 2014-12-01 13:31:19 | [diff] [blame] | 8075 | spdy_util_.ConstructSpdyWindowUpdate(1, initial_window_size)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8076 | |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 8077 | reads.push_back(CreateMockRead(settings_frame_small, i++)); |
| 8078 | reads.push_back(CreateMockRead(session_window_update_init_size, i++)); |
| 8079 | reads.push_back(CreateMockRead(window_update_init_size, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8080 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8081 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 8082 | writes.push_back(CreateMockWrite(settings_ack, i++)); |
[email protected] | d4a77c1 | 2014-05-15 20:45:21 | [diff] [blame] | 8083 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 8084 | // Stalled frames which can be sent after |settings_ack|. |
| 8085 | if (last_body.size() > 0) |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 8086 | writes.push_back(CreateMockWrite(body4, i++)); |
| 8087 | writes.push_back(CreateMockWrite(body5, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8088 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8089 | spdy::SpdySerializedFrame reply( |
| 8090 | spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 8091 | reads.push_back(CreateMockRead(reply, i++)); |
| 8092 | reads.push_back(CreateMockRead(body2, i++)); |
| 8093 | reads.push_back(CreateMockRead(body5, i++)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8094 | reads.push_back(MockRead(ASYNC, 0, i++)); // EOF |
| 8095 | |
| 8096 | // Force all writes to happen before any read, last write will not |
| 8097 | // actually queue a frame, due to window size being 0. |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8098 | SequencedSocketData data(reads, writes); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8099 | |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 8100 | std::vector<std::unique_ptr<UploadElementReader>> element_readers; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 8101 | std::string upload_data_string(kBufferSize * num_upload_buffers, 'a'); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8102 | upload_data_string.append(kUploadData, kUploadDataSize); |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 8103 | element_readers.push_back(std::make_unique<UploadBytesElementReader>( |
bnc | 3f6a855 | 2017-05-17 13:40:34 | [diff] [blame] | 8104 | upload_data_string.c_str(), upload_data_string.size())); |
olli.raula | 6df48b2a | 2015-11-26 07:40:22 | [diff] [blame] | 8105 | ElementsUploadDataStream upload_data_stream(std::move(element_readers), 0); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8106 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8107 | request_.method = "POST"; |
| 8108 | request_.upload_data_stream = &upload_data_stream; |
| 8109 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 8110 | |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8111 | helper.RunPreTestSetup(); |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 8112 | helper.AddData(&data); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8113 | |
| 8114 | HttpNetworkTransaction* trans = helper.trans(); |
| 8115 | |
| 8116 | TestCompletionCallback callback; |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8117 | int rv = trans->Start(&request_, callback.callback(), log_); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 8118 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8119 | |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 8120 | data.RunUntilPaused(); // Write as much as we can. |
| 8121 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8122 | |
| 8123 | SpdyHttpStream* stream = static_cast<SpdyHttpStream*>(trans->stream_.get()); |
wez | ca107093 | 2016-05-26 20:30:52 | [diff] [blame] | 8124 | ASSERT_TRUE(stream); |
| 8125 | ASSERT_TRUE(stream->stream()); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8126 | EXPECT_EQ(0, stream->stream()->send_window_size()); |
| 8127 | |
xunjieli | 179a6e7 | 2016-04-26 19:47:45 | [diff] [blame] | 8128 | if (initial_window_size % kBufferSize != 0) { |
| 8129 | // If it does not take whole number of full upload buffer to zero out |
| 8130 | // initial window size, then the upload data is not at EOF, because the |
| 8131 | // last read must be stalled. |
| 8132 | EXPECT_FALSE(upload_data_stream.IsEOF()); |
| 8133 | } else { |
| 8134 | // All the body data should have been read. |
| 8135 | // TODO(satorux): This is because of the weirdness in reading the request |
| 8136 | // body in OnSendBodyComplete(). See crbug.com/113107. |
| 8137 | EXPECT_TRUE(upload_data_stream.IsEOF()); |
| 8138 | } |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8139 | |
| 8140 | // Read in WINDOW_UPDATE or SETTINGS frame. |
mmenke | 666a6fea | 2015-12-19 04:16:33 | [diff] [blame] | 8141 | data.Resume(); |
| 8142 | base::RunLoop().RunUntilIdle(); |
[email protected] | d11b691 | 2013-06-27 23:07:32 | [diff] [blame] | 8143 | rv = callback.WaitForResult(); |
| 8144 | helper.VerifyDataConsumed(); |
| 8145 | } |
| 8146 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 8147 | TEST_F(SpdyNetworkTransactionTest, GoAwayOnOddPushStreamId) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 8148 | base::HistogramTester histogram_tester; |
| 8149 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 8150 | spdy::Http2HeaderBlock push_headers; |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 8151 | spdy_util_.AddUrlToHeaderBlock("http://www.example.org/a.dat", &push_headers); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8152 | spdy::SpdySerializedFrame push( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 8153 | spdy_util_.ConstructSpdyPushPromise(1, 3, std::move(push_headers))); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 8154 | MockRead reads[] = {CreateMockRead(push, 1)}; |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 8155 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8156 | spdy::SpdySerializedFrame req( |
| 8157 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 8158 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 8159 | 0, spdy::ERROR_CODE_PROTOCOL_ERROR, |
Bence Béky | 602c40c | 2017-07-26 05:22:56 | [diff] [blame] | 8160 | "Received invalid pushed stream id 3 (must be even) on stream id 1.")); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 8161 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 8162 | CreateMockWrite(req, 0), CreateMockWrite(goaway, 2), |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 8163 | }; |
| 8164 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8165 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8166 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 8167 | helper.RunToCompletion(&data); |
| 8168 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 8169 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 8170 | |
| 8171 | histogram_tester.ExpectBucketCount( |
| 8172 | "Net.SpdyPushedStreamFate", |
| 8173 | static_cast<int>(SpdyPushedStreamFate::kPromisedStreamIdParityError), 1); |
| 8174 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 8175 | } |
| 8176 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 8177 | TEST_F(SpdyNetworkTransactionTest, |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 8178 | GoAwayOnPushStreamIdLesserOrEqualThanLastAccepted) { |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 8179 | base::HistogramTester histogram_tester; |
| 8180 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8181 | spdy::SpdySerializedFrame push_a(spdy_util_.ConstructSpdyPush( |
Bence Béky | 3e01b53 | 2018-02-06 23:04:51 | [diff] [blame] | 8182 | nullptr, 0, 4, 1, "https://www.example.org/a.dat")); |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 8183 | spdy::Http2HeaderBlock push_b_headers; |
Bence Béky | 3e01b53 | 2018-02-06 23:04:51 | [diff] [blame] | 8184 | spdy_util_.AddUrlToHeaderBlock("https://www.example.org/b.dat", |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 8185 | &push_b_headers); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8186 | spdy::SpdySerializedFrame push_b( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 8187 | spdy_util_.ConstructSpdyPushPromise(1, 2, std::move(push_b_headers))); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 8188 | MockRead reads[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 8189 | CreateMockRead(push_a, 1), CreateMockRead(push_b, 3), |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 8190 | }; |
| 8191 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8192 | spdy::SpdySerializedFrame req( |
| 8193 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 8194 | spdy::SpdySerializedFrame priority_a( |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 8195 | spdy_util_.ConstructSpdyPriority(4, 1, IDLE, true)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8196 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 8197 | 4, spdy::ERROR_CODE_PROTOCOL_ERROR, |
Bence Béky | 602c40c | 2017-07-26 05:22:56 | [diff] [blame] | 8198 | "Received pushed stream id 2 must be larger than last accepted id 4.")); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 8199 | MockWrite writes[] = { |
tombergan | 5d22c18 | 2017-01-11 02:05:35 | [diff] [blame] | 8200 | CreateMockWrite(req, 0), CreateMockWrite(priority_a, 2), |
| 8201 | CreateMockWrite(goaway, 4), |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 8202 | }; |
| 8203 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8204 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8205 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 8206 | helper.RunToCompletion(&data); |
| 8207 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 8208 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
Bence Béky | eacd48f | 2018-05-14 11:34:33 | [diff] [blame] | 8209 | |
| 8210 | histogram_tester.ExpectBucketCount( |
| 8211 | "Net.SpdyPushedStreamFate", |
| 8212 | static_cast<int>(SpdyPushedStreamFate::kStreamIdOutOfOrder), 1); |
| 8213 | histogram_tester.ExpectTotalCount("Net.SpdyPushedStreamFate", 1); |
baranovich | 212a129 | 2014-09-02 21:45:31 | [diff] [blame] | 8214 | } |
| 8215 | |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 8216 | // Regression test for https://crbug.com/493348: request header exceeds 16 kB |
| 8217 | // and thus sent in multiple frames when using HTTP/2. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 8218 | TEST_F(SpdyNetworkTransactionTest, LargeRequest) { |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 8219 | const std::string kKey("foo"); |
| 8220 | const std::string kValue(1 << 15, 'z'); |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 8221 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8222 | request_.extra_headers.SetHeader(kKey, kValue); |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 8223 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 8224 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8225 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
bnc | 086b39e1 | 2016-06-24 13:05:26 | [diff] [blame] | 8226 | headers[kKey] = kValue; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8227 | spdy::SpdySerializedFrame req( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 8228 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers), LOWEST, true)); |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 8229 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 8230 | CreateMockWrite(req, 0), |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 8231 | }; |
| 8232 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8233 | spdy::SpdySerializedFrame resp( |
| 8234 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8235 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 8236 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 8237 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 8238 | MockRead(ASYNC, 0, 3) // EOF |
| 8239 | }; |
| 8240 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8241 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8242 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 8243 | helper.RunToCompletion(&data); |
| 8244 | TransactionHelperResult out = helper.output(); |
| 8245 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 8246 | EXPECT_THAT(out.rv, IsOk()); |
bnc | 84e7fb5 | 2015-12-02 11:50:02 | [diff] [blame] | 8247 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
bnc | 76598ab | 2015-06-29 12:43:07 | [diff] [blame] | 8248 | EXPECT_EQ("hello!", out.response_data); |
| 8249 | } |
| 8250 | |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 8251 | // Regression test for https://crbug.com/535629: response header exceeds 16 kB. |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 8252 | TEST_F(SpdyNetworkTransactionTest, LargeResponseHeader) { |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 8253 | spdy::Http2HeaderBlock headers( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8254 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 8255 | spdy::SpdySerializedFrame req( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 8256 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers), LOWEST, true)); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 8257 | MockWrite writes[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 8258 | CreateMockWrite(req, 0), |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 8259 | }; |
| 8260 | |
| 8261 | // HPACK decoder implementation limits string literal length to 16 kB. |
| 8262 | const char* response_headers[2]; |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 8263 | const std::string kKey(16 * 1024, 'a'); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 8264 | response_headers[0] = kKey.data(); |
Bence Béky | 4e83f49 | 2018-05-13 23:14:25 | [diff] [blame] | 8265 | const std::string kValue(16 * 1024, 'b'); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 8266 | response_headers[1] = kValue.data(); |
| 8267 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8268 | spdy::SpdySerializedFrame resp( |
bnc | 4233140 | 2016-07-25 13:36:15 | [diff] [blame] | 8269 | spdy_util_.ConstructSpdyGetReply(response_headers, 1, 1)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8270 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 8271 | MockRead reads[] = { |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 8272 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 8273 | MockRead(ASYNC, 0, 3) // EOF |
| 8274 | }; |
| 8275 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8276 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 8277 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8278 | SequencedSocketData data(reads, writes); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 8279 | helper.RunToCompletion(&data); |
| 8280 | TransactionHelperResult out = helper.output(); |
| 8281 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 8282 | EXPECT_THAT(out.rv, IsOk()); |
bnc | d6738334 | 2016-01-08 21:58:43 | [diff] [blame] | 8283 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 8284 | EXPECT_EQ("hello!", out.response_data); |
| 8285 | ASSERT_TRUE(out.response_info.headers->HasHeaderValue(kKey, kValue)); |
| 8286 | } |
| 8287 | |
bnc | 204a6d0 | 2016-08-01 14:34:27 | [diff] [blame] | 8288 | // End of line delimiter is forbidden according to RFC 7230 Section 3.2. |
| 8289 | TEST_F(SpdyNetworkTransactionTest, CRLFInHeaderValue) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8290 | spdy::SpdySerializedFrame req( |
| 8291 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 8292 | spdy::SpdySerializedFrame rst( |
| 8293 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_PROTOCOL_ERROR)); |
bnc | 204a6d0 | 2016-08-01 14:34:27 | [diff] [blame] | 8294 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(rst, 2)}; |
| 8295 | |
| 8296 | const char* response_headers[] = {"folded", "foo\r\nbar"}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8297 | spdy::SpdySerializedFrame resp( |
bnc | 204a6d0 | 2016-08-01 14:34:27 | [diff] [blame] | 8298 | spdy_util_.ConstructSpdyGetReply(response_headers, 1, 1)); |
| 8299 | MockRead reads[] = {CreateMockRead(resp, 1), MockRead(ASYNC, 0, 3)}; |
| 8300 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8301 | SequencedSocketData data(reads, writes); |
bnc | 204a6d0 | 2016-08-01 14:34:27 | [diff] [blame] | 8302 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8303 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 204a6d0 | 2016-08-01 14:34:27 | [diff] [blame] | 8304 | helper.RunToCompletion(&data); |
| 8305 | TransactionHelperResult out = helper.output(); |
| 8306 | |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 8307 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
bnc | 204a6d0 | 2016-08-01 14:34:27 | [diff] [blame] | 8308 | } |
| 8309 | |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 8310 | // Regression test for https://crbug.com/603182. |
| 8311 | // No response headers received before RST_STREAM: error. |
| 8312 | TEST_F(SpdyNetworkTransactionTest, RstStreamNoError) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8313 | spdy::SpdySerializedFrame req( |
| 8314 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 8315 | MockWrite writes[] = {CreateMockWrite(req, 0, ASYNC)}; |
| 8316 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8317 | spdy::SpdySerializedFrame rst( |
| 8318 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_NO_ERROR)); |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 8319 | MockRead reads[] = {CreateMockRead(rst, 1), MockRead(ASYNC, 0, 2)}; |
| 8320 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8321 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8322 | UseChunkedPostRequest(); |
| 8323 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 8324 | helper.RunToCompletion(&data); |
| 8325 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 8326 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 8327 | } |
| 8328 | |
| 8329 | // Regression test for https://crbug.com/603182. |
| 8330 | // Response headers and data, then RST_STREAM received, |
| 8331 | // before request body is sent: success. |
| 8332 | TEST_F(SpdyNetworkTransactionTest, RstStreamNoErrorAfterResponse) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8333 | spdy::SpdySerializedFrame req( |
| 8334 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 8335 | MockWrite writes[] = {CreateMockWrite(req, 0, ASYNC)}; |
| 8336 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8337 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 8338 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8339 | spdy::SpdySerializedFrame rst( |
| 8340 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_NO_ERROR)); |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 8341 | MockRead reads[] = {CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 8342 | CreateMockRead(rst, 3), MockRead(ASYNC, 0, 4)}; |
| 8343 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8344 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8345 | UseChunkedPostRequest(); |
| 8346 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | c22b581e8 | 2016-10-27 04:45:42 | [diff] [blame] | 8347 | helper.RunToCompletion(&data); |
| 8348 | TransactionHelperResult out = helper.output(); |
| 8349 | EXPECT_THAT(out.rv, IsOk()); |
| 8350 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 8351 | EXPECT_EQ("hello!", out.response_data); |
| 8352 | } |
| 8353 | |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 8354 | TEST_F(SpdyNetworkTransactionTest, 100Continue) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8355 | spdy::SpdySerializedFrame req( |
| 8356 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 8357 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 8358 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 8359 | spdy::Http2HeaderBlock informational_headers; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8360 | informational_headers[spdy::kHttp2StatusHeader] = "100"; |
| 8361 | spdy::SpdySerializedFrame informational_response( |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 8362 | spdy_util_.ConstructSpdyReply(1, std::move(informational_headers))); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8363 | spdy::SpdySerializedFrame resp( |
| 8364 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8365 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 8366 | MockRead reads[] = { |
| 8367 | CreateMockRead(informational_response, 1), CreateMockRead(resp, 2), |
| 8368 | CreateMockRead(body, 3), MockRead(ASYNC, 0, 4) // EOF |
| 8369 | }; |
| 8370 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8371 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8372 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | c9f762a | 2016-12-06 20:38:23 | [diff] [blame] | 8373 | helper.RunToCompletion(&data); |
| 8374 | TransactionHelperResult out = helper.output(); |
| 8375 | EXPECT_THAT(out.rv, IsOk()); |
| 8376 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 8377 | EXPECT_EQ("hello!", out.response_data); |
| 8378 | } |
| 8379 | |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 8380 | // "A server can send a complete response prior to the client sending an entire |
| 8381 | // request if the response does not depend on any portion of the request that |
| 8382 | // has not been sent and received." (RFC7540 Section 8.1) |
| 8383 | // Regression test for https://crbug.com/606990. Server responds before POST |
| 8384 | // data are sent and closes connection: this must result in |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 8385 | // ERR_CONNECTION_CLOSED (as opposed to ERR_HTTP2_PROTOCOL_ERROR). |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 8386 | TEST_F(SpdyNetworkTransactionTest, ResponseBeforePostDataSent) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8387 | spdy::SpdySerializedFrame req( |
| 8388 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 8389 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 8390 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8391 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 8392 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 8393 | MockRead reads[] = {CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 8394 | MockRead(ASYNC, 0, 3)}; |
| 8395 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8396 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8397 | UseChunkedPostRequest(); |
| 8398 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 8399 | |
| 8400 | helper.RunPreTestSetup(); |
| 8401 | helper.AddData(&data); |
| 8402 | helper.StartDefaultTest(); |
| 8403 | EXPECT_THAT(helper.output().rv, IsError(ERR_IO_PENDING)); |
| 8404 | helper.WaitForCallbackToComplete(); |
| 8405 | EXPECT_THAT(helper.output().rv, IsError(ERR_CONNECTION_CLOSED)); |
| 8406 | } |
| 8407 | |
| 8408 | // Regression test for https://crbug.com/606990. |
| 8409 | // Server responds before POST data are sent and resets stream with NO_ERROR. |
| 8410 | TEST_F(SpdyNetworkTransactionTest, ResponseAndRstStreamBeforePostDataSent) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8411 | spdy::SpdySerializedFrame req( |
| 8412 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 8413 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 8414 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8415 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 8416 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8417 | spdy::SpdySerializedFrame rst( |
| 8418 | spdy_util_.ConstructSpdyRstStream(1, spdy::ERROR_CODE_NO_ERROR)); |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 8419 | MockRead reads[] = {CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 8420 | CreateMockRead(rst, 3), MockRead(ASYNC, 0, 4)}; |
| 8421 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8422 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8423 | UseChunkedPostRequest(); |
| 8424 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 1ff8087 | 2016-12-16 20:57:57 | [diff] [blame] | 8425 | |
| 8426 | helper.RunToCompletion(&data); |
| 8427 | |
| 8428 | TransactionHelperResult out = helper.output(); |
| 8429 | EXPECT_THAT(out.rv, IsOk()); |
| 8430 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 8431 | EXPECT_EQ("hello!", out.response_data); |
| 8432 | } |
| 8433 | |
bnc | 96487ec | 2017-03-29 19:40:23 | [diff] [blame] | 8434 | // Unsupported frames must be ignored. This is especially important for frame |
| 8435 | // type 0xb, which used to be the BLOCKED frame in previous versions of SPDY, |
| 8436 | // but is going to be used for the ORIGIN frame. |
| 8437 | // TODO(bnc): Implement ORIGIN frame support. https://crbug.com/697333 |
| 8438 | TEST_F(SpdyNetworkTransactionTest, IgnoreUnsupportedOriginFrame) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8439 | spdy::SpdySerializedFrame req( |
| 8440 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
bnc | 96487ec | 2017-03-29 19:40:23 | [diff] [blame] | 8441 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 8442 | |
| 8443 | const char origin_frame_on_stream_zero[] = { |
| 8444 | 0x00, 0x00, 0x05, // Length |
| 8445 | 0x0b, // Type |
| 8446 | 0x00, // Flags |
| 8447 | 0x00, 0x00, 0x00, 0x00, // Stream ID |
| 8448 | 0x00, 0x03, // Origin-Len |
| 8449 | 'f', 'o', 'o' // ASCII-Origin |
| 8450 | }; |
| 8451 | |
| 8452 | const char origin_frame_on_stream_one[] = { |
| 8453 | 0x00, 0x00, 0x05, // Length |
| 8454 | 0x0b, // Type |
| 8455 | 0x00, // Flags |
| 8456 | 0x00, 0x00, 0x00, 0x01, // Stream ID |
| 8457 | 0x00, 0x03, // Origin-Len |
| 8458 | 'b', 'a', 'r' // ASCII-Origin |
| 8459 | }; |
| 8460 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8461 | spdy::SpdySerializedFrame resp( |
| 8462 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8463 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
bnc | 96487ec | 2017-03-29 19:40:23 | [diff] [blame] | 8464 | MockRead reads[] = {MockRead(ASYNC, origin_frame_on_stream_zero, |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 8465 | base::size(origin_frame_on_stream_zero), 1), |
bnc | 96487ec | 2017-03-29 19:40:23 | [diff] [blame] | 8466 | CreateMockRead(resp, 2), |
| 8467 | MockRead(ASYNC, origin_frame_on_stream_one, |
Avi Drissman | 4365a478 | 2018-12-28 19:26:24 | [diff] [blame] | 8468 | base::size(origin_frame_on_stream_one), 3), |
bnc | 96487ec | 2017-03-29 19:40:23 | [diff] [blame] | 8469 | CreateMockRead(body, 4), MockRead(ASYNC, 0, 5)}; |
| 8470 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8471 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8472 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
bnc | 96487ec | 2017-03-29 19:40:23 | [diff] [blame] | 8473 | helper.RunToCompletion(&data); |
| 8474 | TransactionHelperResult out = helper.output(); |
| 8475 | EXPECT_THAT(out.rv, IsOk()); |
| 8476 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 8477 | EXPECT_EQ("hello!", out.response_data); |
| 8478 | } |
| 8479 | |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 8480 | class SpdyNetworkTransactionTLSUsageCheckTest |
| 8481 | : public SpdyNetworkTransactionTest { |
| 8482 | protected: |
danakj | aee3e1ec | 2016-04-16 00:23:18 | [diff] [blame] | 8483 | void RunTLSUsageCheckTest( |
| 8484 | std::unique_ptr<SSLSocketDataProvider> ssl_provider) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8485 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 8486 | 0, spdy::ERROR_CODE_INADEQUATE_SECURITY, "")); |
bnc | df80d44fd | 2016-07-15 20:27:41 | [diff] [blame] | 8487 | MockWrite writes[] = {CreateMockWrite(goaway)}; |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 8488 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8489 | StaticSocketDataProvider data(base::span<MockRead>(), writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8490 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 8491 | nullptr); |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 8492 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 8493 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 8494 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_INADEQUATE_TRANSPORT_SECURITY)); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 8495 | } |
| 8496 | }; |
| 8497 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 8498 | TEST_F(SpdyNetworkTransactionTLSUsageCheckTest, TLSVersionTooOld) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 8499 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 8500 | SSLConnectionStatusSetVersion(SSL_CONNECTION_VERSION_SSL3, |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 8501 | &ssl_provider->ssl_info.connection_status); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 8502 | |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 8503 | RunTLSUsageCheckTest(std::move(ssl_provider)); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 8504 | } |
| 8505 | |
bnc | d16676a | 2016-07-20 16:23:01 | [diff] [blame] | 8506 | TEST_F(SpdyNetworkTransactionTLSUsageCheckTest, TLSCipherSuiteSucky) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 8507 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 8508 | // Set to TLS_RSA_WITH_NULL_MD5 |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 8509 | SSLConnectionStatusSetCipherSuite(0x1, |
| 8510 | &ssl_provider->ssl_info.connection_status); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 8511 | |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 8512 | RunTLSUsageCheckTest(std::move(ssl_provider)); |
[email protected] | 514aeaf | 2014-05-23 10:31:51 | [diff] [blame] | 8513 | } |
| 8514 | |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 8515 | // Regression test for https://crbug.com/737143. |
| 8516 | // This test sets up an old TLS version just like in TLSVersionTooOld, |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8517 | // and makes sure that it results in an spdy::ERROR_CODE_INADEQUATE_SECURITY |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 8518 | // even for a non-secure request URL. |
| 8519 | TEST_F(SpdyNetworkTransactionTest, InsecureUrlCreatesSecureSpdySession) { |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 8520 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 8521 | SSLConnectionStatusSetVersion(SSL_CONNECTION_VERSION_SSL3, |
Ryan Sleevi | 4f83209 | 2017-11-21 23:25:49 | [diff] [blame] | 8522 | &ssl_provider->ssl_info.connection_status); |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 8523 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8524 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 8525 | 0, spdy::ERROR_CODE_INADEQUATE_SECURITY, "")); |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 8526 | MockWrite writes[] = {CreateMockWrite(goaway)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8527 | StaticSocketDataProvider data(base::span<MockRead>(), writes); |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 8528 | |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8529 | request_.url = GURL("http://www.example.org/"); |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 8530 | |
| 8531 | // Need secure proxy so that insecure URL can use HTTP/2. |
Jeremy Roman | 0579ed6 | 2017-08-29 15:56:19 | [diff] [blame] | 8532 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Nicolas Arciniega | d2013f9 | 2020-02-07 23:00:56 | [diff] [blame] | 8533 | ConfiguredProxyResolutionService::CreateFixedFromPacResult( |
Ramin Halavati | ca8d525 | 2018-03-12 05:33:49 | [diff] [blame] | 8534 | "HTTPS myproxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8535 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
Bence Béky | d3dde83 | 2017-09-19 19:02:31 | [diff] [blame] | 8536 | std::move(session_deps)); |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 8537 | |
| 8538 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
| 8539 | TransactionHelperResult out = helper.output(); |
Bence Béky | d0d6950 | 2019-06-25 19:47:18 | [diff] [blame] | 8540 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_INADEQUATE_TRANSPORT_SECURITY)); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8541 | } |
Bence Béky | 306378f | 2017-06-30 12:09:56 | [diff] [blame] | 8542 | |
Andrey Kosyakov | 83a6eee | 2017-08-14 19:20:04 | [diff] [blame] | 8543 | TEST_F(SpdyNetworkTransactionTest, RequestHeadersCallback) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8544 | spdy::SpdySerializedFrame req( |
Bence Béky | 27ad0a1 | 2018-02-08 00:35:48 | [diff] [blame] | 8545 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, DEFAULT_PRIORITY)); |
Andrey Kosyakov | 83a6eee | 2017-08-14 19:20:04 | [diff] [blame] | 8546 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 8547 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8548 | spdy::SpdySerializedFrame resp( |
| 8549 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8550 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
Andrey Kosyakov | 83a6eee | 2017-08-14 19:20:04 | [diff] [blame] | 8551 | MockRead reads[] = { |
| 8552 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 8553 | MockRead(ASYNC, 0, 3) // EOF |
| 8554 | }; |
| 8555 | |
| 8556 | HttpRawRequestHeaders raw_headers; |
| 8557 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8558 | SequencedSocketData data(reads, writes); |
Bence Béky | db3cf65 | 2017-10-10 15:22:10 | [diff] [blame] | 8559 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
Andrey Kosyakov | 83a6eee | 2017-08-14 19:20:04 | [diff] [blame] | 8560 | helper.RunPreTestSetup(); |
| 8561 | helper.AddData(&data); |
Steve Kobes | 530eb14 | 2020-07-08 18:15:51 | [diff] [blame] | 8562 | helper.trans()->SetRequestHeadersCallback(base::BindRepeating( |
Andrey Kosyakov | 83a6eee | 2017-08-14 19:20:04 | [diff] [blame] | 8563 | &HttpRawRequestHeaders::Assign, base::Unretained(&raw_headers))); |
| 8564 | helper.StartDefaultTest(); |
| 8565 | helper.FinishDefaultTestWithoutVerification(); |
| 8566 | EXPECT_FALSE(raw_headers.headers().empty()); |
| 8567 | std::string value; |
| 8568 | EXPECT_TRUE(raw_headers.FindHeaderForTest(":path", &value)); |
| 8569 | EXPECT_EQ("/", value); |
| 8570 | EXPECT_TRUE(raw_headers.FindHeaderForTest(":method", &value)); |
| 8571 | EXPECT_EQ("GET", value); |
| 8572 | EXPECT_TRUE(raw_headers.request_line().empty()); |
| 8573 | } |
| 8574 | |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 8575 | // A request that has adopted a push promise and later got reset by the server |
| 8576 | // should be retried on a new stream. |
| 8577 | // Regression test for https://crbug.com/798508. |
| 8578 | TEST_F(SpdyNetworkTransactionTest, PushCanceledByServerAfterClaimed) { |
| 8579 | const char pushed_url[] = "https://www.example.org/a.dat"; |
| 8580 | // Construct a request to the default URL on stream 1. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8581 | spdy::SpdySerializedFrame req( |
| 8582 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 8583 | spdy::SpdySerializedFrame req2( |
| 8584 | spdy_util_.ConstructSpdyGet(pushed_url, 3, LOWEST)); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 8585 | // Construct a priority frame for stream 2. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8586 | spdy::SpdySerializedFrame priority( |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 8587 | spdy_util_.ConstructSpdyPriority(2, 1, IDLE, true)); |
| 8588 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(priority, 3), |
| 8589 | CreateMockWrite(req2, 6)}; |
| 8590 | |
| 8591 | // Construct a Push Promise frame, with no response. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8592 | spdy::SpdySerializedFrame push_promise(spdy_util_.ConstructSpdyPushPromise( |
Bence Béky | f1d7852 | 2018-01-11 01:16:50 | [diff] [blame] | 8593 | 1, 2, spdy_util_.ConstructGetHeaderBlock(pushed_url))); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 8594 | // Construct a RST frame, canceling stream 2. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8595 | spdy::SpdySerializedFrame rst_server( |
| 8596 | spdy_util_.ConstructSpdyRstStream(2, spdy::ERROR_CODE_CANCEL)); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 8597 | // Construct response headers and bodies. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8598 | spdy::SpdySerializedFrame resp1( |
| 8599 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8600 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8601 | spdy::SpdySerializedFrame resp2( |
| 8602 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 8603 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 8604 | MockRead reads[] = { |
| 8605 | CreateMockRead(push_promise, 1), MockRead(ASYNC, ERR_IO_PENDING, 2), |
| 8606 | CreateMockRead(rst_server, 4), MockRead(ASYNC, ERR_IO_PENDING, 5), |
| 8607 | CreateMockRead(resp1, 7), CreateMockRead(body1, 8), |
| 8608 | CreateMockRead(resp2, 9), CreateMockRead(body2, 10), |
| 8609 | MockRead(ASYNC, 0, 11)}; |
| 8610 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8611 | SequencedSocketData data(reads, writes); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 8612 | |
| 8613 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 8614 | |
| 8615 | helper.RunPreTestSetup(); |
| 8616 | helper.AddData(&data); |
| 8617 | |
| 8618 | HttpNetworkTransaction* trans = helper.trans(); |
| 8619 | |
| 8620 | // First request to start the connection. |
| 8621 | TestCompletionCallback callback1; |
| 8622 | int rv = trans->Start(&request_, callback1.callback(), log_); |
| 8623 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 8624 | |
| 8625 | data.RunUntilPaused(); |
| 8626 | |
| 8627 | // Get a SpdySession. |
| 8628 | SpdySessionKey key(HostPortPair::FromURL(request_.url), ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 8629 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 8630 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 8631 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 8632 | HttpNetworkSession* session = helper.session(); |
| 8633 | base::WeakPtr<SpdySession> spdy_session = |
| 8634 | session->spdy_session_pool()->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 8635 | key, /* enable_ip_based_pooling = */ true, |
| 8636 | /* is_websocket = */ false, log_); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 8637 | |
| 8638 | // Verify that there is one unclaimed push stream. |
| 8639 | EXPECT_EQ(1u, num_unclaimed_pushed_streams(spdy_session)); |
| 8640 | |
| 8641 | // Claim the pushed stream. |
| 8642 | HttpNetworkTransaction transaction2(DEFAULT_PRIORITY, session); |
| 8643 | TestCompletionCallback callback2; |
| 8644 | HttpRequestInfo request2; |
| 8645 | request2.method = "GET"; |
| 8646 | request2.url = GURL(pushed_url); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 8647 | request2.traffic_annotation = |
| 8648 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Yoav Weiss | 9693572f | 2018-01-04 09:37:34 | [diff] [blame] | 8649 | transaction2.Start(&request2, callback2.callback(), log_); |
| 8650 | base::RunLoop().RunUntilIdle(); |
| 8651 | EXPECT_EQ(3u, spdy_stream_hi_water_mark(spdy_session)); |
| 8652 | |
| 8653 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session)); |
| 8654 | |
| 8655 | // Continue reading and get the RST. |
| 8656 | data.Resume(); |
| 8657 | base::RunLoop().RunUntilIdle(); |
| 8658 | |
| 8659 | // Make sure we got the RST and retried the request. |
| 8660 | EXPECT_EQ(2u, num_active_streams(spdy_session)); |
| 8661 | EXPECT_EQ(0u, num_unclaimed_pushed_streams(spdy_session)); |
| 8662 | EXPECT_EQ(5u, spdy_stream_hi_water_mark(spdy_session)); |
| 8663 | |
| 8664 | data.Resume(); |
| 8665 | |
| 8666 | // Test that transactions succeeded. |
| 8667 | rv = callback1.WaitForResult(); |
| 8668 | ASSERT_THAT(rv, IsOk()); |
| 8669 | |
| 8670 | rv = callback2.WaitForResult(); |
| 8671 | ASSERT_THAT(rv, IsOk()); |
| 8672 | |
| 8673 | // Read EOF. |
| 8674 | base::RunLoop().RunUntilIdle(); |
| 8675 | |
| 8676 | // Verify that all data was read and written. |
| 8677 | helper.VerifyDataConsumed(); |
| 8678 | } |
| 8679 | |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8680 | #if BUILDFLAG(ENABLE_WEBSOCKETS) |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8681 | |
| 8682 | TEST_F(SpdyNetworkTransactionTest, WebSocketOpensNewConnection) { |
Bence Béky | b09dddf1 | 2018-07-31 18:52:04 | [diff] [blame] | 8683 | base::HistogramTester histogram_tester; |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8684 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 8685 | helper.RunPreTestSetup(); |
| 8686 | |
| 8687 | // First request opens up an HTTP/2 connection. |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8688 | spdy::SpdySerializedFrame req( |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8689 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, DEFAULT_PRIORITY)); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8690 | MockWrite writes1[] = {CreateMockWrite(req, 0)}; |
| 8691 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8692 | spdy::SpdySerializedFrame resp( |
| 8693 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8694 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8695 | MockRead reads1[] = {CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 8696 | MockRead(ASYNC, ERR_IO_PENDING, 3), |
| 8697 | MockRead(ASYNC, 0, 4)}; |
| 8698 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8699 | SequencedSocketData data1(reads1, writes1); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8700 | helper.AddData(&data1); |
| 8701 | |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8702 | // WebSocket request opens a new connection with HTTP/2 disabled. |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8703 | MockWrite writes2[] = { |
| 8704 | MockWrite("GET / HTTP/1.1\r\n" |
| 8705 | "Host: www.example.org\r\n" |
| 8706 | "Connection: Upgrade\r\n" |
| 8707 | "Upgrade: websocket\r\n" |
| 8708 | "Origin: http://www.example.org\r\n" |
| 8709 | "Sec-WebSocket-Version: 13\r\n" |
Bence Béky | 8d1c605 | 2018-02-07 12:48:15 | [diff] [blame] | 8710 | "Sec-WebSocket-Key: dGhlIHNhbXBsZSBub25jZQ==\r\n" |
| 8711 | "Sec-WebSocket-Extensions: permessage-deflate; " |
| 8712 | "client_max_window_bits\r\n\r\n")}; |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8713 | |
Bence Béky | 8d1c605 | 2018-02-07 12:48:15 | [diff] [blame] | 8714 | MockRead reads2[] = { |
| 8715 | MockRead("HTTP/1.1 101 Switching Protocols\r\n" |
| 8716 | "Upgrade: websocket\r\n" |
| 8717 | "Connection: Upgrade\r\n" |
| 8718 | "Sec-WebSocket-Accept: s3pPLMBiTxaQ9kYGzzhZRbK+xOo=\r\n\r\n")}; |
| 8719 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8720 | StaticSocketDataProvider data2(reads2, writes2); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8721 | |
| 8722 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8723 | // Test that request has empty |alpn_protos|, that is, HTTP/2 is disabled. |
| 8724 | ssl_provider2->next_protos_expected_in_ssl_config = NextProtoVector{}; |
| 8725 | // Force socket to use HTTP/1.1, the default protocol without ALPN. |
| 8726 | ssl_provider2->next_proto = kProtoHTTP11; |
| 8727 | ssl_provider2->ssl_info.cert = |
| 8728 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
| 8729 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 8730 | |
| 8731 | TestCompletionCallback callback1; |
| 8732 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 8733 | int rv = trans1.Start(&request_, callback1.callback(), log_); |
| 8734 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 8735 | rv = callback1.WaitForResult(); |
| 8736 | ASSERT_THAT(rv, IsOk()); |
| 8737 | |
| 8738 | const HttpResponseInfo* response = trans1.GetResponseInfo(); |
| 8739 | ASSERT_TRUE(response->headers); |
| 8740 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 8741 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 8742 | |
| 8743 | std::string response_data; |
| 8744 | rv = ReadTransaction(&trans1, &response_data); |
| 8745 | EXPECT_THAT(rv, IsOk()); |
| 8746 | EXPECT_EQ("hello!", response_data); |
| 8747 | |
| 8748 | SpdySessionKey key(HostPortPair::FromURL(request_.url), ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 8749 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 8750 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 8751 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8752 | base::WeakPtr<SpdySession> spdy_session = |
| 8753 | helper.session()->spdy_session_pool()->FindAvailableSession( |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 8754 | key, /* enable_ip_based_pooling = */ true, |
| 8755 | /* is_websocket = */ false, log_); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8756 | ASSERT_TRUE(spdy_session); |
Bence Béky | d885b2b | 2018-02-03 00:58:31 | [diff] [blame] | 8757 | EXPECT_FALSE(spdy_session->support_websocket()); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8758 | |
| 8759 | HttpRequestInfo request2; |
| 8760 | request2.method = "GET"; |
| 8761 | request2.url = GURL("wss://www.example.org/"); |
Ramin Halavati | b5e433e6 | 2018-02-07 07:41:10 | [diff] [blame] | 8762 | request2.traffic_annotation = |
| 8763 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8764 | EXPECT_TRUE(HostPortPair::FromURL(request_.url) |
| 8765 | .Equals(HostPortPair::FromURL(request2.url))); |
| 8766 | request2.extra_headers.SetHeader("Connection", "Upgrade"); |
| 8767 | request2.extra_headers.SetHeader("Upgrade", "websocket"); |
| 8768 | request2.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 8769 | request2.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
Bence Béky | 8d1c605 | 2018-02-07 12:48:15 | [diff] [blame] | 8770 | |
| 8771 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8772 | |
| 8773 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8774 | trans2.SetWebSocketHandshakeStreamCreateHelper( |
| 8775 | &websocket_stream_create_helper); |
| 8776 | |
| 8777 | TestCompletionCallback callback2; |
| 8778 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 8779 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 8780 | rv = callback2.WaitForResult(); |
| 8781 | ASSERT_THAT(rv, IsOk()); |
| 8782 | |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8783 | // HTTP/2 connection is still open, but WebSocket request did not pool to it. |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8784 | ASSERT_TRUE(spdy_session); |
| 8785 | |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8786 | data1.Resume(); |
Bence Béky | b09dddf1 | 2018-07-31 18:52:04 | [diff] [blame] | 8787 | base::RunLoop().RunUntilIdle(); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8788 | helper.VerifyDataConsumed(); |
Bence Béky | b09dddf1 | 2018-07-31 18:52:04 | [diff] [blame] | 8789 | |
| 8790 | // Server did not advertise WebSocket support. |
| 8791 | histogram_tester.ExpectUniqueSample("Net.SpdySession.ServerSupportsWebSocket", |
| 8792 | /* support_websocket = false */ 0, |
| 8793 | /* expected_count = */ 1); |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 8794 | } |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8795 | |
Matt Menke | 7717395 | 2019-04-18 17:42:14 | [diff] [blame] | 8796 | // Make sure that a WebSocket job doesn't pick up a newly created SpdySession |
| 8797 | // that doesn't support WebSockets through |
| 8798 | // HttpStreamFactory::Job::OnSpdySessionAvailable(). |
| 8799 | TEST_F(SpdyNetworkTransactionTest, |
| 8800 | WebSocketDoesUseNewH2SessionWithoutWebSocketSupport) { |
| 8801 | base::HistogramTester histogram_tester; |
| 8802 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 8803 | session_deps->enable_websocket_over_http2 = true; |
| 8804 | NormalSpdyTransactionHelper helper(request_, HIGHEST, log_, |
| 8805 | std::move(session_deps)); |
| 8806 | helper.RunPreTestSetup(); |
| 8807 | |
| 8808 | spdy::SpdySerializedFrame req( |
| 8809 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, HIGHEST)); |
| 8810 | |
| 8811 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 8812 | |
| 8813 | spdy::SpdySerializedFrame resp1( |
| 8814 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8815 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8816 | MockRead reads[] = {CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 8817 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 3)}; |
| 8818 | |
| 8819 | SequencedSocketData data( |
| 8820 | // Just as with other operations, this means to pause during connection |
| 8821 | // establishment. |
| 8822 | MockConnect(ASYNC, ERR_IO_PENDING), reads, writes); |
| 8823 | helper.AddData(&data); |
| 8824 | |
| 8825 | MockWrite writes2[] = { |
| 8826 | MockWrite(SYNCHRONOUS, 0, |
| 8827 | "GET / HTTP/1.1\r\n" |
| 8828 | "Host: www.example.org\r\n" |
| 8829 | "Connection: Upgrade\r\n" |
| 8830 | "Upgrade: websocket\r\n" |
| 8831 | "Origin: http://www.example.org\r\n" |
| 8832 | "Sec-WebSocket-Version: 13\r\n" |
| 8833 | "Sec-WebSocket-Key: dGhlIHNhbXBsZSBub25jZQ==\r\n" |
| 8834 | "Sec-WebSocket-Extensions: permessage-deflate; " |
| 8835 | "client_max_window_bits\r\n\r\n")}; |
| 8836 | |
| 8837 | MockRead reads2[] = { |
| 8838 | MockRead(SYNCHRONOUS, 1, |
| 8839 | "HTTP/1.1 101 Switching Protocols\r\n" |
| 8840 | "Upgrade: websocket\r\n" |
| 8841 | "Connection: Upgrade\r\n" |
| 8842 | "Sec-WebSocket-Accept: s3pPLMBiTxaQ9kYGzzhZRbK+xOo=\r\n\r\n")}; |
| 8843 | SequencedSocketData data2(MockConnect(ASYNC, ERR_IO_PENDING), reads2, |
| 8844 | writes2); |
| 8845 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 8846 | // Test that request has empty |alpn_protos|, that is, HTTP/2 is disabled. |
| 8847 | ssl_provider2->next_protos_expected_in_ssl_config = NextProtoVector{}; |
| 8848 | // Force socket to use HTTP/1.1, the default protocol without ALPN. |
| 8849 | ssl_provider2->next_proto = kProtoHTTP11; |
Matt Menke | 7717395 | 2019-04-18 17:42:14 | [diff] [blame] | 8850 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 8851 | |
| 8852 | TestCompletionCallback callback1; |
| 8853 | int rv = helper.trans()->Start(&request_, callback1.callback(), log_); |
| 8854 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 8855 | |
| 8856 | // Create HTTP/2 connection. |
| 8857 | base::RunLoop().RunUntilIdle(); |
| 8858 | |
| 8859 | HttpRequestInfo request2; |
| 8860 | request2.method = "GET"; |
| 8861 | request2.url = GURL("wss://www.example.org/"); |
| 8862 | request2.traffic_annotation = |
| 8863 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 8864 | EXPECT_TRUE(HostPortPair::FromURL(request_.url) |
| 8865 | .Equals(HostPortPair::FromURL(request2.url))); |
| 8866 | request2.extra_headers.SetHeader("Connection", "Upgrade"); |
| 8867 | request2.extra_headers.SetHeader("Upgrade", "websocket"); |
| 8868 | request2.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 8869 | request2.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
| 8870 | |
| 8871 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 8872 | |
| 8873 | HttpNetworkTransaction trans2(MEDIUM, helper.session()); |
| 8874 | trans2.SetWebSocketHandshakeStreamCreateHelper( |
| 8875 | &websocket_stream_create_helper); |
| 8876 | |
| 8877 | TestCompletionCallback callback2; |
| 8878 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 8879 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 8880 | |
| 8881 | // Run until waiting on both connections. |
| 8882 | base::RunLoop().RunUntilIdle(); |
| 8883 | |
| 8884 | // The H2 connection completes. |
| 8885 | data.socket()->OnConnectComplete(MockConnect(SYNCHRONOUS, OK)); |
| 8886 | EXPECT_EQ(OK, callback1.WaitForResult()); |
| 8887 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
| 8888 | ASSERT_TRUE(response->headers); |
| 8889 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 8890 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 8891 | std::string response_data; |
| 8892 | rv = ReadTransaction(helper.trans(), &response_data); |
| 8893 | EXPECT_THAT(rv, IsOk()); |
| 8894 | EXPECT_EQ("hello!", response_data); |
| 8895 | |
| 8896 | SpdySessionKey key(HostPortPair::FromURL(request_.url), ProxyServer::Direct(), |
| 8897 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 8898 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 8899 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | 7717395 | 2019-04-18 17:42:14 | [diff] [blame] | 8900 | |
| 8901 | base::WeakPtr<SpdySession> spdy_session = |
| 8902 | helper.session()->spdy_session_pool()->FindAvailableSession( |
| 8903 | key, /* enable_ip_based_pooling = */ true, |
| 8904 | /* is_websocket = */ false, log_); |
| 8905 | ASSERT_TRUE(spdy_session); |
| 8906 | EXPECT_FALSE(spdy_session->support_websocket()); |
| 8907 | |
| 8908 | EXPECT_FALSE(callback2.have_result()); |
| 8909 | |
| 8910 | // Create WebSocket stream. |
| 8911 | data2.socket()->OnConnectComplete(MockConnect(SYNCHRONOUS, OK)); |
| 8912 | |
| 8913 | rv = callback2.WaitForResult(); |
| 8914 | ASSERT_THAT(rv, IsOk()); |
| 8915 | helper.VerifyDataConsumed(); |
| 8916 | } |
| 8917 | |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8918 | TEST_F(SpdyNetworkTransactionTest, WebSocketOverHTTP2) { |
Bence Béky | b09dddf1 | 2018-07-31 18:52:04 | [diff] [blame] | 8919 | base::HistogramTester histogram_tester; |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8920 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 8921 | session_deps->enable_websocket_over_http2 = true; |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 8922 | NormalSpdyTransactionHelper helper(request_, HIGHEST, log_, |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8923 | std::move(session_deps)); |
| 8924 | helper.RunPreTestSetup(); |
| 8925 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8926 | spdy::SpdySerializedFrame req( |
| 8927 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, HIGHEST)); |
| 8928 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8929 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 8930 | spdy::Http2HeaderBlock websocket_request_headers; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8931 | websocket_request_headers[spdy::kHttp2MethodHeader] = "CONNECT"; |
| 8932 | websocket_request_headers[spdy::kHttp2AuthorityHeader] = "www.example.org"; |
| 8933 | websocket_request_headers[spdy::kHttp2SchemeHeader] = "https"; |
| 8934 | websocket_request_headers[spdy::kHttp2PathHeader] = "/"; |
| 8935 | websocket_request_headers[spdy::kHttp2ProtocolHeader] = "websocket"; |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8936 | websocket_request_headers["origin"] = "http://www.example.org"; |
| 8937 | websocket_request_headers["sec-websocket-version"] = "13"; |
| 8938 | websocket_request_headers["sec-websocket-extensions"] = |
| 8939 | "permessage-deflate; client_max_window_bits"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8940 | spdy::SpdySerializedFrame websocket_request(spdy_util_.ConstructSpdyHeaders( |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 8941 | 3, std::move(websocket_request_headers), MEDIUM, false)); |
| 8942 | |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 8943 | spdy::SpdySerializedFrame priority1( |
| 8944 | spdy_util_.ConstructSpdyPriority(3, 0, MEDIUM, true)); |
| 8945 | spdy::SpdySerializedFrame priority2( |
| 8946 | spdy_util_.ConstructSpdyPriority(1, 3, LOWEST, true)); |
| 8947 | |
| 8948 | MockWrite writes[] = { |
| 8949 | CreateMockWrite(req, 0), CreateMockWrite(settings_ack, 2), |
| 8950 | CreateMockWrite(websocket_request, 4), CreateMockWrite(priority1, 5), |
| 8951 | CreateMockWrite(priority2, 6)}; |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8952 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8953 | spdy::SettingsMap settings; |
| 8954 | settings[spdy::SETTINGS_ENABLE_CONNECT_PROTOCOL] = 1; |
| 8955 | spdy::SpdySerializedFrame settings_frame( |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8956 | spdy_util_.ConstructSpdySettings(settings)); |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 8957 | spdy::SpdySerializedFrame resp1( |
| 8958 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 8959 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 8960 | spdy::SpdySerializedFrame websocket_response( |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8961 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 8962 | MockRead reads[] = {CreateMockRead(settings_frame, 1), |
| 8963 | CreateMockRead(resp1, 3), CreateMockRead(body1, 7), |
| 8964 | CreateMockRead(websocket_response, 8), |
| 8965 | MockRead(ASYNC, 0, 9)}; |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8966 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 8967 | SequencedSocketData data(reads, writes); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8968 | helper.AddData(&data); |
| 8969 | |
| 8970 | TestCompletionCallback callback1; |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 8971 | int rv = helper.trans()->Start(&request_, callback1.callback(), log_); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8972 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8973 | |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 8974 | // Create HTTP/2 connection. |
| 8975 | base::RunLoop().RunUntilIdle(); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8976 | |
| 8977 | SpdySessionKey key(HostPortPair::FromURL(request_.url), ProxyServer::Direct(), |
Matt Menke | 2436b2f | 2018-12-11 18:07:11 | [diff] [blame] | 8978 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 8979 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 8980 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 8981 | base::WeakPtr<SpdySession> spdy_session = |
| 8982 | helper.session()->spdy_session_pool()->FindAvailableSession( |
| 8983 | key, /* enable_ip_based_pooling = */ true, |
| 8984 | /* is_websocket = */ true, log_); |
| 8985 | ASSERT_TRUE(spdy_session); |
| 8986 | EXPECT_TRUE(spdy_session->support_websocket()); |
| 8987 | |
| 8988 | HttpRequestInfo request2; |
| 8989 | request2.method = "GET"; |
| 8990 | request2.url = GURL("wss://www.example.org/"); |
| 8991 | request2.traffic_annotation = |
| 8992 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 8993 | EXPECT_TRUE(HostPortPair::FromURL(request_.url) |
| 8994 | .Equals(HostPortPair::FromURL(request2.url))); |
| 8995 | request2.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 8996 | request2.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
| 8997 | // The following two headers must be removed by WebSocketHttp2HandshakeStream. |
| 8998 | request2.extra_headers.SetHeader("Connection", "Upgrade"); |
| 8999 | request2.extra_headers.SetHeader("Upgrade", "websocket"); |
| 9000 | |
| 9001 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 9002 | |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 9003 | HttpNetworkTransaction trans2(MEDIUM, helper.session()); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 9004 | trans2.SetWebSocketHandshakeStreamCreateHelper( |
| 9005 | &websocket_stream_create_helper); |
| 9006 | |
| 9007 | TestCompletionCallback callback2; |
| 9008 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 9009 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 9010 | |
| 9011 | // Create WebSocket stream. |
| 9012 | base::RunLoop().RunUntilIdle(); |
Bence Béky | 73b8529 | 2018-06-14 04:56:43 | [diff] [blame] | 9013 | ASSERT_TRUE(spdy_session); |
| 9014 | |
| 9015 | // First request has HIGHEST priority, WebSocket request has MEDIUM priority. |
| 9016 | // Changing the priority of the first request to LOWEST changes their order, |
| 9017 | // and therefore triggers sending PRIORITY frames. |
| 9018 | helper.trans()->SetPriority(LOWEST); |
Bence Béky | 7a4836c | 2018-05-08 03:52:48 | [diff] [blame] | 9019 | |
| 9020 | rv = callback1.WaitForResult(); |
| 9021 | ASSERT_THAT(rv, IsOk()); |
| 9022 | |
| 9023 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
| 9024 | ASSERT_TRUE(response->headers); |
| 9025 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 9026 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 9027 | |
| 9028 | std::string response_data; |
| 9029 | rv = ReadTransaction(helper.trans(), &response_data); |
| 9030 | EXPECT_THAT(rv, IsOk()); |
| 9031 | EXPECT_EQ("hello!", response_data); |
| 9032 | |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 9033 | rv = callback2.WaitForResult(); |
| 9034 | ASSERT_THAT(rv, IsOk()); |
| 9035 | |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 9036 | helper.VerifyDataConsumed(); |
Bence Béky | b09dddf1 | 2018-07-31 18:52:04 | [diff] [blame] | 9037 | |
| 9038 | // Server advertised WebSocket support. |
| 9039 | histogram_tester.ExpectUniqueSample("Net.SpdySession.ServerSupportsWebSocket", |
| 9040 | /* support_websocket = true */ 1, |
| 9041 | /* expected_count = */ 1); |
Bence Béky | 8bfacd4 | 2018-02-23 13:05:13 | [diff] [blame] | 9042 | } |
| 9043 | |
Matt Menke | 7269f35 | 2019-10-03 17:05:29 | [diff] [blame] | 9044 | // Make sure that a WebSocket job doesn't pick up a newly created SpdySession |
| 9045 | // that supports WebSockets through an HTTPS proxy when an H2 server doesn't |
| 9046 | // support websockets and |enable_websocket_over_http2| is false. See |
| 9047 | // https://crbug.com/1010491. |
| 9048 | TEST_F(SpdyNetworkTransactionTest, |
| 9049 | WebSocketDoesNotUseNewH2SessionWithoutWebSocketSupportOverHttpsProxy) { |
| 9050 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Nicolas Arciniega | d2013f9 | 2020-02-07 23:00:56 | [diff] [blame] | 9051 | ConfiguredProxyResolutionService::CreateFixed( |
| 9052 | "https://proxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
Matt Menke | 7269f35 | 2019-10-03 17:05:29 | [diff] [blame] | 9053 | |
| 9054 | // Note: Once WebSocket over H2 is enabled by default, this line can be |
| 9055 | // deleted, and this test will still be useful to keep, though its description |
| 9056 | // will need to be updated. |
| 9057 | session_deps->enable_websocket_over_http2 = false; |
| 9058 | |
| 9059 | NormalSpdyTransactionHelper helper(request_, HIGHEST, log_, |
| 9060 | std::move(session_deps)); |
| 9061 | helper.RunPreTestSetup(); |
| 9062 | |
| 9063 | spdy::SpdySerializedFrame req( |
| 9064 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, HIGHEST)); |
| 9065 | |
| 9066 | MockWrite writes[] = {MockWrite(SYNCHRONOUS, 0, |
| 9067 | "CONNECT www.example.org:443 HTTP/1.1\r\n" |
| 9068 | "Host: www.example.org:443\r\n" |
| 9069 | "Proxy-Connection: keep-alive\r\n\r\n"), |
| 9070 | CreateMockWrite(req, 2)}; |
| 9071 | |
| 9072 | spdy::SpdySerializedFrame resp1( |
| 9073 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 9074 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 9075 | MockRead reads[] = {MockRead(SYNCHRONOUS, 1, "HTTP/1.1 200 OK\r\n\r\n"), |
| 9076 | CreateMockRead(resp1, 3), CreateMockRead(body1, 4), |
| 9077 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 5)}; |
| 9078 | |
| 9079 | // SSL data for the proxy. |
| 9080 | SSLSocketDataProvider tunnel_ssl_data(ASYNC, OK); |
| 9081 | helper.session_deps()->socket_factory->AddSSLSocketDataProvider( |
| 9082 | &tunnel_ssl_data); |
| 9083 | |
| 9084 | SequencedSocketData data( |
| 9085 | // Just as with other operations, this means to pause during connection |
| 9086 | // establishment. |
| 9087 | MockConnect(ASYNC, ERR_IO_PENDING), reads, writes); |
| 9088 | helper.AddData(&data); |
| 9089 | |
| 9090 | MockWrite writes2[] = { |
| 9091 | MockWrite(SYNCHRONOUS, 0, |
| 9092 | "CONNECT www.example.org:443 HTTP/1.1\r\n" |
| 9093 | "Host: www.example.org:443\r\n" |
| 9094 | "Proxy-Connection: keep-alive\r\n\r\n"), |
| 9095 | MockWrite(SYNCHRONOUS, 2, |
| 9096 | "GET / HTTP/1.1\r\n" |
| 9097 | "Host: www.example.org\r\n" |
| 9098 | "Connection: Upgrade\r\n" |
| 9099 | "Upgrade: websocket\r\n" |
| 9100 | "Origin: http://www.example.org\r\n" |
| 9101 | "Sec-WebSocket-Version: 13\r\n" |
| 9102 | "Sec-WebSocket-Key: dGhlIHNhbXBsZSBub25jZQ==\r\n" |
| 9103 | "Sec-WebSocket-Extensions: permessage-deflate; " |
| 9104 | "client_max_window_bits\r\n\r\n")}; |
| 9105 | |
| 9106 | MockRead reads2[] = { |
| 9107 | MockRead(SYNCHRONOUS, 1, "HTTP/1.1 200 OK\r\n\r\n"), |
| 9108 | MockRead(SYNCHRONOUS, 3, |
| 9109 | "HTTP/1.1 101 Switching Protocols\r\n" |
| 9110 | "Upgrade: websocket\r\n" |
| 9111 | "Connection: Upgrade\r\n" |
| 9112 | "Sec-WebSocket-Accept: s3pPLMBiTxaQ9kYGzzhZRbK+xOo=\r\n\r\n")}; |
| 9113 | SequencedSocketData data2(MockConnect(ASYNC, ERR_IO_PENDING), reads2, |
| 9114 | writes2); |
| 9115 | |
| 9116 | // SSL data for the proxy. |
| 9117 | SSLSocketDataProvider tunnel_ssl_data2(ASYNC, OK); |
| 9118 | helper.session_deps()->socket_factory->AddSSLSocketDataProvider( |
| 9119 | &tunnel_ssl_data2); |
| 9120 | |
| 9121 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 9122 | // Test that request has empty |alpn_protos|, that is, HTTP/2 is disabled. |
| 9123 | ssl_provider2->next_protos_expected_in_ssl_config = NextProtoVector{}; |
| 9124 | // Force socket to use HTTP/1.1, the default protocol without ALPN. |
| 9125 | ssl_provider2->next_proto = kProtoHTTP11; |
| 9126 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 9127 | |
| 9128 | TestCompletionCallback callback1; |
| 9129 | int rv = helper.trans()->Start(&request_, callback1.callback(), log_); |
| 9130 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 9131 | |
| 9132 | // Create HTTP/2 connection. |
| 9133 | base::RunLoop().RunUntilIdle(); |
| 9134 | |
| 9135 | HttpRequestInfo request2; |
| 9136 | request2.method = "GET"; |
| 9137 | request2.url = GURL("wss://www.example.org/"); |
| 9138 | request2.traffic_annotation = |
| 9139 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 9140 | EXPECT_TRUE(HostPortPair::FromURL(request_.url) |
| 9141 | .Equals(HostPortPair::FromURL(request2.url))); |
| 9142 | request2.extra_headers.SetHeader("Connection", "Upgrade"); |
| 9143 | request2.extra_headers.SetHeader("Upgrade", "websocket"); |
| 9144 | request2.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 9145 | request2.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
| 9146 | |
| 9147 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 9148 | |
| 9149 | HttpNetworkTransaction trans2(MEDIUM, helper.session()); |
| 9150 | trans2.SetWebSocketHandshakeStreamCreateHelper( |
| 9151 | &websocket_stream_create_helper); |
| 9152 | |
| 9153 | TestCompletionCallback callback2; |
| 9154 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 9155 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 9156 | |
| 9157 | // Run until waiting on both connections. |
| 9158 | base::RunLoop().RunUntilIdle(); |
| 9159 | |
| 9160 | // The H2 connection completes. |
| 9161 | data.socket()->OnConnectComplete(MockConnect(SYNCHRONOUS, OK)); |
| 9162 | EXPECT_EQ(OK, callback1.WaitForResult()); |
| 9163 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
| 9164 | ASSERT_TRUE(response->headers); |
| 9165 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 9166 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 9167 | std::string response_data; |
| 9168 | rv = ReadTransaction(helper.trans(), &response_data); |
| 9169 | EXPECT_THAT(rv, IsOk()); |
| 9170 | EXPECT_EQ("hello!", response_data); |
| 9171 | |
| 9172 | SpdySessionKey key( |
| 9173 | HostPortPair::FromURL(request_.url), |
Eric Orth | 5ccc3f0 | 2021-09-23 00:01:57 | [diff] [blame] | 9174 | ProxyUriToProxyServer("https://proxy:70", ProxyServer::SCHEME_HTTPS), |
Matt Menke | 7269f35 | 2019-10-03 17:05:29 | [diff] [blame] | 9175 | PRIVACY_MODE_DISABLED, SpdySessionKey::IsProxySession::kFalse, |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 9176 | SocketTag(), NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | 7269f35 | 2019-10-03 17:05:29 | [diff] [blame] | 9177 | |
| 9178 | base::WeakPtr<SpdySession> spdy_session = |
| 9179 | helper.session()->spdy_session_pool()->FindAvailableSession( |
| 9180 | key, /* enable_ip_based_pooling = */ true, |
| 9181 | /* is_websocket = */ false, log_); |
| 9182 | ASSERT_TRUE(spdy_session); |
| 9183 | EXPECT_FALSE(spdy_session->support_websocket()); |
| 9184 | |
| 9185 | EXPECT_FALSE(callback2.have_result()); |
| 9186 | |
| 9187 | // Create WebSocket stream. |
| 9188 | data2.socket()->OnConnectComplete(MockConnect(SYNCHRONOUS, OK)); |
| 9189 | |
| 9190 | rv = callback2.WaitForResult(); |
| 9191 | ASSERT_THAT(rv, IsOk()); |
| 9192 | helper.VerifyDataConsumed(); |
| 9193 | } |
| 9194 | |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 9195 | // Same as above, but checks that a WebSocket connection avoids creating a new |
| 9196 | // socket if it detects an H2 session when host resolution completes, and |
| 9197 | // requests also use different hostnames. |
| 9198 | TEST_F(SpdyNetworkTransactionTest, |
| 9199 | WebSocketOverHTTP2DetectsNewSessionWithAliasing) { |
| 9200 | base::HistogramTester histogram_tester; |
| 9201 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 9202 | session_deps->enable_websocket_over_http2 = true; |
| 9203 | session_deps->host_resolver->set_ondemand_mode(true); |
| 9204 | NormalSpdyTransactionHelper helper(request_, HIGHEST, log_, |
| 9205 | std::move(session_deps)); |
| 9206 | helper.RunPreTestSetup(); |
| 9207 | |
| 9208 | spdy::SpdySerializedFrame req( |
| 9209 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, HIGHEST)); |
| 9210 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
| 9211 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 9212 | spdy::Http2HeaderBlock websocket_request_headers; |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 9213 | websocket_request_headers[spdy::kHttp2MethodHeader] = "CONNECT"; |
| 9214 | websocket_request_headers[spdy::kHttp2AuthorityHeader] = "example.test"; |
| 9215 | websocket_request_headers[spdy::kHttp2SchemeHeader] = "https"; |
| 9216 | websocket_request_headers[spdy::kHttp2PathHeader] = "/"; |
| 9217 | websocket_request_headers[spdy::kHttp2ProtocolHeader] = "websocket"; |
| 9218 | websocket_request_headers["origin"] = "http://example.test"; |
| 9219 | websocket_request_headers["sec-websocket-version"] = "13"; |
| 9220 | websocket_request_headers["sec-websocket-extensions"] = |
| 9221 | "permessage-deflate; client_max_window_bits"; |
| 9222 | spdy::SpdySerializedFrame websocket_request(spdy_util_.ConstructSpdyHeaders( |
| 9223 | 3, std::move(websocket_request_headers), MEDIUM, false)); |
| 9224 | |
| 9225 | spdy::SpdySerializedFrame priority1( |
| 9226 | spdy_util_.ConstructSpdyPriority(3, 0, MEDIUM, true)); |
| 9227 | spdy::SpdySerializedFrame priority2( |
| 9228 | spdy_util_.ConstructSpdyPriority(1, 3, LOWEST, true)); |
| 9229 | |
| 9230 | MockWrite writes[] = { |
| 9231 | CreateMockWrite(req, 0), CreateMockWrite(settings_ack, 2), |
| 9232 | CreateMockWrite(websocket_request, 4), CreateMockWrite(priority1, 5), |
| 9233 | CreateMockWrite(priority2, 6)}; |
| 9234 | |
| 9235 | spdy::SettingsMap settings; |
| 9236 | settings[spdy::SETTINGS_ENABLE_CONNECT_PROTOCOL] = 1; |
| 9237 | spdy::SpdySerializedFrame settings_frame( |
| 9238 | spdy_util_.ConstructSpdySettings(settings)); |
| 9239 | spdy::SpdySerializedFrame resp1( |
| 9240 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 9241 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 9242 | spdy::SpdySerializedFrame websocket_response( |
| 9243 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 9244 | MockRead reads[] = {CreateMockRead(settings_frame, 1), |
| 9245 | CreateMockRead(resp1, 3), CreateMockRead(body1, 7), |
| 9246 | CreateMockRead(websocket_response, 8), |
| 9247 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 9)}; |
| 9248 | |
| 9249 | SequencedSocketData data(reads, writes); |
| 9250 | helper.AddData(&data); |
| 9251 | |
| 9252 | TestCompletionCallback callback1; |
| 9253 | int rv = helper.trans()->Start(&request_, callback1.callback(), log_); |
| 9254 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 9255 | |
| 9256 | HttpRequestInfo request2; |
| 9257 | request2.method = "GET"; |
| 9258 | request2.url = GURL("wss://example.test/"); |
| 9259 | request2.traffic_annotation = |
| 9260 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 9261 | request2.extra_headers.SetHeader("Origin", "http://example.test"); |
| 9262 | request2.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
| 9263 | // The following two headers must be removed by WebSocketHttp2HandshakeStream. |
| 9264 | request2.extra_headers.SetHeader("Connection", "Upgrade"); |
| 9265 | request2.extra_headers.SetHeader("Upgrade", "websocket"); |
| 9266 | |
| 9267 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 9268 | |
| 9269 | HttpNetworkTransaction trans2(MEDIUM, helper.session()); |
| 9270 | trans2.SetWebSocketHandshakeStreamCreateHelper( |
| 9271 | &websocket_stream_create_helper); |
| 9272 | |
| 9273 | TestCompletionCallback callback2; |
| 9274 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 9275 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 9276 | |
| 9277 | // Make sure both requests are blocked on host resolution. |
| 9278 | base::RunLoop().RunUntilIdle(); |
| 9279 | |
| 9280 | EXPECT_TRUE(helper.session_deps()->host_resolver->has_pending_requests()); |
| 9281 | // Complete the first DNS lookup, which should result in the first transaction |
| 9282 | // creating an H2 session (And completing successfully). |
| 9283 | helper.session_deps()->host_resolver->ResolveNow(1); |
| 9284 | base::RunLoop().RunUntilIdle(); |
| 9285 | |
| 9286 | SpdySessionKey key1(HostPortPair::FromURL(request_.url), |
| 9287 | ProxyServer::Direct(), PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 9288 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 9289 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 9290 | base::WeakPtr<SpdySession> spdy_session1 = |
| 9291 | helper.session()->spdy_session_pool()->FindAvailableSession( |
| 9292 | key1, /* enable_ip_based_pooling = */ true, |
| 9293 | /* is_websocket = */ false, log_); |
| 9294 | ASSERT_TRUE(spdy_session1); |
| 9295 | EXPECT_TRUE(spdy_session1->support_websocket()); |
| 9296 | |
| 9297 | // Second DNS lookup completes, which results in creating a WebSocket stream. |
| 9298 | helper.session_deps()->host_resolver->ResolveNow(2); |
| 9299 | ASSERT_TRUE(spdy_session1); |
| 9300 | |
| 9301 | SpdySessionKey key2(HostPortPair::FromURL(request2.url), |
| 9302 | ProxyServer::Direct(), PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 9303 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 9304 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 9305 | base::WeakPtr<SpdySession> spdy_session2 = |
| 9306 | helper.session()->spdy_session_pool()->FindAvailableSession( |
| 9307 | key1, /* enable_ip_based_pooling = */ true, |
| 9308 | /* is_websocket = */ true, log_); |
| 9309 | ASSERT_TRUE(spdy_session2); |
| 9310 | EXPECT_EQ(spdy_session1.get(), spdy_session2.get()); |
| 9311 | |
| 9312 | base::RunLoop().RunUntilIdle(); |
| 9313 | |
| 9314 | // First request has HIGHEST priority, WebSocket request has MEDIUM priority. |
| 9315 | // Changing the priority of the first request to LOWEST changes their order, |
| 9316 | // and therefore triggers sending PRIORITY frames. |
| 9317 | helper.trans()->SetPriority(LOWEST); |
| 9318 | |
| 9319 | rv = callback1.WaitForResult(); |
| 9320 | ASSERT_THAT(rv, IsOk()); |
| 9321 | |
| 9322 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
| 9323 | ASSERT_TRUE(response->headers); |
| 9324 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 9325 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 9326 | |
| 9327 | std::string response_data; |
| 9328 | rv = ReadTransaction(helper.trans(), &response_data); |
| 9329 | EXPECT_THAT(rv, IsOk()); |
| 9330 | EXPECT_EQ("hello!", response_data); |
| 9331 | |
| 9332 | rv = callback2.WaitForResult(); |
| 9333 | ASSERT_THAT(rv, IsOk()); |
| 9334 | |
| 9335 | helper.VerifyDataConsumed(); |
| 9336 | } |
| 9337 | |
| 9338 | // Same as above, but the SpdySession is closed just before use, so the |
| 9339 | // WebSocket is sent over a new HTTP/1.x connection instead. |
| 9340 | TEST_F(SpdyNetworkTransactionTest, |
| 9341 | WebSocketOverDetectsNewSessionWithAliasingButClosedBeforeUse) { |
| 9342 | base::HistogramTester histogram_tester; |
| 9343 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 9344 | session_deps->enable_websocket_over_http2 = true; |
| 9345 | session_deps->host_resolver->set_ondemand_mode(true); |
| 9346 | NormalSpdyTransactionHelper helper(request_, HIGHEST, log_, |
| 9347 | std::move(session_deps)); |
| 9348 | helper.RunPreTestSetup(); |
| 9349 | |
| 9350 | spdy::SpdySerializedFrame req( |
| 9351 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, HIGHEST)); |
| 9352 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
| 9353 | |
| 9354 | MockWrite writes[] = {CreateMockWrite(req, 0), |
| 9355 | CreateMockWrite(settings_ack, 2)}; |
| 9356 | |
| 9357 | spdy::SettingsMap settings; |
| 9358 | settings[spdy::SETTINGS_ENABLE_CONNECT_PROTOCOL] = 1; |
| 9359 | spdy::SpdySerializedFrame settings_frame( |
| 9360 | spdy_util_.ConstructSpdySettings(settings)); |
| 9361 | spdy::SpdySerializedFrame resp1( |
| 9362 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 9363 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 9364 | MockRead reads[] = {CreateMockRead(settings_frame, 1), |
| 9365 | CreateMockRead(resp1, 3), CreateMockRead(body1, 4), |
| 9366 | MockRead(SYNCHRONOUS, ERR_IO_PENDING, 5)}; |
| 9367 | |
| 9368 | SequencedSocketData data(reads, writes); |
| 9369 | helper.AddData(&data); |
| 9370 | |
| 9371 | MockWrite writes2[] = { |
| 9372 | MockWrite("GET / HTTP/1.1\r\n" |
| 9373 | "Host: example.test\r\n" |
| 9374 | "Connection: Upgrade\r\n" |
| 9375 | "Upgrade: websocket\r\n" |
| 9376 | "Origin: http://example.test\r\n" |
| 9377 | "Sec-WebSocket-Version: 13\r\n" |
| 9378 | "Sec-WebSocket-Key: dGhlIHNhbXBsZSBub25jZQ==\r\n" |
| 9379 | "Sec-WebSocket-Extensions: permessage-deflate; " |
| 9380 | "client_max_window_bits\r\n\r\n")}; |
| 9381 | MockRead reads2[] = { |
| 9382 | MockRead("HTTP/1.1 101 Switching Protocols\r\n" |
| 9383 | "Upgrade: websocket\r\n" |
| 9384 | "Connection: Upgrade\r\n" |
| 9385 | "Sec-WebSocket-Accept: s3pPLMBiTxaQ9kYGzzhZRbK+xOo=\r\n\r\n")}; |
| 9386 | StaticSocketDataProvider data2(reads2, writes2); |
| 9387 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 9388 | // Test that request has empty |alpn_protos|, that is, HTTP/2 is disabled. |
| 9389 | ssl_provider2->next_protos_expected_in_ssl_config = NextProtoVector{}; |
| 9390 | // Force socket to use HTTP/1.1, the default protocol without ALPN. |
| 9391 | ssl_provider2->next_proto = kProtoHTTP11; |
| 9392 | ssl_provider2->ssl_info.cert = |
| 9393 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
| 9394 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 9395 | |
| 9396 | TestCompletionCallback callback1; |
| 9397 | int rv = helper.trans()->Start(&request_, callback1.callback(), log_); |
| 9398 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 9399 | |
| 9400 | HttpRequestInfo request2; |
| 9401 | request2.method = "GET"; |
| 9402 | request2.url = GURL("wss://example.test/"); |
| 9403 | request2.traffic_annotation = |
| 9404 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 9405 | request2.extra_headers.SetHeader("Connection", "Upgrade"); |
| 9406 | request2.extra_headers.SetHeader("Upgrade", "websocket"); |
| 9407 | request2.extra_headers.SetHeader("Origin", "http://example.test"); |
| 9408 | request2.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
| 9409 | |
| 9410 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 9411 | |
| 9412 | HttpNetworkTransaction trans2(MEDIUM, helper.session()); |
| 9413 | trans2.SetWebSocketHandshakeStreamCreateHelper( |
| 9414 | &websocket_stream_create_helper); |
| 9415 | |
| 9416 | TestCompletionCallback callback2; |
| 9417 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 9418 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 9419 | |
| 9420 | // Make sure both requests are blocked on host resolution. |
| 9421 | base::RunLoop().RunUntilIdle(); |
| 9422 | |
| 9423 | EXPECT_TRUE(helper.session_deps()->host_resolver->has_pending_requests()); |
| 9424 | // Complete the first DNS lookup, which should result in the first transaction |
| 9425 | // creating an H2 session (And completing successfully). |
| 9426 | helper.session_deps()->host_resolver->ResolveNow(1); |
| 9427 | |
| 9428 | // Complete first request. |
| 9429 | rv = callback1.WaitForResult(); |
| 9430 | ASSERT_THAT(rv, IsOk()); |
| 9431 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
| 9432 | ASSERT_TRUE(response->headers); |
| 9433 | EXPECT_TRUE(response->was_fetched_via_spdy); |
| 9434 | EXPECT_EQ("HTTP/1.1 200", response->headers->GetStatusLine()); |
| 9435 | std::string response_data; |
| 9436 | rv = ReadTransaction(helper.trans(), &response_data); |
| 9437 | EXPECT_THAT(rv, IsOk()); |
| 9438 | EXPECT_EQ("hello!", response_data); |
| 9439 | |
| 9440 | SpdySessionKey key1(HostPortPair::FromURL(request_.url), |
| 9441 | ProxyServer::Direct(), PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 9442 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 9443 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 9444 | base::WeakPtr<SpdySession> spdy_session1 = |
| 9445 | helper.session()->spdy_session_pool()->FindAvailableSession( |
| 9446 | key1, /* enable_ip_based_pooling = */ true, |
| 9447 | /* is_websocket = */ false, log_); |
| 9448 | ASSERT_TRUE(spdy_session1); |
| 9449 | EXPECT_TRUE(spdy_session1->support_websocket()); |
| 9450 | |
| 9451 | // Second DNS lookup completes, which results in creating an alias for the |
| 9452 | // SpdySession immediately, and a task is posted asynchronously to use the |
| 9453 | // alias.. |
| 9454 | helper.session_deps()->host_resolver->ResolveNow(2); |
| 9455 | |
| 9456 | SpdySessionKey key2(HostPortPair::FromURL(request2.url), |
| 9457 | ProxyServer::Direct(), PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 9458 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 9459 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | 5062be2 | 2019-05-01 17:50:24 | [diff] [blame] | 9460 | base::WeakPtr<SpdySession> spdy_session2 = |
| 9461 | helper.session()->spdy_session_pool()->FindAvailableSession( |
| 9462 | key1, /* enable_ip_based_pooling = */ true, |
| 9463 | /* is_websocket = */ true, log_); |
| 9464 | ASSERT_TRUE(spdy_session2); |
| 9465 | EXPECT_EQ(spdy_session1.get(), spdy_session2.get()); |
| 9466 | |
| 9467 | // But the session is closed before it can be used. |
| 9468 | helper.session()->spdy_session_pool()->CloseAllSessions(); |
| 9469 | |
| 9470 | // The second request establishes another connection (without even doing |
| 9471 | // another DNS lookup) instead, and uses HTTP/1.x. |
| 9472 | rv = callback2.WaitForResult(); |
| 9473 | ASSERT_THAT(rv, IsOk()); |
| 9474 | |
| 9475 | helper.VerifyDataConsumed(); |
| 9476 | } |
| 9477 | |
Bence Béky | fbeb883 | 2018-04-05 23:19:56 | [diff] [blame] | 9478 | TEST_F(SpdyNetworkTransactionTest, WebSocketNegotiatesHttp2) { |
| 9479 | HttpRequestInfo request; |
| 9480 | request.method = "GET"; |
| 9481 | request.url = GURL("wss://www.example.org/"); |
| 9482 | request.traffic_annotation = |
| 9483 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 9484 | EXPECT_TRUE(HostPortPair::FromURL(request_.url) |
| 9485 | .Equals(HostPortPair::FromURL(request.url))); |
| 9486 | request.extra_headers.SetHeader("Connection", "Upgrade"); |
| 9487 | request.extra_headers.SetHeader("Upgrade", "websocket"); |
| 9488 | request.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 9489 | request.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
| 9490 | |
| 9491 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 9492 | helper.RunPreTestSetup(); |
| 9493 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 9494 | StaticSocketDataProvider data; |
Bence Béky | fbeb883 | 2018-04-05 23:19:56 | [diff] [blame] | 9495 | |
| 9496 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 9497 | // Test that request has empty |alpn_protos|, that is, HTTP/2 is disabled. |
| 9498 | ssl_provider->next_protos_expected_in_ssl_config = NextProtoVector{}; |
Bence Béky | b4a07f8f | 2018-05-17 14:31:55 | [diff] [blame] | 9499 | // Force socket to use HTTP/2, which should never happen (TLS implementation |
| 9500 | // should fail TLS handshake if server chooses HTTP/2 without client |
| 9501 | // advertising support). |
Bence Béky | fbeb883 | 2018-04-05 23:19:56 | [diff] [blame] | 9502 | ssl_provider->next_proto = kProtoHTTP2; |
| 9503 | ssl_provider->ssl_info.cert = |
| 9504 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
| 9505 | helper.AddDataWithSSLSocketDataProvider(&data, std::move(ssl_provider)); |
| 9506 | |
| 9507 | HttpNetworkTransaction* trans = helper.trans(); |
| 9508 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 9509 | trans->SetWebSocketHandshakeStreamCreateHelper( |
| 9510 | &websocket_stream_create_helper); |
| 9511 | |
| 9512 | TestCompletionCallback callback; |
| 9513 | int rv = trans->Start(&request, callback.callback(), log_); |
| 9514 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 9515 | rv = callback.WaitForResult(); |
| 9516 | ASSERT_THAT(rv, IsError(ERR_NOT_IMPLEMENTED)); |
| 9517 | |
| 9518 | helper.VerifyDataConsumed(); |
| 9519 | } |
| 9520 | |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 9521 | TEST_F(SpdyNetworkTransactionTest, WebSocketHttp11Required) { |
| 9522 | base::HistogramTester histogram_tester; |
| 9523 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 9524 | session_deps->enable_websocket_over_http2 = true; |
| 9525 | NormalSpdyTransactionHelper helper(request_, HIGHEST, log_, |
| 9526 | std::move(session_deps)); |
| 9527 | helper.RunPreTestSetup(); |
| 9528 | |
| 9529 | spdy::SpdySerializedFrame req( |
| 9530 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, HIGHEST)); |
| 9531 | spdy::SpdySerializedFrame settings_ack(spdy_util_.ConstructSpdySettingsAck()); |
| 9532 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 9533 | spdy::Http2HeaderBlock websocket_request_headers; |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 9534 | websocket_request_headers[spdy::kHttp2MethodHeader] = "CONNECT"; |
| 9535 | websocket_request_headers[spdy::kHttp2AuthorityHeader] = "www.example.org"; |
| 9536 | websocket_request_headers[spdy::kHttp2SchemeHeader] = "https"; |
| 9537 | websocket_request_headers[spdy::kHttp2PathHeader] = "/"; |
| 9538 | websocket_request_headers[spdy::kHttp2ProtocolHeader] = "websocket"; |
| 9539 | websocket_request_headers["origin"] = "http://www.example.org"; |
| 9540 | websocket_request_headers["sec-websocket-version"] = "13"; |
| 9541 | websocket_request_headers["sec-websocket-extensions"] = |
| 9542 | "permessage-deflate; client_max_window_bits"; |
| 9543 | spdy::SpdySerializedFrame websocket_request(spdy_util_.ConstructSpdyHeaders( |
| 9544 | 3, std::move(websocket_request_headers), MEDIUM, false)); |
| 9545 | |
| 9546 | spdy::SpdySerializedFrame priority1( |
| 9547 | spdy_util_.ConstructSpdyPriority(3, 0, MEDIUM, true)); |
| 9548 | spdy::SpdySerializedFrame priority2( |
| 9549 | spdy_util_.ConstructSpdyPriority(1, 3, LOWEST, true)); |
| 9550 | |
| 9551 | MockWrite writes1[] = {CreateMockWrite(req, 0), |
| 9552 | CreateMockWrite(settings_ack, 2), |
| 9553 | CreateMockWrite(websocket_request, 4)}; |
| 9554 | |
| 9555 | spdy::SettingsMap settings; |
| 9556 | settings[spdy::SETTINGS_ENABLE_CONNECT_PROTOCOL] = 1; |
| 9557 | spdy::SpdySerializedFrame settings_frame( |
| 9558 | spdy_util_.ConstructSpdySettings(settings)); |
| 9559 | spdy::SpdySerializedFrame resp1( |
| 9560 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 9561 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 9562 | spdy::SpdySerializedFrame websocket_response_http11_required( |
| 9563 | spdy_util_.ConstructSpdyRstStream(3, spdy::ERROR_CODE_HTTP_1_1_REQUIRED)); |
| 9564 | MockRead reads1[] = {CreateMockRead(settings_frame, 1), |
| 9565 | CreateMockRead(resp1, 3), |
| 9566 | CreateMockRead(websocket_response_http11_required, 5)}; |
| 9567 | |
| 9568 | SequencedSocketData data1(reads1, writes1); |
| 9569 | helper.AddData(&data1); |
| 9570 | |
| 9571 | MockWrite writes2[] = { |
| 9572 | MockWrite("GET / HTTP/1.1\r\n" |
| 9573 | "Host: www.example.org\r\n" |
| 9574 | "Connection: Upgrade\r\n" |
| 9575 | "Origin: http://www.example.org\r\n" |
| 9576 | "Sec-WebSocket-Version: 13\r\n" |
| 9577 | "Upgrade: websocket\r\n" |
| 9578 | "Sec-WebSocket-Key: dGhlIHNhbXBsZSBub25jZQ==\r\n" |
| 9579 | "Sec-WebSocket-Extensions: permessage-deflate; " |
| 9580 | "client_max_window_bits\r\n\r\n")}; |
| 9581 | MockRead reads2[] = { |
| 9582 | MockRead("HTTP/1.1 101 Switching Protocols\r\n" |
| 9583 | "Upgrade: websocket\r\n" |
| 9584 | "Connection: Upgrade\r\n" |
| 9585 | "Sec-WebSocket-Accept: s3pPLMBiTxaQ9kYGzzhZRbK+xOo=\r\n\r\n")}; |
| 9586 | StaticSocketDataProvider data2(reads2, writes2); |
| 9587 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 9588 | // Test that request has empty |alpn_protos|, that is, HTTP/2 is disabled. |
| 9589 | ssl_provider2->next_protos_expected_in_ssl_config = NextProtoVector{}; |
| 9590 | // Force socket to use HTTP/1.1, the default protocol without ALPN. |
| 9591 | ssl_provider2->next_proto = kProtoHTTP11; |
| 9592 | ssl_provider2->ssl_info.cert = |
| 9593 | ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem"); |
| 9594 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 9595 | |
| 9596 | // Create HTTP/2 connection. |
| 9597 | TestCompletionCallback callback1; |
| 9598 | int rv = helper.trans()->Start(&request_, callback1.callback(), log_); |
| 9599 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 9600 | |
| 9601 | // Create HTTP/2 connection. |
| 9602 | base::RunLoop().RunUntilIdle(); |
| 9603 | |
| 9604 | SpdySessionKey key(HostPortPair::FromURL(request_.url), ProxyServer::Direct(), |
| 9605 | PRIVACY_MODE_DISABLED, |
dalyk | 51ab46b | 2019-10-15 15:14:34 | [diff] [blame] | 9606 | SpdySessionKey::IsProxySession::kFalse, SocketTag(), |
Ben Schwartz | 3ff4dc1e6 | 2021-04-27 21:15:23 | [diff] [blame] | 9607 | NetworkIsolationKey(), SecureDnsPolicy::kAllow); |
Matt Menke | f2ee07c | 2019-08-29 02:10:36 | [diff] [blame] | 9608 | base::WeakPtr<SpdySession> spdy_session = |
| 9609 | helper.session()->spdy_session_pool()->FindAvailableSession( |
| 9610 | key, /* enable_ip_based_pooling = */ true, |
| 9611 | /* is_websocket = */ true, log_); |
| 9612 | ASSERT_TRUE(spdy_session); |
| 9613 | EXPECT_TRUE(spdy_session->support_websocket()); |
| 9614 | |
| 9615 | HttpRequestInfo request2; |
| 9616 | request2.method = "GET"; |
| 9617 | request2.url = GURL("wss://www.example.org/"); |
| 9618 | request2.traffic_annotation = |
| 9619 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 9620 | EXPECT_TRUE(HostPortPair::FromURL(request_.url) |
| 9621 | .Equals(HostPortPair::FromURL(request2.url))); |
| 9622 | request2.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 9623 | request2.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
| 9624 | // The following two headers must be removed by WebSocketHttp2HandshakeStream. |
| 9625 | request2.extra_headers.SetHeader("Connection", "Upgrade"); |
| 9626 | request2.extra_headers.SetHeader("Upgrade", "websocket"); |
| 9627 | |
| 9628 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 9629 | |
| 9630 | HttpNetworkTransaction trans2(MEDIUM, helper.session()); |
| 9631 | trans2.SetWebSocketHandshakeStreamCreateHelper( |
| 9632 | &websocket_stream_create_helper); |
| 9633 | |
| 9634 | TestCompletionCallback callback2; |
| 9635 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 9636 | EXPECT_THAT(callback2.GetResult(rv), IsOk()); |
| 9637 | |
| 9638 | helper.VerifyDataConsumed(); |
| 9639 | |
| 9640 | // Server advertised WebSocket support. |
| 9641 | histogram_tester.ExpectUniqueSample("Net.SpdySession.ServerSupportsWebSocket", |
| 9642 | /* support_websocket = true */ 1, |
| 9643 | /* expected_count = */ 1); |
| 9644 | } |
| 9645 | |
David Benjamin | 7c6df0b76 | 2021-12-23 21:02:54 | [diff] [blame] | 9646 | // When using an HTTP(S) proxy, plaintext WebSockets use CONNECT tunnels. This |
| 9647 | // should work for HTTP/2 proxies. |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9648 | TEST_F(SpdyNetworkTransactionTest, PlaintextWebSocketOverHttp2Proxy) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 9649 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyConnect( |
Matt Menke | 6e879bd | 2019-03-18 17:26:04 | [diff] [blame] | 9650 | nullptr, 0, 1, HttpProxyConnectJob::kH2QuicTunnelPriority, |
| 9651 | HostPortPair("www.example.org", 80))); |
David Benjamin | 7c6df0b76 | 2021-12-23 21:02:54 | [diff] [blame] | 9652 | const char kWebSocketRequest[] = |
| 9653 | "GET / HTTP/1.1\r\n" |
| 9654 | "Host: www.example.org\r\n" |
| 9655 | "Connection: Upgrade\r\n" |
| 9656 | "Upgrade: websocket\r\n" |
| 9657 | "Origin: http://www.example.org\r\n" |
| 9658 | "Sec-WebSocket-Version: 13\r\n" |
| 9659 | "Sec-WebSocket-Key: dGhlIHNhbXBsZSBub25jZQ==\r\n" |
| 9660 | "Sec-WebSocket-Extensions: permessage-deflate; " |
| 9661 | "client_max_window_bits\r\n\r\n"; |
| 9662 | spdy::SpdySerializedFrame websocket_request(spdy_util_.ConstructSpdyDataFrame( |
| 9663 | /*stream_id=*/1, kWebSocketRequest, /*fin=*/false)); |
| 9664 | MockWrite writes[] = {CreateMockWrite(req, 0), |
| 9665 | CreateMockWrite(websocket_request, 2)}; |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9666 | |
David Benjamin | 7c6df0b76 | 2021-12-23 21:02:54 | [diff] [blame] | 9667 | spdy::SpdySerializedFrame connect_response( |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 9668 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
David Benjamin | 7c6df0b76 | 2021-12-23 21:02:54 | [diff] [blame] | 9669 | const char kWebSocketResponse[] = |
| 9670 | "HTTP/1.1 101 Switching Protocols\r\n" |
| 9671 | "Upgrade: websocket\r\n" |
| 9672 | "Connection: Upgrade\r\n" |
| 9673 | "Sec-WebSocket-Accept: s3pPLMBiTxaQ9kYGzzhZRbK+xOo=\r\n\r\n"; |
| 9674 | spdy::SpdySerializedFrame websocket_response( |
| 9675 | spdy_util_.ConstructSpdyDataFrame(/*stream_id=*/1, kWebSocketResponse, |
| 9676 | /*fin=*/false)); |
| 9677 | MockRead reads[] = {CreateMockRead(connect_response, 1), |
| 9678 | CreateMockRead(websocket_response, 3), |
| 9679 | MockRead(ASYNC, 0, 4)}; |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9680 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 9681 | SequencedSocketData data(reads, writes); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9682 | |
| 9683 | request_.url = GURL("ws://www.example.org/"); |
David Benjamin | 7c6df0b76 | 2021-12-23 21:02:54 | [diff] [blame] | 9684 | request_.extra_headers.SetHeader("Connection", "Upgrade"); |
| 9685 | request_.extra_headers.SetHeader("Upgrade", "websocket"); |
| 9686 | request_.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 9687 | request_.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9688 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Nicolas Arciniega | d2013f9 | 2020-02-07 23:00:56 | [diff] [blame] | 9689 | ConfiguredProxyResolutionService::CreateFixed( |
| 9690 | "https://proxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9691 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 9692 | std::move(session_deps)); |
| 9693 | helper.RunPreTestSetup(); |
| 9694 | helper.AddData(&data); |
| 9695 | |
| 9696 | HttpNetworkTransaction* trans = helper.trans(); |
| 9697 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 9698 | trans->SetWebSocketHandshakeStreamCreateHelper( |
| 9699 | &websocket_stream_create_helper); |
| 9700 | |
| 9701 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 9702 | helper.WaitForCallbackToComplete(); |
David Benjamin | 7c6df0b76 | 2021-12-23 21:02:54 | [diff] [blame] | 9703 | EXPECT_THAT(helper.output().rv, IsOk()); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9704 | |
Bence Béky | 6434d5e | 2018-04-03 13:43:11 | [diff] [blame] | 9705 | base::RunLoop().RunUntilIdle(); |
Bence Béky | 6434d5e | 2018-04-03 13:43:11 | [diff] [blame] | 9706 | helper.VerifyDataConsumed(); |
| 9707 | } |
| 9708 | |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9709 | TEST_F(SpdyNetworkTransactionTest, SecureWebSocketOverHttp2Proxy) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 9710 | spdy::SpdySerializedFrame connect_request(spdy_util_.ConstructSpdyConnect( |
Matt Menke | 6e879bd | 2019-03-18 17:26:04 | [diff] [blame] | 9711 | nullptr, 0, 1, HttpProxyConnectJob::kH2QuicTunnelPriority, |
| 9712 | HostPortPair("www.example.org", 443))); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9713 | const char kWebSocketRequest[] = |
| 9714 | "GET / HTTP/1.1\r\n" |
| 9715 | "Host: www.example.org\r\n" |
| 9716 | "Connection: Upgrade\r\n" |
| 9717 | "Upgrade: websocket\r\n" |
| 9718 | "Origin: http://www.example.org\r\n" |
| 9719 | "Sec-WebSocket-Version: 13\r\n" |
| 9720 | "Sec-WebSocket-Key: dGhlIHNhbXBsZSBub25jZQ==\r\n" |
| 9721 | "Sec-WebSocket-Extensions: permessage-deflate; " |
| 9722 | "client_max_window_bits\r\n\r\n"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 9723 | spdy::SpdySerializedFrame websocket_request( |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9724 | spdy_util_.ConstructSpdyDataFrame(1, kWebSocketRequest, false)); |
| 9725 | MockWrite writes[] = {CreateMockWrite(connect_request, 0), |
| 9726 | CreateMockWrite(websocket_request, 2)}; |
| 9727 | |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 9728 | spdy::SpdySerializedFrame connect_response( |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9729 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 9730 | const char kWebSocketResponse[] = |
| 9731 | "HTTP/1.1 101 Switching Protocols\r\n" |
| 9732 | "Upgrade: websocket\r\n" |
| 9733 | "Connection: Upgrade\r\n" |
| 9734 | "Sec-WebSocket-Accept: s3pPLMBiTxaQ9kYGzzhZRbK+xOo=\r\n\r\n"; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 9735 | spdy::SpdySerializedFrame websocket_response( |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9736 | spdy_util_.ConstructSpdyDataFrame(1, kWebSocketResponse, false)); |
| 9737 | MockRead reads[] = {CreateMockRead(connect_response, 1), |
| 9738 | CreateMockRead(websocket_response, 3), |
| 9739 | MockRead(ASYNC, 0, 4)}; |
| 9740 | |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 9741 | SequencedSocketData data(reads, writes); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9742 | |
| 9743 | request_.url = GURL("wss://www.example.org/"); |
| 9744 | request_.extra_headers.SetHeader("Connection", "Upgrade"); |
| 9745 | request_.extra_headers.SetHeader("Upgrade", "websocket"); |
| 9746 | request_.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 9747 | request_.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
| 9748 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Nicolas Arciniega | d2013f9 | 2020-02-07 23:00:56 | [diff] [blame] | 9749 | ConfiguredProxyResolutionService::CreateFixed( |
| 9750 | "https://proxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9751 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 9752 | std::move(session_deps)); |
| 9753 | helper.RunPreTestSetup(); |
| 9754 | helper.AddData(&data); |
| 9755 | |
| 9756 | // Add SSL data for the tunneled connection. |
| 9757 | SSLSocketDataProvider ssl_provider(ASYNC, OK); |
| 9758 | ssl_provider.ssl_info.cert = |
| 9759 | ImportCertFromFile(GetTestCertsDirectory(), "wildcard.pem"); |
Bence Béky | 12943c6 | 2018-04-05 19:16:50 | [diff] [blame] | 9760 | // A WebSocket request should not advertise HTTP/2 support. |
| 9761 | ssl_provider.next_protos_expected_in_ssl_config = NextProtoVector{}; |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9762 | // This test uses WebSocket over HTTP/1.1. |
| 9763 | ssl_provider.next_proto = kProtoHTTP11; |
| 9764 | helper.session_deps()->socket_factory->AddSSLSocketDataProvider( |
| 9765 | &ssl_provider); |
| 9766 | |
| 9767 | HttpNetworkTransaction* trans = helper.trans(); |
| 9768 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 9769 | trans->SetWebSocketHandshakeStreamCreateHelper( |
| 9770 | &websocket_stream_create_helper); |
| 9771 | |
| 9772 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 9773 | helper.WaitForCallbackToComplete(); |
| 9774 | EXPECT_THAT(helper.output().rv, IsOk()); |
| 9775 | const HttpResponseInfo* response = trans->GetResponseInfo(); |
| 9776 | ASSERT_TRUE(response); |
| 9777 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP1_1, |
| 9778 | response->connection_info); |
| 9779 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 9780 | EXPECT_FALSE(response->was_fetched_via_spdy); |
Tsuyoshi Horo | 01faed6 | 2019-02-20 22:11:37 | [diff] [blame] | 9781 | EXPECT_EQ(70, response->remote_endpoint.port()); |
Bence Béky | 420bb2d | 2018-03-30 17:25:26 | [diff] [blame] | 9782 | ASSERT_TRUE(response->headers); |
| 9783 | EXPECT_EQ("HTTP/1.1 101 Switching Protocols", |
| 9784 | response->headers->GetStatusLine()); |
| 9785 | |
| 9786 | base::RunLoop().RunUntilIdle(); |
| 9787 | helper.VerifyDataConsumed(); |
| 9788 | } |
| 9789 | |
Bence Béky | 12943c6 | 2018-04-05 19:16:50 | [diff] [blame] | 9790 | // Regression test for https://crbug.com/828865. |
| 9791 | TEST_F(SpdyNetworkTransactionTest, |
| 9792 | SecureWebSocketOverHttp2ProxyNegotiatesHttp2) { |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 9793 | spdy::SpdySerializedFrame connect_request(spdy_util_.ConstructSpdyConnect( |
Matt Menke | 6e879bd | 2019-03-18 17:26:04 | [diff] [blame] | 9794 | nullptr, 0, 1, HttpProxyConnectJob::kH2QuicTunnelPriority, |
| 9795 | HostPortPair("www.example.org", 443))); |
Bence Béky | 12943c6 | 2018-04-05 19:16:50 | [diff] [blame] | 9796 | MockWrite writes[] = {CreateMockWrite(connect_request, 0)}; |
Ryan Hamilton | 0239aac | 2018-05-19 00:03:13 | [diff] [blame] | 9797 | spdy::SpdySerializedFrame connect_response( |
Bence Béky | 12943c6 | 2018-04-05 19:16:50 | [diff] [blame] | 9798 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 9799 | MockRead reads[] = {CreateMockRead(connect_response, 1), |
| 9800 | MockRead(ASYNC, 0, 2)}; |
Ryan Sleevi | b8d7ea0 | 2018-05-07 20:01:01 | [diff] [blame] | 9801 | SequencedSocketData data(reads, writes); |
Bence Béky | 12943c6 | 2018-04-05 19:16:50 | [diff] [blame] | 9802 | |
| 9803 | request_.url = GURL("wss://www.example.org/"); |
| 9804 | request_.extra_headers.SetHeader("Connection", "Upgrade"); |
| 9805 | request_.extra_headers.SetHeader("Upgrade", "websocket"); |
| 9806 | request_.extra_headers.SetHeader("Origin", "http://www.example.org"); |
| 9807 | request_.extra_headers.SetHeader("Sec-WebSocket-Version", "13"); |
| 9808 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Nicolas Arciniega | d2013f9 | 2020-02-07 23:00:56 | [diff] [blame] | 9809 | ConfiguredProxyResolutionService::CreateFixed( |
| 9810 | "https://proxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
Bence Béky | 12943c6 | 2018-04-05 19:16:50 | [diff] [blame] | 9811 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 9812 | std::move(session_deps)); |
| 9813 | helper.RunPreTestSetup(); |
| 9814 | helper.AddData(&data); |
| 9815 | |
| 9816 | // Add SSL data for the tunneled connection. |
| 9817 | SSLSocketDataProvider ssl_provider(ASYNC, OK); |
| 9818 | ssl_provider.ssl_info.cert = |
| 9819 | ImportCertFromFile(GetTestCertsDirectory(), "wildcard.pem"); |
| 9820 | // A WebSocket request should not advertise HTTP/2 support. |
| 9821 | ssl_provider.next_protos_expected_in_ssl_config = NextProtoVector{}; |
| 9822 | // The server should not negotiate HTTP/2 over the tunnelled connection, |
| 9823 | // but it must be handled gracefully if it does. |
| 9824 | ssl_provider.next_proto = kProtoHTTP2; |
| 9825 | helper.session_deps()->socket_factory->AddSSLSocketDataProvider( |
| 9826 | &ssl_provider); |
| 9827 | |
| 9828 | HttpNetworkTransaction* trans = helper.trans(); |
| 9829 | TestWebSocketHandshakeStreamCreateHelper websocket_stream_create_helper; |
| 9830 | trans->SetWebSocketHandshakeStreamCreateHelper( |
| 9831 | &websocket_stream_create_helper); |
| 9832 | |
| 9833 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 9834 | helper.WaitForCallbackToComplete(); |
| 9835 | EXPECT_THAT(helper.output().rv, IsError(ERR_NOT_IMPLEMENTED)); |
| 9836 | |
| 9837 | base::RunLoop().RunUntilIdle(); |
| 9838 | helper.VerifyDataConsumed(); |
| 9839 | } |
| 9840 | |
Bence Béky | 0ca719f | 2018-01-31 13:41:19 | [diff] [blame] | 9841 | #endif // BUILDFLAG(ENABLE_WEBSOCKETS) |
| 9842 | |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 9843 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTDoesntConfirm) { |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 9844 | static const base::TimeDelta kDelay = base::Milliseconds(10); |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 9845 | spdy::SpdySerializedFrame req( |
| 9846 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 9847 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 9848 | |
| 9849 | spdy::SpdySerializedFrame resp( |
| 9850 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 9851 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 9852 | MockRead reads[] = { |
| 9853 | CreateMockRead(resp, 1), CreateMockRead(body, 2), |
| 9854 | MockRead(ASYNC, 0, 3) // EOF |
| 9855 | }; |
| 9856 | |
| 9857 | SequencedSocketData data(reads, writes); |
| 9858 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 9859 | session_deps->enable_early_data = true; |
| 9860 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 9861 | std::move(session_deps)); |
| 9862 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
David Benjamin | bae08ba | 2019-10-18 21:06:15 | [diff] [blame] | 9863 | ssl_provider->connect_callback = FastForwardByCallback(kDelay); |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 9864 | // Configure |ssl_provider| to fail if ConfirmHandshake is called. The request |
| 9865 | // should still succeed. |
| 9866 | ssl_provider->confirm = MockConfirm(SYNCHRONOUS, ERR_SSL_PROTOCOL_ERROR); |
David Benjamin | bae08ba | 2019-10-18 21:06:15 | [diff] [blame] | 9867 | ssl_provider->confirm_callback = FastForwardByCallback(kDelay); |
| 9868 | base::TimeTicks start_time = base::TimeTicks::Now(); |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 9869 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
| 9870 | TransactionHelperResult out = helper.output(); |
| 9871 | EXPECT_THAT(out.rv, IsOk()); |
| 9872 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 9873 | EXPECT_EQ("hello!", out.response_data); |
David Benjamin | bae08ba | 2019-10-18 21:06:15 | [diff] [blame] | 9874 | |
| 9875 | // The handshake time should include the time it took to run Connect(), but |
| 9876 | // not ConfirmHandshake(). |
| 9877 | LoadTimingInfo load_timing_info; |
| 9878 | EXPECT_TRUE(helper.trans()->GetLoadTimingInfo(&load_timing_info)); |
| 9879 | EXPECT_EQ(load_timing_info.connect_timing.connect_start, start_time); |
| 9880 | EXPECT_EQ(load_timing_info.connect_timing.ssl_start, start_time); |
| 9881 | EXPECT_EQ(load_timing_info.connect_timing.ssl_end, start_time + kDelay); |
| 9882 | EXPECT_EQ(load_timing_info.connect_timing.connect_end, start_time + kDelay); |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 9883 | } |
| 9884 | |
| 9885 | // Run multiple concurrent streams that don't require handshake confirmation. |
| 9886 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTNoConfirmMultipleStreams) { |
| 9887 | spdy::SpdySerializedFrame req1( |
| 9888 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST)); |
| 9889 | spdy::SpdySerializedFrame req2( |
| 9890 | spdy_util_.ConstructSpdyGet(nullptr, 0, 3, LOWEST)); |
| 9891 | MockWrite writes1[] = {CreateMockWrite(req1, 0), CreateMockWrite(req2, 3)}; |
| 9892 | |
| 9893 | spdy::SpdySerializedFrame resp1( |
| 9894 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 9895 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 9896 | spdy::SpdySerializedFrame resp2( |
| 9897 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 9898 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 9899 | MockRead reads1[] = { |
| 9900 | CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 9901 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 9902 | MockRead(ASYNC, 0, 6) // EOF |
| 9903 | }; |
| 9904 | |
| 9905 | SequencedSocketData data1(reads1, writes1); |
| 9906 | SequencedSocketData data2({}, {}); |
| 9907 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 9908 | session_deps->enable_early_data = true; |
| 9909 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 9910 | std::move(session_deps)); |
| 9911 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 9912 | ssl_provider1->confirm = MockConfirm(SYNCHRONOUS, ERR_SSL_PROTOCOL_ERROR); |
| 9913 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 9914 | ssl_provider2->confirm = MockConfirm(SYNCHRONOUS, ERR_SSL_PROTOCOL_ERROR); |
| 9915 | |
| 9916 | helper.RunPreTestSetup(); |
| 9917 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
| 9918 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 9919 | EXPECT_TRUE(helper.StartDefaultTest()); |
| 9920 | |
| 9921 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 9922 | HttpRequestInfo request2; |
| 9923 | request2.method = "GET"; |
| 9924 | request2.url = GURL(kDefaultUrl); |
| 9925 | request2.traffic_annotation = |
| 9926 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 9927 | TestCompletionCallback callback2; |
| 9928 | int rv = trans2.Start(&request2, callback2.callback(), log_); |
| 9929 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 9930 | |
| 9931 | helper.FinishDefaultTest(); |
| 9932 | EXPECT_THAT(callback2.GetResult(ERR_IO_PENDING), IsOk()); |
| 9933 | helper.VerifyDataConsumed(); |
| 9934 | |
| 9935 | TransactionHelperResult out = helper.output(); |
| 9936 | EXPECT_THAT(out.rv, IsOk()); |
| 9937 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 9938 | EXPECT_EQ("hello!", out.response_data); |
| 9939 | } |
| 9940 | |
| 9941 | // Run multiple concurrent streams that require handshake confirmation. |
| 9942 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTConfirmMultipleStreams) { |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 9943 | spdy::Http2HeaderBlock req_block1( |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 9944 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, 0)); |
| 9945 | spdy::SpdySerializedFrame req1( |
| 9946 | spdy_util_.ConstructSpdyHeaders(1, std::move(req_block1), LOWEST, true)); |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 9947 | spdy::Http2HeaderBlock req_block2( |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 9948 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, 0)); |
| 9949 | spdy::SpdySerializedFrame req2( |
| 9950 | spdy_util_.ConstructSpdyHeaders(3, std::move(req_block2), LOWEST, true)); |
| 9951 | MockWrite writes[] = { |
| 9952 | CreateMockWrite(req1, 0), |
| 9953 | CreateMockWrite(req2, 3), |
| 9954 | }; |
| 9955 | spdy::SpdySerializedFrame resp1( |
| 9956 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 9957 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 9958 | spdy::SpdySerializedFrame resp2( |
| 9959 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 9960 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 9961 | MockRead reads[] = { |
| 9962 | CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 9963 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 9964 | MockRead(ASYNC, 0, 6) // EOF |
| 9965 | }; |
| 9966 | |
| 9967 | SequencedSocketData data1(reads, writes); |
| 9968 | SequencedSocketData data2({}, {}); |
| 9969 | UsePostRequest(); |
| 9970 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 9971 | session_deps->enable_early_data = true; |
| 9972 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 9973 | std::move(session_deps)); |
| 9974 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 9975 | ssl_provider1->confirm = MockConfirm(ASYNC, OK); |
| 9976 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 9977 | ssl_provider2->confirm = MockConfirm(ASYNC, OK); |
| 9978 | |
| 9979 | helper.RunPreTestSetup(); |
| 9980 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
| 9981 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 9982 | |
| 9983 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 9984 | HttpRequestInfo request1; |
| 9985 | request1.method = "POST"; |
| 9986 | request1.url = GURL(kDefaultUrl); |
| 9987 | request1.traffic_annotation = |
| 9988 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 9989 | TestCompletionCallback callback1; |
| 9990 | int rv = trans1.Start(&request1, callback1.callback(), log_); |
| 9991 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 9992 | |
| 9993 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 9994 | HttpRequestInfo request2; |
| 9995 | request2.method = "POST"; |
| 9996 | request2.url = GURL(kDefaultUrl); |
| 9997 | request2.traffic_annotation = |
| 9998 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 9999 | TestCompletionCallback callback2; |
| 10000 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 10001 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 10002 | |
| 10003 | EXPECT_THAT(callback1.GetResult(ERR_IO_PENDING), IsOk()); |
| 10004 | EXPECT_THAT(callback2.GetResult(ERR_IO_PENDING), IsOk()); |
| 10005 | |
| 10006 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
| 10007 | ASSERT_TRUE(response1); |
| 10008 | ASSERT_TRUE(response1->headers); |
| 10009 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 10010 | response1->connection_info); |
| 10011 | EXPECT_EQ("HTTP/1.1 200", response1->headers->GetStatusLine()); |
| 10012 | std::string response_data; |
| 10013 | ReadTransaction(&trans1, &response_data); |
| 10014 | EXPECT_EQ("hello!", response_data); |
| 10015 | |
| 10016 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
| 10017 | ASSERT_TRUE(response2); |
| 10018 | ASSERT_TRUE(response2->headers); |
| 10019 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 10020 | response2->connection_info); |
| 10021 | EXPECT_EQ("HTTP/1.1 200", response2->headers->GetStatusLine()); |
| 10022 | ReadTransaction(&trans2, &response_data); |
| 10023 | EXPECT_EQ("hello!", response_data); |
| 10024 | |
| 10025 | helper.VerifyDataConsumed(); |
| 10026 | } |
| 10027 | |
| 10028 | // Run multiple concurrent streams, the first require a confirmation and the |
| 10029 | // second not requiring confirmation. |
| 10030 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTConfirmNoConfirmStreams) { |
| 10031 | // This test orders the writes such that the GET (no confirmation) is written |
| 10032 | // before the POST (confirmation required). |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 10033 | spdy::Http2HeaderBlock req_block1( |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 10034 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 10035 | spdy::SpdySerializedFrame req1( |
| 10036 | spdy_util_.ConstructSpdyHeaders(1, std::move(req_block1), LOWEST, true)); |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 10037 | spdy::Http2HeaderBlock req_block2( |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 10038 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, 0)); |
| 10039 | spdy::SpdySerializedFrame req2( |
| 10040 | spdy_util_.ConstructSpdyHeaders(3, std::move(req_block2), LOWEST, true)); |
| 10041 | MockWrite writes[] = { |
| 10042 | CreateMockWrite(req1, 0), |
| 10043 | CreateMockWrite(req2, 3), |
| 10044 | }; |
| 10045 | spdy::SpdySerializedFrame resp1( |
| 10046 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 10047 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10048 | spdy::SpdySerializedFrame resp2( |
| 10049 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 10050 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 10051 | MockRead reads[] = { |
| 10052 | CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 10053 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 10054 | MockRead(ASYNC, 0, 6) // EOF |
| 10055 | }; |
| 10056 | |
| 10057 | SequencedSocketData data1(reads, writes); |
| 10058 | SequencedSocketData data2({}, {}); |
| 10059 | UsePostRequest(); |
| 10060 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10061 | session_deps->enable_early_data = true; |
| 10062 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10063 | std::move(session_deps)); |
| 10064 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 10065 | ssl_provider1->confirm = MockConfirm(ASYNC, OK); |
| 10066 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 10067 | ssl_provider2->confirm = MockConfirm(ASYNC, OK); |
| 10068 | |
| 10069 | helper.RunPreTestSetup(); |
| 10070 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
| 10071 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 10072 | |
| 10073 | // TODO(https://crbug.com/949724): Explicitly verify the ordering of |
| 10074 | // ConfirmHandshake and the second stream. |
| 10075 | |
| 10076 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 10077 | HttpRequestInfo request1; |
| 10078 | request1.method = "POST"; |
| 10079 | request1.url = GURL(kDefaultUrl); |
| 10080 | request1.traffic_annotation = |
| 10081 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 10082 | TestCompletionCallback callback1; |
| 10083 | int rv = trans1.Start(&request1, callback1.callback(), log_); |
| 10084 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 10085 | |
| 10086 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 10087 | HttpRequestInfo request2; |
| 10088 | request2.method = "GET"; |
| 10089 | request2.url = GURL(kDefaultUrl); |
| 10090 | request2.traffic_annotation = |
| 10091 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 10092 | TestCompletionCallback callback2; |
| 10093 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 10094 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 10095 | |
| 10096 | EXPECT_THAT(callback1.GetResult(ERR_IO_PENDING), IsOk()); |
| 10097 | EXPECT_THAT(callback2.GetResult(ERR_IO_PENDING), IsOk()); |
| 10098 | |
| 10099 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
| 10100 | ASSERT_TRUE(response1); |
| 10101 | ASSERT_TRUE(response1->headers); |
| 10102 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 10103 | response1->connection_info); |
| 10104 | EXPECT_EQ("HTTP/1.1 200", response1->headers->GetStatusLine()); |
| 10105 | std::string response_data; |
| 10106 | ReadTransaction(&trans1, &response_data); |
| 10107 | EXPECT_EQ("hello!", response_data); |
| 10108 | |
| 10109 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
| 10110 | ASSERT_TRUE(response2); |
| 10111 | ASSERT_TRUE(response2->headers); |
| 10112 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 10113 | response2->connection_info); |
| 10114 | EXPECT_EQ("HTTP/1.1 200", response2->headers->GetStatusLine()); |
| 10115 | ReadTransaction(&trans2, &response_data); |
| 10116 | EXPECT_EQ("hello!", response_data); |
| 10117 | |
| 10118 | helper.VerifyDataConsumed(); |
| 10119 | } |
| 10120 | |
| 10121 | // Run multiple concurrent streams, the first not requiring confirmation and the |
| 10122 | // second requiring confirmation. |
| 10123 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTNoConfirmConfirmStreams) { |
| 10124 | // This test orders the writes such that the GET (no confirmation) is written |
| 10125 | // before the POST (confirmation required). |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 10126 | spdy::Http2HeaderBlock req_block1( |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 10127 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 10128 | spdy::SpdySerializedFrame req1( |
| 10129 | spdy_util_.ConstructSpdyHeaders(1, std::move(req_block1), LOWEST, true)); |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 10130 | spdy::Http2HeaderBlock req_block2( |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 10131 | spdy_util_.ConstructPostHeaderBlock(kDefaultUrl, 0)); |
| 10132 | spdy::SpdySerializedFrame req2( |
| 10133 | spdy_util_.ConstructSpdyHeaders(3, std::move(req_block2), LOWEST, true)); |
| 10134 | MockWrite writes[] = { |
| 10135 | CreateMockWrite(req1, 0), |
| 10136 | CreateMockWrite(req2, 3), |
| 10137 | }; |
| 10138 | spdy::SpdySerializedFrame resp1( |
| 10139 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 10140 | spdy::SpdySerializedFrame body1(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10141 | spdy::SpdySerializedFrame resp2( |
| 10142 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 3)); |
| 10143 | spdy::SpdySerializedFrame body2(spdy_util_.ConstructSpdyDataFrame(3, true)); |
| 10144 | MockRead reads[] = { |
| 10145 | CreateMockRead(resp1, 1), CreateMockRead(body1, 2), |
| 10146 | CreateMockRead(resp2, 4), CreateMockRead(body2, 5), |
| 10147 | MockRead(ASYNC, 0, 6) // EOF |
| 10148 | }; |
| 10149 | |
| 10150 | SequencedSocketData data1(reads, writes); |
| 10151 | SequencedSocketData data2({}, {}); |
| 10152 | UsePostRequest(); |
| 10153 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10154 | session_deps->enable_early_data = true; |
| 10155 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10156 | std::move(session_deps)); |
| 10157 | auto ssl_provider1 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 10158 | ssl_provider1->confirm = MockConfirm(ASYNC, OK); |
| 10159 | auto ssl_provider2 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 10160 | ssl_provider2->confirm = MockConfirm(ASYNC, OK); |
| 10161 | |
| 10162 | helper.RunPreTestSetup(); |
| 10163 | helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1)); |
| 10164 | helper.AddDataWithSSLSocketDataProvider(&data2, std::move(ssl_provider2)); |
| 10165 | |
| 10166 | // TODO(https://crbug.com/949724): Explicitly verify the ordering of |
| 10167 | // ConfirmHandshake and the second stream. |
| 10168 | |
| 10169 | HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session()); |
| 10170 | HttpRequestInfo request1; |
| 10171 | request1.method = "GET"; |
| 10172 | request1.url = GURL(kDefaultUrl); |
| 10173 | request1.traffic_annotation = |
| 10174 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 10175 | TestCompletionCallback callback1; |
| 10176 | int rv = trans1.Start(&request1, callback1.callback(), log_); |
| 10177 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 10178 | |
| 10179 | HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session()); |
| 10180 | HttpRequestInfo request2; |
| 10181 | request2.method = "POST"; |
| 10182 | request2.url = GURL(kDefaultUrl); |
| 10183 | request2.traffic_annotation = |
| 10184 | net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS); |
| 10185 | TestCompletionCallback callback2; |
| 10186 | rv = trans2.Start(&request2, callback2.callback(), log_); |
| 10187 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 10188 | |
| 10189 | EXPECT_THAT(callback1.GetResult(ERR_IO_PENDING), IsOk()); |
| 10190 | EXPECT_THAT(callback2.GetResult(ERR_IO_PENDING), IsOk()); |
| 10191 | |
| 10192 | const HttpResponseInfo* response1 = trans1.GetResponseInfo(); |
| 10193 | ASSERT_TRUE(response1); |
| 10194 | ASSERT_TRUE(response1->headers); |
| 10195 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 10196 | response1->connection_info); |
| 10197 | EXPECT_EQ("HTTP/1.1 200", response1->headers->GetStatusLine()); |
| 10198 | std::string response_data; |
| 10199 | ReadTransaction(&trans1, &response_data); |
| 10200 | EXPECT_EQ("hello!", response_data); |
| 10201 | |
| 10202 | const HttpResponseInfo* response2 = trans2.GetResponseInfo(); |
| 10203 | ASSERT_TRUE(response2); |
| 10204 | ASSERT_TRUE(response2->headers); |
| 10205 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP2, |
| 10206 | response2->connection_info); |
| 10207 | EXPECT_EQ("HTTP/1.1 200", response2->headers->GetStatusLine()); |
| 10208 | ReadTransaction(&trans2, &response_data); |
| 10209 | EXPECT_EQ("hello!", response_data); |
| 10210 | |
| 10211 | helper.VerifyDataConsumed(); |
| 10212 | } |
| 10213 | |
| 10214 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTSyncConfirmSyncWrite) { |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 10215 | static const base::TimeDelta kDelay = base::Milliseconds(10); |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 10216 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 10217 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 10218 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10219 | MockWrite writes[] = { |
| 10220 | CreateMockWrite(req, 0, SYNCHRONOUS), |
| 10221 | CreateMockWrite(body, 1), // POST upload frame |
| 10222 | }; |
| 10223 | |
| 10224 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 10225 | MockRead reads[] = { |
| 10226 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
| 10227 | MockRead(ASYNC, 0, 4) // EOF |
| 10228 | }; |
| 10229 | |
| 10230 | SequencedSocketData data(reads, writes); |
| 10231 | UsePostRequest(); |
| 10232 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10233 | session_deps->enable_early_data = true; |
| 10234 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10235 | std::move(session_deps)); |
| 10236 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
David Benjamin | bae08ba | 2019-10-18 21:06:15 | [diff] [blame] | 10237 | ssl_provider->connect_callback = FastForwardByCallback(kDelay); |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 10238 | ssl_provider->confirm = MockConfirm(SYNCHRONOUS, OK); |
David Benjamin | bae08ba | 2019-10-18 21:06:15 | [diff] [blame] | 10239 | ssl_provider->confirm_callback = FastForwardByCallback(kDelay); |
| 10240 | base::TimeTicks start_time = base::TimeTicks::Now(); |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 10241 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
| 10242 | TransactionHelperResult out = helper.output(); |
| 10243 | EXPECT_THAT(out.rv, IsOk()); |
| 10244 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 10245 | EXPECT_EQ("hello!", out.response_data); |
David Benjamin | bae08ba | 2019-10-18 21:06:15 | [diff] [blame] | 10246 | |
| 10247 | // The handshake time should include the time it took to run Connect(), but |
| 10248 | // not ConfirmHandshake(). If ConfirmHandshake() returns synchronously, we |
| 10249 | // assume the connection did not negotiate 0-RTT or the handshake was already |
| 10250 | // confirmed. |
| 10251 | LoadTimingInfo load_timing_info; |
| 10252 | EXPECT_TRUE(helper.trans()->GetLoadTimingInfo(&load_timing_info)); |
| 10253 | EXPECT_EQ(load_timing_info.connect_timing.connect_start, start_time); |
| 10254 | EXPECT_EQ(load_timing_info.connect_timing.ssl_start, start_time); |
| 10255 | EXPECT_EQ(load_timing_info.connect_timing.ssl_end, start_time + kDelay); |
| 10256 | EXPECT_EQ(load_timing_info.connect_timing.connect_end, start_time + kDelay); |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 10257 | } |
| 10258 | |
| 10259 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTSyncConfirmAsyncWrite) { |
| 10260 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 10261 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 10262 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10263 | MockWrite writes[] = { |
| 10264 | CreateMockWrite(req, 0, ASYNC), |
| 10265 | CreateMockWrite(body, 1), // POST upload frame |
| 10266 | }; |
| 10267 | |
| 10268 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 10269 | MockRead reads[] = { |
| 10270 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
| 10271 | MockRead(ASYNC, 0, 4) // EOF |
| 10272 | }; |
| 10273 | |
| 10274 | SequencedSocketData data(reads, writes); |
| 10275 | UsePostRequest(); |
| 10276 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10277 | session_deps->enable_early_data = true; |
| 10278 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10279 | std::move(session_deps)); |
| 10280 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 10281 | ssl_provider->confirm = MockConfirm(SYNCHRONOUS, OK); |
| 10282 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
| 10283 | TransactionHelperResult out = helper.output(); |
| 10284 | EXPECT_THAT(out.rv, IsOk()); |
| 10285 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 10286 | EXPECT_EQ("hello!", out.response_data); |
| 10287 | } |
| 10288 | |
| 10289 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTAsyncConfirmSyncWrite) { |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 10290 | static const base::TimeDelta kDelay = base::Milliseconds(10); |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 10291 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 10292 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 10293 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10294 | MockWrite writes[] = { |
| 10295 | CreateMockWrite(req, 0, SYNCHRONOUS), |
| 10296 | CreateMockWrite(body, 1), // POST upload frame |
| 10297 | }; |
| 10298 | |
| 10299 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 10300 | MockRead reads[] = { |
| 10301 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
| 10302 | MockRead(ASYNC, 0, 4) // EOF |
| 10303 | }; |
| 10304 | |
| 10305 | SequencedSocketData data(reads, writes); |
| 10306 | UsePostRequest(); |
| 10307 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10308 | session_deps->enable_early_data = true; |
| 10309 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10310 | std::move(session_deps)); |
| 10311 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
David Benjamin | bae08ba | 2019-10-18 21:06:15 | [diff] [blame] | 10312 | ssl_provider->connect_callback = FastForwardByCallback(kDelay); |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 10313 | ssl_provider->confirm = MockConfirm(ASYNC, OK); |
David Benjamin | bae08ba | 2019-10-18 21:06:15 | [diff] [blame] | 10314 | ssl_provider->confirm_callback = FastForwardByCallback(kDelay); |
| 10315 | base::TimeTicks start_time = base::TimeTicks::Now(); |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 10316 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
| 10317 | TransactionHelperResult out = helper.output(); |
| 10318 | EXPECT_THAT(out.rv, IsOk()); |
| 10319 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 10320 | EXPECT_EQ("hello!", out.response_data); |
David Benjamin | bae08ba | 2019-10-18 21:06:15 | [diff] [blame] | 10321 | |
| 10322 | // The handshake time should include the time it took to run Connect() and |
| 10323 | // ConfirmHandshake(). |
| 10324 | LoadTimingInfo load_timing_info; |
| 10325 | EXPECT_TRUE(helper.trans()->GetLoadTimingInfo(&load_timing_info)); |
| 10326 | EXPECT_EQ(load_timing_info.connect_timing.connect_start, start_time); |
| 10327 | EXPECT_EQ(load_timing_info.connect_timing.ssl_start, start_time); |
| 10328 | EXPECT_EQ(load_timing_info.connect_timing.ssl_end, start_time + 2 * kDelay); |
| 10329 | EXPECT_EQ(load_timing_info.connect_timing.connect_end, |
| 10330 | start_time + 2 * kDelay); |
Steven Valdez | 1c185917 | 2019-04-10 15:33:28 | [diff] [blame] | 10331 | } |
| 10332 | |
| 10333 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTAsyncConfirmAsyncWrite) { |
| 10334 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 10335 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 10336 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10337 | MockWrite writes[] = { |
| 10338 | CreateMockWrite(req, 0, ASYNC), |
| 10339 | CreateMockWrite(body, 1), // POST upload frame |
| 10340 | }; |
| 10341 | |
| 10342 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 10343 | MockRead reads[] = { |
| 10344 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
| 10345 | MockRead(ASYNC, 0, 4) // EOF |
| 10346 | }; |
| 10347 | |
| 10348 | SequencedSocketData data(reads, writes); |
| 10349 | UsePostRequest(); |
| 10350 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10351 | session_deps->enable_early_data = true; |
| 10352 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10353 | std::move(session_deps)); |
| 10354 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 10355 | ssl_provider->confirm = MockConfirm(ASYNC, OK); |
| 10356 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
| 10357 | TransactionHelperResult out = helper.output(); |
| 10358 | EXPECT_THAT(out.rv, IsOk()); |
| 10359 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 10360 | EXPECT_EQ("hello!", out.response_data); |
| 10361 | } |
| 10362 | |
| 10363 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTConfirmErrorSync) { |
| 10364 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 10365 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 10366 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10367 | MockWrite writes[] = { |
| 10368 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), // POST upload frame |
| 10369 | }; |
| 10370 | |
| 10371 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 10372 | MockRead reads[] = { |
| 10373 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
| 10374 | MockRead(ASYNC, 0, 4) // EOF |
| 10375 | }; |
| 10376 | |
| 10377 | SequencedSocketData data(reads, writes); |
| 10378 | UsePostRequest(); |
| 10379 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10380 | session_deps->enable_early_data = true; |
| 10381 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10382 | std::move(session_deps)); |
| 10383 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 10384 | ssl_provider->confirm = MockConfirm(SYNCHRONOUS, ERR_SSL_PROTOCOL_ERROR); |
| 10385 | helper.RunPreTestSetup(); |
| 10386 | helper.AddDataWithSSLSocketDataProvider(&data, std::move(ssl_provider)); |
| 10387 | helper.RunDefaultTest(); |
| 10388 | TransactionHelperResult out = helper.output(); |
| 10389 | EXPECT_THAT(out.rv, IsError(ERR_SSL_PROTOCOL_ERROR)); |
| 10390 | } |
| 10391 | |
| 10392 | TEST_F(SpdyNetworkTransactionTest, ZeroRTTConfirmErrorAsync) { |
| 10393 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 10394 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 10395 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10396 | MockWrite writes[] = { |
| 10397 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), // POST upload frame |
| 10398 | }; |
| 10399 | |
| 10400 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 10401 | MockRead reads[] = { |
| 10402 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
| 10403 | MockRead(ASYNC, 0, 4) // EOF |
| 10404 | }; |
| 10405 | |
| 10406 | SequencedSocketData data(reads, writes); |
| 10407 | UsePostRequest(); |
| 10408 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10409 | session_deps->enable_early_data = true; |
| 10410 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10411 | std::move(session_deps)); |
| 10412 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 10413 | ssl_provider->confirm = MockConfirm(ASYNC, ERR_SSL_PROTOCOL_ERROR); |
| 10414 | helper.RunPreTestSetup(); |
| 10415 | helper.AddDataWithSSLSocketDataProvider(&data, std::move(ssl_provider)); |
| 10416 | helper.RunDefaultTest(); |
| 10417 | TransactionHelperResult out = helper.output(); |
| 10418 | EXPECT_THAT(out.rv, IsError(ERR_SSL_PROTOCOL_ERROR)); |
| 10419 | } |
| 10420 | |
Bence Béky | d228fb2 | 2021-10-29 14:45:51 | [diff] [blame] | 10421 | TEST_F(SpdyNetworkTransactionTest, GreaseSettings) { |
| 10422 | RecordingNetLogObserver net_log_observer; |
| 10423 | |
| 10424 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10425 | session_deps->enable_http2_settings_grease = true; |
| 10426 | NormalSpdyTransactionHelper helper( |
| 10427 | request_, DEFAULT_PRIORITY, |
| 10428 | NetLogWithSource::Make(NetLogSourceType::NONE), std::move(session_deps)); |
| 10429 | |
| 10430 | SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool(); |
| 10431 | SpdySessionPoolPeer pool_peer(spdy_session_pool); |
| 10432 | pool_peer.SetEnableSendingInitialData(true); |
| 10433 | |
| 10434 | // Greased setting parameter is random. Hang writes instead of trying to |
| 10435 | // construct matching mock data. Extra write and read is needed because mock |
| 10436 | // data cannot end on ERR_IO_PENDING. Writes or reads will not actually be |
| 10437 | // resumed. |
| 10438 | MockWrite writes[] = {MockWrite(ASYNC, ERR_IO_PENDING, 0), |
| 10439 | MockWrite(ASYNC, OK, 1)}; |
| 10440 | MockRead reads[] = {MockRead(ASYNC, ERR_IO_PENDING, 2), |
| 10441 | MockRead(ASYNC, OK, 3)}; |
| 10442 | SequencedSocketData data(reads, writes); |
| 10443 | helper.RunPreTestSetup(); |
| 10444 | helper.AddData(&data); |
| 10445 | |
| 10446 | int rv = helper.trans()->Start(&request_, CompletionOnceCallback{}, log_); |
| 10447 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 10448 | |
| 10449 | base::RunLoop().RunUntilIdle(); |
| 10450 | |
| 10451 | helper.ResetTrans(); |
| 10452 | |
| 10453 | EXPECT_FALSE(data.AllReadDataConsumed()); |
| 10454 | EXPECT_FALSE(data.AllWriteDataConsumed()); |
| 10455 | |
| 10456 | const auto entries = net_log_observer.GetEntries(); |
| 10457 | |
| 10458 | size_t pos = ExpectLogContainsSomewhere( |
| 10459 | entries, 0, NetLogEventType::HTTP2_SESSION_SEND_SETTINGS, |
| 10460 | NetLogEventPhase::NONE); |
| 10461 | ASSERT_LT(pos, entries.size()); |
| 10462 | |
| 10463 | const base::Value& params = entries[pos].params; |
| 10464 | const base::Value* const settings = params.FindKey("settings"); |
| 10465 | ASSERT_TRUE(settings); |
| 10466 | ASSERT_TRUE(settings->is_list()); |
| 10467 | |
| 10468 | base::Value::ConstListView list = settings->GetList(); |
| 10469 | ASSERT_FALSE(list.empty()); |
| 10470 | // Get last setting parameter. |
| 10471 | const base::Value& greased_setting = list[list.size() - 1]; |
| 10472 | ASSERT_TRUE(greased_setting.is_string()); |
| 10473 | base::StringPiece greased_setting_string(greased_setting.GetString()); |
| 10474 | |
| 10475 | const std::string kExpectedPrefix = "[id:"; |
| 10476 | EXPECT_EQ(kExpectedPrefix, |
| 10477 | greased_setting_string.substr(0, kExpectedPrefix.size())); |
| 10478 | int setting_identifier = 0; |
| 10479 | base::StringToInt(greased_setting_string.substr(kExpectedPrefix.size()), |
| 10480 | &setting_identifier); |
| 10481 | // The setting identifier must be of format 0x?a?a. |
| 10482 | EXPECT_EQ(0xa, setting_identifier % 16); |
| 10483 | EXPECT_EQ(0xa, (setting_identifier / 256) % 16); |
| 10484 | } |
| 10485 | |
Bence Béky | cb4be9e | 2020-07-09 11:18:14 | [diff] [blame] | 10486 | // If |http2_end_stream_with_data_frame| is false, then the HEADERS frame of a |
| 10487 | // GET request will close the stream using the END_STREAM flag. Test that |
| 10488 | // |greased_http2_frame| is ignored and no reserved frames are sent on a closed |
| 10489 | // stream. |
| 10490 | TEST_F(SpdyNetworkTransactionTest, |
| 10491 | DoNotGreaseFrameTypeWithGetRequestIfHeadersFrameClosesStream) { |
| 10492 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10493 | |
| 10494 | const uint8_t type = 0x0b; |
| 10495 | const uint8_t flags = 0xcc; |
| 10496 | const std::string payload("foo"); |
| 10497 | session_deps->greased_http2_frame = |
Anton Bikineev | 068d291 | 2021-05-15 20:43:52 | [diff] [blame] | 10498 | absl::optional<net::SpdySessionPool::GreasedHttp2Frame>( |
Bence Béky | cb4be9e | 2020-07-09 11:18:14 | [diff] [blame] | 10499 | {type, flags, payload}); |
| 10500 | session_deps->http2_end_stream_with_data_frame = false; |
| 10501 | |
| 10502 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10503 | std::move(session_deps)); |
| 10504 | |
| 10505 | spdy::SpdySerializedFrame req( |
| 10506 | spdy_util_.ConstructSpdyGet(nullptr, 0, 1, DEFAULT_PRIORITY)); |
| 10507 | MockWrite writes[] = {CreateMockWrite(req, 0)}; |
| 10508 | |
| 10509 | spdy::SpdySerializedFrame resp( |
| 10510 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 10511 | spdy::SpdySerializedFrame response_body( |
| 10512 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10513 | |
| 10514 | MockRead reads[] = {CreateMockRead(resp, 1), CreateMockRead(response_body, 2), |
| 10515 | MockRead(ASYNC, 0, 3)}; |
| 10516 | |
| 10517 | SequencedSocketData data(reads, writes); |
| 10518 | helper.RunPreTestSetup(); |
| 10519 | helper.AddData(&data); |
| 10520 | |
| 10521 | TestCompletionCallback callback; |
| 10522 | int rv = helper.trans()->Start(&request_, callback.callback(), log_); |
| 10523 | EXPECT_THAT(callback.GetResult(rv), IsOk()); |
| 10524 | |
| 10525 | base::RunLoop().RunUntilIdle(); |
| 10526 | |
| 10527 | helper.VerifyDataConsumed(); |
| 10528 | } |
| 10529 | |
| 10530 | // Test that if |http2_end_stream_with_data_frame| and |greased_http2_frame| are |
| 10531 | // both set, then the HEADERS frame does not have the END_STREAM flag set, it is |
| 10532 | // followed by a greased frame, and then by an empty DATA frame with END_STREAM |
| 10533 | // set. |
Bence Béky | 9eb57f6 | 2019-11-13 14:47:25 | [diff] [blame] | 10534 | TEST_F(SpdyNetworkTransactionTest, GreaseFrameTypeWithGetRequest) { |
| 10535 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10536 | |
| 10537 | const uint8_t type = 0x0b; |
| 10538 | const uint8_t flags = 0xcc; |
| 10539 | const std::string payload("foo"); |
| 10540 | session_deps->greased_http2_frame = |
Anton Bikineev | 068d291 | 2021-05-15 20:43:52 | [diff] [blame] | 10541 | absl::optional<net::SpdySessionPool::GreasedHttp2Frame>( |
Bence Béky | 9eb57f6 | 2019-11-13 14:47:25 | [diff] [blame] | 10542 | {type, flags, payload}); |
Bence Béky | cb4be9e | 2020-07-09 11:18:14 | [diff] [blame] | 10543 | session_deps->http2_end_stream_with_data_frame = true; |
Bence Béky | 9eb57f6 | 2019-11-13 14:47:25 | [diff] [blame] | 10544 | |
| 10545 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10546 | std::move(session_deps)); |
| 10547 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 10548 | spdy::Http2HeaderBlock headers( |
Bence Béky | 9eb57f6 | 2019-11-13 14:47:25 | [diff] [blame] | 10549 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 10550 | spdy::SpdySerializedFrame req( |
| 10551 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers), DEFAULT_PRIORITY, |
| 10552 | /* fin = */ false)); |
| 10553 | |
Peter Kasting | 0ff39d4 | 2021-06-14 13:26:06 | [diff] [blame] | 10554 | uint8_t kRawFrameData[] = { |
Bence Béky | 9eb57f6 | 2019-11-13 14:47:25 | [diff] [blame] | 10555 | 0x00, 0x00, 0x03, // length |
| 10556 | 0x0b, // type |
| 10557 | 0xcc, // flags |
| 10558 | 0x00, 0x00, 0x00, 0x01, // stream ID |
| 10559 | 'f', 'o', 'o' // payload |
| 10560 | }; |
Peter Kasting | 0ff39d4 | 2021-06-14 13:26:06 | [diff] [blame] | 10561 | spdy::SpdySerializedFrame grease(reinterpret_cast<char*>(kRawFrameData), |
Bence Béky | 9eb57f6 | 2019-11-13 14:47:25 | [diff] [blame] | 10562 | base::size(kRawFrameData), |
| 10563 | /* owns_buffer = */ false); |
| 10564 | spdy::SpdySerializedFrame empty_body( |
| 10565 | spdy_util_.ConstructSpdyDataFrame(1, "", true)); |
| 10566 | |
| 10567 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(grease, 1), |
| 10568 | CreateMockWrite(empty_body, 2)}; |
| 10569 | |
| 10570 | spdy::SpdySerializedFrame resp( |
| 10571 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 10572 | spdy::SpdySerializedFrame response_body( |
| 10573 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10574 | |
| 10575 | MockRead reads[] = {CreateMockRead(resp, 3), CreateMockRead(response_body, 4), |
| 10576 | MockRead(ASYNC, 0, 5)}; |
| 10577 | |
| 10578 | SequencedSocketData data(reads, writes); |
| 10579 | helper.RunPreTestSetup(); |
| 10580 | helper.AddData(&data); |
| 10581 | |
| 10582 | TestCompletionCallback callback; |
| 10583 | int rv = helper.trans()->Start(&request_, callback.callback(), log_); |
| 10584 | EXPECT_THAT(callback.GetResult(rv), IsOk()); |
| 10585 | |
| 10586 | base::RunLoop().RunUntilIdle(); |
| 10587 | |
| 10588 | helper.VerifyDataConsumed(); |
| 10589 | } |
| 10590 | |
Bence Béky | cb4be9e | 2020-07-09 11:18:14 | [diff] [blame] | 10591 | // Test sending a greased frame before DATA frame that closes the stream when |
| 10592 | // |http2_end_stream_with_data_frame| is false. |
| 10593 | TEST_F(SpdyNetworkTransactionTest, |
| 10594 | GreaseFrameTypeWithPostRequestWhenHeadersFrameClosesStream) { |
Bence Béky | 9eb57f6 | 2019-11-13 14:47:25 | [diff] [blame] | 10595 | UsePostRequest(); |
| 10596 | |
| 10597 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10598 | |
| 10599 | const uint8_t type = 0x0b; |
| 10600 | const uint8_t flags = 0xcc; |
| 10601 | const std::string payload("foo"); |
| 10602 | session_deps->greased_http2_frame = |
Anton Bikineev | 068d291 | 2021-05-15 20:43:52 | [diff] [blame] | 10603 | absl::optional<net::SpdySessionPool::GreasedHttp2Frame>( |
Bence Béky | 9eb57f6 | 2019-11-13 14:47:25 | [diff] [blame] | 10604 | {type, flags, payload}); |
Bence Béky | cb4be9e | 2020-07-09 11:18:14 | [diff] [blame] | 10605 | session_deps->http2_end_stream_with_data_frame = true; |
| 10606 | |
| 10607 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10608 | std::move(session_deps)); |
| 10609 | |
| 10610 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 10611 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 10612 | |
Peter Kasting | 0ff39d4 | 2021-06-14 13:26:06 | [diff] [blame] | 10613 | uint8_t kRawFrameData[] = { |
Bence Béky | cb4be9e | 2020-07-09 11:18:14 | [diff] [blame] | 10614 | 0x00, 0x00, 0x03, // length |
| 10615 | 0x0b, // type |
| 10616 | 0xcc, // flags |
| 10617 | 0x00, 0x00, 0x00, 0x01, // stream ID |
| 10618 | 'f', 'o', 'o' // payload |
| 10619 | }; |
Peter Kasting | 0ff39d4 | 2021-06-14 13:26:06 | [diff] [blame] | 10620 | spdy::SpdySerializedFrame grease(reinterpret_cast<char*>(kRawFrameData), |
Bence Béky | cb4be9e | 2020-07-09 11:18:14 | [diff] [blame] | 10621 | base::size(kRawFrameData), |
| 10622 | /* owns_buffer = */ false); |
| 10623 | spdy::SpdySerializedFrame request_body( |
| 10624 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10625 | |
| 10626 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(grease, 1), |
| 10627 | CreateMockWrite(request_body, 2)}; |
| 10628 | |
| 10629 | spdy::SpdySerializedFrame resp( |
| 10630 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 10631 | spdy::SpdySerializedFrame response_body( |
| 10632 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10633 | |
| 10634 | MockRead reads[] = {CreateMockRead(resp, 3), CreateMockRead(response_body, 4), |
| 10635 | MockRead(ASYNC, 0, 5)}; |
| 10636 | |
| 10637 | SequencedSocketData data(reads, writes); |
| 10638 | helper.RunPreTestSetup(); |
| 10639 | helper.AddData(&data); |
| 10640 | |
| 10641 | TestCompletionCallback callback; |
| 10642 | int rv = helper.trans()->Start(&request_, callback.callback(), log_); |
| 10643 | EXPECT_THAT(callback.GetResult(rv), IsOk()); |
| 10644 | |
| 10645 | base::RunLoop().RunUntilIdle(); |
| 10646 | |
| 10647 | helper.VerifyDataConsumed(); |
| 10648 | } |
| 10649 | |
| 10650 | // Test sending a greased frame before DATA frame that closes the stream. |
| 10651 | // |http2_end_stream_with_data_frame| is true but should make no difference, |
| 10652 | // because the stream is already closed by a DATA frame. |
| 10653 | TEST_F(SpdyNetworkTransactionTest, |
| 10654 | GreaseFrameTypeWithPostRequestWhenEmptyDataFrameClosesStream) { |
| 10655 | UsePostRequest(); |
| 10656 | |
| 10657 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10658 | |
| 10659 | const uint8_t type = 0x0b; |
| 10660 | const uint8_t flags = 0xcc; |
| 10661 | const std::string payload("foo"); |
| 10662 | session_deps->greased_http2_frame = |
Anton Bikineev | 068d291 | 2021-05-15 20:43:52 | [diff] [blame] | 10663 | absl::optional<net::SpdySessionPool::GreasedHttp2Frame>( |
Bence Béky | cb4be9e | 2020-07-09 11:18:14 | [diff] [blame] | 10664 | {type, flags, payload}); |
| 10665 | session_deps->http2_end_stream_with_data_frame = true; |
Bence Béky | 9eb57f6 | 2019-11-13 14:47:25 | [diff] [blame] | 10666 | |
| 10667 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10668 | std::move(session_deps)); |
| 10669 | |
| 10670 | spdy::SpdySerializedFrame req(spdy_util_.ConstructSpdyPost( |
| 10671 | kDefaultUrl, 1, kUploadDataSize, LOWEST, nullptr, 0)); |
| 10672 | |
Peter Kasting | 0ff39d4 | 2021-06-14 13:26:06 | [diff] [blame] | 10673 | uint8_t kRawFrameData[] = { |
Bence Béky | 9eb57f6 | 2019-11-13 14:47:25 | [diff] [blame] | 10674 | 0x00, 0x00, 0x03, // length |
| 10675 | 0x0b, // type |
| 10676 | 0xcc, // flags |
| 10677 | 0x00, 0x00, 0x00, 0x01, // stream ID |
| 10678 | 'f', 'o', 'o' // payload |
| 10679 | }; |
Peter Kasting | 0ff39d4 | 2021-06-14 13:26:06 | [diff] [blame] | 10680 | spdy::SpdySerializedFrame grease(reinterpret_cast<char*>(kRawFrameData), |
Bence Béky | 9eb57f6 | 2019-11-13 14:47:25 | [diff] [blame] | 10681 | base::size(kRawFrameData), |
| 10682 | /* owns_buffer = */ false); |
| 10683 | spdy::SpdySerializedFrame request_body( |
| 10684 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10685 | |
| 10686 | MockWrite writes[] = {CreateMockWrite(req, 0), CreateMockWrite(grease, 1), |
| 10687 | CreateMockWrite(request_body, 2)}; |
| 10688 | |
| 10689 | spdy::SpdySerializedFrame resp( |
| 10690 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 10691 | spdy::SpdySerializedFrame response_body( |
| 10692 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10693 | |
| 10694 | MockRead reads[] = {CreateMockRead(resp, 3), CreateMockRead(response_body, 4), |
| 10695 | MockRead(ASYNC, 0, 5)}; |
| 10696 | |
| 10697 | SequencedSocketData data(reads, writes); |
| 10698 | helper.RunPreTestSetup(); |
| 10699 | helper.AddData(&data); |
| 10700 | |
| 10701 | TestCompletionCallback callback; |
| 10702 | int rv = helper.trans()->Start(&request_, callback.callback(), log_); |
| 10703 | EXPECT_THAT(callback.GetResult(rv), IsOk()); |
| 10704 | |
| 10705 | base::RunLoop().RunUntilIdle(); |
| 10706 | |
| 10707 | helper.VerifyDataConsumed(); |
| 10708 | } |
| 10709 | |
Bence Béky | 21755dd6 | 2019-11-19 13:47:35 | [diff] [blame] | 10710 | // According to https://httpwg.org/specs/rfc7540.html#CONNECT, "frame types |
| 10711 | // other than DATA or stream management frames (RST_STREAM, WINDOW_UPDATE, and |
| 10712 | // PRIORITY) MUST NOT be sent on a connected stream". |
Bence Béky | cb4be9e | 2020-07-09 11:18:14 | [diff] [blame] | 10713 | // Also test that |http2_end_stream_with_data_frame| has no effect on proxy |
| 10714 | // streams. |
Bence Béky | 21755dd6 | 2019-11-19 13:47:35 | [diff] [blame] | 10715 | TEST_F(SpdyNetworkTransactionTest, DoNotGreaseFrameTypeWithConnect) { |
| 10716 | auto session_deps = std::make_unique<SpdySessionDependencies>( |
Nicolas Arciniega | d2013f9 | 2020-02-07 23:00:56 | [diff] [blame] | 10717 | ConfiguredProxyResolutionService::CreateFixedFromPacResult( |
Bence Béky | 21755dd6 | 2019-11-19 13:47:35 | [diff] [blame] | 10718 | "HTTPS myproxy:70", TRAFFIC_ANNOTATION_FOR_TESTS)); |
| 10719 | |
| 10720 | const uint8_t type = 0x0b; |
| 10721 | const uint8_t flags = 0xcc; |
| 10722 | const std::string payload("foo"); |
| 10723 | session_deps->greased_http2_frame = |
Anton Bikineev | 068d291 | 2021-05-15 20:43:52 | [diff] [blame] | 10724 | absl::optional<net::SpdySessionPool::GreasedHttp2Frame>( |
Bence Béky | 21755dd6 | 2019-11-19 13:47:35 | [diff] [blame] | 10725 | {type, flags, payload}); |
Bence Béky | cb4be9e | 2020-07-09 11:18:14 | [diff] [blame] | 10726 | session_deps->http2_end_stream_with_data_frame = true; |
Bence Béky | 21755dd6 | 2019-11-19 13:47:35 | [diff] [blame] | 10727 | |
| 10728 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10729 | std::move(session_deps)); |
| 10730 | |
| 10731 | // CONNECT to proxy. |
| 10732 | spdy::SpdySerializedFrame connect_req(spdy_util_.ConstructSpdyConnect( |
| 10733 | nullptr, 0, 1, HttpProxyConnectJob::kH2QuicTunnelPriority, |
| 10734 | HostPortPair("www.example.org", 443))); |
| 10735 | spdy::SpdySerializedFrame connect_response( |
| 10736 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 10737 | |
| 10738 | // Tunneled transaction wrapped in DATA frames. |
| 10739 | const char req[] = |
| 10740 | "GET / HTTP/1.1\r\n" |
| 10741 | "Host: www.example.org\r\n" |
| 10742 | "Connection: keep-alive\r\n\r\n"; |
| 10743 | spdy::SpdySerializedFrame tunneled_req( |
| 10744 | spdy_util_.ConstructSpdyDataFrame(1, req, false)); |
| 10745 | |
| 10746 | const char resp[] = |
| 10747 | "HTTP/1.1 200 OK\r\n" |
| 10748 | "Content-Length: 5\r\n\r\n" |
| 10749 | "hello"; |
| 10750 | spdy::SpdySerializedFrame tunneled_response( |
| 10751 | spdy_util_.ConstructSpdyDataFrame(1, resp, false)); |
| 10752 | |
| 10753 | MockWrite writes[] = {CreateMockWrite(connect_req, 0), |
| 10754 | CreateMockWrite(tunneled_req, 2)}; |
| 10755 | |
| 10756 | MockRead reads[] = {CreateMockRead(connect_response, 1), |
| 10757 | CreateMockRead(tunneled_response, 3), |
| 10758 | MockRead(ASYNC, 0, 4)}; |
| 10759 | |
| 10760 | SequencedSocketData data0(reads, writes); |
| 10761 | |
| 10762 | // HTTP/2 connection to proxy. |
| 10763 | auto ssl_provider0 = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 10764 | ssl_provider0->next_proto = kProtoHTTP2; |
| 10765 | helper.AddDataWithSSLSocketDataProvider(&data0, std::move(ssl_provider0)); |
| 10766 | |
| 10767 | // HTTP/1.1 to destination. |
| 10768 | SSLSocketDataProvider ssl_provider1(ASYNC, OK); |
| 10769 | ssl_provider1.next_proto = kProtoHTTP11; |
| 10770 | helper.session_deps()->socket_factory->AddSSLSocketDataProvider( |
| 10771 | &ssl_provider1); |
| 10772 | |
| 10773 | helper.RunPreTestSetup(); |
| 10774 | helper.StartDefaultTest(); |
| 10775 | helper.FinishDefaultTestWithoutVerification(); |
| 10776 | helper.VerifyDataConsumed(); |
| 10777 | |
| 10778 | const HttpResponseInfo* response = helper.trans()->GetResponseInfo(); |
| 10779 | ASSERT_TRUE(response); |
| 10780 | ASSERT_TRUE(response->headers); |
| 10781 | EXPECT_EQ("HTTP/1.1 200 OK", response->headers->GetStatusLine()); |
| 10782 | EXPECT_FALSE(response->was_fetched_via_spdy); |
| 10783 | EXPECT_EQ(HttpResponseInfo::CONNECTION_INFO_HTTP1_1, |
| 10784 | response->connection_info); |
| 10785 | EXPECT_TRUE(response->was_alpn_negotiated); |
| 10786 | EXPECT_TRUE(request_.url.SchemeIs("https")); |
| 10787 | EXPECT_EQ("127.0.0.1", response->remote_endpoint.ToStringWithoutPort()); |
| 10788 | EXPECT_EQ(70, response->remote_endpoint.port()); |
| 10789 | std::string response_data; |
| 10790 | ASSERT_THAT(ReadTransaction(helper.trans(), &response_data), IsOk()); |
| 10791 | EXPECT_EQ("hello", response_data); |
| 10792 | } |
| 10793 | |
Bence Béky | 087d4ba | 2020-05-13 23:10:28 | [diff] [blame] | 10794 | // Regression test for https://crbug.com/1081955. |
| 10795 | // Greasing frame types is enabled, the outgoing HEADERS frame is followed by a |
| 10796 | // frame of reserved type, then an empty DATA frame to close the stream. |
| 10797 | // Response arrives before reserved frame and DATA frame can be sent. |
| 10798 | // SpdyHttpStream::OnDataSent() must not crash. |
| 10799 | TEST_F(SpdyNetworkTransactionTest, OnDataSentDoesNotCrashWithGreasedFrameType) { |
| 10800 | auto session_deps = std::make_unique<SpdySessionDependencies>(); |
| 10801 | |
| 10802 | const uint8_t type = 0x0b; |
| 10803 | const uint8_t flags = 0xcc; |
| 10804 | const std::string payload("foo"); |
| 10805 | session_deps->greased_http2_frame = |
Anton Bikineev | 068d291 | 2021-05-15 20:43:52 | [diff] [blame] | 10806 | absl::optional<net::SpdySessionPool::GreasedHttp2Frame>( |
Bence Béky | 087d4ba | 2020-05-13 23:10:28 | [diff] [blame] | 10807 | {type, flags, payload}); |
Bence Béky | cb4be9e | 2020-07-09 11:18:14 | [diff] [blame] | 10808 | session_deps->http2_end_stream_with_data_frame = true; |
Bence Béky | 087d4ba | 2020-05-13 23:10:28 | [diff] [blame] | 10809 | |
| 10810 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, |
| 10811 | std::move(session_deps)); |
| 10812 | |
Bence Béky | 4c325e5 | 2020-10-22 20:48:01 | [diff] [blame] | 10813 | spdy::Http2HeaderBlock headers( |
Bence Béky | 087d4ba | 2020-05-13 23:10:28 | [diff] [blame] | 10814 | spdy_util_.ConstructGetHeaderBlock(kDefaultUrl)); |
| 10815 | spdy::SpdySerializedFrame req( |
| 10816 | spdy_util_.ConstructSpdyHeaders(1, std::move(headers), DEFAULT_PRIORITY, |
| 10817 | /* fin = */ false)); |
| 10818 | |
Peter Kasting | 0ff39d4 | 2021-06-14 13:26:06 | [diff] [blame] | 10819 | uint8_t kRawFrameData[] = { |
Bence Béky | 087d4ba | 2020-05-13 23:10:28 | [diff] [blame] | 10820 | 0x00, 0x00, 0x03, // length |
| 10821 | 0x0b, // type |
| 10822 | 0xcc, // flags |
| 10823 | 0x00, 0x00, 0x00, 0x01, // stream ID |
| 10824 | 'f', 'o', 'o' // payload |
| 10825 | }; |
Peter Kasting | 0ff39d4 | 2021-06-14 13:26:06 | [diff] [blame] | 10826 | spdy::SpdySerializedFrame grease(reinterpret_cast<char*>(kRawFrameData), |
Bence Béky | 087d4ba | 2020-05-13 23:10:28 | [diff] [blame] | 10827 | base::size(kRawFrameData), |
| 10828 | /* owns_buffer = */ false); |
| 10829 | spdy::SpdySerializedFrame empty_body( |
| 10830 | spdy_util_.ConstructSpdyDataFrame(1, "", true)); |
| 10831 | |
| 10832 | MockWrite writes[] = { |
| 10833 | CreateMockWrite(req, 0), MockWrite(ASYNC, ERR_IO_PENDING, 2), |
| 10834 | CreateMockWrite(grease, 3), CreateMockWrite(empty_body, 4)}; |
| 10835 | |
| 10836 | spdy::SpdySerializedFrame resp( |
| 10837 | spdy_util_.ConstructSpdyGetReply(nullptr, 0, 1)); |
| 10838 | spdy::SpdySerializedFrame response_body( |
| 10839 | spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10840 | |
| 10841 | MockRead reads[] = {CreateMockRead(resp, 1), CreateMockRead(response_body, 5), |
| 10842 | MockRead(ASYNC, 0, 6)}; |
| 10843 | |
| 10844 | SequencedSocketData data(reads, writes); |
| 10845 | helper.RunPreTestSetup(); |
| 10846 | helper.AddData(&data); |
| 10847 | |
| 10848 | TestCompletionCallback callback; |
| 10849 | int rv = helper.trans()->Start(&request_, callback.callback(), log_); |
| 10850 | base::RunLoop().RunUntilIdle(); |
| 10851 | |
| 10852 | // Response headers received. Resume sending |grease| and |empty_body|. |
| 10853 | data.Resume(); |
| 10854 | EXPECT_THAT(callback.GetResult(rv), IsOk()); |
| 10855 | |
| 10856 | base::RunLoop().RunUntilIdle(); |
| 10857 | |
| 10858 | helper.VerifyDataConsumed(); |
| 10859 | } |
| 10860 | |
Yoichi Osato | 4c75c0c | 2020-06-24 08:03:57 | [diff] [blame] | 10861 | TEST_F(SpdyNetworkTransactionTest, NotAllowHTTP1NotBlockH2Post) { |
| 10862 | spdy::SpdySerializedFrame req( |
| 10863 | spdy_util_.ConstructChunkedSpdyPost(nullptr, 0)); |
| 10864 | spdy::SpdySerializedFrame body(spdy_util_.ConstructSpdyDataFrame(1, true)); |
| 10865 | MockWrite writes[] = { |
| 10866 | CreateMockWrite(req, 0), CreateMockWrite(body, 1), // POST upload frame |
| 10867 | }; |
| 10868 | spdy::SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0)); |
| 10869 | MockRead reads[] = { |
| 10870 | CreateMockRead(resp, 2), CreateMockRead(body, 3), |
| 10871 | MockRead(ASYNC, 0, 4) // EOF |
| 10872 | }; |
| 10873 | SequencedSocketData data(reads, writes); |
| 10874 | |
| 10875 | request_.method = "POST"; |
| 10876 | UploadDataStreamNotAllowHTTP1 upload_data(kUploadData); |
| 10877 | request_.upload_data_stream = &upload_data; |
| 10878 | |
| 10879 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 10880 | helper.RunToCompletion(&data); |
| 10881 | TransactionHelperResult out = helper.output(); |
| 10882 | EXPECT_THAT(out.rv, IsOk()); |
| 10883 | EXPECT_EQ("HTTP/1.1 200", out.status_line); |
| 10884 | EXPECT_EQ("hello!", out.response_data); |
| 10885 | } |
| 10886 | |
Bence Béky | 78b542c | 2021-03-25 19:30:37 | [diff] [blame] | 10887 | TEST_F(SpdyNetworkTransactionTest, AlpsFramingError) { |
| 10888 | base::HistogramTester histogram_tester; |
| 10889 | |
| 10890 | spdy::SpdySerializedFrame goaway(spdy_util_.ConstructSpdyGoAway( |
| 10891 | 0, spdy::ERROR_CODE_PROTOCOL_ERROR, "Error parsing ALPS: 3")); |
| 10892 | MockWrite writes[] = {CreateMockWrite(goaway, 0)}; |
| 10893 | SequencedSocketData data(base::span<MockRead>(), writes); |
| 10894 | |
| 10895 | auto ssl_provider = std::make_unique<SSLSocketDataProvider>(ASYNC, OK); |
| 10896 | // Not a complete HTTP/2 frame. |
| 10897 | ssl_provider->peer_application_settings = "boo"; |
| 10898 | |
| 10899 | NormalSpdyTransactionHelper helper(request_, DEFAULT_PRIORITY, log_, nullptr); |
| 10900 | helper.RunToCompletionWithSSLData(&data, std::move(ssl_provider)); |
| 10901 | |
| 10902 | TransactionHelperResult out = helper.output(); |
| 10903 | EXPECT_THAT(out.rv, IsError(ERR_HTTP2_PROTOCOL_ERROR)); |
| 10904 | |
| 10905 | histogram_tester.ExpectUniqueSample( |
| 10906 | "Net.SpdySession.AlpsDecoderStatus", |
| 10907 | static_cast<int>(AlpsDecoder::Error::kNotOnFrameBoundary), 1); |
| 10908 | histogram_tester.ExpectTotalCount("Net.SpdySession.AlpsAcceptChEntries", 0); |
| 10909 | histogram_tester.ExpectTotalCount("Net.SpdySession.AlpsSettingParameterCount", |
| 10910 | 0); |
| 10911 | } |
| 10912 | |
[email protected] | aea8060 | 2009-09-18 00:55:08 | [diff] [blame] | 10913 | } // namespace net |