moar tests passing #180
Merged
moar tests passing #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,7 @@ var_dump($m->deleteByKey('keffe', '')); | |||
| echo $m->getResultMessage(), "\n"; | |||
| var_dump($m->deleteByKey('', 'keffe')); | |||
| echo $m->getResultMessage(), "\n"; | |||
| var_dump($m->deleteByKey('keffe', '���as�� �a�sd�f asdf')); | |||
| var_dump($m->deleteByKey('keffe', '���as�� �a�sd�f asdf')); # no spaces allowed | |||
There was a problem hiding this comment.
I know it seems like I just changed these to pass, but it really looks like this is the expected result. strchr is ran on the keys everywhere to check for spaces ...
| echo $m->getResultMessage(), "\n"; | ||
|
|
||
| --EXPECTF-- | ||
| bool(false) | ||
| A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE | ||
| bool(false) | ||
| %rCLIENT ERROR|NOT FOUND%r | ||
| A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE |
There was a problem hiding this comment.
this appears to be right, strchr is ran on the key to check for spaces ...
|
Looks like the build fails with /tmp/php-memcached-build/memcached-2.2.0/php_memcached.h:23:33: fatal error: Zend/zend_smart_str.h: No such file or directory |
…ched into moar-tests-passing
|
I was hoping it would be green before merging, but let me get this merged and get the other dependencies tested and then I'll work in php7 branch ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Down to 6 failures ... out of time for today ...
The way value is dtored/reset when unserialized fails is inconsistent for different serializers, don't know if that is intended.
One of the failures remaining is because a cas_token is set unconditionally, but the test seems to expect it to be null still, seems like an anomaly.
Another is because of making objects null in ctor ... I didn't change the test, but making objects null in ctor is a really quite horrible practice, can we leave it in PHP5 ?