Skip to content

moar tests passing #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 1, 2015
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
disable stuff not available for 7 yet
  • Loading branch information
krakjoe committed Sep 1, 2015
commit 3a8c8fd7a016460d683fc68591072fce0a5c0c04
10 changes: 5 additions & 5 deletions .travis/travis.sh
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,11 @@ function run_memcached_tests() {

pushd "${PHP_MEMCACHED_BUILD_DIR}/memcached-${PHP_MEMCACHED_VERSION}"
# We have one xfail test, we run it separately
php run-tests.php -d extension=msgpack.so -d extension=igbinary.so -d extension=memcached.so -n ./tests/expire.phpt
php run-tests.php -d extension=memcached.so -n ./tests/expire.phpt
rm ./tests/expire.phpt

# Run normal tests
php run-tests.php -d extension=msgpack.so -d extension=igbinary.so -d extension=memcached.so -n ./tests/*.phpt
php run-tests.php -d extension=memcached.so -n ./tests/*.phpt
retval=$?
for i in `ls tests/*.out 2>/dev/null`; do
echo "-- START ${i}";
Expand Down Expand Up @@ -213,14 +213,14 @@ case $ACTION in
install_libmemcached

# Install igbinary extension
install_igbinary
# install_igbinary

# install msgpack
install_msgpack
# install_msgpack

# install SASL
if test "x$ENABLE_SASL" = "xyes"; then
install_sasl
# install_sasl
fi
;;

Expand Down
2 changes: 1 addition & 1 deletion php_memcached.c
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ static PHP_METHOD(Memcached, __construct)
zend_fcall_info fci = {0};
zend_fcall_info_cache fci_cache;

if (zend_parse_parameters_throw(ZEND_NUM_ARGS(), "|S!f!S", &persistent_id, &fci, &fci_cache, &conn_str) == FAILURE) {
if (zend_parse_parameters(ZEND_NUM_ARGS(), "|S!f!S", &persistent_id, &fci, &fci_cache, &conn_str) == FAILURE) {
return;
}

Expand Down
13 changes: 8 additions & 5 deletions tests/bad_construct.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Memcached construct with bad arguments
<?php if (!extension_loaded("memcached")) print "skip"; ?>
--FILE--
<?php
error_reporting(0);

$m = new Memcached((object)array());
echo $php_errormsg, "\n";
var_dump($m);
Expand All @@ -21,9 +21,12 @@ var_dump ($extended->setOption (Memcached::OPT_BINARY_PROTOCOL, true));
echo "OK" . PHP_EOL;

--EXPECTF--
Memcached::__construct() expects parameter %s
NULL
Warning: Memcached::__construct() expects parameter 1 to be string, object given in %s on line 3
Memcached::__construct() expects parameter 1 to be string, object given
object(Memcached)#1 (0) {
}

Warning: Memcached::setOption(): Memcached constructor was not called in %s on line %d
Warning: Memcached::setOption(): Memcached constructor was not called in %s on line 14
NULL
OK
OK

2 changes: 1 addition & 1 deletion tests/experimental/get_bykey_cas.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ string(4) "asdf"
float(%d)
SUCCESS
bool(false)
NULL
float(0)
NOT FOUND
bool(false)
NULL
Expand Down