Skip to content

fix windows php8 php_stdint.h path #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2022
Merged

fix windows php8 php_stdint.h path #497

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a06230
fix windows php8 php_stdint.h path
Dec 29, 2021
5a8db86
format code
Dec 30, 2021
0826156
format code
Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions php_memcached_private.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@
#include <ext/standard/basic_functions.h>

#ifdef PHP_WIN32
#if PHP_VERSION_ID >= 80000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent the directive one space

#include "php_stdint.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent two spaces and add a second space to the alternate win32 include line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a win32 test machine myself. If this works for you I'll take your word for it. Is there a release note that we can link to in the comment indicating this was a known change in PHP 8.x?

i compiled dll file
basic usage works fine

#else
# include "win32/php_stdint.h"
#endif
#else
/* Used to store the size of the block */
# if defined(HAVE_INTTYPES_H)
Expand Down