Skip to content

fix windows php8 php_stdint.h path #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 9, 2022
Merged

fix windows php8 php_stdint.h path #497

merged 3 commits into from
Mar 9, 2022

Conversation

lifenglsf
Copy link
Contributor

fix windows php8 php_stdint.h path

sodabrew
sodabrew reviewed Dec 29, 2021
View reviewed changes
Copy link
Contributor

@sodabrew sodabrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a win32 test machine myself. If this works for you I'll take your word for it. Is there a release note that we can link to in the comment indicating this was a known change in PHP 8.x?

php_memcached_private.h Outdated
@@ -48,7 +48,11 @@
#include <ext/standard/basic_functions.h>

#ifdef PHP_WIN32
#if PHP_VERSION_ID >= 80000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent the directive one space

php_memcached_private.h Outdated
@@ -48,7 +48,11 @@
#include <ext/standard/basic_functions.h>

#ifdef PHP_WIN32
#if PHP_VERSION_ID >= 80000
#include "php_stdint.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent two spaces and add a second space to the alternate win32 include line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a win32 test machine myself. If this works for you I'll take your word for it. Is there a release note that we can link to in the comment indicating this was a known change in PHP 8.x?

i compiled dll file
basic usage works fine

@cmb69
Copy link
Contributor

cmb69 commented Mar 9, 2022

Is there a release note that we can link to in the comment indicating this was a known change in PHP 8.x?

See php/php-src#5323. This PR is okay, but for PHP 8 I don't see the need for the platform specific code at all. include "php_stdint.h" should be good for all platforms.

@remicollet remicollet merged commit 7965b8e into php-memcached-dev:master Mar 9, 2022
@lifenglsf
Copy link
Contributor Author

Is there a release note that we can link to in the comment indicating this was a known change in PHP 8.x?

See php/php-src#5323. This PR is okay, but for PHP 8 I don't see the need for the platform specific code at all. include "php_stdint.h" should be good for all platforms.

include "php_stdint.h" worked for php7?

@cmb69
Copy link
Contributor

cmb69 commented Mar 10, 2022

include "php_stdint.h" worked for php7?

No. Only as of PHP 8.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sodabrew sodabrew sodabrew left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lifenglsf @cmb69 @sodabrew @remicollet