[email protected] | e34400c3 | 2012-01-24 02:49:33 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 5 | #include "net/socket/client_socket_pool_base.h" |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 6 | |
tbansal | f82cc8e | 2015-10-14 20:05:49 | [diff] [blame] | 7 | #include <stdint.h> |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 8 | #include <utility> |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 9 | #include <vector> |
| 10 | |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 11 | #include "base/bind.h" |
| 12 | #include "base/bind_helpers.h" |
[email protected] | 2041cf34 | 2010-02-19 03:15:59 | [diff] [blame] | 13 | #include "base/callback.h" |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 14 | #include "base/location.h" |
mmenke | 33d24423d | 2015-05-19 19:41:09 | [diff] [blame] | 15 | #include "base/logging.h" |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 16 | #include "base/macros.h" |
[email protected] | 3b63f8f4 | 2011-03-28 01:54:15 | [diff] [blame] | 17 | #include "base/memory/ref_counted.h" |
[email protected] | 6ea7b15 | 2011-12-21 21:21:13 | [diff] [blame] | 18 | #include "base/memory/weak_ptr.h" |
[email protected] | 18b57741 | 2013-07-18 04:19:15 | [diff] [blame] | 19 | #include "base/message_loop/message_loop.h" |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 20 | #include "base/run_loop.h" |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 21 | #include "base/single_thread_task_runner.h" |
[email protected] | fc9be580 | 2013-06-11 10:56:51 | [diff] [blame] | 22 | #include "base/strings/string_number_conversions.h" |
[email protected] | 18b57741 | 2013-07-18 04:19:15 | [diff] [blame] | 23 | #include "base/strings/stringprintf.h" |
[email protected] | f214f879 | 2011-01-01 02:17:08 | [diff] [blame] | 24 | #include "base/threading/platform_thread.h" |
gab | f767595f | 2016-05-11 18:50:35 | [diff] [blame] | 25 | #include "base/threading/thread_task_runner_handle.h" |
[email protected] | f3a1c64 | 2011-07-12 19:15:03 | [diff] [blame] | 26 | #include "base/values.h" |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 27 | #include "net/base/load_timing_info.h" |
[email protected] | b258e079 | 2013-01-12 07:11:59 | [diff] [blame] | 28 | #include "net/base/load_timing_info_test_util.h" |
[email protected] | d8eb8424 | 2010-09-25 02:25:06 | [diff] [blame] | 29 | #include "net/base/net_errors.h" |
[email protected] | ac790b4 | 2009-12-02 04:31:31 | [diff] [blame] | 30 | #include "net/base/request_priority.h" |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 31 | #include "net/base/test_completion_callback.h" |
[email protected] | 277d594 | 2010-08-11 21:02:35 | [diff] [blame] | 32 | #include "net/http/http_response_headers.h" |
eroman | 87c53d6 | 2015-04-02 06:51:07 | [diff] [blame] | 33 | #include "net/log/net_log.h" |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 34 | #include "net/log/net_log_event_type.h" |
mikecirone | f22f981 | 2016-10-04 03:40:19 | [diff] [blame] | 35 | #include "net/log/net_log_source.h" |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 36 | #include "net/log/net_log_source_type.h" |
mmenke | 16a7cbdd | 2015-04-24 23:00:56 | [diff] [blame] | 37 | #include "net/log/test_net_log.h" |
mmenke | 43758e6 | 2015-05-04 21:09:46 | [diff] [blame] | 38 | #include "net/log/test_net_log_entry.h" |
| 39 | #include "net/log/test_net_log_util.h" |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 40 | #include "net/socket/client_socket_factory.h" |
| 41 | #include "net/socket/client_socket_handle.h" |
tfarina | 5dd13c2 | 2016-11-16 12:08:26 | [diff] [blame] | 42 | #include "net/socket/datagram_client_socket.h" |
tbansal | ca83c00 | 2016-04-28 20:56:28 | [diff] [blame] | 43 | #include "net/socket/socket_performance_watcher.h" |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 44 | #include "net/socket/socket_tag.h" |
[email protected] | 75439d3b | 2009-07-23 22:11:17 | [diff] [blame] | 45 | #include "net/socket/socket_test_util.h" |
[email protected] | 18ccfdb | 2013-08-15 00:13:44 | [diff] [blame] | 46 | #include "net/socket/ssl_client_socket.h" |
[email protected] | 3268023f | 2011-05-05 00:08:10 | [diff] [blame] | 47 | #include "net/socket/stream_socket.h" |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 48 | #include "net/test/gtest_util.h" |
Ramin Halavati | 0a08cc8 | 2018-02-06 07:46:38 | [diff] [blame] | 49 | #include "net/traffic_annotation/network_traffic_annotation_test_helper.h" |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 50 | #include "testing/gmock/include/gmock/gmock.h" |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 51 | #include "testing/gtest/include/gtest/gtest.h" |
| 52 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 53 | using net::test::IsError; |
| 54 | using net::test::IsOk; |
| 55 | |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 56 | using ::testing::Invoke; |
| 57 | using ::testing::Return; |
| 58 | |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 59 | namespace net { |
| 60 | |
| 61 | namespace { |
| 62 | |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 63 | const int kDefaultMaxSockets = 4; |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 64 | const int kDefaultMaxSocketsPerGroup = 2; |
[email protected] | 0b7648c | 2009-07-06 20:14:01 | [diff] [blame] | 65 | |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 66 | // Make sure |handle| sets load times correctly when it has been assigned a |
| 67 | // reused socket. |
| 68 | void TestLoadTimingInfoConnectedReused(const ClientSocketHandle& handle) { |
| 69 | LoadTimingInfo load_timing_info; |
| 70 | // Only pass true in as |is_reused|, as in general, HttpStream types should |
| 71 | // have stricter concepts of reuse than socket pools. |
| 72 | EXPECT_TRUE(handle.GetLoadTimingInfo(true, &load_timing_info)); |
| 73 | |
| 74 | EXPECT_EQ(true, load_timing_info.socket_reused); |
mikecirone | f22f981 | 2016-10-04 03:40:19 | [diff] [blame] | 75 | EXPECT_NE(NetLogSource::kInvalidId, load_timing_info.socket_log_id); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 76 | |
[email protected] | b258e079 | 2013-01-12 07:11:59 | [diff] [blame] | 77 | ExpectConnectTimingHasNoTimes(load_timing_info.connect_timing); |
| 78 | ExpectLoadTimingHasOnlyConnectionTimes(load_timing_info); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 79 | } |
| 80 | |
| 81 | // Make sure |handle| sets load times correctly when it has been assigned a |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 82 | // fresh socket. Also runs TestLoadTimingInfoConnectedReused, since the owner |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 83 | // of a connection where |is_reused| is false may consider the connection |
| 84 | // reused. |
| 85 | void TestLoadTimingInfoConnectedNotReused(const ClientSocketHandle& handle) { |
| 86 | EXPECT_FALSE(handle.is_reused()); |
| 87 | |
| 88 | LoadTimingInfo load_timing_info; |
| 89 | EXPECT_TRUE(handle.GetLoadTimingInfo(false, &load_timing_info)); |
| 90 | |
| 91 | EXPECT_FALSE(load_timing_info.socket_reused); |
mikecirone | f22f981 | 2016-10-04 03:40:19 | [diff] [blame] | 92 | EXPECT_NE(NetLogSource::kInvalidId, load_timing_info.socket_log_id); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 93 | |
[email protected] | b258e079 | 2013-01-12 07:11:59 | [diff] [blame] | 94 | ExpectConnectTimingHasTimes(load_timing_info.connect_timing, |
| 95 | CONNECT_TIMING_HAS_CONNECT_TIMES_ONLY); |
| 96 | ExpectLoadTimingHasOnlyConnectionTimes(load_timing_info); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 97 | |
| 98 | TestLoadTimingInfoConnectedReused(handle); |
| 99 | } |
| 100 | |
| 101 | // Make sure |handle| sets load times correctly, in the case that it does not |
| 102 | // currently have a socket. |
| 103 | void TestLoadTimingInfoNotConnected(const ClientSocketHandle& handle) { |
| 104 | // Should only be set to true once a socket is assigned, if at all. |
| 105 | EXPECT_FALSE(handle.is_reused()); |
| 106 | |
| 107 | LoadTimingInfo load_timing_info; |
| 108 | EXPECT_FALSE(handle.GetLoadTimingInfo(false, &load_timing_info)); |
| 109 | |
| 110 | EXPECT_FALSE(load_timing_info.socket_reused); |
mikecirone | f22f981 | 2016-10-04 03:40:19 | [diff] [blame] | 111 | EXPECT_EQ(NetLogSource::kInvalidId, load_timing_info.socket_log_id); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 112 | |
[email protected] | b258e079 | 2013-01-12 07:11:59 | [diff] [blame] | 113 | ExpectConnectTimingHasNoTimes(load_timing_info.connect_timing); |
| 114 | ExpectLoadTimingHasOnlyConnectionTimes(load_timing_info); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 115 | } |
| 116 | |
[email protected] | df4b4ef | 2010-07-12 18:25:21 | [diff] [blame] | 117 | class TestSocketParams : public base::RefCounted<TestSocketParams> { |
[email protected] | 5acdce1 | 2011-03-30 13:00:20 | [diff] [blame] | 118 | public: |
Chris Watkins | 7a41d355 | 2017-12-01 02:13:27 | [diff] [blame] | 119 | explicit TestSocketParams() = default; |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 120 | |
[email protected] | df4b4ef | 2010-07-12 18:25:21 | [diff] [blame] | 121 | private: |
| 122 | friend class base::RefCounted<TestSocketParams>; |
Chris Watkins | 7a41d355 | 2017-12-01 02:13:27 | [diff] [blame] | 123 | ~TestSocketParams() = default; |
[email protected] | df4b4ef | 2010-07-12 18:25:21 | [diff] [blame] | 124 | }; |
[email protected] | 7fc5b09a | 2010-02-27 00:07:38 | [diff] [blame] | 125 | typedef ClientSocketPoolBase<TestSocketParams> TestClientSocketPoolBase; |
[email protected] | d80a432 | 2009-08-14 07:07:49 | [diff] [blame] | 126 | |
[email protected] | 3268023f | 2011-05-05 00:08:10 | [diff] [blame] | 127 | class MockClientSocket : public StreamSocket { |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 128 | public: |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 129 | explicit MockClientSocket(net::NetLog* net_log) |
| 130 | : connected_(false), |
[email protected] | 0dc88b3 | 2014-03-26 20:12:28 | [diff] [blame] | 131 | has_unread_data_(false), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 132 | net_log_(NetLogWithSource::Make(net_log, NetLogSourceType::SOCKET)), |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 133 | was_used_to_convey_data_(false), |
| 134 | motivation_(HttpRequestInfo::NORMAL_MOTIVATION) {} |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 135 | |
[email protected] | 0dc88b3 | 2014-03-26 20:12:28 | [diff] [blame] | 136 | // Sets whether the socket has unread data. If true, the next call to Read() |
| 137 | // will return 1 byte and IsConnectedAndIdle() will return false. |
| 138 | void set_has_unread_data(bool has_unread_data) { |
| 139 | has_unread_data_ = has_unread_data; |
| 140 | } |
| 141 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 142 | HttpRequestInfo::RequestMotivation motivation() const { return motivation_; } |
| 143 | |
[email protected] | 3f55aa1 | 2011-12-07 02:03:33 | [diff] [blame] | 144 | // Socket implementation. |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 145 | int Read(IOBuffer* /* buf */, |
| 146 | int len, |
| 147 | const CompletionCallback& /* callback */) override { |
[email protected] | 0dc88b3 | 2014-03-26 20:12:28 | [diff] [blame] | 148 | if (has_unread_data_ && len > 0) { |
| 149 | has_unread_data_ = false; |
| 150 | was_used_to_convey_data_ = true; |
| 151 | return 1; |
| 152 | } |
[email protected] | e86df8dc | 2013-03-30 13:18:28 | [diff] [blame] | 153 | return ERR_UNEXPECTED; |
[email protected] | 3f55aa1 | 2011-12-07 02:03:33 | [diff] [blame] | 154 | } |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 155 | |
[email protected] | a2b2cfc | 2017-12-06 09:06:08 | [diff] [blame] | 156 | int Write( |
| 157 | IOBuffer* /* buf */, |
| 158 | int len, |
| 159 | const CompletionCallback& /* callback */, |
| 160 | const NetworkTrafficAnnotationTag& /*traffic_annotation*/) override { |
[email protected] | 0f873e8 | 2010-09-02 16:09:01 | [diff] [blame] | 161 | was_used_to_convey_data_ = true; |
| 162 | return len; |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 163 | } |
Avi Drissman | 13fc893 | 2015-12-20 04:40:46 | [diff] [blame] | 164 | int SetReceiveBufferSize(int32_t size) override { return OK; } |
| 165 | int SetSendBufferSize(int32_t size) override { return OK; } |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 166 | |
[email protected] | dbf036f | 2011-12-06 23:33:24 | [diff] [blame] | 167 | // StreamSocket implementation. |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 168 | int Connect(const CompletionCallback& callback) override { |
[email protected] | dbf036f | 2011-12-06 23:33:24 | [diff] [blame] | 169 | connected_ = true; |
| 170 | return OK; |
| 171 | } |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 172 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 173 | void Disconnect() override { connected_ = false; } |
| 174 | bool IsConnected() const override { return connected_; } |
| 175 | bool IsConnectedAndIdle() const override { |
[email protected] | 0dc88b3 | 2014-03-26 20:12:28 | [diff] [blame] | 176 | return connected_ && !has_unread_data_; |
| 177 | } |
[email protected] | 0b7648c | 2009-07-06 20:14:01 | [diff] [blame] | 178 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 179 | int GetPeerAddress(IPEndPoint* /* address */) const override { |
[email protected] | 9f864b3 | 2010-01-20 15:01:16 | [diff] [blame] | 180 | return ERR_UNEXPECTED; |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 181 | } |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 182 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 183 | int GetLocalAddress(IPEndPoint* /* address */) const override { |
[email protected] | e7f74da | 2011-04-19 23:49:35 | [diff] [blame] | 184 | return ERR_UNEXPECTED; |
| 185 | } |
| 186 | |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 187 | const NetLogWithSource& NetLog() const override { return net_log_; } |
[email protected] | a2006ece | 2010-04-23 16:44:02 | [diff] [blame] | 188 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 189 | void SetSubresourceSpeculation() override { |
| 190 | motivation_ = HttpRequestInfo::PRECONNECT_MOTIVATED; |
| 191 | } |
| 192 | void SetOmniboxSpeculation() override { |
| 193 | motivation_ = HttpRequestInfo::OMNIBOX_MOTIVATED; |
| 194 | } |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 195 | bool WasEverUsed() const override { return was_used_to_convey_data_; } |
tfarina | 2846404c | 2016-12-25 14:31:37 | [diff] [blame] | 196 | bool WasAlpnNegotiated() const override { return false; } |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 197 | NextProto GetNegotiatedProtocol() const override { return kProtoUnknown; } |
| 198 | bool GetSSLInfo(SSLInfo* ssl_info) override { return false; } |
ttuttle | 23fdb7b | 2015-05-15 01:28:03 | [diff] [blame] | 199 | void GetConnectionAttempts(ConnectionAttempts* out) const override { |
| 200 | out->clear(); |
| 201 | } |
| 202 | void ClearConnectionAttempts() override {} |
| 203 | void AddConnectionAttempts(const ConnectionAttempts& attempts) override {} |
tbansal | f82cc8e | 2015-10-14 20:05:49 | [diff] [blame] | 204 | int64_t GetTotalReceivedBytes() const override { |
| 205 | NOTIMPLEMENTED(); |
| 206 | return 0; |
| 207 | } |
Paul Jensen | 0f49dec | 2017-12-12 23:39:58 | [diff] [blame] | 208 | void ApplySocketTag(const SocketTag& tag) override {} |
[email protected] | 9b5614a | 2010-08-25 20:29:45 | [diff] [blame] | 209 | |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 210 | private: |
| 211 | bool connected_; |
[email protected] | 0dc88b3 | 2014-03-26 20:12:28 | [diff] [blame] | 212 | bool has_unread_data_; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 213 | NetLogWithSource net_log_; |
[email protected] | 0f873e8 | 2010-09-02 16:09:01 | [diff] [blame] | 214 | bool was_used_to_convey_data_; |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 215 | HttpRequestInfo::RequestMotivation motivation_; |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 216 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 217 | DISALLOW_COPY_AND_ASSIGN(MockClientSocket); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 218 | }; |
| 219 | |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 220 | class TestConnectJob; |
| 221 | |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 222 | class MockClientSocketFactory : public ClientSocketFactory { |
| 223 | public: |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 224 | MockClientSocketFactory() : allocation_count_(0) {} |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 225 | |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 226 | std::unique_ptr<DatagramClientSocket> CreateDatagramClientSocket( |
[email protected] | 5370c01 | 2011-06-29 03:47:04 | [diff] [blame] | 227 | DatagramSocket::BindType bind_type, |
[email protected] | 98b0e58 | 2011-06-22 14:31:41 | [diff] [blame] | 228 | NetLog* net_log, |
mikecirone | f22f981 | 2016-10-04 03:40:19 | [diff] [blame] | 229 | const NetLogSource& source) override { |
[email protected] | 98b0e58 | 2011-06-22 14:31:41 | [diff] [blame] | 230 | NOTREACHED(); |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 231 | return std::unique_ptr<DatagramClientSocket>(); |
[email protected] | 98b0e58 | 2011-06-22 14:31:41 | [diff] [blame] | 232 | } |
| 233 | |
Helen Li | d5bb922 | 2018-04-12 15:33:09 | [diff] [blame^] | 234 | std::unique_ptr<TransportClientSocket> CreateTransportClientSocket( |
[email protected] | 0a0b768 | 2010-08-25 17:08:07 | [diff] [blame] | 235 | const AddressList& addresses, |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 236 | std::unique_ptr< |
| 237 | SocketPerformanceWatcher> /* socket_performance_watcher */, |
[email protected] | 0a0b768 | 2010-08-25 17:08:07 | [diff] [blame] | 238 | NetLog* /* net_log */, |
mikecirone | f22f981 | 2016-10-04 03:40:19 | [diff] [blame] | 239 | const NetLogSource& /*source*/) override { |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 240 | allocation_count_++; |
Helen Li | d5bb922 | 2018-04-12 15:33:09 | [diff] [blame^] | 241 | return nullptr; |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 242 | } |
| 243 | |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 244 | std::unique_ptr<SSLClientSocket> CreateSSLClientSocket( |
| 245 | std::unique_ptr<ClientSocketHandle> transport_socket, |
[email protected] | 4f4de7e6 | 2010-11-12 19:55:27 | [diff] [blame] | 246 | const HostPortPair& host_and_port, |
[email protected] | 7ab5bbd1 | 2010-10-19 13:33:21 | [diff] [blame] | 247 | const SSLConfig& ssl_config, |
mostynb | ba063d603 | 2014-10-09 11:01:13 | [diff] [blame] | 248 | const SSLClientSocketContext& context) override { |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 249 | NOTIMPLEMENTED(); |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 250 | return std::unique_ptr<SSLClientSocket>(); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 251 | } |
| 252 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 253 | void ClearSSLSessionCache() override { NOTIMPLEMENTED(); } |
[email protected] | 25f4735 | 2011-02-25 16:31:59 | [diff] [blame] | 254 | |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 255 | void WaitForSignal(TestConnectJob* job) { waiting_jobs_.push_back(job); } |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 256 | |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 257 | void SignalJobs(); |
| 258 | |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 259 | void SignalJob(size_t job); |
| 260 | |
| 261 | void SetJobLoadState(size_t job, LoadState load_state); |
| 262 | |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 263 | int allocation_count() const { return allocation_count_; } |
| 264 | |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 265 | private: |
| 266 | int allocation_count_; |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 267 | std::vector<TestConnectJob*> waiting_jobs_; |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 268 | }; |
| 269 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 270 | class TestConnectJob : public ConnectJob { |
| 271 | public: |
| 272 | enum JobType { |
| 273 | kMockJob, |
| 274 | kMockFailingJob, |
| 275 | kMockPendingJob, |
| 276 | kMockPendingFailingJob, |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 277 | kMockWaitingJob, |
[email protected] | e772db3f | 2010-07-12 18:11:13 | [diff] [blame] | 278 | kMockRecoverableJob, |
| 279 | kMockPendingRecoverableJob, |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 280 | kMockAdditionalErrorStateJob, |
| 281 | kMockPendingAdditionalErrorStateJob, |
[email protected] | 0dc88b3 | 2014-03-26 20:12:28 | [diff] [blame] | 282 | kMockUnreadDataJob, |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 283 | }; |
| 284 | |
[email protected] | 994d493 | 2010-07-12 17:55:13 | [diff] [blame] | 285 | // The kMockPendingJob uses a slight delay before allowing the connect |
| 286 | // to complete. |
| 287 | static const int kPendingConnectDelay = 2; |
| 288 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 289 | TestConnectJob(JobType job_type, |
| 290 | const std::string& group_name, |
[email protected] | d80a432 | 2009-08-14 07:07:49 | [diff] [blame] | 291 | const TestClientSocketPoolBase::Request& request, |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 292 | base::TimeDelta timeout_duration, |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 293 | ConnectJob::Delegate* delegate, |
[email protected] | fd7b7c9 | 2009-08-20 19:38:30 | [diff] [blame] | 294 | MockClientSocketFactory* client_socket_factory, |
[email protected] | 06650c5 | 2010-06-03 00:49:17 | [diff] [blame] | 295 | NetLog* net_log) |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 296 | : ConnectJob( |
| 297 | group_name, |
| 298 | timeout_duration, |
| 299 | request.priority(), |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 300 | request.socket_tag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 301 | request.respect_limits(), |
| 302 | delegate, |
davidben | b7048f09 | 2016-11-30 21:20:26 | [diff] [blame] | 303 | NetLogWithSource::Make(net_log, |
| 304 | NetLogSourceType::TRANSPORT_CONNECT_JOB)), |
[email protected] | 2ab05b5 | 2009-07-01 23:57:58 | [diff] [blame] | 305 | job_type_(job_type), |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 306 | client_socket_factory_(client_socket_factory), |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 307 | load_state_(LOAD_STATE_IDLE), |
[email protected] | d5492c5 | 2013-11-10 20:44:39 | [diff] [blame] | 308 | store_additional_error_state_(false), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 309 | weak_factory_(this) {} |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 310 | |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 311 | void Signal() { |
[email protected] | e772db3f | 2010-07-12 18:11:13 | [diff] [blame] | 312 | DoConnect(waiting_success_, true /* async */, false /* recoverable */); |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 313 | } |
| 314 | |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 315 | void set_load_state(LoadState load_state) { load_state_ = load_state; } |
| 316 | |
| 317 | // From ConnectJob: |
| 318 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 319 | LoadState GetLoadState() const override { return load_state_; } |
[email protected] | 4645135 | 2009-09-01 14:54:21 | [diff] [blame] | 320 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 321 | void GetAdditionalErrorState(ClientSocketHandle* handle) override { |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 322 | if (store_additional_error_state_) { |
| 323 | // Set all of the additional error state fields in some way. |
| 324 | handle->set_is_ssl_error(true); |
[email protected] | 8b49869 | 2010-07-16 17:11:43 | [diff] [blame] | 325 | HttpResponseInfo info; |
[email protected] | 007b3f8 | 2013-04-09 08:46:45 | [diff] [blame] | 326 | info.headers = new HttpResponseHeaders(std::string()); |
[email protected] | 8b49869 | 2010-07-16 17:11:43 | [diff] [blame] | 327 | handle->set_ssl_error_response_info(info); |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 328 | } |
| 329 | } |
| 330 | |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 331 | private: |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 332 | // From ConnectJob: |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 333 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 334 | int ConnectInternal() override { |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 335 | AddressList ignored; |
tbansal | 7b403bcc | 2016-04-13 22:33:21 | [diff] [blame] | 336 | client_socket_factory_->CreateTransportClientSocket(ignored, NULL, NULL, |
mikecirone | f22f981 | 2016-10-04 03:40:19 | [diff] [blame] | 337 | NetLogSource()); |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 338 | SetSocket(std::unique_ptr<StreamSocket>( |
| 339 | new MockClientSocket(net_log().net_log()))); |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 340 | switch (job_type_) { |
| 341 | case kMockJob: |
[email protected] | e772db3f | 2010-07-12 18:11:13 | [diff] [blame] | 342 | return DoConnect(true /* successful */, false /* sync */, |
| 343 | false /* recoverable */); |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 344 | case kMockFailingJob: |
[email protected] | e772db3f | 2010-07-12 18:11:13 | [diff] [blame] | 345 | return DoConnect(false /* error */, false /* sync */, |
| 346 | false /* recoverable */); |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 347 | case kMockPendingJob: |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 348 | set_load_state(LOAD_STATE_CONNECTING); |
[email protected] | 6b17538 | 2009-10-13 06:47:47 | [diff] [blame] | 349 | |
| 350 | // Depending on execution timings, posting a delayed task can result |
| 351 | // in the task getting executed the at the earliest possible |
| 352 | // opportunity or only after returning once from the message loop and |
| 353 | // then a second call into the message loop. In order to make behavior |
| 354 | // more deterministic, we change the default delay to 2ms. This should |
| 355 | // always require us to wait for the second call into the message loop. |
| 356 | // |
| 357 | // N.B. The correct fix for this and similar timing problems is to |
| 358 | // abstract time for the purpose of unittests. Unfortunately, we have |
| 359 | // a lot of third-party components that directly call the various |
| 360 | // time functions, so this change would be rather invasive. |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 361 | base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 362 | FROM_HERE, |
[email protected] | 6ea7b15 | 2011-12-21 21:21:13 | [diff] [blame] | 363 | base::Bind(base::IgnoreResult(&TestConnectJob::DoConnect), |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 364 | weak_factory_.GetWeakPtr(), true /* successful */, |
| 365 | true /* async */, false /* recoverable */), |
[email protected] | 5761ab9c | 2012-02-04 16:44:53 | [diff] [blame] | 366 | base::TimeDelta::FromMilliseconds(kPendingConnectDelay)); |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 367 | return ERR_IO_PENDING; |
| 368 | case kMockPendingFailingJob: |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 369 | set_load_state(LOAD_STATE_CONNECTING); |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 370 | base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 371 | FROM_HERE, |
[email protected] | 6ea7b15 | 2011-12-21 21:21:13 | [diff] [blame] | 372 | base::Bind(base::IgnoreResult(&TestConnectJob::DoConnect), |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 373 | weak_factory_.GetWeakPtr(), false /* error */, |
| 374 | true /* async */, false /* recoverable */), |
[email protected] | 5761ab9c | 2012-02-04 16:44:53 | [diff] [blame] | 375 | base::TimeDelta::FromMilliseconds(2)); |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 376 | return ERR_IO_PENDING; |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 377 | case kMockWaitingJob: |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 378 | set_load_state(LOAD_STATE_CONNECTING); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 379 | client_socket_factory_->WaitForSignal(this); |
| 380 | waiting_success_ = true; |
| 381 | return ERR_IO_PENDING; |
[email protected] | e772db3f | 2010-07-12 18:11:13 | [diff] [blame] | 382 | case kMockRecoverableJob: |
| 383 | return DoConnect(false /* error */, false /* sync */, |
| 384 | true /* recoverable */); |
| 385 | case kMockPendingRecoverableJob: |
| 386 | set_load_state(LOAD_STATE_CONNECTING); |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 387 | base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( |
[email protected] | e772db3f | 2010-07-12 18:11:13 | [diff] [blame] | 388 | FROM_HERE, |
[email protected] | 6ea7b15 | 2011-12-21 21:21:13 | [diff] [blame] | 389 | base::Bind(base::IgnoreResult(&TestConnectJob::DoConnect), |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 390 | weak_factory_.GetWeakPtr(), false /* error */, |
| 391 | true /* async */, true /* recoverable */), |
[email protected] | 5761ab9c | 2012-02-04 16:44:53 | [diff] [blame] | 392 | base::TimeDelta::FromMilliseconds(2)); |
[email protected] | e772db3f | 2010-07-12 18:11:13 | [diff] [blame] | 393 | return ERR_IO_PENDING; |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 394 | case kMockAdditionalErrorStateJob: |
| 395 | store_additional_error_state_ = true; |
| 396 | return DoConnect(false /* error */, false /* sync */, |
| 397 | false /* recoverable */); |
| 398 | case kMockPendingAdditionalErrorStateJob: |
| 399 | set_load_state(LOAD_STATE_CONNECTING); |
| 400 | store_additional_error_state_ = true; |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 401 | base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 402 | FROM_HERE, |
[email protected] | 6ea7b15 | 2011-12-21 21:21:13 | [diff] [blame] | 403 | base::Bind(base::IgnoreResult(&TestConnectJob::DoConnect), |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 404 | weak_factory_.GetWeakPtr(), false /* error */, |
| 405 | true /* async */, false /* recoverable */), |
[email protected] | 5761ab9c | 2012-02-04 16:44:53 | [diff] [blame] | 406 | base::TimeDelta::FromMilliseconds(2)); |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 407 | return ERR_IO_PENDING; |
[email protected] | 0dc88b3 | 2014-03-26 20:12:28 | [diff] [blame] | 408 | case kMockUnreadDataJob: { |
| 409 | int ret = DoConnect(true /* successful */, false /* sync */, |
| 410 | false /* recoverable */); |
| 411 | static_cast<MockClientSocket*>(socket())->set_has_unread_data(true); |
| 412 | return ret; |
| 413 | } |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 414 | default: |
| 415 | NOTREACHED(); |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 416 | SetSocket(std::unique_ptr<StreamSocket>()); |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 417 | return ERR_FAILED; |
| 418 | } |
| 419 | } |
| 420 | |
[email protected] | e772db3f | 2010-07-12 18:11:13 | [diff] [blame] | 421 | int DoConnect(bool succeed, bool was_async, bool recoverable) { |
| 422 | int result = OK; |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 423 | if (succeed) { |
[email protected] | 83039bb | 2011-12-09 18:43:55 | [diff] [blame] | 424 | socket()->Connect(CompletionCallback()); |
[email protected] | e772db3f | 2010-07-12 18:11:13 | [diff] [blame] | 425 | } else if (recoverable) { |
| 426 | result = ERR_PROXY_AUTH_REQUESTED; |
[email protected] | 6e713f0 | 2009-08-06 02:56:40 | [diff] [blame] | 427 | } else { |
[email protected] | e772db3f | 2010-07-12 18:11:13 | [diff] [blame] | 428 | result = ERR_CONNECTION_FAILED; |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 429 | SetSocket(std::unique_ptr<StreamSocket>()); |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 430 | } |
[email protected] | 2ab05b5 | 2009-07-01 23:57:58 | [diff] [blame] | 431 | |
| 432 | if (was_async) |
[email protected] | fd7b7c9 | 2009-08-20 19:38:30 | [diff] [blame] | 433 | NotifyDelegateOfCompletion(result); |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 434 | return result; |
| 435 | } |
| 436 | |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 437 | bool waiting_success_; |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 438 | const JobType job_type_; |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 439 | MockClientSocketFactory* const client_socket_factory_; |
[email protected] | 4645135 | 2009-09-01 14:54:21 | [diff] [blame] | 440 | LoadState load_state_; |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 441 | bool store_additional_error_state_; |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 442 | |
[email protected] | d5492c5 | 2013-11-10 20:44:39 | [diff] [blame] | 443 | base::WeakPtrFactory<TestConnectJob> weak_factory_; |
| 444 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 445 | DISALLOW_COPY_AND_ASSIGN(TestConnectJob); |
| 446 | }; |
| 447 | |
[email protected] | d80a432 | 2009-08-14 07:07:49 | [diff] [blame] | 448 | class TestConnectJobFactory |
| 449 | : public TestClientSocketPoolBase::ConnectJobFactory { |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 450 | public: |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 451 | TestConnectJobFactory(MockClientSocketFactory* client_socket_factory, |
| 452 | NetLog* net_log) |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 453 | : job_type_(TestConnectJob::kMockJob), |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 454 | job_types_(NULL), |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 455 | client_socket_factory_(client_socket_factory), |
| 456 | net_log_(net_log) { |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 457 | } |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 458 | |
Chris Watkins | 7a41d355 | 2017-12-01 02:13:27 | [diff] [blame] | 459 | ~TestConnectJobFactory() override = default; |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 460 | |
| 461 | void set_job_type(TestConnectJob::JobType job_type) { job_type_ = job_type; } |
| 462 | |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 463 | void set_job_types(std::list<TestConnectJob::JobType>* job_types) { |
| 464 | job_types_ = job_types; |
| 465 | CHECK(!job_types_->empty()); |
| 466 | } |
| 467 | |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 468 | void set_timeout_duration(base::TimeDelta timeout_duration) { |
| 469 | timeout_duration_ = timeout_duration; |
| 470 | } |
| 471 | |
[email protected] | 3f55aa1 | 2011-12-07 02:03:33 | [diff] [blame] | 472 | // ConnectJobFactory implementation. |
[email protected] | 83039bb | 2011-12-09 18:43:55 | [diff] [blame] | 473 | |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 474 | std::unique_ptr<ConnectJob> NewConnectJob( |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 475 | const std::string& group_name, |
[email protected] | d80a432 | 2009-08-14 07:07:49 | [diff] [blame] | 476 | const TestClientSocketPoolBase::Request& request, |
mostynb | ba063d603 | 2014-10-09 11:01:13 | [diff] [blame] | 477 | ConnectJob::Delegate* delegate) const override { |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 478 | EXPECT_TRUE(!job_types_ || !job_types_->empty()); |
| 479 | TestConnectJob::JobType job_type = job_type_; |
| 480 | if (job_types_ && !job_types_->empty()) { |
| 481 | job_type = job_types_->front(); |
| 482 | job_types_->pop_front(); |
| 483 | } |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 484 | return std::unique_ptr<ConnectJob>( |
| 485 | new TestConnectJob(job_type, group_name, request, timeout_duration_, |
| 486 | delegate, client_socket_factory_, net_log_)); |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 487 | } |
| 488 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 489 | base::TimeDelta ConnectionTimeout() const override { |
[email protected] | a796bcec | 2010-03-22 17:17:26 | [diff] [blame] | 490 | return timeout_duration_; |
| 491 | } |
| 492 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 493 | private: |
| 494 | TestConnectJob::JobType job_type_; |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 495 | std::list<TestConnectJob::JobType>* job_types_; |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 496 | base::TimeDelta timeout_duration_; |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 497 | MockClientSocketFactory* const client_socket_factory_; |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 498 | NetLog* net_log_; |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 499 | |
| 500 | DISALLOW_COPY_AND_ASSIGN(TestConnectJobFactory); |
| 501 | }; |
| 502 | |
| 503 | class TestClientSocketPool : public ClientSocketPool { |
| 504 | public: |
[email protected] | 12322e7e | 2013-08-15 17:49:26 | [diff] [blame] | 505 | typedef TestSocketParams SocketParams; |
| 506 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 507 | TestClientSocketPool( |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 508 | int max_sockets, |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 509 | int max_sockets_per_group, |
[email protected] | 9bf28db | 2009-08-29 01:35:16 | [diff] [blame] | 510 | base::TimeDelta unused_idle_socket_timeout, |
| 511 | base::TimeDelta used_idle_socket_timeout, |
[email protected] | d80a432 | 2009-08-14 07:07:49 | [diff] [blame] | 512 | TestClientSocketPoolBase::ConnectJobFactory* connect_job_factory) |
rkaplow | d90695c | 2015-03-25 22:12:41 | [diff] [blame] | 513 | : base_(NULL, |
| 514 | max_sockets, |
| 515 | max_sockets_per_group, |
| 516 | unused_idle_socket_timeout, |
| 517 | used_idle_socket_timeout, |
[email protected] | 66761b95 | 2010-06-25 21:30:38 | [diff] [blame] | 518 | connect_job_factory) {} |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 519 | |
Chris Watkins | 7a41d355 | 2017-12-01 02:13:27 | [diff] [blame] | 520 | ~TestClientSocketPool() override = default; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 521 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 522 | int RequestSocket(const std::string& group_name, |
| 523 | const void* params, |
ttuttle | 859dc7a | 2015-04-23 19:42:29 | [diff] [blame] | 524 | RequestPriority priority, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 525 | const SocketTag& socket_tag, |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 526 | RespectLimits respect_limits, |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 527 | ClientSocketHandle* handle, |
| 528 | const CompletionCallback& callback, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 529 | const NetLogWithSource& net_log) override { |
[email protected] | df4b4ef | 2010-07-12 18:25:21 | [diff] [blame] | 530 | const scoped_refptr<TestSocketParams>* casted_socket_params = |
| 531 | static_cast<const scoped_refptr<TestSocketParams>*>(params); |
| 532 | return base_.RequestSocket(group_name, *casted_socket_params, priority, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 533 | socket_tag, respect_limits, handle, callback, |
| 534 | net_log); |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 535 | } |
| 536 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 537 | void RequestSockets(const std::string& group_name, |
| 538 | const void* params, |
| 539 | int num_sockets, |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 540 | const NetLogWithSource& net_log, |
| 541 | HttpRequestInfo::RequestMotivation motivation) override { |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 542 | const scoped_refptr<TestSocketParams>* casted_params = |
| 543 | static_cast<const scoped_refptr<TestSocketParams>*>(params); |
| 544 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 545 | base_.RequestSockets(group_name, *casted_params, num_sockets, net_log, |
| 546 | motivation); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 547 | } |
| 548 | |
rdsmith | 29dbad1 | 2017-02-17 02:22:18 | [diff] [blame] | 549 | void SetPriority(const std::string& group_name, |
| 550 | ClientSocketHandle* handle, |
| 551 | RequestPriority priority) override { |
| 552 | base_.SetPriority(group_name, handle, priority); |
| 553 | } |
| 554 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 555 | void CancelRequest(const std::string& group_name, |
| 556 | ClientSocketHandle* handle) override { |
[email protected] | d80a432 | 2009-08-14 07:07:49 | [diff] [blame] | 557 | base_.CancelRequest(group_name, handle); |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 558 | } |
| 559 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 560 | void ReleaseSocket(const std::string& group_name, |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 561 | std::unique_ptr<StreamSocket> socket, |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 562 | int id) override { |
dcheng | c7eeda42 | 2015-12-26 03:56:48 | [diff] [blame] | 563 | base_.ReleaseSocket(group_name, std::move(socket), id); |
[email protected] | a7e3857 | 2010-06-07 18:22:24 | [diff] [blame] | 564 | } |
| 565 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 566 | void FlushWithError(int error) override { base_.FlushWithError(error); } |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 567 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 568 | bool IsStalled() const override { return base_.IsStalled(); } |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 569 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 570 | void CloseIdleSockets() override { base_.CloseIdleSockets(); } |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 571 | |
xunjieli | 92feb33 | 2017-03-03 17:19:23 | [diff] [blame] | 572 | void CloseIdleSocketsInGroup(const std::string& group_name) override { |
| 573 | base_.CloseIdleSocketsInGroup(group_name); |
| 574 | } |
| 575 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 576 | int IdleSocketCount() const override { return base_.idle_socket_count(); } |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 577 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 578 | int IdleSocketCountInGroup(const std::string& group_name) const override { |
[email protected] | d80a432 | 2009-08-14 07:07:49 | [diff] [blame] | 579 | return base_.IdleSocketCountInGroup(group_name); |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 580 | } |
| 581 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 582 | LoadState GetLoadState(const std::string& group_name, |
| 583 | const ClientSocketHandle* handle) const override { |
[email protected] | d80a432 | 2009-08-14 07:07:49 | [diff] [blame] | 584 | return base_.GetLoadState(group_name, handle); |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 585 | } |
| 586 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 587 | void AddHigherLayeredPool(HigherLayeredPool* higher_pool) override { |
[email protected] | 043b68c8 | 2013-08-22 23:41:52 | [diff] [blame] | 588 | base_.AddHigherLayeredPool(higher_pool); |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 589 | } |
| 590 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 591 | void RemoveHigherLayeredPool(HigherLayeredPool* higher_pool) override { |
[email protected] | 043b68c8 | 2013-08-22 23:41:52 | [diff] [blame] | 592 | base_.RemoveHigherLayeredPool(higher_pool); |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 593 | } |
| 594 | |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 595 | std::unique_ptr<base::DictionaryValue> GetInfoAsValue( |
[email protected] | d4dfdab | 2011-12-07 16:56:59 | [diff] [blame] | 596 | const std::string& name, |
| 597 | const std::string& type, |
mostynb | ba063d603 | 2014-10-09 11:01:13 | [diff] [blame] | 598 | bool include_nested_pools) const override { |
[email protected] | 59d7a5a | 2010-08-30 16:44:27 | [diff] [blame] | 599 | return base_.GetInfoAsValue(name, type); |
| 600 | } |
| 601 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 602 | base::TimeDelta ConnectionTimeout() const override { |
[email protected] | a796bcec | 2010-03-22 17:17:26 | [diff] [blame] | 603 | return base_.ConnectionTimeout(); |
| 604 | } |
| 605 | |
[email protected] | d80a432 | 2009-08-14 07:07:49 | [diff] [blame] | 606 | const TestClientSocketPoolBase* base() const { return &base_; } |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 607 | |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 608 | int NumUnassignedConnectJobsInGroup(const std::string& group_name) const { |
| 609 | return base_.NumUnassignedConnectJobsInGroup(group_name); |
| 610 | } |
| 611 | |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 612 | int NumConnectJobsInGroup(const std::string& group_name) const { |
[email protected] | d80a432 | 2009-08-14 07:07:49 | [diff] [blame] | 613 | return base_.NumConnectJobsInGroup(group_name); |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 614 | } |
| 615 | |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 616 | int NumActiveSocketsInGroup(const std::string& group_name) const { |
| 617 | return base_.NumActiveSocketsInGroup(group_name); |
| 618 | } |
| 619 | |
[email protected] | 2abfe90a | 2010-08-25 17:49:51 | [diff] [blame] | 620 | bool HasGroup(const std::string& group_name) const { |
| 621 | return base_.HasGroup(group_name); |
| 622 | } |
| 623 | |
[email protected] | 9bf28db | 2009-08-29 01:35:16 | [diff] [blame] | 624 | void CleanupTimedOutIdleSockets() { base_.CleanupIdleSockets(false); } |
| 625 | |
[email protected] | 06d9404 | 2010-08-25 01:45:22 | [diff] [blame] | 626 | void EnableConnectBackupJobs() { base_.EnableConnectBackupJobs(); } |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 627 | |
[email protected] | 043b68c8 | 2013-08-22 23:41:52 | [diff] [blame] | 628 | bool CloseOneIdleConnectionInHigherLayeredPool() { |
| 629 | return base_.CloseOneIdleConnectionInHigherLayeredPool(); |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 630 | } |
| 631 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 632 | private: |
[email protected] | d80a432 | 2009-08-14 07:07:49 | [diff] [blame] | 633 | TestClientSocketPoolBase base_; |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 634 | |
| 635 | DISALLOW_COPY_AND_ASSIGN(TestClientSocketPool); |
| 636 | }; |
| 637 | |
[email protected] | a937a06d | 2009-08-19 21:19:24 | [diff] [blame] | 638 | } // namespace |
| 639 | |
[email protected] | a937a06d | 2009-08-19 21:19:24 | [diff] [blame] | 640 | namespace { |
| 641 | |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 642 | void MockClientSocketFactory::SignalJobs() { |
| 643 | for (std::vector<TestConnectJob*>::iterator it = waiting_jobs_.begin(); |
| 644 | it != waiting_jobs_.end(); ++it) { |
| 645 | (*it)->Signal(); |
| 646 | } |
| 647 | waiting_jobs_.clear(); |
| 648 | } |
| 649 | |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 650 | void MockClientSocketFactory::SignalJob(size_t job) { |
| 651 | ASSERT_LT(job, waiting_jobs_.size()); |
| 652 | waiting_jobs_[job]->Signal(); |
| 653 | waiting_jobs_.erase(waiting_jobs_.begin() + job); |
| 654 | } |
| 655 | |
| 656 | void MockClientSocketFactory::SetJobLoadState(size_t job, |
| 657 | LoadState load_state) { |
| 658 | ASSERT_LT(job, waiting_jobs_.size()); |
| 659 | waiting_jobs_[job]->set_load_state(load_state); |
| 660 | } |
| 661 | |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 662 | class TestConnectJobDelegate : public ConnectJob::Delegate { |
| 663 | public: |
| 664 | TestConnectJobDelegate() |
| 665 | : have_result_(false), waiting_for_result_(false), result_(OK) {} |
Chris Watkins | 7a41d355 | 2017-12-01 02:13:27 | [diff] [blame] | 666 | ~TestConnectJobDelegate() override = default; |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 667 | |
dcheng | b03027d | 2014-10-21 12:00:20 | [diff] [blame] | 668 | void OnConnectJobComplete(int result, ConnectJob* job) override { |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 669 | result_ = result; |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 670 | std::unique_ptr<ConnectJob> owned_job(job); |
| 671 | std::unique_ptr<StreamSocket> socket = owned_job->PassSocket(); |
[email protected] | 9b6fee1 | 2009-09-29 18:13:07 | [diff] [blame] | 672 | // socket.get() should be NULL iff result != OK |
[email protected] | 18ccfdb | 2013-08-15 00:13:44 | [diff] [blame] | 673 | EXPECT_EQ(socket == NULL, result != OK); |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 674 | have_result_ = true; |
| 675 | if (waiting_for_result_) |
Gabriel Charette | 53a9ef81 | 2017-07-26 12:36:23 | [diff] [blame] | 676 | base::RunLoop::QuitCurrentWhenIdleDeprecated(); |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 677 | } |
| 678 | |
| 679 | int WaitForResult() { |
| 680 | DCHECK(!waiting_for_result_); |
| 681 | while (!have_result_) { |
| 682 | waiting_for_result_ = true; |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 683 | base::RunLoop().Run(); |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 684 | waiting_for_result_ = false; |
| 685 | } |
| 686 | have_result_ = false; // auto-reset for next callback |
| 687 | return result_; |
| 688 | } |
| 689 | |
| 690 | private: |
| 691 | bool have_result_; |
| 692 | bool waiting_for_result_; |
| 693 | int result_; |
| 694 | }; |
| 695 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 696 | class ClientSocketPoolBaseTest : public testing::Test { |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 697 | protected: |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 698 | ClientSocketPoolBaseTest() : params_(new TestSocketParams()) { |
[email protected] | 636b825 | 2011-04-08 19:56:54 | [diff] [blame] | 699 | connect_backup_jobs_enabled_ = |
| 700 | internal::ClientSocketPoolBaseHelper::connect_backup_jobs_enabled(); |
| 701 | internal::ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(true); |
| 702 | } |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 703 | |
dcheng | 67be2b1f | 2014-10-27 21:47:29 | [diff] [blame] | 704 | ~ClientSocketPoolBaseTest() override { |
[email protected] | 636b825 | 2011-04-08 19:56:54 | [diff] [blame] | 705 | internal::ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled( |
| 706 | connect_backup_jobs_enabled_); |
| 707 | } |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 708 | |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 709 | void CreatePool(int max_sockets, int max_sockets_per_group) { |
[email protected] | 9bf28db | 2009-08-29 01:35:16 | [diff] [blame] | 710 | CreatePoolWithIdleTimeouts( |
| 711 | max_sockets, |
| 712 | max_sockets_per_group, |
[email protected] | 82b8c96 | 2011-10-12 09:17:30 | [diff] [blame] | 713 | ClientSocketPool::unused_idle_socket_timeout(), |
| 714 | ClientSocketPool::used_idle_socket_timeout()); |
[email protected] | 9bf28db | 2009-08-29 01:35:16 | [diff] [blame] | 715 | } |
| 716 | |
| 717 | void CreatePoolWithIdleTimeouts( |
| 718 | int max_sockets, int max_sockets_per_group, |
| 719 | base::TimeDelta unused_idle_socket_timeout, |
| 720 | base::TimeDelta used_idle_socket_timeout) { |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 721 | DCHECK(!pool_.get()); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 722 | connect_job_factory_ = new TestConnectJobFactory(&client_socket_factory_, |
| 723 | &net_log_); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 724 | pool_.reset(new TestClientSocketPool(max_sockets, |
| 725 | max_sockets_per_group, |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 726 | unused_idle_socket_timeout, |
| 727 | used_idle_socket_timeout, |
| 728 | connect_job_factory_)); |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 729 | } |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 730 | |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 731 | int StartRequestWithIgnoreLimits( |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 732 | const std::string& group_name, |
| 733 | RequestPriority priority, |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 734 | ClientSocketPool::RespectLimits respect_limits) { |
| 735 | return test_base_.StartRequestUsingPool(pool_.get(), group_name, priority, |
| 736 | respect_limits, params_); |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 737 | } |
| 738 | |
| 739 | int StartRequest(const std::string& group_name, RequestPriority priority) { |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 740 | return StartRequestWithIgnoreLimits( |
| 741 | group_name, priority, ClientSocketPool::RespectLimits::ENABLED); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 742 | } |
| 743 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 744 | int GetOrderOfRequest(size_t index) const { |
| 745 | return test_base_.GetOrderOfRequest(index); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 746 | } |
| 747 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 748 | bool ReleaseOneConnection(ClientSocketPoolTest::KeepAlive keep_alive) { |
| 749 | return test_base_.ReleaseOneConnection(keep_alive); |
| 750 | } |
| 751 | |
| 752 | void ReleaseAllConnections(ClientSocketPoolTest::KeepAlive keep_alive) { |
| 753 | test_base_.ReleaseAllConnections(keep_alive); |
| 754 | } |
| 755 | |
| 756 | TestSocketRequest* request(int i) { return test_base_.request(i); } |
| 757 | size_t requests_size() const { return test_base_.requests_size(); } |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 758 | std::vector<std::unique_ptr<TestSocketRequest>>* requests() { |
olli.raula | 9d66b7d | 2015-11-23 08:30:42 | [diff] [blame] | 759 | return test_base_.requests(); |
| 760 | } |
rdsmith | 29dbad1 | 2017-02-17 02:22:18 | [diff] [blame] | 761 | // Only counts the requests that get sockets asynchronously; |
| 762 | // synchronous completions are not registered by this count. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 763 | size_t completion_count() const { return test_base_.completion_count(); } |
| 764 | |
vishal.b | 62985ca9 | 2015-04-17 08:45:51 | [diff] [blame] | 765 | TestNetLog net_log_; |
[email protected] | 636b825 | 2011-04-08 19:56:54 | [diff] [blame] | 766 | bool connect_backup_jobs_enabled_; |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 767 | MockClientSocketFactory client_socket_factory_; |
[email protected] | 17a0c6c | 2009-08-04 00:07:04 | [diff] [blame] | 768 | TestConnectJobFactory* connect_job_factory_; |
[email protected] | df4b4ef | 2010-07-12 18:25:21 | [diff] [blame] | 769 | scoped_refptr<TestSocketParams> params_; |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 770 | std::unique_ptr<TestClientSocketPool> pool_; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 771 | ClientSocketPoolTest test_base_; |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 772 | }; |
| 773 | |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 774 | // Even though a timeout is specified, it doesn't time out on a synchronous |
| 775 | // completion. |
| 776 | TEST_F(ClientSocketPoolBaseTest, ConnectJob_NoTimeoutOnSynchronousCompletion) { |
| 777 | TestConnectJobDelegate delegate; |
[email protected] | a512f598 | 2009-08-18 16:01:06 | [diff] [blame] | 778 | ClientSocketHandle ignored; |
[email protected] | d80a432 | 2009-08-14 07:07:49 | [diff] [blame] | 779 | TestClientSocketPoolBase::Request request( |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 780 | &ignored, CompletionCallback(), DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 781 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 782 | internal::ClientSocketPoolBaseHelper::NORMAL, params_, |
| 783 | NetLogWithSource()); |
danakj | 655b66c | 2016-04-16 00:51:38 | [diff] [blame] | 784 | std::unique_ptr<TestConnectJob> job( |
| 785 | new TestConnectJob(TestConnectJob::kMockJob, "a", request, |
| 786 | base::TimeDelta::FromMicroseconds(1), &delegate, |
| 787 | &client_socket_factory_, NULL)); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 788 | EXPECT_THAT(job->Connect(), IsOk()); |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 789 | } |
| 790 | |
| 791 | TEST_F(ClientSocketPoolBaseTest, ConnectJob_TimedOut) { |
| 792 | TestConnectJobDelegate delegate; |
[email protected] | a512f598 | 2009-08-18 16:01:06 | [diff] [blame] | 793 | ClientSocketHandle ignored; |
vishal.b | 62985ca9 | 2015-04-17 08:45:51 | [diff] [blame] | 794 | TestNetLog log; |
[email protected] | 9e743cd | 2010-03-16 07:03:53 | [diff] [blame] | 795 | |
[email protected] | d80a432 | 2009-08-14 07:07:49 | [diff] [blame] | 796 | TestClientSocketPoolBase::Request request( |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 797 | &ignored, CompletionCallback(), DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 798 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 799 | internal::ClientSocketPoolBaseHelper::NORMAL, params_, |
| 800 | NetLogWithSource()); |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 801 | // Deleted by TestConnectJobDelegate. |
| 802 | TestConnectJob* job = |
| 803 | new TestConnectJob(TestConnectJob::kMockPendingJob, |
[email protected] | ec08bb2 | 2009-08-12 00:25:12 | [diff] [blame] | 804 | "a", |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 805 | request, |
| 806 | base::TimeDelta::FromMicroseconds(1), |
| 807 | &delegate, |
[email protected] | fd7b7c9 | 2009-08-20 19:38:30 | [diff] [blame] | 808 | &client_socket_factory_, |
[email protected] | 06650c5 | 2010-06-03 00:49:17 | [diff] [blame] | 809 | &log); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 810 | ASSERT_THAT(job->Connect(), IsError(ERR_IO_PENDING)); |
[email protected] | 26b997396 | 2012-01-28 00:57:00 | [diff] [blame] | 811 | base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(1)); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 812 | EXPECT_THAT(delegate.WaitForResult(), IsError(ERR_TIMED_OUT)); |
[email protected] | fd7b7c9 | 2009-08-20 19:38:30 | [diff] [blame] | 813 | |
mmenke | 43758e6 | 2015-05-04 21:09:46 | [diff] [blame] | 814 | TestNetLogEntry::List entries; |
[email protected] | b2fcd0e | 2010-12-01 15:19:40 | [diff] [blame] | 815 | log.GetEntries(&entries); |
| 816 | |
| 817 | EXPECT_EQ(6u, entries.size()); |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 818 | EXPECT_TRUE(LogContainsBeginEvent(entries, 0, |
| 819 | NetLogEventType::SOCKET_POOL_CONNECT_JOB)); |
[email protected] | e9002a9 | 2010-01-29 07:10:46 | [diff] [blame] | 820 | EXPECT_TRUE(LogContainsBeginEvent( |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 821 | entries, 1, NetLogEventType::SOCKET_POOL_CONNECT_JOB_CONNECT)); |
| 822 | EXPECT_TRUE(LogContainsEvent(entries, 2, |
| 823 | NetLogEventType::CONNECT_JOB_SET_SOCKET, |
| 824 | NetLogEventPhase::NONE)); |
[email protected] | e9002a9 | 2010-01-29 07:10:46 | [diff] [blame] | 825 | EXPECT_TRUE(LogContainsEvent( |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 826 | entries, 3, NetLogEventType::SOCKET_POOL_CONNECT_JOB_TIMED_OUT, |
| 827 | NetLogEventPhase::NONE)); |
[email protected] | e9002a9 | 2010-01-29 07:10:46 | [diff] [blame] | 828 | EXPECT_TRUE(LogContainsEndEvent( |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 829 | entries, 4, NetLogEventType::SOCKET_POOL_CONNECT_JOB_CONNECT)); |
| 830 | EXPECT_TRUE(LogContainsEndEvent(entries, 5, |
| 831 | NetLogEventType::SOCKET_POOL_CONNECT_JOB)); |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 832 | } |
| 833 | |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 834 | TEST_F(ClientSocketPoolBaseTest, BasicSynchronous) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 835 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 836 | |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 837 | TestCompletionCallback callback; |
[email protected] | a512f598 | 2009-08-18 16:01:06 | [diff] [blame] | 838 | ClientSocketHandle handle; |
vishal.b | 62985ca9 | 2015-04-17 08:45:51 | [diff] [blame] | 839 | BoundTestNetLog log; |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 840 | TestLoadTimingInfoNotConnected(handle); |
[email protected] | 9e743cd | 2010-03-16 07:03:53 | [diff] [blame] | 841 | |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 842 | EXPECT_EQ(OK, handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 843 | ClientSocketPool::RespectLimits::ENABLED, |
| 844 | callback.callback(), pool_.get(), log.bound())); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 845 | EXPECT_TRUE(handle.is_initialized()); |
| 846 | EXPECT_TRUE(handle.socket()); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 847 | TestLoadTimingInfoConnectedNotReused(handle); |
| 848 | |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 849 | handle.Reset(); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 850 | TestLoadTimingInfoNotConnected(handle); |
[email protected] | fd7b7c9 | 2009-08-20 19:38:30 | [diff] [blame] | 851 | |
mmenke | 43758e6 | 2015-05-04 21:09:46 | [diff] [blame] | 852 | TestNetLogEntry::List entries; |
[email protected] | b2fcd0e | 2010-12-01 15:19:40 | [diff] [blame] | 853 | log.GetEntries(&entries); |
| 854 | |
| 855 | EXPECT_EQ(4u, entries.size()); |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 856 | EXPECT_TRUE(LogContainsBeginEvent(entries, 0, NetLogEventType::SOCKET_POOL)); |
[email protected] | 9e743cd | 2010-03-16 07:03:53 | [diff] [blame] | 857 | EXPECT_TRUE(LogContainsEvent( |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 858 | entries, 1, NetLogEventType::SOCKET_POOL_BOUND_TO_CONNECT_JOB, |
| 859 | NetLogEventPhase::NONE)); |
| 860 | EXPECT_TRUE(LogContainsEvent(entries, 2, |
| 861 | NetLogEventType::SOCKET_POOL_BOUND_TO_SOCKET, |
| 862 | NetLogEventPhase::NONE)); |
| 863 | EXPECT_TRUE(LogContainsEndEvent(entries, 3, NetLogEventType::SOCKET_POOL)); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 864 | } |
| 865 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 866 | TEST_F(ClientSocketPoolBaseTest, InitConnectionFailure) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 867 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 868 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 869 | connect_job_factory_->set_job_type(TestConnectJob::kMockFailingJob); |
vishal.b | 62985ca9 | 2015-04-17 08:45:51 | [diff] [blame] | 870 | BoundTestNetLog log; |
[email protected] | 9e743cd | 2010-03-16 07:03:53 | [diff] [blame] | 871 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 872 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 873 | TestCompletionCallback callback; |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 874 | // Set the additional error state members to ensure that they get cleared. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 875 | handle.set_is_ssl_error(true); |
[email protected] | 8b49869 | 2010-07-16 17:11:43 | [diff] [blame] | 876 | HttpResponseInfo info; |
[email protected] | 007b3f8 | 2013-04-09 08:46:45 | [diff] [blame] | 877 | info.headers = new HttpResponseHeaders(std::string()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 878 | handle.set_ssl_error_response_info(info); |
| 879 | EXPECT_EQ(ERR_CONNECTION_FAILED, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 880 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 881 | ClientSocketPool::RespectLimits::ENABLED, |
| 882 | callback.callback(), pool_.get(), log.bound())); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 883 | EXPECT_FALSE(handle.socket()); |
| 884 | EXPECT_FALSE(handle.is_ssl_error()); |
| 885 | EXPECT_TRUE(handle.ssl_error_response_info().headers.get() == NULL); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 886 | TestLoadTimingInfoNotConnected(handle); |
[email protected] | fd7b7c9 | 2009-08-20 19:38:30 | [diff] [blame] | 887 | |
mmenke | 43758e6 | 2015-05-04 21:09:46 | [diff] [blame] | 888 | TestNetLogEntry::List entries; |
[email protected] | b2fcd0e | 2010-12-01 15:19:40 | [diff] [blame] | 889 | log.GetEntries(&entries); |
| 890 | |
| 891 | EXPECT_EQ(3u, entries.size()); |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 892 | EXPECT_TRUE(LogContainsBeginEvent(entries, 0, NetLogEventType::SOCKET_POOL)); |
[email protected] | 06650c5 | 2010-06-03 00:49:17 | [diff] [blame] | 893 | EXPECT_TRUE(LogContainsEvent( |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 894 | entries, 1, NetLogEventType::SOCKET_POOL_BOUND_TO_CONNECT_JOB, |
| 895 | NetLogEventPhase::NONE)); |
| 896 | EXPECT_TRUE(LogContainsEndEvent(entries, 2, NetLogEventType::SOCKET_POOL)); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 897 | } |
| 898 | |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 899 | TEST_F(ClientSocketPoolBaseTest, TotalLimit) { |
| 900 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 901 | |
[email protected] | 9e743cd | 2010-03-16 07:03:53 | [diff] [blame] | 902 | // TODO(eroman): Check that the NetLog contains this event. |
[email protected] | fd7b7c9 | 2009-08-20 19:38:30 | [diff] [blame] | 903 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 904 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 905 | EXPECT_THAT(StartRequest("b", DEFAULT_PRIORITY), IsOk()); |
| 906 | EXPECT_THAT(StartRequest("c", DEFAULT_PRIORITY), IsOk()); |
| 907 | EXPECT_THAT(StartRequest("d", DEFAULT_PRIORITY), IsOk()); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 908 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 909 | EXPECT_EQ(static_cast<int>(requests_size()), |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 910 | client_socket_factory_.allocation_count()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 911 | EXPECT_EQ(requests_size() - kDefaultMaxSockets, completion_count()); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 912 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 913 | EXPECT_THAT(StartRequest("e", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 914 | EXPECT_THAT(StartRequest("f", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 915 | EXPECT_THAT(StartRequest("g", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 916 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 917 | ReleaseAllConnections(ClientSocketPoolTest::NO_KEEP_ALIVE); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 918 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 919 | EXPECT_EQ(static_cast<int>(requests_size()), |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 920 | client_socket_factory_.allocation_count()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 921 | EXPECT_EQ(requests_size() - kDefaultMaxSockets, completion_count()); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 922 | |
| 923 | EXPECT_EQ(1, GetOrderOfRequest(1)); |
| 924 | EXPECT_EQ(2, GetOrderOfRequest(2)); |
| 925 | EXPECT_EQ(3, GetOrderOfRequest(3)); |
| 926 | EXPECT_EQ(4, GetOrderOfRequest(4)); |
| 927 | EXPECT_EQ(5, GetOrderOfRequest(5)); |
| 928 | EXPECT_EQ(6, GetOrderOfRequest(6)); |
| 929 | EXPECT_EQ(7, GetOrderOfRequest(7)); |
[email protected] | 75439d3b | 2009-07-23 22:11:17 | [diff] [blame] | 930 | |
| 931 | // Make sure we test order of all requests made. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 932 | EXPECT_EQ(ClientSocketPoolTest::kIndexOutOfBounds, GetOrderOfRequest(8)); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 933 | } |
| 934 | |
| 935 | TEST_F(ClientSocketPoolBaseTest, TotalLimitReachedNewGroup) { |
| 936 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 937 | |
[email protected] | 9e743cd | 2010-03-16 07:03:53 | [diff] [blame] | 938 | // TODO(eroman): Check that the NetLog contains this event. |
[email protected] | fd7b7c9 | 2009-08-20 19:38:30 | [diff] [blame] | 939 | |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 940 | // Reach all limits: max total sockets, and max sockets per group. |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 941 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 942 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 943 | EXPECT_THAT(StartRequest("b", DEFAULT_PRIORITY), IsOk()); |
| 944 | EXPECT_THAT(StartRequest("b", DEFAULT_PRIORITY), IsOk()); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 945 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 946 | EXPECT_EQ(static_cast<int>(requests_size()), |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 947 | client_socket_factory_.allocation_count()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 948 | EXPECT_EQ(requests_size() - kDefaultMaxSockets, completion_count()); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 949 | |
| 950 | // Now create a new group and verify that we don't starve it. |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 951 | EXPECT_THAT(StartRequest("c", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 952 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 953 | ReleaseAllConnections(ClientSocketPoolTest::NO_KEEP_ALIVE); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 954 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 955 | EXPECT_EQ(static_cast<int>(requests_size()), |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 956 | client_socket_factory_.allocation_count()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 957 | EXPECT_EQ(requests_size() - kDefaultMaxSockets, completion_count()); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 958 | |
| 959 | EXPECT_EQ(1, GetOrderOfRequest(1)); |
| 960 | EXPECT_EQ(2, GetOrderOfRequest(2)); |
| 961 | EXPECT_EQ(3, GetOrderOfRequest(3)); |
| 962 | EXPECT_EQ(4, GetOrderOfRequest(4)); |
| 963 | EXPECT_EQ(5, GetOrderOfRequest(5)); |
[email protected] | 75439d3b | 2009-07-23 22:11:17 | [diff] [blame] | 964 | |
| 965 | // Make sure we test order of all requests made. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 966 | EXPECT_EQ(ClientSocketPoolTest::kIndexOutOfBounds, GetOrderOfRequest(6)); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 967 | } |
| 968 | |
| 969 | TEST_F(ClientSocketPoolBaseTest, TotalLimitRespectsPriority) { |
| 970 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 971 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 972 | EXPECT_THAT(StartRequest("b", LOWEST), IsOk()); |
| 973 | EXPECT_THAT(StartRequest("a", MEDIUM), IsOk()); |
| 974 | EXPECT_THAT(StartRequest("b", HIGHEST), IsOk()); |
| 975 | EXPECT_THAT(StartRequest("a", LOWEST), IsOk()); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 976 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 977 | EXPECT_EQ(static_cast<int>(requests_size()), |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 978 | client_socket_factory_.allocation_count()); |
| 979 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 980 | EXPECT_THAT(StartRequest("c", LOWEST), IsError(ERR_IO_PENDING)); |
| 981 | EXPECT_THAT(StartRequest("a", MEDIUM), IsError(ERR_IO_PENDING)); |
| 982 | EXPECT_THAT(StartRequest("b", HIGHEST), IsError(ERR_IO_PENDING)); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 983 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 984 | ReleaseAllConnections(ClientSocketPoolTest::NO_KEEP_ALIVE); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 985 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 986 | EXPECT_EQ(requests_size() - kDefaultMaxSockets, completion_count()); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 987 | |
| 988 | // First 4 requests don't have to wait, and finish in order. |
| 989 | EXPECT_EQ(1, GetOrderOfRequest(1)); |
| 990 | EXPECT_EQ(2, GetOrderOfRequest(2)); |
| 991 | EXPECT_EQ(3, GetOrderOfRequest(3)); |
| 992 | EXPECT_EQ(4, GetOrderOfRequest(4)); |
| 993 | |
[email protected] | ac790b4 | 2009-12-02 04:31:31 | [diff] [blame] | 994 | // Request ("b", HIGHEST) has the highest priority, then ("a", MEDIUM), |
| 995 | // and then ("c", LOWEST). |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 996 | EXPECT_EQ(7, GetOrderOfRequest(5)); |
| 997 | EXPECT_EQ(6, GetOrderOfRequest(6)); |
| 998 | EXPECT_EQ(5, GetOrderOfRequest(7)); |
[email protected] | 75439d3b | 2009-07-23 22:11:17 | [diff] [blame] | 999 | |
| 1000 | // Make sure we test order of all requests made. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1001 | EXPECT_EQ(ClientSocketPoolTest::kIndexOutOfBounds, GetOrderOfRequest(9)); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1002 | } |
| 1003 | |
rdsmith | 29dbad1 | 2017-02-17 02:22:18 | [diff] [blame] | 1004 | // Test reprioritizing a request before completion doesn't interfere with |
| 1005 | // its completion. |
| 1006 | TEST_F(ClientSocketPoolBaseTest, ReprioritizeOne) { |
| 1007 | CreatePool(kDefaultMaxSockets, 1); |
| 1008 | |
| 1009 | EXPECT_THAT(StartRequest("a", LOWEST), IsError(OK)); |
| 1010 | EXPECT_THAT(StartRequest("a", MEDIUM), IsError(ERR_IO_PENDING)); |
| 1011 | EXPECT_TRUE(request(0)->handle()->socket()); |
| 1012 | EXPECT_FALSE(request(1)->handle()->socket()); |
| 1013 | |
| 1014 | request(1)->handle()->SetPriority(MEDIUM); |
| 1015 | |
| 1016 | ReleaseOneConnection(ClientSocketPoolTest::NO_KEEP_ALIVE); |
| 1017 | |
| 1018 | EXPECT_TRUE(request(1)->handle()->socket()); |
| 1019 | } |
| 1020 | |
| 1021 | // Reprioritize a request up past another one and make sure that changes the |
| 1022 | // completion order. |
| 1023 | TEST_F(ClientSocketPoolBaseTest, ReprioritizeUpReorder) { |
| 1024 | CreatePool(kDefaultMaxSockets, 1); |
| 1025 | |
| 1026 | EXPECT_THAT(StartRequest("a", LOWEST), IsError(OK)); |
| 1027 | EXPECT_THAT(StartRequest("a", MEDIUM), IsError(ERR_IO_PENDING)); |
| 1028 | EXPECT_THAT(StartRequest("a", LOWEST), IsError(ERR_IO_PENDING)); |
| 1029 | EXPECT_TRUE(request(0)->handle()->socket()); |
| 1030 | EXPECT_FALSE(request(1)->handle()->socket()); |
| 1031 | EXPECT_FALSE(request(2)->handle()->socket()); |
| 1032 | |
| 1033 | request(2)->handle()->SetPriority(HIGHEST); |
| 1034 | |
| 1035 | ReleaseAllConnections(ClientSocketPoolTest::NO_KEEP_ALIVE); |
| 1036 | |
| 1037 | EXPECT_EQ(1, GetOrderOfRequest(1)); |
| 1038 | EXPECT_EQ(3, GetOrderOfRequest(2)); |
| 1039 | EXPECT_EQ(2, GetOrderOfRequest(3)); |
| 1040 | } |
| 1041 | |
| 1042 | // Reprioritize a request without changing relative priorities and check |
| 1043 | // that the order doesn't change. |
| 1044 | TEST_F(ClientSocketPoolBaseTest, ReprioritizeUpNoReorder) { |
| 1045 | CreatePool(kDefaultMaxSockets, 1); |
| 1046 | |
| 1047 | EXPECT_THAT(StartRequest("a", LOWEST), IsError(OK)); |
| 1048 | EXPECT_THAT(StartRequest("a", MEDIUM), IsError(ERR_IO_PENDING)); |
| 1049 | EXPECT_THAT(StartRequest("a", LOW), IsError(ERR_IO_PENDING)); |
| 1050 | EXPECT_TRUE(request(0)->handle()->socket()); |
| 1051 | EXPECT_FALSE(request(1)->handle()->socket()); |
| 1052 | EXPECT_FALSE(request(2)->handle()->socket()); |
| 1053 | |
| 1054 | request(2)->handle()->SetPriority(MEDIUM); |
| 1055 | |
| 1056 | ReleaseAllConnections(ClientSocketPoolTest::NO_KEEP_ALIVE); |
| 1057 | |
| 1058 | EXPECT_EQ(1, GetOrderOfRequest(1)); |
| 1059 | EXPECT_EQ(2, GetOrderOfRequest(2)); |
| 1060 | EXPECT_EQ(3, GetOrderOfRequest(3)); |
| 1061 | } |
| 1062 | |
| 1063 | // Reprioritize a request past down another one and make sure that changes the |
| 1064 | // completion order. |
| 1065 | TEST_F(ClientSocketPoolBaseTest, ReprioritizeDownReorder) { |
| 1066 | CreatePool(kDefaultMaxSockets, 1); |
| 1067 | |
| 1068 | EXPECT_THAT(StartRequest("a", LOWEST), IsError(OK)); |
| 1069 | EXPECT_THAT(StartRequest("a", HIGHEST), IsError(ERR_IO_PENDING)); |
| 1070 | EXPECT_THAT(StartRequest("a", MEDIUM), IsError(ERR_IO_PENDING)); |
| 1071 | EXPECT_TRUE(request(0)->handle()->socket()); |
| 1072 | EXPECT_FALSE(request(1)->handle()->socket()); |
| 1073 | EXPECT_FALSE(request(2)->handle()->socket()); |
| 1074 | |
| 1075 | request(1)->handle()->SetPriority(LOW); |
| 1076 | |
| 1077 | ReleaseAllConnections(ClientSocketPoolTest::NO_KEEP_ALIVE); |
| 1078 | |
| 1079 | EXPECT_EQ(1, GetOrderOfRequest(1)); |
| 1080 | EXPECT_EQ(3, GetOrderOfRequest(2)); |
| 1081 | EXPECT_EQ(2, GetOrderOfRequest(3)); |
| 1082 | } |
| 1083 | |
| 1084 | // Reprioritize a request to the same level as another and confirm it is |
| 1085 | // put after the old request. |
| 1086 | TEST_F(ClientSocketPoolBaseTest, ReprioritizeResetFIFO) { |
| 1087 | CreatePool(kDefaultMaxSockets, 1); |
| 1088 | |
| 1089 | EXPECT_THAT(StartRequest("a", LOWEST), IsError(OK)); |
| 1090 | EXPECT_THAT(StartRequest("a", HIGHEST), IsError(ERR_IO_PENDING)); |
| 1091 | EXPECT_THAT(StartRequest("a", MEDIUM), IsError(ERR_IO_PENDING)); |
| 1092 | EXPECT_TRUE(request(0)->handle()->socket()); |
| 1093 | EXPECT_FALSE(request(1)->handle()->socket()); |
| 1094 | EXPECT_FALSE(request(2)->handle()->socket()); |
| 1095 | |
| 1096 | request(1)->handle()->SetPriority(MEDIUM); |
| 1097 | |
| 1098 | ReleaseAllConnections(ClientSocketPoolTest::NO_KEEP_ALIVE); |
| 1099 | |
| 1100 | EXPECT_EQ(1, GetOrderOfRequest(1)); |
| 1101 | EXPECT_EQ(3, GetOrderOfRequest(2)); |
| 1102 | EXPECT_EQ(2, GetOrderOfRequest(3)); |
| 1103 | } |
| 1104 | |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1105 | TEST_F(ClientSocketPoolBaseTest, TotalLimitRespectsGroupLimit) { |
| 1106 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 1107 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1108 | EXPECT_THAT(StartRequest("a", LOWEST), IsOk()); |
| 1109 | EXPECT_THAT(StartRequest("a", LOW), IsOk()); |
| 1110 | EXPECT_THAT(StartRequest("b", HIGHEST), IsOk()); |
| 1111 | EXPECT_THAT(StartRequest("b", MEDIUM), IsOk()); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1112 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1113 | EXPECT_EQ(static_cast<int>(requests_size()), |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1114 | client_socket_factory_.allocation_count()); |
| 1115 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1116 | EXPECT_THAT(StartRequest("c", MEDIUM), IsError(ERR_IO_PENDING)); |
| 1117 | EXPECT_THAT(StartRequest("a", LOW), IsError(ERR_IO_PENDING)); |
| 1118 | EXPECT_THAT(StartRequest("b", HIGHEST), IsError(ERR_IO_PENDING)); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1119 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1120 | ReleaseAllConnections(ClientSocketPoolTest::NO_KEEP_ALIVE); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1121 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1122 | EXPECT_EQ(static_cast<int>(requests_size()), |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1123 | client_socket_factory_.allocation_count()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1124 | EXPECT_EQ(requests_size() - kDefaultMaxSockets, completion_count()); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1125 | |
| 1126 | // First 4 requests don't have to wait, and finish in order. |
| 1127 | EXPECT_EQ(1, GetOrderOfRequest(1)); |
| 1128 | EXPECT_EQ(2, GetOrderOfRequest(2)); |
| 1129 | EXPECT_EQ(3, GetOrderOfRequest(3)); |
| 1130 | EXPECT_EQ(4, GetOrderOfRequest(4)); |
| 1131 | |
| 1132 | // Request ("b", 7) has the highest priority, but we can't make new socket for |
| 1133 | // group "b", because it has reached the per-group limit. Then we make |
| 1134 | // socket for ("c", 6), because it has higher priority than ("a", 4), |
| 1135 | // and we still can't make a socket for group "b". |
| 1136 | EXPECT_EQ(5, GetOrderOfRequest(5)); |
| 1137 | EXPECT_EQ(6, GetOrderOfRequest(6)); |
| 1138 | EXPECT_EQ(7, GetOrderOfRequest(7)); |
[email protected] | 75439d3b | 2009-07-23 22:11:17 | [diff] [blame] | 1139 | |
| 1140 | // Make sure we test order of all requests made. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1141 | EXPECT_EQ(ClientSocketPoolTest::kIndexOutOfBounds, GetOrderOfRequest(8)); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1142 | } |
| 1143 | |
| 1144 | // Make sure that we count connecting sockets against the total limit. |
| 1145 | TEST_F(ClientSocketPoolBaseTest, TotalLimitCountsConnectingSockets) { |
| 1146 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 1147 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1148 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 1149 | EXPECT_THAT(StartRequest("b", DEFAULT_PRIORITY), IsOk()); |
| 1150 | EXPECT_THAT(StartRequest("c", DEFAULT_PRIORITY), IsOk()); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1151 | |
| 1152 | // Create one asynchronous request. |
| 1153 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1154 | EXPECT_THAT(StartRequest("d", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1155 | |
[email protected] | 6b17538 | 2009-10-13 06:47:47 | [diff] [blame] | 1156 | // We post all of our delayed tasks with a 2ms delay. I.e. they don't |
| 1157 | // actually become pending until 2ms after they have been created. In order |
| 1158 | // to flush all tasks, we need to wait so that we know there are no |
| 1159 | // soon-to-be-pending tasks waiting. |
[email protected] | 26b997396 | 2012-01-28 00:57:00 | [diff] [blame] | 1160 | base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(10)); |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 1161 | base::RunLoop().RunUntilIdle(); |
[email protected] | 6b17538 | 2009-10-13 06:47:47 | [diff] [blame] | 1162 | |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1163 | // The next synchronous request should wait for its turn. |
| 1164 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1165 | EXPECT_THAT(StartRequest("e", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1166 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1167 | ReleaseAllConnections(ClientSocketPoolTest::NO_KEEP_ALIVE); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1168 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1169 | EXPECT_EQ(static_cast<int>(requests_size()), |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1170 | client_socket_factory_.allocation_count()); |
| 1171 | |
| 1172 | EXPECT_EQ(1, GetOrderOfRequest(1)); |
| 1173 | EXPECT_EQ(2, GetOrderOfRequest(2)); |
| 1174 | EXPECT_EQ(3, GetOrderOfRequest(3)); |
| 1175 | EXPECT_EQ(4, GetOrderOfRequest(4)); |
[email protected] | 75439d3b | 2009-07-23 22:11:17 | [diff] [blame] | 1176 | EXPECT_EQ(5, GetOrderOfRequest(5)); |
| 1177 | |
| 1178 | // Make sure we test order of all requests made. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1179 | EXPECT_EQ(ClientSocketPoolTest::kIndexOutOfBounds, GetOrderOfRequest(6)); |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1180 | } |
| 1181 | |
[email protected] | 6427fe2 | 2010-04-16 22:27:41 | [diff] [blame] | 1182 | TEST_F(ClientSocketPoolBaseTest, CorrectlyCountStalledGroups) { |
| 1183 | CreatePool(kDefaultMaxSockets, kDefaultMaxSockets); |
| 1184 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
| 1185 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1186 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 1187 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 1188 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 1189 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
[email protected] | 6427fe2 | 2010-04-16 22:27:41 | [diff] [blame] | 1190 | |
| 1191 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 1192 | |
| 1193 | EXPECT_EQ(kDefaultMaxSockets, client_socket_factory_.allocation_count()); |
| 1194 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1195 | EXPECT_THAT(StartRequest("b", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 1196 | EXPECT_THAT(StartRequest("c", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
[email protected] | 6427fe2 | 2010-04-16 22:27:41 | [diff] [blame] | 1197 | |
| 1198 | EXPECT_EQ(kDefaultMaxSockets, client_socket_factory_.allocation_count()); |
| 1199 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1200 | EXPECT_TRUE(ReleaseOneConnection(ClientSocketPoolTest::KEEP_ALIVE)); |
[email protected] | 6427fe2 | 2010-04-16 22:27:41 | [diff] [blame] | 1201 | EXPECT_EQ(kDefaultMaxSockets + 1, client_socket_factory_.allocation_count()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1202 | EXPECT_TRUE(ReleaseOneConnection(ClientSocketPoolTest::KEEP_ALIVE)); |
[email protected] | 6427fe2 | 2010-04-16 22:27:41 | [diff] [blame] | 1203 | EXPECT_EQ(kDefaultMaxSockets + 2, client_socket_factory_.allocation_count()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1204 | EXPECT_TRUE(ReleaseOneConnection(ClientSocketPoolTest::KEEP_ALIVE)); |
| 1205 | EXPECT_TRUE(ReleaseOneConnection(ClientSocketPoolTest::KEEP_ALIVE)); |
[email protected] | 6427fe2 | 2010-04-16 22:27:41 | [diff] [blame] | 1206 | EXPECT_EQ(kDefaultMaxSockets + 2, client_socket_factory_.allocation_count()); |
| 1207 | } |
| 1208 | |
[email protected] | d7027bb | 2010-05-10 18:58:54 | [diff] [blame] | 1209 | TEST_F(ClientSocketPoolBaseTest, StallAndThenCancelAndTriggerAvailableSocket) { |
| 1210 | CreatePool(kDefaultMaxSockets, kDefaultMaxSockets); |
| 1211 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 1212 | |
| 1213 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1214 | TestCompletionCallback callback; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1215 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1216 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1217 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1218 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | d7027bb | 2010-05-10 18:58:54 | [diff] [blame] | 1219 | |
| 1220 | ClientSocketHandle handles[4]; |
| 1221 | for (size_t i = 0; i < arraysize(handles); ++i) { |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1222 | TestCompletionCallback callback; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1223 | EXPECT_EQ( |
| 1224 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1225 | handles[i].Init("b", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1226 | ClientSocketPool::RespectLimits::ENABLED, |
| 1227 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | d7027bb | 2010-05-10 18:58:54 | [diff] [blame] | 1228 | } |
| 1229 | |
| 1230 | // One will be stalled, cancel all the handles now. |
| 1231 | // This should hit the OnAvailableSocketSlot() code where we previously had |
| 1232 | // stalled groups, but no longer have any. |
| 1233 | for (size_t i = 0; i < arraysize(handles); ++i) |
| 1234 | handles[i].Reset(); |
| 1235 | } |
| 1236 | |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1237 | TEST_F(ClientSocketPoolBaseTest, CancelStalledSocketAtSocketLimit) { |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1238 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 1239 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
| 1240 | |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1241 | { |
| 1242 | ClientSocketHandle handles[kDefaultMaxSockets]; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1243 | TestCompletionCallback callbacks[kDefaultMaxSockets]; |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1244 | for (int i = 0; i < kDefaultMaxSockets; ++i) { |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1245 | EXPECT_EQ(OK, handles[i].Init(base::IntToString(i), params_, |
| 1246 | DEFAULT_PRIORITY, SocketTag(), |
| 1247 | ClientSocketPool::RespectLimits::ENABLED, |
| 1248 | callbacks[i].callback(), pool_.get(), |
| 1249 | NetLogWithSource())); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1250 | } |
| 1251 | |
| 1252 | // Force a stalled group. |
| 1253 | ClientSocketHandle stalled_handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1254 | TestCompletionCallback callback; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1255 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1256 | stalled_handle.Init("foo", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1257 | ClientSocketPool::RespectLimits::ENABLED, |
| 1258 | callback.callback(), pool_.get(), |
| 1259 | NetLogWithSource())); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1260 | |
| 1261 | // Cancel the stalled request. |
| 1262 | stalled_handle.Reset(); |
| 1263 | |
| 1264 | EXPECT_EQ(kDefaultMaxSockets, client_socket_factory_.allocation_count()); |
| 1265 | EXPECT_EQ(0, pool_->IdleSocketCount()); |
| 1266 | |
| 1267 | // Dropping out of scope will close all handles and return them to idle. |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1268 | } |
| 1269 | |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1270 | EXPECT_EQ(kDefaultMaxSockets, client_socket_factory_.allocation_count()); |
| 1271 | EXPECT_EQ(kDefaultMaxSockets, pool_->IdleSocketCount()); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1272 | } |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1273 | |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1274 | TEST_F(ClientSocketPoolBaseTest, CancelPendingSocketAtSocketLimit) { |
| 1275 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 1276 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 1277 | |
| 1278 | { |
| 1279 | ClientSocketHandle handles[kDefaultMaxSockets]; |
| 1280 | for (int i = 0; i < kDefaultMaxSockets; ++i) { |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1281 | TestCompletionCallback callback; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1282 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1283 | handles[i].Init( |
| 1284 | base::IntToString(i), params_, DEFAULT_PRIORITY, |
| 1285 | SocketTag(), ClientSocketPool::RespectLimits::ENABLED, |
| 1286 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1287 | } |
| 1288 | |
| 1289 | // Force a stalled group. |
| 1290 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 1291 | ClientSocketHandle stalled_handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1292 | TestCompletionCallback callback; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1293 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1294 | stalled_handle.Init("foo", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1295 | ClientSocketPool::RespectLimits::ENABLED, |
| 1296 | callback.callback(), pool_.get(), |
| 1297 | NetLogWithSource())); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1298 | |
| 1299 | // Since it is stalled, it should have no connect jobs. |
| 1300 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("foo")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 1301 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("foo")); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1302 | |
| 1303 | // Cancel the stalled request. |
| 1304 | handles[0].Reset(); |
| 1305 | |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1306 | // Now we should have a connect job. |
| 1307 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("foo")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 1308 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("foo")); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1309 | |
| 1310 | // The stalled socket should connect. |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1311 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1312 | |
| 1313 | EXPECT_EQ(kDefaultMaxSockets + 1, |
| 1314 | client_socket_factory_.allocation_count()); |
| 1315 | EXPECT_EQ(0, pool_->IdleSocketCount()); |
| 1316 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("foo")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 1317 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("foo")); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1318 | |
| 1319 | // Dropping out of scope will close all handles and return them to idle. |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1320 | } |
| 1321 | |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1322 | EXPECT_EQ(1, pool_->IdleSocketCount()); |
| 1323 | } |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1324 | |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1325 | TEST_F(ClientSocketPoolBaseTest, WaitForStalledSocketAtSocketLimit) { |
| 1326 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 1327 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1328 | |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1329 | ClientSocketHandle stalled_handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1330 | TestCompletionCallback callback; |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1331 | { |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 1332 | EXPECT_FALSE(pool_->IsStalled()); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1333 | ClientSocketHandle handles[kDefaultMaxSockets]; |
| 1334 | for (int i = 0; i < kDefaultMaxSockets; ++i) { |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1335 | TestCompletionCallback callback; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1336 | EXPECT_EQ(OK, handles[i].Init(base::StringPrintf("Take 2: %d", i), |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1337 | params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1338 | ClientSocketPool::RespectLimits::ENABLED, |
| 1339 | callback.callback(), pool_.get(), |
| 1340 | NetLogWithSource())); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1341 | } |
| 1342 | |
| 1343 | EXPECT_EQ(kDefaultMaxSockets, client_socket_factory_.allocation_count()); |
| 1344 | EXPECT_EQ(0, pool_->IdleSocketCount()); |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 1345 | EXPECT_FALSE(pool_->IsStalled()); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1346 | |
| 1347 | // Now we will hit the socket limit. |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1348 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1349 | stalled_handle.Init("foo", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1350 | ClientSocketPool::RespectLimits::ENABLED, |
| 1351 | callback.callback(), pool_.get(), |
| 1352 | NetLogWithSource())); |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 1353 | EXPECT_TRUE(pool_->IsStalled()); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1354 | |
| 1355 | // Dropping out of scope will close all handles and return them to idle. |
| 1356 | } |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1357 | |
| 1358 | // But if we wait for it, the released idle sockets will be closed in |
| 1359 | // preference of the waiting request. |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1360 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1361 | |
| 1362 | EXPECT_EQ(kDefaultMaxSockets + 1, client_socket_factory_.allocation_count()); |
| 1363 | EXPECT_EQ(3, pool_->IdleSocketCount()); |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1364 | } |
| 1365 | |
| 1366 | // Regression test for http://crbug.com/40952. |
| 1367 | TEST_F(ClientSocketPoolBaseTest, CloseIdleSocketAtSocketLimitDeleteGroup) { |
| 1368 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | 06d9404 | 2010-08-25 01:45:22 | [diff] [blame] | 1369 | pool_->EnableConnectBackupJobs(); |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1370 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
| 1371 | |
| 1372 | for (int i = 0; i < kDefaultMaxSockets; ++i) { |
| 1373 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1374 | TestCompletionCallback callback; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1375 | EXPECT_EQ( |
| 1376 | OK, handle.Init(base::IntToString(i), params_, DEFAULT_PRIORITY, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1377 | SocketTag(), ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1378 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1379 | } |
| 1380 | |
| 1381 | // Flush all the DoReleaseSocket tasks. |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 1382 | base::RunLoop().RunUntilIdle(); |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1383 | |
| 1384 | // Stall a group. Set a pending job so it'll trigger a backup job if we don't |
| 1385 | // reuse a socket. |
| 1386 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 1387 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1388 | TestCompletionCallback callback; |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1389 | |
| 1390 | // "0" is special here, since it should be the first entry in the sorted map, |
| 1391 | // which is the one which we would close an idle socket for. We shouldn't |
| 1392 | // close an idle socket though, since we should reuse the idle socket. |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1393 | EXPECT_EQ(OK, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1394 | handle.Init("0", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1395 | ClientSocketPool::RespectLimits::ENABLED, |
| 1396 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1397 | |
| 1398 | EXPECT_EQ(kDefaultMaxSockets, client_socket_factory_.allocation_count()); |
| 1399 | EXPECT_EQ(kDefaultMaxSockets - 1, pool_->IdleSocketCount()); |
| 1400 | } |
| 1401 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 1402 | TEST_F(ClientSocketPoolBaseTest, PendingRequests) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1403 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1404 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1405 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 1406 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 1407 | EXPECT_THAT(StartRequest("a", IDLE), IsError(ERR_IO_PENDING)); |
| 1408 | EXPECT_THAT(StartRequest("a", LOWEST), IsError(ERR_IO_PENDING)); |
| 1409 | EXPECT_THAT(StartRequest("a", MEDIUM), IsError(ERR_IO_PENDING)); |
| 1410 | EXPECT_THAT(StartRequest("a", HIGHEST), IsError(ERR_IO_PENDING)); |
| 1411 | EXPECT_THAT(StartRequest("a", LOW), IsError(ERR_IO_PENDING)); |
| 1412 | EXPECT_THAT(StartRequest("a", LOWEST), IsError(ERR_IO_PENDING)); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1413 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1414 | ReleaseAllConnections(ClientSocketPoolTest::KEEP_ALIVE); |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1415 | EXPECT_EQ(kDefaultMaxSocketsPerGroup, |
| 1416 | client_socket_factory_.allocation_count()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1417 | EXPECT_EQ(requests_size() - kDefaultMaxSocketsPerGroup, |
| 1418 | completion_count()); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1419 | |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1420 | EXPECT_EQ(1, GetOrderOfRequest(1)); |
| 1421 | EXPECT_EQ(2, GetOrderOfRequest(2)); |
[email protected] | c9c6f5c | 2010-07-31 01:30:03 | [diff] [blame] | 1422 | EXPECT_EQ(8, GetOrderOfRequest(3)); |
| 1423 | EXPECT_EQ(6, GetOrderOfRequest(4)); |
| 1424 | EXPECT_EQ(4, GetOrderOfRequest(5)); |
| 1425 | EXPECT_EQ(3, GetOrderOfRequest(6)); |
| 1426 | EXPECT_EQ(5, GetOrderOfRequest(7)); |
| 1427 | EXPECT_EQ(7, GetOrderOfRequest(8)); |
[email protected] | 75439d3b | 2009-07-23 22:11:17 | [diff] [blame] | 1428 | |
| 1429 | // Make sure we test order of all requests made. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1430 | EXPECT_EQ(ClientSocketPoolTest::kIndexOutOfBounds, GetOrderOfRequest(9)); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1431 | } |
| 1432 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 1433 | TEST_F(ClientSocketPoolBaseTest, PendingRequests_NoKeepAlive) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1434 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1435 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1436 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 1437 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 1438 | EXPECT_THAT(StartRequest("a", LOWEST), IsError(ERR_IO_PENDING)); |
| 1439 | EXPECT_THAT(StartRequest("a", MEDIUM), IsError(ERR_IO_PENDING)); |
| 1440 | EXPECT_THAT(StartRequest("a", HIGHEST), IsError(ERR_IO_PENDING)); |
| 1441 | EXPECT_THAT(StartRequest("a", LOW), IsError(ERR_IO_PENDING)); |
| 1442 | EXPECT_THAT(StartRequest("a", LOWEST), IsError(ERR_IO_PENDING)); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1443 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1444 | ReleaseAllConnections(ClientSocketPoolTest::NO_KEEP_ALIVE); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1445 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1446 | for (size_t i = kDefaultMaxSocketsPerGroup; i < requests_size(); ++i) |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1447 | EXPECT_THAT(request(i)->WaitForResult(), IsOk()); |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1448 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1449 | EXPECT_EQ(static_cast<int>(requests_size()), |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1450 | client_socket_factory_.allocation_count()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1451 | EXPECT_EQ(requests_size() - kDefaultMaxSocketsPerGroup, |
| 1452 | completion_count()); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1453 | } |
| 1454 | |
| 1455 | // This test will start up a RequestSocket() and then immediately Cancel() it. |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 1456 | // The pending connect job will be cancelled and should not call back into |
| 1457 | // ClientSocketPoolBase. |
| 1458 | TEST_F(ClientSocketPoolBaseTest, CancelRequestClearGroup) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1459 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1460 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 1461 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1462 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1463 | TestCompletionCallback callback; |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1464 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1465 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1466 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1467 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1468 | handle.Reset(); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1469 | } |
| 1470 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 1471 | TEST_F(ClientSocketPoolBaseTest, ConnectCancelConnect) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1472 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1473 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 1474 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
[email protected] | a512f598 | 2009-08-18 16:01:06 | [diff] [blame] | 1475 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1476 | TestCompletionCallback callback; |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1477 | |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1478 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1479 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1480 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1481 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1482 | |
| 1483 | handle.Reset(); |
| 1484 | |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1485 | TestCompletionCallback callback2; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1486 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1487 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1488 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1489 | callback2.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1490 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1491 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1492 | EXPECT_FALSE(callback.have_result()); |
| 1493 | |
| 1494 | handle.Reset(); |
| 1495 | } |
| 1496 | |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 1497 | TEST_F(ClientSocketPoolBaseTest, CancelRequest) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1498 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1499 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1500 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 1501 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 1502 | EXPECT_THAT(StartRequest("a", LOWEST), IsError(ERR_IO_PENDING)); |
| 1503 | EXPECT_THAT(StartRequest("a", MEDIUM), IsError(ERR_IO_PENDING)); |
| 1504 | EXPECT_THAT(StartRequest("a", HIGHEST), IsError(ERR_IO_PENDING)); |
| 1505 | EXPECT_THAT(StartRequest("a", LOW), IsError(ERR_IO_PENDING)); |
| 1506 | EXPECT_THAT(StartRequest("a", LOWEST), IsError(ERR_IO_PENDING)); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1507 | |
| 1508 | // Cancel a request. |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1509 | size_t index_to_cancel = kDefaultMaxSocketsPerGroup + 2; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1510 | EXPECT_FALSE((*requests())[index_to_cancel]->handle()->is_initialized()); |
| 1511 | (*requests())[index_to_cancel]->handle()->Reset(); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1512 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1513 | ReleaseAllConnections(ClientSocketPoolTest::KEEP_ALIVE); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1514 | |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1515 | EXPECT_EQ(kDefaultMaxSocketsPerGroup, |
| 1516 | client_socket_factory_.allocation_count()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1517 | EXPECT_EQ(requests_size() - kDefaultMaxSocketsPerGroup - 1, |
| 1518 | completion_count()); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1519 | |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1520 | EXPECT_EQ(1, GetOrderOfRequest(1)); |
| 1521 | EXPECT_EQ(2, GetOrderOfRequest(2)); |
| 1522 | EXPECT_EQ(5, GetOrderOfRequest(3)); |
| 1523 | EXPECT_EQ(3, GetOrderOfRequest(4)); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1524 | EXPECT_EQ(ClientSocketPoolTest::kRequestNotFound, |
| 1525 | GetOrderOfRequest(5)); // Canceled request. |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1526 | EXPECT_EQ(4, GetOrderOfRequest(6)); |
| 1527 | EXPECT_EQ(6, GetOrderOfRequest(7)); |
[email protected] | 75439d3b | 2009-07-23 22:11:17 | [diff] [blame] | 1528 | |
| 1529 | // Make sure we test order of all requests made. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1530 | EXPECT_EQ(ClientSocketPoolTest::kIndexOutOfBounds, GetOrderOfRequest(8)); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1531 | } |
| 1532 | |
mmenke | 33d24423d | 2015-05-19 19:41:09 | [diff] [blame] | 1533 | // Function to be used as a callback on socket request completion. It first |
| 1534 | // disconnects the successfully connected socket from the first request, and |
| 1535 | // then reuses the ClientSocketHandle to request another socket. |
| 1536 | // |
| 1537 | // |nested_callback| is called with the result of the second socket request. |
| 1538 | void RequestSocketOnComplete(ClientSocketHandle* handle, |
| 1539 | TestClientSocketPool* pool, |
| 1540 | TestConnectJobFactory* test_connect_job_factory, |
| 1541 | TestConnectJob::JobType next_job_type, |
| 1542 | const CompletionCallback& nested_callback, |
| 1543 | int first_request_result) { |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1544 | EXPECT_THAT(first_request_result, IsOk()); |
mmenke | 33d24423d | 2015-05-19 19:41:09 | [diff] [blame] | 1545 | |
| 1546 | test_connect_job_factory->set_job_type(next_job_type); |
| 1547 | |
| 1548 | // Don't allow reuse of the socket. Disconnect it and then release it. |
| 1549 | if (handle->socket()) |
| 1550 | handle->socket()->Disconnect(); |
| 1551 | handle->Reset(); |
| 1552 | |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1553 | scoped_refptr<TestSocketParams> params(new TestSocketParams()); |
mmenke | 33d24423d | 2015-05-19 19:41:09 | [diff] [blame] | 1554 | TestCompletionCallback callback; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1555 | int rv = handle->Init("a", params, LOWEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1556 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1557 | nested_callback, pool, NetLogWithSource()); |
mmenke | 33d24423d | 2015-05-19 19:41:09 | [diff] [blame] | 1558 | if (rv != ERR_IO_PENDING) { |
| 1559 | DCHECK_EQ(TestConnectJob::kMockJob, next_job_type); |
| 1560 | nested_callback.Run(rv); |
| 1561 | } else { |
| 1562 | DCHECK_EQ(TestConnectJob::kMockPendingJob, next_job_type); |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1563 | } |
mmenke | 33d24423d | 2015-05-19 19:41:09 | [diff] [blame] | 1564 | } |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1565 | |
mmenke | 33d24423d | 2015-05-19 19:41:09 | [diff] [blame] | 1566 | // Tests the case where a second socket is requested in a completion callback, |
| 1567 | // and the second socket connects asynchronously. Reuses the same |
| 1568 | // ClientSocketHandle for the second socket, after disconnecting the first. |
[email protected] | 2ab05b5 | 2009-07-01 23:57:58 | [diff] [blame] | 1569 | TEST_F(ClientSocketPoolBaseTest, RequestPendingJobTwice) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1570 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1571 | |
[email protected] | 0b7648c | 2009-07-06 20:14:01 | [diff] [blame] | 1572 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
[email protected] | a512f598 | 2009-08-18 16:01:06 | [diff] [blame] | 1573 | ClientSocketHandle handle; |
mmenke | 33d24423d | 2015-05-19 19:41:09 | [diff] [blame] | 1574 | TestCompletionCallback second_result_callback; |
| 1575 | int rv = handle.Init( |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1576 | "a", params_, DEFAULT_PRIORITY, SocketTag(), |
| 1577 | ClientSocketPool::RespectLimits::ENABLED, |
mmenke | 33d24423d | 2015-05-19 19:41:09 | [diff] [blame] | 1578 | base::Bind(&RequestSocketOnComplete, &handle, pool_.get(), |
| 1579 | connect_job_factory_, TestConnectJob::kMockPendingJob, |
| 1580 | second_result_callback.callback()), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1581 | pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1582 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1583 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1584 | EXPECT_THAT(second_result_callback.WaitForResult(), IsOk()); |
[email protected] | 2ab05b5 | 2009-07-01 23:57:58 | [diff] [blame] | 1585 | } |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1586 | |
mmenke | 33d24423d | 2015-05-19 19:41:09 | [diff] [blame] | 1587 | // Tests the case where a second socket is requested in a completion callback, |
| 1588 | // and the second socket connects synchronously. Reuses the same |
| 1589 | // ClientSocketHandle for the second socket, after disconnecting the first. |
[email protected] | 2ab05b5 | 2009-07-01 23:57:58 | [diff] [blame] | 1590 | TEST_F(ClientSocketPoolBaseTest, RequestPendingJobThenSynchronous) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1591 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1592 | |
[email protected] | 0b7648c | 2009-07-06 20:14:01 | [diff] [blame] | 1593 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
[email protected] | a512f598 | 2009-08-18 16:01:06 | [diff] [blame] | 1594 | ClientSocketHandle handle; |
mmenke | 33d24423d | 2015-05-19 19:41:09 | [diff] [blame] | 1595 | TestCompletionCallback second_result_callback; |
| 1596 | int rv = handle.Init( |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1597 | "a", params_, DEFAULT_PRIORITY, SocketTag(), |
| 1598 | ClientSocketPool::RespectLimits::ENABLED, |
mmenke | 33d24423d | 2015-05-19 19:41:09 | [diff] [blame] | 1599 | base::Bind(&RequestSocketOnComplete, &handle, pool_.get(), |
| 1600 | connect_job_factory_, TestConnectJob::kMockPendingJob, |
| 1601 | second_result_callback.callback()), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1602 | pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1603 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 2ab05b5 | 2009-07-01 23:57:58 | [diff] [blame] | 1604 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1605 | EXPECT_THAT(second_result_callback.WaitForResult(), IsOk()); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1606 | } |
| 1607 | |
| 1608 | // Make sure that pending requests get serviced after active requests get |
| 1609 | // cancelled. |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 1610 | TEST_F(ClientSocketPoolBaseTest, CancelActiveRequestWithPendingRequests) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1611 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1612 | |
[email protected] | 0b7648c | 2009-07-06 20:14:01 | [diff] [blame] | 1613 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1614 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1615 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 1616 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 1617 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 1618 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 1619 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 1620 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 1621 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1622 | |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1623 | // Now, kDefaultMaxSocketsPerGroup requests should be active. |
| 1624 | // Let's cancel them. |
| 1625 | for (int i = 0; i < kDefaultMaxSocketsPerGroup; ++i) { |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1626 | ASSERT_FALSE(request(i)->handle()->is_initialized()); |
| 1627 | request(i)->handle()->Reset(); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1628 | } |
| 1629 | |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1630 | // Let's wait for the rest to complete now. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1631 | for (size_t i = kDefaultMaxSocketsPerGroup; i < requests_size(); ++i) { |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1632 | EXPECT_THAT(request(i)->WaitForResult(), IsOk()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1633 | request(i)->handle()->Reset(); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1634 | } |
| 1635 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1636 | EXPECT_EQ(requests_size() - kDefaultMaxSocketsPerGroup, |
| 1637 | completion_count()); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1638 | } |
| 1639 | |
| 1640 | // Make sure that pending requests get serviced after active requests fail. |
[email protected] | ab83889 | 2009-06-30 18:49:05 | [diff] [blame] | 1641 | TEST_F(ClientSocketPoolBaseTest, FailingActiveRequestWithPendingRequests) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1642 | const size_t kMaxSockets = 5; |
| 1643 | CreatePool(kMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | c9d6a1d | 2009-07-14 16:15:20 | [diff] [blame] | 1644 | |
[email protected] | 0b7648c | 2009-07-06 20:14:01 | [diff] [blame] | 1645 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingFailingJob); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1646 | |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1647 | const size_t kNumberOfRequests = 2 * kDefaultMaxSocketsPerGroup + 1; |
| 1648 | ASSERT_LE(kNumberOfRequests, kMaxSockets); // Otherwise the test will hang. |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1649 | |
| 1650 | // Queue up all the requests |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1651 | for (size_t i = 0; i < kNumberOfRequests; ++i) |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1652 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1653 | |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1654 | for (size_t i = 0; i < kNumberOfRequests; ++i) |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1655 | EXPECT_THAT(request(i)->WaitForResult(), IsError(ERR_CONNECTION_FAILED)); |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 1656 | } |
| 1657 | |
mmenke | 9d72fe4 | 2017-05-18 22:36:07 | [diff] [blame] | 1658 | // Make sure that pending requests that complete synchronously get serviced |
| 1659 | // after active requests fail. See https://crbug.com/723748 |
| 1660 | TEST_F(ClientSocketPoolBaseTest, HandleMultipleSyncFailuresAfterAsyncFailure) { |
| 1661 | const size_t kNumberOfRequests = 10; |
| 1662 | const size_t kMaxSockets = 1; |
| 1663 | CreatePool(kMaxSockets, kMaxSockets); |
| 1664 | |
| 1665 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingFailingJob); |
| 1666 | |
| 1667 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 1668 | |
| 1669 | connect_job_factory_->set_job_type(TestConnectJob::kMockFailingJob); |
| 1670 | |
| 1671 | // Queue up all the other requests |
| 1672 | for (size_t i = 1; i < kNumberOfRequests; ++i) |
| 1673 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 1674 | |
| 1675 | // Make sure all requests fail, instead of hanging. |
| 1676 | for (size_t i = 0; i < kNumberOfRequests; ++i) |
| 1677 | EXPECT_THAT(request(i)->WaitForResult(), IsError(ERR_CONNECTION_FAILED)); |
| 1678 | } |
| 1679 | |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1680 | TEST_F(ClientSocketPoolBaseTest, CancelActiveRequestThenRequestSocket) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1681 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1682 | |
| 1683 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 1684 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1685 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1686 | TestCompletionCallback callback; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1687 | int rv = handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1688 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1689 | callback.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1690 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1691 | |
| 1692 | // Cancel the active request. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1693 | handle.Reset(); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1694 | |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1695 | rv = handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1696 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1697 | callback.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1698 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 1699 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1700 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1701 | EXPECT_FALSE(handle.is_reused()); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 1702 | TestLoadTimingInfoConnectedNotReused(handle); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1703 | EXPECT_EQ(2, client_socket_factory_.allocation_count()); |
| 1704 | } |
| 1705 | |
xunjieli | 26619e7 | 2016-11-23 19:39:55 | [diff] [blame] | 1706 | TEST_F(ClientSocketPoolBaseTest, CloseIdleSocketsForced) { |
xunjieli | 26619e7 | 2016-11-23 19:39:55 | [diff] [blame] | 1707 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 1708 | ClientSocketHandle handle; |
| 1709 | TestCompletionCallback callback; |
| 1710 | BoundTestNetLog log; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1711 | int rv = handle.Init("a", params_, LOWEST, SocketTag(), |
xunjieli | 26619e7 | 2016-11-23 19:39:55 | [diff] [blame] | 1712 | ClientSocketPool::RespectLimits::ENABLED, |
| 1713 | callback.callback(), pool_.get(), log.bound()); |
| 1714 | EXPECT_THAT(rv, IsOk()); |
| 1715 | handle.Reset(); |
| 1716 | EXPECT_EQ(1, pool_->IdleSocketCount()); |
| 1717 | pool_->CloseIdleSockets(); |
xunjieli | 26619e7 | 2016-11-23 19:39:55 | [diff] [blame] | 1718 | } |
| 1719 | |
xunjieli | 92feb33 | 2017-03-03 17:19:23 | [diff] [blame] | 1720 | TEST_F(ClientSocketPoolBaseTest, CloseIdleSocketsInGroupForced) { |
xunjieli | 92feb33 | 2017-03-03 17:19:23 | [diff] [blame] | 1721 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 1722 | TestCompletionCallback callback; |
| 1723 | BoundTestNetLog log; |
| 1724 | ClientSocketHandle handle1; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1725 | int rv = handle1.Init("a", params_, LOWEST, SocketTag(), |
xunjieli | 92feb33 | 2017-03-03 17:19:23 | [diff] [blame] | 1726 | ClientSocketPool::RespectLimits::ENABLED, |
| 1727 | callback.callback(), pool_.get(), log.bound()); |
| 1728 | EXPECT_THAT(rv, IsOk()); |
| 1729 | ClientSocketHandle handle2; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1730 | rv = handle2.Init("a", params_, LOWEST, SocketTag(), |
xunjieli | 92feb33 | 2017-03-03 17:19:23 | [diff] [blame] | 1731 | ClientSocketPool::RespectLimits::ENABLED, |
| 1732 | callback.callback(), pool_.get(), log.bound()); |
| 1733 | ClientSocketHandle handle3; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1734 | rv = handle3.Init("b", params_, LOWEST, SocketTag(), |
xunjieli | 92feb33 | 2017-03-03 17:19:23 | [diff] [blame] | 1735 | ClientSocketPool::RespectLimits::ENABLED, |
| 1736 | callback.callback(), pool_.get(), log.bound()); |
| 1737 | EXPECT_THAT(rv, IsOk()); |
| 1738 | handle1.Reset(); |
| 1739 | handle2.Reset(); |
| 1740 | handle3.Reset(); |
| 1741 | EXPECT_EQ(3, pool_->IdleSocketCount()); |
| 1742 | pool_->CloseIdleSocketsInGroup("a"); |
| 1743 | EXPECT_EQ(1, pool_->IdleSocketCount()); |
xunjieli | 92feb33 | 2017-03-03 17:19:23 | [diff] [blame] | 1744 | } |
| 1745 | |
xunjieli | 26619e7 | 2016-11-23 19:39:55 | [diff] [blame] | 1746 | TEST_F(ClientSocketPoolBaseTest, CleanUpUnusableIdleSockets) { |
xunjieli | 26619e7 | 2016-11-23 19:39:55 | [diff] [blame] | 1747 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 1748 | ClientSocketHandle handle; |
| 1749 | TestCompletionCallback callback; |
| 1750 | BoundTestNetLog log; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1751 | int rv = handle.Init("a", params_, LOWEST, SocketTag(), |
xunjieli | 26619e7 | 2016-11-23 19:39:55 | [diff] [blame] | 1752 | ClientSocketPool::RespectLimits::ENABLED, |
| 1753 | callback.callback(), pool_.get(), log.bound()); |
| 1754 | EXPECT_THAT(rv, IsOk()); |
| 1755 | StreamSocket* socket = handle.socket(); |
| 1756 | handle.Reset(); |
| 1757 | EXPECT_EQ(1, pool_->IdleSocketCount()); |
| 1758 | |
| 1759 | // Disconnect socket now to make the socket unusable. |
| 1760 | socket->Disconnect(); |
| 1761 | ClientSocketHandle handle2; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1762 | rv = handle2.Init("a", params_, LOWEST, SocketTag(), |
xunjieli | 26619e7 | 2016-11-23 19:39:55 | [diff] [blame] | 1763 | ClientSocketPool::RespectLimits::ENABLED, |
| 1764 | callback.callback(), pool_.get(), log.bound()); |
| 1765 | EXPECT_THAT(rv, IsOk()); |
| 1766 | EXPECT_FALSE(handle2.is_reused()); |
xunjieli | 26619e7 | 2016-11-23 19:39:55 | [diff] [blame] | 1767 | } |
| 1768 | |
[email protected] | 2b7523d | 2009-07-29 20:29:23 | [diff] [blame] | 1769 | // Regression test for http://crbug.com/17985. |
| 1770 | TEST_F(ClientSocketPoolBaseTest, GroupWithPendingRequestsIsNotEmpty) { |
| 1771 | const int kMaxSockets = 3; |
| 1772 | const int kMaxSocketsPerGroup = 2; |
| 1773 | CreatePool(kMaxSockets, kMaxSocketsPerGroup); |
| 1774 | |
[email protected] | ac790b4 | 2009-12-02 04:31:31 | [diff] [blame] | 1775 | const RequestPriority kHighPriority = HIGHEST; |
[email protected] | 2b7523d | 2009-07-29 20:29:23 | [diff] [blame] | 1776 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1777 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 1778 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
[email protected] | 2b7523d | 2009-07-29 20:29:23 | [diff] [blame] | 1779 | |
| 1780 | // This is going to be a pending request in an otherwise empty group. |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1781 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
[email protected] | 2b7523d | 2009-07-29 20:29:23 | [diff] [blame] | 1782 | |
| 1783 | // Reach the maximum socket limit. |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1784 | EXPECT_THAT(StartRequest("b", DEFAULT_PRIORITY), IsOk()); |
[email protected] | 2b7523d | 2009-07-29 20:29:23 | [diff] [blame] | 1785 | |
| 1786 | // Create a stalled group with high priorities. |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1787 | EXPECT_THAT(StartRequest("c", kHighPriority), IsError(ERR_IO_PENDING)); |
| 1788 | EXPECT_THAT(StartRequest("c", kHighPriority), IsError(ERR_IO_PENDING)); |
[email protected] | 2b7523d | 2009-07-29 20:29:23 | [diff] [blame] | 1789 | |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1790 | // Release the first two sockets from "a". Because this is a keepalive, |
| 1791 | // the first release will unblock the pending request for "a". The |
| 1792 | // second release will unblock a request for "c", becaue it is the next |
| 1793 | // high priority socket. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1794 | EXPECT_TRUE(ReleaseOneConnection(ClientSocketPoolTest::KEEP_ALIVE)); |
| 1795 | EXPECT_TRUE(ReleaseOneConnection(ClientSocketPoolTest::KEEP_ALIVE)); |
[email protected] | 2b7523d | 2009-07-29 20:29:23 | [diff] [blame] | 1796 | |
| 1797 | // Closing idle sockets should not get us into trouble, but in the bug |
| 1798 | // we were hitting a CHECK here. |
[email protected] | 93054cc1 | 2010-06-08 06:12:41 | [diff] [blame] | 1799 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
[email protected] | 43a21b8 | 2010-06-10 21:30:54 | [diff] [blame] | 1800 | pool_->CloseIdleSockets(); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1801 | |
[email protected] | 2da659e | 2013-05-23 20:51:34 | [diff] [blame] | 1802 | // Run the released socket wakeups. |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 1803 | base::RunLoop().RunUntilIdle(); |
[email protected] | 2b7523d | 2009-07-29 20:29:23 | [diff] [blame] | 1804 | } |
| 1805 | |
[email protected] | 4d3b05d | 2010-01-27 21:27:29 | [diff] [blame] | 1806 | TEST_F(ClientSocketPoolBaseTest, BasicAsynchronous) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1807 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1808 | |
| 1809 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1810 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1811 | TestCompletionCallback callback; |
vishal.b | 62985ca9 | 2015-04-17 08:45:51 | [diff] [blame] | 1812 | BoundTestNetLog log; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1813 | int rv = handle.Init("a", params_, LOWEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1814 | ClientSocketPool::RespectLimits::ENABLED, |
| 1815 | callback.callback(), pool_.get(), log.bound()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1816 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1817 | EXPECT_EQ(LOAD_STATE_CONNECTING, pool_->GetLoadState("a", &handle)); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 1818 | TestLoadTimingInfoNotConnected(handle); |
| 1819 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1820 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1821 | EXPECT_TRUE(handle.is_initialized()); |
| 1822 | EXPECT_TRUE(handle.socket()); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 1823 | TestLoadTimingInfoConnectedNotReused(handle); |
| 1824 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1825 | handle.Reset(); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 1826 | TestLoadTimingInfoNotConnected(handle); |
[email protected] | fd7b7c9 | 2009-08-20 19:38:30 | [diff] [blame] | 1827 | |
mmenke | 43758e6 | 2015-05-04 21:09:46 | [diff] [blame] | 1828 | TestNetLogEntry::List entries; |
[email protected] | b2fcd0e | 2010-12-01 15:19:40 | [diff] [blame] | 1829 | log.GetEntries(&entries); |
| 1830 | |
| 1831 | EXPECT_EQ(4u, entries.size()); |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 1832 | EXPECT_TRUE(LogContainsBeginEvent(entries, 0, NetLogEventType::SOCKET_POOL)); |
[email protected] | 06650c5 | 2010-06-03 00:49:17 | [diff] [blame] | 1833 | EXPECT_TRUE(LogContainsEvent( |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 1834 | entries, 1, NetLogEventType::SOCKET_POOL_BOUND_TO_CONNECT_JOB, |
| 1835 | NetLogEventPhase::NONE)); |
| 1836 | EXPECT_TRUE(LogContainsEvent(entries, 2, |
| 1837 | NetLogEventType::SOCKET_POOL_BOUND_TO_SOCKET, |
| 1838 | NetLogEventPhase::NONE)); |
| 1839 | EXPECT_TRUE(LogContainsEndEvent(entries, 3, NetLogEventType::SOCKET_POOL)); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1840 | } |
| 1841 | |
[email protected] | 4d3b05d | 2010-01-27 21:27:29 | [diff] [blame] | 1842 | TEST_F(ClientSocketPoolBaseTest, |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1843 | InitConnectionAsynchronousFailure) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1844 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1845 | |
| 1846 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingFailingJob); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1847 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1848 | TestCompletionCallback callback; |
vishal.b | 62985ca9 | 2015-04-17 08:45:51 | [diff] [blame] | 1849 | BoundTestNetLog log; |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 1850 | // Set the additional error state members to ensure that they get cleared. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1851 | handle.set_is_ssl_error(true); |
[email protected] | 8b49869 | 2010-07-16 17:11:43 | [diff] [blame] | 1852 | HttpResponseInfo info; |
[email protected] | 007b3f8 | 2013-04-09 08:46:45 | [diff] [blame] | 1853 | info.headers = new HttpResponseHeaders(std::string()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1854 | handle.set_ssl_error_response_info(info); |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1855 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1856 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1857 | ClientSocketPool::RespectLimits::ENABLED, |
| 1858 | callback.callback(), pool_.get(), log.bound())); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1859 | EXPECT_EQ(LOAD_STATE_CONNECTING, pool_->GetLoadState("a", &handle)); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1860 | EXPECT_THAT(callback.WaitForResult(), IsError(ERR_CONNECTION_FAILED)); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1861 | EXPECT_FALSE(handle.is_ssl_error()); |
| 1862 | EXPECT_TRUE(handle.ssl_error_response_info().headers.get() == NULL); |
[email protected] | fd7b7c9 | 2009-08-20 19:38:30 | [diff] [blame] | 1863 | |
mmenke | 43758e6 | 2015-05-04 21:09:46 | [diff] [blame] | 1864 | TestNetLogEntry::List entries; |
[email protected] | b2fcd0e | 2010-12-01 15:19:40 | [diff] [blame] | 1865 | log.GetEntries(&entries); |
| 1866 | |
| 1867 | EXPECT_EQ(3u, entries.size()); |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 1868 | EXPECT_TRUE(LogContainsBeginEvent(entries, 0, NetLogEventType::SOCKET_POOL)); |
[email protected] | 06650c5 | 2010-06-03 00:49:17 | [diff] [blame] | 1869 | EXPECT_TRUE(LogContainsEvent( |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 1870 | entries, 1, NetLogEventType::SOCKET_POOL_BOUND_TO_CONNECT_JOB, |
| 1871 | NetLogEventPhase::NONE)); |
| 1872 | EXPECT_TRUE(LogContainsEndEvent(entries, 2, NetLogEventType::SOCKET_POOL)); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1873 | } |
| 1874 | |
mmenke | 6be122f | 2015-03-09 22:22:47 | [diff] [blame] | 1875 | // Check that an async ConnectJob failure does not result in creation of a new |
| 1876 | // ConnectJob when there's another pending request also waiting on its own |
| 1877 | // ConnectJob. See http://crbug.com/463960. |
| 1878 | TEST_F(ClientSocketPoolBaseTest, AsyncFailureWithPendingRequestWithJob) { |
| 1879 | CreatePool(2, 2); |
| 1880 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingFailingJob); |
| 1881 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1882 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 1883 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
mmenke | 6be122f | 2015-03-09 22:22:47 | [diff] [blame] | 1884 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1885 | EXPECT_THAT(request(0)->WaitForResult(), IsError(ERR_CONNECTION_FAILED)); |
| 1886 | EXPECT_THAT(request(1)->WaitForResult(), IsError(ERR_CONNECTION_FAILED)); |
mmenke | 6be122f | 2015-03-09 22:22:47 | [diff] [blame] | 1887 | |
| 1888 | EXPECT_EQ(2, client_socket_factory_.allocation_count()); |
| 1889 | } |
| 1890 | |
[email protected] | 4d3b05d | 2010-01-27 21:27:29 | [diff] [blame] | 1891 | TEST_F(ClientSocketPoolBaseTest, TwoRequestsCancelOne) { |
[email protected] | b22b516 | 2010-03-16 07:53:10 | [diff] [blame] | 1892 | // TODO(eroman): Add back the log expectations! Removed them because the |
| 1893 | // ordering is difficult, and some may fire during destructor. |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1894 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1895 | |
| 1896 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1897 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1898 | TestCompletionCallback callback; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1899 | ClientSocketHandle handle2; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 1900 | TestCompletionCallback callback2; |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1901 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1902 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1903 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1904 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1905 | callback.callback(), pool_.get(), NetLogWithSource())); |
vishal.b | 62985ca9 | 2015-04-17 08:45:51 | [diff] [blame] | 1906 | BoundTestNetLog log2; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1907 | EXPECT_EQ( |
| 1908 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1909 | handle2.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1910 | ClientSocketPool::RespectLimits::ENABLED, |
| 1911 | callback2.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1912 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1913 | handle.Reset(); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1914 | |
[email protected] | fd7b7c9 | 2009-08-20 19:38:30 | [diff] [blame] | 1915 | |
| 1916 | // At this point, request 2 is just waiting for the connect job to finish. |
[email protected] | fd7b7c9 | 2009-08-20 19:38:30 | [diff] [blame] | 1917 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1918 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1919 | handle2.Reset(); |
[email protected] | fd7b7c9 | 2009-08-20 19:38:30 | [diff] [blame] | 1920 | |
| 1921 | // Now request 2 has actually finished. |
[email protected] | 9e743cd | 2010-03-16 07:03:53 | [diff] [blame] | 1922 | // TODO(eroman): Add back log expectations. |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1923 | } |
| 1924 | |
[email protected] | 4d3b05d | 2010-01-27 21:27:29 | [diff] [blame] | 1925 | TEST_F(ClientSocketPoolBaseTest, CancelRequestLimitsJobs) { |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 1926 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 1927 | |
[email protected] | 17a0c6c | 2009-08-04 00:07:04 | [diff] [blame] | 1928 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 1929 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1930 | EXPECT_THAT(StartRequest("a", LOWEST), IsError(ERR_IO_PENDING)); |
| 1931 | EXPECT_THAT(StartRequest("a", LOW), IsError(ERR_IO_PENDING)); |
| 1932 | EXPECT_THAT(StartRequest("a", MEDIUM), IsError(ERR_IO_PENDING)); |
| 1933 | EXPECT_THAT(StartRequest("a", HIGHEST), IsError(ERR_IO_PENDING)); |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 1934 | |
| 1935 | EXPECT_EQ(kDefaultMaxSocketsPerGroup, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1936 | (*requests())[2]->handle()->Reset(); |
| 1937 | (*requests())[3]->handle()->Reset(); |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 1938 | EXPECT_EQ(kDefaultMaxSocketsPerGroup, pool_->NumConnectJobsInGroup("a")); |
| 1939 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1940 | (*requests())[1]->handle()->Reset(); |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 1941 | EXPECT_EQ(kDefaultMaxSocketsPerGroup, pool_->NumConnectJobsInGroup("a")); |
| 1942 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1943 | (*requests())[0]->handle()->Reset(); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 1944 | EXPECT_EQ(kDefaultMaxSocketsPerGroup, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 974ebd6 | 2009-08-03 23:14:34 | [diff] [blame] | 1945 | } |
| 1946 | |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1947 | // When requests and ConnectJobs are not coupled, the request will get serviced |
| 1948 | // by whatever comes first. |
[email protected] | 4d3b05d | 2010-01-27 21:27:29 | [diff] [blame] | 1949 | TEST_F(ClientSocketPoolBaseTest, ReleaseSockets) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 1950 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1951 | |
| 1952 | // Start job 1 (async OK) |
[email protected] | b59ff37 | 2009-07-15 22:04:32 | [diff] [blame] | 1953 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1954 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1955 | std::vector<TestSocketRequest*> request_order; |
| 1956 | size_t completion_count; // unused |
| 1957 | TestSocketRequest req1(&request_order, &completion_count); |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1958 | int rv = |
| 1959 | req1.handle()->Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
| 1960 | ClientSocketPool::RespectLimits::ENABLED, |
| 1961 | req1.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1962 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 1963 | EXPECT_THAT(req1.WaitForResult(), IsOk()); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1964 | |
| 1965 | // Job 1 finished OK. Start job 2 (also async OK). Request 3 is pending |
| 1966 | // without a job. |
| 1967 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 1968 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1969 | TestSocketRequest req2(&request_order, &completion_count); |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1970 | rv = req2.handle()->Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1971 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1972 | req2.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1973 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1974 | TestSocketRequest req3(&request_order, &completion_count); |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 1975 | rv = req3.handle()->Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 1976 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 1977 | req3.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1978 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1979 | |
| 1980 | // Both Requests 2 and 3 are pending. We release socket 1 which should |
| 1981 | // service request 2. Request 3 should still be waiting. |
[email protected] | a6c59f6 | 2009-07-29 16:33:33 | [diff] [blame] | 1982 | req1.handle()->Reset(); |
[email protected] | 2da659e | 2013-05-23 20:51:34 | [diff] [blame] | 1983 | // Run the released socket wakeups. |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 1984 | base::RunLoop().RunUntilIdle(); |
[email protected] | a6c59f6 | 2009-07-29 16:33:33 | [diff] [blame] | 1985 | ASSERT_TRUE(req2.handle()->socket()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1986 | EXPECT_THAT(req2.WaitForResult(), IsOk()); |
[email protected] | a6c59f6 | 2009-07-29 16:33:33 | [diff] [blame] | 1987 | EXPECT_FALSE(req3.handle()->socket()); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1988 | |
| 1989 | // Signal job 2, which should service request 3. |
| 1990 | |
| 1991 | client_socket_factory_.SignalJobs(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 1992 | EXPECT_THAT(req3.WaitForResult(), IsOk()); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1993 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 1994 | ASSERT_EQ(3U, request_order.size()); |
| 1995 | EXPECT_EQ(&req1, request_order[0]); |
| 1996 | EXPECT_EQ(&req2, request_order[1]); |
| 1997 | EXPECT_EQ(&req3, request_order[2]); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 1998 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 1999 | } |
| 2000 | |
| 2001 | // The requests are not coupled to the jobs. So, the requests should finish in |
| 2002 | // their priority / insertion order. |
[email protected] | 4d3b05d | 2010-01-27 21:27:29 | [diff] [blame] | 2003 | TEST_F(ClientSocketPoolBaseTest, PendingJobCompletionOrder) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 2004 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 2005 | // First two jobs are async. |
[email protected] | b59ff37 | 2009-07-15 22:04:32 | [diff] [blame] | 2006 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingFailingJob); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 2007 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2008 | std::vector<TestSocketRequest*> request_order; |
| 2009 | size_t completion_count; // unused |
| 2010 | TestSocketRequest req1(&request_order, &completion_count); |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2011 | int rv = |
| 2012 | req1.handle()->Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
| 2013 | ClientSocketPool::RespectLimits::ENABLED, |
| 2014 | req1.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2015 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 2016 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2017 | TestSocketRequest req2(&request_order, &completion_count); |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2018 | rv = req2.handle()->Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2019 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2020 | req2.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2021 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 2022 | |
| 2023 | // The pending job is sync. |
[email protected] | b59ff37 | 2009-07-15 22:04:32 | [diff] [blame] | 2024 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 2025 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2026 | TestSocketRequest req3(&request_order, &completion_count); |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2027 | rv = req3.handle()->Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2028 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2029 | req3.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2030 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 2031 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2032 | EXPECT_THAT(req1.WaitForResult(), IsError(ERR_CONNECTION_FAILED)); |
| 2033 | EXPECT_THAT(req2.WaitForResult(), IsOk()); |
| 2034 | EXPECT_THAT(req3.WaitForResult(), IsError(ERR_CONNECTION_FAILED)); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 2035 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2036 | ASSERT_EQ(3U, request_order.size()); |
| 2037 | EXPECT_EQ(&req1, request_order[0]); |
| 2038 | EXPECT_EQ(&req2, request_order[1]); |
| 2039 | EXPECT_EQ(&req3, request_order[2]); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 2040 | } |
| 2041 | |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2042 | // Test GetLoadState in the case there's only one socket request. |
| 2043 | TEST_F(ClientSocketPoolBaseTest, LoadStateOneRequest) { |
[email protected] | 211d2172 | 2009-07-22 15:48:53 | [diff] [blame] | 2044 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2045 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 2046 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2047 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2048 | TestCompletionCallback callback; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2049 | int rv = handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2050 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2051 | callback.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2052 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2053 | EXPECT_EQ(LOAD_STATE_CONNECTING, handle.GetLoadState()); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 2054 | |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2055 | client_socket_factory_.SetJobLoadState(0, LOAD_STATE_SSL_HANDSHAKE); |
| 2056 | EXPECT_EQ(LOAD_STATE_SSL_HANDSHAKE, handle.GetLoadState()); |
| 2057 | |
| 2058 | // No point in completing the connection, since ClientSocketHandles only |
| 2059 | // expect the LoadState to be checked while connecting. |
| 2060 | } |
| 2061 | |
| 2062 | // Test GetLoadState in the case there are two socket requests. |
haavardm | 835c1d6 | 2015-04-22 08:18:00 | [diff] [blame] | 2063 | // Only the first connection in the pool should affect the pool's load status. |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2064 | TEST_F(ClientSocketPoolBaseTest, LoadStateTwoRequests) { |
| 2065 | CreatePool(2, 2); |
| 2066 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 2067 | |
| 2068 | ClientSocketHandle handle; |
| 2069 | TestCompletionCallback callback; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2070 | int rv = handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2071 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2072 | callback.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2073 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
haavardm | 835c1d6 | 2015-04-22 08:18:00 | [diff] [blame] | 2074 | client_socket_factory_.SetJobLoadState(0, LOAD_STATE_RESOLVING_HOST); |
| 2075 | |
| 2076 | ClientSocketHandle handle2; |
| 2077 | TestCompletionCallback callback2; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2078 | rv = handle2.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2079 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2080 | callback2.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2081 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
haavardm | 835c1d6 | 2015-04-22 08:18:00 | [diff] [blame] | 2082 | client_socket_factory_.SetJobLoadState(1, LOAD_STATE_RESOLVING_HOST); |
| 2083 | |
| 2084 | // Check that both handles report the state of the first job. |
| 2085 | EXPECT_EQ(LOAD_STATE_RESOLVING_HOST, handle.GetLoadState()); |
| 2086 | EXPECT_EQ(LOAD_STATE_RESOLVING_HOST, handle2.GetLoadState()); |
| 2087 | |
| 2088 | client_socket_factory_.SetJobLoadState(0, LOAD_STATE_CONNECTING); |
| 2089 | |
| 2090 | // Check that both handles change to LOAD_STATE_CONNECTING. |
| 2091 | EXPECT_EQ(LOAD_STATE_CONNECTING, handle.GetLoadState()); |
| 2092 | EXPECT_EQ(LOAD_STATE_CONNECTING, handle2.GetLoadState()); |
| 2093 | } |
| 2094 | |
| 2095 | // Test that the second connection request does not affect the pool's load |
| 2096 | // status. |
| 2097 | TEST_F(ClientSocketPoolBaseTest, LoadStateTwoRequestsChangeSecondRequestState) { |
| 2098 | CreatePool(2, 2); |
| 2099 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 2100 | |
| 2101 | ClientSocketHandle handle; |
| 2102 | TestCompletionCallback callback; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2103 | int rv = handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2104 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2105 | callback.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2106 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 2107 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2108 | ClientSocketHandle handle2; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2109 | TestCompletionCallback callback2; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2110 | rv = handle2.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2111 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2112 | callback2.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2113 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
haavardm | 835c1d6 | 2015-04-22 08:18:00 | [diff] [blame] | 2114 | client_socket_factory_.SetJobLoadState(1, LOAD_STATE_RESOLVING_HOST); |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2115 | |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2116 | EXPECT_EQ(LOAD_STATE_CONNECTING, handle.GetLoadState()); |
| 2117 | EXPECT_EQ(LOAD_STATE_CONNECTING, handle2.GetLoadState()); |
| 2118 | |
haavardm | 835c1d6 | 2015-04-22 08:18:00 | [diff] [blame] | 2119 | // First job connects and the first request gets the socket. The |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2120 | // second handle switches to the state of the remaining ConnectJob. |
| 2121 | client_socket_factory_.SignalJob(0); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2122 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
haavardm | 835c1d6 | 2015-04-22 08:18:00 | [diff] [blame] | 2123 | EXPECT_EQ(LOAD_STATE_RESOLVING_HOST, handle2.GetLoadState()); |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2124 | } |
| 2125 | |
| 2126 | // Test GetLoadState in the case the per-group limit is reached. |
| 2127 | TEST_F(ClientSocketPoolBaseTest, LoadStateGroupLimit) { |
| 2128 | CreatePool(2, 1); |
| 2129 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 2130 | |
| 2131 | ClientSocketHandle handle; |
| 2132 | TestCompletionCallback callback; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2133 | int rv = handle.Init("a", params_, MEDIUM, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2134 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2135 | callback.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2136 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2137 | EXPECT_EQ(LOAD_STATE_CONNECTING, handle.GetLoadState()); |
| 2138 | |
| 2139 | // Request another socket from the same pool, buth with a higher priority. |
| 2140 | // The first request should now be stalled at the socket group limit. |
| 2141 | ClientSocketHandle handle2; |
| 2142 | TestCompletionCallback callback2; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2143 | rv = handle2.Init("a", params_, HIGHEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2144 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2145 | callback2.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2146 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2147 | EXPECT_EQ(LOAD_STATE_WAITING_FOR_AVAILABLE_SOCKET, handle.GetLoadState()); |
| 2148 | EXPECT_EQ(LOAD_STATE_CONNECTING, handle2.GetLoadState()); |
| 2149 | |
| 2150 | // The first handle should remain stalled as the other socket goes through |
| 2151 | // the connect process. |
| 2152 | |
| 2153 | client_socket_factory_.SetJobLoadState(0, LOAD_STATE_SSL_HANDSHAKE); |
| 2154 | EXPECT_EQ(LOAD_STATE_WAITING_FOR_AVAILABLE_SOCKET, handle.GetLoadState()); |
| 2155 | EXPECT_EQ(LOAD_STATE_SSL_HANDSHAKE, handle2.GetLoadState()); |
| 2156 | |
| 2157 | client_socket_factory_.SignalJob(0); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2158 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2159 | EXPECT_EQ(LOAD_STATE_WAITING_FOR_AVAILABLE_SOCKET, handle.GetLoadState()); |
| 2160 | |
| 2161 | // Closing the second socket should cause the stalled handle to finally get a |
| 2162 | // ConnectJob. |
| 2163 | handle2.socket()->Disconnect(); |
| 2164 | handle2.Reset(); |
| 2165 | EXPECT_EQ(LOAD_STATE_CONNECTING, handle.GetLoadState()); |
| 2166 | } |
| 2167 | |
| 2168 | // Test GetLoadState in the case the per-pool limit is reached. |
| 2169 | TEST_F(ClientSocketPoolBaseTest, LoadStatePoolLimit) { |
| 2170 | CreatePool(2, 2); |
| 2171 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 2172 | |
| 2173 | ClientSocketHandle handle; |
| 2174 | TestCompletionCallback callback; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2175 | int rv = handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2176 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2177 | callback.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2178 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2179 | |
| 2180 | // Request for socket from another pool. |
| 2181 | ClientSocketHandle handle2; |
| 2182 | TestCompletionCallback callback2; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2183 | rv = handle2.Init("b", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2184 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2185 | callback2.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2186 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2187 | |
| 2188 | // Request another socket from the first pool. Request should stall at the |
| 2189 | // socket pool limit. |
| 2190 | ClientSocketHandle handle3; |
| 2191 | TestCompletionCallback callback3; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2192 | rv = handle3.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2193 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2194 | callback2.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2195 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2196 | |
| 2197 | // The third handle should remain stalled as the other sockets in its group |
| 2198 | // goes through the connect process. |
| 2199 | |
| 2200 | EXPECT_EQ(LOAD_STATE_CONNECTING, handle.GetLoadState()); |
| 2201 | EXPECT_EQ(LOAD_STATE_WAITING_FOR_STALLED_SOCKET_POOL, handle3.GetLoadState()); |
| 2202 | |
| 2203 | client_socket_factory_.SetJobLoadState(0, LOAD_STATE_SSL_HANDSHAKE); |
| 2204 | EXPECT_EQ(LOAD_STATE_SSL_HANDSHAKE, handle.GetLoadState()); |
| 2205 | EXPECT_EQ(LOAD_STATE_WAITING_FOR_STALLED_SOCKET_POOL, handle3.GetLoadState()); |
| 2206 | |
| 2207 | client_socket_factory_.SignalJob(0); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2208 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | 03b7c8c | 2013-07-20 04:38:55 | [diff] [blame] | 2209 | EXPECT_EQ(LOAD_STATE_WAITING_FOR_STALLED_SOCKET_POOL, handle3.GetLoadState()); |
| 2210 | |
| 2211 | // Closing a socket should allow the stalled handle to finally get a new |
| 2212 | // ConnectJob. |
| 2213 | handle.socket()->Disconnect(); |
| 2214 | handle.Reset(); |
| 2215 | EXPECT_EQ(LOAD_STATE_CONNECTING, handle3.GetLoadState()); |
[email protected] | 5fc08e3 | 2009-07-15 17:09:57 | [diff] [blame] | 2216 | } |
| 2217 | |
[email protected] | e772db3f | 2010-07-12 18:11:13 | [diff] [blame] | 2218 | TEST_F(ClientSocketPoolBaseTest, Recoverable) { |
| 2219 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 2220 | connect_job_factory_->set_job_type(TestConnectJob::kMockRecoverableJob); |
| 2221 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2222 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2223 | TestCompletionCallback callback; |
| 2224 | EXPECT_EQ(ERR_PROXY_AUTH_REQUESTED, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2225 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2226 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2227 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2228 | EXPECT_TRUE(handle.is_initialized()); |
| 2229 | EXPECT_TRUE(handle.socket()); |
[email protected] | e772db3f | 2010-07-12 18:11:13 | [diff] [blame] | 2230 | } |
| 2231 | |
| 2232 | TEST_F(ClientSocketPoolBaseTest, AsyncRecoverable) { |
| 2233 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 2234 | |
| 2235 | connect_job_factory_->set_job_type( |
| 2236 | TestConnectJob::kMockPendingRecoverableJob); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2237 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2238 | TestCompletionCallback callback; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2239 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2240 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2241 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2242 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2243 | EXPECT_EQ(LOAD_STATE_CONNECTING, pool_->GetLoadState("a", &handle)); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2244 | EXPECT_THAT(callback.WaitForResult(), IsError(ERR_PROXY_AUTH_REQUESTED)); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2245 | EXPECT_TRUE(handle.is_initialized()); |
| 2246 | EXPECT_TRUE(handle.socket()); |
[email protected] | e772db3f | 2010-07-12 18:11:13 | [diff] [blame] | 2247 | } |
| 2248 | |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 2249 | TEST_F(ClientSocketPoolBaseTest, AdditionalErrorStateSynchronous) { |
| 2250 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 2251 | connect_job_factory_->set_job_type( |
| 2252 | TestConnectJob::kMockAdditionalErrorStateJob); |
| 2253 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2254 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2255 | TestCompletionCallback callback; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2256 | EXPECT_EQ(ERR_CONNECTION_FAILED, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2257 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2258 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2259 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2260 | EXPECT_FALSE(handle.is_initialized()); |
| 2261 | EXPECT_FALSE(handle.socket()); |
| 2262 | EXPECT_TRUE(handle.is_ssl_error()); |
| 2263 | EXPECT_FALSE(handle.ssl_error_response_info().headers.get() == NULL); |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 2264 | } |
| 2265 | |
| 2266 | TEST_F(ClientSocketPoolBaseTest, AdditionalErrorStateAsynchronous) { |
| 2267 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 2268 | |
| 2269 | connect_job_factory_->set_job_type( |
| 2270 | TestConnectJob::kMockPendingAdditionalErrorStateJob); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2271 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2272 | TestCompletionCallback callback; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2273 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2274 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2275 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2276 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2277 | EXPECT_EQ(LOAD_STATE_CONNECTING, pool_->GetLoadState("a", &handle)); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2278 | EXPECT_THAT(callback.WaitForResult(), IsError(ERR_CONNECTION_FAILED)); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2279 | EXPECT_FALSE(handle.is_initialized()); |
| 2280 | EXPECT_FALSE(handle.socket()); |
| 2281 | EXPECT_TRUE(handle.is_ssl_error()); |
| 2282 | EXPECT_FALSE(handle.ssl_error_response_info().headers.get() == NULL); |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 2283 | } |
| 2284 | |
martijn | 003cd61 | 2016-05-19 22:24:38 | [diff] [blame] | 2285 | // Make sure we can reuse sockets. |
| 2286 | TEST_F(ClientSocketPoolBaseTest, CleanupTimedOutIdleSocketsReuse) { |
[email protected] | 64770b7d | 2011-11-16 04:30:41 | [diff] [blame] | 2287 | CreatePoolWithIdleTimeouts( |
| 2288 | kDefaultMaxSockets, kDefaultMaxSocketsPerGroup, |
[email protected] | e7b1c6d2c | 2012-05-05 00:54:03 | [diff] [blame] | 2289 | base::TimeDelta(), // Time out unused sockets immediately. |
| 2290 | base::TimeDelta::FromDays(1)); // Don't time out used sockets. |
| 2291 | |
| 2292 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 2293 | |
| 2294 | ClientSocketHandle handle; |
| 2295 | TestCompletionCallback callback; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2296 | int rv = handle.Init("a", params_, LOWEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2297 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2298 | callback.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2299 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | e7b1c6d2c | 2012-05-05 00:54:03 | [diff] [blame] | 2300 | EXPECT_EQ(LOAD_STATE_CONNECTING, pool_->GetLoadState("a", &handle)); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2301 | ASSERT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | e7b1c6d2c | 2012-05-05 00:54:03 | [diff] [blame] | 2302 | |
| 2303 | // Use and release the socket. |
Ramin Halavati | 0a08cc8 | 2018-02-06 07:46:38 | [diff] [blame] | 2304 | EXPECT_EQ(1, handle.socket()->Write(NULL, 1, CompletionCallback(), |
| 2305 | TRAFFIC_ANNOTATION_FOR_TESTS)); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 2306 | TestLoadTimingInfoConnectedNotReused(handle); |
[email protected] | e7b1c6d2c | 2012-05-05 00:54:03 | [diff] [blame] | 2307 | handle.Reset(); |
| 2308 | |
| 2309 | // Should now have one idle socket. |
| 2310 | ASSERT_EQ(1, pool_->IdleSocketCount()); |
| 2311 | |
| 2312 | // Request a new socket. This should reuse the old socket and complete |
| 2313 | // synchronously. |
vishal.b | 62985ca9 | 2015-04-17 08:45:51 | [diff] [blame] | 2314 | BoundTestNetLog log; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2315 | rv = handle.Init("a", params_, LOWEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2316 | ClientSocketPool::RespectLimits::ENABLED, |
| 2317 | CompletionCallback(), pool_.get(), log.bound()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2318 | ASSERT_THAT(rv, IsOk()); |
[email protected] | e7b1c6d2c | 2012-05-05 00:54:03 | [diff] [blame] | 2319 | EXPECT_TRUE(handle.is_reused()); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 2320 | TestLoadTimingInfoConnectedReused(handle); |
[email protected] | e7b1c6d2c | 2012-05-05 00:54:03 | [diff] [blame] | 2321 | |
| 2322 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 2323 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 2324 | EXPECT_EQ(1, pool_->NumActiveSocketsInGroup("a")); |
| 2325 | |
mmenke | 43758e6 | 2015-05-04 21:09:46 | [diff] [blame] | 2326 | TestNetLogEntry::List entries; |
[email protected] | e7b1c6d2c | 2012-05-05 00:54:03 | [diff] [blame] | 2327 | log.GetEntries(&entries); |
| 2328 | EXPECT_TRUE(LogContainsEntryWithType( |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 2329 | entries, 1, NetLogEventType::SOCKET_POOL_REUSED_AN_EXISTING_SOCKET)); |
[email protected] | e7b1c6d2c | 2012-05-05 00:54:03 | [diff] [blame] | 2330 | } |
| 2331 | |
blundell | b8163592f | 2015-12-16 14:22:42 | [diff] [blame] | 2332 | #if defined(OS_IOS) |
| 2333 | // TODO(droger): Enable this test (crbug.com/512595). |
martijn | 003cd61 | 2016-05-19 22:24:38 | [diff] [blame] | 2334 | #define MAYBE_CleanupTimedOutIdleSocketsNoReuse \ |
| 2335 | DISABLED_CleanupTimedOutIdleSocketsNoReuse |
blundell | b8163592f | 2015-12-16 14:22:42 | [diff] [blame] | 2336 | #else |
martijn | 003cd61 | 2016-05-19 22:24:38 | [diff] [blame] | 2337 | #define MAYBE_CleanupTimedOutIdleSocketsNoReuse \ |
| 2338 | CleanupTimedOutIdleSocketsNoReuse |
blundell | b8163592f | 2015-12-16 14:22:42 | [diff] [blame] | 2339 | #endif |
martijn | 003cd61 | 2016-05-19 22:24:38 | [diff] [blame] | 2340 | // Make sure we cleanup old unused sockets. |
| 2341 | TEST_F(ClientSocketPoolBaseTest, MAYBE_CleanupTimedOutIdleSocketsNoReuse) { |
[email protected] | e7b1c6d2c | 2012-05-05 00:54:03 | [diff] [blame] | 2342 | CreatePoolWithIdleTimeouts( |
| 2343 | kDefaultMaxSockets, kDefaultMaxSocketsPerGroup, |
| 2344 | base::TimeDelta(), // Time out unused sockets immediately |
| 2345 | base::TimeDelta()); // Time out used sockets immediately |
[email protected] | 64770b7d | 2011-11-16 04:30:41 | [diff] [blame] | 2346 | |
| 2347 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 2348 | |
| 2349 | // Startup two mock pending connect jobs, which will sit in the MessageLoop. |
| 2350 | |
| 2351 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2352 | TestCompletionCallback callback; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2353 | int rv = handle.Init("a", params_, LOWEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2354 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2355 | callback.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2356 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 64770b7d | 2011-11-16 04:30:41 | [diff] [blame] | 2357 | EXPECT_EQ(LOAD_STATE_CONNECTING, pool_->GetLoadState("a", &handle)); |
| 2358 | |
| 2359 | ClientSocketHandle handle2; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2360 | TestCompletionCallback callback2; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2361 | rv = handle2.Init("a", params_, LOWEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2362 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2363 | callback2.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2364 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 64770b7d | 2011-11-16 04:30:41 | [diff] [blame] | 2365 | EXPECT_EQ(LOAD_STATE_CONNECTING, pool_->GetLoadState("a", &handle2)); |
| 2366 | |
| 2367 | // Cancel one of the requests. Wait for the other, which will get the first |
| 2368 | // job. Release the socket. Run the loop again to make sure the second |
| 2369 | // socket is sitting idle and the first one is released (since ReleaseSocket() |
| 2370 | // just posts a DoReleaseSocket() task). |
| 2371 | |
| 2372 | handle.Reset(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2373 | ASSERT_THAT(callback2.WaitForResult(), IsOk()); |
[email protected] | 64770b7d | 2011-11-16 04:30:41 | [diff] [blame] | 2374 | // Use the socket. |
Ramin Halavati | 0a08cc8 | 2018-02-06 07:46:38 | [diff] [blame] | 2375 | EXPECT_EQ(1, handle2.socket()->Write(NULL, 1, CompletionCallback(), |
| 2376 | TRAFFIC_ANNOTATION_FOR_TESTS)); |
[email protected] | 64770b7d | 2011-11-16 04:30:41 | [diff] [blame] | 2377 | handle2.Reset(); |
| 2378 | |
[email protected] | e7b1c6d2c | 2012-05-05 00:54:03 | [diff] [blame] | 2379 | // We post all of our delayed tasks with a 2ms delay. I.e. they don't |
| 2380 | // actually become pending until 2ms after they have been created. In order |
| 2381 | // to flush all tasks, we need to wait so that we know there are no |
| 2382 | // soon-to-be-pending tasks waiting. |
| 2383 | base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(10)); |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 2384 | base::RunLoop().RunUntilIdle(); |
[email protected] | 64770b7d | 2011-11-16 04:30:41 | [diff] [blame] | 2385 | |
[email protected] | e7b1c6d2c | 2012-05-05 00:54:03 | [diff] [blame] | 2386 | // Both sockets should now be idle. |
[email protected] | 64770b7d | 2011-11-16 04:30:41 | [diff] [blame] | 2387 | ASSERT_EQ(2, pool_->IdleSocketCount()); |
| 2388 | |
| 2389 | // Request a new socket. This should cleanup the unused and timed out ones. |
| 2390 | // A new socket will be created rather than reusing the idle one. |
vishal.b | 62985ca9 | 2015-04-17 08:45:51 | [diff] [blame] | 2391 | BoundTestNetLog log; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2392 | TestCompletionCallback callback3; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2393 | rv = handle.Init("a", params_, LOWEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2394 | ClientSocketPool::RespectLimits::ENABLED, |
| 2395 | callback3.callback(), pool_.get(), log.bound()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2396 | ASSERT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 2397 | ASSERT_THAT(callback3.WaitForResult(), IsOk()); |
[email protected] | 64770b7d | 2011-11-16 04:30:41 | [diff] [blame] | 2398 | EXPECT_FALSE(handle.is_reused()); |
| 2399 | |
[email protected] | e7b1c6d2c | 2012-05-05 00:54:03 | [diff] [blame] | 2400 | // Make sure the idle socket is closed. |
[email protected] | 64770b7d | 2011-11-16 04:30:41 | [diff] [blame] | 2401 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 2402 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 2403 | EXPECT_EQ(1, pool_->NumActiveSocketsInGroup("a")); |
| 2404 | |
mmenke | 43758e6 | 2015-05-04 21:09:46 | [diff] [blame] | 2405 | TestNetLogEntry::List entries; |
[email protected] | 64770b7d | 2011-11-16 04:30:41 | [diff] [blame] | 2406 | log.GetEntries(&entries); |
| 2407 | EXPECT_FALSE(LogContainsEntryWithType( |
mikecirone | 8b85c43 | 2016-09-08 19:11:00 | [diff] [blame] | 2408 | entries, 1, NetLogEventType::SOCKET_POOL_REUSED_AN_EXISTING_SOCKET)); |
[email protected] | 64770b7d | 2011-11-16 04:30:41 | [diff] [blame] | 2409 | } |
| 2410 | |
[email protected] | 2041cf34 | 2010-02-19 03:15:59 | [diff] [blame] | 2411 | // Make sure that we process all pending requests even when we're stalling |
[email protected] | 4f2abec | 2010-02-03 18:10:16 | [diff] [blame] | 2412 | // because of multiple releasing disconnected sockets. |
| 2413 | TEST_F(ClientSocketPoolBaseTest, MultipleReleasingDisconnectedSockets) { |
| 2414 | CreatePoolWithIdleTimeouts( |
| 2415 | kDefaultMaxSockets, kDefaultMaxSocketsPerGroup, |
| 2416 | base::TimeDelta(), // Time out unused sockets immediately. |
| 2417 | base::TimeDelta::FromDays(1)); // Don't time out used sockets. |
| 2418 | |
| 2419 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
| 2420 | |
| 2421 | // Startup 4 connect jobs. Two of them will be pending. |
| 2422 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2423 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2424 | TestCompletionCallback callback; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2425 | int rv = handle.Init("a", params_, LOWEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2426 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2427 | callback.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2428 | EXPECT_THAT(rv, IsOk()); |
[email protected] | 4f2abec | 2010-02-03 18:10:16 | [diff] [blame] | 2429 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2430 | ClientSocketHandle handle2; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2431 | TestCompletionCallback callback2; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2432 | rv = handle2.Init("a", params_, LOWEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2433 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2434 | callback2.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2435 | EXPECT_THAT(rv, IsOk()); |
[email protected] | 4f2abec | 2010-02-03 18:10:16 | [diff] [blame] | 2436 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2437 | ClientSocketHandle handle3; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2438 | TestCompletionCallback callback3; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2439 | rv = handle3.Init("a", params_, LOWEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2440 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2441 | callback3.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2442 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 4f2abec | 2010-02-03 18:10:16 | [diff] [blame] | 2443 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2444 | ClientSocketHandle handle4; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2445 | TestCompletionCallback callback4; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2446 | rv = handle4.Init("a", params_, LOWEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2447 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2448 | callback4.callback(), pool_.get(), NetLogWithSource()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2449 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
[email protected] | 4f2abec | 2010-02-03 18:10:16 | [diff] [blame] | 2450 | |
| 2451 | // Release two disconnected sockets. |
| 2452 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2453 | handle.socket()->Disconnect(); |
| 2454 | handle.Reset(); |
| 2455 | handle2.socket()->Disconnect(); |
| 2456 | handle2.Reset(); |
[email protected] | 4f2abec | 2010-02-03 18:10:16 | [diff] [blame] | 2457 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2458 | EXPECT_THAT(callback3.WaitForResult(), IsOk()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2459 | EXPECT_FALSE(handle3.is_reused()); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2460 | EXPECT_THAT(callback4.WaitForResult(), IsOk()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2461 | EXPECT_FALSE(handle4.is_reused()); |
[email protected] | 4f2abec | 2010-02-03 18:10:16 | [diff] [blame] | 2462 | } |
| 2463 | |
[email protected] | d7027bb | 2010-05-10 18:58:54 | [diff] [blame] | 2464 | // Regression test for http://crbug.com/42267. |
| 2465 | // When DoReleaseSocket() is processed for one socket, it is blocked because the |
| 2466 | // other stalled groups all have releasing sockets, so no progress can be made. |
| 2467 | TEST_F(ClientSocketPoolBaseTest, SocketLimitReleasingSockets) { |
| 2468 | CreatePoolWithIdleTimeouts( |
| 2469 | 4 /* socket limit */, 4 /* socket limit per group */, |
| 2470 | base::TimeDelta(), // Time out unused sockets immediately. |
| 2471 | base::TimeDelta::FromDays(1)); // Don't time out used sockets. |
| 2472 | |
| 2473 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
| 2474 | |
| 2475 | // Max out the socket limit with 2 per group. |
| 2476 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2477 | ClientSocketHandle handle_a[4]; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2478 | TestCompletionCallback callback_a[4]; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2479 | ClientSocketHandle handle_b[4]; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2480 | TestCompletionCallback callback_b[4]; |
[email protected] | d7027bb | 2010-05-10 18:58:54 | [diff] [blame] | 2481 | |
| 2482 | for (int i = 0; i < 2; ++i) { |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2483 | EXPECT_EQ(OK, handle_a[i].Init("a", params_, LOWEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2484 | ClientSocketPool::RespectLimits::ENABLED, |
| 2485 | callback_a[i].callback(), pool_.get(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2486 | NetLogWithSource())); |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2487 | EXPECT_EQ(OK, handle_b[i].Init("b", params_, LOWEST, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2488 | ClientSocketPool::RespectLimits::ENABLED, |
| 2489 | callback_b[i].callback(), pool_.get(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2490 | NetLogWithSource())); |
[email protected] | d7027bb | 2010-05-10 18:58:54 | [diff] [blame] | 2491 | } |
[email protected] | b89f7e4 | 2010-05-20 20:37:00 | [diff] [blame] | 2492 | |
[email protected] | d7027bb | 2010-05-10 18:58:54 | [diff] [blame] | 2493 | // Make 4 pending requests, 2 per group. |
| 2494 | |
| 2495 | for (int i = 2; i < 4; ++i) { |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2496 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2497 | handle_a[i].Init("a", params_, LOWEST, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2498 | ClientSocketPool::RespectLimits::ENABLED, |
| 2499 | callback_a[i].callback(), pool_.get(), |
| 2500 | NetLogWithSource())); |
| 2501 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2502 | handle_b[i].Init("b", params_, LOWEST, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2503 | ClientSocketPool::RespectLimits::ENABLED, |
| 2504 | callback_b[i].callback(), pool_.get(), |
| 2505 | NetLogWithSource())); |
[email protected] | d7027bb | 2010-05-10 18:58:54 | [diff] [blame] | 2506 | } |
| 2507 | |
| 2508 | // Release b's socket first. The order is important, because in |
| 2509 | // DoReleaseSocket(), we'll process b's released socket, and since both b and |
| 2510 | // a are stalled, but 'a' is lower lexicographically, we'll process group 'a' |
| 2511 | // first, which has a releasing socket, so it refuses to start up another |
| 2512 | // ConnectJob. So, we used to infinite loop on this. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2513 | handle_b[0].socket()->Disconnect(); |
| 2514 | handle_b[0].Reset(); |
| 2515 | handle_a[0].socket()->Disconnect(); |
| 2516 | handle_a[0].Reset(); |
[email protected] | d7027bb | 2010-05-10 18:58:54 | [diff] [blame] | 2517 | |
| 2518 | // Used to get stuck here. |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 2519 | base::RunLoop().RunUntilIdle(); |
[email protected] | d7027bb | 2010-05-10 18:58:54 | [diff] [blame] | 2520 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2521 | handle_b[1].socket()->Disconnect(); |
| 2522 | handle_b[1].Reset(); |
| 2523 | handle_a[1].socket()->Disconnect(); |
| 2524 | handle_a[1].Reset(); |
[email protected] | d7027bb | 2010-05-10 18:58:54 | [diff] [blame] | 2525 | |
| 2526 | for (int i = 2; i < 4; ++i) { |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2527 | EXPECT_THAT(callback_b[i].WaitForResult(), IsOk()); |
| 2528 | EXPECT_THAT(callback_a[i].WaitForResult(), IsOk()); |
[email protected] | d7027bb | 2010-05-10 18:58:54 | [diff] [blame] | 2529 | } |
| 2530 | } |
| 2531 | |
[email protected] | fd4fe0b | 2010-02-08 23:02:15 | [diff] [blame] | 2532 | TEST_F(ClientSocketPoolBaseTest, |
| 2533 | ReleasingDisconnectedSocketsMaintainsPriorityOrder) { |
| 2534 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 2535 | |
| 2536 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 2537 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2538 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 2539 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 2540 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
| 2541 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsError(ERR_IO_PENDING)); |
[email protected] | fd4fe0b | 2010-02-08 23:02:15 | [diff] [blame] | 2542 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2543 | EXPECT_THAT((*requests())[0]->WaitForResult(), IsOk()); |
| 2544 | EXPECT_THAT((*requests())[1]->WaitForResult(), IsOk()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2545 | EXPECT_EQ(2u, completion_count()); |
[email protected] | fd4fe0b | 2010-02-08 23:02:15 | [diff] [blame] | 2546 | |
| 2547 | // Releases one connection. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2548 | EXPECT_TRUE(ReleaseOneConnection(ClientSocketPoolTest::NO_KEEP_ALIVE)); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2549 | EXPECT_THAT((*requests())[2]->WaitForResult(), IsOk()); |
[email protected] | fd4fe0b | 2010-02-08 23:02:15 | [diff] [blame] | 2550 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2551 | EXPECT_TRUE(ReleaseOneConnection(ClientSocketPoolTest::NO_KEEP_ALIVE)); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2552 | EXPECT_THAT((*requests())[3]->WaitForResult(), IsOk()); |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2553 | EXPECT_EQ(4u, completion_count()); |
[email protected] | fd4fe0b | 2010-02-08 23:02:15 | [diff] [blame] | 2554 | |
| 2555 | EXPECT_EQ(1, GetOrderOfRequest(1)); |
| 2556 | EXPECT_EQ(2, GetOrderOfRequest(2)); |
| 2557 | EXPECT_EQ(3, GetOrderOfRequest(3)); |
| 2558 | EXPECT_EQ(4, GetOrderOfRequest(4)); |
| 2559 | |
| 2560 | // Make sure we test order of all requests made. |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2561 | EXPECT_EQ(ClientSocketPoolTest::kIndexOutOfBounds, GetOrderOfRequest(5)); |
[email protected] | fd4fe0b | 2010-02-08 23:02:15 | [diff] [blame] | 2562 | } |
| 2563 | |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2564 | class TestReleasingSocketRequest : public TestCompletionCallbackBase { |
[email protected] | 4f1e498 | 2010-03-02 18:31:04 | [diff] [blame] | 2565 | public: |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2566 | TestReleasingSocketRequest(TestClientSocketPool* pool, |
| 2567 | int expected_result, |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 2568 | bool reset_releasing_handle) |
| 2569 | : pool_(pool), |
| 2570 | expected_result_(expected_result), |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2571 | reset_releasing_handle_(reset_releasing_handle), |
[email protected] | aa249b5 | 2013-04-30 01:04:32 | [diff] [blame] | 2572 | callback_(base::Bind(&TestReleasingSocketRequest::OnComplete, |
| 2573 | base::Unretained(this))) { |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2574 | } |
| 2575 | |
Chris Watkins | 7a41d355 | 2017-12-01 02:13:27 | [diff] [blame] | 2576 | ~TestReleasingSocketRequest() override = default; |
[email protected] | 4f1e498 | 2010-03-02 18:31:04 | [diff] [blame] | 2577 | |
| 2578 | ClientSocketHandle* handle() { return &handle_; } |
| 2579 | |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2580 | const CompletionCallback& callback() const { return callback_; } |
[email protected] | 4f1e498 | 2010-03-02 18:31:04 | [diff] [blame] | 2581 | |
| 2582 | private: |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2583 | void OnComplete(int result) { |
| 2584 | SetResult(result); |
| 2585 | if (reset_releasing_handle_) |
| 2586 | handle_.Reset(); |
| 2587 | |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2588 | scoped_refptr<TestSocketParams> con_params(new TestSocketParams()); |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2589 | EXPECT_EQ(expected_result_, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2590 | handle2_.Init("a", con_params, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2591 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2592 | callback2_.callback(), pool_, NetLogWithSource())); |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2593 | } |
| 2594 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2595 | TestClientSocketPool* const pool_; |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 2596 | int expected_result_; |
| 2597 | bool reset_releasing_handle_; |
[email protected] | 4f1e498 | 2010-03-02 18:31:04 | [diff] [blame] | 2598 | ClientSocketHandle handle_; |
| 2599 | ClientSocketHandle handle2_; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2600 | CompletionCallback callback_; |
| 2601 | TestCompletionCallback callback2_; |
[email protected] | 4f1e498 | 2010-03-02 18:31:04 | [diff] [blame] | 2602 | }; |
| 2603 | |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 2604 | |
| 2605 | TEST_F(ClientSocketPoolBaseTest, AdditionalErrorSocketsDontUseSlot) { |
| 2606 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 2607 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2608 | EXPECT_THAT(StartRequest("b", DEFAULT_PRIORITY), IsOk()); |
| 2609 | EXPECT_THAT(StartRequest("a", DEFAULT_PRIORITY), IsOk()); |
| 2610 | EXPECT_THAT(StartRequest("b", DEFAULT_PRIORITY), IsOk()); |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 2611 | |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2612 | EXPECT_EQ(static_cast<int>(requests_size()), |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 2613 | client_socket_factory_.allocation_count()); |
| 2614 | |
| 2615 | connect_job_factory_->set_job_type( |
| 2616 | TestConnectJob::kMockPendingAdditionalErrorStateJob); |
| 2617 | TestReleasingSocketRequest req(pool_.get(), OK, false); |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2618 | EXPECT_EQ( |
| 2619 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2620 | req.handle()->Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2621 | ClientSocketPool::RespectLimits::ENABLED, |
| 2622 | req.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 2623 | // The next job should complete synchronously |
| 2624 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
| 2625 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2626 | EXPECT_THAT(req.WaitForResult(), IsError(ERR_CONNECTION_FAILED)); |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 2627 | EXPECT_FALSE(req.handle()->is_initialized()); |
| 2628 | EXPECT_FALSE(req.handle()->socket()); |
| 2629 | EXPECT_TRUE(req.handle()->is_ssl_error()); |
[email protected] | 8b49869 | 2010-07-16 17:11:43 | [diff] [blame] | 2630 | EXPECT_FALSE(req.handle()->ssl_error_response_info().headers.get() == NULL); |
[email protected] | e60e47a | 2010-07-14 03:37:18 | [diff] [blame] | 2631 | } |
| 2632 | |
[email protected] | b6501d3d | 2010-06-03 23:53:34 | [diff] [blame] | 2633 | // http://crbug.com/44724 regression test. |
| 2634 | // We start releasing the pool when we flush on network change. When that |
| 2635 | // happens, the only active references are in the ClientSocketHandles. When a |
| 2636 | // ConnectJob completes and calls back into the last ClientSocketHandle, that |
| 2637 | // callback can release the last reference and delete the pool. After the |
| 2638 | // callback finishes, we go back to the stack frame within the now-deleted pool. |
| 2639 | // Executing any code that refers to members of the now-deleted pool can cause |
| 2640 | // crashes. |
| 2641 | TEST_F(ClientSocketPoolBaseTest, CallbackThatReleasesPool) { |
| 2642 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 2643 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingFailingJob); |
| 2644 | |
| 2645 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2646 | TestCompletionCallback callback; |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2647 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2648 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2649 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2650 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | b6501d3d | 2010-06-03 23:53:34 | [diff] [blame] | 2651 | |
[email protected] | 7af985a | 2012-12-14 22:40:42 | [diff] [blame] | 2652 | pool_->FlushWithError(ERR_NETWORK_CHANGED); |
[email protected] | b6501d3d | 2010-06-03 23:53:34 | [diff] [blame] | 2653 | |
| 2654 | // We'll call back into this now. |
| 2655 | callback.WaitForResult(); |
| 2656 | } |
| 2657 | |
[email protected] | a7e3857 | 2010-06-07 18:22:24 | [diff] [blame] | 2658 | TEST_F(ClientSocketPoolBaseTest, DoNotReuseSocketAfterFlush) { |
| 2659 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 2660 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 2661 | |
| 2662 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2663 | TestCompletionCallback callback; |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2664 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2665 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2666 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2667 | callback.callback(), pool_.get(), NetLogWithSource())); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2668 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | a7e3857 | 2010-06-07 18:22:24 | [diff] [blame] | 2669 | EXPECT_EQ(ClientSocketHandle::UNUSED, handle.reuse_type()); |
| 2670 | |
[email protected] | 7af985a | 2012-12-14 22:40:42 | [diff] [blame] | 2671 | pool_->FlushWithError(ERR_NETWORK_CHANGED); |
[email protected] | a7e3857 | 2010-06-07 18:22:24 | [diff] [blame] | 2672 | |
| 2673 | handle.Reset(); |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 2674 | base::RunLoop().RunUntilIdle(); |
[email protected] | a7e3857 | 2010-06-07 18:22:24 | [diff] [blame] | 2675 | |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2676 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2677 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2678 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2679 | callback.callback(), pool_.get(), NetLogWithSource())); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2680 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | a7e3857 | 2010-06-07 18:22:24 | [diff] [blame] | 2681 | EXPECT_EQ(ClientSocketHandle::UNUSED, handle.reuse_type()); |
| 2682 | } |
| 2683 | |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2684 | class ConnectWithinCallback : public TestCompletionCallbackBase { |
[email protected] | 06f9246 | 2010-08-31 19:24:14 | [diff] [blame] | 2685 | public: |
| 2686 | ConnectWithinCallback( |
| 2687 | const std::string& group_name, |
| 2688 | const scoped_refptr<TestSocketParams>& params, |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2689 | TestClientSocketPool* pool) |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2690 | : group_name_(group_name), |
| 2691 | params_(params), |
| 2692 | pool_(pool), |
[email protected] | aa249b5 | 2013-04-30 01:04:32 | [diff] [blame] | 2693 | callback_(base::Bind(&ConnectWithinCallback::OnComplete, |
| 2694 | base::Unretained(this))) { |
[email protected] | 06f9246 | 2010-08-31 19:24:14 | [diff] [blame] | 2695 | } |
| 2696 | |
Chris Watkins | 7a41d355 | 2017-12-01 02:13:27 | [diff] [blame] | 2697 | ~ConnectWithinCallback() override = default; |
[email protected] | 06f9246 | 2010-08-31 19:24:14 | [diff] [blame] | 2698 | |
| 2699 | int WaitForNestedResult() { |
| 2700 | return nested_callback_.WaitForResult(); |
| 2701 | } |
| 2702 | |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2703 | const CompletionCallback& callback() const { return callback_; } |
| 2704 | |
[email protected] | 06f9246 | 2010-08-31 19:24:14 | [diff] [blame] | 2705 | private: |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2706 | void OnComplete(int result) { |
| 2707 | SetResult(result); |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2708 | EXPECT_EQ( |
| 2709 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2710 | handle_.Init(group_name_, params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2711 | ClientSocketPool::RespectLimits::ENABLED, |
| 2712 | nested_callback_.callback(), pool_, NetLogWithSource())); |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2713 | } |
| 2714 | |
[email protected] | 06f9246 | 2010-08-31 19:24:14 | [diff] [blame] | 2715 | const std::string group_name_; |
| 2716 | const scoped_refptr<TestSocketParams> params_; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2717 | TestClientSocketPool* const pool_; |
[email protected] | 06f9246 | 2010-08-31 19:24:14 | [diff] [blame] | 2718 | ClientSocketHandle handle_; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2719 | CompletionCallback callback_; |
| 2720 | TestCompletionCallback nested_callback_; |
| 2721 | |
| 2722 | DISALLOW_COPY_AND_ASSIGN(ConnectWithinCallback); |
[email protected] | 06f9246 | 2010-08-31 19:24:14 | [diff] [blame] | 2723 | }; |
| 2724 | |
| 2725 | TEST_F(ClientSocketPoolBaseTest, AbortAllRequestsOnFlush) { |
| 2726 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 2727 | |
| 2728 | // First job will be waiting until it gets aborted. |
| 2729 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 2730 | |
| 2731 | ClientSocketHandle handle; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2732 | ConnectWithinCallback callback("a", params_, pool_.get()); |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2733 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2734 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2735 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2736 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 06f9246 | 2010-08-31 19:24:14 | [diff] [blame] | 2737 | |
| 2738 | // Second job will be started during the first callback, and will |
| 2739 | // asynchronously complete with OK. |
| 2740 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
[email protected] | 7af985a | 2012-12-14 22:40:42 | [diff] [blame] | 2741 | pool_->FlushWithError(ERR_NETWORK_CHANGED); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2742 | EXPECT_THAT(callback.WaitForResult(), IsError(ERR_NETWORK_CHANGED)); |
| 2743 | EXPECT_THAT(callback.WaitForNestedResult(), IsOk()); |
[email protected] | 06f9246 | 2010-08-31 19:24:14 | [diff] [blame] | 2744 | } |
| 2745 | |
[email protected] | 25eea38 | 2010-07-10 23:55:26 | [diff] [blame] | 2746 | // Cancel a pending socket request while we're at max sockets, |
| 2747 | // and verify that the backup socket firing doesn't cause a crash. |
| 2748 | TEST_F(ClientSocketPoolBaseTest, BackupSocketCancelAtMaxSockets) { |
| 2749 | // Max 4 sockets globally, max 4 sockets per group. |
| 2750 | CreatePool(kDefaultMaxSockets, kDefaultMaxSockets); |
[email protected] | 06d9404 | 2010-08-25 01:45:22 | [diff] [blame] | 2751 | pool_->EnableConnectBackupJobs(); |
[email protected] | 25eea38 | 2010-07-10 23:55:26 | [diff] [blame] | 2752 | |
[email protected] | 4baaf9d | 2010-08-31 15:15:44 | [diff] [blame] | 2753 | // Create the first socket and set to ERR_IO_PENDING. This starts the backup |
| 2754 | // timer. |
[email protected] | 25eea38 | 2010-07-10 23:55:26 | [diff] [blame] | 2755 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 2756 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2757 | TestCompletionCallback callback; |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2758 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2759 | handle.Init("bar", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2760 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2761 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 25eea38 | 2010-07-10 23:55:26 | [diff] [blame] | 2762 | |
| 2763 | // Start (MaxSockets - 1) connected sockets to reach max sockets. |
| 2764 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
| 2765 | ClientSocketHandle handles[kDefaultMaxSockets]; |
| 2766 | for (int i = 1; i < kDefaultMaxSockets; ++i) { |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2767 | TestCompletionCallback callback; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2768 | EXPECT_EQ(OK, handles[i].Init("bar", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2769 | ClientSocketPool::RespectLimits::ENABLED, |
| 2770 | callback.callback(), pool_.get(), |
| 2771 | NetLogWithSource())); |
[email protected] | 25eea38 | 2010-07-10 23:55:26 | [diff] [blame] | 2772 | } |
| 2773 | |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 2774 | base::RunLoop().RunUntilIdle(); |
[email protected] | 25eea38 | 2010-07-10 23:55:26 | [diff] [blame] | 2775 | |
| 2776 | // Cancel the pending request. |
| 2777 | handle.Reset(); |
| 2778 | |
| 2779 | // Wait for the backup timer to fire (add some slop to ensure it fires) |
[email protected] | 26b997396 | 2012-01-28 00:57:00 | [diff] [blame] | 2780 | base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds( |
| 2781 | ClientSocketPool::kMaxConnectRetryIntervalMs / 2 * 3)); |
[email protected] | 25eea38 | 2010-07-10 23:55:26 | [diff] [blame] | 2782 | |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 2783 | base::RunLoop().RunUntilIdle(); |
[email protected] | 25eea38 | 2010-07-10 23:55:26 | [diff] [blame] | 2784 | EXPECT_EQ(kDefaultMaxSockets, client_socket_factory_.allocation_count()); |
| 2785 | } |
| 2786 | |
[email protected] | 3f00be8 | 2010-09-27 19:50:02 | [diff] [blame] | 2787 | TEST_F(ClientSocketPoolBaseTest, CancelBackupSocketAfterCancelingAllRequests) { |
[email protected] | 4baaf9d | 2010-08-31 15:15:44 | [diff] [blame] | 2788 | CreatePool(kDefaultMaxSockets, kDefaultMaxSockets); |
| 2789 | pool_->EnableConnectBackupJobs(); |
| 2790 | |
| 2791 | // Create the first socket and set to ERR_IO_PENDING. This starts the backup |
| 2792 | // timer. |
| 2793 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 2794 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2795 | TestCompletionCallback callback; |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2796 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2797 | handle.Init("bar", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2798 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2799 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 4baaf9d | 2010-08-31 15:15:44 | [diff] [blame] | 2800 | ASSERT_TRUE(pool_->HasGroup("bar")); |
| 2801 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("bar")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 2802 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("bar")); |
[email protected] | 4baaf9d | 2010-08-31 15:15:44 | [diff] [blame] | 2803 | |
| 2804 | // Cancel the socket request. This should cancel the backup timer. Wait for |
| 2805 | // the backup time to see if it indeed got canceled. |
| 2806 | handle.Reset(); |
| 2807 | // Wait for the backup timer to fire (add some slop to ensure it fires) |
[email protected] | 26b997396 | 2012-01-28 00:57:00 | [diff] [blame] | 2808 | base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds( |
| 2809 | ClientSocketPool::kMaxConnectRetryIntervalMs / 2 * 3)); |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 2810 | base::RunLoop().RunUntilIdle(); |
[email protected] | 4baaf9d | 2010-08-31 15:15:44 | [diff] [blame] | 2811 | ASSERT_TRUE(pool_->HasGroup("bar")); |
| 2812 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("bar")); |
| 2813 | } |
| 2814 | |
[email protected] | 3f00be8 | 2010-09-27 19:50:02 | [diff] [blame] | 2815 | TEST_F(ClientSocketPoolBaseTest, CancelBackupSocketAfterFinishingAllRequests) { |
| 2816 | CreatePool(kDefaultMaxSockets, kDefaultMaxSockets); |
| 2817 | pool_->EnableConnectBackupJobs(); |
| 2818 | |
| 2819 | // Create the first socket and set to ERR_IO_PENDING. This starts the backup |
| 2820 | // timer. |
| 2821 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 2822 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2823 | TestCompletionCallback callback; |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2824 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2825 | handle.Init("bar", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2826 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2827 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 3f00be8 | 2010-09-27 19:50:02 | [diff] [blame] | 2828 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 2829 | ClientSocketHandle handle2; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2830 | TestCompletionCallback callback2; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2831 | EXPECT_EQ( |
| 2832 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2833 | handle2.Init("bar", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2834 | ClientSocketPool::RespectLimits::ENABLED, |
| 2835 | callback2.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 3f00be8 | 2010-09-27 19:50:02 | [diff] [blame] | 2836 | ASSERT_TRUE(pool_->HasGroup("bar")); |
| 2837 | EXPECT_EQ(2, pool_->NumConnectJobsInGroup("bar")); |
| 2838 | |
| 2839 | // Cancel request 1 and then complete request 2. With the requests finished, |
| 2840 | // the backup timer should be cancelled. |
| 2841 | handle.Reset(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2842 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
[email protected] | 3f00be8 | 2010-09-27 19:50:02 | [diff] [blame] | 2843 | // Wait for the backup timer to fire (add some slop to ensure it fires) |
[email protected] | 26b997396 | 2012-01-28 00:57:00 | [diff] [blame] | 2844 | base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds( |
| 2845 | ClientSocketPool::kMaxConnectRetryIntervalMs / 2 * 3)); |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 2846 | base::RunLoop().RunUntilIdle(); |
[email protected] | 3f00be8 | 2010-09-27 19:50:02 | [diff] [blame] | 2847 | } |
| 2848 | |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2849 | // Test delayed socket binding for the case where we have two connects, |
| 2850 | // and while one is waiting on a connect, the other frees up. |
| 2851 | // The socket waiting on a connect should switch immediately to the freed |
| 2852 | // up socket. |
| 2853 | TEST_F(ClientSocketPoolBaseTest, DelayedSocketBindingWaitingForConnect) { |
| 2854 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 2855 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 2856 | |
| 2857 | ClientSocketHandle handle1; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2858 | TestCompletionCallback callback; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2859 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2860 | handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2861 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2862 | callback.callback(), pool_.get(), NetLogWithSource())); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2863 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2864 | |
| 2865 | // No idle sockets, no pending jobs. |
| 2866 | EXPECT_EQ(0, pool_->IdleSocketCount()); |
| 2867 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 2868 | |
| 2869 | // Create a second socket to the same host, but this one will wait. |
| 2870 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 2871 | ClientSocketHandle handle2; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2872 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2873 | handle2.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2874 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2875 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2876 | // No idle sockets, and one connecting job. |
| 2877 | EXPECT_EQ(0, pool_->IdleSocketCount()); |
| 2878 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 2879 | |
| 2880 | // Return the first handle to the pool. This will initiate the delayed |
| 2881 | // binding. |
| 2882 | handle1.Reset(); |
| 2883 | |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 2884 | base::RunLoop().RunUntilIdle(); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2885 | |
| 2886 | // Still no idle sockets, still one pending connect job. |
| 2887 | EXPECT_EQ(0, pool_->IdleSocketCount()); |
| 2888 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 2889 | |
| 2890 | // The second socket connected, even though it was a Waiting Job. |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2891 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2892 | |
| 2893 | // And we can see there is still one job waiting. |
| 2894 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 2895 | |
| 2896 | // Finally, signal the waiting Connect. |
| 2897 | client_socket_factory_.SignalJobs(); |
| 2898 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 2899 | |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 2900 | base::RunLoop().RunUntilIdle(); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2901 | } |
| 2902 | |
| 2903 | // Test delayed socket binding when a group is at capacity and one |
| 2904 | // of the group's sockets frees up. |
| 2905 | TEST_F(ClientSocketPoolBaseTest, DelayedSocketBindingAtGroupCapacity) { |
| 2906 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 2907 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 2908 | |
| 2909 | ClientSocketHandle handle1; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2910 | TestCompletionCallback callback; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2911 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2912 | handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2913 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2914 | callback.callback(), pool_.get(), NetLogWithSource())); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2915 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2916 | |
| 2917 | // No idle sockets, no pending jobs. |
| 2918 | EXPECT_EQ(0, pool_->IdleSocketCount()); |
| 2919 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 2920 | |
| 2921 | // Create a second socket to the same host, but this one will wait. |
| 2922 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 2923 | ClientSocketHandle handle2; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2924 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2925 | handle2.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2926 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2927 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2928 | // No idle sockets, and one connecting job. |
| 2929 | EXPECT_EQ(0, pool_->IdleSocketCount()); |
| 2930 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 2931 | |
| 2932 | // Return the first handle to the pool. This will initiate the delayed |
| 2933 | // binding. |
| 2934 | handle1.Reset(); |
| 2935 | |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 2936 | base::RunLoop().RunUntilIdle(); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2937 | |
| 2938 | // Still no idle sockets, still one pending connect job. |
| 2939 | EXPECT_EQ(0, pool_->IdleSocketCount()); |
| 2940 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 2941 | |
| 2942 | // The second socket connected, even though it was a Waiting Job. |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2943 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2944 | |
| 2945 | // And we can see there is still one job waiting. |
| 2946 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 2947 | |
| 2948 | // Finally, signal the waiting Connect. |
| 2949 | client_socket_factory_.SignalJobs(); |
| 2950 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 2951 | |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 2952 | base::RunLoop().RunUntilIdle(); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2953 | } |
| 2954 | |
| 2955 | // Test out the case where we have one socket connected, one |
| 2956 | // connecting, when the first socket finishes and goes idle. |
[email protected] | 2abfe90a | 2010-08-25 17:49:51 | [diff] [blame] | 2957 | // Although the second connection is pending, the second request |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2958 | // should complete, by taking the first socket's idle socket. |
| 2959 | TEST_F(ClientSocketPoolBaseTest, DelayedSocketBindingAtStall) { |
| 2960 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 2961 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 2962 | |
| 2963 | ClientSocketHandle handle1; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 2964 | TestCompletionCallback callback; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2965 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2966 | handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2967 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2968 | callback.callback(), pool_.get(), NetLogWithSource())); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2969 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2970 | |
| 2971 | // No idle sockets, no pending jobs. |
| 2972 | EXPECT_EQ(0, pool_->IdleSocketCount()); |
| 2973 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 2974 | |
| 2975 | // Create a second socket to the same host, but this one will wait. |
| 2976 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 2977 | ClientSocketHandle handle2; |
[email protected] | 2431756e | 2010-09-29 20:26:13 | [diff] [blame] | 2978 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 2979 | handle2.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 2980 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 2981 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2982 | // No idle sockets, and one connecting job. |
| 2983 | EXPECT_EQ(0, pool_->IdleSocketCount()); |
| 2984 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 2985 | |
| 2986 | // Return the first handle to the pool. This will initiate the delayed |
| 2987 | // binding. |
| 2988 | handle1.Reset(); |
| 2989 | |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 2990 | base::RunLoop().RunUntilIdle(); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2991 | |
| 2992 | // Still no idle sockets, still one pending connect job. |
| 2993 | EXPECT_EQ(0, pool_->IdleSocketCount()); |
| 2994 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 2995 | |
| 2996 | // The second socket connected, even though it was a Waiting Job. |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 2997 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 2998 | |
| 2999 | // And we can see there is still one job waiting. |
| 3000 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 3001 | |
| 3002 | // Finally, signal the waiting Connect. |
| 3003 | client_socket_factory_.SignalJobs(); |
| 3004 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 3005 | |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 3006 | base::RunLoop().RunUntilIdle(); |
[email protected] | eb5a9938 | 2010-07-11 03:18:26 | [diff] [blame] | 3007 | } |
| 3008 | |
[email protected] | 2abfe90a | 2010-08-25 17:49:51 | [diff] [blame] | 3009 | // Cover the case where on an available socket slot, we have one pending |
| 3010 | // request that completes synchronously, thereby making the Group empty. |
| 3011 | TEST_F(ClientSocketPoolBaseTest, SynchronouslyProcessOnePendingRequest) { |
| 3012 | const int kUnlimitedSockets = 100; |
| 3013 | const int kOneSocketPerGroup = 1; |
| 3014 | CreatePool(kUnlimitedSockets, kOneSocketPerGroup); |
| 3015 | |
| 3016 | // Make the first request asynchronous fail. |
| 3017 | // This will free up a socket slot later. |
| 3018 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingFailingJob); |
| 3019 | |
| 3020 | ClientSocketHandle handle1; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3021 | TestCompletionCallback callback1; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3022 | EXPECT_EQ( |
| 3023 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3024 | handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3025 | ClientSocketPool::RespectLimits::ENABLED, |
| 3026 | callback1.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2abfe90a | 2010-08-25 17:49:51 | [diff] [blame] | 3027 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 3028 | |
| 3029 | // Make the second request synchronously fail. This should make the Group |
| 3030 | // empty. |
| 3031 | connect_job_factory_->set_job_type(TestConnectJob::kMockFailingJob); |
| 3032 | ClientSocketHandle handle2; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3033 | TestCompletionCallback callback2; |
[email protected] | 2abfe90a | 2010-08-25 17:49:51 | [diff] [blame] | 3034 | // It'll be ERR_IO_PENDING now, but the TestConnectJob will synchronously fail |
| 3035 | // when created. |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3036 | EXPECT_EQ( |
| 3037 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3038 | handle2.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3039 | ClientSocketPool::RespectLimits::ENABLED, |
| 3040 | callback2.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2abfe90a | 2010-08-25 17:49:51 | [diff] [blame] | 3041 | |
| 3042 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 3043 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3044 | EXPECT_THAT(callback1.WaitForResult(), IsError(ERR_CONNECTION_FAILED)); |
| 3045 | EXPECT_THAT(callback2.WaitForResult(), IsError(ERR_CONNECTION_FAILED)); |
[email protected] | 2abfe90a | 2010-08-25 17:49:51 | [diff] [blame] | 3046 | EXPECT_FALSE(pool_->HasGroup("a")); |
| 3047 | } |
| 3048 | |
[email protected] | e1b54dc | 2010-10-06 21:27:22 | [diff] [blame] | 3049 | TEST_F(ClientSocketPoolBaseTest, PreferUsedSocketToUnusedSocket) { |
| 3050 | CreatePool(kDefaultMaxSockets, kDefaultMaxSockets); |
| 3051 | |
| 3052 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3053 | |
| 3054 | ClientSocketHandle handle1; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3055 | TestCompletionCallback callback1; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3056 | EXPECT_EQ( |
| 3057 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3058 | handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3059 | ClientSocketPool::RespectLimits::ENABLED, |
| 3060 | callback1.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | e1b54dc | 2010-10-06 21:27:22 | [diff] [blame] | 3061 | |
| 3062 | ClientSocketHandle handle2; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3063 | TestCompletionCallback callback2; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3064 | EXPECT_EQ( |
| 3065 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3066 | handle2.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3067 | ClientSocketPool::RespectLimits::ENABLED, |
| 3068 | callback2.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | e1b54dc | 2010-10-06 21:27:22 | [diff] [blame] | 3069 | ClientSocketHandle handle3; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3070 | TestCompletionCallback callback3; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3071 | EXPECT_EQ( |
| 3072 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3073 | handle3.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3074 | ClientSocketPool::RespectLimits::ENABLED, |
| 3075 | callback3.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | e1b54dc | 2010-10-06 21:27:22 | [diff] [blame] | 3076 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3077 | EXPECT_THAT(callback1.WaitForResult(), IsOk()); |
| 3078 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
| 3079 | EXPECT_THAT(callback3.WaitForResult(), IsOk()); |
[email protected] | e1b54dc | 2010-10-06 21:27:22 | [diff] [blame] | 3080 | |
| 3081 | // Use the socket. |
Ramin Halavati | 0a08cc8 | 2018-02-06 07:46:38 | [diff] [blame] | 3082 | EXPECT_EQ(1, handle1.socket()->Write(NULL, 1, CompletionCallback(), |
| 3083 | TRAFFIC_ANNOTATION_FOR_TESTS)); |
| 3084 | EXPECT_EQ(1, handle3.socket()->Write(NULL, 1, CompletionCallback(), |
| 3085 | TRAFFIC_ANNOTATION_FOR_TESTS)); |
[email protected] | e1b54dc | 2010-10-06 21:27:22 | [diff] [blame] | 3086 | |
| 3087 | handle1.Reset(); |
| 3088 | handle2.Reset(); |
| 3089 | handle3.Reset(); |
| 3090 | |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3091 | EXPECT_EQ( |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3092 | OK, handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3093 | ClientSocketPool::RespectLimits::ENABLED, |
| 3094 | callback1.callback(), pool_.get(), NetLogWithSource())); |
| 3095 | EXPECT_EQ( |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3096 | OK, handle2.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3097 | ClientSocketPool::RespectLimits::ENABLED, |
| 3098 | callback2.callback(), pool_.get(), NetLogWithSource())); |
| 3099 | EXPECT_EQ( |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3100 | OK, handle3.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3101 | ClientSocketPool::RespectLimits::ENABLED, |
| 3102 | callback3.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | e1b54dc | 2010-10-06 21:27:22 | [diff] [blame] | 3103 | |
| 3104 | EXPECT_TRUE(handle1.socket()->WasEverUsed()); |
| 3105 | EXPECT_TRUE(handle2.socket()->WasEverUsed()); |
| 3106 | EXPECT_FALSE(handle3.socket()->WasEverUsed()); |
| 3107 | } |
| 3108 | |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3109 | TEST_F(ClientSocketPoolBaseTest, RequestSockets) { |
| 3110 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 3111 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3112 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3113 | pool_->RequestSockets("a", ¶ms_, 2, NetLogWithSource(), |
| 3114 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3115 | |
| 3116 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3117 | EXPECT_EQ(2, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3118 | EXPECT_EQ(2, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3119 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3120 | |
| 3121 | ClientSocketHandle handle1; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3122 | TestCompletionCallback callback1; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3123 | EXPECT_EQ( |
| 3124 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3125 | handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3126 | ClientSocketPool::RespectLimits::ENABLED, |
| 3127 | callback1.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3128 | |
| 3129 | ClientSocketHandle handle2; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3130 | TestCompletionCallback callback2; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3131 | EXPECT_EQ( |
| 3132 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3133 | handle2.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3134 | ClientSocketPool::RespectLimits::ENABLED, |
| 3135 | callback2.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3136 | |
| 3137 | EXPECT_EQ(2, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3138 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3139 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3140 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3141 | EXPECT_THAT(callback1.WaitForResult(), IsOk()); |
| 3142 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3143 | handle1.Reset(); |
| 3144 | handle2.Reset(); |
| 3145 | |
| 3146 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3147 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3148 | EXPECT_EQ(2, pool_->IdleSocketCountInGroup("a")); |
| 3149 | } |
| 3150 | |
| 3151 | TEST_F(ClientSocketPoolBaseTest, RequestSocketsWhenAlreadyHaveAConnectJob) { |
| 3152 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 3153 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3154 | |
| 3155 | ClientSocketHandle handle1; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3156 | TestCompletionCallback callback1; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3157 | EXPECT_EQ( |
| 3158 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3159 | handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3160 | ClientSocketPool::RespectLimits::ENABLED, |
| 3161 | callback1.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3162 | |
| 3163 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3164 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3165 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3166 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3167 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3168 | pool_->RequestSockets("a", ¶ms_, 2, NetLogWithSource(), |
| 3169 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3170 | |
| 3171 | EXPECT_EQ(2, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3172 | EXPECT_EQ(1, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3173 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3174 | |
| 3175 | ClientSocketHandle handle2; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3176 | TestCompletionCallback callback2; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3177 | EXPECT_EQ( |
| 3178 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3179 | handle2.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3180 | ClientSocketPool::RespectLimits::ENABLED, |
| 3181 | callback2.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3182 | |
| 3183 | EXPECT_EQ(2, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3184 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3185 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3186 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3187 | EXPECT_THAT(callback1.WaitForResult(), IsOk()); |
| 3188 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3189 | handle1.Reset(); |
| 3190 | handle2.Reset(); |
| 3191 | |
| 3192 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3193 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3194 | EXPECT_EQ(2, pool_->IdleSocketCountInGroup("a")); |
| 3195 | } |
| 3196 | |
| 3197 | TEST_F(ClientSocketPoolBaseTest, |
| 3198 | RequestSocketsWhenAlreadyHaveMultipleConnectJob) { |
| 3199 | CreatePool(4, 4); |
| 3200 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3201 | |
| 3202 | ClientSocketHandle handle1; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3203 | TestCompletionCallback callback1; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3204 | EXPECT_EQ( |
| 3205 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3206 | handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3207 | ClientSocketPool::RespectLimits::ENABLED, |
| 3208 | callback1.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3209 | |
| 3210 | ClientSocketHandle handle2; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3211 | TestCompletionCallback callback2; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3212 | EXPECT_EQ( |
| 3213 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3214 | handle2.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3215 | ClientSocketPool::RespectLimits::ENABLED, |
| 3216 | callback2.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3217 | |
| 3218 | ClientSocketHandle handle3; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3219 | TestCompletionCallback callback3; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3220 | EXPECT_EQ( |
| 3221 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3222 | handle3.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3223 | ClientSocketPool::RespectLimits::ENABLED, |
| 3224 | callback3.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3225 | |
| 3226 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3227 | EXPECT_EQ(3, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3228 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3229 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3230 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3231 | pool_->RequestSockets("a", ¶ms_, 2, NetLogWithSource(), |
| 3232 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3233 | |
| 3234 | EXPECT_EQ(3, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3235 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3236 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3237 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3238 | EXPECT_THAT(callback1.WaitForResult(), IsOk()); |
| 3239 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
| 3240 | EXPECT_THAT(callback3.WaitForResult(), IsOk()); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3241 | handle1.Reset(); |
| 3242 | handle2.Reset(); |
| 3243 | handle3.Reset(); |
| 3244 | |
| 3245 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3246 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3247 | EXPECT_EQ(3, pool_->IdleSocketCountInGroup("a")); |
| 3248 | } |
| 3249 | |
| 3250 | TEST_F(ClientSocketPoolBaseTest, RequestSocketsAtMaxSocketLimit) { |
| 3251 | CreatePool(kDefaultMaxSockets, kDefaultMaxSockets); |
| 3252 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3253 | |
| 3254 | ASSERT_FALSE(pool_->HasGroup("a")); |
| 3255 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3256 | pool_->RequestSockets("a", ¶ms_, kDefaultMaxSockets, NetLogWithSource(), |
| 3257 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3258 | |
| 3259 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3260 | EXPECT_EQ(kDefaultMaxSockets, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3261 | EXPECT_EQ(kDefaultMaxSockets, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3262 | |
| 3263 | ASSERT_FALSE(pool_->HasGroup("b")); |
| 3264 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3265 | pool_->RequestSockets("b", ¶ms_, kDefaultMaxSockets, NetLogWithSource(), |
| 3266 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3267 | |
| 3268 | ASSERT_FALSE(pool_->HasGroup("b")); |
| 3269 | } |
| 3270 | |
| 3271 | TEST_F(ClientSocketPoolBaseTest, RequestSocketsHitMaxSocketLimit) { |
| 3272 | CreatePool(kDefaultMaxSockets, kDefaultMaxSockets); |
| 3273 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3274 | |
| 3275 | ASSERT_FALSE(pool_->HasGroup("a")); |
| 3276 | |
| 3277 | pool_->RequestSockets("a", ¶ms_, kDefaultMaxSockets - 1, |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3278 | NetLogWithSource(), HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3279 | |
| 3280 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3281 | EXPECT_EQ(kDefaultMaxSockets - 1, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3282 | EXPECT_EQ(kDefaultMaxSockets - 1, |
| 3283 | pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 3284 | EXPECT_FALSE(pool_->IsStalled()); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3285 | |
| 3286 | ASSERT_FALSE(pool_->HasGroup("b")); |
| 3287 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3288 | pool_->RequestSockets("b", ¶ms_, kDefaultMaxSockets, NetLogWithSource(), |
| 3289 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3290 | |
| 3291 | ASSERT_TRUE(pool_->HasGroup("b")); |
| 3292 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("b")); |
[email protected] | 51fdc7c | 2012-04-10 19:19:48 | [diff] [blame] | 3293 | EXPECT_FALSE(pool_->IsStalled()); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3294 | } |
| 3295 | |
| 3296 | TEST_F(ClientSocketPoolBaseTest, RequestSocketsCountIdleSockets) { |
| 3297 | CreatePool(4, 4); |
| 3298 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3299 | |
| 3300 | ClientSocketHandle handle1; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3301 | TestCompletionCallback callback1; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3302 | EXPECT_EQ( |
| 3303 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3304 | handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3305 | ClientSocketPool::RespectLimits::ENABLED, |
| 3306 | callback1.callback(), pool_.get(), NetLogWithSource())); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3307 | ASSERT_THAT(callback1.WaitForResult(), IsOk()); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3308 | handle1.Reset(); |
| 3309 | |
| 3310 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3311 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3312 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3313 | EXPECT_EQ(1, pool_->IdleSocketCountInGroup("a")); |
| 3314 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3315 | pool_->RequestSockets("a", ¶ms_, 2, NetLogWithSource(), |
| 3316 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3317 | |
| 3318 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3319 | EXPECT_EQ(1, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3320 | EXPECT_EQ(1, pool_->IdleSocketCountInGroup("a")); |
| 3321 | } |
| 3322 | |
| 3323 | TEST_F(ClientSocketPoolBaseTest, RequestSocketsCountActiveSockets) { |
| 3324 | CreatePool(4, 4); |
| 3325 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3326 | |
| 3327 | ClientSocketHandle handle1; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3328 | TestCompletionCallback callback1; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3329 | EXPECT_EQ( |
| 3330 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3331 | handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3332 | ClientSocketPool::RespectLimits::ENABLED, |
| 3333 | callback1.callback(), pool_.get(), NetLogWithSource())); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3334 | ASSERT_THAT(callback1.WaitForResult(), IsOk()); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3335 | |
| 3336 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3337 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3338 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3339 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3340 | EXPECT_EQ(1, pool_->NumActiveSocketsInGroup("a")); |
| 3341 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3342 | pool_->RequestSockets("a", ¶ms_, 2, NetLogWithSource(), |
| 3343 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3344 | |
| 3345 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3346 | EXPECT_EQ(1, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3347 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3348 | EXPECT_EQ(1, pool_->NumActiveSocketsInGroup("a")); |
| 3349 | } |
| 3350 | |
| 3351 | TEST_F(ClientSocketPoolBaseTest, RequestSocketsSynchronous) { |
| 3352 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 3353 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
| 3354 | |
| 3355 | pool_->RequestSockets("a", ¶ms_, kDefaultMaxSocketsPerGroup, |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3356 | NetLogWithSource(), HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3357 | |
| 3358 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3359 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3360 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3361 | EXPECT_EQ(kDefaultMaxSocketsPerGroup, pool_->IdleSocketCountInGroup("a")); |
| 3362 | |
| 3363 | pool_->RequestSockets("b", ¶ms_, kDefaultMaxSocketsPerGroup, |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3364 | NetLogWithSource(), HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3365 | |
| 3366 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("b")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3367 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("b")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3368 | EXPECT_EQ(kDefaultMaxSocketsPerGroup, pool_->IdleSocketCountInGroup("b")); |
| 3369 | } |
| 3370 | |
[email protected] | 3c819f52 | 2010-12-02 02:03:12 | [diff] [blame] | 3371 | TEST_F(ClientSocketPoolBaseTest, RequestSocketsSynchronousError) { |
| 3372 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 3373 | connect_job_factory_->set_job_type(TestConnectJob::kMockFailingJob); |
| 3374 | |
| 3375 | pool_->RequestSockets("a", ¶ms_, kDefaultMaxSocketsPerGroup, |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3376 | NetLogWithSource(), HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 3c819f52 | 2010-12-02 02:03:12 | [diff] [blame] | 3377 | |
| 3378 | ASSERT_FALSE(pool_->HasGroup("a")); |
[email protected] | fd2e53e | 2011-01-14 20:40:52 | [diff] [blame] | 3379 | |
| 3380 | connect_job_factory_->set_job_type( |
| 3381 | TestConnectJob::kMockAdditionalErrorStateJob); |
| 3382 | pool_->RequestSockets("a", ¶ms_, kDefaultMaxSocketsPerGroup, |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3383 | NetLogWithSource(), HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | fd2e53e | 2011-01-14 20:40:52 | [diff] [blame] | 3384 | |
| 3385 | ASSERT_FALSE(pool_->HasGroup("a")); |
[email protected] | 3c819f52 | 2010-12-02 02:03:12 | [diff] [blame] | 3386 | } |
| 3387 | |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3388 | TEST_F(ClientSocketPoolBaseTest, RequestSocketsMultipleTimesDoesNothing) { |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3389 | CreatePool(4, 4); |
| 3390 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3391 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3392 | pool_->RequestSockets("a", ¶ms_, 2, NetLogWithSource(), |
| 3393 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3394 | |
| 3395 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3396 | EXPECT_EQ(2, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3397 | EXPECT_EQ(2, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3398 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3399 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3400 | pool_->RequestSockets("a", ¶ms_, 2, NetLogWithSource(), |
| 3401 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3402 | EXPECT_EQ(2, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3403 | EXPECT_EQ(2, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3404 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3405 | |
| 3406 | ClientSocketHandle handle1; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3407 | TestCompletionCallback callback1; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3408 | EXPECT_EQ( |
| 3409 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3410 | handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3411 | ClientSocketPool::RespectLimits::ENABLED, |
| 3412 | callback1.callback(), pool_.get(), NetLogWithSource())); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3413 | ASSERT_THAT(callback1.WaitForResult(), IsOk()); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3414 | |
| 3415 | ClientSocketHandle handle2; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3416 | TestCompletionCallback callback2; |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3417 | int rv = handle2.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 3418 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3419 | callback2.callback(), pool_.get(), NetLogWithSource()); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3420 | if (rv != OK) { |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3421 | EXPECT_THAT(rv, IsError(ERR_IO_PENDING)); |
| 3422 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3423 | } |
| 3424 | |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3425 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 3426 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
| 3427 | EXPECT_EQ(2, pool_->NumActiveSocketsInGroup("a")); |
| 3428 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3429 | |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3430 | handle1.Reset(); |
| 3431 | handle2.Reset(); |
| 3432 | |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3433 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 3434 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3435 | EXPECT_EQ(2, pool_->IdleSocketCountInGroup("a")); |
| 3436 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3437 | pool_->RequestSockets("a", ¶ms_, 2, NetLogWithSource(), |
| 3438 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3439 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3440 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3441 | EXPECT_EQ(2, pool_->IdleSocketCountInGroup("a")); |
| 3442 | } |
| 3443 | |
| 3444 | TEST_F(ClientSocketPoolBaseTest, RequestSocketsDifferentNumSockets) { |
| 3445 | CreatePool(4, 4); |
| 3446 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3447 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3448 | pool_->RequestSockets("a", ¶ms_, 1, NetLogWithSource(), |
| 3449 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3450 | |
| 3451 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3452 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3453 | EXPECT_EQ(1, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3454 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3455 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3456 | pool_->RequestSockets("a", ¶ms_, 2, NetLogWithSource(), |
| 3457 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3458 | EXPECT_EQ(2, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3459 | EXPECT_EQ(2, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3460 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3461 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3462 | pool_->RequestSockets("a", ¶ms_, 3, NetLogWithSource(), |
| 3463 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3464 | EXPECT_EQ(3, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3465 | EXPECT_EQ(3, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3466 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3467 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3468 | pool_->RequestSockets("a", ¶ms_, 1, NetLogWithSource(), |
| 3469 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3470 | EXPECT_EQ(3, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3471 | EXPECT_EQ(3, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3472 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3473 | } |
| 3474 | |
| 3475 | TEST_F(ClientSocketPoolBaseTest, PreconnectJobsTakenByNormalRequests) { |
| 3476 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 3477 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3478 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3479 | pool_->RequestSockets("a", ¶ms_, 1, NetLogWithSource(), |
| 3480 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3481 | |
| 3482 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3483 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3484 | EXPECT_EQ(1, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3485 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3486 | |
| 3487 | ClientSocketHandle handle1; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3488 | TestCompletionCallback callback1; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3489 | EXPECT_EQ( |
| 3490 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3491 | handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3492 | ClientSocketPool::RespectLimits::ENABLED, |
| 3493 | callback1.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3494 | |
| 3495 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3496 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3497 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3498 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3499 | ASSERT_THAT(callback1.WaitForResult(), IsOk()); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3500 | |
[email protected] | 0dc88b3 | 2014-03-26 20:12:28 | [diff] [blame] | 3501 | // Make sure if a preconnected socket is not fully connected when a request |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 3502 | // starts, it has a connect start time. |
| 3503 | TestLoadTimingInfoConnectedNotReused(handle1); |
[email protected] | 2c2bef15 | 2010-10-13 00:55:03 | [diff] [blame] | 3504 | handle1.Reset(); |
| 3505 | |
| 3506 | EXPECT_EQ(1, pool_->IdleSocketCountInGroup("a")); |
| 3507 | } |
| 3508 | |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 3509 | // Checks that fully connected preconnect jobs have no connect times, and are |
| 3510 | // marked as reused. |
| 3511 | TEST_F(ClientSocketPoolBaseTest, ConnectedPreconnectJobsHaveNoConnectTimes) { |
| 3512 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 3513 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3514 | pool_->RequestSockets("a", ¶ms_, 1, NetLogWithSource(), |
| 3515 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 3516 | |
| 3517 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3518 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 3519 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
| 3520 | EXPECT_EQ(1, pool_->IdleSocketCountInGroup("a")); |
| 3521 | |
| 3522 | ClientSocketHandle handle; |
| 3523 | TestCompletionCallback callback; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3524 | EXPECT_EQ(OK, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3525 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3526 | ClientSocketPool::RespectLimits::ENABLED, |
| 3527 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 034df0f3 | 2013-01-07 23:17:48 | [diff] [blame] | 3528 | |
| 3529 | // Make sure the idle socket was used. |
| 3530 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3531 | |
| 3532 | TestLoadTimingInfoConnectedReused(handle); |
| 3533 | handle.Reset(); |
| 3534 | TestLoadTimingInfoNotConnected(handle); |
| 3535 | } |
| 3536 | |
[email protected] | dcbe168a | 2010-12-02 03:14:46 | [diff] [blame] | 3537 | // http://crbug.com/64940 regression test. |
| 3538 | TEST_F(ClientSocketPoolBaseTest, PreconnectClosesIdleSocketRemovesGroup) { |
| 3539 | const int kMaxTotalSockets = 3; |
| 3540 | const int kMaxSocketsPerGroup = 2; |
| 3541 | CreatePool(kMaxTotalSockets, kMaxSocketsPerGroup); |
| 3542 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3543 | |
| 3544 | // Note that group name ordering matters here. "a" comes before "b", so |
| 3545 | // CloseOneIdleSocket() will try to close "a"'s idle socket. |
| 3546 | |
| 3547 | // Set up one idle socket in "a". |
| 3548 | ClientSocketHandle handle1; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3549 | TestCompletionCallback callback1; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3550 | EXPECT_EQ( |
| 3551 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3552 | handle1.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3553 | ClientSocketPool::RespectLimits::ENABLED, |
| 3554 | callback1.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | dcbe168a | 2010-12-02 03:14:46 | [diff] [blame] | 3555 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3556 | ASSERT_THAT(callback1.WaitForResult(), IsOk()); |
[email protected] | dcbe168a | 2010-12-02 03:14:46 | [diff] [blame] | 3557 | handle1.Reset(); |
| 3558 | EXPECT_EQ(1, pool_->IdleSocketCountInGroup("a")); |
| 3559 | |
| 3560 | // Set up two active sockets in "b". |
| 3561 | ClientSocketHandle handle2; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3562 | TestCompletionCallback callback2; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3563 | EXPECT_EQ( |
| 3564 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3565 | handle1.Init("b", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3566 | ClientSocketPool::RespectLimits::ENABLED, |
| 3567 | callback1.callback(), pool_.get(), NetLogWithSource())); |
| 3568 | EXPECT_EQ( |
| 3569 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3570 | handle2.Init("b", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3571 | ClientSocketPool::RespectLimits::ENABLED, |
| 3572 | callback2.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | dcbe168a | 2010-12-02 03:14:46 | [diff] [blame] | 3573 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3574 | ASSERT_THAT(callback1.WaitForResult(), IsOk()); |
| 3575 | ASSERT_THAT(callback2.WaitForResult(), IsOk()); |
[email protected] | dcbe168a | 2010-12-02 03:14:46 | [diff] [blame] | 3576 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("b")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3577 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("b")); |
[email protected] | dcbe168a | 2010-12-02 03:14:46 | [diff] [blame] | 3578 | EXPECT_EQ(2, pool_->NumActiveSocketsInGroup("b")); |
| 3579 | |
| 3580 | // Now we have 1 idle socket in "a" and 2 active sockets in "b". This means |
| 3581 | // we've maxed out on sockets, since we set |kMaxTotalSockets| to 3. |
| 3582 | // Requesting 2 preconnected sockets for "a" should fail to allocate any more |
| 3583 | // sockets for "a", and "b" should still have 2 active sockets. |
| 3584 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3585 | pool_->RequestSockets("a", ¶ms_, 2, NetLogWithSource(), |
| 3586 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | dcbe168a | 2010-12-02 03:14:46 | [diff] [blame] | 3587 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3588 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | dcbe168a | 2010-12-02 03:14:46 | [diff] [blame] | 3589 | EXPECT_EQ(1, pool_->IdleSocketCountInGroup("a")); |
| 3590 | EXPECT_EQ(0, pool_->NumActiveSocketsInGroup("a")); |
| 3591 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("b")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3592 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("b")); |
[email protected] | dcbe168a | 2010-12-02 03:14:46 | [diff] [blame] | 3593 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("b")); |
| 3594 | EXPECT_EQ(2, pool_->NumActiveSocketsInGroup("b")); |
| 3595 | |
| 3596 | // Now release the 2 active sockets for "b". This will give us 1 idle socket |
| 3597 | // in "a" and 2 idle sockets in "b". Requesting 2 preconnected sockets for |
| 3598 | // "a" should result in closing 1 for "b". |
| 3599 | handle1.Reset(); |
| 3600 | handle2.Reset(); |
| 3601 | EXPECT_EQ(2, pool_->IdleSocketCountInGroup("b")); |
| 3602 | EXPECT_EQ(0, pool_->NumActiveSocketsInGroup("b")); |
| 3603 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3604 | pool_->RequestSockets("a", ¶ms_, 2, NetLogWithSource(), |
| 3605 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | dcbe168a | 2010-12-02 03:14:46 | [diff] [blame] | 3606 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3607 | EXPECT_EQ(1, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | dcbe168a | 2010-12-02 03:14:46 | [diff] [blame] | 3608 | EXPECT_EQ(1, pool_->IdleSocketCountInGroup("a")); |
| 3609 | EXPECT_EQ(0, pool_->NumActiveSocketsInGroup("a")); |
| 3610 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("b")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3611 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("b")); |
[email protected] | dcbe168a | 2010-12-02 03:14:46 | [diff] [blame] | 3612 | EXPECT_EQ(1, pool_->IdleSocketCountInGroup("b")); |
| 3613 | EXPECT_EQ(0, pool_->NumActiveSocketsInGroup("b")); |
| 3614 | } |
| 3615 | |
[email protected] | b7b8be4 | 2011-07-12 12:46:41 | [diff] [blame] | 3616 | TEST_F(ClientSocketPoolBaseTest, PreconnectWithoutBackupJob) { |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3617 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 3618 | pool_->EnableConnectBackupJobs(); |
| 3619 | |
| 3620 | // Make the ConnectJob hang until it times out, shorten the timeout. |
| 3621 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
| 3622 | connect_job_factory_->set_timeout_duration( |
| 3623 | base::TimeDelta::FromMilliseconds(500)); |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3624 | pool_->RequestSockets("a", ¶ms_, 1, NetLogWithSource(), |
| 3625 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3626 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3627 | EXPECT_EQ(1, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3628 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3629 | |
[email protected] | b7b8be4 | 2011-07-12 12:46:41 | [diff] [blame] | 3630 | // Verify the backup timer doesn't create a backup job, by making |
| 3631 | // the backup job a pending job instead of a waiting job, so it |
| 3632 | // *would* complete if it were created. |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3633 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
skyostil | 4891b25b | 2015-06-11 11:43:45 | [diff] [blame] | 3634 | base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( |
ki.stfu | 375812e | 2015-10-09 20:23:17 | [diff] [blame] | 3635 | FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(), |
[email protected] | 2da659e | 2013-05-23 20:51:34 | [diff] [blame] | 3636 | base::TimeDelta::FromSeconds(1)); |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 3637 | base::RunLoop().Run(); |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3638 | EXPECT_FALSE(pool_->HasGroup("a")); |
| 3639 | } |
| 3640 | |
[email protected] | b7b8be4 | 2011-07-12 12:46:41 | [diff] [blame] | 3641 | TEST_F(ClientSocketPoolBaseTest, PreconnectWithBackupJob) { |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3642 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 3643 | pool_->EnableConnectBackupJobs(); |
| 3644 | |
| 3645 | // Make the ConnectJob hang forever. |
| 3646 | connect_job_factory_->set_job_type(TestConnectJob::kMockWaitingJob); |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3647 | pool_->RequestSockets("a", ¶ms_, 1, NetLogWithSource(), |
| 3648 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3649 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3650 | EXPECT_EQ(1, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3651 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
fdoray | 5eeb764 | 2016-06-22 16:11:28 | [diff] [blame] | 3652 | base::RunLoop().RunUntilIdle(); |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3653 | |
| 3654 | // Make the backup job be a pending job, so it completes normally. |
| 3655 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3656 | ClientSocketHandle handle; |
[email protected] | 6ecf2b9 | 2011-12-15 01:14:52 | [diff] [blame] | 3657 | TestCompletionCallback callback; |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 3658 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3659 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 3660 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3661 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | b7b8be4 | 2011-07-12 12:46:41 | [diff] [blame] | 3662 | // Timer has started, but the backup connect job shouldn't be created yet. |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3663 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3664 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3665 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3666 | EXPECT_EQ(0, pool_->NumActiveSocketsInGroup("a")); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3667 | ASSERT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3668 | |
| 3669 | // The hung connect job should still be there, but everything else should be |
| 3670 | // complete. |
| 3671 | EXPECT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
[email protected] | 8159a1c | 2012-06-07 00:00:10 | [diff] [blame] | 3672 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
[email protected] | a9fc8fc | 2011-05-10 02:41:07 | [diff] [blame] | 3673 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3674 | EXPECT_EQ(1, pool_->NumActiveSocketsInGroup("a")); |
| 3675 | } |
| 3676 | |
[email protected] | 0dc88b3 | 2014-03-26 20:12:28 | [diff] [blame] | 3677 | // Tests that a preconnect that starts out with unread data can still be used. |
| 3678 | // http://crbug.com/334467 |
| 3679 | TEST_F(ClientSocketPoolBaseTest, PreconnectWithUnreadData) { |
| 3680 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 3681 | connect_job_factory_->set_job_type(TestConnectJob::kMockUnreadDataJob); |
| 3682 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3683 | pool_->RequestSockets("a", ¶ms_, 1, NetLogWithSource(), |
| 3684 | HttpRequestInfo::NORMAL_MOTIVATION); |
[email protected] | 0dc88b3 | 2014-03-26 20:12:28 | [diff] [blame] | 3685 | |
| 3686 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3687 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 3688 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
| 3689 | EXPECT_EQ(1, pool_->IdleSocketCountInGroup("a")); |
| 3690 | |
| 3691 | // Fail future jobs to be sure that handle receives the preconnected socket |
| 3692 | // rather than closing it and making a new one. |
| 3693 | connect_job_factory_->set_job_type(TestConnectJob::kMockFailingJob); |
| 3694 | ClientSocketHandle handle; |
| 3695 | TestCompletionCallback callback; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3696 | EXPECT_EQ(OK, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3697 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3698 | ClientSocketPool::RespectLimits::ENABLED, |
| 3699 | callback.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 0dc88b3 | 2014-03-26 20:12:28 | [diff] [blame] | 3700 | |
| 3701 | ASSERT_TRUE(pool_->HasGroup("a")); |
| 3702 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 3703 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
| 3704 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3705 | |
| 3706 | // Drain the pending read. |
| 3707 | EXPECT_EQ(1, handle.socket()->Read(NULL, 1, CompletionCallback())); |
| 3708 | |
| 3709 | TestLoadTimingInfoConnectedReused(handle); |
| 3710 | handle.Reset(); |
| 3711 | |
| 3712 | // The socket should be usable now that it's idle again. |
| 3713 | EXPECT_EQ(1, pool_->IdleSocketCountInGroup("a")); |
| 3714 | } |
| 3715 | |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3716 | // Tests that a socket pool correctly sets a motivation for a preconnected |
| 3717 | // socket. |
| 3718 | TEST_F(ClientSocketPoolBaseTest, PreconnectSetsMotivation) { |
| 3719 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 3720 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3721 | |
| 3722 | for (auto motivation : {HttpRequestInfo::NORMAL_MOTIVATION, |
| 3723 | HttpRequestInfo::PRECONNECT_MOTIVATED, |
| 3724 | HttpRequestInfo::OMNIBOX_MOTIVATED}) { |
| 3725 | SCOPED_TRACE(::testing::Message() << "motivation: " << motivation); |
| 3726 | pool_->RequestSockets("a", ¶ms_, 1, NetLogWithSource(), motivation); |
| 3727 | |
| 3728 | ClientSocketHandle handle; |
| 3729 | TestCompletionCallback callback; |
| 3730 | EXPECT_EQ( |
| 3731 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3732 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3733 | ClientSocketPool::RespectLimits::ENABLED, |
| 3734 | callback.callback(), pool_.get(), NetLogWithSource())); |
| 3735 | |
| 3736 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
| 3737 | EXPECT_TRUE(handle.is_initialized()); |
| 3738 | ASSERT_TRUE(handle.socket()); |
| 3739 | EXPECT_EQ(motivation, |
| 3740 | static_cast<MockClientSocket*>(handle.socket())->motivation()); |
| 3741 | handle.socket()->Disconnect(); |
| 3742 | handle.Reset(); |
| 3743 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 3744 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
| 3745 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3746 | } |
| 3747 | } |
| 3748 | |
| 3749 | // Tests that a socket pool doesn't change motivation on existing sockets. |
| 3750 | TEST_F(ClientSocketPoolBaseTest, PreconnectPreservesExistingMotivation) { |
| 3751 | CreatePool(3, 3); |
| 3752 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 3753 | |
| 3754 | // We should get one socket of each motivation. |
| 3755 | pool_->RequestSockets("a", ¶ms_, 1, NetLogWithSource(), |
| 3756 | HttpRequestInfo::NORMAL_MOTIVATION); |
| 3757 | pool_->RequestSockets("a", ¶ms_, 2, NetLogWithSource(), |
| 3758 | HttpRequestInfo::PRECONNECT_MOTIVATED); |
| 3759 | pool_->RequestSockets("a", ¶ms_, 3, NetLogWithSource(), |
| 3760 | HttpRequestInfo::OMNIBOX_MOTIVATED); |
| 3761 | |
| 3762 | EXPECT_EQ(3, pool_->NumConnectJobsInGroup("a")); |
| 3763 | EXPECT_EQ(3, pool_->NumUnassignedConnectJobsInGroup("a")); |
| 3764 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3765 | |
| 3766 | std::vector<ClientSocketHandle> handles(3); |
| 3767 | std::vector<TestCompletionCallback> callbacks(3); |
| 3768 | |
| 3769 | for (size_t i = 0; i < 3; ++i) { |
| 3770 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3771 | handles[i].Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
Alexandr Ilin | 65ec958 | 2017-10-02 14:50:31 | [diff] [blame] | 3772 | ClientSocketPool::RespectLimits::ENABLED, |
| 3773 | callbacks[i].callback(), pool_.get(), |
| 3774 | NetLogWithSource())); |
| 3775 | } |
| 3776 | |
| 3777 | for (size_t i = 0; i < 3; ++i) { |
| 3778 | EXPECT_THAT(callbacks[i].WaitForResult(), IsOk()); |
| 3779 | EXPECT_TRUE(handles[i].is_initialized()); |
| 3780 | EXPECT_TRUE(handles[i].socket()); |
| 3781 | } |
| 3782 | |
| 3783 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 3784 | EXPECT_EQ(0, pool_->NumUnassignedConnectJobsInGroup("a")); |
| 3785 | EXPECT_EQ(0, pool_->IdleSocketCountInGroup("a")); |
| 3786 | EXPECT_EQ(3, pool_->NumActiveSocketsInGroup("a")); |
| 3787 | |
| 3788 | EXPECT_EQ(HttpRequestInfo::NORMAL_MOTIVATION, |
| 3789 | static_cast<MockClientSocket*>(handles[0].socket())->motivation()); |
| 3790 | EXPECT_EQ(HttpRequestInfo::PRECONNECT_MOTIVATED, |
| 3791 | static_cast<MockClientSocket*>(handles[1].socket())->motivation()); |
| 3792 | EXPECT_EQ(HttpRequestInfo::OMNIBOX_MOTIVATED, |
| 3793 | static_cast<MockClientSocket*>(handles[2].socket())->motivation()); |
| 3794 | } |
| 3795 | |
[email protected] | 043b68c8 | 2013-08-22 23:41:52 | [diff] [blame] | 3796 | class MockLayeredPool : public HigherLayeredPool { |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3797 | public: |
| 3798 | MockLayeredPool(TestClientSocketPool* pool, |
| 3799 | const std::string& group_name) |
| 3800 | : pool_(pool), |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3801 | group_name_(group_name), |
| 3802 | can_release_connection_(true) { |
[email protected] | 043b68c8 | 2013-08-22 23:41:52 | [diff] [blame] | 3803 | pool_->AddHigherLayeredPool(this); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3804 | } |
| 3805 | |
| 3806 | ~MockLayeredPool() { |
[email protected] | 043b68c8 | 2013-08-22 23:41:52 | [diff] [blame] | 3807 | pool_->RemoveHigherLayeredPool(this); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3808 | } |
| 3809 | |
| 3810 | int RequestSocket(TestClientSocketPool* pool) { |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 3811 | scoped_refptr<TestSocketParams> params(new TestSocketParams()); |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3812 | return handle_.Init(group_name_, params, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 3813 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3814 | callback_.callback(), pool, NetLogWithSource()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3815 | } |
| 3816 | |
| 3817 | int RequestSocketWithoutLimits(TestClientSocketPool* pool) { |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 3818 | scoped_refptr<TestSocketParams> params(new TestSocketParams()); |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3819 | return handle_.Init(group_name_, params, MAXIMUM_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 3820 | ClientSocketPool::RespectLimits::DISABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3821 | callback_.callback(), pool, NetLogWithSource()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3822 | } |
| 3823 | |
| 3824 | bool ReleaseOneConnection() { |
| 3825 | if (!handle_.is_initialized() || !can_release_connection_) { |
| 3826 | return false; |
| 3827 | } |
| 3828 | handle_.socket()->Disconnect(); |
| 3829 | handle_.Reset(); |
| 3830 | return true; |
| 3831 | } |
| 3832 | |
| 3833 | void set_can_release_connection(bool can_release_connection) { |
| 3834 | can_release_connection_ = can_release_connection; |
| 3835 | } |
| 3836 | |
| 3837 | MOCK_METHOD0(CloseOneIdleConnection, bool()); |
| 3838 | |
| 3839 | private: |
| 3840 | TestClientSocketPool* const pool_; |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3841 | ClientSocketHandle handle_; |
| 3842 | TestCompletionCallback callback_; |
| 3843 | const std::string group_name_; |
| 3844 | bool can_release_connection_; |
| 3845 | }; |
| 3846 | |
| 3847 | TEST_F(ClientSocketPoolBaseTest, FailToCloseIdleSocketsNotHeldByLayeredPool) { |
| 3848 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 3849 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
| 3850 | |
| 3851 | MockLayeredPool mock_layered_pool(pool_.get(), "foo"); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3852 | EXPECT_THAT(mock_layered_pool.RequestSocket(pool_.get()), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3853 | EXPECT_CALL(mock_layered_pool, CloseOneIdleConnection()) |
| 3854 | .WillOnce(Return(false)); |
[email protected] | 043b68c8 | 2013-08-22 23:41:52 | [diff] [blame] | 3855 | EXPECT_FALSE(pool_->CloseOneIdleConnectionInHigherLayeredPool()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3856 | } |
| 3857 | |
| 3858 | TEST_F(ClientSocketPoolBaseTest, ForciblyCloseIdleSocketsHeldByLayeredPool) { |
| 3859 | CreatePool(kDefaultMaxSockets, kDefaultMaxSocketsPerGroup); |
| 3860 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
| 3861 | |
| 3862 | MockLayeredPool mock_layered_pool(pool_.get(), "foo"); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3863 | EXPECT_THAT(mock_layered_pool.RequestSocket(pool_.get()), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3864 | EXPECT_CALL(mock_layered_pool, CloseOneIdleConnection()) |
| 3865 | .WillOnce(Invoke(&mock_layered_pool, |
| 3866 | &MockLayeredPool::ReleaseOneConnection)); |
[email protected] | 043b68c8 | 2013-08-22 23:41:52 | [diff] [blame] | 3867 | EXPECT_TRUE(pool_->CloseOneIdleConnectionInHigherLayeredPool()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3868 | } |
| 3869 | |
| 3870 | // Tests the basic case of closing an idle socket in a higher layered pool when |
| 3871 | // a new request is issued and the lower layer pool is stalled. |
| 3872 | TEST_F(ClientSocketPoolBaseTest, CloseIdleSocketsHeldByLayeredPoolWhenNeeded) { |
| 3873 | CreatePool(1, 1); |
| 3874 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
| 3875 | |
| 3876 | MockLayeredPool mock_layered_pool(pool_.get(), "foo"); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3877 | EXPECT_THAT(mock_layered_pool.RequestSocket(pool_.get()), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3878 | EXPECT_CALL(mock_layered_pool, CloseOneIdleConnection()) |
| 3879 | .WillOnce(Invoke(&mock_layered_pool, |
| 3880 | &MockLayeredPool::ReleaseOneConnection)); |
| 3881 | ClientSocketHandle handle; |
| 3882 | TestCompletionCallback callback; |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 3883 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3884 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 3885 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3886 | callback.callback(), pool_.get(), NetLogWithSource())); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3887 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3888 | } |
| 3889 | |
| 3890 | // Same as above, but the idle socket is in the same group as the stalled |
| 3891 | // socket, and closes the only other request in its group when closing requests |
| 3892 | // in higher layered pools. This generally shouldn't happen, but it may be |
| 3893 | // possible if a higher level pool issues a request and the request is |
| 3894 | // subsequently cancelled. Even if it's not possible, best not to crash. |
| 3895 | TEST_F(ClientSocketPoolBaseTest, |
| 3896 | CloseIdleSocketsHeldByLayeredPoolWhenNeededSameGroup) { |
| 3897 | CreatePool(2, 2); |
| 3898 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
| 3899 | |
| 3900 | // Need a socket in another group for the pool to be stalled (If a group |
| 3901 | // has the maximum number of connections already, it's not stalled). |
| 3902 | ClientSocketHandle handle1; |
| 3903 | TestCompletionCallback callback1; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3904 | EXPECT_EQ( |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3905 | OK, handle1.Init("group1", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3906 | ClientSocketPool::RespectLimits::ENABLED, |
| 3907 | callback1.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3908 | |
| 3909 | MockLayeredPool mock_layered_pool(pool_.get(), "group2"); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3910 | EXPECT_THAT(mock_layered_pool.RequestSocket(pool_.get()), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3911 | EXPECT_CALL(mock_layered_pool, CloseOneIdleConnection()) |
| 3912 | .WillOnce(Invoke(&mock_layered_pool, |
| 3913 | &MockLayeredPool::ReleaseOneConnection)); |
| 3914 | ClientSocketHandle handle; |
| 3915 | TestCompletionCallback callback2; |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 3916 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3917 | handle.Init("group2", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 3918 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3919 | callback2.callback(), pool_.get(), NetLogWithSource())); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3920 | EXPECT_THAT(callback2.WaitForResult(), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3921 | } |
| 3922 | |
| 3923 | // Tests the case when an idle socket can be closed when a new request is |
| 3924 | // issued, and the new request belongs to a group that was previously stalled. |
| 3925 | TEST_F(ClientSocketPoolBaseTest, |
| 3926 | CloseIdleSocketsHeldByLayeredPoolInSameGroupWhenNeeded) { |
| 3927 | CreatePool(2, 2); |
| 3928 | std::list<TestConnectJob::JobType> job_types; |
| 3929 | job_types.push_back(TestConnectJob::kMockJob); |
| 3930 | job_types.push_back(TestConnectJob::kMockJob); |
| 3931 | job_types.push_back(TestConnectJob::kMockJob); |
| 3932 | job_types.push_back(TestConnectJob::kMockJob); |
| 3933 | connect_job_factory_->set_job_types(&job_types); |
| 3934 | |
| 3935 | ClientSocketHandle handle1; |
| 3936 | TestCompletionCallback callback1; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3937 | EXPECT_EQ( |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3938 | OK, handle1.Init("group1", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3939 | ClientSocketPool::RespectLimits::ENABLED, |
| 3940 | callback1.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3941 | |
| 3942 | MockLayeredPool mock_layered_pool(pool_.get(), "group2"); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3943 | EXPECT_THAT(mock_layered_pool.RequestSocket(pool_.get()), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3944 | EXPECT_CALL(mock_layered_pool, CloseOneIdleConnection()) |
| 3945 | .WillRepeatedly(Invoke(&mock_layered_pool, |
| 3946 | &MockLayeredPool::ReleaseOneConnection)); |
| 3947 | mock_layered_pool.set_can_release_connection(false); |
| 3948 | |
| 3949 | // The third request is made when the socket pool is in a stalled state. |
| 3950 | ClientSocketHandle handle3; |
| 3951 | TestCompletionCallback callback3; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3952 | EXPECT_EQ( |
| 3953 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3954 | handle3.Init("group3", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3955 | ClientSocketPool::RespectLimits::ENABLED, |
| 3956 | callback3.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3957 | |
| 3958 | base::RunLoop().RunUntilIdle(); |
| 3959 | EXPECT_FALSE(callback3.have_result()); |
| 3960 | |
| 3961 | // The fourth request is made when the pool is no longer stalled. The third |
| 3962 | // request should be serviced first, since it was issued first and has the |
| 3963 | // same priority. |
| 3964 | mock_layered_pool.set_can_release_connection(true); |
| 3965 | ClientSocketHandle handle4; |
| 3966 | TestCompletionCallback callback4; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3967 | EXPECT_EQ( |
| 3968 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3969 | handle4.Init("group3", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3970 | ClientSocketPool::RespectLimits::ENABLED, |
| 3971 | callback4.callback(), pool_.get(), NetLogWithSource())); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3972 | EXPECT_THAT(callback3.WaitForResult(), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3973 | EXPECT_FALSE(callback4.have_result()); |
| 3974 | |
| 3975 | // Closing a handle should free up another socket slot. |
| 3976 | handle1.Reset(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 3977 | EXPECT_THAT(callback4.WaitForResult(), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 3978 | } |
| 3979 | |
| 3980 | // Tests the case when an idle socket can be closed when a new request is |
| 3981 | // issued, and the new request belongs to a group that was previously stalled. |
| 3982 | // |
| 3983 | // The two differences from the above test are that the stalled requests are not |
| 3984 | // in the same group as the layered pool's request, and the the fourth request |
| 3985 | // has a higher priority than the third one, so gets a socket first. |
| 3986 | TEST_F(ClientSocketPoolBaseTest, |
| 3987 | CloseIdleSocketsHeldByLayeredPoolInSameGroupWhenNeeded2) { |
| 3988 | CreatePool(2, 2); |
| 3989 | std::list<TestConnectJob::JobType> job_types; |
| 3990 | job_types.push_back(TestConnectJob::kMockJob); |
| 3991 | job_types.push_back(TestConnectJob::kMockJob); |
| 3992 | job_types.push_back(TestConnectJob::kMockJob); |
| 3993 | job_types.push_back(TestConnectJob::kMockJob); |
| 3994 | connect_job_factory_->set_job_types(&job_types); |
| 3995 | |
| 3996 | ClientSocketHandle handle1; |
| 3997 | TestCompletionCallback callback1; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 3998 | EXPECT_EQ( |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 3999 | OK, handle1.Init("group1", params_, DEFAULT_PRIORITY, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 4000 | ClientSocketPool::RespectLimits::ENABLED, |
| 4001 | callback1.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 4002 | |
| 4003 | MockLayeredPool mock_layered_pool(pool_.get(), "group2"); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4004 | EXPECT_THAT(mock_layered_pool.RequestSocket(pool_.get()), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 4005 | EXPECT_CALL(mock_layered_pool, CloseOneIdleConnection()) |
| 4006 | .WillRepeatedly(Invoke(&mock_layered_pool, |
| 4007 | &MockLayeredPool::ReleaseOneConnection)); |
| 4008 | mock_layered_pool.set_can_release_connection(false); |
| 4009 | |
| 4010 | // The third request is made when the socket pool is in a stalled state. |
| 4011 | ClientSocketHandle handle3; |
| 4012 | TestCompletionCallback callback3; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 4013 | EXPECT_EQ( |
| 4014 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 4015 | handle3.Init("group3", params_, MEDIUM, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 4016 | ClientSocketPool::RespectLimits::ENABLED, |
| 4017 | callback3.callback(), pool_.get(), NetLogWithSource())); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 4018 | |
| 4019 | base::RunLoop().RunUntilIdle(); |
| 4020 | EXPECT_FALSE(callback3.have_result()); |
| 4021 | |
| 4022 | // The fourth request is made when the pool is no longer stalled. This |
| 4023 | // request has a higher priority than the third request, so is serviced first. |
| 4024 | mock_layered_pool.set_can_release_connection(true); |
| 4025 | ClientSocketHandle handle4; |
| 4026 | TestCompletionCallback callback4; |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 4027 | EXPECT_EQ( |
| 4028 | ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 4029 | handle4.Init("group3", params_, HIGHEST, SocketTag(), |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 4030 | ClientSocketPool::RespectLimits::ENABLED, |
| 4031 | callback4.callback(), pool_.get(), NetLogWithSource())); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4032 | EXPECT_THAT(callback4.WaitForResult(), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 4033 | EXPECT_FALSE(callback3.have_result()); |
| 4034 | |
| 4035 | // Closing a handle should free up another socket slot. |
| 4036 | handle1.Reset(); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4037 | EXPECT_THAT(callback3.WaitForResult(), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 4038 | } |
| 4039 | |
| 4040 | TEST_F(ClientSocketPoolBaseTest, |
| 4041 | CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded) { |
| 4042 | CreatePool(1, 1); |
| 4043 | connect_job_factory_->set_job_type(TestConnectJob::kMockJob); |
| 4044 | |
| 4045 | MockLayeredPool mock_layered_pool1(pool_.get(), "foo"); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4046 | EXPECT_THAT(mock_layered_pool1.RequestSocket(pool_.get()), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 4047 | EXPECT_CALL(mock_layered_pool1, CloseOneIdleConnection()) |
| 4048 | .WillRepeatedly(Invoke(&mock_layered_pool1, |
| 4049 | &MockLayeredPool::ReleaseOneConnection)); |
| 4050 | MockLayeredPool mock_layered_pool2(pool_.get(), "bar"); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4051 | EXPECT_THAT(mock_layered_pool2.RequestSocketWithoutLimits(pool_.get()), |
| 4052 | IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 4053 | EXPECT_CALL(mock_layered_pool2, CloseOneIdleConnection()) |
| 4054 | .WillRepeatedly(Invoke(&mock_layered_pool2, |
| 4055 | &MockLayeredPool::ReleaseOneConnection)); |
| 4056 | ClientSocketHandle handle; |
| 4057 | TestCompletionCallback callback; |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 4058 | EXPECT_EQ(ERR_IO_PENDING, |
Paul Jensen | 8d6f87ec | 2018-01-13 00:46:54 | [diff] [blame] | 4059 | handle.Init("a", params_, DEFAULT_PRIORITY, SocketTag(), |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 4060 | ClientSocketPool::RespectLimits::ENABLED, |
tfarina | 42834111 | 2016-09-22 13:38:20 | [diff] [blame] | 4061 | callback.callback(), pool_.get(), NetLogWithSource())); |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4062 | EXPECT_THAT(callback.WaitForResult(), IsOk()); |
[email protected] | 58e562f | 2013-04-22 17:32:20 | [diff] [blame] | 4063 | } |
| 4064 | |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 4065 | // Test that when a socket pool and group are at their limits, a request |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 4066 | // with RespectLimits::DISABLED triggers creation of a new socket, and gets the |
| 4067 | // socket instead of a request with the same priority that was issued earlier, |
| 4068 | // but has RespectLimits::ENABLED. |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 4069 | TEST_F(ClientSocketPoolBaseTest, IgnoreLimits) { |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 4070 | CreatePool(1, 1); |
| 4071 | |
| 4072 | // Issue a request to reach the socket pool limit. |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 4073 | EXPECT_EQ( |
| 4074 | OK, StartRequestWithIgnoreLimits( |
| 4075 | "a", MAXIMUM_PRIORITY, ClientSocketPool::RespectLimits::ENABLED)); |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 4076 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 4077 | |
| 4078 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 4079 | |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 4080 | EXPECT_EQ(ERR_IO_PENDING, StartRequestWithIgnoreLimits( |
| 4081 | "a", MAXIMUM_PRIORITY, |
| 4082 | ClientSocketPool::RespectLimits::ENABLED)); |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 4083 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 4084 | |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 4085 | // Issue a request that ignores the limits, so a new ConnectJob is |
| 4086 | // created. |
| 4087 | EXPECT_EQ(ERR_IO_PENDING, StartRequestWithIgnoreLimits( |
| 4088 | "a", MAXIMUM_PRIORITY, |
| 4089 | ClientSocketPool::RespectLimits::DISABLED)); |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 4090 | ASSERT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 4091 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4092 | EXPECT_THAT(request(2)->WaitForResult(), IsOk()); |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 4093 | EXPECT_FALSE(request(1)->have_result()); |
| 4094 | } |
| 4095 | |
[email protected] | c55fabd | 2013-11-04 23:26:56 | [diff] [blame] | 4096 | // Test that when a socket pool and group are at their limits, a ConnectJob |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 4097 | // issued for a request with RespectLimits::DISABLED is not cancelled when a |
| 4098 | // request with RespectLimits::ENABLED issued to the same group is cancelled. |
[email protected] | c55fabd | 2013-11-04 23:26:56 | [diff] [blame] | 4099 | TEST_F(ClientSocketPoolBaseTest, IgnoreLimitsCancelOtherJob) { |
[email protected] | c55fabd | 2013-11-04 23:26:56 | [diff] [blame] | 4100 | CreatePool(1, 1); |
| 4101 | |
| 4102 | // Issue a request to reach the socket pool limit. |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 4103 | EXPECT_EQ( |
| 4104 | OK, StartRequestWithIgnoreLimits( |
| 4105 | "a", MAXIMUM_PRIORITY, ClientSocketPool::RespectLimits::ENABLED)); |
[email protected] | c55fabd | 2013-11-04 23:26:56 | [diff] [blame] | 4106 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 4107 | |
| 4108 | connect_job_factory_->set_job_type(TestConnectJob::kMockPendingJob); |
| 4109 | |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 4110 | EXPECT_EQ(ERR_IO_PENDING, StartRequestWithIgnoreLimits( |
| 4111 | "a", MAXIMUM_PRIORITY, |
| 4112 | ClientSocketPool::RespectLimits::ENABLED)); |
[email protected] | c55fabd | 2013-11-04 23:26:56 | [diff] [blame] | 4113 | EXPECT_EQ(0, pool_->NumConnectJobsInGroup("a")); |
| 4114 | |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 4115 | // Issue a request with RespectLimits::DISABLED, so a new ConnectJob is |
| 4116 | // created. |
| 4117 | EXPECT_EQ(ERR_IO_PENDING, StartRequestWithIgnoreLimits( |
| 4118 | "a", MAXIMUM_PRIORITY, |
| 4119 | ClientSocketPool::RespectLimits::DISABLED)); |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 4120 | ASSERT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 4121 | |
mmenke | d3641e1 | 2016-01-28 16:06:15 | [diff] [blame] | 4122 | // Cancel the pending request with RespectLimits::ENABLED. The ConnectJob |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 4123 | // should not be cancelled. |
| 4124 | request(1)->handle()->Reset(); |
| 4125 | ASSERT_EQ(1, pool_->NumConnectJobsInGroup("a")); |
| 4126 | |
robpercival | 214763f | 2016-07-01 23:27:01 | [diff] [blame] | 4127 | EXPECT_THAT(request(2)->WaitForResult(), IsOk()); |
[email protected] | b021ece6 | 2013-06-11 11:06:33 | [diff] [blame] | 4128 | EXPECT_FALSE(request(1)->have_result()); |
| 4129 | } |
| 4130 | |
[email protected] | f6d1d6eb | 2009-06-24 20:16:09 | [diff] [blame] | 4131 | } // namespace |
| 4132 | |
| 4133 | } // namespace net |